[jira] [Work logged] (TS-4650) cachekey: not thread safe

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4650?focusedWorklogId=31457=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31457
 ]

ASF GitHub Bot logged work on TS-4650:
--

Author: ASF GitHub Bot
Created on: 02/Nov/16 18:35
Start Date: 02/Nov/16 18:35
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1172
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1145/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 31457)
Time Spent: 2h 40m  (was: 2.5h)

> cachekey: not thread safe
> -
>
> Key: TS-4650
> URL: https://issues.apache.org/jira/browse/TS-4650
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Affects Versions: 6.2.0
>Reporter: Felicity Tarnell
>Assignee: Felicity Tarnell
> Fix For: 7.0.0
>
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> cachekey's Pattern class is not thread safe; it uses member data to store the 
> result of pcre_exec(), but only one instance is shared between all threads.  
> This causes crashes when two threads access the pcre result at the same time.
> Fix: use automatic storage for the pcre result data.
> PR incoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4650) cachekey: not thread safe

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4650?focusedWorklogId=31460=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31460
 ]

ASF GitHub Bot logged work on TS-4650:
--

Author: ASF GitHub Bot
Created on: 02/Nov/16 18:37
Start Date: 02/Nov/16 18:37
Worklog Time Spent: 10m 
  Work Description: Github user PSUdaemon closed the pull request at:

https://github.com/apache/trafficserver/pull/1172


Issue Time Tracking
---

Worklog Id: (was: 31460)
Time Spent: 3h  (was: 2h 50m)

> cachekey: not thread safe
> -
>
> Key: TS-4650
> URL: https://issues.apache.org/jira/browse/TS-4650
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Affects Versions: 6.2.0
>Reporter: Felicity Tarnell
>Assignee: Felicity Tarnell
> Fix For: 6.2.1, 7.0.0
>
>  Time Spent: 3h
>  Remaining Estimate: 0h
>
> cachekey's Pattern class is not thread safe; it uses member data to store the 
> result of pcre_exec(), but only one instance is shared between all threads.  
> This causes crashes when two threads access the pcre result at the same time.
> Fix: use automatic storage for the pcre result data.
> PR incoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4650) cachekey: not thread safe

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4650?focusedWorklogId=31459=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31459
 ]

ASF GitHub Bot logged work on TS-4650:
--

Author: ASF GitHub Bot
Created on: 02/Nov/16 18:36
Start Date: 02/Nov/16 18:36
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1172
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1038/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 31459)
Time Spent: 2h 50m  (was: 2h 40m)

> cachekey: not thread safe
> -
>
> Key: TS-4650
> URL: https://issues.apache.org/jira/browse/TS-4650
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Affects Versions: 6.2.0
>Reporter: Felicity Tarnell
>Assignee: Felicity Tarnell
> Fix For: 7.0.0
>
>  Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> cachekey's Pattern class is not thread safe; it uses member data to store the 
> result of pcre_exec(), but only one instance is shared between all threads.  
> This causes crashes when two threads access the pcre result at the same time.
> Fix: use automatic storage for the pcre result data.
> PR incoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4650) cachekey: not thread safe

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4650?focusedWorklogId=31456=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31456
 ]

ASF GitHub Bot logged work on TS-4650:
--

Author: ASF GitHub Bot
Created on: 02/Nov/16 18:31
Start Date: 02/Nov/16 18:31
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1172
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1037/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 31456)
Time Spent: 2.5h  (was: 2h 20m)

> cachekey: not thread safe
> -
>
> Key: TS-4650
> URL: https://issues.apache.org/jira/browse/TS-4650
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Affects Versions: 6.2.0
>Reporter: Felicity Tarnell
>Assignee: Felicity Tarnell
> Fix For: 7.0.0
>
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> cachekey's Pattern class is not thread safe; it uses member data to store the 
> result of pcre_exec(), but only one instance is shared between all threads.  
> This causes crashes when two threads access the pcre result at the same time.
> Fix: use automatic storage for the pcre result data.
> PR incoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4650) cachekey: not thread safe

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4650?focusedWorklogId=31455=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31455
 ]

ASF GitHub Bot logged work on TS-4650:
--

Author: ASF GitHub Bot
Created on: 02/Nov/16 18:30
Start Date: 02/Nov/16 18:30
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1172
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1144/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 31455)
Time Spent: 2h 20m  (was: 2h 10m)

> cachekey: not thread safe
> -
>
> Key: TS-4650
> URL: https://issues.apache.org/jira/browse/TS-4650
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Affects Versions: 6.2.0
>Reporter: Felicity Tarnell
>Assignee: Felicity Tarnell
> Fix For: 7.0.0
>
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> cachekey's Pattern class is not thread safe; it uses member data to store the 
> result of pcre_exec(), but only one instance is shared between all threads.  
> This causes crashes when two threads access the pcre result at the same time.
> Fix: use automatic storage for the pcre result data.
> PR incoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4650) cachekey: not thread safe

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4650?focusedWorklogId=31453=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31453
 ]

ASF GitHub Bot logged work on TS-4650:
--

Author: ASF GitHub Bot
Created on: 02/Nov/16 18:23
Start Date: 02/Nov/16 18:23
Worklog Time Spent: 10m 
  Work Description: Github user PSUdaemon commented on the issue:

https://github.com/apache/trafficserver/pull/1172
  
[approve ci]


Issue Time Tracking
---

Worklog Id: (was: 31453)
Time Spent: 2h 10m  (was: 2h)

> cachekey: not thread safe
> -
>
> Key: TS-4650
> URL: https://issues.apache.org/jira/browse/TS-4650
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Affects Versions: 6.2.0
>Reporter: Felicity Tarnell
>Assignee: Felicity Tarnell
> Fix For: 7.0.0
>
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> cachekey's Pattern class is not thread safe; it uses member data to store the 
> result of pcre_exec(), but only one instance is shared between all threads.  
> This causes crashes when two threads access the pcre result at the same time.
> Fix: use automatic storage for the pcre result data.
> PR incoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4650) cachekey: not thread safe

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4650?focusedWorklogId=31452=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31452
 ]

ASF GitHub Bot logged work on TS-4650:
--

Author: ASF GitHub Bot
Created on: 02/Nov/16 18:19
Start Date: 02/Nov/16 18:19
Worklog Time Spent: 10m 
  Work Description: GitHub user gtenev opened a pull request:

https://github.com/apache/trafficserver/pull/1172

TS-4650: cachekey: not thread safe

(cherry picked from commit f4a97a9d573867441c5dd711b54ff66117fcd057)
(cherry picked from commit 15b2ab08a30a0df8c2223e05c7bfc4cb530ea243)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gtenev/trafficserver TS-4650_backport

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1172.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1172


commit ec577b957b75a2a0e1e481d47f2e3f5988c21f1e
Author: Felicity Tarnell 
Date:   2016-07-12T15:28:44Z

TS-4650: cachekey: not thread safe

(cherry picked from commit f4a97a9d573867441c5dd711b54ff66117fcd057)
(cherry picked from commit 15b2ab08a30a0df8c2223e05c7bfc4cb530ea243)




Issue Time Tracking
---

Worklog Id: (was: 31452)
Time Spent: 2h  (was: 1h 50m)

> cachekey: not thread safe
> -
>
> Key: TS-4650
> URL: https://issues.apache.org/jira/browse/TS-4650
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Affects Versions: 6.2.0
>Reporter: Felicity Tarnell
>Assignee: Felicity Tarnell
> Fix For: 7.0.0
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> cachekey's Pattern class is not thread safe; it uses member data to store the 
> result of pcre_exec(), but only one instance is shared between all threads.  
> This causes crashes when two threads access the pcre result at the same time.
> Fix: use automatic storage for the pcre result data.
> PR incoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4650) cachekey: not thread safe

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4650?focusedWorklogId=25821=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25821
 ]

ASF GitHub Bot logged work on TS-4650:
--

Author: ASF GitHub Bot
Created on: 21/Jul/16 18:25
Start Date: 21/Jul/16 18:25
Worklog Time Spent: 10m 
  Work Description: Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/792


Issue Time Tracking
---

Worklog Id: (was: 25821)
Time Spent: 1h 50m  (was: 1h 40m)

> cachekey: not thread safe
> -
>
> Key: TS-4650
> URL: https://issues.apache.org/jira/browse/TS-4650
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Affects Versions: 6.2.0
>Reporter: Felicity Tarnell
>Assignee: Felicity Tarnell
> Fix For: 7.0.0
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> cachekey's Pattern class is not thread safe; it uses member data to store the 
> result of pcre_exec(), but only one instance is shared between all threads.  
> This causes crashes when two threads access the pcre result at the same time.
> Fix: use automatic storage for the pcre result data.
> PR incoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4650) cachekey: not thread safe

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4650?focusedWorklogId=25820=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25820
 ]

ASF GitHub Bot logged work on TS-4650:
--

Author: ASF GitHub Bot
Created on: 21/Jul/16 18:08
Start Date: 21/Jul/16 18:08
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/792
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/366/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 25820)
Time Spent: 1h 40m  (was: 1.5h)

> cachekey: not thread safe
> -
>
> Key: TS-4650
> URL: https://issues.apache.org/jira/browse/TS-4650
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Affects Versions: 6.2.0
>Reporter: Felicity Tarnell
> Fix For: 7.0.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> cachekey's Pattern class is not thread safe; it uses member data to store the 
> result of pcre_exec(), but only one instance is shared between all threads.  
> This causes crashes when two threads access the pcre result at the same time.
> Fix: use automatic storage for the pcre result data.
> PR incoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4650) cachekey: not thread safe

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4650?focusedWorklogId=25819=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25819
 ]

ASF GitHub Bot logged work on TS-4650:
--

Author: ASF GitHub Bot
Created on: 21/Jul/16 18:03
Start Date: 21/Jul/16 18:03
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/792
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/469/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 25819)
Time Spent: 1.5h  (was: 1h 20m)

> cachekey: not thread safe
> -
>
> Key: TS-4650
> URL: https://issues.apache.org/jira/browse/TS-4650
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Affects Versions: 6.2.0
>Reporter: Felicity Tarnell
> Fix For: 7.0.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> cachekey's Pattern class is not thread safe; it uses member data to store the 
> result of pcre_exec(), but only one instance is shared between all threads.  
> This causes crashes when two threads access the pcre result at the same time.
> Fix: use automatic storage for the pcre result data.
> PR incoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4650) cachekey: not thread safe

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4650?focusedWorklogId=25818=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25818
 ]

ASF GitHub Bot logged work on TS-4650:
--

Author: ASF GitHub Bot
Created on: 21/Jul/16 17:52
Start Date: 21/Jul/16 17:52
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/792
  
[approve ci]


Issue Time Tracking
---

Worklog Id: (was: 25818)
Time Spent: 1h 20m  (was: 1h 10m)

> cachekey: not thread safe
> -
>
> Key: TS-4650
> URL: https://issues.apache.org/jira/browse/TS-4650
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Affects Versions: 6.2.0
>Reporter: Felicity Tarnell
> Fix For: 7.0.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> cachekey's Pattern class is not thread safe; it uses member data to store the 
> result of pcre_exec(), but only one instance is shared between all threads.  
> This causes crashes when two threads access the pcre result at the same time.
> Fix: use automatic storage for the pcre result data.
> PR incoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4650) cachekey: not thread safe

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4650?focusedWorklogId=25796=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25796
 ]

ASF GitHub Bot logged work on TS-4650:
--

Author: ASF GitHub Bot
Created on: 21/Jul/16 13:38
Start Date: 21/Jul/16 13:38
Worklog Time Spent: 10m 
  Work Description: Github user ftarnell commented on the issue:

https://github.com/apache/trafficserver/pull/792
  
clang-format should be fixed now.


Issue Time Tracking
---

Worklog Id: (was: 25796)
Time Spent: 1h 10m  (was: 1h)

> cachekey: not thread safe
> -
>
> Key: TS-4650
> URL: https://issues.apache.org/jira/browse/TS-4650
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Affects Versions: 6.2.0
>Reporter: Felicity Tarnell
> Fix For: 7.0.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> cachekey's Pattern class is not thread safe; it uses member data to store the 
> result of pcre_exec(), but only one instance is shared between all threads.  
> This causes crashes when two threads access the pcre result at the same time.
> Fix: use automatic storage for the pcre result data.
> PR incoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4650) cachekey: not thread safe

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4650?focusedWorklogId=25448=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25448
 ]

ASF GitHub Bot logged work on TS-4650:
--

Author: ASF GitHub Bot
Created on: 12/Jul/16 21:50
Start Date: 12/Jul/16 21:50
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/792
  
Thanks @gtenev. @ftarnell can you fix the clang format error (see the linux 
build above), and then we can land this.

Thanks!


Issue Time Tracking
---

Worklog Id: (was: 25448)
Time Spent: 1h  (was: 50m)

> cachekey: not thread safe
> -
>
> Key: TS-4650
> URL: https://issues.apache.org/jira/browse/TS-4650
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Affects Versions: 6.2.0
>Reporter: Felicity Tarnell
> Fix For: 7.0.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> cachekey's Pattern class is not thread safe; it uses member data to store the 
> result of pcre_exec(), but only one instance is shared between all threads.  
> This causes crashes when two threads access the pcre result at the same time.
> Fix: use automatic storage for the pcre result data.
> PR incoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4650) cachekey: not thread safe

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4650?focusedWorklogId=25446=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25446
 ]

ASF GitHub Bot logged work on TS-4650:
--

Author: ASF GitHub Bot
Created on: 12/Jul/16 21:18
Start Date: 12/Jul/16 21:18
Worklog Time Spent: 10m 
  Work Description: Github user gtenev commented on the issue:

https://github.com/apache/trafficserver/pull/792
  
@ftarnell looks good, thanks for fixing!
@zwoop it will be great if we can back port to 6.2.1



Issue Time Tracking
---

Worklog Id: (was: 25446)
Time Spent: 50m  (was: 40m)

> cachekey: not thread safe
> -
>
> Key: TS-4650
> URL: https://issues.apache.org/jira/browse/TS-4650
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Affects Versions: 6.2.0
>Reporter: Felicity Tarnell
> Fix For: 6.2.1
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> cachekey's Pattern class is not thread safe; it uses member data to store the 
> result of pcre_exec(), but only one instance is shared between all threads.  
> This causes crashes when two threads access the pcre result at the same time.
> Fix: use automatic storage for the pcre result data.
> PR incoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4650) cachekey: not thread safe

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4650?focusedWorklogId=25438=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25438
 ]

ASF GitHub Bot logged work on TS-4650:
--

Author: ASF GitHub Bot
Created on: 12/Jul/16 17:03
Start Date: 12/Jul/16 17:03
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/792
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/418/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 25438)
Time Spent: 40m  (was: 0.5h)

> cachekey: not thread safe
> -
>
> Key: TS-4650
> URL: https://issues.apache.org/jira/browse/TS-4650
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: Felicity Tarnell
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> cachekey's Pattern class is not thread safe; it uses member data to store the 
> result of pcre_exec(), but only one instance is shared between all threads.  
> This causes crashes when two threads access the pcre result at the same time.
> Fix: use automatic storage for the pcre result data.
> PR incoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4650) cachekey: not thread safe

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4650?focusedWorklogId=25437=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25437
 ]

ASF GitHub Bot logged work on TS-4650:
--

Author: ASF GitHub Bot
Created on: 12/Jul/16 16:58
Start Date: 12/Jul/16 16:58
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/792
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/312/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 25437)
Time Spent: 0.5h  (was: 20m)

> cachekey: not thread safe
> -
>
> Key: TS-4650
> URL: https://issues.apache.org/jira/browse/TS-4650
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: Felicity Tarnell
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> cachekey's Pattern class is not thread safe; it uses member data to store the 
> result of pcre_exec(), but only one instance is shared between all threads.  
> This causes crashes when two threads access the pcre result at the same time.
> Fix: use automatic storage for the pcre result data.
> PR incoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4650) cachekey: not thread safe

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4650?focusedWorklogId=25436=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25436
 ]

ASF GitHub Bot logged work on TS-4650:
--

Author: ASF GitHub Bot
Created on: 12/Jul/16 16:55
Start Date: 12/Jul/16 16:55
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/792
  
[approve ci]

@gtenev  Please review.


Issue Time Tracking
---

Worklog Id: (was: 25436)
Time Spent: 20m  (was: 10m)

> cachekey: not thread safe
> -
>
> Key: TS-4650
> URL: https://issues.apache.org/jira/browse/TS-4650
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: Felicity Tarnell
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> cachekey's Pattern class is not thread safe; it uses member data to store the 
> result of pcre_exec(), but only one instance is shared between all threads.  
> This causes crashes when two threads access the pcre result at the same time.
> Fix: use automatic storage for the pcre result data.
> PR incoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4650) cachekey: not thread safe

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4650?focusedWorklogId=25435=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25435
 ]

ASF GitHub Bot logged work on TS-4650:
--

Author: ASF GitHub Bot
Created on: 12/Jul/16 16:20
Start Date: 12/Jul/16 16:20
Worklog Time Spent: 10m 
  Work Description: GitHub user ftarnell opened a pull request:

https://github.com/apache/trafficserver/pull/792

TS-4650: cachekey: not thread safe



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/torchbox/trafficserver ts4650

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/792.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #792






Issue Time Tracking
---

Worklog Id: (was: 25435)
Time Spent: 10m
Remaining Estimate: 0h

> cachekey: not thread safe
> -
>
> Key: TS-4650
> URL: https://issues.apache.org/jira/browse/TS-4650
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: Felicity Tarnell
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> cachekey's Pattern class is not thread safe; it uses member data to store the 
> result of pcre_exec(), but only one instance is shared between all threads.  
> This causes crashes when two threads access the pcre result at the same time.
> Fix: use automatic storage for the pcre result data.
> PR incoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)