[jira] [Work logged] (TS-4728) Null pointer error in LogHost.cc.

2016-11-09 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4728?focusedWorklogId=31908=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31908
 ]

ASF GitHub Bot logged work on TS-4728:
--

Author: ASF GitHub Bot
Created on: 10/Nov/16 02:14
Start Date: 10/Nov/16 02:14
Worklog Time Spent: 10m 
  Work Description: Github user PSUdaemon closed the pull request at:

https://github.com/apache/trafficserver/pull/1213


Issue Time Tracking
---

Worklog Id: (was: 31908)
Time Spent: 2h 20m  (was: 2h 10m)

> Null pointer error in LogHost.cc.
> -
>
> Key: TS-4728
> URL: https://issues.apache.org/jira/browse/TS-4728
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Affects Versions: 7.0.0
>Reporter: Peter Chou
>Assignee: James Peach
> Fix For: 6.2.1, 7.0.0
>
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> [~jpe...@apache.org] I am getting a null pointer access error with the 
> following assertion at the time of traffic_server start-up with log collation 
> enabled (client-side). I was able to get around it by just commenting it out, 
> but perhaps a better fix is required.
> {noformat}
> LogHost::create_orphan_LogFile_object()
> {
>   // We expect that no-one else is holding any refcounts on the
>   // orphan file so that is will be releases when we replace it
>   // below.
>   ink_assert(m_orphan_file->refcount() == 1);
> {noformat}
> Back-trace --
> {noformat}
> #0  0x0053e772 in RefCountObj::refcount (this=0x8) at 
> ../lib/ts/Ptr.h:80
> #1  0x00692f9f in LogHost::create_orphan_LogFile_object 
> (this=0x2268d80) at LogHost.cc:235
> #2  0x00692a45 in LogHost::set_ipstr_port (this=0x2268d80, 
> ipstr=0x2265d40 "127.0.0.1", pt=8085) at LogHost.cc:135
> #3  0x00692b92 in LogHost::set_name_or_ipstr (this=0x2268d80, 
> name_or_ip=0x2265d40 "127.0.0.1") at LogHost.cc:155
> #4  0x00684046 in LogConfig::read_xml_log_config (this=0x21e4110) at 
> LogConfig.cc:1472
> #5  0x0067ff73 in LogConfig::setup_log_objects (this=0x21e4110) at 
> LogConfig.cc:510
> #6  0x0067f858 in LogConfig::init (this=0x21e4110, prev_config=0x0) 
> at LogConfig.cc:395
> #7  0x006721fe in Log::init (flags=0) at Log.cc:925
> #8  0x00542552 in main (argv=0x7ffcc853abd8) at Main.cc:1828
> {noformat}
> I made minimal changes to logs_xml.config to set as client --
> {noformat}
> 
> 
>  : % : %"/>
> 
> 
> 
> 
> 
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4728) Null pointer error in LogHost.cc.

2016-11-09 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4728?focusedWorklogId=31907=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31907
 ]

ASF GitHub Bot logged work on TS-4728:
--

Author: ASF GitHub Bot
Created on: 10/Nov/16 02:12
Start Date: 10/Nov/16 02:12
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1213
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1198/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 31907)
Time Spent: 2h 10m  (was: 2h)

> Null pointer error in LogHost.cc.
> -
>
> Key: TS-4728
> URL: https://issues.apache.org/jira/browse/TS-4728
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Affects Versions: 7.0.0
>Reporter: Peter Chou
>Assignee: James Peach
> Fix For: 7.0.0
>
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> [~jpe...@apache.org] I am getting a null pointer access error with the 
> following assertion at the time of traffic_server start-up with log collation 
> enabled (client-side). I was able to get around it by just commenting it out, 
> but perhaps a better fix is required.
> {noformat}
> LogHost::create_orphan_LogFile_object()
> {
>   // We expect that no-one else is holding any refcounts on the
>   // orphan file so that is will be releases when we replace it
>   // below.
>   ink_assert(m_orphan_file->refcount() == 1);
> {noformat}
> Back-trace --
> {noformat}
> #0  0x0053e772 in RefCountObj::refcount (this=0x8) at 
> ../lib/ts/Ptr.h:80
> #1  0x00692f9f in LogHost::create_orphan_LogFile_object 
> (this=0x2268d80) at LogHost.cc:235
> #2  0x00692a45 in LogHost::set_ipstr_port (this=0x2268d80, 
> ipstr=0x2265d40 "127.0.0.1", pt=8085) at LogHost.cc:135
> #3  0x00692b92 in LogHost::set_name_or_ipstr (this=0x2268d80, 
> name_or_ip=0x2265d40 "127.0.0.1") at LogHost.cc:155
> #4  0x00684046 in LogConfig::read_xml_log_config (this=0x21e4110) at 
> LogConfig.cc:1472
> #5  0x0067ff73 in LogConfig::setup_log_objects (this=0x21e4110) at 
> LogConfig.cc:510
> #6  0x0067f858 in LogConfig::init (this=0x21e4110, prev_config=0x0) 
> at LogConfig.cc:395
> #7  0x006721fe in Log::init (flags=0) at Log.cc:925
> #8  0x00542552 in main (argv=0x7ffcc853abd8) at Main.cc:1828
> {noformat}
> I made minimal changes to logs_xml.config to set as client --
> {noformat}
> 
> 
>  : % : %"/>
> 
> 
> 
> 
> 
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4728) Null pointer error in LogHost.cc.

2016-11-09 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4728?focusedWorklogId=31906=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31906
 ]

ASF GitHub Bot logged work on TS-4728:
--

Author: ASF GitHub Bot
Created on: 10/Nov/16 02:11
Start Date: 10/Nov/16 02:11
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1213
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1091/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 31906)
Time Spent: 2h  (was: 1h 50m)

> Null pointer error in LogHost.cc.
> -
>
> Key: TS-4728
> URL: https://issues.apache.org/jira/browse/TS-4728
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Affects Versions: 7.0.0
>Reporter: Peter Chou
>Assignee: James Peach
> Fix For: 7.0.0
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> [~jpe...@apache.org] I am getting a null pointer access error with the 
> following assertion at the time of traffic_server start-up with log collation 
> enabled (client-side). I was able to get around it by just commenting it out, 
> but perhaps a better fix is required.
> {noformat}
> LogHost::create_orphan_LogFile_object()
> {
>   // We expect that no-one else is holding any refcounts on the
>   // orphan file so that is will be releases when we replace it
>   // below.
>   ink_assert(m_orphan_file->refcount() == 1);
> {noformat}
> Back-trace --
> {noformat}
> #0  0x0053e772 in RefCountObj::refcount (this=0x8) at 
> ../lib/ts/Ptr.h:80
> #1  0x00692f9f in LogHost::create_orphan_LogFile_object 
> (this=0x2268d80) at LogHost.cc:235
> #2  0x00692a45 in LogHost::set_ipstr_port (this=0x2268d80, 
> ipstr=0x2265d40 "127.0.0.1", pt=8085) at LogHost.cc:135
> #3  0x00692b92 in LogHost::set_name_or_ipstr (this=0x2268d80, 
> name_or_ip=0x2265d40 "127.0.0.1") at LogHost.cc:155
> #4  0x00684046 in LogConfig::read_xml_log_config (this=0x21e4110) at 
> LogConfig.cc:1472
> #5  0x0067ff73 in LogConfig::setup_log_objects (this=0x21e4110) at 
> LogConfig.cc:510
> #6  0x0067f858 in LogConfig::init (this=0x21e4110, prev_config=0x0) 
> at LogConfig.cc:395
> #7  0x006721fe in Log::init (flags=0) at Log.cc:925
> #8  0x00542552 in main (argv=0x7ffcc853abd8) at Main.cc:1828
> {noformat}
> I made minimal changes to logs_xml.config to set as client --
> {noformat}
> 
> 
>  : % : %"/>
> 
> 
> 
> 
> 
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4728) Null pointer error in LogHost.cc.

2016-11-09 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4728?focusedWorklogId=31902=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31902
 ]

ASF GitHub Bot logged work on TS-4728:
--

Author: ASF GitHub Bot
Created on: 10/Nov/16 01:58
Start Date: 10/Nov/16 01:58
Worklog Time Spent: 10m 
  Work Description: Github user PSUdaemon commented on the issue:

https://github.com/apache/trafficserver/pull/1213
  
[approve ci]


Issue Time Tracking
---

Worklog Id: (was: 31902)
Time Spent: 1h 50m  (was: 1h 40m)

> Null pointer error in LogHost.cc.
> -
>
> Key: TS-4728
> URL: https://issues.apache.org/jira/browse/TS-4728
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Affects Versions: 7.0.0
>Reporter: Peter Chou
>Assignee: James Peach
> Fix For: 7.0.0
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> [~jpe...@apache.org] I am getting a null pointer access error with the 
> following assertion at the time of traffic_server start-up with log collation 
> enabled (client-side). I was able to get around it by just commenting it out, 
> but perhaps a better fix is required.
> {noformat}
> LogHost::create_orphan_LogFile_object()
> {
>   // We expect that no-one else is holding any refcounts on the
>   // orphan file so that is will be releases when we replace it
>   // below.
>   ink_assert(m_orphan_file->refcount() == 1);
> {noformat}
> Back-trace --
> {noformat}
> #0  0x0053e772 in RefCountObj::refcount (this=0x8) at 
> ../lib/ts/Ptr.h:80
> #1  0x00692f9f in LogHost::create_orphan_LogFile_object 
> (this=0x2268d80) at LogHost.cc:235
> #2  0x00692a45 in LogHost::set_ipstr_port (this=0x2268d80, 
> ipstr=0x2265d40 "127.0.0.1", pt=8085) at LogHost.cc:135
> #3  0x00692b92 in LogHost::set_name_or_ipstr (this=0x2268d80, 
> name_or_ip=0x2265d40 "127.0.0.1") at LogHost.cc:155
> #4  0x00684046 in LogConfig::read_xml_log_config (this=0x21e4110) at 
> LogConfig.cc:1472
> #5  0x0067ff73 in LogConfig::setup_log_objects (this=0x21e4110) at 
> LogConfig.cc:510
> #6  0x0067f858 in LogConfig::init (this=0x21e4110, prev_config=0x0) 
> at LogConfig.cc:395
> #7  0x006721fe in Log::init (flags=0) at Log.cc:925
> #8  0x00542552 in main (argv=0x7ffcc853abd8) at Main.cc:1828
> {noformat}
> I made minimal changes to logs_xml.config to set as client --
> {noformat}
> 
> 
>  : % : %"/>
> 
> 
> 
> 
> 
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4728) Null pointer error in LogHost.cc.

2016-11-08 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4728?focusedWorklogId=31828=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31828
 ]

ASF GitHub Bot logged work on TS-4728:
--

Author: ASF GitHub Bot
Created on: 08/Nov/16 23:34
Start Date: 08/Nov/16 23:34
Worklog Time Spent: 10m 
  Work Description: GitHub user pbchou opened a pull request:

https://github.com/apache/trafficserver/pull/1213

TS-4728 Null pointer error in LogHost.cc (backport 6.2.x)

@PSUdaemon -- As requested, this is a PR to backport the commits for this 
issue to 6.2.x. However, I'm not sure that I can fully vouch for this because 
IIRC the crash bug that I reported in the Jira was present in 7.0.x but not in 
6.1.x or 6.2.x.

It was @zwoop who requested the back-port originally and @jpeach who wrote 
the commits in this PR.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pbchou/trafficserver TS-4728-backport-6.2.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1213.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1213


commit e2d746871d0fc05d280e74585289a14c5570dfdd
Author: James Peach 
Date:   2016-08-10T21:10:17Z

TS-4728: Return bool from LogHost boolean functions.

(cherry picked from commit 0a12b2682cc718057ee33d0642dfe009c5574004)

Conflicts:
proxy/logging/LogHost.cc

commit 8ec7dcd922493ec41318c989102717b555454a68
Author: James Peach 
Date:   2016-08-10T21:16:16Z

TS-4728: Remove invalid LogHost assertion.

(cherry picked from commit f502718abc09c66830d9dececf596e039daec422)

Conflicts:
proxy/logging/LogHost.cc




Issue Time Tracking
---

Worklog Id: (was: 31828)
Time Spent: 1h 40m  (was: 1.5h)

> Null pointer error in LogHost.cc.
> -
>
> Key: TS-4728
> URL: https://issues.apache.org/jira/browse/TS-4728
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Affects Versions: 7.0.0
>Reporter: Peter Chou
>Assignee: James Peach
> Fix For: 7.0.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> [~jpe...@apache.org] I am getting a null pointer access error with the 
> following assertion at the time of traffic_server start-up with log collation 
> enabled (client-side). I was able to get around it by just commenting it out, 
> but perhaps a better fix is required.
> {noformat}
> LogHost::create_orphan_LogFile_object()
> {
>   // We expect that no-one else is holding any refcounts on the
>   // orphan file so that is will be releases when we replace it
>   // below.
>   ink_assert(m_orphan_file->refcount() == 1);
> {noformat}
> Back-trace --
> {noformat}
> #0  0x0053e772 in RefCountObj::refcount (this=0x8) at 
> ../lib/ts/Ptr.h:80
> #1  0x00692f9f in LogHost::create_orphan_LogFile_object 
> (this=0x2268d80) at LogHost.cc:235
> #2  0x00692a45 in LogHost::set_ipstr_port (this=0x2268d80, 
> ipstr=0x2265d40 "127.0.0.1", pt=8085) at LogHost.cc:135
> #3  0x00692b92 in LogHost::set_name_or_ipstr (this=0x2268d80, 
> name_or_ip=0x2265d40 "127.0.0.1") at LogHost.cc:155
> #4  0x00684046 in LogConfig::read_xml_log_config (this=0x21e4110) at 
> LogConfig.cc:1472
> #5  0x0067ff73 in LogConfig::setup_log_objects (this=0x21e4110) at 
> LogConfig.cc:510
> #6  0x0067f858 in LogConfig::init (this=0x21e4110, prev_config=0x0) 
> at LogConfig.cc:395
> #7  0x006721fe in Log::init (flags=0) at Log.cc:925
> #8  0x00542552 in main (argv=0x7ffcc853abd8) at Main.cc:1828
> {noformat}
> I made minimal changes to logs_xml.config to set as client --
> {noformat}
> 
> 
>  : % : %"/>
> 
> 
> 
> 
> 
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4728) Null pointer error in LogHost.cc.

2016-09-02 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4728?focusedWorklogId=27939=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27939
 ]

ASF GitHub Bot logged work on TS-4728:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 16:02
Start Date: 02/Sep/16 16:02
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on the issue:

https://github.com/apache/trafficserver/pull/850
  

> On Sep 2, 2016, at 6:45 AM, Oknet  wrote:
> 
> Should we define LogFile::free() first ?
> The Ptr::clear() need free() to dealloc the LogFile.

LogFile inherits RefCountObj, which implements free() as "delete this", so 
it just needs a valid destructor.


Issue Time Tracking
---

Worklog Id: (was: 27939)
Time Spent: 1.5h  (was: 1h 20m)

> Null pointer error in LogHost.cc.
> -
>
> Key: TS-4728
> URL: https://issues.apache.org/jira/browse/TS-4728
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Affects Versions: 7.0.0
>Reporter: Peter Chou
>Assignee: James Peach
> Fix For: 7.0.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> [~jpe...@apache.org] I am getting a null pointer access error with the 
> following assertion at the time of traffic_server start-up with log collation 
> enabled (client-side). I was able to get around it by just commenting it out, 
> but perhaps a better fix is required.
> {noformat}
> LogHost::create_orphan_LogFile_object()
> {
>   // We expect that no-one else is holding any refcounts on the
>   // orphan file so that is will be releases when we replace it
>   // below.
>   ink_assert(m_orphan_file->refcount() == 1);
> {noformat}
> Back-trace --
> {noformat}
> #0  0x0053e772 in RefCountObj::refcount (this=0x8) at 
> ../lib/ts/Ptr.h:80
> #1  0x00692f9f in LogHost::create_orphan_LogFile_object 
> (this=0x2268d80) at LogHost.cc:235
> #2  0x00692a45 in LogHost::set_ipstr_port (this=0x2268d80, 
> ipstr=0x2265d40 "127.0.0.1", pt=8085) at LogHost.cc:135
> #3  0x00692b92 in LogHost::set_name_or_ipstr (this=0x2268d80, 
> name_or_ip=0x2265d40 "127.0.0.1") at LogHost.cc:155
> #4  0x00684046 in LogConfig::read_xml_log_config (this=0x21e4110) at 
> LogConfig.cc:1472
> #5  0x0067ff73 in LogConfig::setup_log_objects (this=0x21e4110) at 
> LogConfig.cc:510
> #6  0x0067f858 in LogConfig::init (this=0x21e4110, prev_config=0x0) 
> at LogConfig.cc:395
> #7  0x006721fe in Log::init (flags=0) at Log.cc:925
> #8  0x00542552 in main (argv=0x7ffcc853abd8) at Main.cc:1828
> {noformat}
> I made minimal changes to logs_xml.config to set as client --
> {noformat}
> 
> 
>  : % : %"/>
> 
> 
> 
> 
> 
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4728) Null pointer error in LogHost.cc.

2016-09-02 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4728?focusedWorklogId=27915=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27915
 ]

ASF GitHub Bot logged work on TS-4728:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 13:45
Start Date: 02/Sep/16 13:45
Worklog Time Spent: 10m 
  Work Description: Github user oknet commented on the issue:

https://github.com/apache/trafficserver/pull/850
  
Should we define LogFile::free() first ?
The Ptr::clear() need free() to dealloc the LogFile.


Issue Time Tracking
---

Worklog Id: (was: 27915)
Time Spent: 1h 20m  (was: 1h 10m)

> Null pointer error in LogHost.cc.
> -
>
> Key: TS-4728
> URL: https://issues.apache.org/jira/browse/TS-4728
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Affects Versions: 7.0.0
>Reporter: Peter Chou
>Assignee: James Peach
> Fix For: 7.0.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> [~jpe...@apache.org] I am getting a null pointer access error with the 
> following assertion at the time of traffic_server start-up with log collation 
> enabled (client-side). I was able to get around it by just commenting it out, 
> but perhaps a better fix is required.
> {noformat}
> LogHost::create_orphan_LogFile_object()
> {
>   // We expect that no-one else is holding any refcounts on the
>   // orphan file so that is will be releases when we replace it
>   // below.
>   ink_assert(m_orphan_file->refcount() == 1);
> {noformat}
> Back-trace --
> {noformat}
> #0  0x0053e772 in RefCountObj::refcount (this=0x8) at 
> ../lib/ts/Ptr.h:80
> #1  0x00692f9f in LogHost::create_orphan_LogFile_object 
> (this=0x2268d80) at LogHost.cc:235
> #2  0x00692a45 in LogHost::set_ipstr_port (this=0x2268d80, 
> ipstr=0x2265d40 "127.0.0.1", pt=8085) at LogHost.cc:135
> #3  0x00692b92 in LogHost::set_name_or_ipstr (this=0x2268d80, 
> name_or_ip=0x2265d40 "127.0.0.1") at LogHost.cc:155
> #4  0x00684046 in LogConfig::read_xml_log_config (this=0x21e4110) at 
> LogConfig.cc:1472
> #5  0x0067ff73 in LogConfig::setup_log_objects (this=0x21e4110) at 
> LogConfig.cc:510
> #6  0x0067f858 in LogConfig::init (this=0x21e4110, prev_config=0x0) 
> at LogConfig.cc:395
> #7  0x006721fe in Log::init (flags=0) at Log.cc:925
> #8  0x00542552 in main (argv=0x7ffcc853abd8) at Main.cc:1828
> {noformat}
> I made minimal changes to logs_xml.config to set as client --
> {noformat}
> 
> 
>  : % : %"/>
> 
> 
> 
> 
> 
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4728) Null pointer error in LogHost.cc.

2016-08-10 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4728?focusedWorklogId=26322=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26322
 ]

ASF GitHub Bot logged work on TS-4728:
--

Author: ASF GitHub Bot
Created on: 11/Aug/16 00:22
Start Date: 11/Aug/16 00:22
Worklog Time Spent: 10m 
  Work Description: Github user jpeach closed the pull request at:

https://github.com/apache/trafficserver/pull/850


Issue Time Tracking
---

Worklog Id: (was: 26322)
Time Spent: 1h 10m  (was: 1h)

> Null pointer error in LogHost.cc.
> -
>
> Key: TS-4728
> URL: https://issues.apache.org/jira/browse/TS-4728
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Affects Versions: 7.0.0
>Reporter: Peter Chou
>Assignee: James Peach
> Fix For: 7.0.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> [~jpe...@apache.org] I am getting a null pointer access error with the 
> following assertion at the time of traffic_server start-up with log collation 
> enabled (client-side). I was able to get around it by just commenting it out, 
> but perhaps a better fix is required.
> {noformat}
> LogHost::create_orphan_LogFile_object()
> {
>   // We expect that no-one else is holding any refcounts on the
>   // orphan file so that is will be releases when we replace it
>   // below.
>   ink_assert(m_orphan_file->refcount() == 1);
> {noformat}
> Back-trace --
> {noformat}
> #0  0x0053e772 in RefCountObj::refcount (this=0x8) at 
> ../lib/ts/Ptr.h:80
> #1  0x00692f9f in LogHost::create_orphan_LogFile_object 
> (this=0x2268d80) at LogHost.cc:235
> #2  0x00692a45 in LogHost::set_ipstr_port (this=0x2268d80, 
> ipstr=0x2265d40 "127.0.0.1", pt=8085) at LogHost.cc:135
> #3  0x00692b92 in LogHost::set_name_or_ipstr (this=0x2268d80, 
> name_or_ip=0x2265d40 "127.0.0.1") at LogHost.cc:155
> #4  0x00684046 in LogConfig::read_xml_log_config (this=0x21e4110) at 
> LogConfig.cc:1472
> #5  0x0067ff73 in LogConfig::setup_log_objects (this=0x21e4110) at 
> LogConfig.cc:510
> #6  0x0067f858 in LogConfig::init (this=0x21e4110, prev_config=0x0) 
> at LogConfig.cc:395
> #7  0x006721fe in Log::init (flags=0) at Log.cc:925
> #8  0x00542552 in main (argv=0x7ffcc853abd8) at Main.cc:1828
> {noformat}
> I made minimal changes to logs_xml.config to set as client --
> {noformat}
> 
> 
>  : % : %"/>
> 
> 
> 
> 
> 
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4728) Null pointer error in LogHost.cc.

2016-08-10 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4728?focusedWorklogId=26312=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26312
 ]

ASF GitHub Bot logged work on TS-4728:
--

Author: ASF GitHub Bot
Created on: 10/Aug/16 23:41
Start Date: 10/Aug/16 23:41
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/850
  
This is likely a back port candidate for 6.2.1 as well.


Issue Time Tracking
---

Worklog Id: (was: 26312)
Time Spent: 1h  (was: 50m)

> Null pointer error in LogHost.cc.
> -
>
> Key: TS-4728
> URL: https://issues.apache.org/jira/browse/TS-4728
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Affects Versions: 7.0.0
>Reporter: Peter Chou
>Assignee: James Peach
> Fix For: 7.0.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> [~jpe...@apache.org] I am getting a null pointer access error with the 
> following assertion at the time of traffic_server start-up with log collation 
> enabled (client-side). I was able to get around it by just commenting it out, 
> but perhaps a better fix is required.
> {noformat}
> LogHost::create_orphan_LogFile_object()
> {
>   // We expect that no-one else is holding any refcounts on the
>   // orphan file so that is will be releases when we replace it
>   // below.
>   ink_assert(m_orphan_file->refcount() == 1);
> {noformat}
> Back-trace --
> {noformat}
> #0  0x0053e772 in RefCountObj::refcount (this=0x8) at 
> ../lib/ts/Ptr.h:80
> #1  0x00692f9f in LogHost::create_orphan_LogFile_object 
> (this=0x2268d80) at LogHost.cc:235
> #2  0x00692a45 in LogHost::set_ipstr_port (this=0x2268d80, 
> ipstr=0x2265d40 "127.0.0.1", pt=8085) at LogHost.cc:135
> #3  0x00692b92 in LogHost::set_name_or_ipstr (this=0x2268d80, 
> name_or_ip=0x2265d40 "127.0.0.1") at LogHost.cc:155
> #4  0x00684046 in LogConfig::read_xml_log_config (this=0x21e4110) at 
> LogConfig.cc:1472
> #5  0x0067ff73 in LogConfig::setup_log_objects (this=0x21e4110) at 
> LogConfig.cc:510
> #6  0x0067f858 in LogConfig::init (this=0x21e4110, prev_config=0x0) 
> at LogConfig.cc:395
> #7  0x006721fe in Log::init (flags=0) at Log.cc:925
> #8  0x00542552 in main (argv=0x7ffcc853abd8) at Main.cc:1828
> {noformat}
> I made minimal changes to logs_xml.config to set as client --
> {noformat}
> 
> 
>  : % : %"/>
> 
> 
> 
> 
> 
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4728) Null pointer error in LogHost.cc.

2016-08-10 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4728?focusedWorklogId=26311=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26311
 ]

ASF GitHub Bot logged work on TS-4728:
--

Author: ASF GitHub Bot
Created on: 10/Aug/16 23:40
Start Date: 10/Aug/16 23:40
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/850
  
:+1:


Issue Time Tracking
---

Worklog Id: (was: 26311)
Time Spent: 50m  (was: 40m)

> Null pointer error in LogHost.cc.
> -
>
> Key: TS-4728
> URL: https://issues.apache.org/jira/browse/TS-4728
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Affects Versions: 7.0.0
>Reporter: Peter Chou
>Assignee: James Peach
> Fix For: 7.0.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> [~jpe...@apache.org] I am getting a null pointer access error with the 
> following assertion at the time of traffic_server start-up with log collation 
> enabled (client-side). I was able to get around it by just commenting it out, 
> but perhaps a better fix is required.
> {noformat}
> LogHost::create_orphan_LogFile_object()
> {
>   // We expect that no-one else is holding any refcounts on the
>   // orphan file so that is will be releases when we replace it
>   // below.
>   ink_assert(m_orphan_file->refcount() == 1);
> {noformat}
> Back-trace --
> {noformat}
> #0  0x0053e772 in RefCountObj::refcount (this=0x8) at 
> ../lib/ts/Ptr.h:80
> #1  0x00692f9f in LogHost::create_orphan_LogFile_object 
> (this=0x2268d80) at LogHost.cc:235
> #2  0x00692a45 in LogHost::set_ipstr_port (this=0x2268d80, 
> ipstr=0x2265d40 "127.0.0.1", pt=8085) at LogHost.cc:135
> #3  0x00692b92 in LogHost::set_name_or_ipstr (this=0x2268d80, 
> name_or_ip=0x2265d40 "127.0.0.1") at LogHost.cc:155
> #4  0x00684046 in LogConfig::read_xml_log_config (this=0x21e4110) at 
> LogConfig.cc:1472
> #5  0x0067ff73 in LogConfig::setup_log_objects (this=0x21e4110) at 
> LogConfig.cc:510
> #6  0x0067f858 in LogConfig::init (this=0x21e4110, prev_config=0x0) 
> at LogConfig.cc:395
> #7  0x006721fe in Log::init (flags=0) at Log.cc:925
> #8  0x00542552 in main (argv=0x7ffcc853abd8) at Main.cc:1828
> {noformat}
> I made minimal changes to logs_xml.config to set as client --
> {noformat}
> 
> 
>  : % : %"/>
> 
> 
> 
> 
> 
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4728) Null pointer error in LogHost.cc.

2016-08-10 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4728?focusedWorklogId=26304=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26304
 ]

ASF GitHub Bot logged work on TS-4728:
--

Author: ASF GitHub Bot
Created on: 10/Aug/16 21:49
Start Date: 10/Aug/16 21:49
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/850
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/413/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 26304)
Time Spent: 40m  (was: 0.5h)

> Null pointer error in LogHost.cc.
> -
>
> Key: TS-4728
> URL: https://issues.apache.org/jira/browse/TS-4728
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Affects Versions: 7.0.0
>Reporter: Peter Chou
>Assignee: James Peach
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> [~jpe...@apache.org] I am getting a null pointer access error with the 
> following assertion at the time of traffic_server start-up with log collation 
> enabled (client-side). I was able to get around it by just commenting it out, 
> but perhaps a better fix is required.
> {noformat}
> LogHost::create_orphan_LogFile_object()
> {
>   // We expect that no-one else is holding any refcounts on the
>   // orphan file so that is will be releases when we replace it
>   // below.
>   ink_assert(m_orphan_file->refcount() == 1);
> {noformat}
> Back-trace --
> {noformat}
> #0  0x0053e772 in RefCountObj::refcount (this=0x8) at 
> ../lib/ts/Ptr.h:80
> #1  0x00692f9f in LogHost::create_orphan_LogFile_object 
> (this=0x2268d80) at LogHost.cc:235
> #2  0x00692a45 in LogHost::set_ipstr_port (this=0x2268d80, 
> ipstr=0x2265d40 "127.0.0.1", pt=8085) at LogHost.cc:135
> #3  0x00692b92 in LogHost::set_name_or_ipstr (this=0x2268d80, 
> name_or_ip=0x2265d40 "127.0.0.1") at LogHost.cc:155
> #4  0x00684046 in LogConfig::read_xml_log_config (this=0x21e4110) at 
> LogConfig.cc:1472
> #5  0x0067ff73 in LogConfig::setup_log_objects (this=0x21e4110) at 
> LogConfig.cc:510
> #6  0x0067f858 in LogConfig::init (this=0x21e4110, prev_config=0x0) 
> at LogConfig.cc:395
> #7  0x006721fe in Log::init (flags=0) at Log.cc:925
> #8  0x00542552 in main (argv=0x7ffcc853abd8) at Main.cc:1828
> {noformat}
> I made minimal changes to logs_xml.config to set as client --
> {noformat}
> 
> 
>  : % : %"/>
> 
> 
> 
> 
> 
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4728) Null pointer error in LogHost.cc.

2016-08-10 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4728?focusedWorklogId=26303=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26303
 ]

ASF GitHub Bot logged work on TS-4728:
--

Author: ASF GitHub Bot
Created on: 10/Aug/16 21:43
Start Date: 10/Aug/16 21:43
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/850
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/516/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 26303)
Time Spent: 0.5h  (was: 20m)

> Null pointer error in LogHost.cc.
> -
>
> Key: TS-4728
> URL: https://issues.apache.org/jira/browse/TS-4728
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Affects Versions: 7.0.0
>Reporter: Peter Chou
>Assignee: James Peach
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> [~jpe...@apache.org] I am getting a null pointer access error with the 
> following assertion at the time of traffic_server start-up with log collation 
> enabled (client-side). I was able to get around it by just commenting it out, 
> but perhaps a better fix is required.
> {noformat}
> LogHost::create_orphan_LogFile_object()
> {
>   // We expect that no-one else is holding any refcounts on the
>   // orphan file so that is will be releases when we replace it
>   // below.
>   ink_assert(m_orphan_file->refcount() == 1);
> {noformat}
> Back-trace --
> {noformat}
> #0  0x0053e772 in RefCountObj::refcount (this=0x8) at 
> ../lib/ts/Ptr.h:80
> #1  0x00692f9f in LogHost::create_orphan_LogFile_object 
> (this=0x2268d80) at LogHost.cc:235
> #2  0x00692a45 in LogHost::set_ipstr_port (this=0x2268d80, 
> ipstr=0x2265d40 "127.0.0.1", pt=8085) at LogHost.cc:135
> #3  0x00692b92 in LogHost::set_name_or_ipstr (this=0x2268d80, 
> name_or_ip=0x2265d40 "127.0.0.1") at LogHost.cc:155
> #4  0x00684046 in LogConfig::read_xml_log_config (this=0x21e4110) at 
> LogConfig.cc:1472
> #5  0x0067ff73 in LogConfig::setup_log_objects (this=0x21e4110) at 
> LogConfig.cc:510
> #6  0x0067f858 in LogConfig::init (this=0x21e4110, prev_config=0x0) 
> at LogConfig.cc:395
> #7  0x006721fe in Log::init (flags=0) at Log.cc:925
> #8  0x00542552 in main (argv=0x7ffcc853abd8) at Main.cc:1828
> {noformat}
> I made minimal changes to logs_xml.config to set as client --
> {noformat}
> 
> 
>  : % : %"/>
> 
> 
> 
> 
> 
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4728) Null pointer error in LogHost.cc.

2016-08-10 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4728?focusedWorklogId=26302=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26302
 ]

ASF GitHub Bot logged work on TS-4728:
--

Author: ASF GitHub Bot
Created on: 10/Aug/16 21:33
Start Date: 10/Aug/16 21:33
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on the issue:

https://github.com/apache/trafficserver/pull/850
  
Ping @zwoop @pbchou 


Issue Time Tracking
---

Worklog Id: (was: 26302)
Time Spent: 20m  (was: 10m)

> Null pointer error in LogHost.cc.
> -
>
> Key: TS-4728
> URL: https://issues.apache.org/jira/browse/TS-4728
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Affects Versions: 7.0.0
>Reporter: Peter Chou
>Assignee: James Peach
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> [~jpe...@apache.org] I am getting a null pointer access error with the 
> following assertion at the time of traffic_server start-up with log collation 
> enabled (client-side). I was able to get around it by just commenting it out, 
> but perhaps a better fix is required.
> {noformat}
> LogHost::create_orphan_LogFile_object()
> {
>   // We expect that no-one else is holding any refcounts on the
>   // orphan file so that is will be releases when we replace it
>   // below.
>   ink_assert(m_orphan_file->refcount() == 1);
> {noformat}
> Back-trace --
> {noformat}
> #0  0x0053e772 in RefCountObj::refcount (this=0x8) at 
> ../lib/ts/Ptr.h:80
> #1  0x00692f9f in LogHost::create_orphan_LogFile_object 
> (this=0x2268d80) at LogHost.cc:235
> #2  0x00692a45 in LogHost::set_ipstr_port (this=0x2268d80, 
> ipstr=0x2265d40 "127.0.0.1", pt=8085) at LogHost.cc:135
> #3  0x00692b92 in LogHost::set_name_or_ipstr (this=0x2268d80, 
> name_or_ip=0x2265d40 "127.0.0.1") at LogHost.cc:155
> #4  0x00684046 in LogConfig::read_xml_log_config (this=0x21e4110) at 
> LogConfig.cc:1472
> #5  0x0067ff73 in LogConfig::setup_log_objects (this=0x21e4110) at 
> LogConfig.cc:510
> #6  0x0067f858 in LogConfig::init (this=0x21e4110, prev_config=0x0) 
> at LogConfig.cc:395
> #7  0x006721fe in Log::init (flags=0) at Log.cc:925
> #8  0x00542552 in main (argv=0x7ffcc853abd8) at Main.cc:1828
> {noformat}
> I made minimal changes to logs_xml.config to set as client --
> {noformat}
> 
> 
>  : % : %"/>
> 
> 
> 
> 
> 
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4728) Null pointer error in LogHost.cc.

2016-08-10 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4728?focusedWorklogId=26301=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26301
 ]

ASF GitHub Bot logged work on TS-4728:
--

Author: ASF GitHub Bot
Created on: 10/Aug/16 21:32
Start Date: 10/Aug/16 21:32
Worklog Time Spent: 10m 
  Work Description: GitHub user jpeach opened a pull request:

https://github.com/apache/trafficserver/pull/850

TS-4728: Remove invalid LogHost assertion.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jpeach/trafficserver fix/4728

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/850.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #850


commit 0a12b2682cc718057ee33d0642dfe009c5574004
Author: James Peach 
Date:   2016-08-10T21:10:17Z

TS-4728: Return bool from LogHost boolean functions.

commit f502718abc09c66830d9dececf596e039daec422
Author: James Peach 
Date:   2016-08-10T21:16:16Z

TS-4728: Remove invalid LogHost assertion.




Issue Time Tracking
---

Worklog Id: (was: 26301)
Time Spent: 10m
Remaining Estimate: 0h

> Null pointer error in LogHost.cc.
> -
>
> Key: TS-4728
> URL: https://issues.apache.org/jira/browse/TS-4728
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Affects Versions: 7.0.0
>Reporter: Peter Chou
>Assignee: James Peach
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> [~jpe...@apache.org] I am getting a null pointer access error with the 
> following assertion at the time of traffic_server start-up with log collation 
> enabled (client-side). I was able to get around it by just commenting it out, 
> but perhaps a better fix is required.
> {noformat}
> LogHost::create_orphan_LogFile_object()
> {
>   // We expect that no-one else is holding any refcounts on the
>   // orphan file so that is will be releases when we replace it
>   // below.
>   ink_assert(m_orphan_file->refcount() == 1);
> {noformat}
> Back-trace --
> {noformat}
> #0  0x0053e772 in RefCountObj::refcount (this=0x8) at 
> ../lib/ts/Ptr.h:80
> #1  0x00692f9f in LogHost::create_orphan_LogFile_object 
> (this=0x2268d80) at LogHost.cc:235
> #2  0x00692a45 in LogHost::set_ipstr_port (this=0x2268d80, 
> ipstr=0x2265d40 "127.0.0.1", pt=8085) at LogHost.cc:135
> #3  0x00692b92 in LogHost::set_name_or_ipstr (this=0x2268d80, 
> name_or_ip=0x2265d40 "127.0.0.1") at LogHost.cc:155
> #4  0x00684046 in LogConfig::read_xml_log_config (this=0x21e4110) at 
> LogConfig.cc:1472
> #5  0x0067ff73 in LogConfig::setup_log_objects (this=0x21e4110) at 
> LogConfig.cc:510
> #6  0x0067f858 in LogConfig::init (this=0x21e4110, prev_config=0x0) 
> at LogConfig.cc:395
> #7  0x006721fe in Log::init (flags=0) at Log.cc:925
> #8  0x00542552 in main (argv=0x7ffcc853abd8) at Main.cc:1828
> {noformat}
> I made minimal changes to logs_xml.config to set as client --
> {noformat}
> 
> 
>  : % : %"/>
> 
> 
> 
> 
> 
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)