[jira] [Work logged] (TS-4815) CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;

2016-10-27 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4815?focusedWorklogId=31247=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31247
 ]

ASF GitHub Bot logged work on TS-4815:
--

Author: ASF GitHub Bot
Created on: 27/Oct/16 08:45
Start Date: 27/Oct/16 08:45
Worklog Time Spent: 10m 
  Work Description: Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/963


Issue Time Tracking
---

Worklog Id: (was: 31247)
Time Spent: 2.5h  (was: 2h 20m)

> CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;
> --
>
> Key: TS-4815
> URL: https://issues.apache.org/jira/browse/TS-4815
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Management API
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Fix For: 7.1.0
>
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
>   cond_notnull: Condition ctx, taking true branch. Now the value of ctx 
> is not NULL.
> 165  ink_assert(ctx);
>   notnull: At condition ctx, the value of ctx cannot be NULL.
>   dead_error_condition: The condition !ctx cannot be true.
> 166  if (!ctx) {
>   
> CID 1267839 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return TS_ERR_PARAMS;.
> 167return TS_ERR_PARAMS;
> 168  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4815) CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;

2016-09-21 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4815?focusedWorklogId=29465=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29465
 ]

ASF GitHub Bot logged work on TS-4815:
--

Author: ASF GitHub Bot
Created on: 21/Sep/16 20:03
Start Date: 21/Sep/16 20:03
Worklog Time Spent: 10m 
  Work Description: Github user ngara commented on the issue:

https://github.com/apache/trafficserver/pull/963
  
Alright, I cleaned up my mess. Here's just the single commit.


Issue Time Tracking
---

Worklog Id: (was: 29465)
Time Spent: 2h 20m  (was: 2h 10m)

> CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;
> --
>
> Key: TS-4815
> URL: https://issues.apache.org/jira/browse/TS-4815
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Management API
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Fix For: 7.1.0
>
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
>   cond_notnull: Condition ctx, taking true branch. Now the value of ctx 
> is not NULL.
> 165  ink_assert(ctx);
>   notnull: At condition ctx, the value of ctx cannot be NULL.
>   dead_error_condition: The condition !ctx cannot be true.
> 166  if (!ctx) {
>   
> CID 1267839 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return TS_ERR_PARAMS;.
> 167return TS_ERR_PARAMS;
> 168  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4815) CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;

2016-09-21 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4815?focusedWorklogId=29446=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29446
 ]

ASF GitHub Bot logged work on TS-4815:
--

Author: ASF GitHub Bot
Created on: 21/Sep/16 15:42
Start Date: 21/Sep/16 15:42
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/963
  
@ngara  Maybe I'm reading this wrong, but it looks like we still have 3 
commits in this PR. If that's the case, can you please squash that down into a 
single commit? No reason to have the 2 previous versions in the git commit 
history.


Issue Time Tracking
---

Worklog Id: (was: 29446)
Time Spent: 2h 10m  (was: 2h)

> CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;
> --
>
> Key: TS-4815
> URL: https://issues.apache.org/jira/browse/TS-4815
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Management API
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Fix For: 7.1.0
>
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
>   cond_notnull: Condition ctx, taking true branch. Now the value of ctx 
> is not NULL.
> 165  ink_assert(ctx);
>   notnull: At condition ctx, the value of ctx cannot be NULL.
>   dead_error_condition: The condition !ctx cannot be true.
> 166  if (!ctx) {
>   
> CID 1267839 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return TS_ERR_PARAMS;.
> 167return TS_ERR_PARAMS;
> 168  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4815) CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;

2016-09-13 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4815?focusedWorklogId=28976=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28976
 ]

ASF GitHub Bot logged work on TS-4815:
--

Author: ASF GitHub Bot
Created on: 13/Sep/16 18:59
Start Date: 13/Sep/16 18:59
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/963
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/689/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 28976)
Time Spent: 2h  (was: 1h 50m)

> CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;
> --
>
> Key: TS-4815
> URL: https://issues.apache.org/jira/browse/TS-4815
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Management API
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Fix For: 7.0.0
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
>   cond_notnull: Condition ctx, taking true branch. Now the value of ctx 
> is not NULL.
> 165  ink_assert(ctx);
>   notnull: At condition ctx, the value of ctx cannot be NULL.
>   dead_error_condition: The condition !ctx cannot be true.
> 166  if (!ctx) {
>   
> CID 1267839 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return TS_ERR_PARAMS;.
> 167return TS_ERR_PARAMS;
> 168  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4815) CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;

2016-09-13 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4815?focusedWorklogId=28974=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28974
 ]

ASF GitHub Bot logged work on TS-4815:
--

Author: ASF GitHub Bot
Created on: 13/Sep/16 18:56
Start Date: 13/Sep/16 18:56
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/963
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/793/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 28974)
Time Spent: 1h 50m  (was: 1h 40m)

> CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;
> --
>
> Key: TS-4815
> URL: https://issues.apache.org/jira/browse/TS-4815
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Management API
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Fix For: 7.0.0
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
>   cond_notnull: Condition ctx, taking true branch. Now the value of ctx 
> is not NULL.
> 165  ink_assert(ctx);
>   notnull: At condition ctx, the value of ctx cannot be NULL.
>   dead_error_condition: The condition !ctx cannot be true.
> 166  if (!ctx) {
>   
> CID 1267839 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return TS_ERR_PARAMS;.
> 167return TS_ERR_PARAMS;
> 168  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4815) CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;

2016-09-13 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4815?focusedWorklogId=28971=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28971
 ]

ASF GitHub Bot logged work on TS-4815:
--

Author: ASF GitHub Bot
Created on: 13/Sep/16 18:42
Start Date: 13/Sep/16 18:42
Worklog Time Spent: 10m 
  Work Description: GitHub user ngara reopened a pull request:

https://github.com/apache/trafficserver/pull/963

TS-4815 - CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: re…

TS-4815 - CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return 
TS_ERR_PARAMS;

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ngara/trafficserver TS-4815

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/963.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #963


commit 8947c566f5564f1bb03fa63d5bcc2e18ab08ccde
Author: Nathan Garabedian 
Date:   2016-09-02T21:13:38Z

TS-4815 - CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return 
TS_ERR_PARAMS;




Issue Time Tracking
---

Worklog Id: (was: 28971)
Time Spent: 1.5h  (was: 1h 20m)

> CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;
> --
>
> Key: TS-4815
> URL: https://issues.apache.org/jira/browse/TS-4815
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Management API
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Fix For: 7.0.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
>   cond_notnull: Condition ctx, taking true branch. Now the value of ctx 
> is not NULL.
> 165  ink_assert(ctx);
>   notnull: At condition ctx, the value of ctx cannot be NULL.
>   dead_error_condition: The condition !ctx cannot be true.
> 166  if (!ctx) {
>   
> CID 1267839 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return TS_ERR_PARAMS;.
> 167return TS_ERR_PARAMS;
> 168  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4815) CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;

2016-09-13 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4815?focusedWorklogId=28972=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28972
 ]

ASF GitHub Bot logged work on TS-4815:
--

Author: ASF GitHub Bot
Created on: 13/Sep/16 18:43
Start Date: 13/Sep/16 18:43
Worklog Time Spent: 10m 
  Work Description: Github user ngara commented on the issue:

https://github.com/apache/trafficserver/pull/963
  
This pull request should not be merged in.  Handling it with TS-4860 
instead.


Issue Time Tracking
---

Worklog Id: (was: 28972)
Time Spent: 1h 40m  (was: 1.5h)

> CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;
> --
>
> Key: TS-4815
> URL: https://issues.apache.org/jira/browse/TS-4815
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Management API
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Fix For: 7.0.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
>   cond_notnull: Condition ctx, taking true branch. Now the value of ctx 
> is not NULL.
> 165  ink_assert(ctx);
>   notnull: At condition ctx, the value of ctx cannot be NULL.
>   dead_error_condition: The condition !ctx cannot be true.
> 166  if (!ctx) {
>   
> CID 1267839 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return TS_ERR_PARAMS;.
> 167return TS_ERR_PARAMS;
> 168  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4815) CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;

2016-09-13 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4815?focusedWorklogId=28970=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28970
 ]

ASF GitHub Bot logged work on TS-4815:
--

Author: ASF GitHub Bot
Created on: 13/Sep/16 18:40
Start Date: 13/Sep/16 18:40
Worklog Time Spent: 10m 
  Work Description: Github user ngara closed the pull request at:

https://github.com/apache/trafficserver/pull/963


Issue Time Tracking
---

Worklog Id: (was: 28970)
Time Spent: 1h 20m  (was: 1h 10m)

> CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;
> --
>
> Key: TS-4815
> URL: https://issues.apache.org/jira/browse/TS-4815
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Management API
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Fix For: 7.0.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
>   cond_notnull: Condition ctx, taking true branch. Now the value of ctx 
> is not NULL.
> 165  ink_assert(ctx);
>   notnull: At condition ctx, the value of ctx cannot be NULL.
>   dead_error_condition: The condition !ctx cannot be true.
> 166  if (!ctx) {
>   
> CID 1267839 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return TS_ERR_PARAMS;.
> 167return TS_ERR_PARAMS;
> 168  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4815) CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;

2016-09-07 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4815?focusedWorklogId=28386=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28386
 ]

ASF GitHub Bot logged work on TS-4815:
--

Author: ASF GitHub Bot
Created on: 08/Sep/16 02:16
Start Date: 08/Sep/16 02:16
Worklog Time Spent: 10m 
  Work Description: Github user ngara commented on the issue:

https://github.com/apache/trafficserver/pull/963
  
Thanks for the feedback. Updated to use ink_release_assert which will 
always execute, and ready to review again.


Issue Time Tracking
---

Worklog Id: (was: 28386)
Time Spent: 1h 10m  (was: 1h)

> CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;
> --
>
> Key: TS-4815
> URL: https://issues.apache.org/jira/browse/TS-4815
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Management API
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Fix For: 7.0.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
>   cond_notnull: Condition ctx, taking true branch. Now the value of ctx 
> is not NULL.
> 165  ink_assert(ctx);
>   notnull: At condition ctx, the value of ctx cannot be NULL.
>   dead_error_condition: The condition !ctx cannot be true.
> 166  if (!ctx) {
>   
> CID 1267839 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return TS_ERR_PARAMS;.
> 167return TS_ERR_PARAMS;
> 168  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4815) CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;

2016-09-07 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4815?focusedWorklogId=28273=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28273
 ]

ASF GitHub Bot logged work on TS-4815:
--

Author: ASF GitHub Bot
Created on: 07/Sep/16 15:06
Start Date: 07/Sep/16 15:06
Worklog Time Spent: 10m 
  Work Description: Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/963
  
Yes, it seems like the null check is only dead if the assert always 
occurred.  Otherwise running without debug enabled will not catch the issue and 
cause a more mysterious crash later.


Issue Time Tracking
---

Worklog Id: (was: 28273)
Time Spent: 1h  (was: 50m)

> CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;
> --
>
> Key: TS-4815
> URL: https://issues.apache.org/jira/browse/TS-4815
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Management API
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Fix For: 7.0.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
>   cond_notnull: Condition ctx, taking true branch. Now the value of ctx 
> is not NULL.
> 165  ink_assert(ctx);
>   notnull: At condition ctx, the value of ctx cannot be NULL.
>   dead_error_condition: The condition !ctx cannot be true.
> 166  if (!ctx) {
>   
> CID 1267839 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return TS_ERR_PARAMS;.
> 167return TS_ERR_PARAMS;
> 168  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4815) CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;

2016-09-02 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4815?focusedWorklogId=28023=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28023
 ]

ASF GitHub Bot logged work on TS-4815:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 22:50
Start Date: 02/Sep/16 22:50
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/963
  
Should we change this to an ink_relase_assert() or an ink_abort() ?


Issue Time Tracking
---

Worklog Id: (was: 28023)
Time Spent: 0.5h  (was: 20m)

> CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;
> --
>
> Key: TS-4815
> URL: https://issues.apache.org/jira/browse/TS-4815
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Management API
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Fix For: 7.0.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
>   cond_notnull: Condition ctx, taking true branch. Now the value of ctx 
> is not NULL.
> 165  ink_assert(ctx);
>   notnull: At condition ctx, the value of ctx cannot be NULL.
>   dead_error_condition: The condition !ctx cannot be true.
> 166  if (!ctx) {
>   
> CID 1267839 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return TS_ERR_PARAMS;.
> 167return TS_ERR_PARAMS;
> 168  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)