[jira] [Work logged] (TS-4925) Manager puking EBADF everywhere

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4925?focusedWorklogId=30208=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30208
 ]

ASF GitHub Bot logged work on TS-4925:
--

Author: ASF GitHub Bot
Created on: 05/Oct/16 23:42
Start Date: 05/Oct/16 23:42
Worklog Time Spent: 10m 
  Work Description: Github user jpeach closed the pull request at:

https://github.com/apache/trafficserver/pull/1074


Issue Time Tracking
---

Worklog Id: (was: 30208)
Time Spent: 1h 10m  (was: 1h)

> Manager puking EBADF everywhere
> ---
>
> Key: TS-4925
> URL: https://issues.apache.org/jira/browse/TS-4925
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Manager
>Reporter: James Peach
>Assignee: James Peach
> Fix For: 7.1.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> {noformat}
> [Oct  3 20:19:53.824] Manager {0x7f7b699a2800} ERROR: 
> [LocalManager::pollMgmtProcessServer] select failed or was interrupted (9)
> ...
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4925) Manager puking EBADF everywhere

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4925?focusedWorklogId=30158=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30158
 ]

ASF GitHub Bot logged work on TS-4925:
--

Author: ASF GitHub Bot
Created on: 05/Oct/16 04:16
Start Date: 05/Oct/16 04:16
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on the issue:

https://github.com/apache/trafficserver/pull/1074
  
@zwoop It is a race that happens when ``traffic_server`` keeps failing to 
start. 7.0 would be good but not sure we need to bother with 6.2


Issue Time Tracking
---

Worklog Id: (was: 30158)
Time Spent: 1h  (was: 50m)

> Manager puking EBADF everywhere
> ---
>
> Key: TS-4925
> URL: https://issues.apache.org/jira/browse/TS-4925
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Manager
>Reporter: James Peach
>Assignee: James Peach
> Fix For: 7.1.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> {noformat}
> [Oct  3 20:19:53.824] Manager {0x7f7b699a2800} ERROR: 
> [LocalManager::pollMgmtProcessServer] select failed or was interrupted (9)
> ...
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4925) Manager puking EBADF everywhere

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4925?focusedWorklogId=30134=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30134
 ]

ASF GitHub Bot logged work on TS-4925:
--

Author: ASF GitHub Bot
Created on: 04/Oct/16 21:00
Start Date: 04/Oct/16 21:00
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1074
  
I'd imagine this is a backport candidate for at least 7.0.0, maybe 6.2.x ?


Issue Time Tracking
---

Worklog Id: (was: 30134)
Time Spent: 50m  (was: 40m)

> Manager puking EBADF everywhere
> ---
>
> Key: TS-4925
> URL: https://issues.apache.org/jira/browse/TS-4925
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Manager
>Reporter: James Peach
>Assignee: James Peach
> Fix For: 7.1.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> {noformat}
> [Oct  3 20:19:53.824] Manager {0x7f7b699a2800} ERROR: 
> [LocalManager::pollMgmtProcessServer] select failed or was interrupted (9)
> ...
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4925) Manager puking EBADF everywhere

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4925?focusedWorklogId=30133=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30133
 ]

ASF GitHub Bot logged work on TS-4925:
--

Author: ASF GitHub Bot
Created on: 04/Oct/16 20:59
Start Date: 04/Oct/16 20:59
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1074
  
@gtenev  Can you review this please?


Issue Time Tracking
---

Worklog Id: (was: 30133)
Time Spent: 40m  (was: 0.5h)

> Manager puking EBADF everywhere
> ---
>
> Key: TS-4925
> URL: https://issues.apache.org/jira/browse/TS-4925
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Manager
>Reporter: James Peach
>Assignee: James Peach
> Fix For: 7.1.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> {noformat}
> [Oct  3 20:19:53.824] Manager {0x7f7b699a2800} ERROR: 
> [LocalManager::pollMgmtProcessServer] select failed or was interrupted (9)
> ...
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4925) Manager puking EBADF everywhere.

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4925?focusedWorklogId=30101=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30101
 ]

ASF GitHub Bot logged work on TS-4925:
--

Author: ASF GitHub Bot
Created on: 04/Oct/16 05:04
Start Date: 04/Oct/16 05:04
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1074
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/817/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 30101)
Time Spent: 0.5h  (was: 20m)

> Manager puking EBADF everywhere.
> 
>
> Key: TS-4925
> URL: https://issues.apache.org/jira/browse/TS-4925
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Manager
>Reporter: James Peach
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> {noformat}
> [Oct  3 20:19:53.824] Manager {0x7f7b699a2800} ERROR: 
> [LocalManager::pollMgmtProcessServer] select failed or was interrupted (9)
> ...
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4925) Manager puking EBADF everywhere.

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4925?focusedWorklogId=30100=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30100
 ]

ASF GitHub Bot logged work on TS-4925:
--

Author: ASF GitHub Bot
Created on: 04/Oct/16 05:01
Start Date: 04/Oct/16 05:01
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1074
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/923/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 30100)
Time Spent: 20m  (was: 10m)

> Manager puking EBADF everywhere.
> 
>
> Key: TS-4925
> URL: https://issues.apache.org/jira/browse/TS-4925
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Manager
>Reporter: James Peach
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> {noformat}
> [Oct  3 20:19:53.824] Manager {0x7f7b699a2800} ERROR: 
> [LocalManager::pollMgmtProcessServer] select failed or was interrupted (9)
> ...
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4925) Manager puking EBADF everywhere.

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4925?focusedWorklogId=30099=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30099
 ]

ASF GitHub Bot logged work on TS-4925:
--

Author: ASF GitHub Bot
Created on: 04/Oct/16 04:48
Start Date: 04/Oct/16 04:48
Worklog Time Spent: 10m 
  Work Description: GitHub user jpeach opened a pull request:

https://github.com/apache/trafficserver/pull/1074

TS-4925: Manager pollMgmtProcessServer stuck with EBADF.

If the select in pollMgmtProcessServer fails with an actual error
(EBADF, for example), it just returned back into the select loop
and was unable to recover. This might happen if the server file
descriptor is -1, or otherwise stale.

The fix is to not put -1 into the select set, and to break the loop
if select returns an error.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jpeach/trafficserver fix/4925

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1074.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1074


commit a2ff45c956b9b69eb188b87ae1e4c02f74148aba
Author: James Peach 
Date:   2016-10-04T04:43:57Z

TS-4925: Manager pollMgmtProcessServer stuck with EBADF.

If the select in pollMgmtProcessServer fails with an actual error
(EBADF, for example), it just returned back into the select loop
and was unable to recover. This might happen if the server file
descriptor is -1, or otherwise stale.

The fix is to not put -1 into the select set, and to break the loop
if select returns an error.




Issue Time Tracking
---

Worklog Id: (was: 30099)
Time Spent: 10m
Remaining Estimate: 0h

> Manager puking EBADF everywhere.
> 
>
> Key: TS-4925
> URL: https://issues.apache.org/jira/browse/TS-4925
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Manager
>Reporter: James Peach
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> {noformat}
> [Oct  3 20:19:53.824] Manager {0x7f7b699a2800} ERROR: 
> [LocalManager::pollMgmtProcessServer] select failed or was interrupted (9)
> ...
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)