[jira] [Commented] (TRAFODION-2823) some test case donot close connection

2017-12-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TRAFODION-2823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276154#comment-16276154
 ] 

ASF GitHub Bot commented on TRAFODION-2823:
---

Github user DaveBirdsall commented on a diff in the pull request:


https://github.com/apache/incubator-trafodion/pull/1320#discussion_r154540542
  
--- Diff: 
dcs/src/test/jdbc_test/src/test/java/org/trafodion/jdbc_test/TestWrap.java ---
@@ -51,7 +51,11 @@ public void testIsWrapFor() {
 conn = Utils.getUserConnection();
 boolean result = conn.isWrapperFor(Connection.class);
 assertTrue("It is wrapper for this interface", result);
+conn.close();
 } catch (SQLException e) {
+if (conn !=null) {
+conn.close();
--- End diff --

The Jenkins builds are complaining that this code has an uncaught exception 
of some sort. Could you take a look? Thanks.


> some test case donot close connection
> -
>
> Key: TRAFODION-2823
> URL: https://issues.apache.org/jira/browse/TRAFODION-2823
> Project: Apache Trafodion
>  Issue Type: Bug
>Reporter: Gong Pengju
>Priority: Minor
>
> some classes in 
> incubator-trafodion/dcs/src/test/jdbc_test/src/test/java/org/trafodion/jdbc_test
>  do not close statement and connection, which will lead to no connection can 
> be use.
> classes include : 
> PropTest.java
> TestNetworkTimeout.java
> TestWrap.java



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (TRAFODION-2824) some "hp" code in trafodion

2017-12-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TRAFODION-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276145#comment-16276145
 ] 

ASF GitHub Bot commented on TRAFODION-2824:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/1319


> some "hp" code in trafodion
> ---
>
> Key: TRAFODION-2824
> URL: https://issues.apache.org/jira/browse/TRAFODION-2824
> Project: Apache Trafodion
>  Issue Type: Bug
>Reporter: Gong Pengju
>Priority: Minor
>
> there are some code appear in trafodion, like HPT4Connection,HPT4ResultSet



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)