[jira] [Updated] (ZOOKEEPER-4713) ObserverZooKeeperServer.shutdown() is redundant

2023-07-05 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-4713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ZOOKEEPER-4713:
--
Labels: pull-request-available  (was: )

> ObserverZooKeeperServer.shutdown() is redundant
> ---
>
> Key: ZOOKEEPER-4713
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4713
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum, server
>Affects Versions: 3.5.10, 3.6.3, 3.7.0, 3.8.0, 3.7.1, 3.6.4, 3.8.1
>Reporter: Sirius
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> After the 
> [FIX|https://github.com/apache/zookeeper/commit/66646796c2173423655c7faf2b458b658143e6b5]
>  of ZOOKEEPER-1796, LearnerZooKeeperServer.shutdown() should be responsible 
> for the shutdown logic of both the follower and observer. 
> ObserverZooKeeperServer.shutdown() seems redundant, because it is not in the 
> call stack of Observer.shutdown(). (Note that FollowerZooKeeperServer does 
> not have the shutdown() method.)
> Related analysis can be found in ZOOKEEPER-4712



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (ZOOKEEPER-4713) ObserverZooKeeperServer.shutdown() is redundant

2023-06-29 Thread Sirius (Jira)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-4713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sirius updated ZOOKEEPER-4713:
--
Description: 
After the 
[FIX|https://github.com/apache/zookeeper/commit/66646796c2173423655c7faf2b458b658143e6b5]
 of ZOOKEEPER-1796, LearnerZooKeeperServer.shutdown() should be responsible for 
the shutdown logic of both the follower and observer. 
ObserverZooKeeperServer.shutdown() seems redundant, because it is not in the 
call stack of Observer.shutdown(). (Note that FollowerZooKeeperServer does not 
have the shutdown() method.)

Related analysis can be found in ZOOKEEPER-4712

  was:
After the 
[FIX|https://github.com/apache/zookeeper/commit/66646796c2173423655c7faf2b458b658143e6b5]
 of ZOOKEEPER-1796, LearnerZooKeeperServer.shutdown() should be responsible for 
the shutdown logic of both the follower and observer. 
ObserverZooKeeperServer.shutdown() seems redundant.

Related analysis can be found in 
[ZOOKEEPER-4712|https://issues.apache.org/jira/browse/ZOOKEEPER-4712)ZOOKEEPER-4712]


> ObserverZooKeeperServer.shutdown() is redundant
> ---
>
> Key: ZOOKEEPER-4713
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4713
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum, server
>Affects Versions: 3.5.10, 3.6.3, 3.7.0, 3.8.0, 3.7.1, 3.6.4, 3.8.1
>Reporter: Sirius
>Priority: Minor
>
> After the 
> [FIX|https://github.com/apache/zookeeper/commit/66646796c2173423655c7faf2b458b658143e6b5]
>  of ZOOKEEPER-1796, LearnerZooKeeperServer.shutdown() should be responsible 
> for the shutdown logic of both the follower and observer. 
> ObserverZooKeeperServer.shutdown() seems redundant, because it is not in the 
> call stack of Observer.shutdown(). (Note that FollowerZooKeeperServer does 
> not have the shutdown() method.)
> Related analysis can be found in ZOOKEEPER-4712



--
This message was sent by Atlassian Jira
(v8.20.10#820010)