[jira] [Resolved] (ZOOKEEPER-3322) ./zkServer.sh status failed when reconfig don't write the clientPort into the zoo.cfg

2019-06-05 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling resolved ZOOKEEPER-3322.

Resolution: Implemented

> ./zkServer.sh status failed when reconfig don't write the clientPort into the 
> zoo.cfg
> -
>
> Key: ZOOKEEPER-3322
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3322
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: maoling
>Assignee: maoling
>Priority: Major
>
> look at my zoo.cfg which don't have the clientPort value when using the 
> reconfig.
> *cat ../conf/zoo.cfg*
> reconfigEnabled=true
> dataDir=../../zkdata2
> syncLimit=5
> dataLogDir=../../zkdataLog2
> initLimit=10
> tickTime=2000
> dynamicConfigFile=/data/software/zookeeper/zookeeper-test2/conf/zoo.cfg.dynamic.1f
> but look at the cmd:"./zkServer.sh status",it needs this clientPort value 
> STAT=`"$JAVA" "-Dzookeeper.log.dir=${ZOO_LOG_DIR}" 
> "-Dzookeeper.root.logger=${ZOO_LOG4J_PROP}" 
> "-Dzookeeper.log.file=${ZOO_LOG_FILE}" \
>  -cp "$CLASSPATH" $JVMFLAGS org.apache.zookeeper.client.FourLetterWordMain \
>  $clientPortAddress $clientPort srvr 2> /dev/null \
> otw, ./zkServer.sh status will fail.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ZOOKEEPER-3322) ./zkServer.sh status failed when reconfig don't write the clientPort into the zoo.cfg

2019-06-05 Thread maoling (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856380#comment-16856380
 ] 

maoling commented on ZOOKEEPER-3322:


this issue had been solved by the master branch by parsing the clientPort in 
the *zkServer.sh*
{code:java}
echo "Usage: $0 [--config ] 
{start|start-foreground|stop|restart|status|print-cmd}" >&2

esac*)
echo "Usage: $0 [--config ] 
{start|start-foreground|stop|restart|status|print-cmd}" >&2

esac
dynamicConfigFile=`$GREP "^[[:space:]]*dynamicConfigFile" "$ZOOCFG" | sed -e 
's/.*=//'`
clientPortAndAddress=`$GREP "^[[:space:]]*server.$myid=.*;.*" 
"$dynamicConfigFile" | sed -e 's/.*=//' | sed -e 's/.*;//'`
fi
if [ ! "$clientPortAndAddress" ] ; then
echo "Client port not found. Terminating."
exit 1
fi
if [[ "$clientPortAndAddress" =~ ^.*:[0-9]+ ]] ; then
clientPortAddress=`echo "$clientPortAndAddress" | sed -e 's/:.*//'`
fi
clientPort=`echo "$clientPortAndAddress" | sed -e 's/.*://'`
if [ ! "$clientPort" ] ; then
echo "Client port not found. Terminating."
exit 1
fi
fi
echo "Client port found: $clientPort. Client address: $clientPortAddress."
STAT=`"$JAVA" "-Dzookeeper.log.dir=${ZOO_LOG_DIR}" 
"-Dzookeeper.root.logger=${ZOO_LOG4J_PROP}" 
"-Dzookeeper.log.file=${ZOO_LOG_FILE}" \
-cp "$CLASSPATH" $JVMFLAGS org.apache.zookeeper.client.FourLetterWordMain \
$clientPortAddress $clientPort srvr 2> /dev/null \
| $GREP Mode`
if [ "x$STAT" = "x" ]
then
echo "Error contacting service. It is probably not running."
exit 1
else
echo $STAT
exit 0
fi{code}
 

> ./zkServer.sh status failed when reconfig don't write the clientPort into the 
> zoo.cfg
> -
>
> Key: ZOOKEEPER-3322
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3322
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: maoling
>Assignee: maoling
>Priority: Major
>
> look at my zoo.cfg which don't have the clientPort value when using the 
> reconfig.
> *cat ../conf/zoo.cfg*
> reconfigEnabled=true
> dataDir=../../zkdata2
> syncLimit=5
> dataLogDir=../../zkdataLog2
> initLimit=10
> tickTime=2000
> dynamicConfigFile=/data/software/zookeeper/zookeeper-test2/conf/zoo.cfg.dynamic.1f
> but look at the cmd:"./zkServer.sh status",it needs this clientPort value 
> STAT=`"$JAVA" "-Dzookeeper.log.dir=${ZOO_LOG_DIR}" 
> "-Dzookeeper.root.logger=${ZOO_LOG4J_PROP}" 
> "-Dzookeeper.log.file=${ZOO_LOG_FILE}" \
>  -cp "$CLASSPATH" $JVMFLAGS org.apache.zookeeper.client.FourLetterWordMain \
>  $clientPortAddress $clientPort srvr 2> /dev/null \
> otw, ./zkServer.sh status will fail.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ZOOKEEPER-3344) write a new script:zkSnapShotToolkit.sh to encapsulate SnapshotFormatter.java

2019-06-05 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling reassigned ZOOKEEPER-3344:
--

Assignee: maoling

> write a new script:zkSnapShotToolkit.sh to encapsulate SnapshotFormatter.java
> -
>
> Key: ZOOKEEPER-3344
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3344
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: scripts
>Affects Versions: 3.5.4
>Reporter: maoling
>Assignee: maoling
>Priority: Major
>
> write a new script:*zkSnapShotToolkit.sh* to encapsulate 
> *SnapshotFormatter.java*
> just like*: zkTxnLogToolkit.sh* for the users' convenience.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ZOOKEEPER-3380) A revist to the quota mechanism

2019-06-05 Thread maoling (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856551#comment-16856551
 ] 

maoling commented on ZOOKEEPER-3380:


[~lvfangmin]

I leave the throught quota feature for you to do: D

> A revist to the quota mechanism
> ---
>
> Key: ZOOKEEPER-3380
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3380
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: maoling
>Priority: Major
> Fix For: 3.6.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ZOOKEEPER-3413) add a serialVersionUID for ClientCnxnLimitException to make compile no warning

2019-06-05 Thread maoling (JIRA)
maoling created ZOOKEEPER-3413:
--

 Summary: add a serialVersionUID for ClientCnxnLimitException to 
make compile no warning
 Key: ZOOKEEPER-3413
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3413
 Project: ZooKeeper
  Issue Type: Improvement
  Components: java client
Affects Versions: 3.6.0
Reporter: maoling


build-generated:
 [javac] Compiling 2 source files to 
/Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes

compile:
 [javac] Compiling 49 source files to 
/Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
 [javac] 
/Users/wenba/workspaces/workspace_zookeeper/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/ClientCnxnLimitException.java:24:
 警告: [serial] 可序列化类ClientCnxnLimitException没有 serialVersionUID 的定义
 [javac] public class ClientCnxnLimitException extends Exception {
 [javac] ^
 [javac] 1 个警告



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ZOOKEEPER-3414) sync api should throw NoNodeException when syncing a path which is not exist

2019-06-05 Thread maoling (JIRA)
maoling created ZOOKEEPER-3414:
--

 Summary: sync api should throw NoNodeException when syncing a path 
which is not exist
 Key: ZOOKEEPER-3414
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3414
 Project: ZooKeeper
  Issue Type: Bug
  Components: java client
Reporter: maoling
 Fix For: 3.6.0


[zk: 127.0.0.1:2180(CONNECTED) 0] sync /c1
Sync is OK
[zk: 127.0.0.1:2180(CONNECTED) 1] sync /c1dsafasdfasdfadsfasd
Node does not exist: /c1dsafasdfasdfadsfasd



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ZOOKEEPER-2842) optimize the finish() of Send/RecvWorker in QuorumCnxManager and remove testInitiateConnection() and formates some codes

2019-06-05 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling resolved ZOOKEEPER-2842.

Resolution: Won't Do

> optimize the finish() of Send/RecvWorker in QuorumCnxManager and remove 
> testInitiateConnection() and formates some codes
> 
>
> Key: ZOOKEEPER-2842
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2842
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: maoling
>Priority: Trivial
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> 1.the finish() of Send/RecvWorker in QuorumCnxManager changes to 
> double-checked lock style 
> [https://en.wikipedia.org/wiki/Double-checked_locking]
> ,a trivial code changes implement a smaller granularity lock to have a better 
> perfermance in too fierce multithread situation.
> 2.testInitiateConnection() is redundant test function which is only used in 
> TestCase,so I refactor it.
> 3.some codes don't abide to Java Programme Specification ,so I lift a finger 
> to format them



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ZOOKEEPER-3344) write a new script:zkSnapShotToolkit.sh to encapsulate SnapshotFormatter and doc the usage

2019-06-07 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3344:
---
Affects Version/s: (was: 3.5.4)
   3.6.0

> write a new script:zkSnapShotToolkit.sh to encapsulate SnapshotFormatter and 
> doc the usage
> --
>
> Key: ZOOKEEPER-3344
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3344
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: scripts
>Affects Versions: 3.6.0
>Reporter: maoling
>Assignee: maoling
>Priority: Major
>
> write a new script:*zkSnapShotToolkit.sh* to encapsulate 
> *SnapshotFormatter.java*
> just like*: zkTxnLogToolkit.sh* for the users' convenience.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ZOOKEEPER-3344) write a new script:zkSnapShotToolkit.sh to encapsulate SnapshotFormatter and doc the usage

2019-06-07 Thread maoling (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858665#comment-16858665
 ] 

maoling commented on ZOOKEEPER-3344:


*$ ./zkSnapShotToolkit.cmd -json E:/tmp/zookeeper/version-2/snapshot.0*

2019-06-07 21:46:40,931 [myid:] - INFO  [main:SnapStream@63] - 
zookeeper.snapshot.compression.method=CHECKED

2019-06-07 21:46:40,972 [myid:] - INFO  [main:WatchManagerFactory@44] - Using 
org.apache.zookeeper.server.watch.WatchManager as watch manager

2019-06-07 21:46:40,973 [myid:] - INFO  [main:WatchManagerFactory@44] - Using 
org.apache.zookeeper.server.watch.WatchManager as watch manager

[1,0,\{"progname":"SnapshotFormatter.java","progver":"0.01","timestamp":1559915200978},[\{"name":"\/","asize":0,"dsize":0,"dev":0,"ino":1001},[\{"name":"zookeeper","asize":0,"dsize":0,"dev":0,"ino":1002},\{"name":"config","asize":0,"dsize":0,"dev":0,"ino":1003},\{"name":"quota","asize":0,"dsize":0,"dev":0,"ino":1004}]]]

*$ ./zkSnapShotToolkit.cmd -json E:/tmp/zookeeper/version-2/snapshot.3*

2019-06-07 21:46:49,779 [myid:] - INFO  [main:SnapStream@63] - 
zookeeper.snapshot.compression.method=CHECKED

2019-06-07 21:46:49,821 [myid:] - INFO  [main:WatchManagerFactory@44] - Using 
org.apache.zookeeper.server.watch.WatchManager as watch manager

2019-06-07 21:46:49,821 [myid:] - INFO  [main:WatchManagerFactory@44] - Using 
org.apache.zookeeper.server.watch.WatchManager as watch manager

[1,0,\{"progname":"SnapshotFormatter.java","progver":"0.01","timestamp":1559915209821},[\{"name":"\/","asize":0,"dsize":0,"dev":0,"ino":1001},[\{"name":"zookeeper","asize":0,"dsize":0,"dev":0,"ino":1002},\{"name":"config","asize":0,"dsize":0,"dev":0,"ino":1003},\{"name":"quota","asize":0,"dsize":0,"dev":0,"ino":1004}],\{"name":"test","asize":6,"dsize":6,"dev":0,"ino":1005}]]

> write a new script:zkSnapShotToolkit.sh to encapsulate SnapshotFormatter and 
> doc the usage
> --
>
> Key: ZOOKEEPER-3344
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3344
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: scripts
>Affects Versions: 3.6.0
>Reporter: maoling
>Assignee: maoling
>Priority: Major
>
> write a new script:*zkSnapShotToolkit.sh* to encapsulate 
> *SnapshotFormatter.java*
> just like*: zkTxnLogToolkit.sh* for the users' convenience.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ZOOKEEPER-3410) ./zkTxnLogToolkit.sh will throw the NPE and stop the process of formatting txn logs due to the data's content is null

2019-06-08 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling reassigned ZOOKEEPER-3410:
--

Assignee: maoling

> ./zkTxnLogToolkit.sh will throw the NPE and stop the process of formatting 
> txn logs due to the data's content is null
> -
>
> Key: ZOOKEEPER-3410
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3410
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: scripts
>Affects Versions: 3.6.0
>Reporter: maoling
>Assignee: maoling
>Priority: Minor
>
> [zk: 127.0.0.1:2180(CONNECTED) 26] create -t 500 /ttl_node
> 19-5-30 下午06时10分50秒 session 0x10007a75c0c cxid 0x0 zxid 0x6 createSession 
> 3
> Exception in thread "main" java.lang.NullPointerException
>  at java.lang.String.(String.java:566)
>  at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.getDataStrFromTxn(TxnLogToolkit.java:316)
>  at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.printTxn(TxnLogToolkit.java:272)
>  at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.printTxn(TxnLogToolkit.java:266)
>  at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.dump(TxnLogToolkit.java:217)
>  at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.main(TxnLogToolkit.java:116)
> t*xnData.append(createTTLTxn.getPath() + "," + new 
> String(createTTLTxn.getData()))*
>  *.append("," + createTTLTxn.getAcl() + "," + 
> createTTLTxn.getParentCVersion())*
>  *.append("," + createTTLTxn.getTtl());*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ZOOKEEPER-3344) write a new script:zkSnapShotToolkit.sh to encapsulate SnapshotFormatter and doc the usage

2019-06-05 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3344:
---
Summary: write a new script:zkSnapShotToolkit.sh to encapsulate 
SnapshotFormatter and doc the usage  (was: write a new 
script:zkSnapShotToolkit.sh to encapsulate SnapshotFormatter.java)

> write a new script:zkSnapShotToolkit.sh to encapsulate SnapshotFormatter and 
> doc the usage
> --
>
> Key: ZOOKEEPER-3344
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3344
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: scripts
>Affects Versions: 3.5.4
>Reporter: maoling
>Assignee: maoling
>Priority: Major
>
> write a new script:*zkSnapShotToolkit.sh* to encapsulate 
> *SnapshotFormatter.java*
> just like*: zkTxnLogToolkit.sh* for the users' convenience.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ZOOKEEPER-3413) add a serialVersionUID for ClientCnxnLimitException to make compile no warning

2019-06-05 Thread maoling (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857234#comment-16857234
 ] 

maoling commented on ZOOKEEPER-3413:


[~eolivelli]

I reproduce this issue anymore.this may be caused from ZOOKEEPER-3385: fix 
build break.

> add a serialVersionUID for ClientCnxnLimitException to make compile no warning
> --
>
> Key: ZOOKEEPER-3413
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3413
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: java client
>Affects Versions: 3.6.0
>Reporter: maoling
>Priority: Minor
>
> build-generated:
>  [javac] Compiling 2 source files to 
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
> compile:
>  [javac] Compiling 49 source files to 
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
>  [javac] 
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/ClientCnxnLimitException.java:24:
>  警告: [serial] 可序列化类ClientCnxnLimitException没有 serialVersionUID 的定义
>  [javac] public class ClientCnxnLimitException extends Exception {
>  [javac] ^
>  [javac] 1 个警告



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ZOOKEEPER-3413) add a serialVersionUID for ClientCnxnLimitException to make compile no warning

2019-06-05 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling resolved ZOOKEEPER-3413.

Resolution: Won't Fix

> add a serialVersionUID for ClientCnxnLimitException to make compile no warning
> --
>
> Key: ZOOKEEPER-3413
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3413
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: java client
>Affects Versions: 3.6.0
>Reporter: maoling
>Priority: Minor
>
> build-generated:
>  [javac] Compiling 2 source files to 
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
> compile:
>  [javac] Compiling 49 source files to 
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
>  [javac] 
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/ClientCnxnLimitException.java:24:
>  警告: [serial] 可序列化类ClientCnxnLimitException没有 serialVersionUID 的定义
>  [javac] public class ClientCnxnLimitException extends Exception {
>  [javac] ^
>  [javac] 1 个警告



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ZOOKEEPER-3322) ./zkServer.sh status failed when reconfig don't write the clientPort into the zoo.cfg

2019-06-04 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling reassigned ZOOKEEPER-3322:
--

Assignee: maoling

> ./zkServer.sh status failed when reconfig don't write the clientPort into the 
> zoo.cfg
> -
>
> Key: ZOOKEEPER-3322
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3322
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: maoling
>Assignee: maoling
>Priority: Major
>
> look at my zoo.cfg which don't have the clientPort value when using the 
> reconfig.
> *cat ../conf/zoo.cfg*
> reconfigEnabled=true
> dataDir=../../zkdata2
> syncLimit=5
> dataLogDir=../../zkdataLog2
> initLimit=10
> tickTime=2000
> dynamicConfigFile=/data/software/zookeeper/zookeeper-test2/conf/zoo.cfg.dynamic.1f
> but look at the cmd:"./zkServer.sh status",it needs this clientPort value 
> STAT=`"$JAVA" "-Dzookeeper.log.dir=${ZOO_LOG_DIR}" 
> "-Dzookeeper.root.logger=${ZOO_LOG4J_PROP}" 
> "-Dzookeeper.log.file=${ZOO_LOG_FILE}" \
>  -cp "$CLASSPATH" $JVMFLAGS org.apache.zookeeper.client.FourLetterWordMain \
>  $clientPortAddress $clientPort srvr 2> /dev/null \
> otw, ./zkServer.sh status will fail.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ZOOKEEPER-3429) Flaky test test:org.apache.zookeeper.test.DisconnectedWatcherTest.testManyChildWatchersAutoReset

2019-06-13 Thread maoling (JIRA)
maoling created ZOOKEEPER-3429:
--

 Summary: Flaky test 
test:org.apache.zookeeper.test.DisconnectedWatcherTest.testManyChildWatchersAutoReset
 Key: ZOOKEEPER-3429
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3429
 Project: ZooKeeper
  Issue Type: Test
  Components: tests
Reporter: maoling
 Fix For: 3.6.0


[https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-java9/lastFailedBuild/testReport/junit/org.apache.zookeeper.test/DisconnectedWatcherTest/testManyChildWatchersAutoReset/]

 
{code:java}
Error Message
test timed out after 84 milliseconds
Stacktrace
org.junit.runners.model.TestTimedOutException: test timed out after 84 
milliseconds
at java.base@9.0.1/java.lang.Object.wait(Native Method)
at java.base@9.0.1/java.lang.Object.wait(Object.java:516)
at 
app//org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1556)
at 
app//org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1539)
at app//org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:1537)
at 
app//org.apache.zookeeper.test.DisconnectedWatcherTest.testManyChildWatchersAutoReset(DisconnectedWatcherTest.java:247)
at 
java.base@9.0.1/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native 
Method)
at 
java.base@9.0.1/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
java.base@9.0.1/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at 
app//org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:80)
at 
java.base@9.0.1/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base@9.0.1/java.lang.Thread.run(Thread.java:844)
{code}
 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ZOOKEEPER-3428) enable the TTL node and add a lazy-delete strategy to get noNodeException quickly when the ttl node had expired

2019-06-12 Thread maoling (JIRA)
maoling created ZOOKEEPER-3428:
--

 Summary: enable the TTL node and add a lazy-delete strategy to get 
noNodeException quickly when the ttl node had expired
 Key: ZOOKEEPER-3428
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3428
 Project: ZooKeeper
  Issue Type: Improvement
  Components: server
Reporter: maoling
Assignee: maoling
 Fix For: 3.6.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ZOOKEEPER-3301) Enforce the quota limit

2019-06-11 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling reassigned ZOOKEEPER-3301:
--

Assignee: maoling

> Enforce the quota limit
> ---
>
> Key: ZOOKEEPER-3301
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3301
> Project: ZooKeeper
>  Issue Type: Sub-task
>Reporter: maoling
>Assignee: maoling
>Priority: Major
>
> We need a complete quota feature, not just the printing the warning logs 
> which is a bit chicken ribs.
> [zk: localhost:2181(CONNECTED) 18] setquota -n 2 /quota_test
> [zk: localhost:2181(CONNECTED) 19] create /quota_test/child_1
> Created /quota_test/child_1
> [zk: localhost:2181(CONNECTED) 20] create /quota_test/child_2
> Created /quota_test/child_2
> [zk: localhost:2181(CONNECTED) 21] create /quota_test/child_3
> Created /quota_test/child_3
> look at the following logs:
> 2019-03-07 11:22:36,680 [myid:1] - WARN [SyncThread:0:DataTree@374] - Quota 
> exceeded: /quota_test count=3 limit=2
> 2019-03-07 11:22:41,861 [myid:1] - WARN [SyncThread:0:DataTree@374] - Quota 
> exceeded: /quota_test count=4 limit=2



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ZOOKEEPER-3301) Enforce the quota limit

2019-06-11 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3301:
---
Summary: Enforce the quota limit  (was: Enforce the quota limit and doc the 
design of the quota.)

> Enforce the quota limit
> ---
>
> Key: ZOOKEEPER-3301
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3301
> Project: ZooKeeper
>  Issue Type: Sub-task
>Reporter: maoling
>Priority: Major
>
> We need a complete quota feature, not just the printing the warning logs 
> which is a bit chicken ribs.
> [zk: localhost:2181(CONNECTED) 18] setquota -n 2 /quota_test
> [zk: localhost:2181(CONNECTED) 19] create /quota_test/child_1
> Created /quota_test/child_1
> [zk: localhost:2181(CONNECTED) 20] create /quota_test/child_2
> Created /quota_test/child_2
> [zk: localhost:2181(CONNECTED) 21] create /quota_test/child_3
> Created /quota_test/child_3
> look at the following logs:
> 2019-03-07 11:22:36,680 [myid:1] - WARN [SyncThread:0:DataTree@374] - Quota 
> exceeded: /quota_test count=3 limit=2
> 2019-03-07 11:22:41,861 [myid:1] - WARN [SyncThread:0:DataTree@374] - Quota 
> exceeded: /quota_test count=4 limit=2



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ZOOKEEPER-3423) add VersionInfoMain.java to .gitignore and doc the cmd:"./zkServer.sh version"

2019-06-10 Thread maoling (JIRA)
maoling created ZOOKEEPER-3423:
--

 Summary: add VersionInfoMain.java to .gitignore and doc the 
cmd:"./zkServer.sh version"
 Key: ZOOKEEPER-3423
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3423
 Project: ZooKeeper
  Issue Type: Improvement
  Components: scripts
Reporter: maoling
Assignee: maoling
 Fix For: 3.6.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ZOOKEEPER-3413) add a serialVersionUID for ClientCnxnLimitException to make compile no warning

2019-06-11 Thread maoling (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860644#comment-16860644
 ] 

maoling commented on ZOOKEEPER-3413:


I found this:

[https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/3985/artifact/patchprocess/trunkJavacWarnings.txt]

> add a serialVersionUID for ClientCnxnLimitException to make compile no warning
> --
>
> Key: ZOOKEEPER-3413
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3413
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: java client
>Affects Versions: 3.6.0
>Reporter: maoling
>Priority: Minor
>
> build-generated:
>  [javac] Compiling 2 source files to 
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
> compile:
>  [javac] Compiling 49 source files to 
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
>  [javac] 
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/ClientCnxnLimitException.java:24:
>  警告: [serial] 可序列化类ClientCnxnLimitException没有 serialVersionUID 的定义
>  [javac] public class ClientCnxnLimitException extends Exception {
>  [javac] ^
>  [javac] 1 个警告



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ZOOKEEPER-3410) ./zkTxnLogToolkit.sh will throw the NPE and stop the process of formatting txn logs due to the data's content is null

2019-06-09 Thread maoling (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859383#comment-16859383
 ] 

maoling commented on ZOOKEEPER-3410:


*./zkTxnLogToolkit.sh /data/zkBackup/version-2/log.57*
ZooKeeper Transactional Log File with dbid 0 txnlog format version 2
19-6-8 下午05时39分33秒 session 0x1000978b385 cxid 0x0 zxid 0x57 createSession 
3
19-6-8 下午05时39分42秒 session 0x1000978b385 cxid 0x2 zxid 0x58 create 
/p_node*,,*[31,s\{'world,'anyone}
],false,13
19-6-8 下午05时39分52秒 session 0x1000978b385 cxid 0x3 zxid 0x59 createContainer 
/container_node*,,*[31,s\{'world,'anyone}
],14
19-6-8 下午05时39分59秒 session 0x100091e93c20001 cxid 0x0 zxid 0x5a closeSession
19-6-8 下午05时40分04秒 session 0x1000978b385 cxid 0x4 zxid 0x5b createTtl 
/ttl_node*,,*[31,s\{'world,'anyone}
],15,1000
19-6-8 下午05时40分28秒 session 0x0 cxid 0x0 zxid 0x5c deleteContainer '/ttl_node
19-6-8 下午05时40分37秒 session 0x1000978b385 cxid 0x0 zxid 0x5d closeSession
EOF reached after 7 txns.


*./zkTxnLogToolkit.sh /data/zkBackup/version-2/log.5e*
19-6-9 下午02时38分59秒 session 0x1000aec8ddd cxid 0x0 zxid 0x5e createSession 
3
19-6-9 下午02时39分27秒 session 0x1000aec8ddd cxid 0x1 zxid 0x5f create 
/05-09-node,,[31,s\{'world,'anyone}
],false,16
19-6-9 下午02时39分41秒 session 0x1000aec8ddd cxid 0x2 zxid 0x60 error -101
19-6-9 下午02时39分53秒 session 0x1000aec8ddd cxid 0x3 zxid 0x61 error -101
19-6-9 下午02时40分34秒 session 0x1000aec8ddd cxid 0x0 zxid 0x62 closeSession
19-6-9 下午02时43分08秒 session 0x1000aec8ddd0001 cxid 0x0 zxid 0x63 createSession 
3
19-6-9 下午02时43分17秒 session 0x1000aec8ddd0001 cxid 0x3 zxid 0x64 error -110
19-6-9 下午02时44分06秒 session 0x1000aec8ddd0001 cxid 0x5 zxid 0x65 setData 
/05-09-node,,1
19-6-9 下午02时50分32秒 session 0x1000aec8ddd0001 cxid 0x6 zxid 0x66 create 
/06-09,,[31,s\{'world,'anyone}
],false,17
19-6-9 下午02时50分39秒 session 0x1000aec8ddd0001 cxid 0x8 zxid 0x67 setData 
/06-09,,1
19-6-9 下午02时51分16秒 session 0x1000aec8ddd0001 cxid 0x9 zxid 0x68 create 
/ttl-node-2,,[31,s\{'world,'anyone}
],false,18
19-6-9 下午02时51分26秒 session 0x1000aec8ddd0001 cxid 0xa zxid 0x69 createContainer 
/container-node-2,,[31,s\{'world,'anyone}
],19
EOF reached after 12 txns.

> ./zkTxnLogToolkit.sh will throw the NPE and stop the process of formatting 
> txn logs due to the data's content is null
> -
>
> Key: ZOOKEEPER-3410
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3410
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: scripts
>Affects Versions: 3.6.0
>Reporter: maoling
>Assignee: maoling
>Priority: Minor
>
> [zk: 127.0.0.1:2180(CONNECTED) 26] create -t 500 /ttl_node
> 19-5-30 下午06时10分50秒 session 0x10007a75c0c cxid 0x0 zxid 0x6 createSession 
> 3
> Exception in thread "main" java.lang.NullPointerException
>  at java.lang.String.(String.java:566)
>  at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.getDataStrFromTxn(TxnLogToolkit.java:316)
>  at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.printTxn(TxnLogToolkit.java:272)
>  at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.printTxn(TxnLogToolkit.java:266)
>  at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.dump(TxnLogToolkit.java:217)
>  at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.main(TxnLogToolkit.java:116)
> t*xnData.append(createTTLTxn.getPath() + "," + new 
> String(createTTLTxn.getData()))*
>  *.append("," + createTTLTxn.getAcl() + "," + 
> createTTLTxn.getParentCVersion())*
>  *.append("," + createTTLTxn.getTtl());*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ZOOKEEPER-3417) add the new doc:zookeeperProtocols to introduce the implementation details of ZAB comparing with raft

2019-06-09 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling reassigned ZOOKEEPER-3417:
--

Assignee: maoling

> add the new doc:zookeeperProtocols to introduce the implementation details of 
> ZAB comparing with raft
> -
>
> Key: ZOOKEEPER-3417
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3417
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: documentation
>Affects Versions: 3.6.0
>Reporter: maoling
>Assignee: maoling
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Issue Comment Deleted] (ZOOKEEPER-3413) add a serialVersionUID for ClientCnxnLimitException to make compile no warning

2019-06-11 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3413:
---
Comment: was deleted

(was: [~eolivelli]

I cannot reproduce this issue anymore.this may be caused from ZOOKEEPER-3385: 
fix build break.)

> add a serialVersionUID for ClientCnxnLimitException to make compile no warning
> --
>
> Key: ZOOKEEPER-3413
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3413
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: java client
>Affects Versions: 3.6.0
>Reporter: maoling
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> build-generated:
>  [javac] Compiling 2 source files to 
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
> compile:
>  [javac] Compiling 49 source files to 
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
>  [javac] 
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/ClientCnxnLimitException.java:24:
>  警告: [serial] 可序列化类ClientCnxnLimitException没有 serialVersionUID 的定义
>  [javac] public class ClientCnxnLimitException extends Exception {
>  [javac] ^
>  [javac] 1 个警告



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ZOOKEEPER-3425) ttl node should not have the children

2019-06-11 Thread maoling (JIRA)
maoling created ZOOKEEPER-3425:
--

 Summary: ttl node should not have the children
 Key: ZOOKEEPER-3425
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3425
 Project: ZooKeeper
  Issue Type: Improvement
  Components: server
Reporter: maoling
Assignee: maoling
 Fix For: 3.6.0


ttl node should not have the children



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ZOOKEEPER-3438) Flaky test:org.apache.zookeeper.server.PrepRequestProcessorMetricsTest.testPrepRequestProcessorMetrics

2019-06-22 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling resolved ZOOKEEPER-3438.

Resolution: Not A Problem

> Flaky 
> test:org.apache.zookeeper.server.PrepRequestProcessorMetricsTest.testPrepRequestProcessorMetrics
> --
>
> Key: ZOOKEEPER-3438
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3438
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: tests
>Reporter: maoling
>Priority: Minor
> Fix For: 3.6.0
>
>
> [https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build-maven/org.apache.zookeeper$zookeeper/844/testReport/junit/org.apache.zookeeper.server/PrepRequestProcessorMetricsTest/testPrepRequestProcessorMetrics/]
> {code:java}
> Error Message
> expected:<5> but was:<4>
> Stacktrace
> java.lang.AssertionError: expected:<5> but was:<4>
>   at 
> org.apache.zookeeper.server.PrepRequestProcessorMetricsTest.testPrepRequestProcessorMetrics(PrepRequestProcessorMetricsTest.java:146)
> Standard Output
> 2019-06-21 09:09:37,915 [myid:] - INFO  [main:ZKTestCase$1@60] - STARTING 
> testPrepRequestProcessorMetrics
> 2019-06-21 09:09:37,917 [myid:] - INFO  
> [main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - RUNNING TEST METHOD 
> testPrepRequestProcessorMetrics
> 2019-06-21 09:09:37,951 [myid:] - ERROR [ProcessThread(sid:0 
> cport:-1)::PrepRequestProcessor@1002] - Failed to process sessionid:0x1 
> type:setData cxid:0x0 zxid:0x1 txntype:5 reqpath:n/a
> java.lang.NullPointerException
>   at 
> org.apache.zookeeper.server.PrepRequestProcessor.pRequest2Txn(PrepRequestProcessor.java:521)
>   at 
> org.apache.zookeeper.server.PrepRequestProcessor.pRequest(PrepRequestProcessor.java:872)
>   at 
> org.apache.zookeeper.server.PrepRequestProcessor.run(PrepRequestProcessor.java:156)
> 2019-06-21 09:09:37,952 [myid:] - ERROR [ProcessThread(sid:0 
> cport:-1)::PrepRequestProcessor@1015] - Dumping request buffer: 
> 0x00042f666f6f
> 2019-06-21 09:09:37,959 [myid:] - INFO  
> [main:JUnit4ZKTestRunner$LoggedInvokeMethod@99] - TEST METHOD FAILED 
> testPrepRequestProcessorMetrics
> java.lang.AssertionError: expected:<5> but was:<4>
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.failNotEquals(Assert.java:834)
>   at org.junit.Assert.assertEquals(Assert.java:118)
>   at org.junit.Assert.assertEquals(Assert.java:144)
>   at 
> org.apache.zookeeper.server.PrepRequestProcessorMetricsTest.testPrepRequestProcessorMetrics(PrepRequestProcessorMetricsTest.java:146)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:80)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
>   at 
> 

[jira] [Assigned] (ZOOKEEPER-3400) Add documentation on local sessions

2019-06-19 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling reassigned ZOOKEEPER-3400:
--

Assignee: maoling

> Add documentation on local sessions
> ---
>
> Key: ZOOKEEPER-3400
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3400
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 3.6.0, 3.5.6
>Reporter: Brian Nixon
>Assignee: maoling
>Priority: Trivial
>
> ZOOKEEPER-1147 added local sessions (client sessions not ratified by the 
> leader) to ZooKeeper as a lightweight augmentation of the existing global 
> sessions.
>  
> Add some outward facing documentation that describes this feature 
> ([https://zookeeper.apache.org/doc/r3.5.5/zookeeperProgrammers.html#ch_zkSessions]
>  seems like a reasonable place).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ZOOKEEPER-3400) Add documentation on local sessions

2019-06-19 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3400:
---
Priority: Major  (was: Trivial)

> Add documentation on local sessions
> ---
>
> Key: ZOOKEEPER-3400
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3400
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 3.6.0, 3.5.6
>Reporter: Brian Nixon
>Assignee: maoling
>Priority: Major
>
> ZOOKEEPER-1147 added local sessions (client sessions not ratified by the 
> leader) to ZooKeeper as a lightweight augmentation of the existing global 
> sessions.
>  
> Add some outward facing documentation that describes this feature 
> ([https://zookeeper.apache.org/doc/r3.5.5/zookeeperProgrammers.html#ch_zkSessions]
>  seems like a reasonable place).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ZOOKEEPER-3434) [FileTabCharacter] clear up the all the checkstyle violations in the zookeeper-server module

2019-06-19 Thread maoling (JIRA)
maoling created ZOOKEEPER-3434:
--

 Summary: [FileTabCharacter] clear up the all the checkstyle 
violations in the zookeeper-server module
 Key: ZOOKEEPER-3434
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3434
 Project: ZooKeeper
  Issue Type: Sub-task
Reporter: maoling
Assignee: maoling


[FileTabCharacter] clear up the all the checkstyle violations in the 
zookeeper-server module



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ZOOKEEPER-3431) clear up the all the checkstyle violations in the zookeeper-server module

2019-06-19 Thread maoling (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868226#comment-16868226
 ] 

maoling commented on ZOOKEEPER-3431:


[~eolivelli] Let me send the email and describe my planing and trigger the 
discussion.

> clear up the all the checkstyle violations in the zookeeper-server module
> -
>
> Key: ZOOKEEPER-3431
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3431
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: maoling
>Priority: Major
> Fix For: 3.6.0
>
>
> it's time to clear up the all the checkstyle violations(turn on the 
> {{true}}). we can learn from the hbase 
> whose checkstyle is very strict and ensures a very unified code style.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ZOOKEEPER-3431) clean up the all the checkstyle violations in the zookeeper-server module

2019-06-23 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3431:
---
Summary: clean up the all the checkstyle violations in the zookeeper-server 
module  (was: clear up the all the checkstyle violations in the 
zookeeper-server module)

> clean up the all the checkstyle violations in the zookeeper-server module
> -
>
> Key: ZOOKEEPER-3431
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3431
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: maoling
>Priority: Major
> Fix For: 3.6.0
>
>
> it's time to clear up the all the checkstyle violations(turn on the 
> {{true}}). we can learn from the hbase 
> whose checkstyle is very strict and ensures a very unified code style.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ZOOKEEPER-3429) Flaky test test:org.apache.zookeeper.test.DisconnectedWatcherTest.testManyChildWatchersAutoReset

2019-07-04 Thread maoling (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878936#comment-16878936
 ] 

maoling commented on ZOOKEEPER-3429:


[https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build-maven/org.apache.zookeeper$zookeeper/898/testReport/junit/org.apache.zookeeper.test/DisconnectedWatcherTest/testManyChildWatchersAutoReset/]

> Flaky test 
> test:org.apache.zookeeper.test.DisconnectedWatcherTest.testManyChildWatchersAutoReset
> 
>
> Key: ZOOKEEPER-3429
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3429
> Project: ZooKeeper
>  Issue Type: Test
>  Components: tests
>Reporter: maoling
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> [https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-java9/lastFailedBuild/testReport/junit/org.apache.zookeeper.test/DisconnectedWatcherTest/testManyChildWatchersAutoReset/]
>  
> {code:java}
> Error Message
> test timed out after 84 milliseconds
> Stacktrace
> org.junit.runners.model.TestTimedOutException: test timed out after 84 
> milliseconds
>   at java.base@9.0.1/java.lang.Object.wait(Native Method)
>   at java.base@9.0.1/java.lang.Object.wait(Object.java:516)
>   at 
> app//org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1556)
>   at 
> app//org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1539)
>   at app//org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:1537)
>   at 
> app//org.apache.zookeeper.test.DisconnectedWatcherTest.testManyChildWatchersAutoReset(DisconnectedWatcherTest.java:247)
>   at 
> java.base@9.0.1/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native 
> Method)
>   at 
> java.base@9.0.1/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> java.base@9.0.1/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at 
> app//org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:80)
>   at 
> java.base@9.0.1/java.util.concurrent.FutureTask.run(FutureTask.java:264)
>   at java.base@9.0.1/java.lang.Thread.run(Thread.java:844)
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ZOOKEEPER-3447) add a doc: zookeeperMonitor.md

2019-06-28 Thread maoling (JIRA)
maoling created ZOOKEEPER-3447:
--

 Summary: add a doc: zookeeperMonitor.md
 Key: ZOOKEEPER-3447
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3447
 Project: ZooKeeper
  Issue Type: New Feature
  Components: documentation
Reporter: maoling
Assignee: maoling
 Fix For: 3.6.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ZOOKEEPER-3400) Add documentation on local sessions

2019-06-28 Thread maoling (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874854#comment-16874854
 ] 

maoling commented on ZOOKEEPER-3400:


I am working on working this doc.:D

> Add documentation on local sessions
> ---
>
> Key: ZOOKEEPER-3400
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3400
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 3.6.0, 3.5.6
>Reporter: Brian Nixon
>Assignee: maoling
>Priority: Major
>
> ZOOKEEPER-1147 added local sessions (client sessions not ratified by the 
> leader) to ZooKeeper as a lightweight augmentation of the existing global 
> sessions.
>  
> Add some outward facing documentation that describes this feature 
> ([https://zookeeper.apache.org/doc/r3.5.5/zookeeperProgrammers.html#ch_zkSessions]
>  seems like a reasonable place).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ZOOKEEPER-3410) ./zkTxnLogToolkit.sh will throw the NPE and stop the process of formatting txn logs due to the data's content is null

2019-07-11 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling resolved ZOOKEEPER-3410.

Resolution: Resolved

> ./zkTxnLogToolkit.sh will throw the NPE and stop the process of formatting 
> txn logs due to the data's content is null
> -
>
> Key: ZOOKEEPER-3410
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3410
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: scripts
>Affects Versions: 3.6.0
>Reporter: maoling
>Assignee: maoling
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> [zk: 127.0.0.1:2180(CONNECTED) 26] create -t 500 /ttl_node
> 19-5-30 下午06时10分50秒 session 0x10007a75c0c cxid 0x0 zxid 0x6 createSession 
> 3
> Exception in thread "main" java.lang.NullPointerException
>  at java.lang.String.(String.java:566)
>  at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.getDataStrFromTxn(TxnLogToolkit.java:316)
>  at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.printTxn(TxnLogToolkit.java:272)
>  at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.printTxn(TxnLogToolkit.java:266)
>  at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.dump(TxnLogToolkit.java:217)
>  at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.main(TxnLogToolkit.java:116)
> t*xnData.append(createTTLTxn.getPath() + "," + new 
> String(createTTLTxn.getData()))*
>  *.append("," + createTTLTxn.getAcl() + "," + 
> createTTLTxn.getParentCVersion())*
>  *.append("," + createTTLTxn.getTtl());*



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Created] (ZOOKEEPER-3461) add a doc about the admin server command

2019-07-12 Thread maoling (JIRA)
maoling created ZOOKEEPER-3461:
--

 Summary: add a doc about the admin server command
 Key: ZOOKEEPER-3461
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3461
 Project: ZooKeeper
  Issue Type: Improvement
  Components: documentation
Affects Versions: 3.6.0
Reporter: maoling






--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (ZOOKEEPER-3461) add a doc about the admin server command

2019-07-12 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3461:
---
Description: 
{code:java}


 The AdminServer

**New in 3.5.0:** The AdminServer is
an embedded Jetty server that provides an HTTP interface to the four
letter word commands. By default, the server is started on port 8080,
and commands are issued by going to the URL "/commands/\[command name]",
e.g., http://localhost:8080/commands/stat. The command response is
returned as JSON. Unlike the original protocol, commands are not
{code}

> add a doc about the admin server command
> 
>
> Key: ZOOKEEPER-3461
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3461
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 3.6.0
>Reporter: maoling
>Priority: Major
>
> {code:java}
> 
>  The AdminServer
> **New in 3.5.0:** The AdminServer is
> an embedded Jetty server that provides an HTTP interface to the four
> letter word commands. By default, the server is started on port 8080,
> and commands are issued by going to the URL "/commands/\[command name]",
> e.g., http://localhost:8080/commands/stat. The command response is
> returned as JSON. Unlike the original protocol, commands are not
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (ZOOKEEPER-3423) use the maven-like way to ignore the generated version java files and doc the cmd:'./zkServer.sh version'

2019-07-07 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3423:
---
Summary: use the maven-like way to ignore the generated version java files 
and doc the cmd:'./zkServer.sh version'  (was: add VersionInfoMain.java to 
.gitignore and doc the cmd:"./zkServer.sh version")

> use the maven-like way to ignore the generated version java files and doc the 
> cmd:'./zkServer.sh version'
> -
>
> Key: ZOOKEEPER-3423
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3423
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: scripts
>Reporter: maoling
>Assignee: maoling
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 3h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ZOOKEEPER-3456) Service temporarily unavailable due to an ongoing leader election. Please refresh

2019-07-08 Thread maoling (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880877#comment-16880877
 ] 

maoling commented on ZOOKEEPER-3456:


[~Mar_zieh] 

At the first, I think you should *ping* or *telnet* the server2 from other node 
to check the network issue

> Service temporarily unavailable due to an ongoing leader election. Please 
> refresh
> -
>
> Key: ZOOKEEPER-3456
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3456
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
> Environment: docker container with Ubuntu 16.04
>Reporter: Marzieh
>Priority: Major
> Fix For: 3.4.14
>
>
> Hi
> I configured Zookeeper with four nodes for my Mesos cluster with Marathon. 
> When I ran Flink Json file on Marathon, it was run without problem. But, when 
> I entered IP of my two slaves, just one slave shew Flink UI and another slave 
> shew this error:
>  
> Service temporarily unavailable due to an ongoing leader election. Please 
> refresh
> I checked "zookeeper.out" file and it said that :
>  
> 019-07-07 11:48:43,412 [myid:] - INFO [main:QuorumPeerConfig@136] - Reading 
> configuration from: /home/zookeeper-3.4.14/bin/../conf/zoo.cfg
> 2019-07-07 11:48:43,421 [myid:] - INFO [main:QuorumPeer$QuorumServer@185] - 
> Resolved hostname: 0.0.0.0 to address: /0.0.0.0
> 2019-07-07 11:48:43,421 [myid:] - INFO [main:QuorumPeer$QuorumServer@185] - 
> Resolved hostname: 10.32.0.3 to address: /10.32.0.3
> 2019-07-07 11:48:43,422 [myid:] - INFO [main:QuorumPeer$QuorumServer@185] - 
> Resolved hostname: 10.32.0.2 to address: /10.32.0.2
> 2019-07-07 11:48:43,422 [myid:] - INFO [main:QuorumPeer$QuorumServer@185] - 
> Resolved hostname: 10.32.0.5 to address: /10.32.0.5
> 2019-07-07 11:48:43,422 [myid:] - WARN [main:QuorumPeerConfig@354] - 
> Non-optimial configuration, consider an odd number of servers.
> 2019-07-07 11:48:43,422 [myid:] - INFO [main:QuorumPeerConfig@398] - 
> Defaulting to majority quorums
> 2019-07-07 11:48:43,425 [myid:3] - INFO [main:DatadirCleanupManager@78] - 
> autopurge.snapRetainCount set to 3
> 2019-07-07 11:48:43,425 [myid:3] - INFO [main:DatadirCleanupManager@79] - 
> autopurge.purgeInterval set to 0
> 2019-07-07 11:48:43,425 [myid:3] - INFO [main:DatadirCleanupManager@101] - 
> Purge task is not scheduled.
> 2019-07-07 11:48:43,432 [myid:3] - INFO [main:QuorumPeerMain@130] - Starting 
> quorum peer
> 2019-07-07 11:48:43,437 [myid:3] - INFO [main:ServerCnxnFactory@117] - Using 
> org.apache.zookeeper.server.NIOServerCnxnFactory as server connect$
> 2019-07-07 11:48:43,439 [myid:3] - INFO [main:NIOServerCnxnFactory@89] - 
> binding to port 0.0.0.0/0.0.0.0:2181
> 2019-07-07 11:48:43,440 [myid:3] - ERROR [main:QuorumPeerMain@92] - 
> Unexpected exception, exiting abnormally
> java.net.BindException: Address already in use
>  at sun.nio.ch.Net.bind0(Native Method)
>  at sun.nio.ch.Net.bind(Net.java:433)
>  at sun.nio.ch.Net.bind(Net.java:425)
>  at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223)
>  at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
>  at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67)
>  at 
> org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:90)
>  at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:133)
>  at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:114)
>  at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:81)
>  
> I searched a lot and could not find the solution.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ZOOKEEPER-3454) add a new CLI: quorumInfo

2019-07-04 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3454:
---
Summary: add a new CLI: quorumInfo  (was: add a new CLI: q)

> add a new CLI: quorumInfo
> -
>
> Key: ZOOKEEPER-3454
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3454
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: java client
>Reporter: maoling
>Assignee: maoling
>Priority: Major
>
> ./etcdctl -w table --endpoints=127.0.0.1:2379,127.0.0.1:3379,127.0.0.1:4379 
> endpoint status
> ++--+-+-+---+---++
> | ENDPOINT | ID | VERSION | DB SIZE | IS LEADER | RAFT TERM | RAFT INDEX |
> ++--+-+-+---+---++
> | 127.0.0.1:2379 | 2d6d41b3de34869d | 3.3.11 | 20 kB | true | 46 | 18 |
> | 127.0.0.1:3379 | fa452fb497312bf1 | 3.3.11 | 20 kB | false | 46 | 18 |
> | 127.0.0.1:4379 | a20a53b92b8e7e56 | 3.3.11 | 20 kB | false | 46 | 18 |
> ++--+-+-+---+---++
> [用name会报错]:Error: dial tcp: lookup etcd-1 on 10.9.255.1:53: no such host
> ./etcdctl -w table --endpoints=etcd-1:2379,etcd-2:3379,etcd-3:4379 endpoint 
> status
> ./etcdctl endpoint health
> ./etcdctl --endpoints=127.0.0.1:2379,127.0.0.1:3379,127.0.0.1:4379 health
> 127.0.0.1:2379 is healthy: successfully committed proposal: took = 1.454841ms
> ./etcdctl member list
>  3fcd54d1766f30b4: name=etcd-2 peerURLs=http://127.0.0.1:2381 
> clientURLs=http://127.0.0.1:3379,http://127.0.0.1:3379 isLeader=false
>  48e24310bdb358ce: name=etcd-1 peerURLs=http://127.0.0.1:2380 
> clientURLs=http://127.0.0.1:2379,http://127.0.0.1:2379 isLeader=true
>  66846ef509b1c4d7: name=etcd-3 peerURLs=http://127.0.0.1:2382 
> clientURLs=http://127.0.0.1:4379,http://127.0.0.1:4379 isLeader=false



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ZOOKEEPER-3454) add a new CLI: q

2019-07-04 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3454:
---
Summary: add a new CLI: q  (was: add a new CLI: memberlist)

> add a new CLI: q
> 
>
> Key: ZOOKEEPER-3454
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3454
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: java client
>Reporter: maoling
>Assignee: maoling
>Priority: Major
>
> ./etcdctl -w table --endpoints=127.0.0.1:2379,127.0.0.1:3379,127.0.0.1:4379 
> endpoint status
> ++--+-+-+---+---++
> | ENDPOINT | ID | VERSION | DB SIZE | IS LEADER | RAFT TERM | RAFT INDEX |
> ++--+-+-+---+---++
> | 127.0.0.1:2379 | 2d6d41b3de34869d | 3.3.11 | 20 kB | true | 46 | 18 |
> | 127.0.0.1:3379 | fa452fb497312bf1 | 3.3.11 | 20 kB | false | 46 | 18 |
> | 127.0.0.1:4379 | a20a53b92b8e7e56 | 3.3.11 | 20 kB | false | 46 | 18 |
> ++--+-+-+---+---++
> [用name会报错]:Error: dial tcp: lookup etcd-1 on 10.9.255.1:53: no such host
> ./etcdctl -w table --endpoints=etcd-1:2379,etcd-2:3379,etcd-3:4379 endpoint 
> status
> ./etcdctl endpoint health
> ./etcdctl --endpoints=127.0.0.1:2379,127.0.0.1:3379,127.0.0.1:4379 health
> 127.0.0.1:2379 is healthy: successfully committed proposal: took = 1.454841ms
> ./etcdctl member list
>  3fcd54d1766f30b4: name=etcd-2 peerURLs=http://127.0.0.1:2381 
> clientURLs=http://127.0.0.1:3379,http://127.0.0.1:3379 isLeader=false
>  48e24310bdb358ce: name=etcd-1 peerURLs=http://127.0.0.1:2380 
> clientURLs=http://127.0.0.1:2379,http://127.0.0.1:2379 isLeader=true
>  66846ef509b1c4d7: name=etcd-3 peerURLs=http://127.0.0.1:2382 
> clientURLs=http://127.0.0.1:4379,http://127.0.0.1:4379 isLeader=false



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ZOOKEEPER-3425) ttl node should not have the children and ranking the ttl by expireTime asc for the performance

2019-07-01 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3425:
---
Summary: ttl node should not have the children and ranking the ttl by 
expireTime asc for the performance  (was: ttl node should not have the children)

> ttl node should not have the children and ranking the ttl by expireTime asc 
> for the performance
> ---
>
> Key: ZOOKEEPER-3425
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3425
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: maoling
>Assignee: maoling
>Priority: Major
> Fix For: 3.6.0
>
>
> ttl node should not have the children



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ZOOKEEPER-3454) add a new CLI: memberlist

2019-07-02 Thread maoling (JIRA)
maoling created ZOOKEEPER-3454:
--

 Summary: add a new CLI: memberlist
 Key: ZOOKEEPER-3454
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3454
 Project: ZooKeeper
  Issue Type: New Feature
  Components: java client
Reporter: maoling
Assignee: maoling






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ZOOKEEPER-3454) add a new CLI: memberlist

2019-07-02 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3454:
---
Description: 
./etcdctl -w table --endpoints=127.0.0.1:2379,127.0.0.1:3379,127.0.0.1:4379 
endpoint status
++--+-+-+---+---++
| ENDPOINT | ID | VERSION | DB SIZE | IS LEADER | RAFT TERM | RAFT INDEX |
++--+-+-+---+---++
| 127.0.0.1:2379 | 2d6d41b3de34869d | 3.3.11 | 20 kB | true | 46 | 18 |
| 127.0.0.1:3379 | fa452fb497312bf1 | 3.3.11 | 20 kB | false | 46 | 18 |
| 127.0.0.1:4379 | a20a53b92b8e7e56 | 3.3.11 | 20 kB | false | 46 | 18 |
++--+-+-+---+---++
[用name会报错]:Error: dial tcp: lookup etcd-1 on 10.9.255.1:53: no such host
./etcdctl -w table --endpoints=etcd-1:2379,etcd-2:3379,etcd-3:4379 endpoint 
status


./etcdctl endpoint health
./etcdctl --endpoints=127.0.0.1:2379,127.0.0.1:3379,127.0.0.1:4379 health
127.0.0.1:2379 is healthy: successfully committed proposal: took = 1.454841ms

./etcdctl member list
 3fcd54d1766f30b4: name=etcd-2 peerURLs=http://127.0.0.1:2381 
clientURLs=http://127.0.0.1:3379,http://127.0.0.1:3379 isLeader=false
 48e24310bdb358ce: name=etcd-1 peerURLs=http://127.0.0.1:2380 
clientURLs=http://127.0.0.1:2379,http://127.0.0.1:2379 isLeader=true
 66846ef509b1c4d7: name=etcd-3 peerURLs=http://127.0.0.1:2382 
clientURLs=http://127.0.0.1:4379,http://127.0.0.1:4379 isLeader=false

> add a new CLI: memberlist
> -
>
> Key: ZOOKEEPER-3454
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3454
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: java client
>Reporter: maoling
>Assignee: maoling
>Priority: Major
>
> ./etcdctl -w table --endpoints=127.0.0.1:2379,127.0.0.1:3379,127.0.0.1:4379 
> endpoint status
> ++--+-+-+---+---++
> | ENDPOINT | ID | VERSION | DB SIZE | IS LEADER | RAFT TERM | RAFT INDEX |
> ++--+-+-+---+---++
> | 127.0.0.1:2379 | 2d6d41b3de34869d | 3.3.11 | 20 kB | true | 46 | 18 |
> | 127.0.0.1:3379 | fa452fb497312bf1 | 3.3.11 | 20 kB | false | 46 | 18 |
> | 127.0.0.1:4379 | a20a53b92b8e7e56 | 3.3.11 | 20 kB | false | 46 | 18 |
> ++--+-+-+---+---++
> [用name会报错]:Error: dial tcp: lookup etcd-1 on 10.9.255.1:53: no such host
> ./etcdctl -w table --endpoints=etcd-1:2379,etcd-2:3379,etcd-3:4379 endpoint 
> status
> ./etcdctl endpoint health
> ./etcdctl --endpoints=127.0.0.1:2379,127.0.0.1:3379,127.0.0.1:4379 health
> 127.0.0.1:2379 is healthy: successfully committed proposal: took = 1.454841ms
> ./etcdctl member list
>  3fcd54d1766f30b4: name=etcd-2 peerURLs=http://127.0.0.1:2381 
> clientURLs=http://127.0.0.1:3379,http://127.0.0.1:3379 isLeader=false
>  48e24310bdb358ce: name=etcd-1 peerURLs=http://127.0.0.1:2380 
> clientURLs=http://127.0.0.1:2379,http://127.0.0.1:2379 isLeader=true
>  66846ef509b1c4d7: name=etcd-3 peerURLs=http://127.0.0.1:2382 
> clientURLs=http://127.0.0.1:4379,http://127.0.0.1:4379 isLeader=false



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ZOOKEEPER-2559) the quota should be deleted when its parasitic path doesn't exist

2019-07-01 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-2559:
---
Summary: the quota should be deleted when its parasitic path doesn't exist  
(was: Failed to delete the set quota for ephemeral node when the node is 
deleted because of client session closed)

> the quota should be deleted when its parasitic path doesn't exist
> -
>
> Key: ZOOKEEPER-2559
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2559
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.1, 3.5.2
>Reporter: Rakesh Kumar Singh
>Assignee: Rakesh Kumar Singh
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Failed to delete the set quota for ephemeral node when the node is deleted 
> because of client session closed
> [zk: localhost:2181(CONNECTED) 0] create -e /e_test hello
> Created /e_test
> [zk: localhost:2181(CONNECTED) 1] setquota -n 10 /e_test
> [zk: localhost:2181(CONNECTED) 2] listquota /e_test
> absolute path is /zookeeper/quota/e_test/zookeeper_limits
> Output quota for /e_test count=10,bytes=-1
> Output stat for /e_test count=1,bytes=5
> Now close the client connection and so the ephemeral node gets deleted. But 
> the corresponding quota is not getting deleted as below:-
> [zk: localhost:2181(CONNECTED) 0] ls /
> [test, test1, test3, zookeeper]
> [zk: localhost:2181(CONNECTED) 1] listquota /e_test
> absolute path is /zookeeper/quota/e_test/zookeeper_limits
> Output quota for /e_test count=10,bytes=-1
> Output stat for /e_test count=0,bytes=0
> [zk: localhost:2181(CONNECTED) 2] 
> and so now again create the ephemeral node with same node and try to set the 
> quota, it will fail.
> [zk: localhost:2181(CONNECTED) 2] create -e /e_test hello
> Created /e_test
> [zk: localhost:2181(CONNECTED) 3] setquota -n 10 /e_test
> Command failed: java.lang.IllegalArgumentException: /e_test has a parent 
> /zookeeper/quota/e_test which has a quota
> [zk: localhost:2181(CONNECTED) 4] 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ZOOKEEPER-2127) Document zkCli.sh

2019-08-04 Thread maoling (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899629#comment-16899629
 ] 

maoling commented on ZOOKEEPER-2127:


we already had that doc, let me close this issue.

> Document zkCli.sh
> -
>
> Key: ZOOKEEPER-2127
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2127
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Joe Gamache
>Priority: Major
>
> According to the answer provided to this stack overflow question:
> http://stackoverflow.com/questions/28589703/zookeeper-zkcli-sh-create-switches-documentation/28594057#28594057
> the zkCli.sh script is not documented in terms of what all the switches mean. 
>  Such documentation should be provided.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (ZOOKEEPER-3282) a big refactor for the documetations

2019-08-04 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3282:
---
Issue Type: Improvement  (was: New Feature)

> a big refactor for the documetations
> 
>
> Key: ZOOKEEPER-3282
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3282
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: documentation
>Reporter: maoling
>Assignee: maoling
>Priority: Major
>
> Hi guys:
> I'am working on doing a big refactor for the documetations.it aims to 
>  - 1.make a better reading experiences and help users know more about 
> zookeeper quickly,as good as other projects' doc(e.g redis,hbase).
>  - 2.have less changes to diff with the original docs as far as possible.
>  - 3.solve the problem when we have some new features or improvements,but 
> cannot find a good place to doc it.
>  
> The new catalog may looks kile this:
> * is new one added.
> ** is the one to keep unchanged as far as possible.
> *** is the one modified.
> --
> |---Overview
>     |---Welcome ** [1.1]
>     |---Overview ** [1.2]
>     |---Getting Started ** [1.3]
>     |---Release Notes ** [1.4]
> |---Developer
>     |---API *** [2.1]
>     |---Programmer's Guide ** [2.2]
>     |---Recipes *** [2.3]
>     |---Clients * [2.4]
>     |---Use Cases * [2.5]
> |---Admin & Ops
>     |---Administrator's Guide ** [3.1]
>     |---Quota Guide ** [3.2]
>     |---JMX ** [3.3]
>     |---Observers Guide ** [3.4]
>     |---Dynamic Reconfiguration ** [3.5]
>     |---Zookeeper CLI * [3.6]
>     |---Shell * [3.7]
>     |---Configuration flags * [3.8]
>     |---Troubleshooting & Tuning  * [3.9]
> |---Contributor Guidelines
>     |---General Guidelines * [4.1]
>     |---ZooKeeper Internals ** [4.2]
> |---Miscellaneous
>     |---Wiki ** [5.1]
>     |---Mailing Lists ** [5.2]
> --
> The Roadmap is:
> 1.(I pick up it : D)
>   1.1 write API[2.1], which includes the: 
>     1.1.1  original API Docs which is a Auto-generated java doc,just give a 
> link.
>     1.1.2. Restful-api (the apis under the 
> /zookeeper-contrib-rest/src/main/java/org/apache/zookeeper/server/jersey/resources)
>   1.2 write Clients[2.4], which includes the: 
>   1.2.1 C client 
>   1.2.2 zk-python, kazoo
>   1.2.3 Curator etc...
>   look at an example from: https://redis.io/clients
>  #  write Recipes[2.3], which includes the:
>   - integrate "Java Example" and "Barrier and Queue Tutorial"(Since some bugs 
> in the examples and they are obsolete,we may delete something) into it.
>   - suggest users to use the recipes implements of Curator and link to the 
> Curator's recipes doc.
>  
>  #  write Zookeeper CLI[3.6], which includes the:
>   - about how to use the zk command line interface [./zkCli.sh]
>     e.g ls /; get ; rmr;create -e -p etc...
>   - look at an example from redis: https://redis.io/topics/rediscli
>  
>  #  write shell[3.7], which includes the:
>    - list all usages of the shells under the zookeeper/bin. (e.g 
> zkTxnLogToolkit.sh,zkCleanup.sh)
>  
>  #  write Configuration flags[3.8], which includes the:
>    - list all usages of configurations properties(e.g zookeeper.snapCount): 
>    - move the original Advanced Configuration part of zookeeperAdmin.md into 
> it.
>  look at an example 
> from:https://coreos.com/etcd/docs/latest/op-guide/configuration.html
>    
>  #  write Troubleshooting & Tuning[3.9], which includes the:
>    - move the original "Gotchas: Common Problems and Troubleshooting" part of 
> Administrator's Guide.md into it.
>    - move the original "FAQ" into into it.
>    - add some new contents (e.g 
> https://www.yumpu.com/en/document/read/29574266/building-an-impenetrable-zookeeper-pdf-github).
>    look at an example from:https://redis.io/topics/problems
>       https://coreos.com/etcd/docs/latest/tuning.html
>  
>  #  write General Guidelines[4.1], which includes the:
>   - move the original "Logging" part of ZooKeeper Internals into it as the 
> logger specification.
>   - write specifications about code, git commit messages,github PR  etc ...
>     look at an example from:
>     http://hbase.apache.org/book.html#hbase.commit.msg.format
>  
>  #  write Use Cases[2.5], which includes the:
>   - just move the context from: 
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/PoweredBy into it.
>   - add some new contents.(e.g Apache Projects:Spark;Companies:twitter,fb)
>  
> --
> BTW:
> - Any insights or suggestions are very welcomed.After the dicussions,I will 
> create a series of tickets(An umbrella)
> - Since these works can be done parallelly, if you are 

[jira] [Updated] (ZOOKEEPER-3282) a big refactor for the documetations

2019-08-04 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3282:
---
Issue Type: Task  (was: Improvement)

> a big refactor for the documetations
> 
>
> Key: ZOOKEEPER-3282
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3282
> Project: ZooKeeper
>  Issue Type: Task
>  Components: documentation
>Reporter: maoling
>Assignee: maoling
>Priority: Major
>
> Hi guys:
> I'am working on doing a big refactor for the documetations.it aims to 
>  - 1.make a better reading experiences and help users know more about 
> zookeeper quickly,as good as other projects' doc(e.g redis,hbase).
>  - 2.have less changes to diff with the original docs as far as possible.
>  - 3.solve the problem when we have some new features or improvements,but 
> cannot find a good place to doc it.
>  
> The new catalog may looks kile this:
> * is new one added.
> ** is the one to keep unchanged as far as possible.
> *** is the one modified.
> --
> |---Overview
>     |---Welcome ** [1.1]
>     |---Overview ** [1.2]
>     |---Getting Started ** [1.3]
>     |---Release Notes ** [1.4]
> |---Developer
>     |---API *** [2.1]
>     |---Programmer's Guide ** [2.2]
>     |---Recipes *** [2.3]
>     |---Clients * [2.4]
>     |---Use Cases * [2.5]
> |---Admin & Ops
>     |---Administrator's Guide ** [3.1]
>     |---Quota Guide ** [3.2]
>     |---JMX ** [3.3]
>     |---Observers Guide ** [3.4]
>     |---Dynamic Reconfiguration ** [3.5]
>     |---Zookeeper CLI * [3.6]
>     |---Shell * [3.7]
>     |---Configuration flags * [3.8]
>     |---Troubleshooting & Tuning  * [3.9]
> |---Contributor Guidelines
>     |---General Guidelines * [4.1]
>     |---ZooKeeper Internals ** [4.2]
> |---Miscellaneous
>     |---Wiki ** [5.1]
>     |---Mailing Lists ** [5.2]
> --
> The Roadmap is:
> 1.(I pick up it : D)
>   1.1 write API[2.1], which includes the: 
>     1.1.1  original API Docs which is a Auto-generated java doc,just give a 
> link.
>     1.1.2. Restful-api (the apis under the 
> /zookeeper-contrib-rest/src/main/java/org/apache/zookeeper/server/jersey/resources)
>   1.2 write Clients[2.4], which includes the: 
>   1.2.1 C client 
>   1.2.2 zk-python, kazoo
>   1.2.3 Curator etc...
>   look at an example from: https://redis.io/clients
>  #  write Recipes[2.3], which includes the:
>   - integrate "Java Example" and "Barrier and Queue Tutorial"(Since some bugs 
> in the examples and they are obsolete,we may delete something) into it.
>   - suggest users to use the recipes implements of Curator and link to the 
> Curator's recipes doc.
>  
>  #  write Zookeeper CLI[3.6], which includes the:
>   - about how to use the zk command line interface [./zkCli.sh]
>     e.g ls /; get ; rmr;create -e -p etc...
>   - look at an example from redis: https://redis.io/topics/rediscli
>  
>  #  write shell[3.7], which includes the:
>    - list all usages of the shells under the zookeeper/bin. (e.g 
> zkTxnLogToolkit.sh,zkCleanup.sh)
>  
>  #  write Configuration flags[3.8], which includes the:
>    - list all usages of configurations properties(e.g zookeeper.snapCount): 
>    - move the original Advanced Configuration part of zookeeperAdmin.md into 
> it.
>  look at an example 
> from:https://coreos.com/etcd/docs/latest/op-guide/configuration.html
>    
>  #  write Troubleshooting & Tuning[3.9], which includes the:
>    - move the original "Gotchas: Common Problems and Troubleshooting" part of 
> Administrator's Guide.md into it.
>    - move the original "FAQ" into into it.
>    - add some new contents (e.g 
> https://www.yumpu.com/en/document/read/29574266/building-an-impenetrable-zookeeper-pdf-github).
>    look at an example from:https://redis.io/topics/problems
>       https://coreos.com/etcd/docs/latest/tuning.html
>  
>  #  write General Guidelines[4.1], which includes the:
>   - move the original "Logging" part of ZooKeeper Internals into it as the 
> logger specification.
>   - write specifications about code, git commit messages,github PR  etc ...
>     look at an example from:
>     http://hbase.apache.org/book.html#hbase.commit.msg.format
>  
>  #  write Use Cases[2.5], which includes the:
>   - just move the context from: 
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/PoweredBy into it.
>   - add some new contents.(e.g Apache Projects:Spark;Companies:twitter,fb)
>  
> --
> BTW:
> - Any insights or suggestions are very welcomed.After the dicussions,I will 
> create a series of tickets(An umbrella)
> - Since these works can be done parallelly, if you are interested in 

[jira] [Resolved] (ZOOKEEPER-2127) Document zkCli.sh

2019-08-04 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling resolved ZOOKEEPER-2127.

Resolution: Done

> Document zkCli.sh
> -
>
> Key: ZOOKEEPER-2127
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2127
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Joe Gamache
>Priority: Major
>
> According to the answer provided to this stack overflow question:
> http://stackoverflow.com/questions/28589703/zookeeper-zkcli-sh-create-switches-documentation/28594057#28594057
> the zkCli.sh script is not documented in terms of what all the switches mean. 
>  Such documentation should be provided.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Created] (ZOOKEEPER-3506) correct the SessionTrackerImpl#initializeNextSession's java doc about how to generate the sessionId

2019-08-14 Thread maoling (JIRA)
maoling created ZOOKEEPER-3506:
--

 Summary: correct the SessionTrackerImpl#initializeNextSession's 
java doc about how to generate the sessionId
 Key: ZOOKEEPER-3506
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3506
 Project: ZooKeeper
  Issue Type: Improvement
  Components: documentation, server
Reporter: maoling
 Fix For: 3.6.0


 
{code:java}
/**
 * Generates an initial sessionId. High order byte is serverId, next 5
 * 5 bytes are from timestamp, and low order 2 bytes are 0s.
 */
public static long initializeNextSession(long id) {
long nextSid;
nextSid = (Time.currentElapsedTime() << 24) >>> 8;
nextSid =  nextSid | (id <<56);
if (nextSid == EphemeralType.CONTAINER_EPHEMERAL_OWNER) {
++nextSid;  // this is an unlikely edge case, but check it just in case
}
return nextSid;
}
{code}
 

 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (ZOOKEEPER-3506) correct the SessionTrackerImpl#initializeNextSession's javaDoc about how to generate the sessionId

2019-08-14 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3506:
---
Summary: correct the SessionTrackerImpl#initializeNextSession's javaDoc 
about how to generate the sessionId  (was: correct the 
SessionTrackerImpl#initializeNextSession's java doc about how to generate the 
sessionId)

> correct the SessionTrackerImpl#initializeNextSession's javaDoc about how to 
> generate the sessionId
> --
>
> Key: ZOOKEEPER-3506
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3506
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: documentation, server
>Reporter: maoling
>Priority: Minor
> Fix For: 3.6.0
>
>
>  
> {code:java}
> /**
>  * Generates an initial sessionId. High order byte is serverId, next 5
>  * 5 bytes are from timestamp, and low order 2 bytes are 0s.
>  */
> public static long initializeNextSession(long id) {
> long nextSid;
> nextSid = (Time.currentElapsedTime() << 24) >>> 8;
> nextSid =  nextSid | (id <<56);
> if (nextSid == EphemeralType.CONTAINER_EPHEMERAL_OWNER) {
> ++nextSid;  // this is an unlikely edge case, but check it just in 
> case
> }
> return nextSid;
> }
> {code}
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Assigned] (ZOOKEEPER-3501) unify the method:op2String()

2019-08-10 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling reassigned ZOOKEEPER-3501:
--

Assignee: maoling

> unify the method:op2String()
> 
>
> Key: ZOOKEEPER-3501
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3501
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: maoling
>Assignee: maoling
>Priority: Minor
> Fix For: 3.6.0
>
>
> there were two duplicated method
> *public static String op2String(int op)*
> in the code base:
>  
> {code:java}
> org.apache.zookeeper.server.TraceFormatter#op2String
> org.apache.zookeeper.server.Request#op2String
> {code}
>  
> and they are inconsistency, we should unify it and remain only one
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Created] (ZOOKEEPER-3502) improve the server commands: zabstate to have a better observation on the process of leader elction

2019-08-10 Thread maoling (JIRA)
maoling created ZOOKEEPER-3502:
--

 Summary: improve the server commands: zabstate to have a better 
observation on the process of leader elction
 Key: ZOOKEEPER-3502
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3502
 Project: ZooKeeper
  Issue Type: Improvement
  Components: server
Reporter: maoling
Assignee: maoling
 Fix For: 3.6.0






--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (ZOOKEEPER-3502) improve the server commands: zabstate to have a better observation on the process of leader election

2019-08-10 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3502:
---
Summary: improve the server commands: zabstate to have a better observation 
on the process of leader election  (was: improve the server commands: zabstate 
to have a better observation on the process of leader elction)

> improve the server commands: zabstate to have a better observation on the 
> process of leader election
> 
>
> Key: ZOOKEEPER-3502
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3502
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: maoling
>Assignee: maoling
>Priority: Major
> Fix For: 3.6.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (ZOOKEEPER-3502) improve the server command: zabstate to have a better observation on the process of leader election

2019-08-11 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3502:
---
Summary: improve the server command: zabstate to have a better observation 
on the process of leader election  (was: improve the server commands: zabstate 
to have a better observation on the process of leader election)

> improve the server command: zabstate to have a better observation on the 
> process of leader election
> ---
>
> Key: ZOOKEEPER-3502
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3502
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: maoling
>Assignee: maoling
>Priority: Minor
> Fix For: 3.6.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (ZOOKEEPER-3502) improve the server commands: zabstate to have a better observation on the process of leader election

2019-08-11 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3502:
---
Priority: Minor  (was: Major)

> improve the server commands: zabstate to have a better observation on the 
> process of leader election
> 
>
> Key: ZOOKEEPER-3502
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3502
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: maoling
>Assignee: maoling
>Priority: Minor
> Fix For: 3.6.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (ZOOKEEPER-3317) dynamic file for reconfig should support the relative path

2019-08-27 Thread maoling (Jira)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916612#comment-16916612
 ] 

maoling commented on ZOOKEEPER-3317:


Oops, look at the source code, the dynamic file for reconfig has already 
supported the relative path.

Let me close this issue
{code:java}
org.apache.zookeeper.server.quorum.QuorumPeerConfig#parse
try { File configFile = (new VerifyingFileFactory.Builder(LOG) 
.warnForRelativePath() .failForNonExistingPath() .build()).create(path); 
Properties cfg = new Properties(); FileInputStream in = new 
FileInputStream(configFile); try { cfg.load(in); configFileStr = path; } 
finally { in.close(); }
{code}

> dynamic file for reconfig should support the relative path
> --
>
> Key: ZOOKEEPER-3317
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3317
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: maoling
>Priority: Minor
>
> dynamic file for reconfig should support the relative path,just like this:
> *dynamicConfigFile=../zoo_replicated5.cfg.dynamic*
> follow an example of *dataDir*:if use the relative path,log the warning info.
> 2019-03-14 11:02:39,028 [myid:] - INFO [main:QuorumPeerConfig@141] - Reading 
> configuration from: 
> /data/software/zookeeper/zookeeper-test2/bin/../conf/zoo.cfg
> 2019-03-14 11:02:39,037 [myid:] - WARN [main:VerifyingFileFactory@59] - 
> ../../zkdata2 is relative. Prepend ./ to indicate that you're sure!
> 2019-03-14 11:02:39,037 [myid:] - WARN [main:VerifyingFileFactory@59] - 
> ../../zkdataLog2 is relative. Prepend ./ to indicate that you're sure!
> 2019-03-14 11:02:39,048 [myid:] - INFO [main:QuorumPeerConfig@406] - 
> clientPortAddress is 0.0.0.0:22181
> 2019-03-14 11:02:39,048 [myid:] - INFO [main:QuorumPeerConfig@410] - 
> secureClientPort is not set
> 2019-03-14 11:02:39,048 [myid:] - INFO [main:QuorumPeerConfig@427] - 
> observerMasterPort is not set
> 2019-03-14 11:02:39,048 [myid:] - INFO [main:QuorumPeerConfig@445] - 
> metricsProvider.className is 
> org.apache.zookeeper.metrics.impl.NullMetricsProvider
> 2019-03-14 11:02:39,048 [myid:] - ERROR [main:QuorumPeerMain@94] - Invalid 
> config, exiting abnormally
> org.apache.zookeeper.server.quorum.QuorumPeerConfig$ConfigException: Error 
> processing ../zoo_replicated2.cfg.dynamic
>  at 
> org.apache.zookeeper.server.quorum.QuorumPeerConfig.parse(QuorumPeerConfig.java:187)
>  at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:118)
>  at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:87)
> Caused by: java.io.FileNotFoundException: ../zoo_replicated2.cfg.dynamic (No 
> such file or directory)
>  at java.io.FileInputStream.open0(Native Method)
>  at java.io.FileInputStream.open(FileInputStream.java:195)
>  at java.io.FileInputStream.(FileInputStream.java:138)
>  at java.io.FileInputStream.(FileInputStream.java:93)
>  at 
> org.apache.zookeeper.server.quorum.QuorumPeerConfig.parse(QuorumPeerConfig.java:168)
>  ... 2 more
> Invalid config, exiting abnormally



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (ZOOKEEPER-1940) Integrate with Docker.

2019-08-27 Thread maoling (Jira)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916621#comment-16916621
 ] 

maoling commented on ZOOKEEPER-1940:


Hi [~31z4], awesome and great work!!!

I find that you're maintaining the [official zookeeper 
image|[https://hub.docker.com/_/zookeeper]]

Could you plz contribute the dockerfile or add a link to that official 
zookeeper image in the zk official documentation?

> Integrate with Docker.
> --
>
> Key: ZOOKEEPER-1940
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1940
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: David Medinets
>Priority: Trivial
>
> Docker is an open platform for developers and sysadmins to build, ship, and 
> run distributed applications.
> It's become quite popular and I'd like to see the zookeeper community suggest 
> a standard way to run zookeeper inside docker containers. To get the 
> conversation started, I have a working example at:
> https://github.com/medined/docker-zookeeper
> I hope there is a better technique that I used. And if there is please make 
> suggestions.
> The difficulty, I think, posed by Docker, is that the images are started 
> before the bridge network is created. This means, again I think, that 
> zookeeper is running inside the container with no way to communicate with the 
> ensemble for some non-trivial amount of time. 
> My resolution to this was to force each each to wait 30 seconds before  
> starting zookeeper. I still see connection errors in the logs, but eventually 
> the cluster settles and everything seems to work.
> I'm hoping that someone which more networking experience than I can find a 
> way to eliminate that 30 second delay and the connection errors during 
> startup.
> Thanks for reading this far.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (ZOOKEEPER-3415) convert internal logic to use java 8 streams

2019-08-27 Thread maoling (Jira)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3415:
---
Labels: newbie  (was: )

> convert internal logic to use java 8 streams
> 
>
> Key: ZOOKEEPER-3415
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3415
> Project: ZooKeeper
>  Issue Type: Wish
>Affects Versions: 3.6.0
>Reporter: Brian Nixon
>Priority: Trivial
>  Labels: newbie
>
> There are a number of places in the code where for loops are used to perform 
> basic filtering and collection. The java 8 stream api's make these operations 
> much more polished. Since the master branch has been at this language level 
> for a while, I'd wish for a (series of) refactor(s) to convert more of these 
> loops to streams.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (ZOOKEEPER-3411) remove the deprecated CLI: ls2 and rmr

2019-08-27 Thread maoling (Jira)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3411:
---
Labels: new  (was: )

> remove the deprecated CLI: ls2 and rmr
> --
>
> Key: ZOOKEEPER-3411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3411
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: scripts
>Affects Versions: 3.6.0
>Reporter: maoling
>Priority: Minor
>  Labels: new
>
> remove the deprecated CLI: *ls2* and *rmr*
> Look at the discuss in the  [https://github.com/apache/zookeeper/pull/833]



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Resolved] (ZOOKEEPER-3118) DELETE - test

2019-08-27 Thread maoling (Jira)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling resolved ZOOKEEPER-3118.

Resolution: Invalid

> DELETE - test
> -
>
> Key: ZOOKEEPER-3118
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3118
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build, jmx
>Reporter: pacawat k
>Priority: Major
>
> test



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (ZOOKEEPER-3411) remove the deprecated CLI: ls2 and rmr

2019-08-27 Thread maoling (Jira)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3411:
---
Labels: newbie  (was: new)

> remove the deprecated CLI: ls2 and rmr
> --
>
> Key: ZOOKEEPER-3411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3411
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: scripts
>Affects Versions: 3.6.0
>Reporter: maoling
>Priority: Minor
>  Labels: newbie
>
> remove the deprecated CLI: *ls2* and *rmr*
> Look at the discuss in the  [https://github.com/apache/zookeeper/pull/833]



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (ZOOKEEPER-3424) download page file package broken

2019-08-27 Thread maoling (Jira)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916736#comment-16916736
 ] 

maoling commented on ZOOKEEPER-3424:


[~Totoro]

Could you plz give us more details about this issue?

> download page file package broken
> -
>
> Key: ZOOKEEPER-3424
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3424
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.5.5
>Reporter: Wei Xin
>Priority: Trivial
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Resolved] (ZOOKEEPER-3258) Trust

2019-08-27 Thread maoling (Jira)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling resolved ZOOKEEPER-3258.

Resolution: Invalid

> Trust 
> --
>
> Key: ZOOKEEPER-3258
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3258
> Project: ZooKeeper
>  Issue Type: Task
>Reporter: Shae
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (ZOOKEEPER-2984) Master

2019-08-27 Thread maoling (Jira)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916753#comment-16916753
 ] 

maoling commented on ZOOKEEPER-2984:


[~Yayan]

Could you plz give this issue more details?

> Master
> --
>
> Key: ZOOKEEPER-2984
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2984
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Yayan Sinchan
>Priority: Major
> Attachments: firefox-2.0.complete.mar
>
>
> h2.  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (ZOOKEEPER-3527) add a series of docker thing about zookeeper

2019-08-30 Thread maoling (Jira)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3527:
---
Description: 
* Add a dockerfile and all the related docker stuff to the zk trunk
 * Add a link to that [official zookeeper 
image|[https://hub.docker.com/_/zookeeper]] in the zk official 
documentation(*README.md*)

> add a series of docker thing about zookeeper
> 
>
> Key: ZOOKEEPER-3527
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3527
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: documentation, scripts, server
>Affects Versions: 3.6.0
>Reporter: maoling
>Priority: Major
>
> * Add a dockerfile and all the related docker stuff to the zk trunk
>  * Add a link to that [official zookeeper 
> image|[https://hub.docker.com/_/zookeeper]] in the zk official 
> documentation(*README.md*)



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (ZOOKEEPER-2986) My id not in the peer list

2019-08-27 Thread maoling (Jira)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917373#comment-16917373
 ] 

maoling commented on ZOOKEEPER-2986:


[~moetemad] 

Have you found the fact?

may be a mistake in your conf file?

> My id not in the peer list
> --
>
> Key: ZOOKEEPER-2986
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2986
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3
> Environment: Running in a docker container in kubernetes 1.5
>Reporter: Mohammad Etemad
>Priority: Major
>
> Zookeeper 3.5.3-beta is throwing the following error. I am facing the issue 
> of  "My id 1 not in the peer list". If I use the alpha version (3.5.2) and 
> then upgrade to the 3.5.3 beta version, the problem goes away. But if I 
> implement the 3.5.3 version directly, the clustering never  happens and I get 
> the error. To give you a bit more overview of the implementation:
>   
>  The pods use a persistent volume claim on a gluster volume. Each pod is 
> assigned its own volume on the gluster file system. I run zookeeper as a 
> stateful set with 3 pods. 
>   
>  In my cfg file I have:
>   
> {code:java}
> standaloneEnabled=false 
> tickTime=2000 
> initLimit=10 
> syncLimit=5 
> #snapshot file dir 
> dataDir=/data 
> #tran log dir 
> dataLogDir=/dataLog 
> #zk log dir 
> logDir=/logs 
> 4lw.commands.whitelist=* 
> dynamicConfigFile=/opt/zookeeper/conf/zoo_replicated1.cfg.dynamic{code}
>   
>  and in my cfg.dynamic file I have:
>    
> {code:java}
> server.0=zookeeper-0:2888:3888 
> server.1=zookeeper-1:2888:3888 
> server.2=zookeeper-2:2888:3888{code}
>   
>  Has there been any change on the clustering side of things that makes the 
> new version not work?
>  Sample logs:
> {code:java}
> 2018-02-22 19:21:18,078 [myid:1] - ERROR [main:QuorumPeerMain@98] - 
> Unexpected exception, exiting abnormally
>  java.lang.RuntimeException: My id 1 not in the peer list
>  at org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:770)
>  at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:185)
>  at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:120)
>  at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:79){code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Resolved] (ZOOKEEPER-2989) IPv6 literal address causes problems for Quorum members

2019-08-27 Thread maoling (Jira)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling resolved ZOOKEEPER-2989.

  Assignee: (was: maoling)
Resolution: Duplicate

> IPv6 literal address causes problems for Quorum members
> ---
>
> Key: ZOOKEEPER-2989
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2989
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: quorum
>Affects Versions: 3.5.3
>Reporter: Rick Trudeau
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> We're using ZK 3.5.3-beta.
> When using literal IPv6 addresses in the zoo.cfg.dynamic file, ZK fails to 
> come up with the connection to the peer ZKs keeps getting reset.
> zookeeper.log indicates a badly formed address is the cause.
> {noformat}
> <2018.03.01 15:14:30 163 
> -0500>
>  
> org.apache.zookeeper.server.quorum.QuorumCnxManager$InitialMessage$InitialMessageException:
>  Badly formed address: 2001:db8:0:0:0:0:0:2:3888{noformat}
> Our zoo.cfg.dynamic uses literal IPv6 addresses which according to 
> ZOOKEEPER-1460 is supported.
> {noformat}
> server.1=[2001:db8::2]:2888:3888
> server.2=[2001:db8::3]:2888:3888
> server.3=[2001:db8::4]:2888:3888{noformat}
>  
> Digging into QuorumCnxManager.java, InitialMessage.parse attemps to seperate 
> the host portion from the port portion using ":" as a delimeter, which is a 
> problem for IPv6 IPs.  And there's this comment:
> {code:java}
> // FIXME: IPv6 is not supported. Using something like Guava's HostAndPort
> // parser would be good.{code}
> So it looks like peers address:port is failing to be parsed if they are 
> specified as literal IPv6 addresses.  To confirm a workaround, I replaced my 
> zoo.cfg.dynamic with hostnames instead, and everything worked as expected.
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Resolved] (ZOOKEEPER-3108) use a new property:myid in the zoo.cfg to substitute for myid file under the dataDir

2019-08-25 Thread maoling (Jira)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling resolved ZOOKEEPER-3108.

Resolution: Won't Fix

> use a new property:myid in the zoo.cfg to substitute for myid file under the 
> dataDir
> 
>
> Key: ZOOKEEPER-3108
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3108
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.5.0
>Reporter: maoling
>Assignee: maoling
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 3h
>  Remaining Estimate: 0h
>
> When use zk in distributional model,we need to touch a myid file in 
> dataDir.then write a unique number to it.It is inconvenient and not 
> user-friendly,Look at an example from other distribution system such as 
> kafka:it just uses broker.id=0 in the server.properties to indentify a unique 
> server node.This issue is going to abandon the myid file and use a new 
> property such as server.id=0 in the zoo.cfg. this fix will be applied to 
> master branch,branch-3.5+,
> keep branch-3.4 unchaged.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (ZOOKEEPER-3317) dynamic file for reconfig should support the relative path

2019-08-25 Thread maoling (Jira)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915416#comment-16915416
 ] 

maoling commented on ZOOKEEPER-3317:


[~eolivelli]

Are you free for this issue?

Let me pick up it again:D

> dynamic file for reconfig should support the relative path
> --
>
> Key: ZOOKEEPER-3317
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3317
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: maoling
>Priority: Minor
>
> dynamic file for reconfig should support the relative path,just like this:
> *dynamicConfigFile=../zoo_replicated5.cfg.dynamic*
> follow an example of *dataDir*:if use the relative path,log the warning info.
> 2019-03-14 11:02:39,028 [myid:] - INFO [main:QuorumPeerConfig@141] - Reading 
> configuration from: 
> /data/software/zookeeper/zookeeper-test2/bin/../conf/zoo.cfg
> 2019-03-14 11:02:39,037 [myid:] - WARN [main:VerifyingFileFactory@59] - 
> ../../zkdata2 is relative. Prepend ./ to indicate that you're sure!
> 2019-03-14 11:02:39,037 [myid:] - WARN [main:VerifyingFileFactory@59] - 
> ../../zkdataLog2 is relative. Prepend ./ to indicate that you're sure!
> 2019-03-14 11:02:39,048 [myid:] - INFO [main:QuorumPeerConfig@406] - 
> clientPortAddress is 0.0.0.0:22181
> 2019-03-14 11:02:39,048 [myid:] - INFO [main:QuorumPeerConfig@410] - 
> secureClientPort is not set
> 2019-03-14 11:02:39,048 [myid:] - INFO [main:QuorumPeerConfig@427] - 
> observerMasterPort is not set
> 2019-03-14 11:02:39,048 [myid:] - INFO [main:QuorumPeerConfig@445] - 
> metricsProvider.className is 
> org.apache.zookeeper.metrics.impl.NullMetricsProvider
> 2019-03-14 11:02:39,048 [myid:] - ERROR [main:QuorumPeerMain@94] - Invalid 
> config, exiting abnormally
> org.apache.zookeeper.server.quorum.QuorumPeerConfig$ConfigException: Error 
> processing ../zoo_replicated2.cfg.dynamic
>  at 
> org.apache.zookeeper.server.quorum.QuorumPeerConfig.parse(QuorumPeerConfig.java:187)
>  at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:118)
>  at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:87)
> Caused by: java.io.FileNotFoundException: ../zoo_replicated2.cfg.dynamic (No 
> such file or directory)
>  at java.io.FileInputStream.open0(Native Method)
>  at java.io.FileInputStream.open(FileInputStream.java:195)
>  at java.io.FileInputStream.(FileInputStream.java:138)
>  at java.io.FileInputStream.(FileInputStream.java:93)
>  at 
> org.apache.zookeeper.server.quorum.QuorumPeerConfig.parse(QuorumPeerConfig.java:168)
>  ... 2 more
> Invalid config, exiting abnormally



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (ZOOKEEPER-3436) Enhance Mavenized Make C client

2019-08-21 Thread maoling (Jira)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912159#comment-16912159
 ] 

maoling commented on ZOOKEEPER-3436:


[~eolivelli]

Great,I am working on writing a doc for all the zookeeper clients 
library(ZOOKEEPER-3283),but it'a a headache for how to compile the C client 
after moving from ant to maven. Can I leave the part about C client for you?

Cc: [~anmolnar], [~nkalmar]

> Enhance Mavenized Make C client 
> 
>
> Key: ZOOKEEPER-3436
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3436
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: c client
>Affects Versions: 3.6.0, 3.5.5
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Critical
> Fix For: 3.6.0
>
>
> we want to be able to build the c-client  with maven using these commands:
> Jump to the directory
> {code}
> cd zookeeper-client/zookeeper-c-client
> {code}
> Build without running tests
> {code}
> mvn clean install -DskipTests
> {code}
> Build and run tests
> {code}
> mvn clean install
> {code}
> from the root directory we will have:
> {code}
> mvn clean install -Pfull-build -DskipTests
> {code}
> and (with tests)
> {code}
> mvn clean install -Pfull-build {code}
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (ZOOKEEPER-3283) add the new doc: zookeeperClients.md

2019-09-02 Thread maoling (Jira)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3283:
---
Summary: add the new doc: zookeeperClients.md  (was: add the new doc: 
zookeeperClients.md, especially the c client)

> add the new doc: zookeeperClients.md
> 
>
> Key: ZOOKEEPER-3283
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3283
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: documentation
>Reporter: maoling
>Assignee: maoling
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> 1.2 write Clients[2.4], which includes the: 
>       1.2.1 C client 
>       1.2.2 zk-python, kazoo
>       1.2.3 Curator etc...
>       look at an example from: https://redis.io/clients



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Assigned] (ZOOKEEPER-3231) Purge task may lost data when we have many invalid snapshots.

2019-09-02 Thread maoling (Jira)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling reassigned ZOOKEEPER-3231:
--

Assignee: maoling

>  Purge task may lost data when we have many invalid snapshots.
> --
>
> Key: ZOOKEEPER-3231
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3231
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.4, 3.4.13
>Reporter: Jiafu Jiang
>Assignee: maoling
>Priority: Major
>
> I read the ZooKeeper source code, and I find the purge task use 
> FileTxnSnapLog#findNRecentSnapshots to find snapshots, but the method does 
> not check whether the snapshots are valid.
> Consider a worse case, a ZooKeeper server may have many invalid snapshots, 
> and when a purge task begins, it will use the zxid in the last snapshot's 
> name to purge old snapshots and transaction logs, then we may lost data. 
> I think we should use FileSnap#findNValidSnapshots(int) instead of 
> FileSnap#findNRecentSnapshots in FileTxnSnapLog#findNRecentSnapshots, but I 
> am not sure.
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (ZOOKEEPER-3231) Purge task may lost data when the recent snapshots are all invalid

2019-09-02 Thread maoling (Jira)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3231:
---
Summary:  Purge task may lost data when the recent snapshots are all 
invalid  (was:  Purge task may lost data when we have many invalid snapshots.)

>  Purge task may lost data when the recent snapshots are all invalid
> ---
>
> Key: ZOOKEEPER-3231
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3231
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.4, 3.4.13
>Reporter: Jiafu Jiang
>Assignee: maoling
>Priority: Major
>
> I read the ZooKeeper source code, and I find the purge task use 
> FileTxnSnapLog#findNRecentSnapshots to find snapshots, but the method does 
> not check whether the snapshots are valid.
> Consider a worse case, a ZooKeeper server may have many invalid snapshots, 
> and when a purge task begins, it will use the zxid in the last snapshot's 
> name to purge old snapshots and transaction logs, then we may lost data. 
> I think we should use FileSnap#findNValidSnapshots(int) instead of 
> FileSnap#findNRecentSnapshots in FileTxnSnapLog#findNRecentSnapshots, but I 
> am not sure.
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (ZOOKEEPER-3529) add a new doc: zookeeperUseCases.md

2019-09-02 Thread maoling (Jira)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3529:
---
Description: 
  write Use Cases[2.5], which includes the:

 - just move the context from: 
[https://cwiki.apache.org/confluence/display/ZOOKEEPER/PoweredBy] into it.

 - add some new contents.(e.g Apache Projects:Spark;Companies:twitter,fb)

> add a new doc: zookeeperUseCases.md
> ---
>
> Key: ZOOKEEPER-3529
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3529
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: documentation
>Reporter: maoling
>Assignee: maoling
>Priority: Major
> Fix For: 3.6.0
>
>
>   write Use Cases[2.5], which includes the:
>  - just move the context from: 
> [https://cwiki.apache.org/confluence/display/ZOOKEEPER/PoweredBy] into it.
>  - add some new contents.(e.g Apache Projects:Spark;Companies:twitter,fb)



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Assigned] (ZOOKEEPER-3023) Flaky test: org.apache.zookeeper.server.quorum.Zab1_0Test.testNormalFollowerRunWithDiff

2019-08-28 Thread maoling (Jira)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling reassigned ZOOKEEPER-3023:
--

Assignee: (was: maoling)

> Flaky test: 
> org.apache.zookeeper.server.quorum.Zab1_0Test.testNormalFollowerRunWithDiff
> ---
>
> Key: ZOOKEEPER-3023
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3023
> Project: ZooKeeper
>  Issue Type: Sub-task
>Affects Versions: 3.6.0
>Reporter: Pravin Dsilva
>Priority: Major
>
> Getting the following error on master branch:
> Error Message
> {code:java}
> expected:<4294967298> but was:<0>{code}
> Stacktrace
> {code:java}
> junit.framework.AssertionFailedError: expected:<4294967298> but was:<0> at 
> org.apache.zookeeper.server.quorum.Zab1_0Test$5.converseWithFollower(Zab1_0Test.java:876)
>  at 
> org.apache.zookeeper.server.quorum.Zab1_0Test.testFollowerConversation(Zab1_0Test.java:523)
>  at 
> org.apache.zookeeper.server.quorum.Zab1_0Test.testNormalFollowerRunWithDiff(Zab1_0Test.java:791)
>  at 
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79){code}
> Flaky 
> test:https://builds.apache.org/job/ZooKeeper-trunk-java10/141/testReport/junit/org.apache.zookeeper.server.quorum/Zab1_0Test/testNormalFollowerRunWithDiff/



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (ZOOKEEPER-2986) My id not in the peer list

2019-08-28 Thread maoling (Jira)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918225#comment-16918225
 ] 

maoling commented on ZOOKEEPER-2986:


[~moetemad]

Ooo, unbelievable. Let me recheck the *Zookeeper 3.5.3-beta* 

> My id not in the peer list
> --
>
> Key: ZOOKEEPER-2986
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2986
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3
> Environment: Running in a docker container in kubernetes 1.5
>Reporter: Mohammad Etemad
>Priority: Major
>
> Zookeeper 3.5.3-beta is throwing the following error. I am facing the issue 
> of  "My id 1 not in the peer list". If I use the alpha version (3.5.2) and 
> then upgrade to the 3.5.3 beta version, the problem goes away. But if I 
> implement the 3.5.3 version directly, the clustering never  happens and I get 
> the error. To give you a bit more overview of the implementation:
>   
>  The pods use a persistent volume claim on a gluster volume. Each pod is 
> assigned its own volume on the gluster file system. I run zookeeper as a 
> stateful set with 3 pods. 
>   
>  In my cfg file I have:
>   
> {code:java}
> standaloneEnabled=false 
> tickTime=2000 
> initLimit=10 
> syncLimit=5 
> #snapshot file dir 
> dataDir=/data 
> #tran log dir 
> dataLogDir=/dataLog 
> #zk log dir 
> logDir=/logs 
> 4lw.commands.whitelist=* 
> dynamicConfigFile=/opt/zookeeper/conf/zoo_replicated1.cfg.dynamic{code}
>   
>  and in my cfg.dynamic file I have:
>    
> {code:java}
> server.0=zookeeper-0:2888:3888 
> server.1=zookeeper-1:2888:3888 
> server.2=zookeeper-2:2888:3888{code}
>   
>  Has there been any change on the clustering side of things that makes the 
> new version not work?
>  Sample logs:
> {code:java}
> 2018-02-22 19:21:18,078 [myid:1] - ERROR [main:QuorumPeerMain@98] - 
> Unexpected exception, exiting abnormally
>  java.lang.RuntimeException: My id 1 not in the peer list
>  at org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:770)
>  at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:185)
>  at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:120)
>  at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:79){code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Created] (ZOOKEEPER-3535) add a new property:initial-cluster-token to identify a ensemble

2019-09-05 Thread maoling (Jira)
maoling created ZOOKEEPER-3535:
--

 Summary: add a new property:initial-cluster-token to identify a 
ensemble
 Key: ZOOKEEPER-3535
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3535
 Project: ZooKeeper
  Issue Type: New Feature
  Components: documentation, server
Reporter: maoling
Assignee: maoling
 Fix For: 3.6.0


Every new zk cluster generates a new cluster ID based on the initial cluster 
configuration and a user-provided unique initial-cluster-token value. By having 
unique cluster ID’s, zk is protected from cross-cluster interaction which could 
corrupt the cluster.

Usually this warning happens after tearing down an old cluster, then reusing 
some of the peer addresses for the new cluster. If any zk process from the old 
cluster is still running it will try to contact the new cluster. The new 
cluster will recognize a cluster ID mismatch, then ignore the request and emit 
this warning. This warning is often cleared by ensuring peer addresses among 
distinct clusters are disjoint.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (ZOOKEEPER-3529) add a new doc: zookeeperUseCases.md

2019-09-15 Thread maoling (Jira)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3529:
---
Attachment: the permission request letter of book-Apache ZooKeeper 
Essentials.jpg

> add a new doc: zookeeperUseCases.md
> ---
>
> Key: ZOOKEEPER-3529
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3529
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: documentation
>Reporter: maoling
>Assignee: maoling
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.6.0
>
> Attachments: the permission request letter of book-Apache ZooKeeper 
> Essentials.jpg
>
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
>   write Use Cases[2.5], which includes the:
>  - just move the context from: 
> [https://cwiki.apache.org/confluence/display/ZOOKEEPER/PoweredBy] into it.
>  - add some new contents.(e.g Apache Projects:Spark;Companies:twitter,fb)



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Created] (ZOOKEEPER-3477) Flaky test:CommitProcessorMetricsTest.testConcurrentRequestProcessingInCommitProcessor

2019-07-30 Thread maoling (JIRA)
maoling created ZOOKEEPER-3477:
--

 Summary: Flaky 
test:CommitProcessorMetricsTest.testConcurrentRequestProcessingInCommitProcessor
 Key: ZOOKEEPER-3477
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3477
 Project: ZooKeeper
  Issue Type: Sub-task
  Components: tests
Reporter: maoling


 

[https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build-maven/org.apache.zookeeper$zookeeper/1011/testReport/junit/org.apache.zookeeper.server.quorum/CommitProcessorMetricsTest/testConcurrentRequestProcessingInCommitProcessor/]
{code:java}
Error Message
expected:<3> but was:<2>
Stacktrace
java.lang.AssertionError: expected:<3> but was:<2>
at 
org.apache.zookeeper.server.quorum.CommitProcessorMetricsTest.testConcurrentRequestProcessingInCommitProcessor(CommitProcessorMetricsTest.java:391)

Standard Output
2019-07-30 08:02:13,023 [myid:] - INFO  [main:ZKTestCase$1@60] - STARTING 
testConcurrentRequestProcessingInCommitProcessor
2019-07-30 08:02:13,023 [myid:] - INFO  [main:CommitProcessorMetricsTest@52] - 
setup
2019-07-30 08:02:13,023 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - RUNNING TEST METHOD 
testConcurrentRequestProcessingInCommitProcessor
2019-07-30 08:02:13,024 [myid:] - INFO  [main:CommitProcessor@496] - 
Configuring CommitProcessor with readBatchSize -1 commitBatchSize 1
2019-07-30 08:02:13,025 [myid:] - INFO  [main:CommitProcessor@454] - 
Configuring CommitProcessor with 24 worker threads.
2019-07-30 08:02:13,075 [myid:] - INFO  
[main:CommitProcessorMetricsTest$TestCommitProcessor@109] - numWorkerThreads in 
Test is 3
2019-07-30 08:02:15,079 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@99] - TEST METHOD FAILED 
testConcurrentRequestProcessingInCommitProcessor
java.lang.AssertionError: expected:<3> but was:<2>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:144)
at 
{code}
 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Resolved] (ZOOKEEPER-3480) Flaky test CommitProcessorMetricsTest.testConcurrentRequestProcessingInCommitProcessor

2019-07-31 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling resolved ZOOKEEPER-3480.

Resolution: Duplicate

> Flaky test 
> CommitProcessorMetricsTest.testConcurrentRequestProcessingInCommitProcessor
> --
>
> Key: ZOOKEEPER-3480
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3480
> Project: ZooKeeper
>  Issue Type: Test
>  Components: tests
>Affects Versions: 3.6.0
>Reporter: Fangmin Lv
>Priority: Minor
>
> Found this flaky test on Jenkins, here is the log:
> Error Message
> expected:<3> but was:<2>
> h3. Stacktrace
> java.lang.AssertionError: expected:<3> but was:<2> at 
> org.apache.zookeeper.server.quorum.CommitProcessorMetricsTest.testConcurrentRequestProcessingInCommitProcessor(CommitProcessorMetricsTest.java:391)
> h3. Standard Output
> 2019-07-31 03:15:17,408 [myid:] - INFO [main:ZKTestCase$1@60] - STARTING 
> testConcurrentRequestProcessingInCommitProcessor 2019-07-31 03:15:17,408 
> [myid:] - INFO [main:CommitProcessorMetricsTest@52] - setup 2019-07-31 
> 03:15:17,409 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - 
> RUNNING TEST METHOD testConcurrentRequestProcessingInCommitProcessor 
> 2019-07-31 03:15:17,411 [myid:] - INFO [main:CommitProcessor@496] - 
> Configuring CommitProcessor with readBatchSize -1 commitBatchSize 1 
> 2019-07-31 03:15:17,411 [myid:] - INFO [main:CommitProcessor@454] - 
> Configuring CommitProcessor with 24 worker threads. 2019-07-31 03:15:17,461 
> [myid:] - INFO [main:CommitProcessorMetricsTest$TestCommitProcessor@109] - 
> numWorkerThreads in Test is 3 2019-07-31 03:15:19,466 [myid:] - INFO 
> [main:JUnit4ZKTestRunner$LoggedInvokeMethod@99] - TEST METHOD FAILED 
> testConcurrentRequestProcessingInCommitProcessor java.lang.AssertionError: 
> expected:<3> but was:<2> at org.junit.Assert.fail(Assert.java:88) at 
> org.junit.Assert.failNotEquals(Assert.java:834) at 
> org.junit.Assert.assertEquals(Assert.java:118) at 
> org.junit.Assert.assertEquals(Assert.java:144) at 
> org.apache.zookeeper.server.quorum.CommitProcessorMetricsTest.testConcurrentRequestProcessingInCommitProcessor(CommitProcessorMetricsTest.java:391)
>  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke(Method.java:498) at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>  at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>  at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>  at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>  at 
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:80)
>  at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) 
> at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) 
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) at 
> org.junit.rules.RunRules.evaluate(RunRules.java:20) at 
> org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>  at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>  at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at 
> org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at 
> org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at 
> org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at 
> org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at 
> org.junit.runners.ParentRunner.run(ParentRunner.java:363) at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
>  at 
> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
>  at 
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
>  at 
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126) 
> at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418) 
> 2019-07-31 03:15:19,472 [myid:] - INFO [main:CommitProcessorMetricsTest@68] - 
> tearDown starting 2019-07-31 

[jira] [Updated] (ZOOKEEPER-3318) [CLI way]Add a complete backup mechanism for zookeeper internal

2019-08-08 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3318:
---
Summary: [CLI way]Add a complete backup mechanism for zookeeper internal  
(was: Add a complete backup mechanism for zookeeper internal)

> [CLI way]Add a complete backup mechanism for zookeeper internal
> ---
>
> Key: ZOOKEEPER-3318
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3318
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: other
>Reporter: maoling
>Assignee: maoling
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> We already had some workaround ways for the backup, e.g:
> scenario 1: just write a cron shell to copy the snapshots periodically. 
> scenario 2: use the observer as the role of backup, then write the snapshots 
> to distributed file system. (e.g HDFS)
> this issue is aiming to implement a complete backup mechanism for zookeeper 
> internal:
> the init propose:
> 1. for realtime backup.
> write a new CLI:snapshot
> 1.1
> [zk: 127.0.0.1:2180(CONNECTED) 0] snapshot backupDataDir
> [zk: 127.0.0.1:2180(CONNECTED) 1] snapshot
>  
> ***
> 1.2 
> if no parameter, the default backupDataDir is the dataDir. the format of the 
> backup-snapshot is just like: snapshot.f9f82834 which is the same as the 
> original one.
> when recovering,moving the snapshot.f9f82834 to the dataDir, then restart 
> the ensemble.
> 1.3
> don't worry about exposing the takeSnap() api to the client.Look at this two 
> references:
> https://github.com/etcd-io/etcd/blob/master/clientv3/snapshot/v3_snapshot.go
> https://github.com/xetorthio/jedis/blob/master/src/main/java/redis/clients/jedis/commands/BasicCommands.java#L68
> 2. for no-realtime backup.
> 2.1 
> write a new tool/shell: zkBackup.sh which is the reverse proces of the 
> zkCleanup.sh for no-realtime backup.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Created] (ZOOKEEPER-3499) [admin server way] Add a complete backup mechanism for zookeeper internal

2019-08-08 Thread maoling (JIRA)
maoling created ZOOKEEPER-3499:
--

 Summary: [admin server way] Add a complete backup mechanism for 
zookeeper internal
 Key: ZOOKEEPER-3499
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3499
 Project: ZooKeeper
  Issue Type: New Feature
  Components: server
Reporter: maoling
Assignee: maoling
 Fix For: 3.6.0






--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Assigned] (ZOOKEEPER-3461) add a doc about the admin server command

2019-08-01 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling reassigned ZOOKEEPER-3461:
--

Assignee: maoling

> add a doc about the admin server command
> 
>
> Key: ZOOKEEPER-3461
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3461
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 3.6.0
>Reporter: maoling
>Assignee: maoling
>Priority: Major
>
> {code:java}
> 
>  The AdminServer
> **New in 3.5.0:** The AdminServer is
> an embedded Jetty server that provides an HTTP interface to the four
> letter word commands. By default, the server is started on port 8080,
> and commands are issued by going to the URL "/commands/\[command name]",
> e.g., http://localhost:8080/commands/stat. The command response is
> returned as JSON. Unlike the original protocol, commands are not
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Created] (ZOOKEEPER-3501) unify the method:op2String()

2019-08-09 Thread maoling (JIRA)
maoling created ZOOKEEPER-3501:
--

 Summary: unify the method:op2String()
 Key: ZOOKEEPER-3501
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3501
 Project: ZooKeeper
  Issue Type: Improvement
  Components: server
Reporter: maoling
 Fix For: 3.6.0


there were two duplicated method

*public static String op2String(int op)*

in the code base:

 
{code:java}
org.apache.zookeeper.server.TraceFormatter#op2String
org.apache.zookeeper.server.Request#op2String
{code}
 

and they are inconsistency, we should unify it and remain only one

 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Created] (ZOOKEEPER-3464) Enforce the checkstyle violations in the package org.apache.zookeeper.common

2019-07-17 Thread maoling (JIRA)
maoling created ZOOKEEPER-3464:
--

 Summary: Enforce the checkstyle violations in the package 
org.apache.zookeeper.common
 Key: ZOOKEEPER-3464
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3464
 Project: ZooKeeper
  Issue Type: Sub-task
  Components: documentation
Reporter: maoling
Assignee: maoling
 Fix For: 3.6.0






--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (ZOOKEEPER-3431) clean up the all the checkstyle violations in the zookeeper-server module

2019-07-16 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3431:
---
Issue Type: Task  (was: Improvement)

> clean up the all the checkstyle violations in the zookeeper-server module
> -
>
> Key: ZOOKEEPER-3431
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3431
> Project: ZooKeeper
>  Issue Type: Task
>  Components: server
>Reporter: maoling
>Priority: Major
> Fix For: 3.6.0
>
>
> it's time to clear up the all the checkstyle violations(turn on the 
> {{true}}). we can learn from the hbase 
> whose checkstyle is very strict and ensures a very unified code style.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (ZOOKEEPER-3431) Umbrella JIRA for cleaning up the all the checkstyle violations in the zookeeper-server module

2019-07-16 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3431:
---
Summary: Umbrella JIRA for cleaning up the all the checkstyle violations in 
the zookeeper-server module  (was: clean up the all the checkstyle violations 
in the zookeeper-server module)

> Umbrella JIRA for cleaning up the all the checkstyle violations in the 
> zookeeper-server module
> --
>
> Key: ZOOKEEPER-3431
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3431
> Project: ZooKeeper
>  Issue Type: Task
>  Components: server
>Reporter: maoling
>Priority: Major
> Fix For: 3.6.0
>
>
> it's time to clear up the all the checkstyle violations(turn on the 
> {{true}}). we can learn from the hbase 
> whose checkstyle is very strict and ensures a very unified code style.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (ZOOKEEPER-3456) Service temporarily unavailable due to an ongoing leader election. Please refresh

2019-07-15 Thread maoling (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885823#comment-16885823
 ] 

maoling commented on ZOOKEEPER-3456:


[~Mar_zieh]

1.---> *“I have Mesos and Flink, do I have to have two Zookeeper configuration, 
one for Mesos another for Flink?*

      **       of course not. they can share the same configuration.

2.    look at the result of "lsof -i:5888", it's ok. "*netstat -anop|grep 5888* 
" to re-check the port occupied issue.

3.    Even if one node has some problem, the ensemble can still works well ?

 

> Service temporarily unavailable due to an ongoing leader election. Please 
> refresh
> -
>
> Key: ZOOKEEPER-3456
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3456
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
> Environment: docker container with Ubuntu 16.04
>Reporter: Marzieh
>Priority: Major
> Fix For: 3.4.14
>
>
> Hi
> I configured Zookeeper with four nodes for my Mesos cluster with Marathon. 
> When I ran Flink Json file on Marathon, it was run without problem. But, when 
> I entered IP of my two slaves, just one slave shew Flink UI and another slave 
> shew this error:
>  
> Service temporarily unavailable due to an ongoing leader election. Please 
> refresh
> I checked "zookeeper.out" file and it said that :
>  
> 019-07-07 11:48:43,412 [myid:] - INFO [main:QuorumPeerConfig@136] - Reading 
> configuration from: /home/zookeeper-3.4.14/bin/../conf/zoo.cfg
> 2019-07-07 11:48:43,421 [myid:] - INFO [main:QuorumPeer$QuorumServer@185] - 
> Resolved hostname: 0.0.0.0 to address: /0.0.0.0
> 2019-07-07 11:48:43,421 [myid:] - INFO [main:QuorumPeer$QuorumServer@185] - 
> Resolved hostname: 10.32.0.3 to address: /10.32.0.3
> 2019-07-07 11:48:43,422 [myid:] - INFO [main:QuorumPeer$QuorumServer@185] - 
> Resolved hostname: 10.32.0.2 to address: /10.32.0.2
> 2019-07-07 11:48:43,422 [myid:] - INFO [main:QuorumPeer$QuorumServer@185] - 
> Resolved hostname: 10.32.0.5 to address: /10.32.0.5
> 2019-07-07 11:48:43,422 [myid:] - WARN [main:QuorumPeerConfig@354] - 
> Non-optimial configuration, consider an odd number of servers.
> 2019-07-07 11:48:43,422 [myid:] - INFO [main:QuorumPeerConfig@398] - 
> Defaulting to majority quorums
> 2019-07-07 11:48:43,425 [myid:3] - INFO [main:DatadirCleanupManager@78] - 
> autopurge.snapRetainCount set to 3
> 2019-07-07 11:48:43,425 [myid:3] - INFO [main:DatadirCleanupManager@79] - 
> autopurge.purgeInterval set to 0
> 2019-07-07 11:48:43,425 [myid:3] - INFO [main:DatadirCleanupManager@101] - 
> Purge task is not scheduled.
> 2019-07-07 11:48:43,432 [myid:3] - INFO [main:QuorumPeerMain@130] - Starting 
> quorum peer
> 2019-07-07 11:48:43,437 [myid:3] - INFO [main:ServerCnxnFactory@117] - Using 
> org.apache.zookeeper.server.NIOServerCnxnFactory as server connect$
> 2019-07-07 11:48:43,439 [myid:3] - INFO [main:NIOServerCnxnFactory@89] - 
> binding to port 0.0.0.0/0.0.0.0:2181
> 2019-07-07 11:48:43,440 [myid:3] - ERROR [main:QuorumPeerMain@92] - 
> Unexpected exception, exiting abnormally
> java.net.BindException: Address already in use
>  at sun.nio.ch.Net.bind0(Native Method)
>  at sun.nio.ch.Net.bind(Net.java:433)
>  at sun.nio.ch.Net.bind(Net.java:425)
>  at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223)
>  at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
>  at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67)
>  at 
> org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:90)
>  at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:133)
>  at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:114)
>  at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:81)
>  
> I searched a lot and could not find the solution.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Resolved] (ZOOKEEPER-3434) [FileTabCharacter] clear up the all the checkstyle violations in the zookeeper-server module

2019-07-16 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling resolved ZOOKEEPER-3434.

Resolution: Won't Fix

> [FileTabCharacter] clear up the all the checkstyle violations in the 
> zookeeper-server module
> 
>
> Key: ZOOKEEPER-3434
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3434
> Project: ZooKeeper
>  Issue Type: Sub-task
>Reporter: maoling
>Assignee: maoling
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> [FileTabCharacter] clear up the all the checkstyle violations in the 
> zookeeper-server module



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (ZOOKEEPER-3464) enfore checkstyle in the zookeeper-server module and clean the package:admin and client

2019-07-22 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3464:
---
Summary: enfore checkstyle in the zookeeper-server module and clean the 
package:admin and client  (was: Enforce the checkstyle violations in the 
package org.apache.zookeeper.common)

> enfore checkstyle in the zookeeper-server module and clean the package:admin 
> and client
> ---
>
> Key: ZOOKEEPER-3464
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3464
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: build
>Reporter: maoling
>Assignee: maoling
>Priority: Major
> Fix For: 3.6.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (ZOOKEEPER-102) Need to replace Jute with supported code

2019-09-24 Thread maoling (Jira)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936668#comment-16936668
 ] 

maoling commented on ZOOKEEPER-102:
---

_*1 --->shall we want an intermediate stage support both jute and the other 
serialization framework?*_

   It may be unrealistic and too complicated.

2. Since these are huge change work, so we should do a sufficient survey about 
the benefit(especially performance gain) of moving to the third-party serialize 
component.

   I prefer to thrift, hbase uses that way. Thrift has better performance and 
better java support than PB. Of course, I have not tested for this :)

3. For the experience from other project:

    etcd v2 uses the simple restful/http way, after moving to GRPC in etcd v3, 
etcd v3 cannot communicate with v2 server anymore. If we need to replace jute, 
we may do this compatibility broken work in the 4.0.0

 

> Need to replace Jute with supported code
> 
>
> Key: ZOOKEEPER-102
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-102
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Benjamin Reed
>Priority: Major
> Fix For: 4.0.0
>
>
> ZooKeeper currently uses Jute to serialize objects to put on the wire and on 
> disk. We pulled Jute out of Hadoop and added a C binding. Both versions of 
> Jute have evolved (although Hadoop still doesn't have a C binding). It would 
> be nice to use a more standard serialization library. Some options include 
> Thrift or Google's protocol buffers.
> Our main requirements would be Java and C bindings and good performance. (For 
> example, serializing to XML would give us incredibly bad performance and 
> would not be acceptible!)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ZOOKEEPER-3456) Service temporarily unavailable due to an ongoing leader election. Please refresh

2019-07-07 Thread maoling (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880013#comment-16880013
 ] 

maoling commented on ZOOKEEPER-3456:


[~Mar_zieh]

Look at *zookeeper.out*, the zk server(myid=3) has fail at the start-up due to 
the port conflict(*java.net.BindException: Address already in use*)???

 

> Service temporarily unavailable due to an ongoing leader election. Please 
> refresh
> -
>
> Key: ZOOKEEPER-3456
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3456
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
> Environment: docker container with Ubuntu 16.04
>Reporter: Marzieh
>Priority: Major
> Fix For: 3.4.14
>
>
> Hi
> I configured Zookeeper with four nodes for my Mesos cluster with Marathon. 
> When I ran Flink Json file on Marathon, it was run without problem. But, when 
> I entered IP of my two slaves, just one slave shew Flink UI and another slave 
> shew this error:
>  
> Service temporarily unavailable due to an ongoing leader election. Please 
> refresh
> I checked "zookeeper.out" file and it said that :
>  
> 019-07-07 11:48:43,412 [myid:] - INFO [main:QuorumPeerConfig@136] - Reading 
> configuration from: /home/zookeeper-3.4.14/bin/../conf/zoo.cfg
> 2019-07-07 11:48:43,421 [myid:] - INFO [main:QuorumPeer$QuorumServer@185] - 
> Resolved hostname: 0.0.0.0 to address: /0.0.0.0
> 2019-07-07 11:48:43,421 [myid:] - INFO [main:QuorumPeer$QuorumServer@185] - 
> Resolved hostname: 10.32.0.3 to address: /10.32.0.3
> 2019-07-07 11:48:43,422 [myid:] - INFO [main:QuorumPeer$QuorumServer@185] - 
> Resolved hostname: 10.32.0.2 to address: /10.32.0.2
> 2019-07-07 11:48:43,422 [myid:] - INFO [main:QuorumPeer$QuorumServer@185] - 
> Resolved hostname: 10.32.0.5 to address: /10.32.0.5
> 2019-07-07 11:48:43,422 [myid:] - WARN [main:QuorumPeerConfig@354] - 
> Non-optimial configuration, consider an odd number of servers.
> 2019-07-07 11:48:43,422 [myid:] - INFO [main:QuorumPeerConfig@398] - 
> Defaulting to majority quorums
> 2019-07-07 11:48:43,425 [myid:3] - INFO [main:DatadirCleanupManager@78] - 
> autopurge.snapRetainCount set to 3
> 2019-07-07 11:48:43,425 [myid:3] - INFO [main:DatadirCleanupManager@79] - 
> autopurge.purgeInterval set to 0
> 2019-07-07 11:48:43,425 [myid:3] - INFO [main:DatadirCleanupManager@101] - 
> Purge task is not scheduled.
> 2019-07-07 11:48:43,432 [myid:3] - INFO [main:QuorumPeerMain@130] - Starting 
> quorum peer
> 2019-07-07 11:48:43,437 [myid:3] - INFO [main:ServerCnxnFactory@117] - Using 
> org.apache.zookeeper.server.NIOServerCnxnFactory as server connect$
> 2019-07-07 11:48:43,439 [myid:3] - INFO [main:NIOServerCnxnFactory@89] - 
> binding to port 0.0.0.0/0.0.0.0:2181
> 2019-07-07 11:48:43,440 [myid:3] - ERROR [main:QuorumPeerMain@92] - 
> Unexpected exception, exiting abnormally
> java.net.BindException: Address already in use
>  at sun.nio.ch.Net.bind0(Native Method)
>  at sun.nio.ch.Net.bind(Net.java:433)
>  at sun.nio.ch.Net.bind(Net.java:425)
>  at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223)
>  at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
>  at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67)
>  at 
> org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:90)
>  at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:133)
>  at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:114)
>  at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:81)
>  
> I searched a lot and could not find the solution.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ZOOKEEPER-3456) Service temporarily unavailable due to an ongoing leader election. Please refresh

2019-07-10 Thread maoling (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881945#comment-16881945
 ] 

maoling commented on ZOOKEEPER-3456:


step1:  *ping 10.32.0.3*

step2:  *telnet 10.32.0.3 5888*

step3:  check whether the port:5888 in the 10.32.0.3 has occupied by other 
process by *lsof -i:5888*

 

> Service temporarily unavailable due to an ongoing leader election. Please 
> refresh
> -
>
> Key: ZOOKEEPER-3456
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3456
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
> Environment: docker container with Ubuntu 16.04
>Reporter: Marzieh
>Priority: Major
> Fix For: 3.4.14
>
>
> Hi
> I configured Zookeeper with four nodes for my Mesos cluster with Marathon. 
> When I ran Flink Json file on Marathon, it was run without problem. But, when 
> I entered IP of my two slaves, just one slave shew Flink UI and another slave 
> shew this error:
>  
> Service temporarily unavailable due to an ongoing leader election. Please 
> refresh
> I checked "zookeeper.out" file and it said that :
>  
> 019-07-07 11:48:43,412 [myid:] - INFO [main:QuorumPeerConfig@136] - Reading 
> configuration from: /home/zookeeper-3.4.14/bin/../conf/zoo.cfg
> 2019-07-07 11:48:43,421 [myid:] - INFO [main:QuorumPeer$QuorumServer@185] - 
> Resolved hostname: 0.0.0.0 to address: /0.0.0.0
> 2019-07-07 11:48:43,421 [myid:] - INFO [main:QuorumPeer$QuorumServer@185] - 
> Resolved hostname: 10.32.0.3 to address: /10.32.0.3
> 2019-07-07 11:48:43,422 [myid:] - INFO [main:QuorumPeer$QuorumServer@185] - 
> Resolved hostname: 10.32.0.2 to address: /10.32.0.2
> 2019-07-07 11:48:43,422 [myid:] - INFO [main:QuorumPeer$QuorumServer@185] - 
> Resolved hostname: 10.32.0.5 to address: /10.32.0.5
> 2019-07-07 11:48:43,422 [myid:] - WARN [main:QuorumPeerConfig@354] - 
> Non-optimial configuration, consider an odd number of servers.
> 2019-07-07 11:48:43,422 [myid:] - INFO [main:QuorumPeerConfig@398] - 
> Defaulting to majority quorums
> 2019-07-07 11:48:43,425 [myid:3] - INFO [main:DatadirCleanupManager@78] - 
> autopurge.snapRetainCount set to 3
> 2019-07-07 11:48:43,425 [myid:3] - INFO [main:DatadirCleanupManager@79] - 
> autopurge.purgeInterval set to 0
> 2019-07-07 11:48:43,425 [myid:3] - INFO [main:DatadirCleanupManager@101] - 
> Purge task is not scheduled.
> 2019-07-07 11:48:43,432 [myid:3] - INFO [main:QuorumPeerMain@130] - Starting 
> quorum peer
> 2019-07-07 11:48:43,437 [myid:3] - INFO [main:ServerCnxnFactory@117] - Using 
> org.apache.zookeeper.server.NIOServerCnxnFactory as server connect$
> 2019-07-07 11:48:43,439 [myid:3] - INFO [main:NIOServerCnxnFactory@89] - 
> binding to port 0.0.0.0/0.0.0.0:2181
> 2019-07-07 11:48:43,440 [myid:3] - ERROR [main:QuorumPeerMain@92] - 
> Unexpected exception, exiting abnormally
> java.net.BindException: Address already in use
>  at sun.nio.ch.Net.bind0(Native Method)
>  at sun.nio.ch.Net.bind(Net.java:433)
>  at sun.nio.ch.Net.bind(Net.java:425)
>  at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223)
>  at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
>  at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67)
>  at 
> org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:90)
>  at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:133)
>  at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:114)
>  at 
> org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:81)
>  
> I searched a lot and could not find the solution.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ZOOKEEPER-3611) strengthen CLI:addWatch to support all watch event type and add a documentation

2019-11-11 Thread maoling (Jira)
maoling created ZOOKEEPER-3611:
--

 Summary: strengthen CLI:addWatch to support all watch event type 
and add a documentation
 Key: ZOOKEEPER-3611
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3611
 Project: ZooKeeper
  Issue Type: Improvement
Reporter: maoling
Assignee: maoling






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ZOOKEEPER-3570) make the special client xid constant

2019-11-05 Thread maoling (Jira)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling reassigned ZOOKEEPER-3570:
--

Assignee: maoling

> make the special client xid constant
> 
>
> Key: ZOOKEEPER-3570
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3570
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.6.0
>Reporter: maoling
>Assignee: maoling
>Priority: Minor
>
> in the *ClientCnxn*, we had hard-code cxid which is not elegant.
> we need a constant for cxid
> {code:java}
> if (replyHdr.getXid() == -2) {
> // -2 is the xid for pings
> if (LOG.isDebugEnabled()) {
> LOG.debug("Got ping response for sessionid: 0x"
>   + Long.toHexString(sessionId)
>   + " after "
>   + ((System.nanoTime() - lastPingSentNs) / 100)
>   + "ms");
> }
> return;
> }
> if (replyHdr.getXid() == -4) {
> // -4 is the xid for AuthPacket
> if (replyHdr.getErr() == KeeperException.Code.AUTHFAILED.intValue()) {
> state = States.AUTH_FAILED;
> eventThread.queueEvent(new WatchedEvent(Watcher.Event.EventType.None, 
> Watcher.Event.KeeperState.AuthFailed, null));
> eventThread.queueEventOfDeath();
> }
> if (LOG.isDebugEnabled()) {
> LOG.debug("Got auth sessionid:0x" + Long.toHexString(sessionId));
> }
> return;
> }
> if (replyHdr.getXid() == -1) {
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ZOOKEEPER-3570) make the special client xid constant

2019-11-05 Thread maoling (Jira)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3570:
---
Summary: make the special client xid constant  (was: add the constant for 
cxid)

> make the special client xid constant
> 
>
> Key: ZOOKEEPER-3570
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3570
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.6.0
>Reporter: maoling
>Priority: Minor
>
> in the *ClientCnxn*, we had hard-code cxid which is not elegant.
> we need a constant for cxid
> {code:java}
> if (replyHdr.getXid() == -2) {
> // -2 is the xid for pings
> if (LOG.isDebugEnabled()) {
> LOG.debug("Got ping response for sessionid: 0x"
>   + Long.toHexString(sessionId)
>   + " after "
>   + ((System.nanoTime() - lastPingSentNs) / 100)
>   + "ms");
> }
> return;
> }
> if (replyHdr.getXid() == -4) {
> // -4 is the xid for AuthPacket
> if (replyHdr.getErr() == KeeperException.Code.AUTHFAILED.intValue()) {
> state = States.AUTH_FAILED;
> eventThread.queueEvent(new WatchedEvent(Watcher.Event.EventType.None, 
> Watcher.Event.KeeperState.AuthFailed, null));
> eventThread.queueEventOfDeath();
> }
> if (LOG.isDebugEnabled()) {
> LOG.debug("Got auth sessionid:0x" + Long.toHexString(sessionId));
> }
> return;
> }
> if (replyHdr.getXid() == -1) {
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ZOOKEEPER-3608) add a documentation about currentEpoch and acceptEpoch

2019-11-07 Thread maoling (Jira)
maoling created ZOOKEEPER-3608:
--

 Summary: add a documentation about currentEpoch and acceptEpoch
 Key: ZOOKEEPER-3608
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3608
 Project: ZooKeeper
  Issue Type: Improvement
  Components: documentation, leaderElection, server
Reporter: maoling
Assignee: maoling






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ZOOKEEPER-3601) introduce the fault injection framework: Byteman for ZooKeeper

2019-11-01 Thread maoling (Jira)
maoling created ZOOKEEPER-3601:
--

 Summary: introduce the fault injection framework: Byteman for 
ZooKeeper
 Key: ZOOKEEPER-3601
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3601
 Project: ZooKeeper
  Issue Type: New Feature
  Components: documentation, server
Reporter: maoling
Assignee: maoling
 Fix For: 3.6.0






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ZOOKEEPER-3601) introduce the fault injection framework: Byteman for ZooKeeper

2019-11-01 Thread maoling (Jira)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3601:
---
Description: 
[https://www.datastax.com/blog/2016/02/cassandra-unit-testing-byteman]

> introduce the fault injection framework: Byteman for ZooKeeper
> --
>
> Key: ZOOKEEPER-3601
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3601
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: documentation, server
>Reporter: maoling
>Assignee: maoling
>Priority: Major
> Fix For: 3.6.0
>
>
> [https://www.datastax.com/blog/2016/02/cassandra-unit-testing-byteman]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ZOOKEEPER-3613) ZKConfig fails to return proper value on getBoolean() when user accidentally includes spaces at the end of the value

2019-11-13 Thread maoling (Jira)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973111#comment-16973111
 ] 

maoling commented on ZOOKEEPER-3613:


[~scott.gum...@syncsort.com]

Could you plz help us fix this issue?

the contributor guideline is [here]
(https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute])

> ZKConfig fails to return proper value on getBoolean() when user accidentally 
> includes spaces at the end of the value
> 
>
> Key: ZOOKEEPER-3613
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3613
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.5
>Reporter: Scott Guminy
>Priority: Minor
>
> I was using ZooKeeper client in WebSphere Liberty and attempting to configure 
> SSL/TLS for client connections.
> To do so, I must add the system property {{zookeeper.client.secure=true}}.  
> In WebSphere Liberty, java system properties are placed in a file called 
> bootstrap.properties - each property on a separate line.  I accidentally 
> added a space at the end of the line.  When {{ZKConfig.getBoolean()}} 
> attempted to convert this string to a {{boolean}}, it returned {{false}} due 
> to the space at the end.
> {{ZKConfig.getBoolean()}} should trim the string before attempting to convert 
> to a boolean.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


  1   2   3   4   >