[
https://issues.apache.org/jira/browse/IMPALA-12934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844829#comment-17844829
]
ASF subversion and git services commented on IMPALA-12934:
----------------------------------------------------------
Commit 2a3ce2071baff88b08f00a2e1855560f1d75eb99 in impala's branch
refs/heads/master from Steve Carlin
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=2a3ce2071 ]
IMPALA-12934: Added Calcite parsing files to Impala
Adding the framework to create our own parsing syntax for Impala using
the base Calcite Parser.jj file.
The Parser.jj file here was grabbed from Calcite 1.36. So with this commit,
we are using the same parsing analysis as Calcite 1.36. Any changes made
on top of the Parser.jj file or the config.fmpp file in the future are Impala
specific changes, so a diff can be done from this commit to see all the Impala
parsing changes.
The config.fmpp file was grabbed from Calcite 1.36 default_config.fmpp. The
Calcite intention of the config.fmpp file is to allow markup of variables in
the Parser.jj file. So it is always preferable to modify the
default_config.fmpp file when possible. Our version is grabbed from
https://github.com/apache/calcite/blob/main/core/src/main/codegen/config.fmpp
and slightly modified with the class name to make it compile for Impala.
There's no unit test needed since there is no functional change. The Calcite
planner will eventually make changes in the ".jj" file to support the
differences
between the Impala parser and the Calcite parser.
Change-Id: If756b5ea8beb85661a30fb5d029e74ebb6719767
Reviewed-on: http://gerrit.cloudera.org:8080/21194
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Reviewed-by: Joe McDonnell <joemcdonn...@cloudera.com>
> Import parser files from Calcite into Impala
> --------------------------------------------
>
> Key: IMPALA-12934
> URL: https://issues.apache.org/jira/browse/IMPALA-12934
> Project: IMPALA
> Issue Type: Sub-task
> Reporter: Steve Carlin
> Priority: Major
>
> Since the Impala sql syntax is different from the Calcite sql syntax, Impala
> needs it's own parsing files.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
