[jira] [Commented] (IMPALA-5929) Remove useless explicit casts to string
[
https://issues.apache.org/jira/browse/IMPALA-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719238#comment-16719238
]
ASF subversion and git services commented on IMPALA-5929:
-
Commit 899bfd10a2a42d40634cdb8c9c670494b3c8945e in impala's branch
refs/heads/master from [~bikram.sngh91]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=899bfd1 ]
IMPALA-7960: Revert "IMPALA-5929: Remove redundant explicit casts to string"
The fix for IMPALA-5929 introduced a bug that produced wrong results.
This bug is detailed in IMPALA-7960. Reverting for now.
This reverts commit 545163bb0a5c86aa02652d0557871f5b694a6c82.
Change-Id: I6f0da62a7ff86f05859a2acbec13a726a9bd6f4c
Reviewed-on: http://gerrit.cloudera.org:8080/12073
Reviewed-by: Zoram Thanga
Tested-by: Impala Public Jenkins
> Remove useless explicit casts to string
> ---
>
> Key: IMPALA-5929
> URL: https://issues.apache.org/jira/browse/IMPALA-5929
> Project: IMPALA
> Issue Type: Bug
> Components: Frontend
>Affects Versions: Impala 2.5.0, Impala 2.6.0, Impala 2.7.0, Impala 2.8.0,
> Impala 2.9.0, Impala 2.10.0
>Reporter: Alexander Behm
>Assignee: Bikramjeet Vig
>Priority: Major
> Labels: newbie
> Fix For: Impala 2.12.0
>
>
> Some BI tools like to generate expressions that look like this:
> {code}
> cast(numeric_col as string) = '123456'
> {code}
> Casting and comparing as string is expensive and we should convert such
> expressions to:
> {code}
> numeric_col = 123456
> {code}
> Such transformations may be applicable in other situations as well. We should
> be careful about transforming inequality predicates because the string and
> numeric comparison might not always be equivalent. For example, the following
> transformation would be wrong:
> {code}
> cast(numeric_col as string) = '0123456'
> {code}
> is *not* equivalent to
> {code}
> numeric_col = 123456
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
[jira] [Commented] (IMPALA-5929) Remove useless explicit casts to string
[
https://issues.apache.org/jira/browse/IMPALA-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719239#comment-16719239
]
ASF subversion and git services commented on IMPALA-5929:
-
Commit 899bfd10a2a42d40634cdb8c9c670494b3c8945e in impala's branch
refs/heads/master from [~bikram.sngh91]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=899bfd1 ]
IMPALA-7960: Revert "IMPALA-5929: Remove redundant explicit casts to string"
The fix for IMPALA-5929 introduced a bug that produced wrong results.
This bug is detailed in IMPALA-7960. Reverting for now.
This reverts commit 545163bb0a5c86aa02652d0557871f5b694a6c82.
Change-Id: I6f0da62a7ff86f05859a2acbec13a726a9bd6f4c
Reviewed-on: http://gerrit.cloudera.org:8080/12073
Reviewed-by: Zoram Thanga
Tested-by: Impala Public Jenkins
> Remove useless explicit casts to string
> ---
>
> Key: IMPALA-5929
> URL: https://issues.apache.org/jira/browse/IMPALA-5929
> Project: IMPALA
> Issue Type: Bug
> Components: Frontend
>Affects Versions: Impala 2.5.0, Impala 2.6.0, Impala 2.7.0, Impala 2.8.0,
> Impala 2.9.0, Impala 2.10.0
>Reporter: Alexander Behm
>Assignee: Bikramjeet Vig
>Priority: Major
> Labels: newbie
> Fix For: Impala 2.12.0
>
>
> Some BI tools like to generate expressions that look like this:
> {code}
> cast(numeric_col as string) = '123456'
> {code}
> Casting and comparing as string is expensive and we should convert such
> expressions to:
> {code}
> numeric_col = 123456
> {code}
> Such transformations may be applicable in other situations as well. We should
> be careful about transforming inequality predicates because the string and
> numeric comparison might not always be equivalent. For example, the following
> transformation would be wrong:
> {code}
> cast(numeric_col as string) = '0123456'
> {code}
> is *not* equivalent to
> {code}
> numeric_col = 123456
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
