[
https://issues.apache.org/jira/browse/IMPALA-8578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Armstrong resolved IMPALA-8578.
-----------------------------------
Resolution: Fixed
Fix Version/s: Impala 3.3.0
> Reduce code in metric headers
> -----------------------------
>
> Key: IMPALA-8578
> URL: https://issues.apache.org/jira/browse/IMPALA-8578
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Major
> Fix For: Impala 3.3.0
>
>
> metrics.h and other metric headers are included a lot of places and there is
> a lot of code in the header that has very few callers. It appears to be
> pulled into several hundred compilation units, increasing the compile time of
> each of those and forcing recompilation when the headers are changed.
> Some ideas:
> * Move function implementations to .cc files. E.g. ToJson() and
> ToPrometheus() don't need to be inlined.
> * Move MetricGroup to its own file
> * Try to see if we can use forward declarations in more places to avoid
> including it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
