[jira] Commented: (LUCENE-573) Escaped quotes inside a phrase cause a ParseException
[ http://issues.apache.org/jira/browse/LUCENE-573?page=comments#action_12450886 ] Yonik Seeley commented on LUCENE-573: - Thanks Michael, I haven't had a chance to look at the code yet, but I agree with your description of all the changes. So unless concerns arise, I'll commit this after review. Escaped quotes inside a phrase cause a ParseException - Key: LUCENE-573 URL: http://issues.apache.org/jira/browse/LUCENE-573 Project: Lucene - Java Issue Type: Bug Components: QueryParser Affects Versions: 1.9 Environment: Debian Sarge, Sun JDK 1.4.2 Reporter: Tomislav Gountchev Assigned To: Michael Busch Priority: Minor Attachments: LUCENE-573_new.patch QueryParser cannot handle escaped quotes when inside a phrase. Escaped quotes not in a phrase are not a problem. This can be added to TestQueryParser.testEscaped() to demonstrate the issue - the second assert throws an exception: assertQueryEquals(a \\\b c\\\ d, a, a \b c\ d); assertQueryEquals(\a \\\b c\\\ d\, a, \a \b c\ d\); See also this thread: http://www.nabble.com/ParseException-with-escaped-quotes-in-a-phrase-t1647115.html -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (LUCENE-573) Escaped quotes inside a phrase cause a ParseException
[ http://issues.apache.org/jira/browse/LUCENE-573?page=comments#action_12447990 ] Michael Busch commented on LUCENE-573: -- Sorry, it took me a while to take care of this patch. You are right, my patch only prevents the ParseException to be thrown. However, it is still not possible to search for a phrase query that contains quotes. I think the simple solution is to call discardEscapeChar(String) for the phrase string. Then *all* escaped characters within a phrase become unescaped. Now the question is again (Yonik raised it already): Do we want this behavior or do we rather want to maintain backward compatibility for already existing phrase queries that include a backslash? If we prefer compatibility over consistency then one solution would be to add a new method discardEscapeChar(String, char[]) that only unescapes certain characters, in this case and \. If we can make a decision here I'm happy to provide a new patch. Escaped quotes inside a phrase cause a ParseException - Key: LUCENE-573 URL: http://issues.apache.org/jira/browse/LUCENE-573 Project: Lucene - Java Issue Type: Bug Components: QueryParser Affects Versions: 1.9 Environment: Debian Sarge, Sun JDK 1.4.2 Reporter: Tomislav Gountchev Priority: Minor Attachments: escaped_quotes_inside_phrases.patch QueryParser cannot handle escaped quotes when inside a phrase. Escaped quotes not in a phrase are not a problem. This can be added to TestQueryParser.testEscaped() to demonstrate the issue - the second assert throws an exception: assertQueryEquals(a \\\b c\\\ d, a, a \b c\ d); assertQueryEquals(\a \\\b c\\\ d\, a, \a \b c\ d\); See also this thread: http://www.nabble.com/ParseException-with-escaped-quotes-in-a-phrase-t1647115.html -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (LUCENE-573) Escaped quotes inside a phrase cause a ParseException
[ http://issues.apache.org/jira/browse/LUCENE-573?page=comments#action_12448007 ] Yonik Seeley commented on LUCENE-573: - The number of people searching for '\' must be minuscule (to non-existent), so I'm personally OK with doing what makes the most sense. In general, I think it's more user friendly and less surprising to allow a backslash escape of something that doesn't need it (while removing the backslash). So \\ = \ \ = \+ = + // not a necessary escape if in a quoted string, but consistent Then there are the control chars, \r\n\t, etc. At some point we might want to allow unicode escapes, and keeping backslash as a general escape char will facilitate this. Escaped quotes inside a phrase cause a ParseException - Key: LUCENE-573 URL: http://issues.apache.org/jira/browse/LUCENE-573 Project: Lucene - Java Issue Type: Bug Components: QueryParser Affects Versions: 1.9 Environment: Debian Sarge, Sun JDK 1.4.2 Reporter: Tomislav Gountchev Assigned To: Michael Busch Priority: Minor Attachments: escaped_quotes_inside_phrases.patch QueryParser cannot handle escaped quotes when inside a phrase. Escaped quotes not in a phrase are not a problem. This can be added to TestQueryParser.testEscaped() to demonstrate the issue - the second assert throws an exception: assertQueryEquals(a \\\b c\\\ d, a, a \b c\ d); assertQueryEquals(\a \\\b c\\\ d\, a, \a \b c\ d\); See also this thread: http://www.nabble.com/ParseException-with-escaped-quotes-in-a-phrase-t1647115.html -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (LUCENE-573) Escaped quotes inside a phrase cause a ParseException
[ http://issues.apache.org/jira/browse/LUCENE-573?page=comments#action_12443214 ] Michael Krkoska commented on LUCENE-573: I just experienced this bug in my search. The patch works for me, though I found it rather cumbersome to build lucene including javacc. Why is the priority of this bug low? What do we have to do to include tha patch in the release? Escaped quotes inside a phrase cause a ParseException - Key: LUCENE-573 URL: http://issues.apache.org/jira/browse/LUCENE-573 Project: Lucene - Java Issue Type: Bug Components: QueryParser Affects Versions: 1.9 Environment: Debian Sarge, Sun JDK 1.4.2 Reporter: Tomislav Gountchev Priority: Minor Attachments: escaped_quotes_inside_phrases.patch QueryParser cannot handle escaped quotes when inside a phrase. Escaped quotes not in a phrase are not a problem. This can be added to TestQueryParser.testEscaped() to demonstrate the issue - the second assert throws an exception: assertQueryEquals(a \\\b c\\\ d, a, a \b c\ d); assertQueryEquals(\a \\\b c\\\ d\, a, \a \b c\ d\); See also this thread: http://www.nabble.com/ParseException-with-escaped-quotes-in-a-phrase-t1647115.html -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (LUCENE-573) Escaped quotes inside a phrase cause a ParseException
[ http://issues.apache.org/jira/browse/LUCENE-573?page=comments#action_12443287 ] Yonik Seeley commented on LUCENE-573: - What do we have to do to include tha patch in the release? IMO, the minimal amount that needs to be done is 1) map \ to 2) map \\ to \ Escaped quotes inside a phrase cause a ParseException - Key: LUCENE-573 URL: http://issues.apache.org/jira/browse/LUCENE-573 Project: Lucene - Java Issue Type: Bug Components: QueryParser Affects Versions: 1.9 Environment: Debian Sarge, Sun JDK 1.4.2 Reporter: Tomislav Gountchev Priority: Minor Attachments: escaped_quotes_inside_phrases.patch QueryParser cannot handle escaped quotes when inside a phrase. Escaped quotes not in a phrase are not a problem. This can be added to TestQueryParser.testEscaped() to demonstrate the issue - the second assert throws an exception: assertQueryEquals(a \\\b c\\\ d, a, a \b c\ d); assertQueryEquals(\a \\\b c\\\ d\, a, \a \b c\ d\); See also this thread: http://www.nabble.com/ParseException-with-escaped-quotes-in-a-phrase-t1647115.html -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (LUCENE-573) Escaped quotes inside a phrase cause a ParseException
[ http://issues.apache.org/jira/browse/LUCENE-573?page=comments#action_12429287 ] Hoss Man commented on LUCENE-573: - You assume that the queryparser unescapes the quotes inside the phrase, but the queryparser does not unescape *any* escaped characters inside a phrase. You can see that in (2), where the escaped + (plus) character does not become unescaped. ...I'm not sure if this is a fair comaprison. Query parser may not unescape things like the \+ in this example foo bar \+baz ...but i believe that is because there is no reason for it to do so, if what you intended was to match on the + character without a preceding s\ you could have just written... foo bar +baz ...ie: the plus is already escaped by the nature of being inside the phrase bounding quotes this same justification does not hold for the double-quote character however ... there is no way to inlcude a character inside of a phrase without escaping, so it seems like query parser should be unescaping it automatically for you. correct? Escaped quotes inside a phrase cause a ParseException - Key: LUCENE-573 URL: http://issues.apache.org/jira/browse/LUCENE-573 Project: Lucene - Java Issue Type: Bug Components: QueryParser Affects Versions: 1.9 Environment: Debian Sarge, Sun JDK 1.4.2 Reporter: Tomislav Gountchev Priority: Minor Attachments: escaped_quotes_inside_phrases.patch QueryParser cannot handle escaped quotes when inside a phrase. Escaped quotes not in a phrase are not a problem. This can be added to TestQueryParser.testEscaped() to demonstrate the issue - the second assert throws an exception: assertQueryEquals(a \\\b c\\\ d, a, a \b c\ d); assertQueryEquals(\a \\\b c\\\ d\, a, \a \b c\ d\); See also this thread: http://www.nabble.com/ParseException-with-escaped-quotes-in-a-phrase-t1647115.html -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
