Re: FacetsCollector ScoreMode

2022-03-22 Thread Greg Miller
+1 to align this to the needs of keepScores. Good find!

On Mon, Mar 21, 2022 at 10:00 AM Adrien Grand  wrote:
>
> +1 to adjusting the ScoreMode based on keepScores.
>
> On Mon, Mar 21, 2022 at 5:47 PM Mike Drob  wrote:
> >
> > Hey all,
> >
> > I was looking into some performance issues and was a little confused about
> > one aspect of FacetsCollector - why does it always specify
> > ScoreMode.COMPLETE?
> >
> > Especially for the case where we are counting facets, without collecting
> > the documents, it seems like we should be able to get away without scoring.
> > I've tested it locally and it seems to work, but I'm wondering what nuance
> > I am missing.
> >
> > The default behaviour is keepScores == false, so I feel like we should be
> > able to adjust the score mode used based on that.
> >
> > Thanks,
> > Mike
>
>
>
> --
> Adrien
>
> -
> To unsubscribe, e-mail: java-user-unsubscr...@lucene.apache.org
> For additional commands, e-mail: java-user-h...@lucene.apache.org
>

-
To unsubscribe, e-mail: java-user-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-user-h...@lucene.apache.org



Re: FacetsCollector ScoreMode

2022-03-21 Thread Adrien Grand
+1 to adjusting the ScoreMode based on keepScores.

On Mon, Mar 21, 2022 at 5:47 PM Mike Drob  wrote:
>
> Hey all,
>
> I was looking into some performance issues and was a little confused about
> one aspect of FacetsCollector - why does it always specify
> ScoreMode.COMPLETE?
>
> Especially for the case where we are counting facets, without collecting
> the documents, it seems like we should be able to get away without scoring.
> I've tested it locally and it seems to work, but I'm wondering what nuance
> I am missing.
>
> The default behaviour is keepScores == false, so I feel like we should be
> able to adjust the score mode used based on that.
>
> Thanks,
> Mike



-- 
Adrien

-
To unsubscribe, e-mail: java-user-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-user-h...@lucene.apache.org



FacetsCollector ScoreMode

2022-03-21 Thread Mike Drob
Hey all,

I was looking into some performance issues and was a little confused about
one aspect of FacetsCollector - why does it always specify
ScoreMode.COMPLETE?

Especially for the case where we are counting facets, without collecting
the documents, it seems like we should be able to get away without scoring.
I've tested it locally and it seems to work, but I'm wondering what nuance
I am missing.

The default behaviour is keepScores == false, so I feel like we should be
able to adjust the score mode used based on that.

Thanks,
Mike