Re: [JBoss-dev] jboss-3.2/tomcat module updated
hi, On Tue, 2003-08-05 at 02:11, Scott M Stark wrote: You will need to obtain a clean checkout as the cvs module definitions have changed. won't a $ cvs -qz3 co -rBranch_3_2 _jboss_tomcat on my Branch_3_2 root directory be sufficient? worked for me. you can also rm -rf the 'tomcat41' and 'catalina' subdirs afterwards ... worked for me, YMMV. best regards, christian --- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa0013ave/direct;at.aspnet_072303_01/01 ___ JBoss-Development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] Verify primary key implements equals and hashCode
hi dain, On Thu, 2003-03-27 at 02:37, Dain Sundstrom wrote: Who maintains the verifier? i do. shall i integrate yours/victors proposal? best regards, christian --- This SF.net email is sponsored by: The Definitive IT and Networking Event. Be There! NetWorld+Interop Las Vegas 2003 -- Register today! http://ads.sourceforge.net/cgi-bin/redirect.pl?keyn0001en ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] Verifier problems
hi, On Sat, 2003-02-22 at 02:42, Dain Sundstrom wrote: I'm working on fixing the exception tests and I have run into a problem with the verifier. I am getting the following warning that is causing the deployment to fail: Bean : ExceptionTesterEJB Method : public abstract void ejbExceptionInStore() throws Exception Section: 7.10.7 Warning: The methods in the local interface must not include java.rmi.RemoteException in their throws clause. I don't think they wanted to exclude 'throws Exception' from a declaration. This is really a grey area of the spec. Who is maintaining this code? What do you think? i'm maintainig the code. can you file a bug report on sf.net against me (lqd) and attach a testcase? i thought i fixed something like this at the end of last year, what JBoss version are you trying this on? i also remember seeing a bug report on sf.net about this; however my net access has been crappy for the past two weeks. improving now though, i'll be back on track in the next two-three days. best regards, christian --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] [ot] php vs. java: it's the cache!
hi, just dug up something via slashdot which proves marc's point about the caches and basically explains why the phpnuke on the jboss site was doomed to fail sooner or later: http://www.aceshardware.com/read.jsp?id=45000246 sorry for the noise, thought that some of you might find that interesting. rgds, christian --- This SF.NET email is sponsored by: Thawte.com - A 128-bit supercerts will allow you to extend the highest allowed 128 bit encryption to all your clients even if they use browsers that are limited to 40 bit encryption. Get a guide here:http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0030en ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] cvs changes
hi, On Tue, 2002-12-03 at 09:13, Calin Lupa Crisan wrote: Thanks Robert, but my actual question seems to be lost in the message body, so I repeat it: If I understood correctly the CVS ADMINISTRATION POLICY web page is outdated. Is there another place than mailing list archives to look for updated/explained information on actual cvs policy ? i recently updated the QuickStart guide to include information on how to get HEAD, Branch_3_2 and Branch_3_0 out of CVS: http://www.jboss.org/developers/guides/quickstart.jsp i'll try to get around and change the other pages relating to CVS soon. regards, christian --- This SF.net email is sponsored by: Get the new Palm Tungsten T handheld. Power Color in a compact size! http://ads.sourceforge.net/cgi-bin/redirect.pl?palm0002en ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
RE: [JBoss-dev] Branch 3.2 doesn't build?
hi dominik, On Tue, 2002-11-19 at 22:05, Dominik Kacprzak wrote: I'm running into the same problem as Christian on RH Linux 8.0 even tho my ANT_HOME is not set. On my box, I have the following ant rpms installed. ant-optional-full-1.5.1-3jpp ant-1.5.1-3jpp this is my setup, too (except for the fact that i'm on RedHat 7.1 and not 8.0 but that should not matter). scott updated the ant .jar files to 1.5.1 yesterday (for Branch_3_2). that seemed to fix my problem but only for a short time, somehow i managed to set other things, too -- once i exited that shell, it was broken again. the basic problem is that ant reads in your /etc/ant.conf file which apparently breaks the build. i will have one more try of fixing this today as CVS HEAD is working just fine (then again the build.sh files are totally different for the two). you can solve your problem manually by editing jboss-dir/tools/bin/ant by hand and commenting out the first 3 or 4 lines where it reads in your /etc/ant.conf file -- works for me. best regards, christian --- This sf.net email is sponsored by: To learn the basics of securing your web site with SSL, click here to get a FREE TRIAL of a Thawte Server Certificate: http://www.gothawte.com/rd524.html ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] Branch 3.2 doesn't build?
hi, i just noticed that apparently Branch_3_2 doesn't build?! I had problems with Branch_3_0 today but I resolved these w/ a fresh checkout using cvs -d:ext:[EMAIL PROTECTED]:/cvsroot/jboss co -rBranch_3_0 jboss-3.0 i tried the same with Branch_3_2 (fresh checkout) but ant keeps complaining: -- BUILD FAILED Error reading project file: unknown protocol: resource -- this seems to stem from the DOCTYPE declaration in build.xml !DOCTYPE project [ !ENTITY buildmagic SYSTEM resource://org/jboss/tools/buildmagic/common.xml] which however works just fine for 3.0. do others see the same or is it just me? the only thing i changed locally that i upgraded to ant 1.5 on my system; however that shouldn't affect jboss as it uses its own copy of ant; i double-checked that (echoing $ANT and $ANT_HOME from build.sh points to the ant installation in the 'tools' directory in jboss). any suggestions? best regards, christian --- This sf.net email is sponsored by: To learn the basics of securing your web site with SSL, click here to get a FREE TRIAL of a Thawte Server Certificate: http://www.gothawte.com/rd524.html ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] Branch 3.2 doesn't build?
hi, On Tue, 2002-11-19 at 16:17, Scott M Stark wrote: A clean build of a cvs -r Branch_3_2 jboss-3.2 is working for me. it is something related to my local ant installation (which i upgraded to 1.5.1 recently) and the differing ant versions in the three branches. 3.0 uses Ant 1.4 -- works fine 3.2 uses Ant 1.5b2 -- breaks on my system HEAD uses Ant 1.5.1 -- works fine now i don't want to start picking on the build system (there has been enough bashing of that in the past), but wouldn't it make sense to at least have a consistent ant version used across all branches? i just replaced the 1.5b2 in the tools/ directory of Branch_3_2 with the 1.5.1 from HEAD and things work again -- but I really don't want to commit this as I'm afraid that I will break things for other people ... Jason to the rescue? regards, Christian --- This sf.net email is sponsored by: To learn the basics of securing your web site with SSL, click here to get a FREE TRIAL of a Thawte Server Certificate: http://www.gothawte.com/rd524.html ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] Metadata Service
hi, On Wed, 2002-11-13 at 22:36, Dain Sundstrom wrote: (Don't know much about XML Schemasmaybe they address these issues?) This is what XML name spaces are for. If in ISV wants to add more config options to jboss, if jboss wants to add new options to the spec ejb-jar.xml file, we just put it in a different name space. Of course this only works with a schema because dtd don't understand name spaces. hu? it has always been my understanding ( i might be completely wrong/off track of course :), that a namespace is tied to a specific DTD - so that you can have an XML document which contains more than 1 DTD that are referenced by the namespace of the elements. from my current understanding, XML Schema is only a more specific way to describe element/attribute content than a DTD (e.g. you can say this element is a string of 3 characters in a schema whereas a DTD only specifies this element has some content). Regards, Christian --- This sf.net email is sponsored by: To learn the basics of securing your web site with SSL, click here to get a FREE TRIAL of a Thawte Server Certificate: http://www.gothawte.com/rd524.html ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] hsqldb sqlcache speed improvment indication
kids, remember: don't code on drugs! scnr, christian On Tue, 2002-11-12 at 16:13, Peter Fagerlund wrote: cache is king, makes me want to sing, all your cache are belong to us, check it out in swing, cache is king, makes me want to sing, sqlcache is a drag queen, awaiting to be seen, as lean and mean, cache is king, ming, sinister mister, use the drag queen, from the other side, run run, while in cache, you can't hide, may the cache be with you, --- This sf.net email is sponsored by: To learn the basics of securing your web site with SSL, click here to get a FREE TRIAL of a Thawte Server Certificate: http://www.gothawte.com/rd522.html ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] [AUTOMATED] (HEAD) JBoss compilation failed
On Tue, 2002-10-08 at 20:55, Scott M Stark wrote: [...] The head revision cannot be checked out using the jboss-all module alias any longer. does this imply that I _must_ do a full clean checkout of my local CVS copies of all 3 branches using the commands you posted to get a correct working copy? or can i stick w/ 'cvs upd' for the meantime? regards, christian --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] Restricting ejb-name values
Hi everyone, I'm currently working on resolving Bug #613360 (see https://sourceforge.net/tracker/?func=detailatid=376685aid=613360group_id=22866 ). I have an implementation issue with the EJB Spec Section 10.6.14: The Bean Provider should not use reserved identifiers as ejb-names or abstract-schema-names. Reserved identifiers are discussed in Section 11.2.6.1. Even more restrictive is section 10.3.13: The ejb-name must be a valid Java identifier This explicitly disallows something which is quite popular today, e.g. ejb-nameorg/jboss/ABean/ejb-name Thus possibly a lot of deployments will break. If you take the spec literally this only applies to CMP 2.0 Entity Beans (the other sections don't talk about ejb-name element a lot, the DTD only talks about ejb-name being restricted to the XML 1.0 'NMTOKEN' specification). I need a handcount as to how restrictive should JBoss be, please check one of the options below: [ ] ejb-name should be restricted as specified above for ALL EJB's [ ] ejb-name should be restricted as above ONLY for CMP 2.0 Entity Beans My vote is to enforce these restrictions for ALL beans. A lot easier to implement and it has the advantage of being consistent throughout JBoss. Consistency is a Good Thing(tm). Regards + thanks for your input, Christian --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] Is the verifier too restrictive?
hi, i applied a change in 3.2 and HEAD that doesn't check these in the interfaces anymore. regards, christian On Tue, 2002-08-20 at 15:36, Scott M Stark wrote: Yes, the subclasses of RuntimeException and Error should not be checked for in the bean interfaces. Scott Stark Chief Technology Officer JBoss Group, LLC - Original Message - From: Ole Husgaard [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Tuesday, August 20, 2002 2:02 AM Subject: [JBoss-dev] Is the verifier too restrictive? Hi, In the testsuite, in the JCA test, the verifier warns: 2002-08-19 16:51:14,760 WARN [org.jboss.ejb.EJBDeployer.verifier] EJB spec violation: Bean : Teller Method : public abstract Account createAccount(Integer) throws RemoteException Section: 7.10.5 Warning: All the exceptions defined in the throws clause of the matching method of the session beanclass must be defined in the throws clause of the method of the remote interface. Reason for this is that the Teller implementation declares EJBException to be thrown from this method. The remote interface is generated by EJBDoclet, and EJBDoclet does not declare EJBException to be thrown there, since it is not needed to declare a RuntimeException. Fixing that problem is trivial, but: I wonder if the verifier is too restrictive here, and if it would be better if the verifier ignored all Throwable that do not need to be declared before comparing declared exceptions. What do you think? Best Regards, Ole Husgaard. --- This sf.net email is sponsored by: OSDN - Tired of that same old cell phone? Get a new here for FREE! https://www.inphonic.com/r.asp?r=sourceforge1refcode1=vs3390 ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development --- This sf.net email is sponsored by: OSDN - Tired of that same old cell phone? Get a new here for FREE! https://www.inphonic.com/r.asp?r=sourceforge1refcode1=vs3390 ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development -- Riege Software International GmbH Phone: +49 (2159) 91 48 - 0 Mollsfeld 10 Fax : +49 (2159) 91 48 - 11 40670 Meerbusch, Germany http://www.riege.com/ --- This sf.net email is sponsored by: OSDN - Tired of that same old cell phone? Get a new here for FREE! https://www.inphonic.com/r.asp?r=sourceforge1refcode1=vs3390 ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
RE: [JBoss-dev] WHOEVER BROKE HEAD PLEASE FIX IT!!!!!!!!!!!!!!!
hi, On Wed, 2002-07-03 at 23:24, James Mitchell wrote: ou pour nos amis hollandais Ich mag nackt (bildlich sprechend) in die Weiden der offenen Quelle laufen excuse me? as a german i take this as a personal offense being compared to a nation that couldn't even qualify for the world cup. dutch != deutsch of course the comparison was done by an american so i'll let this pass. what you get fed on CNN regarding geography is a shame anyways: http://mitglied.lycos.de/Pedde1/american_geography.jpg sacha will find the link interesting i guess. rgds, christian p.s.: ;) --- This sf.net email is sponsored by:ThinkGeek No, I will not fix your computer. http://thinkgeek.com/sf ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
RE: [JBoss-dev] I can't believe france is out of the world cup
hi, On Thu, 2002-06-27 at 19:46, Bordet, Simone wrote: so sorry guys (especcialy from turkey), but now it's between us and the German. We talk again after sunday, maybe tuesday, because the party is gonna be long : ) (so i hope)... At least the referee is italian, i was so delighted to hear that the game will be led by Colinna. Italy had bad luck with their referees (the one in the game vs. south korea was a joke), Germany got professionals after the first round. man i would've loved a semi-final between .de and .it ... although I'd preferred Italy was there instead of Germany. Ah well, we will see what Ronaldo can do against Kahn, a great battle. actually i wasn't too impressed by ronaldo. i think he's still a bit off from his best days five years ago. you have to give credit to the brazilians that they really know how to handle the ball et. al. but we've seen over the last four weeks that its not always the team playing the better looking football that takes the victory. we'll see on sunday who takes the cup home. but kahn already stated that he has a gut feeling that we'll win :). christian --- Sponsored by: ThinkGeek at http://www.ThinkGeek.com/ ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
RE: [JBoss-dev] I can't believe france is out of the world cup
hi, On Tue, 2002-06-18 at 22:14, marc fleury wrote: | As long as the USA don't win but they shall defeat Germany | and send them home. | |lol. as it looks germany will march through and take the cup by |defeating the three mighty football giants usa, south korea and turkey. don't be so fucking cocky look what it got france g ... and it got us into the semis 8). |what i'm really hoping for though is a final between germany and |england. with germany winning 1:0 by an offside goal in minute 93 of |regular playtime. yeah something tells me ... senegal... now that england is out (what a pity i would've loved a final between them and germany) i'm hoping for a final of germany vs. turkey. that's gonna be civil war over here. rgds, christian --- Sponsored by: ThinkGeek at http://www.ThinkGeek.com/ ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] I can't believe france is out of the world cup
hi, On Tue, 2002-06-18 at 20:19, Andreas Schaefer wrote: As long as the USA don't win but they shall defeat Germany and send them home. lol. as it looks germany will march through and take the cup by defeating the three mighty football giants usa, south korea and turkey. what i'm really hoping for though is a final between germany and england. with germany winning 1:0 by an offside goal in minute 93 of regular playtime. cheers, christian Bringing you mounds of caffeinated joy http://thinkgeek.com/sf ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
RE: [JBoss-dev] I can't believe france is out of the world cup
hi, On Thu, 2002-06-06 at 16:25, Rhett Aultman wrote: I'm just pleased that the US showed Portugal up. They can go back to their usual strategy of treading water and blaming the low support of soccer in the US now. I'm content. ;) he. portugal lost on purpose b/c they didn't want to get a beating by the Germans in the semis :P. christian ___ Don't miss the 2002 Sprint PCS Application Developer's Conference August 25-28 in Las Vegas -- http://devcon.sprintpcs.com/adp/index.cfm ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] [ jboss-Bugs-561683 ] Remove log4j dependency onclient side
hi, On Tue, 2002-05-28 at 23:43, Jason Dillon wrote: Um... what? you can't have an ejb client contacting jboss w/o having log4j in your classpath. i second sacha's bug report on this; i can't see a reason why a client should be forced to have that in its classpath. the whole situation on the client side is a bit yucky. a client calling one method on a session bean needs a whole lotta jars just to do that. i think that one jar should be enough to do this job. rgds, christian ___ Don't miss the 2002 Sprint PCS Application Developer's Conference August 25-28 in Las Vegas -- http://devcon.sprintpcs.com/adp/index.cfm ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
RE: [JBoss-dev] HEAD ClassCircularityError
hi, I know Zahid Rahman. 2002. now THAT should be on the next edition of the jboss t-shirts 8) sorry for the noise, christian ___ Have big pipes? SourceForge.net is looking for download mirrors. We supply the hardware. You get the recognition. Email Us: [EMAIL PROTECTED] ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jboss/src/resources/org/jboss/verifier DefaultMessages.properties
User: lqd Date: 02/04/18 03:27:49 Modified:src/resources/org/jboss/verifier DefaultMessages.properties Log: - fix messages for section 10.6.7 (ejbSelectXXX methods) Revision ChangesPath 1.15 +2 -2 jboss/src/resources/org/jboss/verifier/DefaultMessages.properties Index: DefaultMessages.properties === RCS file: /cvsroot/jboss/jboss/src/resources/org/jboss/verifier/DefaultMessages.properties,v retrieving revision 1.14 retrieving revision 1.15 diff -u -r1.14 -r1.15 --- DefaultMessages.properties14 Apr 2002 01:12:05 - 1.14 +++ DefaultMessages.properties18 Apr 2002 10:27:48 - 1.15 @@ -180,8 +180,8 @@ 10.6.6.c = Home methods of an entity bean class must not define java.rmi.RemoteException. 10.6.7.a = Select methods of an entity bean class must be declared as public. -10.6.7.b = Select methods of an entity bean class must not be declared abstract. -10.6.7.c = Select methods of an entity bean class must not define java.rmi.RemoteException. +10.6.7.b = Select methods of an entity bean class must be declared abstract. +10.6.7.c = Select methods of an entity bean class must define javax.ejb.FinderException in their throws clause. 10.8.1.a = The type of the primkey-field must match the primary key class. 10.8.1.b = The primkey-field must be one of the CMP fields of the entity bean. ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jboss/src/resources/org/jboss/verifier DefaultMessages.properties
User: lqd Date: 02/04/18 03:25:19 Modified:src/resources/org/jboss/verifier Tag: Branch_3_0 DefaultMessages.properties Log: - fix messages for section 10.6.7 (ejbSelectXXX methods) Revision ChangesPath No revision No revision 1.14.2.1 +2 -2 jboss/src/resources/org/jboss/verifier/DefaultMessages.properties Index: DefaultMessages.properties === RCS file: /cvsroot/jboss/jboss/src/resources/org/jboss/verifier/DefaultMessages.properties,v retrieving revision 1.14 retrieving revision 1.14.2.1 diff -u -r1.14 -r1.14.2.1 --- DefaultMessages.properties14 Apr 2002 01:12:05 - 1.14 +++ DefaultMessages.properties18 Apr 2002 10:25:06 - 1.14.2.1 @@ -180,8 +180,8 @@ 10.6.6.c = Home methods of an entity bean class must not define java.rmi.RemoteException. 10.6.7.a = Select methods of an entity bean class must be declared as public. -10.6.7.b = Select methods of an entity bean class must not be declared abstract. -10.6.7.c = Select methods of an entity bean class must not define java.rmi.RemoteException. +10.6.7.b = Select methods of an entity bean class must be declared abstract. +10.6.7.c = Select methods of an entity bean class must define javax.ejb.FinderException in their throws clause. 10.8.1.a = The type of the primkey-field must match the primary key class. 10.8.1.b = The primkey-field must be one of the CMP fields of the entity bean. ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq SpyObjectMessage.java
User: lqd Date: 02/04/09 05:26:12 Modified:src/main/org/jboss/mq SpyObjectMessage.java Log: better safe than sorry; somehow i was getting ObjectMessage messages that had this set to 'true' despite not being byte arrays ... Revision ChangesPath 1.9 +5 -1 jbossmq/src/main/org/jboss/mq/SpyObjectMessage.java Index: SpyObjectMessage.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/SpyObjectMessage.java,v retrieving revision 1.8 retrieving revision 1.9 diff -u -r1.8 -r1.9 --- SpyObjectMessage.java 2 Feb 2002 03:54:19 - 1.8 +++ SpyObjectMessage.java 9 Apr 2002 12:26:12 - 1.9 @@ -27,7 +27,7 @@ * * @author Norbert Lataille ([EMAIL PROTECTED]) * @createdAugust 16, 2001 - * @version$Revision: 1.8 $ + * @version$Revision: 1.9 $ */ public class SpyObjectMessage extends SpyMessage @@ -54,6 +54,7 @@ objectBytes = new byte[( ( byte[] )object ).length]; System.arraycopy( object, 0, objectBytes, 0, objectBytes.length ); } else { +isByteArray = false; ByteArrayOutputStream byteArray = new ByteArrayOutputStream(); ObjectOutputStream objectOut = new ObjectOutputStream( byteArray ); objectOut.writeObject( object ); @@ -150,3 +151,6 @@ } } +/* +vim:tabstop=3:et:shiftwidth=3 +*/ ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jboss-common/src/main/org/jboss/util/jmx MBeanProxy.java
User: lqd Date: 02/04/08 02:35:31 Modified:src/main/org/jboss/util/jmx MBeanProxy.java Log: fix compilation issues when using jikes Revision ChangesPath 1.5 +8 -6 jboss-common/src/main/org/jboss/util/jmx/MBeanProxy.java Index: MBeanProxy.java === RCS file: /cvsroot/jboss/jboss-common/src/main/org/jboss/util/jmx/MBeanProxy.java,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- MBeanProxy.java 3 Apr 2002 08:15:08 - 1.4 +++ MBeanProxy.java 8 Apr 2002 09:35:30 - 1.5 @@ -37,7 +37,7 @@ * liDon't process attributes using invoke. * /ul * - * @version tt$Revision: 1.4 $/tt + * @version tt$Revision: 1.5 $/tt * @author a href=mailto:[EMAIL PROTECTED];Rickard Öberg/a. * @author a href=mailto:[EMAIL PROTECTED];Jason Dillon/a * @author a href=mailto:[EMAIL PROTECTED];Adrian Brock/a. @@ -260,15 +260,15 @@ // make a which delegates to MBeanProxyInstance's cl for it's class resolution ClassLoader cl = new ClassLoader(intf.getClassLoader()) { - public Class loadClass(final String name) throws ClassNotFoundException + public Class loadClass(final String className) throws ClassNotFoundException { try { - return super.loadClass(name); + return super.loadClass(className); } catch (ClassNotFoundException e) { // only allow loading of MBeanProxyInstance from this loader - if (name.equals(MBeanProxyInstance.class.getName())) { - return MBeanProxyInstance.class.getClassLoader().loadClass(name); + if (className.equals(MBeanProxyInstance.class.getName())) { + return MBeanProxyInstance.class.getClassLoader().loadClass(className); } // was some other classname, throw the CNFE @@ -282,4 +282,6 @@ new MBeanProxy(name, server)); } } - +/* +vim:tabstop=3:et:shiftwidth=3 +*/ ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/pm/file MessageLog.java
User: lqd Date: 02/03/29 18:46:35 Modified:src/main/org/jboss/mq/pm/file Tag: Branch_2_4 MessageLog.java Log: fix broken filenames on Windows introduced by fix for Bug #533824 Revision ChangesPath No revision No revision 1.2.2.4 +4 -3 jbossmq/src/main/org/jboss/mq/pm/file/MessageLog.java Index: MessageLog.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/pm/file/MessageLog.java,v retrieving revision 1.2.2.3 retrieving revision 1.2.2.4 diff -u -r1.2.2.3 -r1.2.2.4 --- MessageLog.java 26 Mar 2002 06:40:41 - 1.2.2.3 +++ MessageLog.java 30 Mar 2002 02:46:34 - 1.2.2.4 @@ -28,7 +28,7 @@ * * @createdAugust 16, 2001 * @author:Paul Kendall ([EMAIL PROTECTED]) - * @version$Revision: 1.2.2.3 $ + * @version$Revision: 1.2.2.4 $ */ public class MessageLog { @@ -99,10 +99,11 @@ throws JMSException { try { File f; + String fileName = message.getJMSMessageID().replace( ':', '-' ); if ( transactionId == null ) { -f = new File( queueName, message.getJMSMessageID() ); +f = new File( queueName, fileName ); } else { -f = new File( queueName, message.getJMSMessageID() + . + transactionId ); +f = new File( queueName, fileName + . + transactionId ); } writeMessageToFile( message, f ); message.persistData = f; ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/serverJMSServer.
hi, On Fri, 2002-03-29 at 02:14, Adrian Brock wrote: This breaks on Windows :-( The id is used as a file name in file persistence. You are not allowed a : in the file name for windows. thanks for pointing this out, i've applied a fix for this to the file-based persistence manager. it's probably a bad idea anyways to use the message ID as the filename as the message id can be set by the user upon request thus leading to potentially more problems when using inappropriate characters for the underlying filesystem ... i'll try to come up with a better scheme for this. regards, christian ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/pm/file MessageLog.java
User: lqd Date: 02/03/29 19:11:18 Modified:src/main/org/jboss/mq/pm/file MessageLog.java Log: fix broken filenames on Windows introduced by fix for Bug #533824 Revision ChangesPath 1.12 +4 -3 jbossmq/src/main/org/jboss/mq/pm/file/MessageLog.java Index: MessageLog.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/pm/file/MessageLog.java,v retrieving revision 1.11 retrieving revision 1.12 diff -u -r1.11 -r1.12 --- MessageLog.java 2 Feb 2002 03:54:20 - 1.11 +++ MessageLog.java 30 Mar 2002 03:11:17 - 1.12 @@ -33,7 +33,7 @@ * * @createdAugust 16, 2001 * @author:Paul Kendall ([EMAIL PROTECTED]) - * @version$Revision: 1.11 $ + * @version$Revision: 1.12 $ */ public class MessageLog { @@ -117,12 +117,13 @@ { SpyMessage message = messageRef.getMessage(); File f; + String fileName = message.getJMSMessageID().replace( ':', '-' ); if ( transactionId == null ) { -f = new File( queueName, message.getJMSMessageID() ); +f = new File( queueName, fileName ); } else { -f = new File( queueName, message.getJMSMessageID() + . + transactionId ); +f = new File( queueName, fileName + . + transactionId ); } writeMessageToFile( message, f ); messageRef.persistData = f; ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/pm/file MessageLog.java PersistenceManager.java
User: lqd Date: 02/03/25 22:40:41 Modified:src/main/org/jboss/mq/pm/file Tag: Branch_2_4 MessageLog.java PersistenceManager.java Log: change logging from System.out to log4j Revision ChangesPath No revision No revision 1.2.2.3 +12 -5 jbossmq/src/main/org/jboss/mq/pm/file/MessageLog.java Index: MessageLog.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/pm/file/MessageLog.java,v retrieving revision 1.2.2.2 retrieving revision 1.2.2.3 diff -u -r1.2.2.2 -r1.2.2.3 --- MessageLog.java 13 Dec 2001 15:58:18 - 1.2.2.2 +++ MessageLog.java 26 Mar 2002 06:40:41 - 1.2.2.3 @@ -20,16 +20,20 @@ import org.jboss.mq.SpyMessage; import org.jboss.mq.SpyJMSException; +import org.jboss.logging.Logger; + /** * This is used to keep SpyMessages on the disk and is used reconstruct the * queue in case of provider failure. * * @createdAugust 16, 2001 * @author:Paul Kendall ([EMAIL PROTECTED]) - * @version$Revision: 1.2.2.2 $ + * @version$Revision: 1.2.2.3 $ */ public class MessageLog { + private static Logger log = Logger.getLogger( MessageLog.class ); + / // Attributes / @@ -150,10 +154,10 @@ Thread.yield(); if ( file.exists() ) { if ( !file.delete() ) { - System.out.println( Failed to delete file: + file.getAbsolutePath() ); + log.warn( Failed to delete file: + file.getAbsolutePath() ); } } else { -System.out.println( File was deleted, but delete() failed for: + file.getAbsolutePath() ); +log.warn( File was deleted, but delete() failed for: + file.getAbsolutePath() ); } } } @@ -166,10 +170,10 @@ Thread.yield(); if ( from.exists() ) { if ( !from.renameTo( to ) ) { - System.out.println( Rename of file + from.getAbsolutePath() + to + to.getAbsolutePath() + failed. ); + log.warn( Rename of file + from.getAbsolutePath() + to + to.getAbsolutePath() + failed. ); } } else { -System.out.println( Rename of file + from.getAbsolutePath() + to + to.getAbsolutePath() + failed but from no longer exists? ); +log.warn( Rename of file + from.getAbsolutePath() + to + to.getAbsolutePath() + failed but from no longer exists? ); } } } @@ -203,3 +207,6 @@ throw newE; } } +/* +vim:ts=3:et:sw=3 +*/ 1.2.2.2 +13 -3 jbossmq/src/main/org/jboss/mq/pm/file/PersistenceManager.java Index: PersistenceManager.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/pm/file/PersistenceManager.java,v retrieving revision 1.2.2.1 retrieving revision 1.2.2.2 diff -u -r1.2.2.1 -r1.2.2.2 --- PersistenceManager.java 23 Aug 2001 03:57:11 - 1.2.2.1 +++ PersistenceManager.java 26 Mar 2002 06:40:41 - 1.2.2.2 @@ -26,15 +26,20 @@ import org.jboss.util.ServiceMBeanSupport; +import org.jboss.logging.Logger; + /** * This class manages all persistence related services for file based * persistence. * * @author Paul Kendall ([EMAIL PROTECTED]) * @createdAugust 16, 2001 - * @version$Revision: 1.2.2.1 $ + * @version$Revision: 1.2.2.2 $ */ -public class PersistenceManager extends org.jboss.util.ServiceMBeanSupport implements PersistenceManagerMBean, org.jboss.mq.pm.PersistenceManager { +public class PersistenceManager + extends org.jboss.util.ServiceMBeanSupport + implements PersistenceManagerMBean, org.jboss.mq.pm.PersistenceManager +{ protected java.util.ArrayList txPool = new java.util.ArrayList(); protected long tidcounter = Long.MIN_VALUE; @@ -52,6 +57,8 @@ protected final static int MAX_POOL_SIZE = 50; + private static Logger log = Logger.getLogger( PersistenceManager.class ); + /** * PersistenceManager constructor. * @@ -107,7 +114,7 @@ txs.add( tx ); } } catch ( NumberFormatException e ) { -System.out.println( Ignoring invalid transaction record file + transactFiles[i].getAbsolutePath() ); +log.warn( Ignoring invalid transaction record file + transactFiles[i].getAbsolutePath() ); transactFiles[i] = null; } catch ( IOException e ) { JMSException jmse = new SpyJMSException( IO
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/server JMSServer.java
User: lqd Date: 02/03/25 22:53:49 Modified:src/main/org/jboss/mq/server Tag: Branch_2_4 JMSServer.java Log: Fix for bug #533824. JMS spec requoires the MessageID to be prefixed with 'ID:' instead of just 'ID' Revision ChangesPath No revision No revision 1.4.2.3 +2 -2 jbossmq/src/main/org/jboss/mq/server/JMSServer.java Index: JMSServer.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/server/JMSServer.java,v retrieving revision 1.4.2.2 retrieving revision 1.4.2.3 diff -u -r1.4.2.2 -r1.4.2.3 --- JMSServer.java28 Nov 2001 06:15:32 - 1.4.2.2 +++ JMSServer.java26 Mar 2002 06:53:49 - 1.4.2.3 @@ -37,7 +37,7 @@ * @author Hiram Chirino ([EMAIL PROTECTED]) * @author David Maplesden ([EMAIL PROTECTED]) * @createdAugust 16, 2001 - * @version$Revision: 1.4.2.2 $ + * @version$Revision: 1.4.2.3 $ */ public class JMSServer { @@ -146,7 +146,7 @@ { synchronized ( this ) { - ID = ID + ( new Integer( lastID++ ).toString() ); + ID = ID: + ( new Integer( lastID++ ).toString() ); } stateManager.addLoggedOnClientId( ID ); break; ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/server JMSServer.java
User: lqd Date: 02/03/25 22:55:34 Modified:src/main/org/jboss/mq/server JMSServer.java Log: Fix for bug #533824. JMS spec requoires the MessageID to be prefixed with 'ID:' instead of just 'ID' Revision ChangesPath 1.17 +2 -2 jbossmq/src/main/org/jboss/mq/server/JMSServer.java Index: JMSServer.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/server/JMSServer.java,v retrieving revision 1.16 retrieving revision 1.17 diff -u -r1.16 -r1.17 --- JMSServer.java9 Mar 2002 15:32:34 - 1.16 +++ JMSServer.java26 Mar 2002 06:55:34 - 1.17 @@ -52,7 +52,7 @@ * @authorHiram Chirino ([EMAIL PROTECTED]) * @authorDavid Maplesden ([EMAIL PROTECTED]) * @author a href=mailto:[EMAIL PROTECTED];Peter Antman/a - * @version $Revision: 1.16 $ + * @version $Revision: 1.17 $ */ public class JMSServer implements JMSServerInvoker { @@ -239,7 +239,7 @@ { synchronized (idLock) { - ID = ID + (new Integer(lastID++).toString()); + ID = ID: + (new Integer(lastID++).toString()); } stateManager.addLoggedOnClientId(ID); break; ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] RE: is findByPrimaryKey optimization bad?
Hi, On Thu, 2002-03-14 at 18:48, Bill Burke wrote: One more thing...Maybe we shouldn't be worrying about straight JDBC calls corrupting the cache? If somebody wants to do this, then fuck em. They do so at there own risk. Opinions? I've just added my $.02 in the SF bug tracker; the more I think about it we shouldn't do this in B/C commit-option scenario. The fuck 'em statement is not correct as the update/deletion of the underlying DB entry can happen from a third party which we have no influence on = this is exactly the reason why someone would be using B or C anyways ... Christian ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
RE: [JBoss-dev] ordering proposal
Hi, On Wed, 2002-03-13 at 16:47, marc fleury wrote: |/etc/rc.d/rc3.d/S10network will start before /etc/rc.d/rc3.d/S80sendmail |because 10 commes before 80. whatever, stuff in rc2 is started before stuff in rc3 this is not correct when looked upon from the UNIX perspective. My system boots up in runlevel 3, thus everything under 'rc3.d' is run sequenced by the numbers (S10 before S11, etc.). SysV doesn't care what is in the other rcX.d directories, it just looks into the directory that it is switching runlevel to. When switching in between runlevels (i.e. upon system boot), it also looks in the current runlevel directory and runs any script called Kxx (xx again a sequence number) to shutdown any services currently running. After this has been done it will start everything that is in the next runlevels directory. When switching e.g. from level 3 to level 5, SysV 1. runs all 'Kxx' scripts from rc3.d (K is for KILL) 2. runs all 'Sxx' scripts from rc5.d also the S10network before the S80sendmail is a convention that is actually great, it is an explicit ordering of deployments and is maybe complementary to the extension implicit ordering that was removed. +1 the other thing that i like about the solution is the lack of any xml mumbo jumbo dependencies, it is quite straightforward. +1 and again, unix is good :) +2 ;) Christian ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] Re: Bug in Connecter API
this method has been removed anyways (see http://java.sun.com/j2ee/apidocs-1_0-fr/api/javax/resource/cci/ConnectionFactory.html ); this has been updated accordingly in HEAD cvs. its still in Branch_2_4 though. _ View thread online: http://main.jboss.org/thread.jsp?forum=66thread=10362 ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbosspool/src/main/org/jboss/pool PoolParameters.java
User: lqd Date: 02/03/04 15:16:52 Modified:src/main/org/jboss/pool Tag: Branch_2_4 PoolParameters.java Log: - LOGGER_KEY not used anywhere Revision ChangesPath No revision No revision 1.1.1.1.2.3 +0 -1 jbosspool/src/main/org/jboss/pool/PoolParameters.java Index: PoolParameters.java === RCS file: /cvsroot/jboss/jbosspool/src/main/org/jboss/pool/PoolParameters.java,v retrieving revision 1.1.1.1.2.2 retrieving revision 1.1.1.1.2.3 diff -u -r1.1.1.1.2.2 -r1.1.1.1.2.3 --- PoolParameters.java 21 Feb 2002 22:46:33 - 1.1.1.1.2.2 +++ PoolParameters.java 4 Mar 2002 23:16:52 - 1.1.1.1.2.3 @@ -26,7 +26,6 @@ public final static String GC_MIN_IDLE_MS_KEY = GCMinIdleMillis; public final static String IDLE_TIMEOUT_MS_KEY = IdleTimeoutMillis; public final static String MAX_IDLE_TIMEOUT_PERCENT_KEY = MaxIdleTimeoutPercent; -public final static String LOGGER_KEY = Logger; public final static String LOGGER_ENABLED = LoggingEnabled; ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbosspool/src/main/org/jboss/pool/jdbc/xa/wrapper XADataSourceImpl.java
User: lqd Date: 02/03/04 15:35:09 Modified:src/main/org/jboss/pool/jdbc/xa/wrapper Tag: Branch_2_4 XADataSourceImpl.java Log: - more changes from proprietary PrintWriter logging to log4j - no more NPE at startup Revision ChangesPath No revision No revision 1.1.1.1.2.1 +70 -40 jbosspool/src/main/org/jboss/pool/jdbc/xa/wrapper/Attic/XADataSourceImpl.java Index: XADataSourceImpl.java === RCS file: /cvsroot/jboss/jbosspool/src/main/org/jboss/pool/jdbc/xa/wrapper/Attic/XADataSourceImpl.java,v retrieving revision 1.1.1.1 retrieving revision 1.1.1.1.2.1 diff -u -r1.1.1.1 -r1.1.1.1.2.1 --- XADataSourceImpl.java 15 May 2001 07:58:24 - 1.1.1.1 +++ XADataSourceImpl.java 4 Mar 2002 23:35:09 - 1.1.1.1.2.1 @@ -4,9 +4,15 @@ package org.jboss.pool.jdbc.xa.wrapper; import java.io.PrintWriter; -import java.sql.*; +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.SQLException; import java.util.Properties; -import javax.sql.*; +import javax.sql.XAConnection; +import javax.sql.XADataSource; + +import org.jboss.logging.Logger; +import org.jboss.logging.log4j.CategoryWriter; /** * Transactional DataSource wrapper for JDBC 1.0 drivers. This is very @@ -26,6 +32,8 @@ private int loginTimeout; private PrintWriter logWriter; +private static Logger log = Logger.getLogger( XADataSourceImpl.class ); + /** * Empty constructure for beans, reflection, etc. */ @@ -84,15 +92,31 @@ */ public void setProperties(Properties properties) {this.properties = properties;} -/** - * Gets the log writer used to record when XAConnections are opened. - */ -public PrintWriter getLogWriter() throws SQLException {return logWriter;} - -/** - * Sets a log writer used to record when XAConnections are opened. - */ -public void setLogWriter(PrintWriter writer) throws SQLException {logWriter = writer;} + /** +* Gets the log writer used to record when XAConnections are opened. +*/ + public PrintWriter getLogWriter() + throws SQLException + { + return logWriter; + } + + /** +* Sets a log writer used to record when XAConnections are opened. +*/ + public void setLogWriter(PrintWriter writer) + throws SQLException + { + if( writer == null ) + { + logWriter = null; + } + else + { + if( logWriter == null ) +logWriter = new CategoryWriter( log.getCategory() ); + } + } /** * This is not used by the current implementation, since the effect would @@ -106,37 +130,40 @@ */ public void setLoginTimeout(int timeout) throws SQLException {loginTimeout = timeout;} -/** - * Gets an XAConnection. This first gets a java.sql.Connection from the - * underlying driver, and then wraps it in an XAConnection and XAResource. - * This uses the URL, user, password, and properties (or as many as you - * have specified) to make the connection. - */ -public XAConnection getXAConnection() throws SQLException { -Connection con; -if(user != null user.length() 0) -con = DriverManager.getConnection(url, user, password); -else if(properties != null) -con = DriverManager.getConnection(url, properties); -else -con = DriverManager.getConnection(url); - -try { -con.setAutoCommit(false); -} catch(SQLException e) { -if(logWriter != null) -logWriter.println(XADataSource unable to disable auto-commit on +con.getClass().getName()); -} - -XAResourceImpl res = new XAResourceImpl(con); -XAConnectionImpl xacon = new XAConnectionImpl(con, res); -res.setXAConnection(xacon); + /** +* Gets an XAConnection. This first gets a java.sql.Connection from the +* underlying driver, and then wraps it in an XAConnection and XAResource. +* This uses the URL, user, password, and properties (or as many as you +* have specified) to make the connection. +*/ + public XAConnection getXAConnection() + throws SQLException + { + Connection con; + if(user != null user.length() 0) + con = DriverManager.getConnection(url, user, password); + else if(properties != null) + con = DriverManager.getConnection(url, properties); + else + con = DriverManager.getConnection(url); + + try + { + con.setAutoCommit(false); + } catch(SQLException e) + { +
[JBoss-dev] CVS update: jbosspool/src/main/org/jboss/pool/jdbc JDBCConnectionFactory.java JDBCPoolDataSource.java
User: lqd Date: 02/03/04 15:35:08 Modified:src/main/org/jboss/pool/jdbc Tag: Branch_2_4 JDBCConnectionFactory.java JDBCPoolDataSource.java Log: - more changes from proprietary PrintWriter logging to log4j - no more NPE at startup Revision ChangesPath No revision No revision 1.1.1.1.2.2 +231 -167 jbosspool/src/main/org/jboss/pool/jdbc/Attic/JDBCConnectionFactory.java Index: JDBCConnectionFactory.java === RCS file: /cvsroot/jboss/jbosspool/src/main/org/jboss/pool/jdbc/Attic/JDBCConnectionFactory.java,v retrieving revision 1.1.1.1.2.1 retrieving revision 1.1.1.1.2.2 diff -u -r1.1.1.1.2.1 -r1.1.1.1.2.2 --- JDBCConnectionFactory.java27 Feb 2002 08:14:03 - 1.1.1.1.2.1 +++ JDBCConnectionFactory.java4 Mar 2002 23:35:08 - 1.1.1.1.2.2 @@ -3,13 +3,15 @@ */ package org.jboss.pool.jdbc; -import java.io.PrintWriter; import java.sql.*; import java.util.Iterator; import java.util.Map; import java.util.Properties; import org.jboss.pool.cache.ObjectCache; -import org.jboss.pool.*; +import org.jboss.pool.ObjectPool; +import org.jboss.pool.PoolObjectFactory; + +import org.jboss.logging.Logger; /** * Object factory that creates java.sql.Connections. This is meant for use @@ -20,169 +22,231 @@ * * @author Aaron Mulder ([EMAIL PROTECTED]) */ -public class JDBCConnectionFactory extends PoolObjectFactory { -private String url; -private Properties props; -private String userName; -private String password; -private PrintWriter log; -private int psCacheSize = 10; -private ObjectPool pool; - -/** - * Creates a new factory. You must configure it with JDBC properties - * before you can use it. - */ -public JDBCConnectionFactory() { -} - -/** - * Sets the JDBC URL used to create new connections. - */ -public void setConnectURL(String url) {this.url = url;} - -/** - * Gets the JDBC URL used to create new connections. - */ -public String getConnectURL() {return url;} - -/** - * Sets the JDBC Propeties used to create new connections. - * This is optional, and will only be used if present. - */ -public void setConnectProperties(Properties props) {this.props = props;} - -/** - * Gets the JDBC Properties used to create new connections. - */ -public Properties getConnectProperties() {return props;} - -/** - * Sets the JDBC user name used to create new connections. - * This is optional, and will only be used if present. - */ -public void setUser(String userName) {this.userName = userName;} - -/** - * Gets the JDBC user name used to create new connections. - */ -public String getUser() {return userName;} - -/** - * Sets the JDBC password used to create new connections. - * This is optional, and will only be used if present. - */ -public void setPassword(String password) {this.password = password;} - -/** - * Gets the JDBC password used to create new connections. - */ -public String getPassword() {return password;} - -/** - * Sets the number of PreparedStatements to be cached for each - * Connection. Your DB product may impose a limit on the number - * of open PreparedStatements. The default value is 10. - */ -public void setPSCacheSize(int size) { -psCacheSize = size; -} - -/** - * Gets the number of PreparedStatements to be cached for each - * Connection. The default value is 10. - */ -public int getPSCacheSize() { -return psCacheSize; -} - -/** - * Validates that connection properties were set (at least a URL). - */ -public void poolStarted(ObjectPool pool, PrintWriter log) { -super.poolStarted(pool); -if(url == null) -throw new IllegalStateException(Must specify JDBC connection URL to +getClass().getName()); -this.pool = pool; -} - -/** - * Cleans up. - */ -public void poolClosing(ObjectPool pool) { -super.poolClosing(pool); -this.pool = null; -log = null; -} - -/** - * Creates a new JDBC Connection. - */ -public Object createObject(Object parameters) { -try { -if(userName != null userName.length() 0) -return DriverManager.getConnection(url, userName, password); -else if(props != null) -return DriverManager.getConnection(url, props); -else -return
[JBoss-dev] CVS update: jbosspool/src/main/org/jboss/pool/jdbc/xa XAConnectionFactory.java XAPoolDataSource.java XAPoolDriver.java
User: lqd Date: 02/03/04 15:35:08 Modified:src/main/org/jboss/pool/jdbc/xa Tag: Branch_2_4 XAConnectionFactory.java XAPoolDataSource.java XAPoolDriver.java Log: - more changes from proprietary PrintWriter logging to log4j - no more NPE at startup Revision ChangesPath No revision No revision 1.2.2.2 +91 -65 jbosspool/src/main/org/jboss/pool/jdbc/xa/Attic/XAConnectionFactory.java Index: XAConnectionFactory.java === RCS file: /cvsroot/jboss/jbosspool/src/main/org/jboss/pool/jdbc/xa/Attic/XAConnectionFactory.java,v retrieving revision 1.2.2.1 retrieving revision 1.2.2.2 diff -u -r1.2.2.1 -r1.2.2.2 --- XAConnectionFactory.java 27 Feb 2002 08:14:03 - 1.2.2.1 +++ XAConnectionFactory.java 4 Mar 2002 23:35:08 - 1.2.2.2 @@ -3,7 +3,6 @@ */ package org.jboss.pool.jdbc.xa; -import java.io.PrintWriter; import java.sql.SQLException; import java.util.HashMap; import javax.sql.ConnectionEvent; @@ -21,6 +20,7 @@ import org.jboss.pool.jdbc.xa.wrapper.TransactionListener; import org.jboss.pool.jdbc.xa.wrapper.XAConnectionImpl; import org.jboss.pool.jdbc.xa.wrapper.XAResourceImpl; +import org.jboss.logging.Logger; /** * Object factory for JDBC 2.0 standard extension XAConnections. You pool the @@ -42,7 +42,9 @@ * REVISIONS: * 20010703 bill added code for transaction isolation */ -public class XAConnectionFactory extends PoolObjectFactory { +public class XAConnectionFactory + extends PoolObjectFactory +{ public static final int DEFAULT_ISOLATION = -1; private InitialContext ctx; @@ -55,10 +57,11 @@ private ConnectionEventListener listener, errorListener; private TransactionListener transListener; private ObjectPool pool; -private PrintWriter log; private HashMap wrapperTx, rms; private TransactionManager tm; + private static Logger log = Logger.getLogger( XAConnectionFactory.class ); + /** * Creates a new factory. You must set the XADataSource and * TransactionManager JNDI name before the factory can be used. @@ -105,8 +108,7 @@ rms.remove(con); } } catch(Exception e) { -if(log != null) -e.printStackTrace(log); + log.error( Unable to deregister with TransactionManager, e ); throw new RuntimeException(Unable to deregister with TransactionManager: +e); } @@ -241,9 +243,12 @@ /** * Verifies that the data source and transaction manager are accessible. */ -public void poolStarted(ObjectPool pool, PrintWriter log) { +public void poolStarted(ObjectPool pool) +{ + if( log.isDebugEnabled() ) + log.debug( Starting ); + super.poolStarted(pool); -this.log = log; this.pool = pool; if(source == null) throw new IllegalStateException(Must specify XADataSource to +getClass().getName()); @@ -258,68 +263,86 @@ } } -/** - * Creates a new XAConnection from the provided XADataSource. - */ -public Object createObject(Object parameters) { -try { -if(userName != null userName.length() 0) -return source.getXAConnection(userName, password); -else -return source.getXAConnection(); -} catch(SQLException e) { -if(log != null) -e.printStackTrace(log); -} -return null; -} + /** +* Creates a new XAConnection from the provided XADataSource. +*/ + public Object createObject(Object parameters) + { + if( log.isTraceEnabled() ) + log.trace( Opening new XAConnection ); + + try + { + if(userName != null userName.length() 0) +return source.getXAConnection(userName, password); + else +return source.getXAConnection(); + } + catch(SQLException e) + { + log.error( Can't get an XAConnection, e ); + } + return null; + } -/** - * Registers the XAConnection's XAResource with the current transaction (if - * there is one). Sets listeners that will handle deregistering and - * returning the XAConnection to the pool via callbacks. - */ -public Object prepareObject(Object pooledObject) { -XAConnection con = (XAConnection)pooledObject; -con.addConnectionEventListener(listener); -Transaction trans = null; -try { -if(tm.getStatus() !=
[JBoss-dev] CVS update: jboss/src/etc/deploy jbosspool-jdbc.rar
User: lqd Date: 02/03/04 15:41:39 Modified:src/etc/deploy Tag: Branch_2_4 jbosspool-jdbc.rar Log: sync jbosspool .jar files for release Revision ChangesPath No revision No revision 1.1.4.6 +73 -48jboss/src/etc/deploy/Attic/jbosspool-jdbc.rar Binary file ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbosspool/src/main/org/jboss/pool/connector/jboss MinervaNoTransCMFactory.java MinervaSharedLocalCMFactory.java MinervaXACMFactory.java
User: lqd Date: 02/02/22 01:34:40 Modified:src/main/org/jboss/pool/connector/jboss Tag: Branch_2_4 MinervaNoTransCMFactory.java MinervaSharedLocalCMFactory.java MinervaXACMFactory.java Log: - enable parameter TimestampUsed in jboss.jcml Revision ChangesPath No revision No revision 1.1.1.1.2.1 +18 -2 jbosspool/src/main/org/jboss/pool/connector/jboss/Attic/MinervaNoTransCMFactory.java Index: MinervaNoTransCMFactory.java === RCS file: /cvsroot/jboss/jbosspool/src/main/org/jboss/pool/connector/jboss/Attic/MinervaNoTransCMFactory.java,v retrieving revision 1.1.1.1 retrieving revision 1.1.1.1.2.1 diff -u -r1.1.1.1 -r1.1.1.1.2.1 --- MinervaNoTransCMFactory.java 15 May 2001 07:58:24 - 1.1.1.1 +++ MinervaNoTransCMFactory.java 22 Feb 2002 09:34:39 - 1.1.1.1.2.1 @@ -19,7 +19,7 @@ * Implementation of JBoss connector initialization for no-transaction * connection managers. * @author Aaron Mulder [EMAIL PROTECTED] - * @version $Revision: 1.1.1.1 $ + * @version $Revision: 1.1.1.1.2.1 $ */ public class MinervaNoTransCMFactory implements ConnectionManagerFactory { private TransactionManager tm; @@ -83,6 +83,19 @@ if(s != null) try {params.idleTimeoutMillis = Long.parseLong(s);} catch(Exception e) {} s = props.getProperty(PoolParameters.INVALIDATE_ON_ERROR_KEY); if(s != null) try {params.invalidateOnError = new Boolean(s).booleanValue();} catch(Exception e) {} + + s = props.getProperty(PoolParameters.TRACK_LAST_USED_KEY); + if( s != null ) + { + try + { +params.trackLastUsed = new Boolean(s).booleanValue(); + } + catch( Exception ignored ) + { + } + } + s = props.getProperty(PoolParameters.MAX_IDLE_TIMEOUT_PERCENT_KEY); if(s != null) try {params.maxIdleTimeoutPercent = new Float(s).floatValue();} catch(Exception e) {} s = props.getProperty(PoolParameters.MAX_SIZE_KEY); @@ -112,4 +125,7 @@ return cm; } -} \ No newline at end of file +} +/* +vim:tabstop=3:et:shiftwidth=3 +*/ 1.1.1.1.2.2 +17 -1 jbosspool/src/main/org/jboss/pool/connector/jboss/Attic/MinervaSharedLocalCMFactory.java Index: MinervaSharedLocalCMFactory.java === RCS file: /cvsroot/jboss/jbosspool/src/main/org/jboss/pool/connector/jboss/Attic/MinervaSharedLocalCMFactory.java,v retrieving revision 1.1.1.1.2.1 retrieving revision 1.1.1.1.2.2 diff -u -r1.1.1.1.2.1 -r1.1.1.1.2.2 --- MinervaSharedLocalCMFactory.java 5 Nov 2001 06:06:19 - 1.1.1.1.2.1 +++ MinervaSharedLocalCMFactory.java 22 Feb 2002 09:34:39 - 1.1.1.1.2.2 @@ -18,7 +18,7 @@ /** * Implementation of JBoss connector initialization. * @author Aaron Mulder [EMAIL PROTECTED] - * @version $Revision: 1.1.1.1.2.1 $ + * @version $Revision: 1.1.1.1.2.2 $ */ public class MinervaSharedLocalCMFactory implements ConnectionManagerFactory { private TransactionManager tm; @@ -87,6 +87,19 @@ if(s != null) try {params.idleTimeoutMillis = Long.parseLong(s);} catch(Exception e) {} s = props.getProperty(PoolParameters.INVALIDATE_ON_ERROR_KEY); if(s != null) try {params.invalidateOnError = new Boolean(s).booleanValue();} catch(Exception e) {} + + s = props.getProperty(PoolParameters.TRACK_LAST_USED_KEY); + if( s != null ) + { + try + { +params.trackLastUsed = new Boolean(s).booleanValue(); + } + catch( Exception ignored ) + { + } + } + s = props.getProperty(PoolParameters.MAX_IDLE_TIMEOUT_PERCENT_KEY); if(s != null) try {params.maxIdleTimeoutPercent = new Float(s).floatValue();} catch(Exception e) {} s = props.getProperty(PoolParameters.MAX_SIZE_KEY); @@ -117,3 +130,6 @@ return cm; } } +/* +vim:tabstop=3:et:shiftwidth=3 +*/ 1.1.1.1.2.1 +18 -2 jbosspool/src/main/org/jboss/pool/connector/jboss/Attic/MinervaXACMFactory.java Index: MinervaXACMFactory.java === RCS file: /cvsroot/jboss/jbosspool/src/main/org/jboss/pool/connector/jboss/Attic/MinervaXACMFactory.java,v retrieving revision 1.1.1.1 retrieving revision 1.1.1.1.2.1 diff -u -r1.1.1.1 -r1.1.1.1.2.1 --- MinervaXACMFactory.java 15 May 2001 07:58:24 - 1.1.1.1 +++ MinervaXACMFactory.java 22 Feb 2002 09:34:39 - 1.1.1.1.2.1 @@ -18,7 +18,7 @@ /** * Implementation of JBoss connector
[JBoss-dev] CVS update: jbosspool/src/main/org/jboss/pool ObjectRecord.java
User: lqd Date: 02/02/22 02:46:29 Modified:src/main/org/jboss/pool Tag: Branch_2_4 ObjectRecord.java Log: - clean up imports Revision ChangesPath No revision No revision 1.1.1.1.2.1 +2 -1 jbosspool/src/main/org/jboss/pool/ObjectRecord.java Index: ObjectRecord.java === RCS file: /cvsroot/jboss/jbosspool/src/main/org/jboss/pool/ObjectRecord.java,v retrieving revision 1.1.1.1 retrieving revision 1.1.1.1.2.1 diff -u -r1.1.1.1 -r1.1.1.1.2.1 --- ObjectRecord.java 15 May 2001 07:58:24 - 1.1.1.1 +++ ObjectRecord.java 22 Feb 2002 10:46:29 - 1.1.1.1.2.1 @@ -3,7 +3,8 @@ */ package org.jboss.pool; -import java.util.*; +import java.util.Date; +import java.util.ConcurrentModificationException; /** * Stores the properties of an object in a pool. ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbosspool/src/main/org/jboss/pool PoolGCThread.java
User: lqd Date: 02/02/22 03:14:32 Modified:src/main/org/jboss/pool Tag: Branch_2_4 PoolGCThread.java Log: - add logging Revision ChangesPath No revision No revision 1.1.1.1.2.1 +116 -62 jbosspool/src/main/org/jboss/pool/PoolGCThread.java Index: PoolGCThread.java === RCS file: /cvsroot/jboss/jbosspool/src/main/org/jboss/pool/PoolGCThread.java,v retrieving revision 1.1.1.1 retrieving revision 1.1.1.1.2.1 diff -u -r1.1.1.1 -r1.1.1.1.2.1 --- PoolGCThread.java 15 May 2001 07:58:24 - 1.1.1.1 +++ PoolGCThread.java 22 Feb 2002 11:14:31 - 1.1.1.1.2.1 @@ -3,7 +3,10 @@ */ package org.jboss.pool; -import java.util.*; +import java.util.HashSet; +import java.util.Iterator; + +import org.jboss.logging.Logger; /** * Runs garbage collection on all available pools. Only one GC thread is @@ -12,68 +15,119 @@ * run on any pools which are pretty close to their requested time. * * @author Aaron Mulder ([EMAIL PROTECTED]) + * @version $Revision: 1.1.1.1.2.1 $ */ -class PoolGCThread extends Thread { -private HashSet pools = new HashSet(); - -PoolGCThread() { -super(Minerve ObjectPool GC Thread); -setDaemon(true); -} - -public void run() { -while(true) { -// Don't do anything while there's nothing to do -waitForPools(); -// Figure out how long to sleep -long delay = getDelay(); -// Sleep -if(delay 0l) { -try { -sleep(delay); -} catch(InterruptedException e) {} +class PoolGCThread extends Thread +{ + private HashSet pools = new HashSet(); + private static Logger log = Logger.getLogger( ObjectPool.class ); + + PoolGCThread() + { + super(Minerva ObjectPool GC Thread); + setDaemon(true); + } + + public void run() + { + boolean debug = log.isDebugEnabled(); + while(true) + { + // Don't do anything while there's nothing to do + waitForPools(); + if( debug ) +log.debug(gc thread waited for pools); + + // Figure out how long to sleep + long delay = getDelay(); + if( debug ) +log.debug(gc thread delay: + delay); + + // Sleep + if(delay 0l) + { +try +{ + sleep(delay); } -// Run garbage collection on eligible pools -runGC(); -} -} - -private synchronized void waitForPools() { -while(pools.size() == 0) { -try { -wait(); -} catch(InterruptedException e) { -} -} -} +catch(InterruptedException ignored) {} + } + + // Run garbage collection on eligible pools + runGC(); + } + } + + private synchronized void waitForPools() + { + while(pools.size() == 0) + { + try + { +wait(); + } + catch(InterruptedException ignored) + { +// Warning level seems appropriate; shouldn't really happen +log.warn(waitForPools interrupted); + } + } + } + + private synchronized long getDelay() + { + long next = Long.MAX_VALUE; + long now = System.currentTimeMillis(); + long current; + + for(Iterator it = pools.iterator(); it.hasNext();) + { + ObjectPool pool = (ObjectPool)it.next(); + current = pool.getNextGCMillis(now); + if(current next) +next = current; + } + return next = 0l ? next : 0l; + } + + private synchronized void runGC() + { + boolean debug = log.isDebugEnabled(); + + if( debug ) + log.debug(GC thread running GC); + + for(Iterator it = pools.iterator(); it.hasNext();) + { + ObjectPool pool = (ObjectPool)it.next(); + + if( debug ) +log.debug(GC Thread pool: + pool.getName() + , isTimeToGC(): + pool.isTimeToGC() ); + + if(pool.isTimeToGC()) +pool.runGCandShrink(); + } + } + + synchronized void addPool(ObjectPool pool) + { + if( log.isDebugEnabled() ) + log.debug( Adding pool: + pool.getName() + , GC enabled: + pool.isGCEnabled() ); + + if(pool.isGCEnabled()) + pools.add(pool); + + notify(); + } + + synchronized void removePool(ObjectPool pool) + { + if( log.isDebugEnabled() ) + log.debug( Removing pool: + pool.getName() );
[JBoss-dev] CVS update: jbosspool/src/main/org/jboss/pool ObjectPool.java PoolObjectFactory.java
User: lqd Date: 02/02/22 03:15:48 Modified:src/main/org/jboss/pool Tag: Branch_2_4 ObjectPool.java PoolObjectFactory.java Log: - apply patch #515411 - remove legacy logging w/ PrintWriter, switch to log4j Revision ChangesPath No revision No revision 1.2.2.4 +123 -74 jbosspool/src/main/org/jboss/pool/ObjectPool.java Index: ObjectPool.java === RCS file: /cvsroot/jboss/jbosspool/src/main/org/jboss/pool/ObjectPool.java,v retrieving revision 1.2.2.3 retrieving revision 1.2.2.4 diff -u -r1.2.2.3 -r1.2.2.4 --- ObjectPool.java 27 Dec 2001 20:50:40 - 1.2.2.3 +++ ObjectPool.java 22 Feb 2002 11:15:48 - 1.2.2.4 @@ -3,7 +3,6 @@ */ package org.jboss.pool; -import java.io.PrintWriter; import java.util.ConcurrentModificationException; import java.util.HashMap; import java.util.HashSet; @@ -62,7 +61,6 @@ private int blockingTimeout = -1;// meaning forever private boolean trackLastUsed = false; private boolean invalidateOnError = false; - private PrintWriter logWriter = null; private Object resizeLock = new Object(); /** @@ -157,8 +155,7 @@ if(poolName != null !poolName.equals(name)) throw new IllegalStateException(Cannot change pool name once set!); poolName = name; - String category = ObjectPool.class.getName() + . + name; - log = Logger.getLogger(category); + log = Logger.getLogger( ObjectPool.class.getName() + . + name); } /** @@ -168,27 +165,6 @@ {return poolName;} /** -* Gets a log writer used to record pool events. -*/ - public PrintWriter getLogWriter() - { - return logWriter; - } - - /** -* Sets a log writer used to record pool events. -* @throws java.lang.IllegalStateException -*Occurs when you try to set the log writer after the pool has been -*initialized. -*/ - public void setLogWriter(PrintWriter writer) - { - if(objects != null) - throw new IllegalStateException(INITIALIZED); - logWriter = writer; - } - - /** * Sets the minimum size of the pool. The pool will create this many * instances at startup, and once running, it will never shrink below this * size. The default is zero. @@ -213,7 +189,9 @@ * @see #setMinSize */ public int getMinSize() - {return minSize;} + { + return minSize; + } /** * Sets the maximum size of the pool. Once the pool has grown to hold this @@ -237,7 +215,7 @@ if(maxSize != 0 minSize maxSize) { minSize = maxSize; - log.warn(pool min size set to +minSize+ to stay = max size); + log.warn(pool min size set to + minSize + to stay = max size); } } @@ -246,7 +224,9 @@ * @see #setMaxSize */ public int getMaxSize() - {return maxSize;} + { + return maxSize; + } /** * Sets whether the pool should release instances that have not been used @@ -348,7 +328,9 @@ * @see #setMaxIdleTimeoutPercent */ public float getMaxIdleTimeoutPercent() - {return maxIdleShrinkPercent;} + { + return maxIdleShrinkPercent; + } /** * Sets the minimum idle time to release an unused object from the pool. If @@ -368,6 +350,9 @@ if(objects != null) throw new IllegalStateException(INITIALIZED); idleTimeoutMillis = millis; + + if( log.isDebugEnabled() ) + log.debug( setIdleTimeout( + millis + ) ); } /** @@ -375,7 +360,9 @@ * @see #setIdleTimeout */ public long getIdleTimeout() - {return idleTimeoutMillis;} + { + return idleTimeoutMillis; + } /** * Sets the minimum idle time to make an object eligible for garbage @@ -396,6 +383,9 @@ if(objects != null) throw new IllegalStateException(INITIALIZED); gcMinIdleMillis = millis; + + if( log.isDebugEnabled() ) + log.debug( setGCMinIdleTime( + millis + ) ); } /** @@ -404,7 +394,9 @@ * @see #setGCMinIdleTime */ public long getGCMinIdleTime() - {return gcMinIdleMillis;} + { + return gcMinIdleMillis; + } /** * Sets the length of time between garbage collection and idle timeout runs. @@ -424,7 +416,11 @@ { if(objects != null) throw new IllegalStateException(INITIALIZED); + gcIntervalMillis = millis; + + if( log.isDebugEnabled() ) + log.debug( setGCInterval( + gcIntervalMillis + ) ); }
[JBoss-dev] CVS update: jbosspool/src/main/org/jboss/pool PoolGCThread.java
User: lqd Date: 02/02/22 04:09:09 Modified:src/main/org/jboss/pool Tag: Branch_2_4 PoolGCThread.java Log: - oops, a TAB slipped in Revision ChangesPath No revision No revision 1.1.1.1.2.2 +2 -2 jbosspool/src/main/org/jboss/pool/PoolGCThread.java Index: PoolGCThread.java === RCS file: /cvsroot/jboss/jbosspool/src/main/org/jboss/pool/PoolGCThread.java,v retrieving revision 1.1.1.1.2.1 retrieving revision 1.1.1.1.2.2 diff -u -r1.1.1.1.2.1 -r1.1.1.1.2.2 --- PoolGCThread.java 22 Feb 2002 11:14:31 - 1.1.1.1.2.1 +++ PoolGCThread.java 22 Feb 2002 12:09:09 - 1.1.1.1.2.2 @@ -15,12 +15,12 @@ * run on any pools which are pretty close to their requested time. * * @author Aaron Mulder ([EMAIL PROTECTED]) - * @version $Revision: 1.1.1.1.2.1 $ + * @version $Revision: 1.1.1.1.2.2 $ */ class PoolGCThread extends Thread { private HashSet pools = new HashSet(); - private static Logger log = Logger.getLogger( ObjectPool.class ); + private static Logger log = Logger.getLogger( ObjectPool.class ); PoolGCThread() { ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] Custom / Generated Finders non-spec compliant
Hi, combing through the JBoss SF Bug database I found the following in the patches section: http://sourceforge.net/tracker/index.php?func=detailaid=437043group_id=22866atid=376687 Whoever submitted this is actually correct; the EJB Spec (1.1 and 2.0) state that Finder methods should be prefixed by find (i.e. findMETHOD). The spec doesn't require findBy except for the findByPrimaryKey method of course. The suggested patch would fix the problem but this is only half of the story (it will only deal with custom finders declared in the home interface): all of JBoss's auto-generated finder methods for CMP EB's are also prefixed by findBy which doesn't seem valid according to the specs; i.e. if you have a CMP field String name; the generated finder method should read Collection findName(String parameter); but JBoss generates Collection findByName(String parameter); I haven't seen anybody complaining about this (the findBy prefix is more intuitive anyways IMO) but this should be fixed. The fix seems easy enough and I would be willing to take it but this could break a lot of apps out there that rely on the method being prefixed with findBy ... Any opinions on this? We could just generate the spec-compliant methods AND the findBy stuff but this seems a bit awkward ... Best regards, Christian ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] Bug?: no rollback on tx timeout
hi, On Thu, 2002-02-21 at 20:47, Bill Burke wrote: P.S. I need to solve this problem for work. So if I get no feedback, bewareI'll be making changes. There's one more issue which might be related to this (or not at all, I don't have the necessary insights): When a Bean is enrolled in a transaction and the bean gets passivated (either because the transaction is taking too long or your bean cache is running low), the server will throw a lot of NPE's and the transaction will be marked for rollback -- even if the DB stuff would actually commit at the end of the transaction. Regards, Christian ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
RE: [JBoss-dev] Bug?: no rollback on tx timeout
hi, On Thu, 2002-02-21 at 21:56, Bill Burke wrote: I thought a bean wasn't allowed to be passivated if it was involved with a transaction? Check out the canPassivate method on the instance cache. you're correct. the thrown exception is not a NPE but instead an IllegalStateExeption; we talked about this in private mail on Jan 17, check your archives if you still have them ... Anyways, I will re-post my mail below; I didn't have any time to look further into this issue. All line numbers mentioned refer to CVS Branch_2_4; but I *think* the bug is still in RH: -- snip -- On Thu, 2002-01-17 at 17:30, Bill Burke wrote: Dude. Your fix was a good one. Just add getContainer().getLockManager().removeLockRef(id); in AbstractInstanceCache.release()? Or is there something more? Actually I don't know ... what happens in the PassivationJob() that is scheduled via schedulePassivation(ctx) in the AbstractInstanceCache.release() ?! From the looks of it, PassivationJob.execute() inserts the bean into the cache again, if it can't be passivated -- shouldn't we actually keep the lock on it in this case (lines 705ff)? I'm a bit puzzled ... The fix also produces IllegalStateExceptions in QueuedPessimisticEJBLock (line 441) when the passivation kicks in and a transaction is still running ... we've seen this b/c we are running with ridiculously low settings for the cache for debugging this. Actually I *think* that the call to removeLockRef() should happen at the end of the PassivationJob -- although that also doesn't seem right ... we should possibly check if there's a transaction running on the bean before trying to passivate it. Do you get my leanings? :) -- /snip -- to reproduce, set your cache settings ridiculously low (i.e. 100ms max lifetime or something like that) and run one of the EB test cases vs. the server. I'm sorry if the explanation of the issue at stake is a bit vague but I don't have sufficient insights into what is happening and why; under normal circumstances this bug won't bite you but it will happen when your cache is running low and/or your transaction is taking a lot of time (e.g. longer than the max cache lifetime) best regards, christian ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbosspool/src/main/org/jboss/pool PoolParameters.java
User: lqd Date: 02/02/21 14:46:33 Modified:src/main/org/jboss/pool Tag: Branch_2_4 PoolParameters.java Log: - fix speling mistake. GCIntervalMillis actually works now ... Revision ChangesPath No revision No revision 1.1.1.1.2.2 +4 -1 jbosspool/src/main/org/jboss/pool/PoolParameters.java Index: PoolParameters.java === RCS file: /cvsroot/jboss/jbosspool/src/main/org/jboss/pool/PoolParameters.java,v retrieving revision 1.1.1.1.2.1 retrieving revision 1.1.1.1.2.2 diff -u -r1.1.1.1.2.1 -r1.1.1.1.2.2 --- PoolParameters.java 5 Nov 2001 06:06:19 - 1.1.1.1.2.1 +++ PoolParameters.java 21 Feb 2002 22:46:33 - 1.1.1.1.2.2 @@ -22,7 +22,7 @@ public final static String IDLE_TIMEOUT_ENABLED_KEY = IdleTimeoutEnabled; public final static String INVALIDATE_ON_ERROR_KEY = InvalidateOnError; public final static String TRACK_LAST_USED_KEY = TimestampUsed; -public final static String GC_INTERVAL_MS_KEY = GCIntervazlMillis; +public final static String GC_INTERVAL_MS_KEY = GCIntervalMillis; public final static String GC_MIN_IDLE_MS_KEY = GCMinIdleMillis; public final static String IDLE_TIMEOUT_MS_KEY = IdleTimeoutMillis; public final static String MAX_IDLE_TIMEOUT_PERCENT_KEY = MaxIdleTimeoutPercent; @@ -47,3 +47,6 @@ public PoolParameters() { } } +/* +vim:tabstop=3:et:shiftwidth=3 +*/ ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/pm/rollinglogged PersistenceManager.java PersistenceManagerMBean.java
User: lqd Date: 02/02/19 08:11:22 Modified:src/main/org/jboss/mq/pm/rollinglogged PersistenceManager.java PersistenceManagerMBean.java Log: - add ability to set rollover size via JMX (was fix at 1000 before) - yank dead (commented out) code - replace custom DEBUG logging to System.out to use log4j - clean up ambigious use of SpyMessageLog log - change to messageLog Revision ChangesPath 1.18 +46 -229 jbossmq/src/main/org/jboss/mq/pm/rollinglogged/PersistenceManager.java Index: PersistenceManager.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/pm/rollinglogged/PersistenceManager.java,v retrieving revision 1.17 retrieving revision 1.18 diff -u -r1.17 -r1.18 --- PersistenceManager.java 13 Feb 2002 04:26:38 - 1.17 +++ PersistenceManager.java 19 Feb 2002 16:11:22 - 1.18 @@ -39,15 +39,13 @@ * * @author David Maplesden ([EMAIL PROTECTED]) * @author a href=mailto:[EMAIL PROTECTED];David Jencks/a - * @version$Revision: 1.17 $ + * @version$Revision: 1.18 $ */ public class PersistenceManager extends ServiceMBeanSupport implements org.jboss.mq.pm.PersistenceManager, PersistenceManagerMBean { - public final static int ROLL_OVER_SIZE = 1000; public final static String TRANS_FILE_NAME = transactions.dat; - public final static boolean DEBUG = false; protected static int MAX_POOL_SIZE = 50; @@ -74,7 +72,7 @@ TxManager txManager; private String dataDirectory; - + private int rollOverSize; private HashMap unrestoredMessages = new HashMap(); @@ -84,7 +82,8 @@ * * @exception javax.jms.JMSException Description of Exception */ - public PersistenceManager() throws javax.jms.JMSException + public PersistenceManager() + throws javax.jms.JMSException { txManager = new TxManager(this); } @@ -127,13 +126,21 @@ return dataDirectory; } + public void setRollOverSize( int rollOverSize ) + { + this.rollOverSize = rollOverSize; + } + + public int getRollOverSize() + { + return rollOverSize; + } public Object getInstance() { return this; } - /** * getTxManager method comment. * @@ -144,74 +151,14 @@ return txManager; } - /*public void initQueue(SpyDestination dest) throws javax.jms.JMSException - { - log.error(You called the wrong initQueue method); - } - */ /** * #Description of the Method * * @param destDescription of Parameter * @exception javax.jms.JMSException Description of Exception */ - // public void initQueue(JMSDestination jmsDest) throws javax.jms.JMSException - //{ - // restoreDestination(jmsDest); - /* - SpyDestination dest = jmsDest.getSpyDestination(); - - String destName = dest.toString(); - //really? what about multiple subscribers on a topic? - queues.put(destName, dest); - //new - restoreDestination(jmsDest); - SpyTxLog txLog = null; - - // if called before we have been started there is no need to setup log files - if(currentTxLog == null) - return; - - HashMap logs; - synchronized (messageLogs) - { - logs = (HashMap)messageLogs.get(currentTxLog); - if (logs == null) - { -logs = new HashMap(); -messageLogs.put(currentTxLog, logs); - } - synchronized (logs) - { -LogInfo logInfo = (LogInfo)logs.get(destName); - -if (logInfo == null) -{ - try - { - SpyMessageLog log = new SpyMessageLog(new File(dataDir, destName + .dat + numRollOvers)); - logInfo = new LogInfo(log, dest, currentTxLog); - logs.put(destName, logInfo); - } - catch (Exception e) - { - JMSException jme = new SpyJMSException(Error rolling over logs to new files.); - jme.setLinkedException(e); - throw jme; - } -} - } - } -*/ - // } - - /** -* #Description of the Method -* -* @param destDescription of Parameter -* @exception javax.jms.JMSException Description of Exception -*/ - public void destroyQueue(SpyDestination dest) throws javax.jms.JMSException + public void destroyQueue(SpyDestination dest) + throws javax.jms.JMSException { try @@ -233,9 +180,9
RE: [JBoss-dev] Can we have funtional freeze?
hi, completely off-topic but i couldn't resist: On Tue, 2002-02-05 at 03:18, marc fleury wrote: Bill, you win, throw a party today, looking at bill's sourceforge login (patriot1burke) i guess that bill has already won sunday night and is still partying 8). good game by the patriots, was worth staying up till 4:30am for it. rgds, christian ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/il/oil OILServerILService.java
User: lqd Date: 02/02/01 19:54:20 Modified:src/main/org/jboss/mq/il/oil OILServerILService.java Log: remove wildcard import statements Revision ChangesPath 1.17 +2 -4 jbossmq/src/main/org/jboss/mq/il/oil/OILServerILService.java Index: OILServerILService.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/il/oil/OILServerILService.java,v retrieving revision 1.16 retrieving revision 1.17 diff -u -r1.16 -r1.17 --- OILServerILService.java 2002/01/11 20:18:57 1.16 +++ OILServerILService.java 2002/02/02 03:54:19 1.17 @@ -25,7 +25,6 @@ import javax.jms.TemporaryQueue; import javax.jms.TemporaryTopic; import javax.jms.Topic; -import javax.management.*; import javax.naming.InitialContext; import org.jboss.mq.AcknowledgementRequest; @@ -38,9 +37,8 @@ import org.jboss.mq.TransactionRequest; import org.jboss.mq.il.ServerIL; import org.jboss.mq.il.ServerILJMXService; -import org.jboss.mq.il.uil.multiplexor.*; -import org.jboss.mq.server.JMSServer; import org.jboss.mq.il.ServerILFactory; +import org.jboss.mq.server.JMSServer; import org.jboss.system.ServiceMBeanSupport; @@ -48,7 +46,7 @@ * Implements the ServerILJMXService which is used to manage the JVM IL. * * @authorHiram Chirino ([EMAIL PROTECTED]) - * @version $Revision: 1.16 $ + * @version $Revision: 1.17 $ */ public final class OILServerILService extends org.jboss.mq.il.ServerILJMXService ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/il/jvm JVMServerILService.java
User: lqd Date: 02/02/01 19:54:19 Modified:src/main/org/jboss/mq/il/jvm JVMServerILService.java Log: remove wildcard import statements Revision ChangesPath 1.7 +1 -2 jbossmq/src/main/org/jboss/mq/il/jvm/JVMServerILService.java Index: JVMServerILService.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/il/jvm/JVMServerILService.java,v retrieving revision 1.6 retrieving revision 1.7 diff -u -r1.6 -r1.7 --- JVMServerILService.java 2001/11/10 21:38:04 1.6 +++ JVMServerILService.java 2002/02/02 03:54:19 1.7 @@ -7,7 +7,6 @@ package org.jboss.mq.il.jvm; import java.util.Properties; -import javax.management.*; import javax.naming.InitialContext; import org.jboss.mq.GenericConnectionFactory; @@ -24,7 +23,7 @@ * @author Hiram Chirino ([EMAIL PROTECTED]) * @author David Maplesden ([EMAIL PROTECTED]) * @createdAugust 16, 2001 - * @version$Revision: 1.6 $ + * @version$Revision: 1.7 $ */ public class JVMServerILService extends org.jboss.mq.il.ServerILJMXService implements JVMServerILServiceMBean { ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq SpyBytesMessage.java SpyMapMessage.java SpyMessage.java SpyObjectMessage.java SpyStreamMessage.java SpyTextMessage.java
User: lqd Date: 02/02/01 19:54:19 Modified:src/main/org/jboss/mq SpyBytesMessage.java SpyMapMessage.java SpyMessage.java SpyObjectMessage.java SpyStreamMessage.java SpyTextMessage.java Log: remove wildcard import statements Revision ChangesPath 1.7 +9 -2 jbossmq/src/main/org/jboss/mq/SpyBytesMessage.java Index: SpyBytesMessage.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/SpyBytesMessage.java,v retrieving revision 1.6 retrieving revision 1.7 diff -u -r1.6 -r1.7 --- SpyBytesMessage.java 2002/01/03 17:21:50 1.6 +++ SpyBytesMessage.java 2002/02/02 03:54:19 1.7 @@ -5,8 +5,15 @@ * See terms of license at gnu.org. */ package org.jboss.mq; -import java.io.*; +import java.io.ByteArrayInputStream; +import java.io.ByteArrayOutputStream; +import java.io.DataInputStream; +import java.io.DataOutputStream; +import java.io.EOFException; +import java.io.IOException; +import java.io.Externalizable; + import javax.jms.BytesMessage; import javax.jms.JMSException; import javax.jms.MessageEOFException; @@ -18,7 +25,7 @@ * * @author Norbert Lataille ([EMAIL PROTECTED]) * @createdAugust 16, 2001 - * @version$Revision: 1.6 $ + * @version$Revision: 1.7 $ */ public class SpyBytesMessage extends SpyMessage 1.5 +3 -2 jbossmq/src/main/org/jboss/mq/SpyMapMessage.java Index: SpyMapMessage.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/SpyMapMessage.java,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- SpyMapMessage.java2001/11/14 01:53:39 1.4 +++ SpyMapMessage.java2002/02/02 03:54:19 1.5 @@ -6,7 +6,8 @@ */ package org.jboss.mq; -import java.io.*; +import java.io.Externalizable; + import java.util.Enumeration; import java.util.Hashtable; import javax.jms.JMSException; @@ -20,7 +21,7 @@ * * @author Norbert Lataille ([EMAIL PROTECTED]) * @createdAugust 16, 2001 - * @version$Revision: 1.4 $ + * @version$Revision: 1.5 $ */ public class SpyMapMessage extends SpyMessage 1.12 +8 -2 jbossmq/src/main/org/jboss/mq/SpyMessage.java Index: SpyMessage.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/SpyMessage.java,v retrieving revision 1.11 retrieving revision 1.12 diff -u -r1.11 -r1.12 --- SpyMessage.java 2001/11/26 23:13:32 1.11 +++ SpyMessage.java 2002/02/02 03:54:19 1.12 @@ -15,7 +15,13 @@ import java.util.Collections; import java.util.Enumeration; import java.util.HashMap; -import java.io.*; + +import java.io.Externalizable; +import java.io.Serializable; +import java.io.IOException; +import java.io.ObjectInput; +import java.io.ObjectOutput; + import java.lang.Comparable; /** @@ -25,7 +31,7 @@ * @author Hiram Chirino ([EMAIL PROTECTED]) * @author David Maplesden ([EMAIL PROTECTED]) * - * @version $Revision: 1.11 $ + * @version $Revision: 1.12 $ */ public class SpyMessage implements Serializable, Message, Comparable, Externalizable { 1.8 +12 -2 jbossmq/src/main/org/jboss/mq/SpyObjectMessage.java Index: SpyObjectMessage.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/SpyObjectMessage.java,v retrieving revision 1.7 retrieving revision 1.8 diff -u -r1.7 -r1.8 --- SpyObjectMessage.java 2001/11/14 01:53:40 1.7 +++ SpyObjectMessage.java 2002/02/02 03:54:19 1.8 @@ -5,7 +5,17 @@ * See terms of license at gnu.org. */ package org.jboss.mq; -import java.io.*; + +import java.io.ByteArrayInputStream; +import java.io.ByteArrayOutputStream; +import java.io.InputStream; +import java.io.ObjectOutputStream; +import java.io.ObjectInputStream; +import java.io.ObjectStreamClass; +import java.io.Externalizable; +import java.io.Serializable; +import java.io.IOException; + import javax.jms.JMSException; import javax.jms.MessageFormatException; import javax.jms.MessageNotWriteableException; @@ -17,7 +27,7 @@ * * @author Norbert Lataille ([EMAIL PROTECTED]) * @createdAugust 16, 2001 - * @version$Revision: 1.7 $ + * @version$Revision: 1.8 $ */ public class SpyObjectMessage extends SpyMessage 1.5 +3 -2 jbossmq/src/main/org/jboss/mq/SpyStreamMessage.java Index: SpyStreamMessage.java
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/il/uil/multiplexor StreamDemux.java StreamMux.java
User: lqd Date: 02/02/01 19:54:20 Modified:src/main/org/jboss/mq/il/uil/multiplexor StreamDemux.java StreamMux.java Log: remove wildcard import statements Revision ChangesPath 1.3 +7 -3 jbossmq/src/main/org/jboss/mq/il/uil/multiplexor/StreamDemux.java Index: StreamDemux.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/il/uil/multiplexor/StreamDemux.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- StreamDemux.java 2001/08/17 03:04:04 1.2 +++ StreamDemux.java 2002/02/02 03:54:20 1.3 @@ -6,16 +6,20 @@ */ package org.jboss.mq.il.uil.multiplexor; -import java.io.*; -import java.util.*; +import java.io.DataInputStream; +import java.io.InputStream; +import java.io.IOException; +import java.util.HashMap; +import java.util.Iterator; + /** * This class is used to demultiplex from a single stream into multiple * streams. * * @author Hiram Chirino ([EMAIL PROTECTED]) * @createdAugust 16, 2001 - * @version$Revision: 1.2 $ + * @version$Revision: 1.3 $ */ public class StreamDemux { 1.3 +6 -3 jbossmq/src/main/org/jboss/mq/il/uil/multiplexor/StreamMux.java Index: StreamMux.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/il/uil/multiplexor/StreamMux.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- StreamMux.java2001/08/17 03:04:04 1.2 +++ StreamMux.java2002/02/02 03:54:20 1.3 @@ -6,15 +6,18 @@ */ package org.jboss.mq.il.uil.multiplexor; -import java.io.*; -import java.util.*; +import java.io.DataOutputStream; +import java.io.OutputStream; +import java.io.IOException; +import java.util.HashMap; + /** * This class is used to multiplex from multiple streams into a single stream. * * @author Hiram Chirino ([EMAIL PROTECTED]) * @createdAugust 16, 2001 - * @version$Revision: 1.2 $ + * @version$Revision: 1.3 $ */ public class StreamMux { ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/il/rmi RMIServerILService.java
User: lqd Date: 02/02/01 19:54:20 Modified:src/main/org/jboss/mq/il/rmi RMIServerILService.java Log: remove wildcard import statements Revision ChangesPath 1.9 +1 -2 jbossmq/src/main/org/jboss/mq/il/rmi/RMIServerILService.java Index: RMIServerILService.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/il/rmi/RMIServerILService.java,v retrieving revision 1.8 retrieving revision 1.9 diff -u -r1.8 -r1.9 --- RMIServerILService.java 2002/01/03 04:00:53 1.8 +++ RMIServerILService.java 2002/02/02 03:54:20 1.9 @@ -8,7 +8,6 @@ package org.jboss.mq.il.rmi; import java.util.Properties; -import javax.management.*; import javax.naming.InitialContext; import org.jboss.mq.GenericConnectionFactory; @@ -21,7 +20,7 @@ * Implements the ServerILJMXService which is used to manage the JVM IL. * * @author Hiram Chirino ([EMAIL PROTECTED]) - * @version$Revision: 1.8 $ + * @version$Revision: 1.9 $ */ public class RMIServerILService extends org.jboss.mq.il.ServerILJMXService implements RMIServerILServiceMBean { ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/pm/rollinglogged IntegrityLog.java
User: lqd Date: 02/02/01 19:54:20 Modified:src/main/org/jboss/mq/pm/rollinglogged IntegrityLog.java Log: remove wildcard import statements Revision ChangesPath 1.4 +13 -3 jbossmq/src/main/org/jboss/mq/pm/rollinglogged/IntegrityLog.java Index: IntegrityLog.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/pm/rollinglogged/IntegrityLog.java,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- IntegrityLog.java 2001/09/04 02:22:29 1.3 +++ IntegrityLog.java 2002/02/02 03:54:20 1.4 @@ -6,9 +6,19 @@ */ package org.jboss.mq.pm.rollinglogged; -import java.io.*; +import java.io.File; +import java.io.RandomAccessFile; +import java.io.InputStream; +import java.io.OutputStream; +import java.io.ObjectInput; +import java.io.ObjectOutput; +import java.io.ObjectInputStream; +import java.io.ObjectOutputStream; +import java.io.Serializable; +import java.io.EOFException; +import java.io.IOException; -import org.jboss.mq.*; +import org.jboss.mq.SpyMessage; /** * This class is used to create a log file which which will will garantee it's @@ -17,7 +27,7 @@ * * @createdAugust 16, 2001 * @author:David Maplesden ([EMAIL PROTECTED]) - * @version$Revision: 1.3 $ + * @version$Revision: 1.4 $ */ public class IntegrityLog { ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/pm/file MessageLog.java PersistenceManager.java
User: lqd Date: 02/02/01 19:54:20 Modified:src/main/org/jboss/mq/pm/file MessageLog.java PersistenceManager.java Log: remove wildcard import statements Revision ChangesPath 1.11 +4 -2 jbossmq/src/main/org/jboss/mq/pm/file/MessageLog.java Index: MessageLog.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/pm/file/MessageLog.java,v retrieving revision 1.10 retrieving revision 1.11 diff -u -r1.10 -r1.11 --- MessageLog.java 2002/01/14 12:30:45 1.10 +++ MessageLog.java 2002/02/02 03:54:20 1.11 @@ -18,7 +18,9 @@ import java.util.Map; import java.util.TreeMap; import javax.jms.JMSException; -import org.jboss.mq.*; + +import org.jboss.mq.SpyMessage; +import org.jboss.mq.SpyJMSException; import org.jboss.mq.server.JMSServer; import org.jboss.mq.server.MessageCache; import org.jboss.mq.server.MessageReference ; @@ -31,7 +33,7 @@ * * @createdAugust 16, 2001 * @author:Paul Kendall ([EMAIL PROTECTED]) - * @version$Revision: 1.10 $ + * @version$Revision: 1.11 $ */ public class MessageLog { 1.16 +3 -2 jbossmq/src/main/org/jboss/mq/pm/file/PersistenceManager.java Index: PersistenceManager.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/pm/file/PersistenceManager.java,v retrieving revision 1.15 retrieving revision 1.16 diff -u -r1.15 -r1.16 --- PersistenceManager.java 2002/01/14 12:30:45 1.15 +++ PersistenceManager.java 2002/02/02 03:54:20 1.16 @@ -18,7 +18,8 @@ import java.util.Map; import java.util.TreeSet; import javax.jms.JMSException; -import javax.management.*; +import javax.management.ObjectName; + import org.jboss.mq.SpyDestination; import org.jboss.mq.SpyJMSException; import org.jboss.mq.SpyMessage; @@ -37,7 +38,7 @@ * persistence. * * @author Paul Kendall ([EMAIL PROTECTED]) - * @version$Revision: 1.15 $ + * @version$Revision: 1.16 $ */ public class PersistenceManager extends ServiceMBeanSupport implements PersistenceManagerMBean, org.jboss.mq.pm.PersistenceManager { ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/pm/jdbc MessageLog.java PersistenceManager.java TxLog.java
User: lqd Date: 02/02/01 19:54:20 Modified:src/main/org/jboss/mq/pm/jdbc MessageLog.java PersistenceManager.java TxLog.java Log: remove wildcard import statements Revision ChangesPath 1.10 +10 -4 jbossmq/src/main/org/jboss/mq/pm/jdbc/MessageLog.java Index: MessageLog.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/pm/jdbc/MessageLog.java,v retrieving revision 1.9 retrieving revision 1.10 diff -u -r1.9 -r1.10 --- MessageLog.java 2001/11/12 17:01:17 1.9 +++ MessageLog.java 2002/02/02 03:54:20 1.10 @@ -6,7 +6,8 @@ */ package org.jboss.mq.pm.jdbc; -import java.io.*; +import java.io.ByteArrayInputStream; +import java.io.ByteArrayOutputStream; import java.io.File; import java.io.FileInputStream; import java.io.FileOutputStream; @@ -14,13 +15,18 @@ import java.io.ObjectInputStream; import java.io.ObjectOutputStream; import java.io.Serializable; -import java.sql.*; import java.util.HashMap; import java.util.Map; import java.util.Set; import java.util.TreeMap; +import java.sql.Connection; +import java.sql.PreparedStatement; +import java.sql.ResultSet; +import java.sql.Statement; +import java.sql.SQLException; import javax.jms.JMSException; -import javax.sql.*; +import javax.sql.DataSource; + import org.jboss.mq.SpyDestination; import org.jboss.mq.SpyJMSException; import org.jboss.mq.SpyMessage; @@ -32,7 +38,7 @@ * queue in case of provider failure. * * @author: Jayesh Parayali ([EMAIL PROTECTED]) - * @version $Revision: 1.9 $ + * @version $Revision: 1.10 $ */ public class MessageLog { 1.14 +3 -7 jbossmq/src/main/org/jboss/mq/pm/jdbc/PersistenceManager.java Index: PersistenceManager.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/pm/jdbc/PersistenceManager.java,v retrieving revision 1.13 retrieving revision 1.14 diff -u -r1.13 -r1.14 --- PersistenceManager.java 2001/11/14 04:23:27 1.13 +++ PersistenceManager.java 2002/02/02 03:54:20 1.14 @@ -6,9 +6,7 @@ */ package org.jboss.mq.pm.jdbc; -import java.io.*; import java.net.URL; -import java.sql.*; import java.util.Collection; import java.util.HashMap; import java.util.Iterator; @@ -16,11 +14,9 @@ import java.util.Properties; import java.util.TreeSet; import javax.jms.JMSException; -import javax.management.*; -import javax.naming.*; +import javax.management.ObjectName; import javax.naming.InitialContext; -import javax.rmi.PortableRemoteObject; -import javax.sql.*; +import javax.sql.DataSource; import org.jboss.mq.ConnectionToken; import org.jboss.mq.SpyDestination; import org.jboss.mq.SpyJMSException; @@ -40,7 +36,7 @@ * * @author: Jayesh Parayali ([EMAIL PROTECTED]) * - * @version $Revision: 1.13 $ + * @version $Revision: 1.14 $ */ public class PersistenceManager extends ServiceMBeanSupport implements PersistenceManagerMBean, org.jboss.mq.pm.PersistenceManager { 1.5 +8 -4 jbossmq/src/main/org/jboss/mq/pm/jdbc/TxLog.java Index: TxLog.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/pm/jdbc/TxLog.java,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- TxLog.java2001/11/11 20:32:33 1.4 +++ TxLog.java2002/02/02 03:54:20 1.5 @@ -5,17 +5,21 @@ * See terms of license at gnu.org. */ package org.jboss.mq.pm.jdbc; + import java.io.IOException; import java.io.RandomAccessFile; import java.io.Serializable; -import java.sql.*; +import java.sql.Connection; +import java.sql.PreparedStatement; +import java.sql.ResultSet; +import java.sql.Statement; +import java.sql.SQLException; import java.util.Iterator; import java.util.TreeSet; import javax.jms.JMSException; -import javax.naming.*; -import javax.sql.*; +import javax.sql.DataSource; import org.jboss.mq.SpyJMSException; @@ -25,7 +29,7 @@ * * @createdAugust 16, 2001 * @author:Jayesh Parayali ([EMAIL PROTECTED]) - * @version$Revision: 1.4 $ + * @version$Revision: 1.5 $ */ public class TxLog { ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/xml XElement.java XElementProducer.java
User: lqd Date: 02/02/01 19:54:21 Modified:src/main/org/jboss/mq/xml XElement.java XElementProducer.java Log: remove wildcard import statements Revision ChangesPath 1.5 +3 -2 jbossmq/src/main/org/jboss/mq/xml/XElement.java Index: XElement.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/xml/XElement.java,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- XElement.java 2001/09/28 22:29:21 1.4 +++ XElement.java 2002/02/02 03:54:21 1.5 @@ -10,8 +10,9 @@ import java.util.Iterator; import java.util.Vector; -import org.xml.sax.*; +import org.xml.sax.Attributes; + /** * XElement provides an interface to an XML element. An XElement represents an * XML element which contains: br @@ -48,7 +49,7 @@ * * @author Hiram Chirino ([EMAIL PROTECTED]) * @createdAugust 16, 2001 - * @version$Revision: 1.4 $ + * @version$Revision: 1.5 $ */ public class XElement { 1.5 +7 -3 jbossmq/src/main/org/jboss/mq/xml/XElementProducer.java Index: XElementProducer.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/xml/XElementProducer.java,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- XElementProducer.java 2001/10/12 08:45:48 1.4 +++ XElementProducer.java 2002/02/02 03:54:21 1.5 @@ -6,10 +6,14 @@ */ package org.jboss.mq.xml; -import java.util.*; +import java.util.Vector; import javax.xml.parsers.SAXParser; import javax.xml.parsers.SAXParserFactory; -import org.xml.sax.*; + +import org.xml.sax.Attributes; +import org.xml.sax.InputSource; +import org.xml.sax.SAXException; +import org.xml.sax.XMLReader; import org.xml.sax.helpers.DefaultHandler; /** @@ -26,7 +30,7 @@ * * @author Hiram Chirino ([EMAIL PROTECTED]) * @createdAugust 16, 2001 - * @version$Revision: 1.4 $ + * @version$Revision: 1.5 $ */ public class XElementProducer { ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/server BasicQueue.java JMSDestination.java JMSQueue.java JMSServer.java JMSServerMBean.java JMSTopic.java MessageCache.java PersistentQueue.java QueueManager.java StateManager.java TopicManager.java
User: lqd Date: 02/02/01 19:54:21 Modified:src/main/org/jboss/mq/server BasicQueue.java JMSDestination.java JMSQueue.java JMSServer.java JMSServerMBean.java JMSTopic.java MessageCache.java PersistentQueue.java QueueManager.java StateManager.java TopicManager.java Log: remove wildcard import statements Revision ChangesPath 1.13 +4 -2 jbossmq/src/main/org/jboss/mq/server/BasicQueue.java Index: BasicQueue.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/server/BasicQueue.java,v retrieving revision 1.12 retrieving revision 1.13 diff -u -r1.12 -r1.13 --- BasicQueue.java 2002/01/13 01:10:03 1.12 +++ BasicQueue.java 2002/02/02 03:54:21 1.13 @@ -22,7 +22,9 @@ import org.jboss.mq.SpyMessage; -import org.jboss.mq.*; +import org.jboss.mq.AcknowledgementRequest; +import org.jboss.mq.SpyQueue; +import org.jboss.mq.Subscription; import org.jboss.mq.pm.PersistenceManager; import org.jboss.mq.selectors.Selector; @@ -34,7 +36,7 @@ * @author Norbert Lataille ([EMAIL PROTECTED]) * @author David Maplesden ([EMAIL PROTECTED]) * @createdAugust 16, 2001 - * @version$Revision: 1.12 $ + * @version$Revision: 1.13 $ */ //abstract public class BasicQueue implements Runnable { public class BasicQueue { 1.7 +4 -2 jbossmq/src/main/org/jboss/mq/server/JMSDestination.java Index: JMSDestination.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/server/JMSDestination.java,v retrieving revision 1.6 retrieving revision 1.7 diff -u -r1.6 -r1.7 --- JMSDestination.java 2002/01/13 01:10:03 1.6 +++ JMSDestination.java 2002/02/02 03:54:21 1.7 @@ -18,7 +18,9 @@ import org.jboss.logging.Logger; -import org.jboss.mq.*; +import org.jboss.mq.SpyDestination; +import org.jboss.mq.SpyMessage; +import org.jboss.mq.Subscription; /** * This class is a message queue which is stored (hashed by Destination) on the @@ -28,7 +30,7 @@ * @author Hiram Chirino ([EMAIL PROTECTED]) * @author David Maplesden ([EMAIL PROTECTED]) * @createdAugust 16, 2001 - * @version$Revision: 1.6 $ + * @version$Revision: 1.7 $ */ public abstract class JMSDestination { 1.8 +6 -2 jbossmq/src/main/org/jboss/mq/server/JMSQueue.java Index: JMSQueue.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/server/JMSQueue.java,v retrieving revision 1.7 retrieving revision 1.8 diff -u -r1.7 -r1.8 --- JMSQueue.java 2001/11/10 21:38:05 1.7 +++ JMSQueue.java 2002/02/02 03:54:21 1.8 @@ -5,6 +5,7 @@ * See terms of license at gnu.org. */ package org.jboss.mq.server; + import java.util.HashMap; import java.util.Hashtable; @@ -16,7 +17,10 @@ import javax.jms.Destination; import javax.jms.JMSException; -import org.jboss.mq.*; +import org.jboss.mq.SpyDestination; +import org.jboss.mq.SpyMessage; +import org.jboss.mq.SpyQueue; +import org.jboss.mq.Subscription; /** * This class is a message queue which is stored (hashed by Destination) on the @@ -26,7 +30,7 @@ * @author Hiram Chirino ([EMAIL PROTECTED]) * @author David Maplesden ([EMAIL PROTECTED]) * @createdAugust 16, 2001 - * @version$Revision: 1.7 $ + * @version$Revision: 1.8 $ */ public class JMSQueue extends JMSDestination { 1.13 +17 -6 jbossmq/src/main/org/jboss/mq/server/JMSServer.java Index: JMSServer.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/server/JMSServer.java,v retrieving revision 1.12 retrieving revision 1.13 diff -u -r1.12 -r1.13 --- JMSServer.java2002/01/05 06:38:13 1.12 +++ JMSServer.java2002/02/02 03:54:21 1.13 @@ -24,20 +24,31 @@ import javax.naming.InitialContext; import javax.naming.NamingException; -import org.jboss.logging.Logger; -import org.jboss.mq.*; -import org.jboss.mq.pm.*; - - +import org.jboss.mq.AcknowledgementRequest; +import org.jboss.mq.ConnectionToken; +import org.jboss.mq.DurableSubcriptionID; +import org.jboss.mq.SpyDestination; +import org.jboss.mq.SpyMessage; +import org.jboss.mq.SpyQueue; +import org.jboss.mq.SpyTopic; +import org.jboss.mq.SpyTemporaryQueue; +import org.jboss.mq.SpyTemporaryTopic; +import org.jboss.mq.SpyJMSException; +import org.jboss.mq.Subscription; +import org.jboss.mq.TransactionRequest; +import org.jboss.mq.pm.PersistenceManager;
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/il/jvm JVMServerIL.java
User: lqd Date: 02/02/01 20:02:23 Modified:src/main/org/jboss/mq/il/jvm JVMServerIL.java Log: Fix typo. this just ate 30mins of my time ... realizing a missing s in the class name ... argh! Revision ChangesPath 1.6 +3 -3 jbossmq/src/main/org/jboss/mq/il/jvm/JVMServerIL.java Index: JVMServerIL.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/il/jvm/JVMServerIL.java,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- JVMServerIL.java 2001/11/10 21:38:04 1.5 +++ JVMServerIL.java 2002/02/02 04:02:23 1.6 @@ -14,7 +14,7 @@ import javax.jms.Topic; import org.jboss.mq.AcknowledgementRequest; import org.jboss.mq.ConnectionToken; -import org.jboss.mq.DurableSubcriptionID; +import org.jboss.mq.DurableSubscriptionID; import org.jboss.mq.SpyDestination; import org.jboss.mq.SpyMessage; import org.jboss.mq.TransactionRequest; @@ -27,7 +27,7 @@ * * @authorHiram Chirino ([EMAIL PROTECTED]) * @authorNorbert Lataille ([EMAIL PROTECTED]) - * @version $Revision: 1.5 $ + * @version $Revision: 1.6 $ * @created August 16, 2001 */ public class JVMServerIL implements org.jboss.mq.il.ServerIL @@ -266,7 +266,7 @@ * @param id Description of Parameter * @exception Exception Description of Exception */ - public void destroySubscription(DurableSubcriptionID id) + public void destroySubscription(DurableSubscriptionID id) throws Exception { server.destroySubscription(id); ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/il ServerIL.java
User: lqd Date: 02/02/01 20:02:23 Modified:src/main/org/jboss/mq/il ServerIL.java Log: Fix typo. this just ate 30mins of my time ... realizing a missing s in the class name ... argh! Revision ChangesPath 1.4 +3 -3 jbossmq/src/main/org/jboss/mq/il/ServerIL.java Index: ServerIL.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/il/ServerIL.java,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- ServerIL.java 2001/09/26 05:02:27 1.3 +++ ServerIL.java 2002/02/02 04:02:23 1.4 @@ -14,7 +14,7 @@ import javax.jms.Topic; import org.jboss.mq.AcknowledgementRequest; import org.jboss.mq.ConnectionToken; -import org.jboss.mq.DurableSubcriptionID; +import org.jboss.mq.DurableSubscriptionID; import org.jboss.mq.SpyDestination; import org.jboss.mq.SpyMessage; @@ -25,7 +25,7 @@ * * @authorHiram Chirino ([EMAIL PROTECTED]) * @authorNorbert Lataille ([EMAIL PROTECTED]) - * @version $Revision: 1.3 $ + * @version $Revision: 1.4 $ * @created August 16, 2001 */ public interface ServerIL @@ -190,7 +190,7 @@ * @param id Description of Parameter * @exception Exception Description of Exception */ - public void destroySubscription(DurableSubcriptionID id) + public void destroySubscription(DurableSubscriptionID id) throws Exception; /** ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq DurableSubscriptionID.java Connection.java SpyDestination.java SpyMessage.java SpyTopic.java SpyTopicSession.java DurableSubcriptionID.java
User: lqd Date: 02/02/01 20:02:23 Modified:src/main/org/jboss/mq Connection.java SpyDestination.java SpyMessage.java SpyTopic.java SpyTopicSession.java Added: src/main/org/jboss/mq DurableSubscriptionID.java Removed: src/main/org/jboss/mq DurableSubcriptionID.java Log: Fix typo. this just ate 30mins of my time ... realizing a missing s in the class name ... argh! Revision ChangesPath 1.16 +2 -2 jbossmq/src/main/org/jboss/mq/Connection.java Index: Connection.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/Connection.java,v retrieving revision 1.15 retrieving revision 1.16 diff -u -r1.15 -r1.16 --- Connection.java 2002/01/05 06:38:13 1.15 +++ Connection.java 2002/02/02 04:02:22 1.16 @@ -36,7 +36,7 @@ * * @authorNorbert Lataille ([EMAIL PROTECTED]) * @authorHiram Chirino ([EMAIL PROTECTED]) - * @version $Revision: 1.15 $ + * @version $Revision: 1.16 $ * @created August 16, 2001 */ public class Connection implements java.io.Serializable, javax.jms.Connection @@ -1000,7 +1000,7 @@ //We could check this, though } - void unsubscribe(DurableSubcriptionID id) + void unsubscribe(DurableSubscriptionID id) throws JMSException { try 1.4 +2 -2 jbossmq/src/main/org/jboss/mq/SpyDestination.java Index: SpyDestination.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/SpyDestination.java,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- SpyDestination.java 2001/10/03 02:27:40 1.3 +++ SpyDestination.java 2002/02/02 04:02:22 1.4 @@ -18,7 +18,7 @@ * @author Hiram Chirino ([EMAIL PROTECTED]) * @author David Maplesden ([EMAIL PROTECTED]) * @createdAugust 16, 2001 - * @version$Revision: 1.3 $ + * @version$Revision: 1.4 $ */ public class SpyDestination implements Destination, Serializable { @@ -68,7 +68,7 @@ } else if ( dest instanceof SpyTopic ) { out.writeByte( SPY_TOPIC ); out.writeUTF( ( ( SpyTopic )dest ).getName() ); - DurableSubcriptionID id = ( ( SpyTopic )dest ).durableSubscriptionID; + DurableSubscriptionID id = ( ( SpyTopic )dest ).durableSubscriptionID; if ( id == null ) { out.writeByte( NULL ); } else { 1.13 +3 -3 jbossmq/src/main/org/jboss/mq/SpyMessage.java Index: SpyMessage.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/SpyMessage.java,v retrieving revision 1.12 retrieving revision 1.13 diff -u -r1.12 -r1.13 --- SpyMessage.java 2002/02/02 03:54:19 1.12 +++ SpyMessage.java 2002/02/02 04:02:22 1.13 @@ -31,7 +31,7 @@ * @author Hiram Chirino ([EMAIL PROTECTED]) * @author David Maplesden ([EMAIL PROTECTED]) * - * @version $Revision: 1.12 $ + * @version $Revision: 1.13 $ */ public class SpyMessage implements Serializable, Message, Comparable, Externalizable { @@ -70,7 +70,7 @@ //For noLocal to be able to tell if this was a locally produced message public String producerClientId; //For durable subscriptions - public DurableSubcriptionID durableSubscriberID = null; + public DurableSubscriptionID durableSubscriberID = null; //For ordering in the JMSServerQueue (set on the server side) public transient long messageId; } @@ -482,7 +482,7 @@ this.header.msgReadOnly = original.header.msgReadOnly; this.header.producerClientId = original.header.producerClientId; if (original.header.durableSubscriberID != null) - this.header.durableSubscriberID = new DurableSubcriptionID(original.header.durableSubscriberID.clientID, original.header.durableSubscriberID.subscriptionName); + this.header.durableSubscriberID = new DurableSubscriptionID(original.header.durableSubscriberID.clientID, original.header.durableSubscriberID.subscriptionName); } public boolean isOutdated() { 1.3 +5 -5 jbossmq/src/main/org/jboss/mq/SpyTopic.java Index: SpyTopic.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/SpyTopic.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- SpyTopic.java 2001/08/17 03:04:01 1.2 +++ SpyTopic.java 2002/02/02 04:02:22 1.3 @@ -21,11 +21,11 @@ * @author Hiram Chirino ([EMAIL PROTECTED]) * @author David Maplesden ([EMAIL PROTECTED]) * @createdAugust 16,
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/il/oil OILServerIL.java OILServerILService.java
User: lqd Date: 02/02/01 20:02:23 Modified:src/main/org/jboss/mq/il/oil OILServerIL.java OILServerILService.java Log: Fix typo. this just ate 30mins of my time ... realizing a missing s in the class name ... argh! Revision ChangesPath 1.7 +3 -3 jbossmq/src/main/org/jboss/mq/il/oil/OILServerIL.java Index: OILServerIL.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/il/oil/OILServerIL.java,v retrieving revision 1.6 retrieving revision 1.7 diff -u -r1.6 -r1.7 --- OILServerIL.java 2002/01/11 20:18:57 1.6 +++ OILServerIL.java 2002/02/02 04:02:23 1.7 @@ -23,7 +23,7 @@ import javax.jms.Topic; import org.jboss.mq.AcknowledgementRequest; import org.jboss.mq.ConnectionToken; -import org.jboss.mq.DurableSubcriptionID; +import org.jboss.mq.DurableSubscriptionID; import org.jboss.mq.SpyDestination; import org.jboss.mq.SpyMessage; import org.jboss.mq.TransactionRequest; @@ -37,7 +37,7 @@ * * @authorHiram Chirino ([EMAIL PROTECTED]) * @authorNorbert Lataille ([EMAIL PROTECTED]) - * @version $Revision: 1.6 $ + * @version $Revision: 1.7 $ * @created August 16, 2001 */ public final class OILServerIL @@ -348,7 +348,7 @@ * @exception JMSException Description of Exception * @exception Exception Description of Exception */ - public synchronized void destroySubscription(DurableSubcriptionID id) + public synchronized void destroySubscription(DurableSubscriptionID id) throws JMSException, Exception { checkConnection(); 1.18 +3 -3 jbossmq/src/main/org/jboss/mq/il/oil/OILServerILService.java Index: OILServerILService.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/il/oil/OILServerILService.java,v retrieving revision 1.17 retrieving revision 1.18 diff -u -r1.17 -r1.18 --- OILServerILService.java 2002/02/02 03:54:19 1.17 +++ OILServerILService.java 2002/02/02 04:02:23 1.18 @@ -29,7 +29,7 @@ import javax.naming.InitialContext; import org.jboss.mq.AcknowledgementRequest; import org.jboss.mq.ConnectionToken; -import org.jboss.mq.DurableSubcriptionID; +import org.jboss.mq.DurableSubscriptionID; import org.jboss.mq.GenericConnectionFactory; import org.jboss.mq.SpyDestination; import org.jboss.mq.SpyMessage; @@ -46,7 +46,7 @@ * Implements the ServerILJMXService which is used to manage the JVM IL. * * @authorHiram Chirino ([EMAIL PROTECTED]) - * @version $Revision: 1.17 $ + * @version $Revision: 1.18 $ */ public final class OILServerILService extends org.jboss.mq.il.ServerILJMXService @@ -266,7 +266,7 @@ break; case OILConstants.DESTROY_SUBSCRIPTION: - server.destroySubscription((DurableSubcriptionID)in.readObject()); + server.destroySubscription((DurableSubscriptionID)in.readObject()); break; case OILConstants.CHECK_USER: ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/il/rmi RMIServerIL.java
User: lqd Date: 02/02/01 20:02:23 Modified:src/main/org/jboss/mq/il/rmi RMIServerIL.java Log: Fix typo. this just ate 30mins of my time ... realizing a missing s in the class name ... argh! Revision ChangesPath 1.4 +3 -3 jbossmq/src/main/org/jboss/mq/il/rmi/RMIServerIL.java Index: RMIServerIL.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/il/rmi/RMIServerIL.java,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- RMIServerIL.java 2001/09/26 05:02:28 1.3 +++ RMIServerIL.java 2002/02/02 04:02:23 1.4 @@ -14,7 +14,7 @@ import javax.jms.Topic; import org.jboss.mq.AcknowledgementRequest; import org.jboss.mq.ConnectionToken; -import org.jboss.mq.DurableSubcriptionID; +import org.jboss.mq.DurableSubscriptionID; import org.jboss.mq.SpyDestination; import org.jboss.mq.SpyMessage; import org.jboss.mq.TransactionRequest; @@ -27,7 +27,7 @@ * * @authorHiram Chirino ([EMAIL PROTECTED]) * @authorNorbert Lataille ([EMAIL PROTECTED]) - * @version $Revision: 1.3 $ + * @version $Revision: 1.4 $ * @created August 16, 2001 */ public class RMIServerIL extends java.rmi.server.UnicastRemoteObject implements RMIServerILRemote @@ -261,7 +261,7 @@ * @param id Description of Parameter * @exception Exception Description of Exception */ - public void destroySubscription(DurableSubcriptionID id) + public void destroySubscription(DurableSubscriptionID id) throws Exception { server.destroySubscription(id); ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/il/uil UILServerIL.java UILServerILService.java
User: lqd Date: 02/02/01 20:02:23 Modified:src/main/org/jboss/mq/il/uil UILServerIL.java UILServerILService.java Log: Fix typo. this just ate 30mins of my time ... realizing a missing s in the class name ... argh! Revision ChangesPath 1.6 +3 -3 jbossmq/src/main/org/jboss/mq/il/uil/UILServerIL.java Index: UILServerIL.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/il/uil/UILServerIL.java,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- UILServerIL.java 2001/11/22 07:11:12 1.5 +++ UILServerIL.java 2002/02/02 04:02:23 1.6 @@ -23,7 +23,7 @@ import javax.jms.Topic; import org.jboss.mq.AcknowledgementRequest; import org.jboss.mq.ConnectionToken; -import org.jboss.mq.DurableSubcriptionID; +import org.jboss.mq.DurableSubscriptionID; import org.jboss.mq.SpyDestination; import org.jboss.mq.SpyMessage; import org.jboss.mq.TransactionRequest; @@ -37,7 +37,7 @@ * * @authorHiram Chirino ([EMAIL PROTECTED]) * @authorNorbert Lataille ([EMAIL PROTECTED]) - * @version $Revision: 1.5 $ + * @version $Revision: 1.6 $ * @created August 16, 2001 */ public class UILServerIL implements java.io.Serializable, Cloneable, org.jboss.mq.il.ServerIL @@ -369,7 +369,7 @@ * @exception JMSException Description of Exception * @exception Exception Description of Exception */ - public synchronized void destroySubscription(DurableSubcriptionID id) + public synchronized void destroySubscription(DurableSubscriptionID id) throws JMSException, Exception { checkConnection(); 1.16 +3 -3 jbossmq/src/main/org/jboss/mq/il/uil/UILServerILService.java Index: UILServerILService.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/il/uil/UILServerILService.java,v retrieving revision 1.15 retrieving revision 1.16 diff -u -r1.15 -r1.16 --- UILServerILService.java 2002/02/02 03:54:20 1.15 +++ UILServerILService.java 2002/02/02 04:02:23 1.16 @@ -29,7 +29,7 @@ import javax.naming.InitialContext; import org.jboss.mq.AcknowledgementRequest; import org.jboss.mq.ConnectionToken; -import org.jboss.mq.DurableSubcriptionID; +import org.jboss.mq.DurableSubscriptionID; import org.jboss.mq.GenericConnectionFactory; import org.jboss.mq.SpyDestination; @@ -46,7 +46,7 @@ * Implements the ServerILJMXService which is used to manage the JVM IL. * * @authorHiram Chirino ([EMAIL PROTECTED]) - * @version $Revision: 1.15 $ + * @version $Revision: 1.16 $ */ public class UILServerILService extends org.jboss.mq.il.ServerILJMXService implements Runnable, UILServerILServiceMBean { @@ -274,7 +274,7 @@ server.unsubscribe(connectionToken, in.readInt()); break; case m_destroySubscription: - server.destroySubscription((DurableSubcriptionID)in.readObject()); + server.destroySubscription((DurableSubscriptionID)in.readObject()); break; case m_checkUser: result = server.checkUser((String)in.readObject(), (String)in.readObject()); ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/server JMSServer.java JMSTopic.java StateManager.java TopicManager.java
User: lqd Date: 02/02/01 20:02:24 Modified:src/main/org/jboss/mq/server JMSServer.java JMSTopic.java StateManager.java TopicManager.java Log: Fix typo. this just ate 30mins of my time ... realizing a missing s in the class name ... argh! Revision ChangesPath 1.14 +3 -3 jbossmq/src/main/org/jboss/mq/server/JMSServer.java Index: JMSServer.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/server/JMSServer.java,v retrieving revision 1.13 retrieving revision 1.14 diff -u -r1.13 -r1.14 --- JMSServer.java2002/02/02 03:54:21 1.13 +++ JMSServer.java2002/02/02 04:02:24 1.14 @@ -26,7 +26,7 @@ import org.jboss.mq.AcknowledgementRequest; import org.jboss.mq.ConnectionToken; -import org.jboss.mq.DurableSubcriptionID; +import org.jboss.mq.DurableSubscriptionID; import org.jboss.mq.SpyDestination; import org.jboss.mq.SpyMessage; import org.jboss.mq.SpyQueue; @@ -48,7 +48,7 @@ * @authorNorbert Lataille ([EMAIL PROTECTED]) * @authorHiram Chirino ([EMAIL PROTECTED]) * @authorDavid Maplesden ([EMAIL PROTECTED]) - * @version $Revision: 1.13 $ + * @version $Revision: 1.14 $ */ public class JMSServer { @@ -647,7 +647,7 @@ * @param idDescription of Parameter * @exception JMSException Description of Exception */ - public void destroySubscription(DurableSubcriptionID id) throws JMSException + public void destroySubscription(DurableSubscriptionID id) throws JMSException { getStateManager().setDurableSubscription(this, id, null); } 1.10 +9 -9 jbossmq/src/main/org/jboss/mq/server/JMSTopic.java Index: JMSTopic.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/server/JMSTopic.java,v retrieving revision 1.9 retrieving revision 1.10 diff -u -r1.9 -r1.10 --- JMSTopic.java 2002/02/02 03:54:21 1.9 +++ JMSTopic.java 2002/02/02 04:02:24 1.10 @@ -18,7 +18,7 @@ import javax.jms.Destination; import javax.jms.JMSException; -import org.jboss.mq.DurableSubcriptionID; +import org.jboss.mq.DurableSubscriptionID; import org.jboss.mq.SpyDestination; import org.jboss.mq.SpyMessage; import org.jboss.mq.SpyTopic; @@ -32,7 +32,7 @@ * @author Hiram Chirino ([EMAIL PROTECTED]) * @author David Maplesden ([EMAIL PROTECTED]) * @createdAugust 16, 2001 - * @version$Revision: 1.9 $ + * @version$Revision: 1.10 $ */ public class JMSTopic extends JMSDestination { @@ -62,7 +62,7 @@ public void addSubscriber(Subscription sub) throws JMSException { SpyTopic topic = (SpyTopic) sub.destination; - DurableSubcriptionID id = topic.getDurableSubscriptionID(); + DurableSubscriptionID id = topic.getDurableSubscriptionID(); if (id == null) { BasicQueue q = new BasicQueue(server); synchronized (tempQueues) { @@ -84,7 +84,7 @@ public void removeSubscriber(Subscription sub) throws JMSException { BasicQueue queue = null; SpyTopic topic = (SpyTopic) sub.destination; - DurableSubcriptionID id = topic.getDurableSubscriptionID(); + DurableSubscriptionID id = topic.getDurableSubscriptionID(); if (id == null) { synchronized (tempQueues) { queue = (BasicQueue) tempQueues.get(sub); @@ -128,7 +128,7 @@ } } //called by state manager when a durable sub is created - public void createDurableSubscription(DurableSubcriptionID id) throws JMSException { + public void createDurableSubscription(DurableSubscriptionID id) throws JMSException { if (temporaryDestination != null) { throw new JMSException(Not a valid operation on a temporary topic); } @@ -143,7 +143,7 @@ } //called by state manager when a durable sub is deleted - public void destroyDurableSubscription(DurableSubcriptionID id) throws JMSException { + public void destroyDurableSubscription(DurableSubscriptionID id) throws JMSException { BasicQueue queue; synchronized (durQueues) { queue = (BasicQueue) durQueues.remove(id); @@ -173,7 +173,7 @@ synchronized (durQueues) { Iterator iter = durQueues.keySet().iterator(); while (iter.hasNext()) { - DurableSubcriptionID id = (DurableSubcriptionID) iter.next(); + DurableSubscriptionID id = (DurableSubscriptionID) iter.next(); PersistentQueue q = (PersistentQueue) durQueues.get(id); SpyMessage clone = message.myClone(); clone.header.durableSubscriberID = id; @@ -201,7 +201,7 @@ }
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/pm/file TxLog.java
User: lqd Date: 02/01/31 05:01:39 Removed: src/main/org/jboss/mq/pm/file Tag: Branch_2_4 TxLog.java Log: - this class is never used ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/server QueueManager.java
User: lqd Date: 02/01/31 05:14:42 Modified:src/main/org/jboss/mq/server Tag: Branch_2_4 QueueManager.java Log: - re-setup logger to use the Queue's name in logging output Revision ChangesPath No revision No revision 1.2.2.2 +43 -16jbossmq/src/main/org/jboss/mq/server/QueueManager.java Index: QueueManager.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/server/QueueManager.java,v retrieving revision 1.2.2.1 retrieving revision 1.2.2.2 diff -u -r1.2.2.1 -r1.2.2.2 --- QueueManager.java 2001/08/23 03:57:12 1.2.2.1 +++ QueueManager.java 2002/01/31 13:14:41 1.2.2.2 @@ -21,6 +21,7 @@ import org.jboss.mq.*; import org.jboss.util.ServiceMBeanSupport; +import org.jboss.logging.Logger; /** * This class is a message queue which is stored (hashed by Destination) on the @@ -29,36 +30,43 @@ * @author Norbert Lataille ([EMAIL PROTECTED]) * @author Hiram Chirino ([EMAIL PROTECTED]) * @createdAugust 16, 2001 - * @version$Revision: 1.2.2.1 $ + * @version$Revision: 1.2.2.2 $ */ -public class QueueManager extends org.jboss.util.ServiceMBeanSupport implements QueueManagerMBean { +public class QueueManager + extends org.jboss.util.ServiceMBeanSupport + implements QueueManagerMBean +{ JMSQueue destination; SpyQueue queue; String queueName; - public String getName() { + public String getName() + { return JBossMQQueue; } /** -* Insert the method's description here. Creation date: (7/1/2001 11:30:33 -* AM) +* Get the name of the Queue * * @returnjava.lang.String */ - public java.lang.String getQueueName() { + public java.lang.String getQueueName() + { return queueName; } public int getQueueDepth() - throws Exception { + throws Exception + { return destination.queue.messages.size(); } public void initService() - throws Exception { + throws Exception + { - if ( queueName == null || queueName.length() == 0 ) { + if ( queueName == null || queueName.length() == 0 ) + { throw new Exception( QueueName was not set ); } @@ -67,20 +75,30 @@ queue = new SpyQueue( queueName ); destination = new JMSQueue( queue, null, server ); - server.addDestination( queue, destination ); + try + { + server.addDestination( queue, destination ); + // server.getPersistenceManager().restoreQueue( destination, queue ); + } catch ( JMSException e ) + { + log.warn( Couldn't add queue: + e.getMessage() ); + } - } + } public void startService() - throws Exception { + throws Exception + { //Get an InitialContext InitialContext ctx = new InitialContext(); javax.naming.Context subctx; - try { + try + { subctx = ( javax.naming.Context )ctx.lookup( queue ); - } catch ( javax.naming.NamingException e ) { + } catch ( javax.naming.NamingException e ) + { subctx = ctx.createSubcontext( queue ); } subctx.rebind( queueName, queue ); @@ -88,11 +106,20 @@ } protected ObjectName getObjectName( MBeanServer server, ObjectName name ) - throws javax.management.MalformedObjectNameException { + throws javax.management.MalformedObjectNameException + { queueName = name.getKeyProperty( name ); - if ( queueName == null || queueName.length() == 0 ) { + if ( queueName == null || queueName.length() == 0 ) + { throw new MalformedObjectNameException( Property 'name' not provided ); } + + // re-setup the logger with a more descriptive name + log = Logger.getLogger(getClass().getName() + # + queueName); + return name; } } +/* +vim:tabstop=3:expandtab:shiftwidth=3 +*/ ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb/plugins AbstractInstanceCache.java
User: lqd Date: 02/01/17 09:39:35 Modified:src/main/org/jboss/ejb/plugins Tag: Branch_2_4 AbstractInstanceCache.java Log: fix for SF bug #504895: removeLockRef() is not called when release()-ing the bean Revision ChangesPath No revision No revision 1.10.2.7 +5 -1 jboss/src/main/org/jboss/ejb/plugins/AbstractInstanceCache.java Index: AbstractInstanceCache.java === RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/ejb/plugins/AbstractInstanceCache.java,v retrieving revision 1.10.2.6 retrieving revision 1.10.2.7 diff -u -r1.10.2.6 -r1.10.2.7 --- AbstractInstanceCache.java2001/12/03 21:47:55 1.10.2.6 +++ AbstractInstanceCache.java2002/01/17 17:39:35 1.10.2.7 @@ -64,7 +64,7 @@ * @author a href=[EMAIL PROTECTED]Marc Fleury/a * @author a href=[EMAIL PROTECTED]Scott Stark/a * - * @version $Revision: 1.10.2.6 $ + * @version $Revision: 1.10.2.7 $ * * pbRevisions:/b * @@ -287,6 +287,7 @@ if (getCache().peek(id) != null) { getCache().remove(id); +getContainer().getLockManager().removeLockRef(id); } // This call, executed anyway, leaves door open to multiple scheduling // of the same context, which I take care in other places, in @@ -890,3 +891,6 @@ return m_executed; } } +/* +vim:tabstop=3:expandtab:shiftwidth=3 +*/ ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] [Fwd: ScanMail Message: To Sender, sensitive content found andaction t aken.]
he, upon my last CVS commit (and the following e-mail by SF) I got the attached reply. who the fuck (!) are these clowns? sorry for the spam ;) christian ---BeginMessage--- Trend SMEX Content Filter has detected sensitive content. Place = [EMAIL PROTECTED]; ; Sender = Christian Riege Subject = [JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb/plugins AbstractInstanceCache.java Delivery Time = January 17, 2002 (Thursday) 11:43:13 Policy = Anti-Spam Action on this mail = Quarantine message Warning message from administrator: Anti-Spam filter has blocked a junk mail! ---End Message---
RE: [JBoss-dev] jbossmq message transport times
hi, On Wed, 2002-01-16 at 10:58, Sacha Labourey wrote: I guess that if you want to modify this, you need to make it optional. The TCPNODELAY flag is related to the Nagle's algorithm true. This algorithm is made to avoid sending very small paquets each time you send data through your socket [...] primarily useful for telnet/ssh style applications. I am not familiar with JBossMQ code base but if you think that the implementation could, at some time, send many small messages and would JBossMQ sends packets whenever a message needs to be delivered via the IL (except for the InVM layer but we can put that aside). suffer from sending each time a paquet, then you should most probably make this setting optional. But, on the opposite, if you think that your paquet (*all* paquets, even ACK) always have a sufficient size and don't want Nagle to take care of you, then it is up to you. ... don't forget the new pinger thread which tries to ping the server every once in a while to ensure its still up and running. bottom line: TCP_NODELAY should be set to *enabled* whenever you're in a low latency / high bandwidth situation, i.e. LAN or something similiar. I guess this applies to at the very least 80% of the JBossMQ installations out there. I would disable TCP_NODELAY only when being in a very low bandwidth / high latency situation. Loren, can you pls. submit a patch via SourceForge (or send it to this list) and we'll get this integrated into the codebase. Regarding Mac OS/X in this situation: it could very well be that their default mode of operation is to have TCP_NODELAY disabled by default, even when running on the loopback device -- you ARE using 127.0.0.1 after all, right?. On my Linux box this is a switch when configuring the kernel (at least it has been when I was still building my own kernels ... which hasn't happened since 2.0.something). Regards, Christian ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/pm/file TxLog.java
User: lqd Date: 02/01/14 04:29:58 Removed: src/main/org/jboss/mq/pm/file TxLog.java Log: this class is never used ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/pm/file MessageLog.java PersistenceManager.java
User: lqd Date: 02/01/14 04:30:45 Modified:src/main/org/jboss/mq/pm/file MessageLog.java PersistenceManager.java Log: - remove old code - use org.jboss.logging instead of System.out.println Revision ChangesPath 1.10 +88 -100 jbossmq/src/main/org/jboss/mq/pm/file/MessageLog.java Index: MessageLog.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/pm/file/MessageLog.java,v retrieving revision 1.9 retrieving revision 1.10 diff -u -r1.9 -r1.10 --- MessageLog.java 2001/11/30 18:43:15 1.9 +++ MessageLog.java 2002/01/14 12:30:45 1.10 @@ -23,39 +23,35 @@ import org.jboss.mq.server.MessageCache; import org.jboss.mq.server.MessageReference ; +import org.jboss.logging.Logger; + /** * This is used to keep SpyMessages on the disk and is used reconstruct the * queue in case of provider failure. * * @createdAugust 16, 2001 * @author:Paul Kendall ([EMAIL PROTECTED]) - * @version$Revision: 1.9 $ + * @version$Revision: 1.10 $ */ public class MessageLog { / // Attributes / - private File queueName; + private File queueName; private MessageCache messageCache; + private static Logger log = Logger.getLogger( MessageLog.class ); + / // Constants / - protected final static byte OBJECT_MESS = 3; - protected final static byte BYTES_MESS = 4; - protected final static byte MAP_MESS = 5; - protected final static byte TEXT_MESS = 6; - protected final static byte STREAM_MESS = 7; - protected final static byte ENCAP_MESS = 8; - protected final static byte SPY_MESS = 9; / // Constructor / public MessageLog(MessageCache messageCache, File file ) - { if (messageCache == null) { @@ -71,185 +67,173 @@ // Public Methods / public void close() - throws JMSException { + throws JMSException + { } - public Map restore( java.util.TreeSet rollBackTXs ) - throws JMSException { + throws JMSException + { //use sorted map to get queue order right. TreeMap messageIndex = new TreeMap(); - try { + try + { File[] files = queueName.listFiles(); - for ( int i = 0; i files.length; i++ ) { + for ( int i = 0; i files.length; i++ ) + { String fileName = files[i].getName(); int extIndex = fileName.indexOf( . ); -if ( extIndex 0 ) { +if ( extIndex 0 ) +{ //non transacted message so simply restore restoreMessageFromFile( messageIndex, files[i] ); -} else { +} else +{ //test if message from a transaction that is being rolled back. Long tx = new Long( Long.parseLong( fileName.substring( extIndex + 1 ) ) ); - if ( rollBackTXs.contains( tx ) ) { + if ( rollBackTXs.contains( tx ) ) + { delete( files[i] ); - } else { + } else + { restoreMessageFromFile( messageIndex, files[i] ); } } } - } catch ( Exception e ) { + } catch ( Exception e ) + { throwJMSException( Could not rebuild the queue from the queue's tranaction log., e ); } return messageIndex; - /* - MessageReference rc[] = new MessageReference[messageIndex.size()]; - java.util.Iterator iter = messageIndex.values().iterator(); - for ( int i = 0; iter.hasNext(); i++ ) { - rc[i] = ( MessageReference )iter.next(); - } - return rc; - */ } public void add( MessageReference messageRef, org.jboss.mq.pm.Tx transactionId ) - throws JMSException { - try { - SpyMessage message = messageRef.getMessage(); + throws JMSException + { + try + { + SpyMessage message = messageRef.getMessage(); File f; - if ( transactionId == null ) { + if ( transactionId == null ) + { f = new File( queueName,
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq SpyTextMessage.java
User: lqd Date: 02/01/14 07:25:36 Modified:src/main/org/jboss/mq Tag: Branch_2_4 SpyTextMessage.java Log: safeguard for TextMessages with a 'null' body Revision ChangesPath No revision No revision 1.2.2.7 +7 -1 jbossmq/src/main/org/jboss/mq/SpyTextMessage.java Index: SpyTextMessage.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/SpyTextMessage.java,v retrieving revision 1.2.2.6 retrieving revision 1.2.2.7 diff -u -r1.2.2.6 -r1.2.2.7 --- SpyTextMessage.java 2001/12/13 21:29:21 1.2.2.6 +++ SpyTextMessage.java 2002/01/14 15:25:35 1.2.2.7 @@ -16,7 +16,7 @@ * * @author Norbert Lataille ([EMAIL PROTECTED]) * @createdAugust 16, 2001 - * @version$Revision: 1.2.2.6 $ + * @version$Revision: 1.2.2.7 $ */ public class SpyTextMessage extends SpyMessage @@ -76,6 +76,9 @@ */ final public boolean isVersion2() { + if( content == null ) + return false; + // This is very conservative but cheap int length = content.length(); boolean canWriteUTF = length MAX_UTF_LENGTH; @@ -180,3 +183,6 @@ } } } +/* +vim:tabstop=3:expandtab:shiftwidth=3 +*/ ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] standard for obtaining an org.jboss.logging.Logger instance
hi, is there a standard way of getting the Logger instance in JBoss? the code is sprinkled with at least 4 different ways of doing so, i.e. sometimes its a private variable, sometimes its protected, sometimes its on a package level access, sometimes its declared as 'final', etc ... how about agreeing on a standard way; that would clean up some confusion. regards, christian ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq GenericConnectionFactory.java
User: lqd Date: 02/01/11 04:27:33 Modified:src/main/org/jboss/mq GenericConnectionFactory.java Log: - use org.jboss.logging.Logger instead of log4j - add debug level message when handing out a ClientIL - bump log level of can't connect to server from debug to error Revision ChangesPath 1.6 +10 -3 jbossmq/src/main/org/jboss/mq/GenericConnectionFactory.java Index: GenericConnectionFactory.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/GenericConnectionFactory.java,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- GenericConnectionFactory.java 2001/11/12 05:27:35 1.5 +++ GenericConnectionFactory.java 2002/01/11 12:27:32 1.6 @@ -14,15 +14,18 @@ import org.jboss.mq.il.ServerIL; import org.jboss.mq.il.ServerILFactory; +import org.jboss.logging.Logger; + /** * The RMI implementation of the DistributedConnectionFactory object * * @author Hiram Chirino ([EMAIL PROTECTED]) * @createdAugust 16, 2001 - * @version$Revision: 1.5 $ + * @version$Revision: 1.6 $ */ public class GenericConnectionFactory implements java.io.Serializable { - static org.apache.log4j.Category cat = org.apache.log4j.Category.getInstance( GenericConnectionFactory.class ); + + static Logger log = Logger.getLogger( GenericConnectionFactory.class ); // An instance of the ServerIL, once it is setup, we make clones every // time a new connection is needed. @@ -67,6 +70,10 @@ String clientILServiceCN = connectionProperties.getProperty( ServerILFactory.CLIENT_IL_SERVICE_KEY ); ClientILService service = ( ClientILService )Class.forName( clientILServiceCN ).newInstance(); service.init( connection, connectionProperties ); + + if ( log.isDebugEnabled() ) + log.debug(Handing out ClientIL: + clientILServiceCN); + return service; } @@ -96,7 +103,7 @@ // used to produce multiple connections. return server.cloneServerIL(); } catch ( Exception e ) { - cat.debug( Could not connect to the server, e ); + log.error( Could not connect to the server, e ); throw new SpyJMSException( Could not connect to the server, e ); } } ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq GenericConnectionFactory.java
User: lqd Date: 02/01/11 04:31:05 Modified:src/main/org/jboss/mq Tag: Branch_2_4 GenericConnectionFactory.java Log: Backport of HEAD changes to Branch_2_4: - use org.jboss.logging.Logger instead of log4j - add debug level message when handing out a ClientIL - bump log level of can't connect to server from debug to error Revision ChangesPath No revision No revision 1.2.2.3 +17 -10jbossmq/src/main/org/jboss/mq/GenericConnectionFactory.java Index: GenericConnectionFactory.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/GenericConnectionFactory.java,v retrieving revision 1.2.2.2 retrieving revision 1.2.2.3 diff -u -r1.2.2.2 -r1.2.2.3 --- GenericConnectionFactory.java 2001/11/28 06:15:27 1.2.2.2 +++ GenericConnectionFactory.java 2002/01/11 12:31:05 1.2.2.3 @@ -14,12 +14,14 @@ import org.jboss.mq.il.ServerIL; import org.jboss.mq.il.ServerILFactory; +import org.jboss.logging.Logger; + /** * The RMI implementation of the DistributedConnectionFactory object * * @author Hiram Chirino ([EMAIL PROTECTED]) * @createdAugust 16, 2001 - * @version$Revision: 1.2.2.2 $ + * @version$Revision: 1.2.2.3 $ */ public class GenericConnectionFactory implements java.io.Serializable { @@ -35,18 +37,19 @@ // These are the keys we look for in the connection properties public final static String SERVER_IL_FACTORY_KEY = ServerILFactory; public final static String CLIENT_IL_SERVICE_KEY = ClientILService; - - static org.apache.log4j.Category cat = org.apache.log4j.Category.getInstance( GenericConnectionFactory.class ); + static Logger log = Logger.getLogger( GenericConnectionFactory.class ); /** * The constructor takes a ServerIL and the Connection Properties -* parameters, The connection properties are allways required since they are -* used to setup the ClientIL, but the ServerIL can be null if the -* connection properties defines a ServerILFactory so that the SeverIL can -* be created on the client side. The ServerIL paramter is usefull for IL -* such as RMI or the JVM IL since trying to explicity create a connection -* to them is not strait forward. +* parameters, The connection properties are allways required since +* they are used to setup the ClientIL, but the ServerIL can be null +* if the connection properties defines a ServerILFactory so that +* the SeverIL can be created on the client side. +* p +* The ServerIL parameter is useful for ILs such as RMI or the JVM +* IL since trying to explicity create a connection to them is not +* straight forward. * * @param server Description of Parameter * @param props Description of Parameter @@ -68,6 +71,10 @@ String clientILServiceCN = connectionProperties.getProperty( CLIENT_IL_SERVICE_KEY ); ClientILService service = ( ClientILService )Class.forName( clientILServiceCN ).newInstance(); service.init( connection, connectionProperties ); + + if ( log.isDebugEnabled() ) + log.debug(Handing out ClientIL: + clientILServiceCN); + return service; } @@ -97,7 +104,7 @@ // used to produce multiple connections. return server.cloneServerIL(); } catch ( Exception e ) { - cat.debug( Could not connect to the server, e ); + log.error( Could not connect to the server, e ); throw new SpyJMSException( Could not connect to the server, e ); } } ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] org.jboss.logging.Logger
hi everybody, I'm slightly confused about the org.jboss.logging.Logger class. From my point of view this should be implemented as a singleton; however right now for every invocation of Logger.getLogger(...) it shells out a *new* instance of itself: public static Logger getLogger(String name) { Logger logger = new Logger(name); return logger; } Can anybody enlighten me on the reason behind this? It seems a bit expensive to me with little added value ... of course I understand that the underlying log4j Category object will be shared across all instances, but still. Best regards, Christian msg15798/pgp0.pgp Description: PGP signature
Re: [JBoss-dev] org.jboss.logging.Logger
Hi, On Fri, 2001-12-28 at 18:52, Scott M Stark wrote: Making this a singleton would require that all loggers used the same category name and this is not what we want. I'm still not getting it. In the constructor, we are getting a static log4j Category anyways for the given name: log = Category.getInstance(name); I don't see how different loggers should be able to use different category names with a constructor like this. Wading through the code via 'grep getCategory' doesn't show any use of this either; could you give me a pointer on where this behaviour is actually used/implemented? Best regards, Christian ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] org.jboss.logging.Logger
Hi, On Fri, 2001-12-28 at 18:52, Scott M Stark wrote: Making this a singleton would require that all loggers used the same category name and this is not what we want. I'm still not getting it. In the constructor, we are getting a static log4j Category anyways for the given name: log = Category.getInstance(name); replying to oneself makes you feel really stupid :). OK, I get it, Category.getInstance(name) returns a NEW Category when a Category for that name hasn't already been created. Forgot to read the fineprint in the log4j API docs. Doh. Regards, Christian msg15805/pgp0.pgp Description: PGP signature
[JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mq/pm/file MessageLog.java
User: lqd Date: 01/12/13 07:58:19 Modified:src/main/org/jboss/mq/pm/file Tag: Branch_2_4 MessageLog.java Log: Use SpyMessage.writeMessage() and SpyMessage.readMessage() methods to store / restore files written to disk. Revision ChangesPath No revision No revision 1.2.2.2 +10 -52jbossmq/src/main/org/jboss/mq/pm/file/MessageLog.java Index: MessageLog.java === RCS file: /cvsroot/jboss/jbossmq/src/main/org/jboss/mq/pm/file/MessageLog.java,v retrieving revision 1.2.2.1 retrieving revision 1.2.2.2 diff -u -r1.2.2.1 -r1.2.2.2 --- MessageLog.java 2001/08/23 03:57:11 1.2.2.1 +++ MessageLog.java 2001/12/13 15:58:18 1.2.2.2 @@ -5,6 +5,7 @@ * See terms of license at gnu.org. */ package org.jboss.mq.pm.file; + import java.io.File; import java.io.FileInputStream; import java.io.FileOutputStream; @@ -16,7 +17,8 @@ import javax.jms.JMSException; -import org.jboss.mq.*; +import org.jboss.mq.SpyMessage; +import org.jboss.mq.SpyJMSException; /** * This is used to keep SpyMessages on the disk and is used reconstruct the @@ -24,7 +26,7 @@ * * @createdAugust 16, 2001 * @author:Paul Kendall ([EMAIL PROTECTED]) - * @version$Revision: 1.2.2.1 $ + * @version$Revision: 1.2.2.2 $ */ public class MessageLog { @@ -36,13 +38,6 @@ / // Constants / - protected final static byte OBJECT_MESS = 3; - protected final static byte BYTES_MESS = 4; - protected final static byte MAP_MESS = 5; - protected final static byte TEXT_MESS = 6; - protected final static byte STREAM_MESS = 7; - protected final static byte ENCAP_MESS = 8; - protected final static byte SPY_MESS = 9; / // Constructor @@ -180,58 +175,21 @@ } protected void writeMessageToFile( SpyMessage message, File file ) - throws IOException { + throws IOException + { ObjectOutputStream out = new ObjectOutputStream( new FileOutputStream( file ) ); out.writeLong( message.messageId ); - if ( message instanceof SpyEncapsulatedMessage ) { - out.writeByte( ENCAP_MESS ); - } else if ( message instanceof SpyObjectMessage ) { - out.writeByte( OBJECT_MESS ); - } else if ( message instanceof SpyBytesMessage ) { - out.writeByte( BYTES_MESS ); - } else if ( message instanceof SpyMapMessage ) { - out.writeByte( MAP_MESS ); - } else if ( message instanceof SpyTextMessage ) { - out.writeByte( TEXT_MESS ); - } else if ( message instanceof SpyStreamMessage ) { - out.writeByte( STREAM_MESS ); - } else { - out.writeByte( SPY_MESS ); - } - message.writeExternal( out ); + SpyMessage.writeMessage( message, out ); out.flush(); out.close(); } protected void restoreMessageFromFile( java.util.TreeMap store, File file ) - throws Exception { + throws Exception + { ObjectInputStream in = new ObjectInputStream( new FileInputStream( file ) ); long msgId = in.readLong(); - SpyMessage message = null; - byte type = in.readByte(); - switch ( type ) { - case OBJECT_MESS: -message = new SpyObjectMessage(); -break; - case BYTES_MESS: -message = new SpyBytesMessage(); -break; - case MAP_MESS: -message = new SpyMapMessage(); -break; - case STREAM_MESS: -message = new SpyStreamMessage(); -break; - case TEXT_MESS: -message = new SpyTextMessage(); -break; - case ENCAP_MESS: -message = new SpyEncapsulatedMessage(); -break; - default: -message = new SpyMessage(); - } - message.readExternal( in ); + SpyMessage message = SpyMessage.readMessage( in ); in.close(); message.messageId = msgId; message.persistData = file; ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jboss/src/lib jbossmq.jar
User: lqd Date: 01/12/12 02:27:32 Modified:src/lib Tag: Branch_2_4 jbossmq.jar Log: sync w/ JBossMQ b/c of SF Bug #491613 Revision ChangesPath No revision No revision 1.8.4.10 +398 -399 jboss/src/lib/Attic/jbossmq.jar Binary file ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jboss/src/client jbossmq-client.jar
User: lqd Date: 01/12/12 02:27:32 Modified:src/client Tag: Branch_2_4 jbossmq-client.jar Log: sync w/ JBossMQ b/c of SF Bug #491613 Revision ChangesPath No revision No revision 1.6.4.9 +305 -309 jboss/src/client/Attic/jbossmq-client.jar Binary file ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jboss/src/lib jbossmq.jar
User: lqd Date: 01/12/12 07:20:13 Modified:src/lib Tag: Branch_2_4 jbossmq.jar Log: copy due to bug in new SpyTextMessage.java Revision ChangesPath No revision No revision 1.8.4.11 +261 -262 jboss/src/lib/Attic/jbossmq.jar Binary file ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jboss/src/client jbossmq-client.jar
User: lqd Date: 01/12/12 07:20:14 Modified:src/client Tag: Branch_2_4 jbossmq-client.jar Log: copy due to bug in new SpyTextMessage.java Revision ChangesPath No revision No revision 1.6.4.10 +189 -190 jboss/src/client/Attic/jbossmq-client.jar Binary file ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
RE: [JBoss-dev] JBoss 3.0 Demo App
hi, On Wed, 2001-12-05 at 18:57, Ean Schuessler wrote: I have modifications for Postgres DAO support if anyone else finds Postgres support useful. +1 christian p.s.: nice e-mail address :) msg14140/pgp0.pgp Description: PGP signature
Re: [JBoss-dev] [ jboss-Bugs-463210 ] remove fails when usingcommit-option C
hi, [relating to bug 463210 which is submitted]: http://sourceforge.net/tracker/?func=detailatid=376685aid=463210group_id=22866 Category: JBossCMP Group: v2.4 (stable) [...] Initial Comment: i've just discovered a very odd bug: when using commit-option C for my CMP-based entity beans, the SQL DELETE command that gets sent to the Database has the PK set to NULL: i've just attached a small test-case to this on sourceforge and i've also narrowed it down a bit: its not in direct relation to the PK being set to NULL on commit-option C, it rather seems that the last field that is defined as being a CMP-field is set to NULL (which incidentally in my first test was the PK b/c the table only had one attribute. i've now added a value attribute besides the PK and now the value gets set to NULL ... strange indeed). you will see this when running the test-case and looking at the debug-output from JAWS. hope this helps, christian -- Riege Software International GmbH Phone: +49 (2159) 91 48 - 0 Mollsfeld 10 Fax : +49 (2159) 91 48 - 11 40670 Meerbusch, Germany http://www.riege.com/ ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] MDB non-xa cf tx timeout
hi jason, On Wed, 2001-09-19 at 21:10, Jason Dillon wrote: Just a note, but it looks like there is still a problem with MDB tx timeouts with a non-xa connection factory. I mentioned this problem a while ago, then the world fell apart, then my computers freaked out and then I got ill. Now, I have recomved from 2 of the 3 and am looking into this problem some more. I am currently using a 2.5 snapshot, so I might move over to 2.4.x. It does have the new locking and jbossmq stuff right? Anyways, I think there is still an issue with the tx recipts for an MDB. I have to set the default tx timeout insainly high to avoid this problem. we've been experiencing something similar here, strange TX timeouts when using Entity Beans from a MDB (actually the MDB calls a SLSB which does some stuff which involves ~10 EB's). the TX times out after just ~5 seconds despite the fact that the timeout is set to 200 or somethng like that ... we're trying to nail down the problem and see if we can get a minimal test case for reproducing this by tomorrow. on the other hand, a first look actually suggests that the problem is when an Entity Bean throws a CreateException and calls setRollBackOnly() ... with 2.4.0 the SLSB was able to catch() the CreateException; with 2.4.1 the CreateException never gets through to the SLSB. this only started to happen when we switched over to 2.4.1 (which does have the new locking and JBossMQ in place); 2.4.0 does not show this behaviour. hope to have more precise data available by tomorrow. stay tuned, christian ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] CVS update: jbossmq/src/main/org/jboss/mqSpyTextMessage.java
hi, On Mon, 2001-09-17 at 23:09, David Maplesden wrote: User: dmaplesden Date: 01/09/17 14:09:46 Modified:src/main/org/jboss/mq SpyTextMessage.java Log: Apply submitted patch for working around write/read utf limitation in jdk 1.3.* Revision ChangesPath 1.3 +39 -4 jbossmq/src/main/org/jboss/mq/SpyTextMessage.java could you also apply this to the 2.4 branch of JBossMQ? Best regards, Christian ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] report on Branch_2_4 MQ stability/performance
hi everybody, just to let you know: the backport of JBossMQ 1.0.0beta to the 2.4 JBoss branch works really well. i've pumped about 250MB (its 500 messages of roughly 500k each initially, these get split up internally into about 8 messages of about 1k-10k size each) of data through it w/ no artificial throttling of messages on my side (which I had to do before so as not to make it lock up) and its happily churning away. The speed improvement is also tremendous from previous versions using OIL invocation layer. absolutely *marvelous* work. jboss kicks some serious ass now. i remember jason dillon also using JBossMQ quite heavily, have you used the new stuff yet? if so, i would like to get your experiences with it. i will let the new stuff work over the weekend on our backup system and if its still running on monday i will switch my production machine over to Branch_2_4. best regards, christian ___ Jboss-development mailing list [EMAIL PROTECTED] http://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] MDB has stopped working
hi, On 13 Aug 2001 09:39:26 +0200, Peter Antman wrote: It seems as if MDB has stopped working with the latest jbossmq. I build with a clean checkout of jboss-all today and have run both the mdbtest and tested jms-hello-topic and jms-hello-queue from the new JMS chapter examples: MDB:s deployes OK, it is OK to send to MDB, but the MDB will not receive any thing send to it after is has been deployed. It will however raise an exception when undeploying because there seemd to be stuff waiting i'm experiencing the same things; my guess is that this is related to the changes that Paul did on Friday (remove the PooledExecutor stuff from JBossMQ). Somehow this broke the MDB implementation. On the good side of things, JBossMQ is a lot more stable for me now :). Best regards, Christian ___ Jboss-development mailing list [EMAIL PROTECTED] http://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] jbossmq PooledExecutor
hi hiram, On 12 Aug 2001 18:19:39 -0400, Hiram Chirino wrote: Well, seems like Paul Kendal's las set of changes made away with the pooled executor.. I've heard some positive feed back on the change (the MQ is alot faster now). I wish I could get a hold of a good test case that locks up MQ.. Can anybody send me that test case?? please find attached jmstest.zip which locks up JBossMQ 2.4 for me and works just fine for 2.5 as of Friday Aug 10th. Haven't tried current CVS HEAD b/c of org.jbossmq = org.jboss.mq porting and I will not have the time to look at it until Wednesday; I am at a client this afternoon and the whole day tomorrow. There's a README file in the .zip which [tries :] to explain the setup a bit; I hope that I didn't forget anything :). The load-test actually resembles my application requirements: an MDB receives a message which (potentially) contains 'n' messages (n can be anything up to 20); thus the msg. needs to be split into 20 new messages which will then be consumed by 2 MDB's (depending on type of wrapped message). Hope this helps, Christian jmstest.zip
Re: [JBoss-dev] jbossmq PooledExecutor
hi, On 10 Aug 2001 12:56:42 -0700, Jason Dillon wrote: Are you running off of jars built from jbossmq or are you using the version that is integrated into jboss? i'm running off the .jar files built from the jbossmq CVS module. the integrated version (2.5 and 2.4) still locks up under load for me (w/ CVS as of Friday, Aug 10th). christian ___ Jboss-development mailing list [EMAIL PROTECTED] http://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] JBoss pool (former Minerva) transaction bug?
hi, On Thu, May 31, 2001 at 12:05:10PM +1200, Toby Allsopp wrote: The JTA spec is all I have to go on. It refers to the X/Open XA spec, but that's not free. Free as in free beer or free speech? If it's free beer I would be willing to donate the spec to the JBoss project (well, depends on price, but ...). Any resources on the web of where I could acquire the X/Open XA Spec? Best regards, Christian -- Riege Software International GmbH Phone: +49 (2159) 91 48 - 0 Mollsfeld 10 Fax : +49 (2159) 91 48 - 11 40670 Meerbusch, Germany http://www.riege.com/ ___ Jboss-development mailing list [EMAIL PROTECTED] http://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] Replacing JBossMQ
hi, On 23 May 2001 10:46:31 -0700, Jason Dillon wrote: I do not believe that SonicMQ supports the optional JMS ASF api, nor XA transactions, which will make implementing MDB very difficult. You might want to use the bridge to a JBossMQ provider for your beans instead. OK, that would be a workable solution for the time being. I was actually thinking along the same lines (i.e. using the JMS Bridge product) but thought that replacing JBossMQ altogether would be a cleaner approach (one less system to take care of/administrate). Thanks a lot for the clarification on this issue, it *is* actually documented in the MDB section of the JBoss manual (under Advanced MDB Configuration) but that section was a bit confusing for me. Probably your statement above should be included in the manual in a 20pt font in red :). Best regards, Christian -- Riege Software International GmbH Phone: +49 (2159) 91 48 - 0 Mollsfeld 10 Fax : +49 (2159) 91 48 - 11 40670 Meerbusch, Germany http://www.riege.com/ ___ Jboss-development mailing list [EMAIL PROTECTED] http://lists.sourceforge.net/lists/listinfo/jboss-development