[JBoss-dev] [ jboss-Bugs-960488 ] jca 1.5 config properties broken
Bugs item #960488, was opened at 2004-05-26 00:03
Message generated for change (Comment added) made by ejort
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=376685&aid=960488&group_id=22866
Category: JBossCX
Group: CVS HEAD
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: cory (charp3r)
Assigned to: Adrian Brock (ejort)
Summary: jca 1.5 config properties broken
Initial Comment:
Config properties don't work for ResouceAdapter and
ActivationSpec.
ActivationSpecFactory.java:
bad logic in for loops checking for required properties
lines 47-58
setAsText(null) should be setAsText(value) line 81
ResourceAdapterFactory.java
setAsText(null) should be setAsText(value) line 76
MessageDrivenMetaData.java
getChildrenByTagName(element ... should be
getChildrenByTagName(activationConfig ... line 352
--
>Comment By: Adrian Brock (ejort)
Date: 2004-05-26 15:48
Message:
Logged In: YES
user_id=9459
You wouldn't have to suggest the hack if I could code :-)
--
Comment By: cory (charp3r)
Date: 2004-05-26 15:42
Message:
Logged In: YES
user_id=1049868
yep, that works, sorry for suggesting such a hack :-)
--
Comment By: Adrian Brock (ejort)
Date: 2004-05-26 15:24
Message:
Logged In: YES
user_id=9459
Try this (I don't like spagetthi code):
// Check we have all the required properties
for (Iterator i =
mlmd.getRequiredConfigProperties().iterator(); i.hasNext();)
{
RequiredConfigPropertyMetaData rcpmd =
(RequiredConfigPropertyMetaData) i.next();
boolean found = false;
for (Iterator j = activationConfig.iterator();
j.hasNext();)
{
ActivationConfigPropertyMetaData acpmd =
(ActivationConfigPropertyMetaData) j.next();
if (rcpmd.getName().equals(acpmd.getName()))
{
found = true;
break;
}
}
if (found == false)
throw new DeploymentException("Required config
property " + rcpmd + " for messagingType '" + messagingType +
"' not found in activation config " +
activationConfig + " ra=" + rarName);
}
--
Comment By: cory (charp3r)
Date: 2004-05-26 15:13
Message:
Logged In: YES
user_id=1049868
oops, missed loop logic bug in ActivationSpecFactory.java line
46
I hacked in a "next :" label on the outer for loop. and instead
of "break" a "continue next". Also the inner for loop should be
doing a j.hasNext() instead of i.hasNext().
// Check we have all the required properties
next : for (Iterator i = mlmd.getRequiredConfigProperties
().iterator(); i.hasNext();)
{
RequiredConfigPropertyMetaData rcpmd =
(RequiredConfigPropertyMetaData) i.next();
for (Iterator j = activationConfig.iterator(); j.hasNext
();)
{
ActivationConfigPropertyMetaData acpmd =
(ActivationConfigPropertyMetaData) j.next();
if (rcpmd.getName().equals(acpmd.getName()))
continue next;
}
throw new DeploymentException("Required config
property " + rcpmd + " for messagingType '" + messagingType
+
"' not found in activation config " +
activationConfig + " ra=" + rarName);
}
--
Comment By: Adrian Brock (ejort)
Date: 2004-05-26 01:55
Message:
Logged In: YES
user_id=9459
Thanks. It is a good job somebody is awake :-)
--
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=376685&aid=960488&group_id=22866
---
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g.
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
___
JBoss-Development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] [ jboss-Bugs-960488 ] jca 1.5 config properties broken
Bugs item #960488, was opened at 2004-05-26 00:03
Message generated for change (Comment added) made by charp3r
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=376685&aid=960488&group_id=22866
Category: JBossCX
Group: CVS HEAD
Status: Open
Resolution: Accepted
Priority: 5
Submitted By: cory (charp3r)
Assigned to: Adrian Brock (ejort)
Summary: jca 1.5 config properties broken
Initial Comment:
Config properties don't work for ResouceAdapter and
ActivationSpec.
ActivationSpecFactory.java:
bad logic in for loops checking for required properties
lines 47-58
setAsText(null) should be setAsText(value) line 81
ResourceAdapterFactory.java
setAsText(null) should be setAsText(value) line 76
MessageDrivenMetaData.java
getChildrenByTagName(element ... should be
getChildrenByTagName(activationConfig ... line 352
--
>Comment By: cory (charp3r)
Date: 2004-05-26 15:42
Message:
Logged In: YES
user_id=1049868
yep, that works, sorry for suggesting such a hack :-)
--
Comment By: Adrian Brock (ejort)
Date: 2004-05-26 15:24
Message:
Logged In: YES
user_id=9459
Try this (I don't like spagetthi code):
// Check we have all the required properties
for (Iterator i =
mlmd.getRequiredConfigProperties().iterator(); i.hasNext();)
{
RequiredConfigPropertyMetaData rcpmd =
(RequiredConfigPropertyMetaData) i.next();
boolean found = false;
for (Iterator j = activationConfig.iterator();
j.hasNext();)
{
ActivationConfigPropertyMetaData acpmd =
(ActivationConfigPropertyMetaData) j.next();
if (rcpmd.getName().equals(acpmd.getName()))
{
found = true;
break;
}
}
if (found == false)
throw new DeploymentException("Required config
property " + rcpmd + " for messagingType '" + messagingType +
"' not found in activation config " +
activationConfig + " ra=" + rarName);
}
--
Comment By: cory (charp3r)
Date: 2004-05-26 15:13
Message:
Logged In: YES
user_id=1049868
oops, missed loop logic bug in ActivationSpecFactory.java line
46
I hacked in a "next :" label on the outer for loop. and instead
of "break" a "continue next". Also the inner for loop should be
doing a j.hasNext() instead of i.hasNext().
// Check we have all the required properties
next : for (Iterator i = mlmd.getRequiredConfigProperties
().iterator(); i.hasNext();)
{
RequiredConfigPropertyMetaData rcpmd =
(RequiredConfigPropertyMetaData) i.next();
for (Iterator j = activationConfig.iterator(); j.hasNext
();)
{
ActivationConfigPropertyMetaData acpmd =
(ActivationConfigPropertyMetaData) j.next();
if (rcpmd.getName().equals(acpmd.getName()))
continue next;
}
throw new DeploymentException("Required config
property " + rcpmd + " for messagingType '" + messagingType
+
"' not found in activation config " +
activationConfig + " ra=" + rarName);
}
--
Comment By: Adrian Brock (ejort)
Date: 2004-05-26 01:55
Message:
Logged In: YES
user_id=9459
Thanks. It is a good job somebody is awake :-)
--
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=376685&aid=960488&group_id=22866
---
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g.
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
___
JBoss-Development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] [ jboss-Bugs-960488 ] jca 1.5 config properties broken
Bugs item #960488, was opened at 2004-05-26 00:03
Message generated for change (Comment added) made by ejort
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=376685&aid=960488&group_id=22866
Category: JBossCX
Group: CVS HEAD
Status: Open
>Resolution: Accepted
Priority: 5
Submitted By: cory (charp3r)
Assigned to: Adrian Brock (ejort)
Summary: jca 1.5 config properties broken
Initial Comment:
Config properties don't work for ResouceAdapter and
ActivationSpec.
ActivationSpecFactory.java:
bad logic in for loops checking for required properties
lines 47-58
setAsText(null) should be setAsText(value) line 81
ResourceAdapterFactory.java
setAsText(null) should be setAsText(value) line 76
MessageDrivenMetaData.java
getChildrenByTagName(element ... should be
getChildrenByTagName(activationConfig ... line 352
--
>Comment By: Adrian Brock (ejort)
Date: 2004-05-26 15:24
Message:
Logged In: YES
user_id=9459
Try this (I don't like spagetthi code):
// Check we have all the required properties
for (Iterator i =
mlmd.getRequiredConfigProperties().iterator(); i.hasNext();)
{
RequiredConfigPropertyMetaData rcpmd =
(RequiredConfigPropertyMetaData) i.next();
boolean found = false;
for (Iterator j = activationConfig.iterator();
j.hasNext();)
{
ActivationConfigPropertyMetaData acpmd =
(ActivationConfigPropertyMetaData) j.next();
if (rcpmd.getName().equals(acpmd.getName()))
{
found = true;
break;
}
}
if (found == false)
throw new DeploymentException("Required config
property " + rcpmd + " for messagingType '" + messagingType +
"' not found in activation config " +
activationConfig + " ra=" + rarName);
}
--
Comment By: cory (charp3r)
Date: 2004-05-26 15:13
Message:
Logged In: YES
user_id=1049868
oops, missed loop logic bug in ActivationSpecFactory.java line
46
I hacked in a "next :" label on the outer for loop. and instead
of "break" a "continue next". Also the inner for loop should be
doing a j.hasNext() instead of i.hasNext().
// Check we have all the required properties
next : for (Iterator i = mlmd.getRequiredConfigProperties
().iterator(); i.hasNext();)
{
RequiredConfigPropertyMetaData rcpmd =
(RequiredConfigPropertyMetaData) i.next();
for (Iterator j = activationConfig.iterator(); j.hasNext
();)
{
ActivationConfigPropertyMetaData acpmd =
(ActivationConfigPropertyMetaData) j.next();
if (rcpmd.getName().equals(acpmd.getName()))
continue next;
}
throw new DeploymentException("Required config
property " + rcpmd + " for messagingType '" + messagingType
+
"' not found in activation config " +
activationConfig + " ra=" + rarName);
}
--
Comment By: Adrian Brock (ejort)
Date: 2004-05-26 01:55
Message:
Logged In: YES
user_id=9459
Thanks. It is a good job somebody is awake :-)
--
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=376685&aid=960488&group_id=22866
---
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g.
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
___
JBoss-Development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] [ jboss-Bugs-960488 ] jca 1.5 config properties broken
Bugs item #960488, was opened at 2004-05-26 00:03
Message generated for change (Comment added) made by charp3r
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=376685&aid=960488&group_id=22866
Category: JBossCX
Group: CVS HEAD
>Status: Open
Resolution: Fixed
Priority: 5
Submitted By: cory (charp3r)
Assigned to: Adrian Brock (ejort)
Summary: jca 1.5 config properties broken
Initial Comment:
Config properties don't work for ResouceAdapter and
ActivationSpec.
ActivationSpecFactory.java:
bad logic in for loops checking for required properties
lines 47-58
setAsText(null) should be setAsText(value) line 81
ResourceAdapterFactory.java
setAsText(null) should be setAsText(value) line 76
MessageDrivenMetaData.java
getChildrenByTagName(element ... should be
getChildrenByTagName(activationConfig ... line 352
--
>Comment By: cory (charp3r)
Date: 2004-05-26 15:13
Message:
Logged In: YES
user_id=1049868
oops, missed loop logic bug in ActivationSpecFactory.java line
46
I hacked in a "next :" label on the outer for loop. and instead
of "break" a "continue next". Also the inner for loop should be
doing a j.hasNext() instead of i.hasNext().
// Check we have all the required properties
next : for (Iterator i = mlmd.getRequiredConfigProperties
().iterator(); i.hasNext();)
{
RequiredConfigPropertyMetaData rcpmd =
(RequiredConfigPropertyMetaData) i.next();
for (Iterator j = activationConfig.iterator(); j.hasNext
();)
{
ActivationConfigPropertyMetaData acpmd =
(ActivationConfigPropertyMetaData) j.next();
if (rcpmd.getName().equals(acpmd.getName()))
continue next;
}
throw new DeploymentException("Required config
property " + rcpmd + " for messagingType '" + messagingType
+
"' not found in activation config " +
activationConfig + " ra=" + rarName);
}
--
Comment By: Adrian Brock (ejort)
Date: 2004-05-26 01:55
Message:
Logged In: YES
user_id=9459
Thanks. It is a good job somebody is awake :-)
--
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=376685&aid=960488&group_id=22866
---
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g.
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
___
JBoss-Development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] [ jboss-Bugs-960488 ] jca 1.5 config properties broken
Bugs item #960488, was opened at 2004-05-26 00:03 Message generated for change (Comment added) made by ejort You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=376685&aid=960488&group_id=22866 >Category: JBossCX Group: CVS HEAD >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: cory (charp3r) >Assigned to: Adrian Brock (ejort) Summary: jca 1.5 config properties broken Initial Comment: Config properties don't work for ResouceAdapter and ActivationSpec. ActivationSpecFactory.java: bad logic in for loops checking for required properties lines 47-58 setAsText(null) should be setAsText(value) line 81 ResourceAdapterFactory.java setAsText(null) should be setAsText(value) line 76 MessageDrivenMetaData.java getChildrenByTagName(element ... should be getChildrenByTagName(activationConfig ... line 352 -- >Comment By: Adrian Brock (ejort) Date: 2004-05-26 01:55 Message: Logged In: YES user_id=9459 Thanks. It is a good job somebody is awake :-) -- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=376685&aid=960488&group_id=22866 --- This SF.Net email is sponsored by: Oracle 10g Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE. http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click ___ JBoss-Development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] [ jboss-Bugs-960488 ] jca 1.5 config properties broken
Bugs item #960488, was opened at 2004-05-26 00:03 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=376685&aid=960488&group_id=22866 Category: JBossMX Group: CVS HEAD Status: Open Resolution: None Priority: 5 Submitted By: cory (charp3r) Assigned to: Nobody/Anonymous (nobody) Summary: jca 1.5 config properties broken Initial Comment: Config properties don't work for ResouceAdapter and ActivationSpec. ActivationSpecFactory.java: bad logic in for loops checking for required properties lines 47-58 setAsText(null) should be setAsText(value) line 81 ResourceAdapterFactory.java setAsText(null) should be setAsText(value) line 76 MessageDrivenMetaData.java getChildrenByTagName(element ... should be getChildrenByTagName(activationConfig ... line 352 -- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=376685&aid=960488&group_id=22866 --- This SF.Net email is sponsored by: Oracle 10g Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE. http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click ___ JBoss-Development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
