[JBoss-dev] [JBoss JIRA] Commented: (JBAS-1579) Need to cleanup the serialVersionUIDs for Serializable/Externalizable classes
[ http://jira.jboss.com/jira/browse/JBAS-1579?page=comments#action_12316641 ] Scott M Stark commented on JBAS-1579: - The serialVersionUIDs have been set and I tried running several sets of unit tests from the 4.0.1sp1 build against the current 4.0 branch. The cts, jbossmq, jmx, security tests run fine. The webservice tests have two failures. The first is due to a change in the javax.xml.namespace.QName from 8217399441836960859 to the 4418622981026545151 value found in jdk5: [junit] Tests run: 5, Failures: 0, Errors: 1, Time elapsed: 6.359 sec Cannot unmarshall service ref meta data, cause: java.io.InvalidClassException: javax.xml.namespace.QName; local class incompatible: stream classdesc serialVersionUID = 4418622981026545151, local class serialVersionUID = 8217399441836960859 type=javax.naming.NamingExceptionjavax.naming.NamingException: Cannot unmarshall service ref meta data, cause: java.io.InvalidClassException: javax.xml.namespace.QName; local class incompatible: stream classdesc serialVersionUID = 4418622981026545151, local class serialVersionUID = 8217399441836960859 at org.jboss.webservice.client.ServiceObjectFactory.getObjectInstance(ServiceObjectFactory.java:114) at javax.naming.spi.NamingManager.getObjectInstance(NamingManager.java:301) at org.jnp.interfaces.NamingContext.lookup(NamingContext.java:636) at org.jboss.naming.client.java.javaURLContextFactory$EncContextProxy.invoke(javaURLContextFactory.java:120) at $Proxy1.lookup(Unknown Source) at javax.naming.InitialContext.lookup(InitialContext.java:347) at org.jboss.test.webservice.header.HeaderEndpointTestCase.testImplicitHeaderEndpoint(HeaderEndpointTestCase.java:70) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22) at junit.extensions.TestSetup$1.protect(TestSetup.java:19) at junit.extensions.TestSetup.run(TestSetup.java:23) The SerialVersion.LEGACY approach could be added support interop with the older id. The second is failure is a lookup failure. [junit] Test org.jboss.test.webservice.header.HeaderEndpointTestCase FAILED [junit] Running org.jboss.test.webservice.marshalltest.MarshallDocLiteralTestCase [junit] Tests run: 32, Failures: 0, Errors: 32, Time elapsed: 8.844 sec javax.naming.NamingException: Could not dereference object [Root exception is java.lang.RuntimeException: Cannot access wsdl from [http://localhost:8080/ws4ee-marshall-doclit?wsdl], http://localhost:8080/ws4ee-marshall-doclit?wsdl] at org.jnp.interfaces.NamingContext.lookup(NamingContext.java:647) at org.jboss.naming.client.java.javaURLContextFactory$EncContextProxy.invoke(javaURLContextFactory.java:120) at $Proxy1.lookup(Unknown Source) at javax.naming.InitialContext.lookup(InitialContext.java:347) at org.jboss.test.webservice.marshalltest.MarshallDocLiteralTestCase.setUp(MarshallDocLiteralTestCase.java:72) at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22) at junit.extensions.TestSetup$1.protect(TestSetup.java:19) at junit.extensions.TestSetup.run(TestSetup.java:23) Caused by: java.lang.RuntimeException: Cannot access wsdl from [http://localhost:8080/ws4ee-marshall-doclit?wsdl], http://localhost:8080/ws4ee-marshall-doclit?wsdl at org.jboss.webservice.WSDLDefinitionFactory$WSDLLocatorImpl.getBaseInputSource(WSDLDefinitionFactory.java:103) at com.ibm.wsdl.xml.WSDLReaderImpl.readWSDL(Unknown Source) at org.jboss.webservice.WSDLDefinitionFactory.parse(WSDLDefinitionFactory.java:71) at org.jboss.webservice.metadata.ServiceRefMetaData.getWsdlDefinition(ServiceRefMetaData.java:180) at org.jboss.webservice.client.ServiceObjectFactory.getObjectInstance(ServiceObjectFactory.java:145) at javax.naming.spi.NamingManager.getObjectInstance(NamingManager.java:301) at org.jnp.interfaces.NamingContext.lookup(NamingContext.java:636) ... 20 more Need to cleanup the serialVersionUIDs for Serializable/Externalizable classes - Key: JBAS-1579 URL: http://jira.jboss.com/jira/browse/JBAS-1579 Project: JBoss Application Server Type: Bug Versions: JBossAS-4.0.2RC1, JBossAS-4.0.1 SP1 Reporter: Scott M Stark Assignee: Scott M Stark Priority: Blocker Fix For: JBossAS-4.0.2 Final Attachments: SerializableHasSerialVersionUIDField.zip, TestResultSample.zip, compatibilityCheckProposedSourceCde.zip I'm seeing incomptibilities between versions that are simply due to
[JBoss-dev] [JBoss JIRA] Commented: (JBAS-1579) Need to cleanup the serialVersionUIDs for Serializable/Externalizable classes
[ http://jira.jboss.com/jira/browse/JBAS-1579?page=comments#action_12316469 ] Scott M Stark commented on JBAS-1579: - The requirement is to have a serialVersionUID defined in every Serializable/Externalizable class. Its value should be fixed to the 4.0.1 version if possible. The javax.* classes should match the j2ee 1.4 reference implementation class serialVersionUID values. Need to cleanup the serialVersionUIDs for Serializable/Externalizable classes - Key: JBAS-1579 URL: http://jira.jboss.com/jira/browse/JBAS-1579 Project: JBoss Application Server Type: Bug Versions: JBossAS-4.0.2RC1, JBossAS-4.0.1 SP1 Reporter: Scott M Stark Assignee: Clebert Suconic Priority: Blocker Fix For: JBossAS-4.0.2 Final Attachments: SerializableHasSerialVersionUIDField.zip, TestResultSample.zip, compatibilityCheckProposedSourceCde.zip I'm seeing incomptibilities between versions that are simply due to the fact that Serializable/Externalizable classes are letting their serialVersionUIDs float instead of explicitly defining them. We need to get this cleaned up. There should not be a single Serializable/Externalizable class that does not fix its serialVersionUID and then take responsibility for maintaining compatibility with the indicated version. The attached SerializableHasSerialVersionUIDField.zip unzips to create a SerializableHasSerialVersionUIDField-index.html and SerializableHasSerialVersionUIDField directory which is a report of all classes in the 4.0 codebase that are not defining a serialVersionUID as they should. The JDK object serialization spec defines all you need to know about the apis and contracts for object serialization: http://java.sun.com/j2se/1.4.2/docs/guide/serialization/spec/serialTOC.html In particular, Versioning of Serializable Objects: http://java.sun.com/j2se/1.4.2/docs/guide/serialization/spec/version.html#wp9419 talks about binary compatibility and what is available to manage this. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ JBoss-Development mailing list JBoss-Development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] [JBoss JIRA] Commented: (JBAS-1579) Need to cleanup the serialVersionUIDs for Serializable/Externalizable classes
[ http://jira.jboss.com/jira/browse/JBAS-1579?page=comments#action_12316432 ] Bela Ban commented on JBAS-1579: Fixed all classes in org.jboss.cache package Need to cleanup the serialVersionUIDs for Serializable/Externalizable classes - Key: JBAS-1579 URL: http://jira.jboss.com/jira/browse/JBAS-1579 Project: JBoss Application Server Type: Bug Versions: JBossAS-4.0.2RC1, JBossAS-4.0.1 SP1 Reporter: Scott M Stark Assignee: Clebert Suconic Priority: Blocker Fix For: JBossAS-4.0.2 Final Attachments: SerializableHasSerialVersionUIDField.zip, TestResultSample.zip, compatibilityCheckProposedSourceCde.zip I'm seeing incomptibilities between versions that are simply due to the fact that Serializable/Externalizable classes are letting their serialVersionUIDs float instead of explicitly defining them. We need to get this cleaned up. There should not be a single Serializable/Externalizable class that does not fix its serialVersionUID and then take responsibility for maintaining compatibility with the indicated version. The attached SerializableHasSerialVersionUIDField.zip unzips to create a SerializableHasSerialVersionUIDField-index.html and SerializableHasSerialVersionUIDField directory which is a report of all classes in the 4.0 codebase that are not defining a serialVersionUID as they should. The JDK object serialization spec defines all you need to know about the apis and contracts for object serialization: http://java.sun.com/j2se/1.4.2/docs/guide/serialization/spec/serialTOC.html In particular, Versioning of Serializable Objects: http://java.sun.com/j2se/1.4.2/docs/guide/serialization/spec/version.html#wp9419 talks about binary compatibility and what is available to manage this. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ JBoss-Development mailing list JBoss-Development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] [JBoss JIRA] Commented: (JBAS-1579) Need to cleanup the serialVersionUIDs for Serializable/Externalizable classes
[ http://jira.jboss.com/jira/browse/JBAS-1579?page=comments#action_12316433 ] Clebert Suconic commented on JBAS-1579: --- I thought the requirement for this would be to have serialUID defined in every single class. By using that method SerialUID will be calculated and I understood that we want to have them all defined. So...what's the requirement? - To have serialUID declared in every class? or - To have serialUID always compatible with previous versions? (in such a way that doesn't matter if it came defined or calculated) Need to cleanup the serialVersionUIDs for Serializable/Externalizable classes - Key: JBAS-1579 URL: http://jira.jboss.com/jira/browse/JBAS-1579 Project: JBoss Application Server Type: Bug Versions: JBossAS-4.0.2RC1, JBossAS-4.0.1 SP1 Reporter: Scott M Stark Assignee: Clebert Suconic Priority: Blocker Fix For: JBossAS-4.0.2 Final Attachments: SerializableHasSerialVersionUIDField.zip, TestResultSample.zip, compatibilityCheckProposedSourceCde.zip I'm seeing incomptibilities between versions that are simply due to the fact that Serializable/Externalizable classes are letting their serialVersionUIDs float instead of explicitly defining them. We need to get this cleaned up. There should not be a single Serializable/Externalizable class that does not fix its serialVersionUID and then take responsibility for maintaining compatibility with the indicated version. The attached SerializableHasSerialVersionUIDField.zip unzips to create a SerializableHasSerialVersionUIDField-index.html and SerializableHasSerialVersionUIDField directory which is a report of all classes in the 4.0 codebase that are not defining a serialVersionUID as they should. The JDK object serialization spec defines all you need to know about the apis and contracts for object serialization: http://java.sun.com/j2se/1.4.2/docs/guide/serialization/spec/serialTOC.html In particular, Versioning of Serializable Objects: http://java.sun.com/j2se/1.4.2/docs/guide/serialization/spec/version.html#wp9419 talks about binary compatibility and what is available to manage this. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ JBoss-Development mailing list JBoss-Development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] [JBoss JIRA] Commented: (JBAS-1579) Need to cleanup the serialVersionUIDs for Serializable/Externalizable classes
[ http://jira.jboss.com/jira/browse/JBAS-1579?page=comments#action_12316401 ] Scott M Stark commented on JBAS-1579: - The diffs in terms of obtaining the serialVersionUID should be encapsulated in the java.io.ObjectStreamClass.getSerialVersionUID used by the org.jboss.tools.SerialVersionUID utility class so there is no need to reproduce this behavior. We should be using the exact same algorithm as the vm so that the serialVersionUID can be calculated by tools such as serialver of the jdk. In terms the comparison of the jbossall-client.jar vs the classes in /lib and /server/all as calculated by the SerialVersionUID there are two problems. 1. The size of the serialVersionUID databases are more than 10x larger. For example, the 4.0.1 jbossall-client.jar vs the testsuite/src/etc/serialVersionUID/401.ser is: 342882 401.ser 4148296 jbossall-client.jar If this is going to be part of the intrinsic testsuite archiving the jbossall-client.jar is too much. 2. All server classes need to be validated for serialVersionUID changes. There are many paths that do not involve clients which still serialize objects that need validation. I would just merge your test result into the existing SerialVersionUIDUnitTestCase. Need to cleanup the serialVersionUIDs for Serializable/Externalizable classes - Key: JBAS-1579 URL: http://jira.jboss.com/jira/browse/JBAS-1579 Project: JBoss Application Server Type: Bug Versions: JBossAS-4.0.2RC1, JBossAS-4.0.1 SP1 Reporter: Scott M Stark Assignee: Clebert Suconic Priority: Blocker Fix For: JBossAS-4.0.2 Final Attachments: SerializableHasSerialVersionUIDField.zip, TestResultSample.zip, compatibilityCheckProposedSourceCde.zip I'm seeing incomptibilities between versions that are simply due to the fact that Serializable/Externalizable classes are letting their serialVersionUIDs float instead of explicitly defining them. We need to get this cleaned up. There should not be a single Serializable/Externalizable class that does not fix its serialVersionUID and then take responsibility for maintaining compatibility with the indicated version. The attached SerializableHasSerialVersionUIDField.zip unzips to create a SerializableHasSerialVersionUIDField-index.html and SerializableHasSerialVersionUIDField directory which is a report of all classes in the 4.0 codebase that are not defining a serialVersionUID as they should. The JDK object serialization spec defines all you need to know about the apis and contracts for object serialization: http://java.sun.com/j2se/1.4.2/docs/guide/serialization/spec/serialTOC.html In particular, Versioning of Serializable Objects: http://java.sun.com/j2se/1.4.2/docs/guide/serialization/spec/version.html#wp9419 talks about binary compatibility and what is available to manage this. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ JBoss-Development mailing list JBoss-Development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] [JBoss JIRA] Commented: (JBAS-1579) Need to cleanup the serialVersionUIDs for Serializable/Externalizable classes
[ http://jira.jboss.com/jira/browse/JBAS-1579?page=comments#action_12316391 ] Scott M Stark commented on JBAS-1579: - There already is a org.jboss.test.compatibility.test.SerialVersionUIDUnitTestCase so how does this new testcase compare? Need to cleanup the serialVersionUIDs for Serializable/Externalizable classes - Key: JBAS-1579 URL: http://jira.jboss.com/jira/browse/JBAS-1579 Project: JBoss Application Server Type: Bug Versions: JBossAS-4.0.2RC1, JBossAS-4.0.1 SP1 Reporter: Scott M Stark Assignee: Clebert Suconic Priority: Blocker Fix For: JBossAS-4.0.2 Final Attachments: SerializableHasSerialVersionUIDField.zip, TestResultSample.zip I'm seeing incomptibilities between versions that are simply due to the fact that Serializable/Externalizable classes are letting their serialVersionUIDs float instead of explicitly defining them. We need to get this cleaned up. There should not be a single Serializable/Externalizable class that does not fix its serialVersionUID and then take responsibility for maintaining compatibility with the indicated version. The attached SerializableHasSerialVersionUIDField.zip unzips to create a SerializableHasSerialVersionUIDField-index.html and SerializableHasSerialVersionUIDField directory which is a report of all classes in the 4.0 codebase that are not defining a serialVersionUID as they should. The JDK object serialization spec defines all you need to know about the apis and contracts for object serialization: http://java.sun.com/j2se/1.4.2/docs/guide/serialization/spec/serialTOC.html In particular, Versioning of Serializable Objects: http://java.sun.com/j2se/1.4.2/docs/guide/serialization/spec/version.html#wp9419 talks about binary compatibility and what is available to manage this. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira --- This SF.net email is sponsored by Microsoft Mobile Embedded DevCon 2005 Attend MEDC 2005 May 9-12 in Vegas. Learn more about the latest Windows Embedded(r) Windows Mobile(tm) platforms, applications content. Register by 3/29 save $300 http://ads.osdn.com/?ad_id=6883alloc_id=15149op=click ___ JBoss-Development mailing list JBoss-Development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] [JBoss JIRA] Commented: (JBAS-1579) Need to cleanup the serialVersionUIDs for Serializable/Externalizable classes
[ http://jira.jboss.com/jira/browse/JBAS-1579?page=comments#action_12316392 ] Clebert Suconic commented on JBAS-1579: --- I didn't know there is another testcase doing something to serialUIDs. When I saw JBAS-1598 I understood I needed to verify serialUIDs. Well... let's talk about the differences. First difference: I'm checking if every class into a given JAR has implemented serialUID. I'm doing that by getField/introspection. As it's a private field, I'm changing the property in the same way ObjectOutputStream does: Field field = parameterClass.getDeclaredField(serialVersionUID); field.setAccessible(true); Second difference: If you add older versions in a configured directory (through a property in the system... good option for cruisecontrol), I will check if all the older versions also have serialUID defined. Them I'm checking if both are the same. Third difference: If I have a default constructor, I'm serializing the Object using the older versions in the configured directory. I deserialize in the current version using ObjectInputStreamWithClassLoader. Forth difference: You will see every class tested as a TestResult. Fancy feature only I'm attaching the sourcecode, as I will commit it after validated. Need to cleanup the serialVersionUIDs for Serializable/Externalizable classes - Key: JBAS-1579 URL: http://jira.jboss.com/jira/browse/JBAS-1579 Project: JBoss Application Server Type: Bug Versions: JBossAS-4.0.2RC1, JBossAS-4.0.1 SP1 Reporter: Scott M Stark Assignee: Clebert Suconic Priority: Blocker Fix For: JBossAS-4.0.2 Final Attachments: SerializableHasSerialVersionUIDField.zip, TestResultSample.zip I'm seeing incomptibilities between versions that are simply due to the fact that Serializable/Externalizable classes are letting their serialVersionUIDs float instead of explicitly defining them. We need to get this cleaned up. There should not be a single Serializable/Externalizable class that does not fix its serialVersionUID and then take responsibility for maintaining compatibility with the indicated version. The attached SerializableHasSerialVersionUIDField.zip unzips to create a SerializableHasSerialVersionUIDField-index.html and SerializableHasSerialVersionUIDField directory which is a report of all classes in the 4.0 codebase that are not defining a serialVersionUID as they should. The JDK object serialization spec defines all you need to know about the apis and contracts for object serialization: http://java.sun.com/j2se/1.4.2/docs/guide/serialization/spec/serialTOC.html In particular, Versioning of Serializable Objects: http://java.sun.com/j2se/1.4.2/docs/guide/serialization/spec/version.html#wp9419 talks about binary compatibility and what is available to manage this. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira --- This SF.net email is sponsored by Microsoft Mobile Embedded DevCon 2005 Attend MEDC 2005 May 9-12 in Vegas. Learn more about the latest Windows Embedded(r) Windows Mobile(tm) platforms, applications content. Register by 3/29 save $300 http://ads.osdn.com/?ad_id=6883alloc_id=15149op=click ___ JBoss-Development mailing list JBoss-Development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] [JBoss JIRA] Commented: (JBAS-1579) Need to cleanup the serialVersionUIDs for Serializable/Externalizable classes
[ http://jira.jboss.com/jira/browse/JBAS-1579?page=comments#action_12316393 ] Clebert Suconic commented on JBAS-1579: --- If this test is relevant/aprooved I will put it under org.jboss.test.compatibility.test Need to cleanup the serialVersionUIDs for Serializable/Externalizable classes - Key: JBAS-1579 URL: http://jira.jboss.com/jira/browse/JBAS-1579 Project: JBoss Application Server Type: Bug Versions: JBossAS-4.0.2RC1, JBossAS-4.0.1 SP1 Reporter: Scott M Stark Assignee: Clebert Suconic Priority: Blocker Fix For: JBossAS-4.0.2 Final Attachments: SerializableHasSerialVersionUIDField.zip, TestResultSample.zip, compatibilityCheckProposedSourceCde.zip I'm seeing incomptibilities between versions that are simply due to the fact that Serializable/Externalizable classes are letting their serialVersionUIDs float instead of explicitly defining them. We need to get this cleaned up. There should not be a single Serializable/Externalizable class that does not fix its serialVersionUID and then take responsibility for maintaining compatibility with the indicated version. The attached SerializableHasSerialVersionUIDField.zip unzips to create a SerializableHasSerialVersionUIDField-index.html and SerializableHasSerialVersionUIDField directory which is a report of all classes in the 4.0 codebase that are not defining a serialVersionUID as they should. The JDK object serialization spec defines all you need to know about the apis and contracts for object serialization: http://java.sun.com/j2se/1.4.2/docs/guide/serialization/spec/serialTOC.html In particular, Versioning of Serializable Objects: http://java.sun.com/j2se/1.4.2/docs/guide/serialization/spec/version.html#wp9419 talks about binary compatibility and what is available to manage this. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira --- This SF.net email is sponsored by Microsoft Mobile Embedded DevCon 2005 Attend MEDC 2005 May 9-12 in Vegas. Learn more about the latest Windows Embedded(r) Windows Mobile(tm) platforms, applications content. Register by 3/29 save $300 http://ads.osdn.com/?ad_id=6883alloc_id=15149op=click ___ JBoss-Development mailing list JBoss-Development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] [JBoss JIRA] Commented: (JBAS-1579) Need to cleanup the serialVersionUIDs for Serializable/Externalizable classes
[ http://jira.jboss.com/jira/browse/JBAS-1579?page=comments#action_12316258 ] Dimitris Andreadis commented on JBAS-1579: -- I've fixed a couple of classes: org.jboss.deployment.DeploymentState org.jboss.deployment.SerializedDeploymentInfo org.jboss.system.ServiceContext org.jboss.jmx.adaptor.snmp.agent.ManagerRecord org.jboss.management.j2ee.statistics.* org.jboss.services.deployment.metadata.* The following shouldn't probably be serializable: org.jboss.management.j2ee.J2EEManagedObject org.jboss.metadata.EjbPortComponentMetadata org.jboss.metadata.IorSecurityConfigMetadata I presume the castor stuff is gone, too. Need to cleanup the serialVersionUIDs for Serializable/Externalizable classes - Key: JBAS-1579 URL: http://jira.jboss.com/jira/browse/JBAS-1579 Project: JBoss Application Server Type: Bug Versions: JBossAS-4.0.2RC1, JBossAS-4.0.1 SP1 Reporter: Scott M Stark Priority: Blocker Fix For: JBossAS-4.0.2 Final Attachments: SerializableHasSerialVersionUIDField.zip I'm seeing incomptibilities between versions that are simply due to the fact that Serializable/Externalizable classes are letting their serialVersionUIDs float instead of explicitly defining them. We need to get this cleaned up. There should not be a single Serializable/Externalizable class that does not fix its serialVersionUID and then take responsibility for maintaining compatibility with the indicated version. The attached SerializableHasSerialVersionUIDField.zip unzips to create a SerializableHasSerialVersionUIDField-index.html and SerializableHasSerialVersionUIDField directory which is a report of all classes in the 4.0 codebase that are not defining a serialVersionUID as they should. The JDK object serialization spec defines all you need to know about the apis and contracts for object serialization: http://java.sun.com/j2se/1.4.2/docs/guide/serialization/spec/serialTOC.html In particular, Versioning of Serializable Objects: http://java.sun.com/j2se/1.4.2/docs/guide/serialization/spec/version.html#wp9419 talks about binary compatibility and what is available to manage this. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ JBoss-Development mailing list JBoss-Development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] [JBoss JIRA] Commented: (JBAS-1579) Need to cleanup the serialVersionUIDs for Serializable/Externalizable classes
[ http://jira.jboss.com/jira/browse/JBAS-1579?page=comments#action_12316260 ] Scott M Stark commented on JBAS-1579: - Agreed that the org.jboss.management.j2ee.J2EEManagedObject should not be Serializable. All of the org.jboss.metadata.* really should be JavaBean compatible and Serializable. What is your concern about the EjbPortComponentMetadata and IorSecurityConfigMetadata classes? Need to cleanup the serialVersionUIDs for Serializable/Externalizable classes - Key: JBAS-1579 URL: http://jira.jboss.com/jira/browse/JBAS-1579 Project: JBoss Application Server Type: Bug Versions: JBossAS-4.0.2RC1, JBossAS-4.0.1 SP1 Reporter: Scott M Stark Priority: Blocker Fix For: JBossAS-4.0.2 Final Attachments: SerializableHasSerialVersionUIDField.zip I'm seeing incomptibilities between versions that are simply due to the fact that Serializable/Externalizable classes are letting their serialVersionUIDs float instead of explicitly defining them. We need to get this cleaned up. There should not be a single Serializable/Externalizable class that does not fix its serialVersionUID and then take responsibility for maintaining compatibility with the indicated version. The attached SerializableHasSerialVersionUIDField.zip unzips to create a SerializableHasSerialVersionUIDField-index.html and SerializableHasSerialVersionUIDField directory which is a report of all classes in the 4.0 codebase that are not defining a serialVersionUID as they should. The JDK object serialization spec defines all you need to know about the apis and contracts for object serialization: http://java.sun.com/j2se/1.4.2/docs/guide/serialization/spec/serialTOC.html In particular, Versioning of Serializable Objects: http://java.sun.com/j2se/1.4.2/docs/guide/serialization/spec/version.html#wp9419 talks about binary compatibility and what is available to manage this. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ JBoss-Development mailing list JBoss-Development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] [JBoss JIRA] Commented: (JBAS-1579) Need to cleanup the serialVersionUIDs for Serializable/Externalizable classes
[ http://jira.jboss.com/jira/browse/JBAS-1579?page=comments#action_12316182 ] Scott M Stark commented on JBAS-1579: - Here is a preliminary example of the types of changes I'm seeing. This is a diff between the current 4.0 branch and the 4.0.1 release. This is across all jars in the lib and server/all directories so thirdparty changes are also reflected. WARNING: serialVersionUID error for javax.management.modelmbean.DescriptorSupport$FieldName, 401: 2645619836053638810, current: -6292969195866300415WARNING: serialVersionUID error for javax.security.jacc.EJBMethodPermission, 401: -2677271975280050210, current: 141000WARNING: serialVersionUID error for javax.security.jacc.EJBRoleRefPermission, 401: -4374811682927746472, current: 141000WARNING: serialVersionUID error for javax.xml.namespace.QName, 401: 8217399441836960859, current: 4418622981026545151WARNING: serialVersionUID error for org.apache.axis.AxisEngine, 401: 783705919602087477, current: -6536560628462902930 WARNING: serialVersionUID error for org.apache.axis.AxisFault, 401: 7656291048487769618, current: 1821054234255058350 WARNING: serialVersionUID error for org.apache.axis.ConfigurationException, 401: -2031305405698866120, current: 3128145386557654796 WARNING: serialVersionUID error for org.apache.axis.FaultableHandler, 401: -1318575215335790977, current: -9888308697472666 WARNING: serialVersionUID error for org.apache.axis.InternalException, 401: -7837575501867271417, current: -2439038787028853642 WARNING: serialVersionUID error for org.apache.axis.Message, 401: -673079399072703001, current: -3797053663591575461 WARNING: serialVersionUID error for org.apache.axis.SimpleTargetedChain, 401: 4326784208937906611, current: 6081663876761825537 WARNING: serialVersionUID error for org.apache.axis.attachments.AttachmentsImpl, 401: -3635216569769100668, current: 6592081539679813264 WARNING: serialVersionUID error for org.apache.axis.client.AxisClient, 401: 8628363337655480796, current: 917328696653918636 WARNING: serialVersionUID error for org.apache.axis.client.Service, 401: -3104162953909360111, current: -5518418527298163671 WARNING: serialVersionUID error for org.apache.axis.deployment.wsdd.WSDDDeployableItem, 401: -3260006150211853091, current: -2293858078946363728 WARNING: serialVersionUID error for org.apache.axis.deployment.wsdd.WSDDDeployment, 401: -8079485375776187246, current: -4445495595412038453 WARNING: serialVersionUID error for org.apache.axis.deployment.wsdd.WSDDDocumentation, 401: 3150861050769407999, current: 3995390874236084737 WARNING: serialVersionUID error for org.apache.axis.deployment.wsdd.WSDDElement, 401: 3563586045048588795, current: -592921944454858369 WARNING: serialVersionUID error for org.apache.axis.deployment.wsdd.WSDDGlobalConfiguration, 401: 8096089502610845101, current: -432056797726163452 WARNING: serialVersionUID error for org.apache.axis.deployment.wsdd.WSDDService, 401: -3778233437705831680, current: 7898527740946309006 WARNING: serialVersionUID error for org.apache.axis.description.ParameterDesc, 401: 8514989580706837763, current: 5531650781024519497 WARNING: serialVersionUID error for org.apache.axis.encoding.DeserializerImpl, 401: 3611196368372543212, current: -378592058256066308 WARNING: serialVersionUID error for org.apache.axis.encoding.ser.ArrayDeserializer, 401: 268734140916921026, current: -2333663097459692847 WARNING: serialVersionUID error for org.apache.axis.encoding.ser.ArraySerializer, 401: 7851885505904114045, current: -295100666141518 WARNING: serialVersionUID error for org.apache.axis.encoding.ser.ArraySerializerFactory, 401: 5237560634678155448, current: -440164809313455300 WARNING: serialVersionUID error for org.apache.axis.encoding.ser.Base64Deserializer, 401: 7330763014108753158, current: 6851029229010507274 WARNING: serialVersionUID error for org.apache.axis.encoding.ser.BaseDeserializerFactory, 401: 8950949792689718127, current: -5984246614308993424 WARNING: serialVersionUID error for org.apache.axis.encoding.ser.BaseSerializerFactory, 401: 5578716727285237604, current: -9059108483290118954 WARNING: serialVersionUID error for org.apache.axis.encoding.ser.BeanDeserializer, 401: -1133032377918216855, current: 3852320955478399407 WARNING: serialVersionUID error for org.apache.axis.encoding.ser.BeanDeserializerFactory, 401: 6820538762993201693, current: 9006429762992702423 WARNING: serialVersionUID error for org.apache.axis.encoding.ser.BeanSerializer, 401: 9019938287273362475, current: -7009951737671158500 WARNING: serialVersionUID error for org.apache.axis.encoding.ser.CalendarSerializer, 401: -6302463588379174538, current: 2751762093676757560 WARNING: serialVersionUID error for org.apache.axis.encoding.ser.DateDeserializer, 401: 6145205136706780990, current: 4103689753889895911 WARNING: serialVersionUID error for org.apache.axis.encoding.ser.DateSerializer, 401: 1738433042297509590,
