Re: [JBoss-dev] BasicMBeanRegistry and class loader MBeans
Hi, I've renamed add/removeClassLoader to add/removeCL for external management of the repository. The MBeanServer uses add/removeClassLoader which ignore requests on UnifiedClassLoaders. I fixed the handling of URLClassLoaders, although this approach won't support package private access across URLs in the same URLClassLoader. I've also added some guards where a URL is mistakenly registered twice. Previously, the CL was removed when the first of the duplicates was removed. I'll look at copying the jmx loading tests into the main testsuite. Regards, Adrian From: Scott M Stark [EMAIL PROTECTED] Reply-To: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Re: [JBoss-dev] BasicMBeanRegistry and class loader MBeans Date: Sat, 10 Aug 2002 12:22:25 -0700 Look at fixing it in head as there the BasicMBeanRegistry has been restored, but the default has been changed to JBossMBeanRegistry. The design of our JMX implementation class loading layer has to be geared toward JBoss functionality and requirements. Accommodating whatever is required by the JMX spec is necessary, but if one or the other requires a non-trivial configuration, it is the JMX spec behavior that should incur this burden, not the default JBoss behavior. Scott Stark Chief Technology Officer JBoss Group, LLC - Original Message - From: Adrian Brock [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Saturday, August 10, 2002 11:44 AM Subject: Re: [JBoss-dev] BasicMBeanRegistry and class loader MBeans Hi Scott, This is the specs/RIs mechanism for maintaining the LoaderRepository, although it is only implicitly mentioned in the javadoc for the DefaultLoaderRepository: Keeps the list of Class Loaders registered in the MBean Server. It provides the necessary methods to load classes using the registered Class Loaders. The unified repositories are externally managed and hierarchical, so this behaviour is conflicting. I see you have already removed this code. This probably breaks the MLet processing. But then I think it was already broken, MLets are URLClassLoaders not UCLs. I'll take a look at fixing this without breaking bug #592346 Regards, Adrian From: Scott M Stark [EMAIL PROTECTED] Reply-To: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [JBoss-dev] BasicMBeanRegistry and class loader MBeans Date: Fri, 9 Aug 2002 12:11:41 -0700 When one registers an MBean that is a ClassLoader the BasicMBeanRegistry adds it to the the default LoaderRepository. This breaks scoped class loading of services, and it really seems to be out of the scope of functionality that the BasicMBeanRegistry should assume. Really I don't see why the BasicMBeanRegistry should have any interaction with the LoaderRepository as all it is doing is adding and removing class loaders. --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development _ Chat with friends online, try MSN Messenger: http://messenger.msn.com --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
RE: [JBoss-dev] BasicMBeanRegistry and class loader MBeans
I agree we are beyond the spec here. Queue Marc's dance :-) Going boldly where no spec writer has gone, look like you are running stupidly one arm up (left) right leg up behind you, look at the sky with a stupid smile... wwwh! you are running! tada! going beyond the spec, marcf --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] BasicMBeanRegistry and class loader MBeans
Hi Scott, This is the specs/RIs mechanism for maintaining the LoaderRepository, although it is only implicitly mentioned in the javadoc for the DefaultLoaderRepository: Keeps the list of Class Loaders registered in the MBean Server. It provides the necessary methods to load classes using the registered Class Loaders. The unified repositories are externally managed and hierarchical, so this behaviour is conflicting. I see you have already removed this code. This probably breaks the MLet processing. But then I think it was already broken, MLets are URLClassLoaders not UCLs. I'll take a look at fixing this without breaking bug #592346 Regards, Adrian From: Scott M Stark [EMAIL PROTECTED] Reply-To: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [JBoss-dev] BasicMBeanRegistry and class loader MBeans Date: Fri, 9 Aug 2002 12:11:41 -0700 When one registers an MBean that is a ClassLoader the BasicMBeanRegistry adds it to the the default LoaderRepository. This breaks scoped class loading of services, and it really seems to be out of the scope of functionality that the BasicMBeanRegistry should assume. Really I don't see why the BasicMBeanRegistry should have any interaction with the LoaderRepository as all it is doing is adding and removing class loaders. Scott Stark Chief Technology Officer JBoss Group, LLC --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development _ MSN Photos is the easiest way to share and print your photos: http://photos.msn.com/support/worldwide.aspx --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] BasicMBeanRegistry and class loader MBeans
Look at fixing it in head as there the BasicMBeanRegistry has been restored, but the default has been changed to JBossMBeanRegistry. The design of our JMX implementation class loading layer has to be geared toward JBoss functionality and requirements. Accommodating whatever is required by the JMX spec is necessary, but if one or the other requires a non-trivial configuration, it is the JMX spec behavior that should incur this burden, not the default JBoss behavior. Scott Stark Chief Technology Officer JBoss Group, LLC - Original Message - From: Adrian Brock [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Saturday, August 10, 2002 11:44 AM Subject: Re: [JBoss-dev] BasicMBeanRegistry and class loader MBeans Hi Scott, This is the specs/RIs mechanism for maintaining the LoaderRepository, although it is only implicitly mentioned in the javadoc for the DefaultLoaderRepository: Keeps the list of Class Loaders registered in the MBean Server. It provides the necessary methods to load classes using the registered Class Loaders. The unified repositories are externally managed and hierarchical, so this behaviour is conflicting. I see you have already removed this code. This probably breaks the MLet processing. But then I think it was already broken, MLets are URLClassLoaders not UCLs. I'll take a look at fixing this without breaking bug #592346 Regards, Adrian From: Scott M Stark [EMAIL PROTECTED] Reply-To: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [JBoss-dev] BasicMBeanRegistry and class loader MBeans Date: Fri, 9 Aug 2002 12:11:41 -0700 When one registers an MBean that is a ClassLoader the BasicMBeanRegistry adds it to the the default LoaderRepository. This breaks scoped class loading of services, and it really seems to be out of the scope of functionality that the BasicMBeanRegistry should assume. Really I don't see why the BasicMBeanRegistry should have any interaction with the LoaderRepository as all it is doing is adding and removing class loaders. --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] BasicMBeanRegistry and class loader MBeans
On Sat, 10 Aug 2002, Scott M Stark wrote: This probably breaks the MLet processing. But then I think it was already broken, MLets are URLClassLoaders not UCLs. actually we detect ULR in the mlet code and register one UCL per URL in case ULR is used... -- Juha --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] BasicMBeanRegistry and class loader MBeans
I agree we are beyond the spec here. Queue Marc's dance :-) I think we should still support MLets. I need to figure out a mechanism for registering URLClassLoaders in a Unified repository, probably some form of delegation. The rest is easy. We reserve add/removeClassLoader() for use by the MBeanServer/registry which noops for a UnifiedClassLoader. Then use add/removeUnifiedClassLoader() for the external management. Regards, Adrian From: Scott M Stark [EMAIL PROTECTED] Reply-To: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Re: [JBoss-dev] BasicMBeanRegistry and class loader MBeans Date: Sat, 10 Aug 2002 12:22:25 -0700 Look at fixing it in head as there the BasicMBeanRegistry has been restored, but the default has been changed to JBossMBeanRegistry. The design of our JMX implementation class loading layer has to be geared toward JBoss functionality and requirements. Accommodating whatever is required by the JMX spec is necessary, but if one or the other requires a non-trivial configuration, it is the JMX spec behavior that should incur this burden, not the default JBoss behavior. Scott Stark Chief Technology Officer JBoss Group, LLC - Original Message - From: Adrian Brock [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Saturday, August 10, 2002 11:44 AM Subject: Re: [JBoss-dev] BasicMBeanRegistry and class loader MBeans Hi Scott, This is the specs/RIs mechanism for maintaining the LoaderRepository, although it is only implicitly mentioned in the javadoc for the DefaultLoaderRepository: Keeps the list of Class Loaders registered in the MBean Server. It provides the necessary methods to load classes using the registered Class Loaders. The unified repositories are externally managed and hierarchical, so this behaviour is conflicting. I see you have already removed this code. This probably breaks the MLet processing. But then I think it was already broken, MLets are URLClassLoaders not UCLs. I'll take a look at fixing this without breaking bug #592346 Regards, Adrian From: Scott M Stark [EMAIL PROTECTED] Reply-To: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [JBoss-dev] BasicMBeanRegistry and class loader MBeans Date: Fri, 9 Aug 2002 12:11:41 -0700 When one registers an MBean that is a ClassLoader the BasicMBeanRegistry adds it to the the default LoaderRepository. This breaks scoped class loading of services, and it really seems to be out of the scope of functionality that the BasicMBeanRegistry should assume. Really I don't see why the BasicMBeanRegistry should have any interaction with the LoaderRepository as all it is doing is adding and removing class loaders. --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development _ Join the worlds largest e-mail service with MSN Hotmail. http://www.hotmail.com --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] BasicMBeanRegistry and class loader MBeans
Ok, But I'm seeing failures in the MLet tests (before Scotts modificaiton). I'll investigate... Regards, Adrian From: Juha-P Lindfors [EMAIL PROTECTED] Reply-To: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Re: [JBoss-dev] BasicMBeanRegistry and class loader MBeans Date: Sat, 10 Aug 2002 22:28:56 +0300 (EET DST) On Sat, 10 Aug 2002, Scott M Stark wrote: This probably breaks the MLet processing. But then I think it was already broken, MLets are URLClassLoaders not UCLs. actually we detect ULR in the mlet code and register one UCL per URL in case ULR is used... -- Juha --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development _ Join the worlds largest e-mail service with MSN Hotmail. http://www.hotmail.com --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] BasicMBeanRegistry and class loader MBeans
The Mlet had not been converted to the UnifiedLoaderRepository2. Regards, Adrian From: Adrian Brock [EMAIL PROTECTED] Reply-To: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Re: [JBoss-dev] BasicMBeanRegistry and class loader MBeans Date: Sat, 10 Aug 2002 21:16:06 +0100 Ok, But I'm seeing failures in the MLet tests (before Scotts modificaiton). I'll investigate... Regards, Adrian From: Juha-P Lindfors [EMAIL PROTECTED] Reply-To: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Re: [JBoss-dev] BasicMBeanRegistry and class loader MBeans Date: Sat, 10 Aug 2002 22:28:56 +0300 (EET DST) On Sat, 10 Aug 2002, Scott M Stark wrote: This probably breaks the MLet processing. But then I think it was already broken, MLets are URLClassLoaders not UCLs. actually we detect ULR in the mlet code and register one UCL per URL in case ULR is used... -- Juha --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development _ Join the worlds largest e-mail service with MSN Hotmail. http://www.hotmail.com --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development _ MSN Photos is the easiest way to share and print your photos: http://photos.msn.com/support/worldwide.aspx --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] BasicMBeanRegistry and class loader MBeans
When one registers an MBean that is a ClassLoader the BasicMBeanRegistry adds it to the the default LoaderRepository. This breaks scoped class loading of services, and it really seems to be out of the scope of functionality that the BasicMBeanRegistry should assume. Really I don't see why the BasicMBeanRegistry should have any interaction with the LoaderRepository as all it is doing is adding and removing class loaders. Scott Stark Chief Technology Officer JBoss Group, LLC --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
