[JBoss-dev] CVS update: jbosscx/src/main/org/jboss/resource/connectionmanager ManagedConnectionPoolFactory.java
User: thedug
Date: 01/11/21 10:14:51
Modified:src/main/org/jboss/resource/connectionmanager
ManagedConnectionPoolFactory.java
Log:
destroy() should actually close the connection so that the tcp connection isn't
left open.
Revision ChangesPath
1.3 +16 -0
jbosscx/src/main/org/jboss/resource/connectionmanager/ManagedConnectionPoolFactory.java
Index: ManagedConnectionPoolFactory.java
===
RCS file:
/cvsroot/jboss/jbosscx/src/main/org/jboss/resource/connectionmanager/ManagedConnectionPoolFactory.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- ManagedConnectionPoolFactory.java 2001/09/11 18:38:58 1.2
+++ ManagedConnectionPoolFactory.java 2001/11/21 18:14:51 1.3
@@ -63,6 +63,22 @@
pool = null;
}
+/**
+ * Permanently closes an object, after it is removed from the pool. The
+ * object will not be returned to the pool - after this, it is gone. This
+ * is called when the pool shrinks, and when the pool is shut down.
+ */
+public void deleteObject(Object pooledObject) {
+try{
+((ManagedConnection)pooledObject).destroy();
+}catch(ResourceException e) {
+log.println(Unable to destroy ManagedConnection: +e);
+}
+
+ }
+
+
+
/**
* Creates a new ManagedConnection with the specified parameters.
*
___
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbosscx/src/main/org/jboss/resource/connectionmanager ManagedConnectionPoolFactory.java
User: starksm
Date: 01/11/21 11:41:16
Modified:src/main/org/jboss/resource/connectionmanager
ManagedConnectionPoolFactory.java
Log:
Fix the bad check-in by thedug
Revision ChangesPath
1.4 +9 -5
jbosscx/src/main/org/jboss/resource/connectionmanager/ManagedConnectionPoolFactory.java
Index: ManagedConnectionPoolFactory.java
===
RCS file:
/cvsroot/jboss/jbosscx/src/main/org/jboss/resource/connectionmanager/ManagedConnectionPoolFactory.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- ManagedConnectionPoolFactory.java 2001/11/21 18:14:51 1.3
+++ ManagedConnectionPoolFactory.java 2001/11/21 19:41:16 1.4
@@ -68,14 +68,18 @@
* object will not be returned to the pool - after this, it is gone. This
* is called when the pool shrinks, and when the pool is shut down.
*/
-public void deleteObject(Object pooledObject) {
-try{
+public void deleteObject(Object pooledObject)
+{
+try
+{
((ManagedConnection)pooledObject).destroy();
-}catch(ResourceException e) {
-log.println(Unable to destroy ManagedConnection: +e);
}
+catch(ResourceException e)
+{
+log.error(Unable to destroy ManagedConnection: , e);
+}
- }
+ }
___
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development
RE: [JBoss-dev] CVS update: jbosscx/src/main/org/jboss/resource/connectionmanager ManagedConnectionPoolFactory.java
Sorry,
I was merging a change I made to 2.4 and didn't realize the log method had
changed.
Also, I noticed that you changed formatting. Does JBoss enforce coding
standards in
regards to formatting? If so, where can I find this information?
Thanks,
d.
-Original Message-
From: Scott M Stark [mailto:[EMAIL PROTECTED]]
Sent: Wednesday, November 21, 2001 1:41 PM
To: [EMAIL PROTECTED]
Subject: [JBoss-dev] CVS update:
jbosscx/src/main/org/jboss/resource/connectionmanager
ManagedConnectionPoolFactory.java
User: starksm
Date: 01/11/21 11:41:16
Modified:src/main/org/jboss/resource/connectionmanager
ManagedConnectionPoolFactory.java
Log:
Fix the bad check-in by thedug
Revision ChangesPath
1.4 +9 -5
jbosscx/src/main/org/jboss/resource/connectionmanager/ManagedConnectionPoolF
actory.java
Index: ManagedConnectionPoolFactory.java
===
RCS file:
/cvsroot/jboss/jbosscx/src/main/org/jboss/resource/connectionmanager/Managed
ConnectionPoolFactory.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- ManagedConnectionPoolFactory.java 2001/11/21 18:14:51 1.3
+++ ManagedConnectionPoolFactory.java 2001/11/21 19:41:16 1.4
@@ -68,14 +68,18 @@
* object will not be returned to the pool - after this, it is gone.
This
* is called when the pool shrinks, and when the pool is shut down.
*/
-public void deleteObject(Object pooledObject) {
-try{
+public void deleteObject(Object pooledObject)
+{
+try
+{
((ManagedConnection)pooledObject).destroy();
-}catch(ResourceException e) {
-log.println(Unable to destroy ManagedConnection: +e);
}
+catch(ResourceException e)
+{
+log.error(Unable to destroy ManagedConnection: , e);
+}
- }
+ }
___
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development
___
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] CVS update: jbosscx/src/main/org/jboss/resource/connectionmanager ManagedConnectionPoolFactory.java
Standards are here:
http://www.jboss.org/developers/guide/codestyle.jsp
Scott Stark
Chief Technology Officer
JBoss Group, LLC
- Original Message -
From: Ferguson, Doug [EMAIL PROTECTED]
To: 'Scott M Stark' [EMAIL PROTECTED];
[EMAIL PROTECTED]
Sent: Wednesday, November 21, 2001 12:15 PM
Subject: RE: [JBoss-dev] CVS update:
jbosscx/src/main/org/jboss/resource/connectionmanager
ManagedConnectionPoolFactory.java
Sorry,
I was merging a change I made to 2.4 and didn't realize the log method had
changed.
Also, I noticed that you changed formatting. Does JBoss enforce coding
standards in
regards to formatting? If so, where can I find this information?
Thanks,
d.
-Original Message-
From: Scott M Stark [mailto:[EMAIL PROTECTED]]
Sent: Wednesday, November 21, 2001 1:41 PM
To: [EMAIL PROTECTED]
Subject: [JBoss-dev] CVS update:
jbosscx/src/main/org/jboss/resource/connectionmanager
ManagedConnectionPoolFactory.java
User: starksm
Date: 01/11/21 11:41:16
Modified:src/main/org/jboss/resource/connectionmanager
ManagedConnectionPoolFactory.java
Log:
Fix the bad check-in by thedug
Revision ChangesPath
1.4 +9 -5
jbosscx/src/main/org/jboss/resource/connectionmanager/ManagedConnectionPoolF
actory.java
Index: ManagedConnectionPoolFactory.java
===
RCS file:
/cvsroot/jboss/jbosscx/src/main/org/jboss/resource/connectionmanager/Managed
ConnectionPoolFactory.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- ManagedConnectionPoolFactory.java 2001/11/21 18:14:51 1.3
+++ ManagedConnectionPoolFactory.java 2001/11/21 19:41:16 1.4
@@ -68,14 +68,18 @@
* object will not be returned to the pool - after this, it is
gone.
This
* is called when the pool shrinks, and when the pool is shut
down.
*/
-public void deleteObject(Object pooledObject) {
-try{
+public void deleteObject(Object pooledObject)
+{
+try
+{
((ManagedConnection)pooledObject).destroy();
-}catch(ResourceException e) {
-log.println(Unable to destroy ManagedConnection: +e);
}
+catch(ResourceException e)
+{
+log.error(Unable to destroy ManagedConnection: , e);
+}
- }
+ }
___
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development
___
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development
