[JBoss-dev] RE: FW: JBAS-2972 - OOME / Redeployment leakages

2006-03-23 Thread Adrian Brock
On Thu, 2006-03-23 at 09:05 -0600, Clebert Suconic wrote:
> > I don't even know what ThreadPool changes you are referring to, are
> they real or proposed?
> 
> I thought we had some changes on the ThreadPools. My bad.
> I meant that because of references through ThreadWithAttributes (they
> will be always appear for some reason on JVMTI).
> 
> 
> Anyway, I need to know if a Thread is cleared
> (Thread.setContextClassLoader(somethingElse) before the Thread goes to
> sleep.
> If the Thread keeps the ClassLoader reference until next request, that
> will make my life harder creating a TestCase structure for testing
> redeployment/classLeakages.

All code should be switching and restoring the classloader
during the invocations.  Anything else is a bug.

ClassLoader old = tcl;
tcl = myClassLoader
try
{
}
finally
{
tcl = old;
}

Of course if something (e.g. an MBean)
that is hotdeployed starts a thread
and doesn't stop it at undeployment then it will leak
the classloader. But that is also a bug.
-- 

Adrian Brock
Chief Scientist
JBoss Inc.




---
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
___
JBoss-Development mailing list
JBoss-Development@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jboss-development


[JBoss-dev] RE: FW: JBAS-2972 - OOME / Redeployment leakages

2006-03-23 Thread Clebert Suconic
> I don't even know what ThreadPool changes you are referring to, are
they real or proposed?

I thought we had some changes on the ThreadPools. My bad.
I meant that because of references through ThreadWithAttributes (they
will be always appear for some reason on JVMTI).


Anyway, I need to know if a Thread is cleared
(Thread.setContextClassLoader(somethingElse) before the Thread goes to
sleep.
If the Thread keeps the ClassLoader reference until next request, that
will make my life harder creating a TestCase structure for testing
redeployment/classLeakages.

http://jira.jboss.org/jira/browse/JBAS-2909



-Original Message-
From: Adrian Brock 
Sent: Thursday, March 23, 2006 3:41 AM
To: Clebert Suconic
Cc: Scott M Stark; jboss-development@lists.sourceforge.net
Subject: Re: FW: JBAS-2972 - OOME / Redeployment leakages

On Wed, 2006-03-22 at 21:03 -0600, Clebert Suconic wrote:
> Sorry... pressed Ctrl-enter instead of Enter. (Damn Outlook)
> 
> Do you think that our changes on ThreadPool would eventually leak
> redeployments on the testsuite? (for instance, by keeping
> Thread.currentThread().contextClassLoader() still alive) ?

Clebert, can you please include  some hard facts.
I am not going to comment on speculation.

If you want me to "get the facts" - 
(and I don't mean MSFacts ;-) then tell me.

I don't even know what ThreadPool changes you are referring to,
are they real or proposed?
-- 

Adrian Brock
Chief Scientist
JBoss Inc.




---
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642
___
JBoss-Development mailing list
JBoss-Development@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jboss-development


[JBoss-dev] Re: FW: JBAS-2972 - OOME / Redeployment leakages

2006-03-23 Thread Adrian Brock
On Wed, 2006-03-22 at 21:03 -0600, Clebert Suconic wrote:
> Sorry... pressed Ctrl-enter instead of Enter. (Damn Outlook)
> 
> Do you think that our changes on ThreadPool would eventually leak
> redeployments on the testsuite? (for instance, by keeping
> Thread.currentThread().contextClassLoader() still alive) ?

Clebert, can you please include  some hard facts.
I am not going to comment on speculation.

If you want me to "get the facts" - 
(and I don't mean MSFacts ;-) then tell me.

I don't even know what ThreadPool changes you are referring to,
are they real or proposed?
-- 

Adrian Brock
Chief Scientist
JBoss Inc.




---
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
___
JBoss-Development mailing list
JBoss-Development@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jboss-development