Ooops, sounds like I messed up by applying it... Still, lazy hacking, that hurts... I prefer a slight oversight.
> -----Original Message----- > From: Scott M Stark [mailto:[EMAIL PROTECTED]] > Sent: Monday, October 01, 2001 6:34 PM > To: [EMAIL PROTECTED] > Subject: [JBoss-dev] The fix for bug #462253 is not acceptable > > > The fix for bug[ #462253 ] TextMessage fails for >64k content > is not acceptable for 3 reasons: > > 1. It breaks backward compatibility with previous versions > but does not > change the SpyTextMessage.serialVersionUID value. Using the 2.4.1 > jbossmq jars produces the following exceptions when run with the mdb > unit test against a server using the latest 2.4 branch jbossmq jars: > > [OILServerILService] Client request resulted in a server exception: > java.lang.NegativeArraySizeException > at java.lang.StringBuffer.<init>(StringBuffer.java:116) > at > org.jboss.mq.SpyTextMessage.readExternal(SpyTextMessage.java:76) > at org.jboss.mq.SpyMessage.readMessage(SpyMessage.java:589) > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:219) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > java.rmi.RemoteException: Bad method code ! > at > org.jboss.mq.il.oil.OILServerILService.run(OILServerILService. > java:273) > at java.lang.Thread.run(Thread.java:484) > [OILServerILService] Client request resulted in a server exception: > > 2. The fix introduces a copy of the text message content regardless of > whether > the context is in fact >64k. This is just lazy hacking. > > 3. There is no testcase for the fix in the jbosstest. > > I am backing out the change applied to the 2.4 branch. > > > > _______________________________________________ > Jboss-development mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/jboss-development > _______________________________________________ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
