hg: jdk7u/jdk7u-dev/jdk: 7130521: [macosx] closed/javax/swing/JMenuItem/6209975/bug6209975.java failed on macosx

2012-03-20 Thread alexandr . scherbatiy 
Changeset: d62aaedadac8
Author:alexsch
Date:  2012-03-20 13:48 +0400
URL:   http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/d62aaedadac8

7130521: [macosx] closed/javax/swing/JMenuItem/6209975/bug6209975.java failed 
on macosx
Reviewed-by: rupashka

+ test/javax/swing/JMenuItem/6209975/bug6209975.java

[7u6] Request for approval for CR 7133566 - closed/javax/swing/JTable/4220171/bug4220171.java fails on MacOS

2012-03-20 Thread Alexander Scherbatiy 


Hello,

This is a request to backport a JDK 8 fix into JDK 7u6:

7133566 [macosx] closed/javax/swing/JTable/4220171/bug4220171.java fails 
on MacOS

http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7133566

The fix has already been pushed to JDK 8, as:
http://hg.openjdk.java.net/jdk8/awt/jdk/rev/36b5f46264b3


The code changes for jdk7u6 are identical to the ones in jdk8.

Thank you,
Alexandr.

Re: [7u6] Request for approval for CR 7133566 - closed/javax/swing/JTable/4220171/bug4220171.java fails on MacOS

2012-03-20 Thread Edvard Wendelin 

Approved.

On 03/20/2012 11:09 AM, Alexander Scherbatiy wrote:


Hello,

This is a request to backport a JDK 8 fix into JDK 7u6:

7133566 [macosx] closed/javax/swing/JTable/4220171/bug4220171.java 
fails on MacOS

http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7133566

The fix has already been pushed to JDK 8, as:
http://hg.openjdk.java.net/jdk8/awt/jdk/rev/36b5f46264b3


The code changes for jdk7u6 are identical to the ones in jdk8.

Thank you,
Alexandr.

[7u6] Request for approval for CR 7133573 - closed/javax/swing/JToolTip/4846413/bug4846413.java fails on MacOS

2012-03-20 Thread Alexander Scherbatiy 


Hello,

This is a request to backport a JDK 8 fix into JDK 7u6:

7133573 [macosx] closed/javax/swing/JToolTip/4846413/bug4846413.java 
fails on MacOS

http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7133573

The fix has already been pushed to JDK 8, as:
http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ea888347969d


The code changes for jdk7u6 are identical to the ones in jdk8.

Thank you,
Alexandr.

[7u6] Request for approval for CR 7133581 - closed/javax/swing/JTree/4330357/bug4330357.java fails on MacOS

2012-03-20 Thread Alexander Scherbatiy 

 Hello,

This is a request to backport a JDK 8 fix into JDK 7u6:

7133581 [macosx] closed/javax/swing/JTree/4330357/bug4330357.java fails 
on MacOS

http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7133581

The fix has already been pushed to JDK 8, as:
http://hg.openjdk.java.net/jdk8/awt/jdk/rev/314441d960c0


The code changes for jdk7u6 are identical to the ones in jdk8.

Thank you,
Alexandr.

[7u6] Request for approval for CR 7132808 - closed/javax/swing/JFileChooser/4524490/bug4524490.java fails on MacOS

2012-03-20 Thread Alexander Scherbatiy 

Hello,

This is a request to backport a JDK 8 fix into JDK 7u6:

7132808 [macosx] closed/javax/swing/JFileChooser/4524490/bug4524490.java 
fails on MacOS

http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7132808

The fix has already been pushed to JDK 8, as:
http://hg.openjdk.java.net/jdk8/awt/jdk/rev/af06a5460c42


The code changes for jdk7u6 are identical to the ones in jdk8.

Thank you,
Alexandr.

[7u4] Request for approval for 7123170: JCK vm/jvmti/ResourceExhausted/resexh001/resexh00101/ tests fails since 7u4 b02

2012-03-20 Thread serguei.spit...@oracle.com 

Hello,

This is a request to backport a jdk8/hsx-24 fix into 7u4/hsx-23:
http://monaco.us.oracle.com/detail.jsf?cr=7123170

The fix has been already pushed into jdk8/hsx-24, as:
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a735aec54ea4

The code changes for 7u4/HSX-23 are identical to the ones in jdk8/hsx-24.

Thanks,
Serguei

Re: [7u6] Code Review Request for CR 7128738 - dragged dialog freezes system on dispose

2012-03-20 Thread Artem Ananiev 

Hi, Oleg,

the fix looks fine, as it did for JDK8. In this particular case, the 
change is 1-liner, but in the future, could you also provide a link to 
JDK8 (or whatever release it's backported from) webrev, please? It's 
much easier to look at the webrev than at the patch.


Thanks,

Artem

On 3/19/2012 9:58 PM, Oleg Pekhovskiy wrote:

Hi!

Please review the fix to push for CR:
http://bugs.sun.com/view_bug.do?bug_id=7128738

jdk8 changeset:
http://hg.openjdk.java.net/jdk8/awt-gate/jdk/rev/255dd9eddc10

Reviewed by: anthony
http://mail.openjdk.java.net/pipermail/awt-dev/2012-March/002348.html

Thanks,
Oleg

Re: [7u4] Request for approval for 7123170: JCK vm/jvmti/ResourceExhausted/resexh001/resexh00101/ tests fails since 7u4 b02

2012-03-20 Thread serguei.spit...@oracle.com 

Just in case it is needed..

This is the hsx-23 webrev:
  
http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/7123170-Fix-JCK-ResourceExhausted.hs23/


This is the hsx-24 webrev:
  
http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/7123170-Fix-JCK-ResourceExhausted.2/


Thanks,
Serguei

On 3/20/12 3:35 AM, serguei.spit...@oracle.com wrote:

Hello,

This is a request to backport a jdk8/hsx-24 fix into 7u4/hsx-23:
http://monaco.us.oracle.com/detail.jsf?cr=7123170

The fix has been already pushed into jdk8/hsx-24, as:
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a735aec54ea4

The code changes for 7u4/HSX-23 are identical to the ones in jdk8/hsx-24.

Thanks,
Serguei

[7u4] Request for phase 2 approval for CR 7150089: [macosx] Default for a custom cursor created from non-existent image is not transparent

2012-03-20 Thread Leonid Romanov 
Bug:  http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7150089
Webrev: http://cr.openjdk.java.net/~leonidr/7150089/webrev.00/
Review thread: 
http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-March/003637.html
Reviewer: swingler

Rationale for inclusion in 7u4: Since 1.3 release, there is an approach adopted 
for cursors created from non-existent image to make them transparent. It is an 
additional well-known if not exactly documented feature (see discussion in 
4212593). This behavior was implemented in Apple jdk6.

Thanks,
Leonid.

Re: [7u6] Code Review Request for CR 7128738 - dragged dialog freezes system on dispose

2012-03-20 Thread Oleg Pekhovskiy 

Hi, Artem,

sure, thank you for pointing that out.

Best regards,
Oleg


3/20/2012 2:39 PM, Artem Ananiev wrote:

Hi, Oleg,

the fix looks fine, as it did for JDK8. In this particular case, the 
change is 1-liner, but in the future, could you also provide a link to 
JDK8 (or whatever release it's backported from) webrev, please? It's 
much easier to look at the webrev than at the patch.


Thanks,

Artem

On 3/19/2012 9:58 PM, Oleg Pekhovskiy wrote:

Hi!

Please review the fix to push for CR:
http://bugs.sun.com/view_bug.do?bug_id=7128738

jdk8 changeset:
http://hg.openjdk.java.net/jdk8/awt-gate/jdk/rev/255dd9eddc10

Reviewed by: anthony
http://mail.openjdk.java.net/pipermail/awt-dev/2012-March/002348.html

Thanks,
Oleg

Re: [7u6] Request for approval for 7150349: [macosx] Applets attempting to show popup menus activate the applet process

2012-03-20 Thread Edvard Wendelin 

Hi,

I assume this is applicable to JDK 8 as well? I haven't seen a push to 
the JDK 8 forest. I'll approve it, but please make sure to push the fix 
to the appropriate JDK 8 forest before pushing it to jdk7u-dev.


Cheers,
Edvard

On 03/20/2012 07:51 AM, Dmitry Cherepanov wrote:

This is a request to push the following fix to jdk7u-dev:

Bug: 7150349 "[macosx] Applets attempting to show popup menus activate 
the applet process"


Webrev: http://cr.openjdk.java.net/~dcherepanov/7150349/webrev.0/

Technical review: 
http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-March/003631.html


Thanks,
Dmitry

Re: [7u6] Request for approval for CR 7133581 - closed/javax/swing/JTree/4330357/bug4330357.java fails on MacOS

2012-03-20 Thread Edvard Wendelin 

Approved.

On 03/20/2012 11:20 AM, Alexander Scherbatiy wrote:

 Hello,

This is a request to backport a JDK 8 fix into JDK 7u6:

7133581 [macosx] closed/javax/swing/JTree/4330357/bug4330357.java 
fails on MacOS

http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7133581

The fix has already been pushed to JDK 8, as:
http://hg.openjdk.java.net/jdk8/awt/jdk/rev/314441d960c0


The code changes for jdk7u6 are identical to the ones in jdk8.

Thank you,
Alexandr.

Re: [7u6] Request for approval for CR 7133573 - closed/javax/swing/JToolTip/4846413/bug4846413.java fails on MacOS

2012-03-20 Thread Edvard Wendelin 

Approved

On 03/20/2012 11:18 AM, Alexander Scherbatiy wrote:


Hello,

This is a request to backport a JDK 8 fix into JDK 7u6:

7133573 [macosx] closed/javax/swing/JToolTip/4846413/bug4846413.java 
fails on MacOS

http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7133573

The fix has already been pushed to JDK 8, as:
http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ea888347969d


The code changes for jdk7u6 are identical to the ones in jdk8.

Thank you,
Alexandr.

Re: [7u4] Request for approval for 7123170: JCK vm/jvmti/ResourceExhausted/resexh001/resexh00101/ tests fails since 7u4 b02

2012-03-20 Thread Edvard Wendelin 

Hi,

Hotspot fixes usually get approvals when they come in through the bulk 
integration from hsx to jdk7u-dev, but now that you ask I think it looks 
good. Feel free to push once the CR has been approved by the release team.


Cheers,
Edvard

On 03/20/2012 12:25 PM, serguei.spit...@oracle.com wrote:

Just in case it is needed..

This is the hsx-23 webrev:
  
http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/7123170-Fix-JCK-ResourceExhausted.hs23/


This is the hsx-24 webrev:
  
http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/7123170-Fix-JCK-ResourceExhausted.2/


Thanks,
Serguei

On 3/20/12 3:35 AM, serguei.spit...@oracle.com wrote:

Hello,

This is a request to backport a jdk8/hsx-24 fix into 7u4/hsx-23:
http://monaco.us.oracle.com/detail.jsf?cr=7123170

The fix has been already pushed into jdk8/hsx-24, as:
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a735aec54ea4

The code changes for 7u4/HSX-23 are identical to the ones in 
jdk8/hsx-24.


Thanks,
Serguei

Re: [7u4] Request for phase 2 approval for CR 7150089: [macosx] Default for a custom cursor created from non-existent image is not transparent

2012-03-20 Thread Edvard Wendelin 
Pre-approved pending release team approval. Once you see OK in bug, feel 
free to push the fix.


Cheers,
Edvard

On 03/20/2012 12:36 PM, Leonid Romanov wrote:

Bug:  http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7150089
Webrev: http://cr.openjdk.java.net/~leonidr/7150089/webrev.00/
Review thread: 
http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-March/003637.html
Reviewer: swingler

Rationale for inclusion in 7u4: Since 1.3 release, there is an approach adopted 
for cursors created from non-existent image to make them transparent. It is an 
additional well-known if not exactly documented feature (see discussion in 
4212593). This behavior was implemented in Apple jdk6.

Thanks,
Leonid.

[7u4] Request for phase 2 approval for CR 7124428: [macosx] Frame.setExtendedState() doesn't work for undecorated windows

2012-03-20 Thread Anthony Petrov 

Bug: http://bugs.sun.com/view_bug.do?bug_id=7124428
Webrev: 
http://cr.openjdk.java.net/~anthony/7u4-7-setExtendedStateUndecorated-7124428.0/
Review thread: 
http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-March/003630.html

Reviewer: Mike Swingler (swingler)

Rationale for inclusion in 7u4: the fix resolves a couple of SQE tests 
failures. Its risk is estimated as LOW because it only affects 
programmatic maximization of frames on the Mac.


--
best regards,
Anthony

Re: [7u4] Request for phase 2 approval for CR 7124428: [macosx] Frame.setExtendedState() doesn't work for undecorated windows

2012-03-20 Thread Edvard Wendelin 
Pre-approved pending release team approval. Feel free to push as soon as 
you see OK in CR.


Cheers,
Edvard

On 03/20/2012 01:47 PM, Anthony Petrov wrote:

Bug: http://bugs.sun.com/view_bug.do?bug_id=7124428
Webrev: 
http://cr.openjdk.java.net/~anthony/7u4-7-setExtendedStateUndecorated-7124428.0/
Review thread: 
http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-March/003630.html

Reviewer: Mike Swingler (swingler)

Rationale for inclusion in 7u4: the fix resolves a couple of SQE tests 
failures. Its risk is estimated as LOW because it only affects 
programmatic maximization of frames on the Mac.


--
best regards,
Anthony

Re: [7u4] Request for approval for 7123170: JCK vm/jvmti/ResourceExhausted/resexh001/resexh00101/ tests fails since 7u4 b02

2012-03-20 Thread John Coomes 
Edvard Wendelin (edvard.wende...@oracle.com) wrote:
> Hi,
> 
> Hotspot fixes usually get approvals when they come in through the bulk 
> integration from hsx to jdk7u-dev ...

Yes.  Serguei, in the future, best not to send individual approval
requests for hotspot fixes, so we can avoid duplication.

> ...  , but now that you ask I think it looks 
> good. Feel free to push once the CR has been approved by the release team.

Sergeui, make sure you push to the hsx23 repository:

http://hg.openjdk.java.net/hsx/hsx23/hotspot

-John

> On 03/20/2012 12:25 PM, serguei.spit...@oracle.com wrote:
> > Just in case it is needed..
> >
> > This is the hsx-23 webrev:
> >   
> > http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/7123170-Fix-JCK-ResourceExhausted.hs23/
> >
> > This is the hsx-24 webrev:
> >   
> > http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/7123170-Fix-JCK-ResourceExhausted.2/
> >
> > Thanks,
> > Serguei
> >
> > On 3/20/12 3:35 AM, serguei.spit...@oracle.com wrote:
> >> Hello,
> >>
> >> This is a request to backport a jdk8/hsx-24 fix into 7u4/hsx-23:
> >> http://monaco.us.oracle.com/detail.jsf?cr=7123170
> >>
> >> The fix has been already pushed into jdk8/hsx-24, as:
> >> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a735aec54ea4
> >>
> >> The code changes for 7u4/HSX-23 are identical to the ones in 
> >> jdk8/hsx-24.
> >>
> >> Thanks,
> >> Serguei
> >>
> >>
> >

[7u4] Request for phase 2 approval for CR 7145768 [macosx] Regression: failure in b11 of ModalDialogInFocusEventTest

2012-03-20 Thread Anton V. Tarasov 

Bug: http://bugs.sun.com/view_bug.do?bug_id=7145768
Webrev: http://cr.openjdk.java.net/~ant/7145768/webrev.1/
Review thread: 
http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-March/003635.html
Reviewer: Artem Ananiev (art)

Rationale for inclusion in 7u4: A kbd focus race on subsequent showing of two frames (reproducible 
from time to time). May lead to kbd focus getting into invalid state.


Thanks,
Anton.

[7u6] Request for approval for CR 7128738 - dragged dialog freezes system on dispose

2012-03-20 Thread Oleg Pekhovskiy 

Hi!

Please review this backport to push for CR: 
http://bugs.sun.com/view_bug.do?bug_id=7128738


Webrev for 7u6: http://cr.openjdk.java.net/~bagiras/7u6/7128738.1
JDK8 changeset: 
http://hg.openjdk.java.net/jdk8/awt-gate/jdk/rev/255dd9eddc10
Review thread: 
http://mail.openjdk.java.net/pipermail/awt-dev/2012-March/002348.html

Reviewed by: art, anthony

The code changes for 7u6 are identical to the ones in JDK8.

Thanks,
Oleg

Re: [7u4] Request for approval for 7123170: JCK vm/jvmti/ResourceExhausted/resexh001/resexh00101/ tests fails since 7u4 b02

2012-03-20 Thread serguei.spit...@oracle.com 

Ok, thanks!
Serguei


On 3/20/12 5:34 AM, Edvard Wendelin wrote:

Hi,

Hotspot fixes usually get approvals when they come in through the bulk 
integration from hsx to jdk7u-dev, but now that you ask I think it 
looks good. Feel free to push once the CR has been approved by the 
release team.


Cheers,
Edvard

On 03/20/2012 12:25 PM, serguei.spit...@oracle.com wrote:

Just in case it is needed..

This is the hsx-23 webrev:
  
http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/7123170-Fix-JCK-ResourceExhausted.hs23/


This is the hsx-24 webrev:
  
http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/7123170-Fix-JCK-ResourceExhausted.2/


Thanks,
Serguei

On 3/20/12 3:35 AM, serguei.spit...@oracle.com wrote:

Hello,

This is a request to backport a jdk8/hsx-24 fix into 7u4/hsx-23:
http://monaco.us.oracle.com/detail.jsf?cr=7123170

The fix has been already pushed into jdk8/hsx-24, as:
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a735aec54ea4

The code changes for 7u4/HSX-23 are identical to the ones in 
jdk8/hsx-24.


Thanks,
Serguei

hg: jdk7u/jdk7u-dev/jdk: 7150349: [macosx] Applets attempting to show popup menus activate the applet process

2012-03-20 Thread dmitry . cherepanov 
Changeset: 42004ca895ff
Author:dcherepanov
Date:  2012-03-20 19:42 +0400
URL:   http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/42004ca895ff

7150349: [macosx] Applets attempting to show popup menus activate the applet 
process
Reviewed-by: ant

! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java
! src/macosx/classes/sun/lwawt/macosx/CWrapper.java
! src/macosx/native/sun/awt/AWTWindow.m
! src/macosx/native/sun/awt/CWrapper.m
! src/macosx/native/sun/awt/LWCToolkit.m

[7u4] Request for phase 2 approval for CR 7149085: [macosx] Quit with QuitStrategy CLOSE_ALL_WINDOWS does terminate application

2012-03-20 Thread Anthony Petrov 

Bug: http://bugs.sun.com/view_bug.do?bug_id=7149085
Webrev: http://cr.openjdk.java.net/~anthony/7u4-8-CloseAllWindows-7149085.0/
Review thread: 
http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-March/003654.html

Reviewer: Alexander Zuev (kizune)

Rationale for inclusion in 7u4: deferral of the fix rejected by the 
Release Team.

   Impact:
  Resolves an issue with EAWT (Mac OS X-specific) API.
   Risk:
  LOW: a one-liner fix.

--
best regards,
Anthony

[7u4] Request for Phase 2 approval for CR 7144063: [macosx] Swing JMenu mnemonic doesn't work; hint misleading; cross symbol typed

2012-03-20 Thread Alexander Zuev 

Bug: http://bugs.sun.com/view_bug.do?bug_id=7144063
Webrev: http://cr.openjdk.java.net/~kizune/7144063/webrev.01/
Technical review thread: 
http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-February/003060.html


Rationale for inclusion in 7u4: menu accelerators work unstable and 
unable to enter some (but not all) special symbols into the text 
component. Low-risk fix reviewed and approved by both QA and R-Team.

[7u4] Request for phase 2 approval for CR 7154177: [macosx] An invisible owner frame becomes visible upon clicking a child window

2012-03-20 Thread Anthony Petrov 

Bug: http://bugs.sun.com/view_bug.do?bug_id=7154177
Webrev: http://cr.openjdk.java.net/~anthony/7u4-5-invisibleOwner-7154177.1/
Review thread: 
http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-March/003628.html

Reviewer: Sergey Bylokhov (serb)

Rationale for inclusion in 7u4:
   Impact:
  Resolves a noticeable visual artifact that may affect any Swing 
application using popup-menus, or, say, owned dialogs.

   Risk:
  MEDIUM: the fix changes the logic that establishes the 
parent-child relationship between top-level windows on the native level.


--
best regards,
Anthony

[7u4] Request for phase 2 approval for CR 7152952: [macosx] List rows overlap with enlarged font

2012-03-20 Thread Alexander Potochkin 

Bug: http://bugs.sun.com/view_bug.do?bug_id=7152952
Webrev: http://cr.openjdk.java.net/~alexp/7152952/webrev.00
Review thread: 
http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-March/003657.html

Reviewer: Sergey Bylokhov

Rationale for inclusion in 7u4: this is a regression from JDK6

Re: [7u4] Request for phase 2 approval for CR 7145768 [macosx] Regression: failure in b11 of ModalDialogInFocusEventTest

2012-03-20 Thread Edvard Wendelin 
Pre-approved pending release team approval. Feel free to push as soon as 
you get an OK in the CR.


Cheers,
Edvard

On 03/20/2012 02:39 PM, Anton V. Tarasov wrote:

Bug: http://bugs.sun.com/view_bug.do?bug_id=7145768
Webrev: http://cr.openjdk.java.net/~ant/7145768/webrev.1/
Review thread: 
http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-March/003635.html

Reviewer: Artem Ananiev (art)

Rationale for inclusion in 7u4: A kbd focus race on subsequent showing 
of two frames (reproducible from time to time). May lead to kbd focus 
getting into invalid state.


Thanks,
Anton.

Re: [7u6] Request for approval for CR 7128738 - dragged dialog freezes system on dispose

2012-03-20 Thread Edvard Wendelin 

Approved!

On 03/20/2012 03:08 PM, Oleg Pekhovskiy wrote:

Hi!

Please review this backport to push for CR: 
http://bugs.sun.com/view_bug.do?bug_id=7128738


Webrev for 7u6: http://cr.openjdk.java.net/~bagiras/7u6/7128738.1
JDK8 changeset: 
http://hg.openjdk.java.net/jdk8/awt-gate/jdk/rev/255dd9eddc10
Review thread: 
http://mail.openjdk.java.net/pipermail/awt-dev/2012-March/002348.html

Reviewed by: art, anthony

The code changes for 7u6 are identical to the ones in JDK8.

Thanks,
Oleg

Re: [7u4] Request for phase 2 approval for CR 7149085: [macosx] Quit with QuitStrategy CLOSE_ALL_WINDOWS does terminate application

2012-03-20 Thread Edvard Wendelin 
Pre-approved pending release team approval. Feel free to push once it's 
been approved.  Make sure you create a CR for 8 so that we don't forget 
that we should forward port this!


Cheers,
Edvard


On 03/20/2012 04:57 PM, Anthony Petrov wrote:

Bug: http://bugs.sun.com/view_bug.do?bug_id=7149085
Webrev: 
http://cr.openjdk.java.net/~anthony/7u4-8-CloseAllWindows-7149085.0/
Review thread: 
http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-March/003654.html

Reviewer: Alexander Zuev (kizune)

Rationale for inclusion in 7u4: deferral of the fix rejected by the 
Release Team.

   Impact:
  Resolves an issue with EAWT (Mac OS X-specific) API.
   Risk:
  LOW: a one-liner fix.

--
best regards,
Anthony

Re: [7u4] Request for phase 2 approval for CR 7145768 [macosx] Regression: failure in b11 of ModalDialogInFocusEventTest

2012-03-20 Thread Edvard Wendelin 
Forgot to add that you should create a sub-CR for JDK 8 as well (or push 
it if the fix applies straight away).


Cheers,
Edvard

On 03/20/2012 05:35 PM, Edvard Wendelin wrote:
Pre-approved pending release team approval. Feel free to push as soon 
as you get an OK in the CR.


Cheers,
Edvard

On 03/20/2012 02:39 PM, Anton V. Tarasov wrote:

Bug: http://bugs.sun.com/view_bug.do?bug_id=7145768
Webrev: http://cr.openjdk.java.net/~ant/7145768/webrev.1/
Review thread: 
http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-March/003635.html

Reviewer: Artem Ananiev (art)

Rationale for inclusion in 7u4: A kbd focus race on subsequent 
showing of two frames (reproducible from time to time). May lead to 
kbd focus getting into invalid state.


Thanks,
Anton.

Re: [7u4] Request for approval for 7123170: JCK vm/jvmti/ResourceExhausted/resexh001/resexh00101/ tests fails since 7u4 b02

2012-03-20 Thread serguei.spit...@oracle.com 

On 3/20/12 6:17 AM, John Coomes wrote:

Edvard Wendelin (edvard.wende...@oracle.com) wrote:

Hi,

Hotspot fixes usually get approvals when they come in through the bulk
integration from hsx to jdk7u-dev ...

Yes.  Serguei, in the future, best not to send individual approval
requests for hotspot fixes, so we can avoid duplication.


...  , but now that you ask I think it looks
good. Feel free to push once the CR has been approved by the release team.

Sergeui, make sure you push to the hsx23 repository:

http://hg.openjdk.java.net/hsx/hsx23/hotspot


Right.
You can find the parent repo in the hs23 webrev:
  
http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/7123170-Fix-JCK-ResourceExhausted.hs23/



Thanks,
Serguei



-John


On 03/20/2012 12:25 PM, serguei.spit...@oracle.com wrote:

Just in case it is needed..

This is the hsx-23 webrev:

http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/7123170-Fix-JCK-ResourceExhausted.hs23/

This is the hsx-24 webrev:

http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/7123170-Fix-JCK-ResourceExhausted.2/

Thanks,
Serguei

On 3/20/12 3:35 AM, serguei.spit...@oracle.com wrote:

Hello,

This is a request to backport a jdk8/hsx-24 fix into 7u4/hsx-23:
http://monaco.us.oracle.com/detail.jsf?cr=7123170

The fix has been already pushed into jdk8/hsx-24, as:
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a735aec54ea4

The code changes for 7u4/HSX-23 are identical to the ones in
jdk8/hsx-24.

Thanks,
Serguei

Re: [7u4] Request for phase 2 approval for CR 7154177: [macosx] An invisible owner frame becomes visible upon clicking a child window

2012-03-20 Thread Edvard Wendelin 
Pre-approved pending release team approval. Remember to create a sub-CR 
for this one as well!


On 03/20/2012 05:22 PM, Anthony Petrov wrote:

Bug: http://bugs.sun.com/view_bug.do?bug_id=7154177
Webrev: 
http://cr.openjdk.java.net/~anthony/7u4-5-invisibleOwner-7154177.1/
Review thread: 
http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-March/003628.html

Reviewer: Sergey Bylokhov (serb)

Rationale for inclusion in 7u4:
   Impact:
  Resolves a noticeable visual artifact that may affect any Swing 
application using popup-menus, or, say, owned dialogs.

   Risk:
  MEDIUM: the fix changes the logic that establishes the 
parent-child relationship between top-level windows on the native level.


--
best regards,
Anthony

Re: [7u4] Request for Phase 2 approval for CR 7144063: [macosx] Swing JMenu mnemonic doesn't work; hint misleading; cross symbol typed

2012-03-20 Thread Edvard Wendelin 

Approved! Please push the fix to JDK8 and create a sub-cr for the same!

Cheers,
Edvard

On 03/20/2012 06:06 PM, Alexander Zuev wrote:

Bug: http://bugs.sun.com/view_bug.do?bug_id=7144063
Webrev: http://cr.openjdk.java.net/~kizune/7144063/webrev.01/
Technical review thread: 
http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-February/003060.html


Rationale for inclusion in 7u4: menu accelerators work unstable and 
unable to enter some (but not all) special symbols into the text 
component. Low-risk fix reviewed and approved by both QA and R-Team.

Re: [7u4] Request for phase 2 approval for CR 7145768 [macosx] Regression: failure in b11 of ModalDialogInFocusEventTest

2012-03-20 Thread Artem Ananiev 


On 3/20/2012 8:46 PM, Edvard Wendelin wrote:

Forgot to add that you should create a sub-CR for JDK 8 as well (or push
it if the fix applies straight away).


Even if the fix is absolutely the same for different JDK versions (e.g. 
7u4 and 8), separate sub-CRs should be created for every release the fix 
to be pushed to, shouldn't they?


Thanks,

Artem


Cheers,
Edvard

On 03/20/2012 05:35 PM, Edvard Wendelin wrote:

Pre-approved pending release team approval. Feel free to push as soon
as you get an OK in the CR.

Cheers,
Edvard

On 03/20/2012 02:39 PM, Anton V. Tarasov wrote:

Bug: http://bugs.sun.com/view_bug.do?bug_id=7145768
Webrev: http://cr.openjdk.java.net/~ant/7145768/webrev.1/
Review thread:
http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-March/003635.html

Reviewer: Artem Ananiev (art)

Rationale for inclusion in 7u4: A kbd focus race on subsequent
showing of two frames (reproducible from time to time). May lead to
kbd focus getting into invalid state.

Thanks,
Anton.

[7u4] Request for Phase 2 approval for CR 7150637: No newline emitted after XML decl in XSLT output

2012-03-20 Thread Joe Wang 

Hi,

This is to apply a patch that would address a regression introduced by 
an Apache update.


The bug report: http://bugs.sun.com/view_bug.do?bug_id=7150637

Webrev: http://cr.openjdk.java.net/~joehw/7u4/cr7150537/webrev/

Patch reviewed by Lance: 
http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-March/009605.html


Thanks,
Joe