Re: [PATCH] 6956398: make ephemeral DH key match the length of the certificate key

2016-04-14 Thread Andrew Hughes


- Original Message -
> * Andrew Hughes  [2016-04-13 21:37]:
> > Webrev: http://cr.openjdk.java.net/~andrew/jdk7u/6956398/webrev.01/
> > 8 changeset: http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/0d5f4f1782e8
> > 
> > This patch has been in IcedTea 2.x since the 2.5.5 release on 2015-04-14.
> > 
> > The changeset is nearly identical to the one in 8, with the additional
> > change of having to add the parseUnsignedInt methods from OpenJDK 8's
> > java.lang.Integer as private methods in ServerHandshaker.
> > 
> > The history in IcedTea is slightly more involved because the default
> > was originally changed, so that the backport caused less impact, but
> > this was reversed in 2.5.6 (2015-07-22) by PR2487 [0] [1] as a
> > response to CVE-2015-4000 (LOGJAM).
> > 
> > Ok to push?
> 
> Looks good to me.
> 
> Thanks,
> Omair
> 
> --
> PGP Key: 66484681 (http://pgp.mit.edu/)
> Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681
> 

Thanks! Pushed:

http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/34c594b52b73
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222




[PATCH] 8087120: [GCC5] java.lang.StackOverflowError on Zero JVM initialization on non x86 platforms

2016-04-14 Thread Andrew Hughes
Webrev: http://cr.openjdk.java.net/~andrew/jdk7u/8087120/webrev.01/
OpenJDK 8 changeset: 
http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/c6ef40024aa2

This patch has been in IcedTea 2.x since 2.6.1 (2015-07-21).

It applies as-is to OpenJDK 7. Despite the description, it's necessary
for me to build Zero on x86_64 with GCC 5.3.

Ok to push?

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222




Re: [PATCH] 8087120: [GCC5] java.lang.StackOverflowError on Zero JVM initialization on non x86 platforms

2016-04-14 Thread Omair Majid
* Andrew Hughes  [2016-04-14 14:52]:
> Webrev: http://cr.openjdk.java.net/~andrew/jdk7u/8087120/webrev.01/
> OpenJDK 8 changeset: 
> http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/c6ef40024aa2
> 
> This patch has been in IcedTea 2.x since 2.6.1 (2015-07-21).
> 
> It applies as-is to OpenJDK 7. Despite the description, it's necessary
> for me to build Zero on x86_64 with GCC 5.3.
> 
> Ok to push?

Looks fine to me.

Thanks,
Omair

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681


hg: jdk7u/jdk7u/hotspot: 8087120: [GCC5] java.lang.StackOverflowError on Zero JVM initialization on non x86 platforms.

2016-04-14 Thread gnu . andrew
Changeset: 3c694533a19c
Author:sgehwolf
Date:  2015-06-12 16:09 +0100
URL:   http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/3c694533a19c

8087120: [GCC5] java.lang.StackOverflowError on Zero JVM initialization on non 
x86 platforms.
Summary: Use __builtin_frame_address(0) rather than returning address of local 
variable.
Reviewed-by: dholmes

! src/os_cpu/linux_zero/vm/os_linux_zero.cpp



Re: [PATCH] 8087120: [GCC5] java.lang.StackOverflowError on Zero JVM initialization on non x86 platforms

2016-04-14 Thread Andrew Hughes


- Original Message -
> * Andrew Hughes  [2016-04-14 14:52]:
> > Webrev: http://cr.openjdk.java.net/~andrew/jdk7u/8087120/webrev.01/
> > OpenJDK 8 changeset:
> > http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/c6ef40024aa2
> > 
> > This patch has been in IcedTea 2.x since 2.6.1 (2015-07-21).
> > 
> > It applies as-is to OpenJDK 7. Despite the description, it's necessary
> > for me to build Zero on x86_64 with GCC 5.3.
> > 
> > Ok to push?
> 
> Looks fine to me.
> 
> Thanks,
> Omair
> 
> --
> PGP Key: 66484681 (http://pgp.mit.edu/)
> Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681
> 

Thanks! Pushed:

http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/3c694533a19c
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222




[PATCH] 8081475: SystemTap does not work when JDK is compiled with GCC 5

2016-04-14 Thread Andrew Hughes
Webrev: http://cr.openjdk.java.net/~andrew/jdk7u/8081475/webrev.01/
OpenJDK 8 changeset: 
http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/42c0a8631742

This patch has been in IcedTea 2.x since 2.6.0 (2015-07-17).

It applies as-is to OpenJDK 7 and is a simple correction of the
version check to account for major versions of GCC > 4.

Ok to push?

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222