Re: Review request for JDK-8027709: JDK8 docs on -XX:CompileOnly option are incorrect
Hi Vladimir! The option descriptions were reviewed numerous times by various members of the hotspot team. I updated the webrev with the new Xcomp description. Other changes remained the same. Do you approve? *Kumar*, do you approve the changes? Best regards, Alexey Zhebel On 11.12.2013 5:07, Vladimir Kozlov wrote: Who did review of other flags description? I see that description of -Xcomp is also incorrect - it does not disable Interpreter, methods still can be executed in it. Also JIT compiler does not execute methods. I think it should be: -Xcomp Force methods compilation on first invocation. By default, methods are compiled after number of interpreted method invocations. For example, for Client VM (-client) it is 1000 invocations and for Server VM (-server) it is 1. Interpreted method invocations are used to gather information for efficient compilation. Use the -Xcomp flag to get compiled methods as soon as possible at the expense of efficiency. You can also change the number of interpreted method invocations before compilation using the -XX:CompileThreshold option. I was only asking to display the text which you want to review. It looks fine. Thanks, Vladimir Here is man page text: -XX:CompileCommand=command,method[,option] Specifies a command to perform on a method. For example, to exclude the indexOf() method of the String class from being compiled, use the following: -XX:CompileCommand=exclude,java/lang/String.indexOf Note that the full class name is specified, including all packages and subpackages separated by a slash (/). For easier cut and paste operations, it is also possible to use the method name format produced by the -XX:+PrintCompilation and -XX:+LogCompilation options: -XX:CompileCommand=exclude,java.lang.String::indexOf If the method is specified without the signature, the command will be applied to all methods with the specified name. However, you can also specify the signature of the method in the class file format. In this case, you should enclose the arguments in quotation marks, because otherwise the shell treats the semicolon as command end. For example, if you want to exclude only the indexOf(String) method of the String class from being compiled, use the following: -XX:CompileCommand="exclude,java/lang/String.indexOf,(Ljava/lang/Strin g;)I" You can also use the asterisk (*) as a wilcard for class and method names. For example, to exclude all indexOf() methods in all classes from being compiled, use the following: -XX:CompileCommand=exclude,*.indexOf The commas and periods are aliases for spaces, making it easier to pass compiler commands through a shell. You can pass arguments to -XX:CompileCommand using spaces as separators by enclosing the argument in quotation marks: -XX:CompileCommand="exclude java/lang/String indexOf" Note that after parsing the commands passed on the command line using the -XX:CompileCommand options, the JIT compiler then reads commands from the .hotspot_compiler file. You can add commands to this file or specify a different file using the -XX:CompileCommandFile option. To add several commands, either specify the -XX:CompileCommand option multiple times, or separate each argument with the newline separator (\n). The following commands are available: break Set a breakpoint when debugging the JVM to stop at the beginning of compilation of the specified method. compileonly Exclude all methods from compilation except for the specified method. As an alternative, you can use the -XX:CompileOnly option, which allows to specify several methods. dontinline Prevent inlining of the specified method. exclude Exclude the specified method from compilation. help Print a help message for the -XX:CompileCommand option. inline Attempt to inline the specified method. log Exclude compilation logging (with the -XX:+LogCompilation option) for all methods except for the specified method. By default, logging is performed for all compiled methods. option This command can be used to pass a JIT compilation option to the specified method in place of the last argument (option). The compilation option i
Re: Review request for JDK-8027709: JDK8 docs on -XX:CompileOnly option are incorrect
On 12/11/13 8:55 AM, alexey zhebel wrote: Hi Vladimir! The option descriptions were reviewed numerous times by various members of the hotspot team. I updated the webrev with the new Xcomp description. Other changes remained the same. Do you approve? Yes. Vladimir *Kumar*, do you approve the changes? Best regards, Alexey Zhebel On 11.12.2013 5:07, Vladimir Kozlov wrote: Who did review of other flags description? I see that description of -Xcomp is also incorrect - it does not disable Interpreter, methods still can be executed in it. Also JIT compiler does not execute methods. I think it should be: -Xcomp Force methods compilation on first invocation. By default, methods are compiled after number of interpreted method invocations. For example, for Client VM (-client) it is 1000 invocations and for Server VM (-server) it is 1. Interpreted method invocations are used to gather information for efficient compilation. Use the -Xcomp flag to get compiled methods as soon as possible at the expense of efficiency. You can also change the number of interpreted method invocations before compilation using the -XX:CompileThreshold option. I was only asking to display the text which you want to review. It looks fine. Thanks, Vladimir Here is man page text: -XX:CompileCommand=command,method[,option] Specifies a command to perform on a method. For example, to exclude the indexOf() method of the String class from being compiled, use the following: -XX:CompileCommand=exclude,java/lang/String.indexOf Note that the full class name is specified, including all packages and subpackages separated by a slash (/). For easier cut and paste operations, it is also possible to use the method name format produced by the -XX:+PrintCompilation and -XX:+LogCompilation options: -XX:CompileCommand=exclude,java.lang.String::indexOf If the method is specified without the signature, the command will be applied to all methods with the specified name. However, you can also specify the signature of the method in the class file format. In this case, you should enclose the arguments in quotation marks, because otherwise the shell treats the semicolon as command end. For example, if you want to exclude only the indexOf(String) method of the String class from being compiled, use the following: -XX:CompileCommand="exclude,java/lang/String.indexOf,(Ljava/lang/Strin g;)I" You can also use the asterisk (*) as a wilcard for class and method names. For example, to exclude all indexOf() methods in all classes from being compiled, use the following: -XX:CompileCommand=exclude,*.indexOf The commas and periods are aliases for spaces, making it easier to pass compiler commands through a shell. You can pass arguments to -XX:CompileCommand using spaces as separators by enclosing the argument in quotation marks: -XX:CompileCommand="exclude java/lang/String indexOf" Note that after parsing the commands passed on the command line using the -XX:CompileCommand options, the JIT compiler then reads commands from the .hotspot_compiler file. You can add commands to this file or specify a different file using the -XX:CompileCommandFile option. To add several commands, either specify the -XX:CompileCommand option multiple times, or separate each argument with the newline separator (\n). The following commands are available: break Set a breakpoint when debugging the JVM to stop at the beginning of compilation of the specified method. compileonly Exclude all methods from compilation except for the specified method. As an alternative, you can use the -XX:CompileOnly option, which allows to specify several methods. dontinline Prevent inlining of the specified method. exclude Exclude the specified method from compilation. help Print a help message for the -XX:CompileCommand option. inline Attempt to inline the specified method. log Exclude compilation logging (with the -XX:+LogCompilation option) for all methods except for the specified method. By default, logging is performed for all compiled methods. option This command can be used to pass a JIT compilation option to the specified method in place of the
RE: Managing parallel change in JDK 8 and JDK 9
> Iris -- As you create the initial JDK 9 forest, please tag the tip of each > repository with "jdk9-b00". That will make it easy to identify the point at > which the JDK 9 code line forked from JDK 8. Thanks. Ok. iris
hg: jdk8/jdk8: 8029515: Building multiple configurations fails after removal of old build system
Changeset: cd3825b29830 Author:ihse Date: 2013-12-09 14:43 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/cd3825b29830 8029515: Building multiple configurations fails after removal of old build system Reviewed-by: erikj ! Makefile ! make/MakeHelpers.gmk
hg: jdk8/jdk8/jdk: 8029616: Update jdeps man page to include a new -jdkinternals option
Changeset: d31cd980e1da Author:rgallard Date: 2013-12-10 15:20 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/d31cd980e1da 8029616: Update jdeps man page to include a new -jdkinternals option Reviewed-by: mchung ! src/bsd/doc/man/jdeps.1 ! src/linux/doc/man/jdeps.1 ! src/solaris/doc/sun/man/man1/jdeps.1
