[GitHub] [db-jdo] sonarcloud[bot] commented on pull request #74: JDO 826 - Fix @Convert javadoc for types

2023-04-08 Thread via GitHub


sonarcloud[bot] commented on PR #74:
URL: https://github.com/apache/db-jdo/pull/74#issuecomment-1500862018

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=74)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=74&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=74&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=74&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=74&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=74&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=74&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=74&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=74&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=74&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=74&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=74&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=74&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=74)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=74&metric=duplicated_lines_density&view=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [db-jdo] tzaeschke opened a new pull request, #74: JDO 826 - Fix @Convert javadoc for types

2023-04-08 Thread via GitHub


tzaeschke opened a new pull request, #74:
URL: https://github.com/apache/db-jdo/pull/74

   Remove claim that @Convert can be put on types. See 
https://issues.apache.org/jira/browse/JDO-826.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (JDO-709) Standardize field/property converters

2023-04-08 Thread Jira


[ 
https://issues.apache.org/jira/browse/JDO-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709870#comment-17709870
 ] 

Tilmann Zäschke commented on JDO-709:
-

The discussion about  @Target(ElementType.TYPE,...) has been moved to a 
separate ticket, concluding that we remove it from the javadoc until an 
implementation is available: 
[JDO-826|https://issues.apache.org/jira/browse/JDO-826]

> Standardize field/property converters
> -
>
> Key: JDO-709
> URL: https://issues.apache.org/jira/browse/JDO-709
> Project: JDO
>  Issue Type: New Feature
>  Components: api, specification, tck
>Reporter: Matthew T. Adams
>Assignee: Craig L Russell
>Priority: Minor
>  Labels: converstion, converter, jdo, type, type-converter
> Fix For: JDO 3.2
>
> Attachments: JDO-709-01.patch, JDO-709-3.patch, JDO-709-4.patch
>
>
> This request is to standardize a user's ability to specify conversions of 
> fields or properties of persistence-capable classes.  Currently, this is left 
> to vendor extensions.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (JDO-826) @Convert Javadoc indicates support for @Target(ElementType.TYPE,...)

2023-04-08 Thread Jira
Tilmann Zäschke created JDO-826:
---

 Summary: @Convert Javadoc indicates support for 
@Target(ElementType.TYPE,...)
 Key: JDO-826
 URL: https://issues.apache.org/jira/browse/JDO-826
 Project: JDO
  Issue Type: Bug
  Components: api
Affects Versions: JDO 3.2
Reporter: Tilmann Zäschke
 Fix For: JDO 3.2.2


The javadoc of the @Convert annotation claims that it can be placed on types, 
e.g.
{code:java}
@Convert(value = ConvertiblePointToStringConverter.class)
public class ConvertiblePoint {
  ...
}
{code}
While this feature is desirable, there is currently no implementation of it in 
the reference implementation.



For now, the javadoc should be fixed by removing the section about 
@Target(ElementType.TYPE,...).

Once the implementation is resourced (volunteers welcome!) the section can be 
put back in place.

 

Context:
 * Original discussion: 
[JDO-709|https://issues.apache.org/jira/browse/JDO-709], starting 2022-10-17
 * PR by original problem reporter: [https://github.com/apache/db-jdo/pull/60]
 * Copy of original PR with additional TCK test: 
[https://github.com/apache/db-jdo/pull/61]
 * Tickets with problem description on reference implementation: 
[https://github.com/datanucleus/datanucleus-api-jdo/issues/127]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)