[jenkinsci/p4-plugin] 5b75e1: P4Groovy run() now finds credentials in folders

2019-09-30 Thread Paul Allen
  Branch: refs/heads/master
  Home:   https://github.com/jenkinsci/p4-plugin
  Commit: 5b75e11435837f1e918232db81e832494f2363f9
  
https://github.com/jenkinsci/p4-plugin/commit/5b75e11435837f1e918232db81e832494f2363f9
  Author: Joel Brown 
  Date:   2019-08-18 (Sun, 18 Aug 2019)

  Changed paths:
M 
src/main/java/org/jenkinsci/plugins/p4/credentials/P4InvalidCredentialException.java
M src/main/java/org/jenkinsci/plugins/p4/groovy/GetP4.java
M src/main/java/org/jenkinsci/plugins/p4/groovy/GetP4Task.java
M src/main/java/org/jenkinsci/plugins/p4/groovy/P4Groovy.java
M src/main/java/org/jenkinsci/plugins/p4/groovy/P4GroovyTask.java
M src/main/java/org/jenkinsci/plugins/p4/tasks/AbstractTask.java
M src/test/java/org/jenkinsci/plugins/p4/groovy/P4GroovyTest.java

  Log Message:
  ---
  P4Groovy run() now finds credentials in folders

Fix JENKINS-58745. The credential is now looked
up when p4 is instantiated as we know about the
context (Job) at that time.


  Commit: 8713635d5b82997521a094b10287b5ddde7212f8
  
https://github.com/jenkinsci/p4-plugin/commit/8713635d5b82997521a094b10287b5ddde7212f8
  Author: Paul Allen 
  Date:   2019-08-19 (Mon, 19 Aug 2019)

  Changed paths:
M 
src/main/java/org/jenkinsci/plugins/p4/credentials/P4InvalidCredentialException.java
M src/main/java/org/jenkinsci/plugins/p4/groovy/GetP4.java
M src/main/java/org/jenkinsci/plugins/p4/groovy/GetP4Task.java
M src/main/java/org/jenkinsci/plugins/p4/groovy/P4Groovy.java
M src/main/java/org/jenkinsci/plugins/p4/groovy/P4GroovyTask.java
M src/main/java/org/jenkinsci/plugins/p4/tasks/AbstractTask.java
M src/test/java/org/jenkinsci/plugins/p4/groovy/P4GroovyTest.java

  Log Message:
  ---
  Simplification of change.

I think this should work the same and avoid a copy of both a credential string 
and base class.


  Commit: 9d534b6a8f3d886908f020469c5b373f236016f8
  
https://github.com/jenkinsci/p4-plugin/commit/9d534b6a8f3d886908f020469c5b373f236016f8
  Author: Joel Brown <54191633+joel-f-br...@users.noreply.github.com>
  Date:   2019-08-20 (Tue, 20 Aug 2019)

  Changed paths:
M 
src/main/java/org/jenkinsci/plugins/p4/credentials/P4InvalidCredentialException.java
M src/main/java/org/jenkinsci/plugins/p4/groovy/GetP4.java
M src/main/java/org/jenkinsci/plugins/p4/groovy/GetP4Task.java
M src/main/java/org/jenkinsci/plugins/p4/groovy/P4Groovy.java
M src/main/java/org/jenkinsci/plugins/p4/groovy/P4GroovyTask.java
M src/main/java/org/jenkinsci/plugins/p4/tasks/AbstractTask.java
M src/test/java/org/jenkinsci/plugins/p4/groovy/P4GroovyTest.java

  Log Message:
  ---
  Merge pull request #1 from joel-f-brown/rver

Credentials handling for Folders when using P4Groovy


  Commit: 985929eb70ef02580b781c6994deba467f0c2607
  
https://github.com/jenkinsci/p4-plugin/commit/985929eb70ef02580b781c6994deba467f0c2607
  Author: Joel Brown 
  Date:   2019-08-20 (Tue, 20 Aug 2019)

  Changed paths:
M 
src/main/java/org/jenkinsci/plugins/p4/credentials/P4InvalidCredentialException.java
M src/main/java/org/jenkinsci/plugins/p4/groovy/GetP4.java
M src/main/java/org/jenkinsci/plugins/p4/groovy/GetP4Task.java

  Log Message:
  ---
  Credentials handling for Folders when using P4Groovy

Use Run to determine the credentials in GetP4Task, then pass the
P4BaseCredentials instead of the credentials ID.

Now the P4Groovy getConnection() method uses the P4BaseCredentials
instead of looking up the credentials from the active Jenkins instance.


  Commit: 4560eb1975287982681d7403eb173828319a2469
  
https://github.com/jenkinsci/p4-plugin/commit/4560eb1975287982681d7403eb173828319a2469
  Author: Paul Allen 
  Date:   2019-09-30 (Mon, 30 Sep 2019)

  Changed paths:
M 
src/main/java/org/jenkinsci/plugins/p4/credentials/P4InvalidCredentialException.java
M src/main/java/org/jenkinsci/plugins/p4/groovy/GetP4.java
M src/main/java/org/jenkinsci/plugins/p4/groovy/GetP4Task.java
M src/main/java/org/jenkinsci/plugins/p4/groovy/P4Groovy.java
M src/main/java/org/jenkinsci/plugins/p4/groovy/P4GroovyTask.java
M src/main/java/org/jenkinsci/plugins/p4/tasks/AbstractTask.java
M src/test/java/org/jenkinsci/plugins/p4/groovy/P4GroovyTest.java

  Log Message:
  ---
  Merge pull request #108 from joel-f-brown/master

Credentials handling for Folders when using P4Groovy.

Use run to determine the credentials in GetP4Task, then pass the 
P4BaseCredentials instead of the credentials ID.

Now the P4Groovy getConnection() method uses the P4BaseCredentials instead of 
looking up the credentials from the active Jenkins instance.

JENKINS-58745 JENKINS-57314


Compare: 
https://github.com/jenkinsci/p4-plugin/compare/9d65ce54fda3...4560eb197528

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to 

[jenkinsci/p4-plugin] 5b75e1: P4Groovy run() now finds credentials in folders

2019-08-19 Thread Paul Allen
  Branch: refs/heads/pr/106
  Home:   https://github.com/jenkinsci/p4-plugin
  Commit: 5b75e11435837f1e918232db81e832494f2363f9
  
https://github.com/jenkinsci/p4-plugin/commit/5b75e11435837f1e918232db81e832494f2363f9
  Author: Joel Brown 
  Date:   2019-08-18 (Sun, 18 Aug 2019)

  Changed paths:
M 
src/main/java/org/jenkinsci/plugins/p4/credentials/P4InvalidCredentialException.java
M src/main/java/org/jenkinsci/plugins/p4/groovy/GetP4.java
M src/main/java/org/jenkinsci/plugins/p4/groovy/GetP4Task.java
M src/main/java/org/jenkinsci/plugins/p4/groovy/P4Groovy.java
M src/main/java/org/jenkinsci/plugins/p4/groovy/P4GroovyTask.java
M src/main/java/org/jenkinsci/plugins/p4/tasks/AbstractTask.java
M src/test/java/org/jenkinsci/plugins/p4/groovy/P4GroovyTest.java

  Log Message:
  ---
  P4Groovy run() now finds credentials in folders

Fix JENKINS-58745. The credential is now looked
up when p4 is instantiated as we know about the
context (Job) at that time.


  Commit: 8713635d5b82997521a094b10287b5ddde7212f8
  
https://github.com/jenkinsci/p4-plugin/commit/8713635d5b82997521a094b10287b5ddde7212f8
  Author: Paul Allen 
  Date:   2019-08-19 (Mon, 19 Aug 2019)

  Changed paths:
M 
src/main/java/org/jenkinsci/plugins/p4/credentials/P4InvalidCredentialException.java
M src/main/java/org/jenkinsci/plugins/p4/groovy/GetP4.java
M src/main/java/org/jenkinsci/plugins/p4/groovy/GetP4Task.java
M src/main/java/org/jenkinsci/plugins/p4/groovy/P4Groovy.java
M src/main/java/org/jenkinsci/plugins/p4/groovy/P4GroovyTask.java
M src/main/java/org/jenkinsci/plugins/p4/tasks/AbstractTask.java
M src/test/java/org/jenkinsci/plugins/p4/groovy/P4GroovyTest.java

  Log Message:
  ---
  Simplification of change.

I think this should work the same and avoid a copy of both a credential string 
and base class.


Compare: 
https://github.com/jenkinsci/p4-plugin/compare/5b75e1143583%5E...8713635d5b82

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/p4-plugin/push/refs/heads/pr/106/00-871363%40github.com.