Branch: refs/heads/release/1.x

  Home:   https://github.com/jenkinsci/stashnotifier-plugin

  Commit: b2ffc5e553783f9e1059e6fa80df1d0c88036ff5

      
https://github.com/jenkinsci/stashnotifier-plugin/commit/b2ffc5e553783f9e1059e6fa80df1d0c88036ff5

  Author: René Scheibe <rene.sche...@gmail.com>

  Date:   2020-01-05 (Sun, 05 Jan 2020)



  Changed paths:

    M src/main/java/org/jenkinsci/plugins/stashNotifier/StashNotifier.java

    M src/test/java/org/jenkinsci/plugins/stashNotifier/StashNotifierTest.java



  Log Message:

  -----------

  Inline "lookupCredentials" methods



There was a mix of the `lookupCredentials` wrapper methods and using

`CredentialsProvider#lookupCredentials` directly. This also resulted

in different ways of mocking these calls in the tests.



As the mentioned methods were originally introduced for mocking purposes

and PowerMockito now is anyway used in the tests to mock static methods,

there is no need for these wrapper methods anymore.





  Commit: c5916d94e4e2e46b6b32f64e997277f3baeaaa64

      
https://github.com/jenkinsci/stashnotifier-plugin/commit/c5916d94e4e2e46b6b32f64e997277f3baeaaa64

  Author: Pavel Batanov <pa...@batanov.me>

  Date:   2020-01-06 (Mon, 06 Jan 2020)



  Changed paths:

    M src/main/java/org/jenkinsci/plugins/stashNotifier/StashNotifier.java

    M src/test/java/org/jenkinsci/plugins/stashNotifier/StashNotifierTest.java



  Log Message:

  -----------

  Merge pull request #256 from darxriggs/inline-credentials-lookup



Inline "lookupCredentials" methods





Compare: 
https://github.com/jenkinsci/stashnotifier-plugin/compare/6a531be2d2dd...c5916d94e4e2

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stashnotifier-plugin/push/refs/heads/release/1.x/6a531b-c5916d%40github.com.

Reply via email to