Re: JEP proposal: Removing user-facing scripting features from core

[Kohsuke Kawaguchi]

Is this any different from all the other extractions of features into
plugins? I guess back then we used to bundle those extracted stuff as
bundled plugins?

On Tue, Nov 14, 2017 at 4:30 AM Jesse Glick  wrote:

> On Mon, Nov 13, 2017 at 6:25 AM, Daniel Beck  wrote:
> > Would https://github.com/jenkinsci/jenkins/pull/3006 (the goal,
> rationale etc., not the implementation details) have a chance as a JEP
>
> Yes.
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr0gbewh3Zs%2BMDPZ9C7KBz%3DbE%2BvP_YES51zU5siv6EMp%2Bw%40mail.gmail.com
> .
> For more options, visit https://groups.google.com/d/optout.
>
-- 
Kohsuke Kawaguchi

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAN4CQ4xcVzM-Awpn67phaDhkqwhOda58yo9KXj6OoX7nQR1ifg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: [configuration-as-code] Descriptors configuration

[nicolas de loof]

This is a comparable issue indeed, even this applies to  updateByXml. not
configure(json)
https://github.com/jenkinsci/jenkins/pull/2736 is a promising approach, but
is discovering attributes via reflection, while configuration-as-code is
looking at ui-bound parameters. In many case they are the same but not
always the case. Anyway this gives me some inspiration to propose a fix.

2017-11-13 21:45 GMT+01:00 Daniel Beck :

>
> > On 13. Nov 2017, at 20:26, Jesse Glick  wrote:
> >
> >>
> >> if I UNCHECK the optional property, no "authentication" value
> >> is posted to JSON form, and I don't get SMTPAuthentication reset to
> null in
> >> my descriptor.
> >
> > Unfortunately your `configure` override must start by setting any
> > optional struct fields to null:
>
> Is this just JENKINS-21017 again, or something else?
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/jenkinsci-dev/230C492B-23E2-4816-BB0A-5647E749AB15%40beckweb.net.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANMVJznZpTa%2B7_uC8NvoTd5fBW-33rMWpsaKkG8%2BupVVB5P-%3DA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: [configuration-as-code] Descriptors configuration

[Daniel Beck]

> On 13. Nov 2017, at 20:26, Jesse Glick  wrote:
> 
>> 
>> if I UNCHECK the optional property, no "authentication" value
>> is posted to JSON form, and I don't get SMTPAuthentication reset to null in
>> my descriptor.
> 
> Unfortunately your `configure` override must start by setting any
> optional struct fields to null:

Is this just JENKINS-21017 again, or something else?

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/230C492B-23E2-4816-BB0A-5647E749AB15%40beckweb.net.
For more options, visit https://groups.google.com/d/optout.

Re: JEP proposal: Removing user-facing scripting features from core

[Jesse Glick]

On Mon, Nov 13, 2017 at 6:25 AM, Daniel Beck  wrote:
> Would https://github.com/jenkinsci/jenkins/pull/3006 (the goal, rationale 
> etc., not the implementation details) have a chance as a JEP

Yes.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr0gbewh3Zs%2BMDPZ9C7KBz%3DbE%2BvP_YES51zU5siv6EMp%2Bw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: [configuration-as-code] Descriptors configuration

[Jesse Glick]

On Fri, Nov 10, 2017 at 3:54 AM, nicolas de loof
 wrote:
> I'll rewrite configure method as :
>
> public boolean configure(StaplerRequest req, JSONObject json) throws
> FormException {
> req.bindJSON(this, json);
> save();
> return true;
> }
>
> (by the way, shouldn't this be the default implementation ?)

Maybe. I already did this for `GlobalConfiguration`:

https://github.com/jenkinsci/jenkins/pull/2509

> if I UNCHECK the optional property, no "authentication" value
> is posted to JSON form, and I don't get SMTPAuthentication reset to null in
> my descriptor.

Unfortunately your `configure` override must start by setting any
optional struct fields to null:

https://github.com/jenkinsci/ui-samples-plugin/blob/7d0fe2b32204a7fe0ec6adb6815e65d48b0dd54e/src/main/java/jenkins/plugins/ui_samples/HeteroList.java#L81

> this configuration mechanism isn't atomic, and
> there's some possible race condition for related attributes to have
> inconsistent values seen from another thread while the configuration is
> being changed.

It is not a “possible” race condition; it is definitely a race
condition. Just how Jenkins works. Anyway this is a change you would
apply on Jenkins startup, not while stuff is running, right?

> considering recommended and well adopted approach to
> retrieve a Descriptor is to use
> Jenkins.getInstance.getDescriptor(describable), not referring to some final
> static constant

Some people (following Kohsuke’s lead) `@Inject` descriptors.

> I wonder we could get the Descriptor.configure mechanism to
> rely on @DataBoundConstructors just like Describable do.

I doubt that could be done compatibly. Would break assumptions deep in
`ExtensionList`. Anyway some `Descriptor`s maintain (transient) state,
etc.

Another style is to avoid `f:optionalProperty` and have an explicit
object representing the choice of no authentication, with a no-arg
`@DataBoundConstructor` and a `@Symbol`.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr1bGPXiOU6AKwSuVNMuKJmWHtJ0ZoahrKoKdDQigJdi_g%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: Backporting for LTS 2.89.1 started

[Oleg Nenashev]

Hi all,

Are we also open to consider out-of-order 2.73.4?

   - JENKINS-47909  - 
   Recover from legacy user configuration folders with $ characters that 
   are not part of hex escape sequences - Regression in 2.73.3 due to the 
   security fix
   - JENKINS-47448  - 
   Oracle JDK Installer strikes back

We still have more than 3 weeks before the next LTS, and this two issues 
may put some pressure on updating users.



BR, Oleg


пятница, 10 ноября 2017 г., 11:00:13 UTC+1 пользователь ogondza написал:
>
> Backporting has started and the RC is scheduled for 2017-11-22. Note 
> that schedule for .2 might be modified as keeping the constant pace 
> would require the RC testing during holidays. 
>
> Candidates: https://issues.jenkins-ci.org/issues/?filter=12146 
> Fixed: 
> https://issues.jenkins-ci.org/issues/?jql=labels%20%3D%202.89.1-fixed 
> Rejected: 
> https://issues.jenkins-ci.org/issues/?jql=labels%20%3D%202.89.1-rejected 
> -- 
> oliver 
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/a91ae866-f0c2-4c05-a1c8-822d469d7812%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: JEP proposal: Removing user-facing scripting features from core

[Oleg Nenashev]

Personally I am +1 about **considering** it. My main concern is that Groovy 
logic is being often [mis]used by configuration management tools, e.g. to 
install plugins by CLI calls. If we remove CLI handlers from the core, I 
would expect it to cause some collateral damage on this scenarios. IMHO it 
needs a wider poll via Users mailing list and blog post once CI is accepted 
as a draft.

Regarding keeping Groovy in the core, we need a pluggable core components 
story (JENKINS-41196 ) 
to be delivered for that. Groovy Init Hooks are critical to Jenkins 
environments, and this part should not be detached to plugins IMHO.

BR, Oleg


понедельник, 13 ноября 2017 г., 17:52:06 UTC+1 пользователь Daniel Beck 
написал:
>
>
> > On 13. Nov 2017, at 17:40, R. Tyler Croy  > wrote: 
> > 
> > What impact does this have on the Script Console or the CLI, both of 
> which 
> > expose scripting functionality? 
>
> The "Script Console" and groovy/groovysh CLI commands (and more) would be 
> moved into a plugin, so OOTB, Jenkins would have no text fields taking 
> 'system' Groovy for management purposes. 
>
> The idea is that with that plugin, the exact same features will be 
> available, but without it, you don't have them. Implementation TBD. 
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/80102361-9d82-43da-b254-e85909d7a238%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Proposed BDFL-Delegate for JEP-2: Daniel Beck

[Oleg Nenashev]

I am fine with that.

понедельник, 13 ноября 2017 г., 17:46:16 UTC+1 пользователь R Tyler Croy 
написал:
>
>
> JEP-2 is an informational JEP to capture the initial plugin suggestion 
> criteria 
> we included in Jenkins 2 for posterity. 
> https://github.com/jenkinsci/jep/tree/master/jep/2 
>
> Since Daniel originally led this, and it's just an informational JEP, I 
> propose 
> that he act as the BDFL-Delegate to bang the gavel once JEP-2 properly 
> captures 
> what we originally agreed upon in those olden days before Jenkins 2 :) 
>
>
> Cheers 
> - R. Tyler Croy 
>
> -- 
>  Code:  
>   Chatter:  
>  xmpp: rty...@jabber.org  
>
>   % gpg --keyserver keys.gnupg.net --recv-key 1426C7DC3F51E16F 
> -- 
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/93654ab5-c9c4-431f-9401-8df59398bc26%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: JEP proposal: Removing user-facing scripting features from core

[Daniel Beck]

> On 13. Nov 2017, at 17:40, R. Tyler Croy  wrote:
> 
> What impact does this have on the Script Console or the CLI, both of which
> expose scripting functionality?

The "Script Console" and groovy/groovysh CLI commands (and more) would be moved 
into a plugin, so OOTB, Jenkins would have no text fields taking 'system' 
Groovy for management purposes.

The idea is that with that plugin, the exact same features will be available, 
but without it, you don't have them. Implementation TBD.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/ECBD1D88-F939-42FC-835B-324C9C1F261E%40beckweb.net.
For more options, visit https://groups.google.com/d/optout.

Proposed BDFL-Delegate for JEP-2: Daniel Beck

[R. Tyler Croy]

JEP-2 is an informational JEP to capture the initial plugin suggestion criteria
we included in Jenkins 2 for posterity.
https://github.com/jenkinsci/jep/tree/master/jep/2

Since Daniel originally led this, and it's just an informational JEP, I propose
that he act as the BDFL-Delegate to bang the gavel once JEP-2 properly captures
what we originally agreed upon in those olden days before Jenkins 2 :)


Cheers
- R. Tyler Croy

--
 Code: 
  Chatter: 
 xmpp: rty...@jabber.org

  % gpg --keyserver keys.gnupg.net --recv-key 1426C7DC3F51E16F
--

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/20171113164602.xja56s334qglaqvn%40blackberry.coupleofllamas.com.
For more options, visit https://groups.google.com/d/optout.


signature.asc
Description: PGP signature

Re: JEP proposal: Removing user-facing scripting features from core

[R. Tyler Croy]

(replies inline)

On Mon, 13 Nov 2017, Daniel Beck wrote:

> Hi everyone,
> 
> This is a pre-JEP check[1]: Would 
> https://github.com/jenkinsci/jenkins/pull/3006 (the goal, rationale etc., not 
> the implementation details) have a chance as a JEP, or is it a waste of time?


What impact does this have on the Script Console or the CLI, both of which
expose scripting functionality?

I might not be educated enough to understand the nuance of "removing scripting"
which somehow still leaves Groovy in core, and features like init.groovy.d/.
Can you elaborate a bit more on what features/functionalities are being
proposed for extraction here?


Cheers
- R. Tyler Croy

--
 Code: 
  Chatter: 
 xmpp: rty...@jabber.org

  % gpg --keyserver keys.gnupg.net --recv-key 1426C7DC3F51E16F
--

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/20171113164050.cbb7s6wbkqmp4ur4%40blackberry.coupleofllamas.com.
For more options, visit https://groups.google.com/d/optout.


signature.asc
Description: PGP signature

JEP proposal: Removing user-facing scripting features from core

[Daniel Beck]

Hi everyone,

This is a pre-JEP check[1]: Would 
https://github.com/jenkinsci/jenkins/pull/3006 (the goal, rationale etc., not 
the implementation details) have a chance as a JEP, or is it a waste of time?

Thanks,
Daniel

1: https://github.com/jenkinsci/jep/tree/master/jep/1#discussion

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/13F744D4-88B0-43CE-A07E-F818625BF758%40beckweb.net.
For more options, visit https://groups.google.com/d/optout.

Re: Failed to build js-lib plugins from source

[Ravi H K]

Can anyone please have a lookinto this and let me know any 
thoughts/suggestions?

On Monday, November 6, 2017 at 1:19:53 PM UTC+5:30, Ravi H K wrote:
>
> Hi am trying to build plugins ace-editor,handlebars,momentjs 
> and jquery-detached plugins.from source code 
> https://github.com/jenkinsci/js-libs
> But few files are not getting genreted inside *.hpi files.I noticed few 
> thing like when executing maven command am getting warning messages.
>
> Steps are followed:
> 1, git clone https://github.com/jenkinsci/js-libs
> 2. Execute "mvn clean install"
> 3. Mvn command execution is successful but it shows few warnings bec of 
> this it's not building few files.
> Maven console log:
>
> Cbash-4.2# mvn clean install
> [INFO] Scanning for projects...
> [WARNING] The POM for org.jenkins-ci.tools:maven-hpi-plugin:jar:2.0 is 
> missing, no dependency information available
> [WARNING] Failed to build parent project for 
> org.jenkins-ci.ui:js-module-base:pom:1.2.1
> [WARNING]
> [WARNING] Some problems were encountered while building the effective 
> model for org.jenkins-ci.ui:js-module-base:pom:1.2.1
> [WARNING] 'profiles.profile[copy-jsmodules].activation.file.exists' Failed 
> to interpolate file location ${project.basedir}/src/main/webapp/jsmodules 
> for profile copy-jsmodules: ${project.basedir} expression not supported 
> during profile activation, use ${basedir} instead
> [WARNING]
> [WARNING] Some problems were encountered while building the effective 
> model for org.jenkins-ci.ui:jquery-detached:hpi:1.2.1
> [WARNING] 'profiles.profile[copy-jsmodules].activation.file.exists' Failed 
> to interpolate file location ${project.basedir}/src/main/webapp/jsmodules 
> for profile copy-jsmodules: ${project.basedir} expression not supported 
> during profile activation, use ${basedir} instead @ 
> org.jenkins-ci.ui:js-module-base:1.2.1, /tmp/js-libs/js-module-base/pom.xml
> [WARNING]
> [WARNING] It is highly recommended to fix these problems because they 
> threaten the stability of your build.
> [WARNING]
> [WARNING] For this reason, future Maven versions might no longer support 
> building such malformed projects.
> [WARNING]
>
> Missing files respective of plugins.
> 1. Jquery Detached.
>  jsmodules/jqueryui1.js
>  jsmodules/jquery2.js
>  jsmodules/jqueryui1/style.css
>
> 2. ace-editor:Below are missing files
> jsmodules/
> jsmodules/ace-editor-119.js
> jsmodules/ace-editor-122.js
> jsmodules/test.js
>
> 3. MomentSj 
> jsmodules/momentjs2.js
>
> 4. HandleBar
> jsmodules/handlebars3.js
>
> Could anyone please help me out here.
>
>
>
>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/030e0f9b-7e52-4c27-ac32-c7c42c0500d8%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.