Re: Adopting jUnit Attachments Plugin

[Peter John Hampton]

I also disagree. I reckon the best way is to assign the maintainer (however, 
this word seems rather loaded in Jenkins world). If the assignee doesn’t want 
to work on it for whatever reason they could free it up by unassigning and 
labelling the issue appropriately.

This seems like a separate discussion though. 

> On 14 Aug 2018, at 16:59, Slide  wrote:
> 
> I somewhat disagree with this, as I generally only see emails about issues if 
> I am assigned to it (maybe my settings are setup incorrectly somewhere?). If 
> I don't get emails, the issue will sit without me looking at it for a fairly 
> long period of time, which means the person could get discouraged in that 
> case as well since no one sees the issue.
> 
>> On Tue, Aug 14, 2018 at 8:56 AM Baptiste Mathus  wrote:
>> 
>> 
>>> Le jeu. 9 août 2018 à 23:47, Jesse Glick  a écrit :
>>> On Thu, Aug 9, 2018 at 12:57 PM Oleg Nenashev  
>>> wrote:
>>> > Should I also change the default assignee in JIRA?
>>> 
>>> I have no opinion about that. Generally I find the default assignee
>>> option to be a bad idea—you should assign an issue to yourself if and
>>> when you plan to actually work on it, or someone has a specific reason
>>> to think you are the one who _should_ work on it (for example because
>>> you introduced a regression). If a plugin has only ever had one
>>> maintainer, maybe it makes sense to just assume that any newly filed
>>> issue is going to be handled by them or not at all.
>> 
>> 
>> +1. I think there should not be a default assignee. It conveys the wrong 
>> message:
>> * That the assignee is going to look into the issue
>> * It probably hence discourages some people to try and propose a fix when 
>> they see someone is already working on it (they think)
>> 
>>> 
>>> -- 
>>> You received this message because you are subscribed to the Google Groups 
>>> "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an 
>>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr2hAyfHmpmJZwv_EAJoECZM8HxYx17eAvJJgcQ10A%3Dscw%40mail.gmail.com.
>>> For more options, visit https://groups.google.com/d/optout.
>> 
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS6W3t%2BEdqVY%3Dz3gvwMkq1LYk%3DXDoEM6gmW5mVGGGnSfhA%40mail.gmail.com.
>> For more options, visit https://groups.google.com/d/optout.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAPiUgVcqpRRwP9_XCA%2B8KMBmPmRErS5ZgErYPd5s6OBhESrhDw%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/5C1DA500-5BDC-4516-802B-5915D55A139C%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: Adopting jUnit Attachments Plugin

[Peter John Hampton]

Hey guys,

So I went through the open PRs and left some comments on the attachments
plugin. Nothing will conflict with strategic work. Saying that, you one of
you please add me as a collaborator to that repo - and jUnit so I can close
stuff out that has went stale and rerun CI stuff?

Thanks
Pete

On Tue, 7 Aug 2018 at 22:22, Peter John Hampton 
wrote:

> Hey Jesse!
>
> Thanks for getting back to me - that's fine re notifications. Yes, I do
> have Jenkins plugin development. I maintain a private plugin in work and
> I'm keen to get into more open work. Yeah, for sure - happy to help on
> *both* the jUnit and jUnit attachment plugins. I can indeed triage these
> and filter out the ones that have gone stale. See you on Github!
>
> Pete
>
> On Mon, 6 Aug 2018 at 15:01, Jesse Glick  wrote:
>
>> On Sun, Aug 5, 2018 at 5:30 AM Oleg Nenashev 
>> wrote:
>> > Many people receive more notifications from GitHub than they can
>> actually handle.
>>
>> In fact I do not see such pings at all, I am afraid.
>>
>> As to maintainership, I do not consider myself a maintainer. I may
>> have cut a 1.5 release to get some particular fixes in, since nobody
>> else was doing it.
>>
>> I *do* expect to be making (i.e., proposing) some substantial changes
>> to the plugin, probably in the upcoming weeks, in order to support
>> external test result storage. It is hard to say offhand if any of the
>> currently open PRs would seriously conflict with such work, though I
>> doubt it. More of concern to me is the high number of open PRs in the
>> `junit` plugin, which also seems to lack any active maintainer, but
>> due to its central place in Jenkins is quite sensitive—any regressions
>> will hit a lot of people.
>>
>> Pete do you have some Jenkins plugin development experience? You may
>> want to start off by triaging existing issue reports (reproducible?
>> still valid? etc.), and working through the open PRs—if they seem to
>> be accomplishing something important, get them mergeable against
>> `master` and make sure they have test coverage (i.e., something that
>> fails if you `git checkout master -- src/main && mvn clean test`). Or
>> filing new stuff for issues that interest you, etc. At any rate,
>> somebody paying attention to the plugin and tracking outstanding work
>> is a lot better than nobody, so thanks for anything you can do!
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr126%2BoaVrhvbiDR_%3Du_sOSaeAy2QJKttSoGtpf-o7um-w%40mail.gmail.com
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CABBGwxpZ5jZCETn_r%3DNd%3DGTjVnRjOjAvTMbC0U0eXCVSaMObVA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: Adopting jUnit Attachments Plugin

[Peter John Hampton]

Hey Jesse!

Thanks for getting back to me - that's fine re notifications. Yes, I do
have Jenkins plugin development. I maintain a private plugin in work and
I'm keen to get into more open work. Yeah, for sure - happy to help on
*both* the jUnit and jUnit attachment plugins. I can indeed triage these
and filter out the ones that have gone stale. See you on Github!

Pete

On Mon, 6 Aug 2018 at 15:01, Jesse Glick  wrote:

> On Sun, Aug 5, 2018 at 5:30 AM Oleg Nenashev 
> wrote:
> > Many people receive more notifications from GitHub than they can
> actually handle.
>
> In fact I do not see such pings at all, I am afraid.
>
> As to maintainership, I do not consider myself a maintainer. I may
> have cut a 1.5 release to get some particular fixes in, since nobody
> else was doing it.
>
> I *do* expect to be making (i.e., proposing) some substantial changes
> to the plugin, probably in the upcoming weeks, in order to support
> external test result storage. It is hard to say offhand if any of the
> currently open PRs would seriously conflict with such work, though I
> doubt it. More of concern to me is the high number of open PRs in the
> `junit` plugin, which also seems to lack any active maintainer, but
> due to its central place in Jenkins is quite sensitive—any regressions
> will hit a lot of people.
>
> Pete do you have some Jenkins plugin development experience? You may
> want to start off by triaging existing issue reports (reproducible?
> still valid? etc.), and working through the open PRs—if they seem to
> be accomplishing something important, get them mergeable against
> `master` and make sure they have test coverage (i.e., something that
> fails if you `git checkout master -- src/main && mvn clean test`). Or
> filing new stuff for issues that interest you, etc. At any rate,
> somebody paying attention to the plugin and tracking outstanding work
> is a lot better than nobody, so thanks for anything you can do!
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr126%2BoaVrhvbiDR_%3Du_sOSaeAy2QJKttSoGtpf-o7um-w%40mail.gmail.com
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CABBGwxp2KxAxX%3DqUe%3DZQ2aCbAkcAmPAw7qXmmJFaRchJVKhgBw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: Adopting jUnit Attachments Plugin

[Peter John Hampton]

Awesome. Thanks Oleg!

On Sun, 5 Aug 2018 at 10:30, Oleg Nenashev  wrote:

> Hello Pete,
>
> Thanks you for the interest! If you ping once in GitHub, the message may
> easily go missing.
> Many people receive more notifications from GitHub than they can actually
> handle.
> Do not hesitate to ping again.
>
> I will ask Jesse to take a look at this thread.
>
> BR, Oleg
>
> On Friday, August 3, 2018 at 12:41:25 AM UTC+2, peterjoh...@gmail.com
> wrote:
>>
>> Hey!
>>
>> I would love to adopt the junit attachments plugin and get more involved
>> with the Jenkins. I tried reaching out to the maintainer but I bet they are
>> super busy:
>> https://github.com/jenkinsci/junit-attachments-plugin/issues/20
>> 
>>
>>
>> It doesn't look like this plugin is being maintained though because it
>> has stale PRs.
>>
>> github: github.com/pjhampton
>> jenkins id: pjhampton
>>
>> Happy to discuss
>>
>> Thanks
>> Pete
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/5d967e7d-246b-4f4d-a1f4-4a188dfa59a1%40googlegroups.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CABBGwxqYWdZg0g0EmCL-oS1UpVmtDr%3D9cHN4c_UhhJwkD1njiw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.