[JIRA] (JENKINS-29977) Git Plugin truncates changelog
Title: Message Title Andrew Macks commented on JENKINS-29977 Re: Git Plugin truncates changelog So, my mistake was not to account for the indentation that was added in addition to the wrapping. This format works correctly: commit %H%ntree %T%nparent %P%nauthor %aN <%aE> %ai%ncommitter %cN <%cE> %ci%n%n%w(0,4,4)%s%n%n%b Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-29977) Git Plugin truncates changelog
Title: Message Title Andrew Macks commented on JENKINS-29977 Re: Git Plugin truncates changelog Nicolas: My sincerest apologies for that. I assigned it to you given the previous commit and regression. I'll continue looking into it directly myself. It seems that my previous suggestion does not work when compiled into the plugin (still investigating why locally). Thanks. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-29977) Git Plugin truncates changelog
Title: Message Title Andrew Macks assigned an issue to Nicolas De Loof Jenkins / JENKINS-29977 Git Plugin truncates changelog Change By: Andrew Macks Assignee: Nicolas De Loof Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-29977) Git Plugin truncates changelog
Title: Message Title
Andrew Macks edited a comment on JENKINS-29977
Re: Git Plugin truncates changelog
{{So, after tracking this issue for a while, and getting excited over the last couple of days with Chris' involvement, I got a little concerned when the issue became Unassigned again and decided to dig into it myself.}}{{It turns out that the issue is actually in git-client-plugin and not git-plugin at all. It appears to be caused by this commit:}} {{}} {code:java}commit de49c9bf21f560ac3851c4f7ea3a3597a114ac8eAuthor: Nicolas De Loof Date: Tue Feb 24 09:44:20 2015 +0100 [FIXED JENKINS-27097] use ISO-8601 in changelog Use an explicit format string (to mimic raw format) to enforce ISO-8601 date format. Side benefit is this format string should not be impacted if a future/exotic git CLI do introduce some subtle changes in format=raw output.{code} {{Basically, an arbitary format was specified for the git whatchanged format:}}{{commit %H%ntree %T%nparent %P%nauthor %aN <%aE> %ai%ncommitter %cN <%cE> %ci%n%n%w(76,4,4)%s%n%n%b}}{{The idea was good (to avoid changes in the format of the log pretty raw format), but it also introduced arbitrary wrapping early in the data processing which is probably not the correct place for it (altering the data during input).}}{{Changing this to:}}{{commit %H%ntree %T%nparent %P%nauthor %aN <%aE> %ai%ncommitter %cN <%cE> %ci%n%n%s%n%n%b}}{{fixes the issue.}}{{I don't personally have the environment setup to test this fully, so if somebody can take this information and act upon it, I would be greatly appreciative.}} {{ If there is the desire to maintain the existing (arbitrary) wrapping }} behaviour, then I would suggest adding some sort of flag that allows disabling the arbitrary wrapping. This should (hopefully) make everybody happy :)
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
[JIRA] (JENKINS-29977) Git Plugin truncates changelog
Title: Message Title
Andrew Macks commented on JENKINS-29977
Re: Git Plugin truncates changelog
So, after tracking this issue for a while, and getting excited over the last couple of days with Chris' involvement, I got a little concerned when the issue became Unassigned again and decided to dig into it myself. It turns out that the issue is actually in git-client-plugin and not git-plugin at all. It appears to be caused by this commit: {{}}
commit de49c9bf21f560ac3851c4f7ea3a3597a114ac8e
Author: Nicolas De Loof
Date: Tue Feb 24 09:44:20 2015 +0100
[FIXED JENKINS-27097] use ISO-8601 in changelog
Use an explicit format string (to mimic raw format)
to enforce ISO-8601 date format.
Side benefit is this format string should not be
impacted if a future/exotic git CLI do introduce
some subtle changes in format=raw output.
Basically, an arbitary format was specified for the git whatchanged format: commit %H%ntree %T%nparent %P%nauthor %aN <%aE> %ai%ncommitter %cN <%cE> %ci%n%n%w(76,4,4)%s%n%n%b The idea was good (to avoid changes in the format of the log pretty raw format), but it also introduced arbitrary wrapping early in the data processing which is probably not the correct place for it (altering the data during input). Changing this to: commit %H%ntree %T%nparent %P%nauthor %aN <%aE> %ai%ncommitter %cN <%cE> %ci%n%n%s%n%n%b fixes the issue. I don't personally have the environment setup to test this fully, so if somebody can take this information and act upon it, I would be greatly appreciative. {{If there is the desire to maintain the existing (arbitrary) wrapping }}behaviour, then I would suggest adding some sort of flag that allows disabling the arbitrary wrapping. This should (hopefully) make everybody happy
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
