[JIRA] (JENKINS-60723) Github PR from jenkins
Title: Message Title Brian Saville commented on JENKINS-60723 Re: Github PR from jenkins reddi sekhara, I own the GitHub Pull Request Comment Build Plugin, which is very different from the GHPRB plugin you are trying to configure. I've reassigned components, good luck. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.203972.1578646189000.6614.1578686460192%40Atlassian.JIRA.
[JIRA] (JENKINS-60723) Github PR from jenkins
Title: Message Title Brian Saville updated an issue Jenkins / JENKINS-60723 Github PR from jenkins Change By: Brian Saville Component/s: ghprb-plugin Component/s: github-pr-comment-build-plugin Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.203972.1578646189000.6610.1578686400306%40Atlassian.JIRA.
[JIRA] (JENKINS-60723) Github PR from jenkins
Title: Message Title Brian Saville assigned an issue to Unassigned Jenkins / JENKINS-60723 Github PR from jenkins Change By: Brian Saville Assignee: Brian Saville Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.203972.1578646189000.6612.1578686400358%40Atlassian.JIRA.
[JIRA] (JENKINS-58970) Backwards compatibility broken with version 2.3.0 for KV1
Title: Message Title Brian Saville commented on JENKINS-58970 Re: Backwards compatibility broken with version 2.3.0 for KV1 David Dumas, this sounds like a new problem unrelated to the actual problem fixed in this one, does that sound right? I could see how the summary might lead you to think it's the same issue, but the real problem for us is that the default engine version was 2 for everything instead of 1. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201317.1565984294000.6407.1566327780142%40Atlassian.JIRA.
[JIRA] (JENKINS-58970) Backwards compatibility broken with version 2.3.0 for KV1
Title: Message Title Brian Saville commented on JENKINS-58970 Re: Backwards compatibility broken with version 2.3.0 for KV1 Tried it out this morning, and works great. Thanks for the quick turnaround on this! Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201317.1565984294000.6207.1566312540228%40Atlassian.JIRA.
[JIRA] (JENKINS-58970) Backwards compatibility broken with version 2.3.0 for KV1
Title: Message Title Brian Saville commented on JENKINS-58970 Re: Backwards compatibility broken with version 2.3.0 for KV1 You work fast Joseph Petersen, this is exactly what I was looking for, thanks! Any idea on timeline for the next release? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201317.1565984294000.5802.1566270840169%40Atlassian.JIRA.
[JIRA] (JENKINS-58970) Backwards compatibility broken with version 2.3.0 for KV1
Title: Message Title Brian Saville commented on JENKINS-58970 Re: Backwards compatibility broken with version 2.3.0 for KV1 Joseph Petersen, Jacob Truman is absolutely right, I would like to not have to change any existing workflow scripts since many of them are outside of our control. I would argue that the default has already been changed with 2.3.0 and should be set to 1 to match the previous behavior, but I can understand completely if you don't want to do it that way. I would quite happy with a solution that let me set the default version system wide (perhaps in the global configuration options?) so that individual teams/users don't have to update their scripts to have it continue working with v1 engine versions. Thanks! Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201317.1565984294000.5800.1566270480203%40Atlassian.JIRA.
[JIRA] (JENKINS-58970) Backwards compatibility broken with version 2.3.0 for KV1
Title: Message Title
Brian Saville updated an issue
Jenkins / JENKINS-58970
Backwards compatibility broken with version 2.3.0 for KV1
Change By:
Brian Saville
The latest release is great that it adds support for KV2 secret storage, but it also breaks backwards compatibility. We have many users of Jenkins with their own Jenkinsfiles in various repositories (~300 different references in different places). Instead of requiring the {{engineVersion: 1}} parameter, I would like this to be treated as the default value to preserve the previous behavior. - I'm happy to put together a patch for this, and likely will soon here. -Here is a patch to change this: https://github.com/jenkinsci/hashicorp-vault-plugin/pull/40I realize that the newer vault library uses 2 as the default, but I still think preserving the previous behavior is the easiest path forward. If you do not like this solution, I could probably also code something up that allows an admin to set the default version globally in Jenkins so we can do it just on our instance and it doesn't affect anyone else.
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view
[JIRA] (JENKINS-58970) Backwards compatibility broken with version 2.3.0 for KV1
Title: Message Title Brian Saville created an issue Jenkins / JENKINS-58970 Backwards compatibility broken with version 2.3.0 for KV1 Issue Type: Bug Assignee: Peter Tierno Components: hashicorp-vault-plugin Created: 2019-08-16 19:38 Priority: Critical Reporter: Brian Saville The latest release is great that it adds support for KV2 secret storage, but it also breaks backwards compatibility. We have many users of Jenkins with their own Jenkinsfiles in various repositories (~300 different references in different places). Instead of requiring the engineVersion: 1 parameter, I would like this to be treated as the default value to preserve the previous behavior. I'm happy to put together a patch for this, and likely will soon here. Add Comment
[JIRA] (JENKINS-58947) Vault credentials not found secret/
Title: Message Title Brian Saville commented on JENKINS-58947 Re: Vault credentials not found secret/ Likely related to JENKINS-58970. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201293.1565870178000.4215.1565984340402%40Atlassian.JIRA.
[JIRA] (JENKINS-52646) KV v2 changes the API path to secrets & the response format
Title: Message Title Brian Saville commented on JENKINS-52646 Re: KV v2 changes the API path to secrets & the response format They released a new version last week that works as long as you specify the engineVersion parameter on the VaultSecret class. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.192501.1531974458000.4200.1565983980636%40Atlassian.JIRA.
[JIRA] (JENKINS-52646) KV v2 changes the API path to secrets & the response format
Title: Message Title Brian Saville commented on JENKINS-52646 Re: KV v2 changes the API path to secrets & the response format Second that - we have many users switching to v2 format and we currently cannot work with them. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.192501.1531974458000.13173.1563306900439%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49348) BlueOcean misses a button to re-run a build
Title: Message Title Brian Saville commented on JENKINS-49348 Re: BlueOcean misses a button to re-run a build James Dumay, this would be extremely helpful for us as well. We heavily use pipeline jobs, and modify them often through the Job DSL plugin. Since the re-run button currently does a replay, it will use the old pipeline script instead of the latest one. The rebuild plugin does some nice things as well such as maintain the same build parameters and causes. Causes are especially important to us because it can trigger different behavior based on what caused the build in the first place. IMHO, I think we should either have two buttons available in blue ocean - one for replay and one for rebuild, or, since the replay doesn't actually let you change the pipeline script yet through blue ocean (AFAIK) and the rebuild plugin truly redo the current build exactly as it was the first time, I vote that if the rebuild plugin is present, make the re-run button trigger a rebuild instead of a replay. I would prefer the latter since it prevents confusion, but would be a potentially breaking change for other users. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-53261) Blue ocean should handle non-encoded URLs for jobs in folders
Title: Message Title Brian Saville created an issue Jenkins / JENKINS-53261 Blue ocean should handle non-encoded URLs for jobs in folders Issue Type: Improvement Assignee: Unassigned Components: blueocean-plugin Created: 2018-08-27 19:50 Priority: Major Reporter: Brian Saville Two important points: 1) we're using jobs inside of folders, sometimes up to 4 levels deep, 2) we're sending links in email notifications to our users for failed builds, etc. As it turns out Outlook 365 has ATP (Active Threat Protection) which wraps URLs from "unknown" or not specifically whitelisted addresses in another site controlled by MS. I've confirmed using http://www.o365atp.com/ that the URL encoding for the full job path (i.e. /blue/organizations/jenkins/folder%2Fjob/detail/...) is correct in the wrapped link. Unfortunately, their ATP endpoints returns a 302 with a location that has been URL decoded one too many times, so that I end up with /blue/organizations/jenkins/folder/job/detail/...). This fails to load in blue ocean since it does not handle job paths with actual slashes instead of URL encoded slashes (%2F). Obviously the best answer is that MS should fix their stuff, but I don't think that's going to happen anytime soon. I can also workaround this by using nginx rewrites since we are behind nginx. However, those rewrites are messy and difficult to get right for arbitrary depths of folders. IMHO, blue ocean should be able to handle paths that are not URL encoded for jobs, since there are markers before and after the job (/jenkins/ and /detail/, etc). Is there a chance that we could improve the URL routing to handle this? I'm happy to take a look myself, but I'm not sure where the actual routing is being done for blue ocean.
[JIRA] (JENKINS-45565) Concurrent modification exception on serializing MilestoneStep$DescriptorImpl#milestonesByOrdinalByJob
Title: Message Title Brian Saville commented on JENKINS-45565 Re: Concurrent modification exception on serializing MilestoneStep$DescriptorImpl#milestonesByOrdinalByJob We ran into this same problem today. In our case, we have the same job name in different folders (job_1 and subfolder/job_1), so that might be related to the PS2 above. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38975) Implement PR job rebuild on pull request comment
Title: Message Title Brian Saville closed an issue as Won't Fix I've created a separate plugin for this (located at https://github.com/bluesliverx/github-pr-comment-build-plugin). While it's not released via jenkins plugins yet, you can grab it and manually build it for now. Jenkins / JENKINS-38975 Implement PR job rebuild on pull request comment Change By: Brian Saville Status: Open Closed Resolution: Won't Fix Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To
[JIRA] (JENKINS-38316) Putting Jenkins in shutdown mode breaks running pipeline runs
Title: Message Title Brian Saville edited a comment on JENKINS-38316 Re: Putting Jenkins in shutdown mode breaks running pipeline runs To me, #3 is really the issue here. Due to the nature of pipeline jobs (serialized, stoppable at just about any point), it doesn't bother me that #2 happens. But cancelling the shutdown mode (without a restart) should cause the jobs to start back up again, and it currently doesn't. And it may go without saying, but we're seeing this issue too. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38316) Putting Jenkins in shutdown mode breaks running pipeline runs
Title: Message Title Brian Saville commented on JENKINS-38316 Re: Putting Jenkins in shutdown mode breaks running pipeline runs To me, #3 is really the issue here. Due to the nature of pipeline jobs (serialized, stoppable at just about any point), it doesn't bother me that #2 happens. But cancelling the shutdown mode (without a restart) should cause the jobs to start back up again, and it currently doesn't. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38975) Implement PR job rebuild on pull request comment
Title: Message Title Brian Saville commented on JENKINS-38975 Re: Implement PR job rebuild on pull request comment It's been two weeks since my last comment. Maybe Jesse Glick could take a look? I upped the priority to Major since we depend on this functionality and currently I'm maintaining a customized build to support this for us. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38975) Implement PR job rebuild on pull request comment
Title: Message Title Brian Saville updated an issue Jenkins / JENKINS-38975 Implement PR job rebuild on pull request comment Change By: Brian Saville Priority: Minor Major Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38975) Implement PR job rebuild on pull request comment
Title: Message Title Brian Saville commented on JENKINS-38975 Re: Implement PR job rebuild on pull request comment I realize that I classified this as minor, but the feature is ready to go as far as I see unless I get some more feedback (already responded to some feedback on the PR). Is there any possibility of getting this merged in? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37608) Configurability of GitHub Branch Source to use Scan User with only Read permission
Title: Message Title Brian Saville commented on JENKINS-37608 Re: Configurability of GitHub Branch Source to use Scan User with only Read permission In our case, we are using GitHub enterprise and we automatically trust all PRs. While what you are proposing makes a lot of sense for github.com, it doesn't make as much sense for Enterprise GH. If we could add some configuration to just disable the check, that would be great. Right now I'm pulling the source, override the isTrusted method to return true, and building a custom version of the plugin since it is unacceptable for our users right now to add our API user with write permissions to their org. I feel that this is really a bug in GitHub's API, but to work around it, I'm happy to submit a PR that adds something so you can configure if you want to trust all explicitly without checking collaborators and requiring write access. What do you think Jesse Glick? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38944) webhook is not registering on creation
Title: Message Title Brian Saville commented on JENKINS-38944 Re: webhook is not registering on creation This could be done in the factory class, but that isn't github specific. It may be possible to use a branch property as well, but that seems overkill. I'm not sure of a good way to tie into the job creation process currently, but I'm sure I don't know about something... Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-34230) Display the reason when branch indexing fails
Title: Message Title Brian Saville commented on JENKINS-34230 Re: Display the reason when branch indexing fails Here's a random one that likely will not be common since I only ran into it while developing a new branch property for JENKINS-38975: Executor threw an exception java.lang.AbstractMethodError: you must implement jobDecorator in class org.jenkinsci.plugins.github_branch_source.TriggerPRCommentBranchProperty at jenkins.branch.BranchProperty.jobDecorator(BranchProperty.java:85) at jenkins.branch.BranchProjectFactory.decorate(BranchProjectFactory.java:206) at jenkins.branch.MultiBranchProject$1.observe(MultiBranchProject.java:307) at org.jenkinsci.plugins.github_branch_source.GitHubSCMSource.doRetrieve(GitHubSCMSource.java:464) at org.jenkinsci.plugins.github_branch_source.GitHubSCMSource.retrieve(GitHubSCMSource.java:365) at jenkins.scm.api.SCMSource.fetch(SCMSource.java:148) at jenkins.branch.MultiBranchProject.computeChildren(MultiBranchProject.java:294) at com.cloudbees.hudson.plugins.folder.computed.ComputedFolder.updateChildren(ComputedFolder.java:157) at com.cloudbees.hudson.plugins.folder.computed.FolderComputation.run(FolderComputation.java:122) at hudson.model.ResourceController.execute(ResourceController.java:98) at hudson.model.Executor.run(Executor.java:410) Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
[JIRA] (JENKINS-38975) Implement PR job rebuild on pull request comment
Title: Message Title Brian Saville commented on JENKINS-38975 Re: Implement PR job rebuild on pull request comment I added a new commit to the PR that adds a property for configuring the trigger. So at this point, it is an opt-in based on the branch property. I didn't add support for override branch properties, but it didn't make much sense to me to add that since it already only applies to PR builds and I can't think of a case where you want to only add the comment trigger on only certain PRs (i.e. even numbered PRs). Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38975) Implement PR job rebuild on pull request comment
Title: Message Title Brian Saville commented on JENKINS-38975 Re: Implement PR job rebuild on pull request comment Jae Gangemi, yes it is possible. I'm working on a commit right now that will allow it to be configured in the UI. It defaults to "REBUILD" right now. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38975) Implement PR job rebuild on pull request comment
Title: Message Title Brian Saville commented on JENKINS-38975 Re: Implement PR job rebuild on pull request comment The only things I don't like about this are 1) can't customize the trigger string and 2) this is always on, with no way to opt-out. I think I may look into adding a branch property for this to opt-in to the behavior. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38975) Implement PR job rebuild on pull request comment
Title: Message Title Brian Saville updated an issue Jenkins / JENKINS-38975 Implement PR job rebuild on pull request comment Change By: Brian Saville In switching over from the ghprb plugin, we are currently missing functionality to add a comment to a PR in GitHub that triggers an immediate rebuild of the PR job. We could definitely work around this by going to the job and manually retrying it, but our users often don't know much about Jenkins and instead want to interact with the checks on the PR itself.I've already done some work on this and have a working GHEventsSubscriber that reads issue comments and checks them for PR builds. I'm not sure if this would work better as a separate plugin from the github branch source plugin, but I want to at least open the conversation. We will likely be using our custom built version of this in production until something is merged in, so I'm willing to do whatever it takes to help out in adding the functionality. https://github.com/jenkinsci/github-branch-source-plugin/pull/81 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
[JIRA] (JENKINS-38975) Implement PR job rebuild on pull request comment
Title: Message Title Brian Saville created an issue Jenkins / JENKINS-38975 Implement PR job rebuild on pull request comment Issue Type: New Feature Assignee: Unassigned Components: github-branch-source-plugin Created: 2016/Oct/13 9:33 PM Priority: Minor Reporter: Brian Saville In switching over from the ghprb plugin, we are currently missing functionality to add a comment to a PR in GitHub that triggers an immediate rebuild of the PR job. We could definitely work around this by going to the job and manually retrying it, but our users often don't know much about Jenkins and instead want to interact with the checks on the PR itself. I've already done some work on this and have a working GHEventsSubscriber that reads issue comments and checks them for PR builds. I'm not sure if this would work better as a separate plugin from the github branch source plugin, but I want to at least open the conversation. We will likely be using our custom built version of this in production until something is merged in, so I'm willing to do whatever it takes to help out in adding the functionality. Add Comment
[JIRA] (JENKINS-35412) Dependency list not the same for pom.xml and build.gradle using gradle-jpi-plugin
Title: Message Title Brian Saville commented on JENKINS-35412 Re: Dependency list not the same for pom.xml and build.gradle using gradle-jpi-plugin We've run into this as well. I still notice even using the extended syntax (ext: 'jar') it still seems to require declaring the transitive dependencies for some reason. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38920) JPI plugin Manifest lacks Plugin-Class attribute when Gradle project was previously cleaned
Title: Message Title Brian Saville commented on JENKINS-38920 Re: JPI plugin Manifest lacks Plugin-Class attribute when Gradle project was previously cleaned We have run into this as well. The temporary workaround is to do something like gradlew build jpi to actually build the JPI twice to get the Plugin-Class attribute. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-35132) Pipeline: GitHub webhook received but nothing happens
Title: Message Title Brian Saville edited a comment on JENKINS-35132 Re: Pipeline: GitHub webhook received but nothing happens Ran into the same thing here. *UPDATE*: This was due to us using the "Suppress automatic SCM triggering" option on a GitHub multibranch project. After reading through the source, I incorrectly assumed it would prevent only the initial branch index from firing off new builds, but since the GitHub plugin webhook actually uses the branch indexing to fire off builds after receiving a hook payload, it ignored those as all. Disabling this property on the multibranch project fixed the issue completely for me. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-35132) Pipeline: GitHub webhook received but nothing happens
Title: Message Title Brian Saville commented on JENKINS-35132 Re: Pipeline: GitHub webhook received but nothing happens Ran into the same thing here. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37892) Support jenkins workflow/pipeline
Title: Message Title Brian Saville created an issue Jenkins / JENKINS-37892 Support jenkins workflow/pipeline Issue Type: Improvement Assignee: Christopher Orr Components: google-play-android-publisher-plugin Created: 2016/Sep/01 1:55 PM Priority: Minor Reporter: Brian Saville Currently the google play android publisher plugin does not implement SimpleBuildStep, which means it can't be used in pipeline builds. I've submitted a pull request to add this support. Could you please let me know what you think and/or merge this for an updated plugin version? Add Comment
