[JIRA] (JENKINS-43278) Pressing "Show More" button on Activity tab for Multibranch yields unpredictable results
Title: Message Title
Cliff Meyers created an issue
Jenkins / JENKINS-43278
Pressing "Show More" button on Activity tab for Multibranch yields unpredictable results
Issue Type:
Bug
Assignee:
Unassigned
Components:
blueocean-plugin
Created:
2017/Mar/31 6:22 PM
Priority:
Minor
Reporter:
Cliff Meyers
Preconditions:
Set up a multibranch pipeline with 5 branches and 10 runs for each branch.
Repro Steps 1. Navigate to the Activity branch for the MBP 2. Note there are 25 runs displayed 3. Press "Show More" Expected Result
A total of 50 runs should be displayed
Actual Results
No addition runs are displayed and the "Show More" button disappears
Analysis: When the second request is made, it hits the /activities endpoint sending parameters of start=25 and limit=26. This request returns an empty array. The bug appears to be in MultiBranchPipelineImpl.getRuns() which is called from getActivities(). Inside of the anonymous BlueRunContainer.iterator(int start, int limit) method there is a bug around line 281:
for(final BluePipeline b: branches) {
Iterator it = b.getRuns().iterator(0,MAX_MBP_RUNS_ROWS);
int count = 0;
Iterators.skip(it, start);
while(it.hasNext() && count++ < limit){
c.add(it.next());
}
}
[JIRA] (JENKINS-43259) Parameterised form is sometimes unstyled
Title: Message Title Cliff Meyers commented on JENKINS-43259 Re: Parameterised form is sometimes unstyled PR: https://github.com/jenkinsci/blueocean-plugin/pull/939 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43259) Parameterised form is sometimes unstyled
Title: Message Title Cliff Meyers updated JENKINS-43259 Jenkins / JENKINS-43259 Parameterised form is sometimes unstyled Change By: Cliff Meyers Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42385) Clean up JDL css colours
Title: Message Title Cliff Meyers commented on JENKINS-42385 Re: Clean up JDL css colours Sounds good. I think our goal for this task should be a nice clean "colors.less" or similar, which we could easily do first as a smaller task. We could copy that into dashboard or personalization in the mean time, to eliminate the color duplication. Then if we do a full-blown rework of how the JDL is published, that stuff can just go away eventually. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43259) Parameterised form is sometimes unstyled
Title: Message Title Cliff Meyers started work on JENKINS-43259 Change By: Cliff Meyers Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43259) Parameterised form is sometimes unstyled
Title: Message Title Cliff Meyers assigned an issue to Cliff Meyers Jenkins / JENKINS-43259 Parameterised form is sometimes unstyled Change By: Cliff Meyers Assignee: Cliff Meyers Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43259) Parameterised form is sometimes unstyled
Title: Message Title Cliff Meyers commented on JENKINS-43259 Re: Parameterised form is sometimes unstyled It's likely inheriting the color style from the parent. It's counter intuitive but the dialog actually is a child of the button element as it uses position fixed to take over the screen. I think this class of bugs may get walloped once Josh McDonald updates dialog to be added directly to the body element. I can grab this and implement a simple style fix in the mean time. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43257) Activity table blinks away when clicking "Show More" button
Title: Message Title Cliff Meyers commented on JENKINS-43257 Re: Activity table blinks away when clicking "Show More" button PR: https://github.com/jenkinsci/blueocean-plugin/pull/936 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43257) Activity table blinks away when clicking "Show More" button
Title: Message Title Cliff Meyers updated JENKINS-43257 Jenkins / JENKINS-43257 Activity table blinks away when clicking "Show More" button Change By: Cliff Meyers Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43257) Activity table blinks away when clicking "Show More" button
Title: Message Title Cliff Meyers started work on JENKINS-43257 Change By: Cliff Meyers Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43257) Activity table blinks away when clicking "Show More" button
Title: Message Title Cliff Meyers edited a comment on JENKINS-43257 Re: Activity table blinks away when clicking "Show More" button This regressed during the last addition of empty states in JENKINS-42515 / https://github . com/jenkinsci/blueocean-plugin/pull/929 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43257) Activity table blinks away when clicking "Show More" button
Title: Message Title Cliff Meyers commented on JENKINS-43257 Re: Activity table blinks away when clicking "Show More" button This regressed during the last addition of empty states. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43257) Activity table blinks away when clicking "Show More" button
Title: Message Title Cliff Meyers created an issue Jenkins / JENKINS-43257 Activity table blinks away when clicking "Show More" button Issue Type: Bug Assignee: Cliff Meyers Components: blueocean-plugin Created: 2017/Mar/31 3:05 AM Priority: Minor Reporter: Cliff Meyers When clicking the "Show More" button for the Activity listing, the table momentarily blinks away while the data is loading. This is quite annoying as you lose scroll position and have to start from the top each time. Repro Steps: Drill into a classic pipeline or freestyle job with at least 25 runs, ideally more than 50. Scroll to the bottom of the page. Click "Show More" Expected behavior: Data is appended to the bottom of the list. The scroll position is preserved. Actual behavior: The entire table disappears, then the screen re-renders with all data. Scroll position is reset to the top.
[JIRA] (JENKINS-43217) Closing pipeline results "modal" after clicking on a stage sets the url incorrectly to the previous URL, not activity
Title: Message Title Cliff Meyers commented on JENKINS-43217 Re: Closing pipeline results "modal" after clicking on a stage sets the url incorrectly to the previous URL, not activity PR's: https://github.com/jenkinsci/blueocean-plugin/pull/935 https://github.com/jenkinsci/blueocean-acceptance-test/pull/133/files Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43217) Closing pipeline results "modal" after clicking on a stage sets the url incorrectly to the previous URL, not activity
Title: Message Title Cliff Meyers updated JENKINS-43217 Jenkins / JENKINS-43217 Closing pipeline results "modal" after clicking on a stage sets the url incorrectly to the previous URL, not activity Change By: Cliff Meyers Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43217) Closing pipeline results "modal" after clicking on a stage sets the url incorrectly to the previous URL, not activity
Title: Message Title Cliff Meyers updated an issue Jenkins / JENKINS-43217 Closing pipeline results "modal" after clicking on a stage sets the url incorrectly to the previous URL, not activity Change By: Cliff Meyers Sprint: Blue Ocean 1. 1 0-rc4 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43217) Closing pipeline results "modal" after clicking on a stage sets the url incorrectly to the previous URL, not activity
Title: Message Title Cliff Meyers assigned an issue to Cliff Meyers Jenkins / JENKINS-43217 Closing pipeline results "modal" after clicking on a stage sets the url incorrectly to the previous URL, not activity Change By: Cliff Meyers Assignee: Cliff Meyers Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43217) Closing pipeline results "modal" after clicking on a stage sets the url incorrectly to the previous URL, not activity
Title: Message Title Cliff Meyers started work on JENKINS-43217 Change By: Cliff Meyers Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43217) Closing pipeline results "modal" after clicking on a stage sets the url incorrectly to the previous URL, not activity
Title: Message Title Cliff Meyers commented on JENKINS-43217 Re: Closing pipeline results "modal" after clicking on a stage sets the url incorrectly to the previous URL, not activity This also occurs if the user clicks on any tabs after opening the modal and then closes it. Be advised that in addition to the "full page reload after click" problem, the DOM shown in the browser is a snapshot that is "disconnected" from React and MobX, and therefore won't update in real time. I might suggest upgrading the priority of this bug. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43211) Remove unneeded dependencies (markdown, redux)
Title: Message Title Cliff Meyers commented on JENKINS-43211 Re: Remove unneeded dependencies (markdown, redux) To eliminate redux, following areas need to be ported: blueocean-personalization (full module) blueocean-web (all bootstrapping code for stores, middleware, etc) blueocean-dashboard Dashboard TestResults various tests / specs To eliminate "react-remarkable", following areas need porting: All remaining empty states (at present, only for RunDetailsArtifacts) ParametersRunButton inputStep Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving
[JIRA] (JENKINS-42515) User education empty state updates
Title: Message Title Cliff Meyers commented on JENKINS-42515 Re: User education empty state updates Brody Maclean a few assets / design requests related to this ticket: Could you make the "double checkmark" and "failed X" assets from the top of the test results screen exportable in Zeplin? We need an updated design for the Artifacts tab. Right now if there are over 100 artifacts it displays a simple "only showing first 100 artifacts" message using the old "empty state" blue gradient. Perhaps it could look like the widget at the top of "test results" except with a different icon and a grey stripe? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42131) JDL Dropdowns in wrong place on Firefox
Title: Message Title Cliff Meyers commented on JENKINS-42131 Re: JDL Dropdowns in wrong place on Firefox We had used the approach of appending to body in past apps, and it worked well, although it's certainly more DOM gymnastics than just using the position: fixed approach (which I thought was effective). Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42515) User education empty state updates
Title: Message Title Cliff Meyers commented on JENKINS-42515 Re: User education empty state updates I should note this PR covers all the remaining Pipeline empty states on the Activity, Branches and PR tabs. If we are happy with this and decide to land it before release, I will cut a new ticket that covers the "Run" empty states for Pipeline, Tests, Changes, etc. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42515) User education empty state updates
Title: Message Title Cliff Meyers updated JENKINS-42515 Jenkins / JENKINS-42515 User education empty state updates Change By: Cliff Meyers Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42515) User education empty state updates
Title: Message Title Cliff Meyers commented on JENKINS-42515 Re: User education empty state updates PR: https://github.com/jenkinsci/blueocean-plugin/pull/929 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43083) Investigate how to improve unit and integration tests and avoid relying on E2E (ATH)
Title: Message Title Cliff Meyers commented on JENKINS-43083 Re: Investigate how to improve unit and integration tests and avoid relying on E2E (ATH) Couple of useful reads I found over the weekend that seem to be pro-Jest: https://www.codementor.io/vijayst/unit-testing-react-components-jest-or-enzyme-du1087lh8 https://blog.grommet.io/post/2016/09/01/how-we-landed-on-jest-snapshot-testing-for-_javascript_ And at least one contrarian opinion: https://www.reddit.com/r/reactjs/comments/46cwj3/whats_february_2016s_best_alternative_to_jest_i/ I am not sold on it, although I do think it might be worth taking a look at. Happy to discuss more. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42123) No feedback when clicking "connect" when entering Github access key
Title: Message Title Cliff Meyers updated JENKINS-42123 Jenkins / JENKINS-42123 No feedback when clicking "connect" when entering Github access key Change By: Cliff Meyers Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43096) Form submission progress / error / success states
Title: Message Title Cliff Meyers created an issue Jenkins / JENKINS-43096 Form submission progress / error / success states Issue Type: Task Assignee: Unassigned Components: blueocean-plugin Created: 2017/Mar/24 6:58 PM Labels: technical-debt Priority: Minor Reporter: Cliff Meyers In JENKINS-42123, some button styles were added to show that a form submission is in-progress or succeeded. (Error state was also supported, but not actually displayed in the UI, as the existing form validation error messaging was deemed sufficient feedback). A reusable button control was created to accomplish this but it may not be ideal from an API / coupling perspective (see discussion here: https://github.com/jenkinsci/blueocean-plugin/pull/912) Once a few more concrete use cases are established, we should try to make supporting these kinds of behaviors as easy as possible so that we have consistent UX and components that are easily transferrable to other teams. Add Comment
[JIRA] (JENKINS-42515) User education empty state updates
Title: Message Title Cliff Meyers commented on JENKINS-42515 Re: User education empty state updates James Dumay referring to the Google Doc, I have two questions about the Activity screen (first row on page #2): In practice, will we really see a multi-branch project which has branches but that has no runs? It seems the first thing Jenkins does when creating a multi-branch pipeline is run any branches w/ Jenkinsfiles. This screen was easy enough to create but I'm not sure we actually need it? What should we display for a freestyle job (no branches) with no runs? As it stands now, it would just be a "Run" button at the top of the screen with nothing below it. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42515) User education empty state updates
Title: Message Title Cliff Meyers started work on JENKINS-42515 Change By: Cliff Meyers Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41737) Dashboard screen when there are no pipelines
Title: Message Title Cliff Meyers started work on JENKINS-41737 Change By: Cliff Meyers Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41740) Show empty state on the Activity, Branch and PR tab when there are no branches
Title: Message Title Cliff Meyers updated JENKINS-41740 Jenkins / JENKINS-41740 Show empty state on the Activity, Branch and PR tab when there are no branches Change By: Cliff Meyers Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41740) Show empty state on the Activity, Branch and PR tab when there are no branches
Title: Message Title Cliff Meyers commented on JENKINS-41740 Re: Show empty state on the Activity, Branch and PR tab when there are no branches PR: https://github.com/jenkinsci/blueocean-plugin/pull/922 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42924) Favourite pipelines working oddly when there is no default branch to favourite
Title: Message Title Cliff Meyers edited a comment on JENKINS-42924 Re: Favourite pipelines working oddly when there is no default branch to favourite The error handling won't be too difficult here, but we probably need to give some additional feedback that an error occurred? Clicking the star and having it do nothing will just leave lead to confusion. Should we display some kind of error toast? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42924) Favourite pipelines working oddly when there is no default branch to favourite
Title: Message Title Cliff Meyers commented on JENKINS-42924 Re: Favourite pipelines working oddly when there is no default branch to favourite The error handling won't be too difficult here, but we probably need to give some additional feedback that an error occurred? Clicking the star and having it do nothing will just leave to confusion. Should we display some kind of error toast? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41740) Show empty state on the Activity, Branch and PR tab when there are no branches
Title: Message Title Cliff Meyers started work on JENKINS-41740 Change By: Cliff Meyers Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42926) "Pull requests are unsupported" screen has a link to "Learn more" that should open in a different tab, not in the current one, to not lose the context
Title: Message Title Cliff Meyers commented on JENKINS-42926 Re: "Pull requests are unsupported" screen has a link to "Learn more" that should open in a different tab, not in the current one, to not lose the context This ticket should also be obviated once JENKINS-42515 is implemented, as we are changing the design of this screen. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42927) Pull requests "Enable" button is not doing anything
Title: Message Title Cliff Meyers edited a comment on JENKINS-42927 Re: Pull requests "Enable" button is not doing anything This was never implemented but is clearly confusing. Once JENKINS- 41740 42515 is implemented we'll be able to close this ticket as "won't fix." Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42925) Error fetching page: Not found at checkstatus
Title: Message Title Cliff Meyers commented on JENKINS-42925 Re: Error fetching page: Not found at checkstatus James Dumay we need to decide what we should do if the user visits a URL that corresponds to an organization folder. And for that matter, a folder as well. There may be handling for the latter already, in which case perhaps we should do the same for the former? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42927) Pull requests "Enable" button is not doing anything
Title: Message Title Cliff Meyers commented on JENKINS-42927 Re: Pull requests "Enable" button is not doing anything This was never implemented but is clearly confusing. Once JENKINS-41740 is implemented we'll be able to close this ticket as "won't fix." Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org
Title: Message Title Cliff Meyers commented on JENKINS-42784 Re: Unable to create new pipeline for empty repo in brand new github org Adding details of an issue discovered by Isa Vilacides during exploratory testing. I am confident the underlying issue here is the same but want to preserve it for traceability: Problem: The copy of "Just one repository" github pipeline creation is confusing. It says that it's recommended if you do not have a jenkinsfile, but if you do not have a jenkinsfile, then no pipeline is created and it says that the pipeline is pending to be created when it will never be Steps to reproduce Click on create a pipeline and chose "Github"→ some organization → Just one repository Chose any repo with no jenkinsfile and click on "Create pipeline" Current result It spins creating pipeline until it times out The pipeline is not created but the message is "Saving was successful and pipeline creation is in progress. Go to the dashboard..." so my expectation is that there is a background process that will keep trying or so on. The message should be: there is no jenkinsfile and no pipeline has been created Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
[JIRA] (JENKINS-42924) Favourite pipelines working oddly when there is no default branch to favourite
Title: Message Title Cliff Meyers commented on JENKINS-42924 Re: Favourite pipelines working oddly when there is no default branch to favourite James Dumay I recall this default branch issue being discussed quite a long ways back - perhaps there is another related ticket as well? In the event there's an error, should we display a friendly error message and ensure the favorite star isn't shaded in? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org
Title: Message Title Cliff Meyers assigned an issue to Keith Zantow Assigning to Keith as it sounds like there are some significant changes coming in backend. I'm happy to implement the frontend changes once those are in place - just reassign the ticket when ready and CC me on the PR. Thanks! Jenkins / JENKINS-42784 Unable to create new pipeline for empty repo in brand new github org Change By: Cliff Meyers Assignee: Cliff Meyers Keith Zantow Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org
Title: Message Title Cliff Meyers stopped work on JENKINS-42784 Change By: Cliff Meyers Status: In Progress Open Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org
Title: Message Title Cliff Meyers commented on JENKINS-42784 Re: Unable to create new pipeline for empty repo in brand new github org Sounds as though all of these PR's will be abandoned in favor of some changes that Keith Zantow is going to implement, per discussion in Gitter room. Possible changes include: possible improvement to API to support "add repo" use case. Rather than requiring a PUT request that includes the full repo list each time, allow a simpler request to that adds a single repo to anything existing. ensure single repo optimization happens for "update" calls in addition to create Change impl not to use regex (unclear to me what this would entail) Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42123) No feedback when clicking "connect" when entering Github access key
Title: Message Title Cliff Meyers updated JENKINS-42123 Jenkins / JENKINS-42123 No feedback when clicking "connect" when entering Github access key Change By: Cliff Meyers Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42123) No feedback when clicking "connect" when entering Github access key
Title: Message Title Cliff Meyers commented on JENKINS-42123 Re: No feedback when clicking "connect" when entering Github access key PR: https://github.com/jenkinsci/blueocean-plugin/pull/912 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org
Title: Message Title Cliff Meyers commented on JENKINS-42784 Re: Unable to create new pipeline for empty repo in brand new github org New PR from Vivek with backend changes: https://github.com/jenkinsci/blueocean-plugin/pull/911 Will implement UI changes in same branch. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42120) Revisit Git repository creation flow credential setup
Title: Message Title Cliff Meyers updated JENKINS-42120 Jenkins / JENKINS-42120 Revisit Git repository creation flow credential setup Change By: Cliff Meyers Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42719) Bug fixes / enhancements to Dropdown
Title: Message Title Cliff Meyers commented on JENKINS-42719 Re: Bug fixes / enhancements to Dropdown Decided in PR to defer the "programmatic selection" to avoid API's that we might deprecate later, or breaking current backward compat. Will address in a series of broader changes to JDL down the road. For now, reaching into the state of the Dropdown works. A hack, but used only in one place today. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42719) Bug fixes / enhancements to Dropdown
Title: Message Title Cliff Meyers updated JENKINS-42719 Jenkins / JENKINS-42719 Bug fixes / enhancements to Dropdown Change By: Cliff Meyers Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42719) Bug fixes / enhancements to Dropdown
Title: Message Title Cliff Meyers updated an issue Jenkins / JENKINS-42719 Bug fixes / enhancements to Dropdown Change By: Cliff Meyers While working JENKINS-42120 some bugs in the JDL Dropdown became evident:# (/) Need a way to programmatically select an option in the Dropdown, either via an exposed method or a prop.# (/) Adjust the height of dropdown to match that of standard button.# (/) Prevent NPE if "data" prop is null/undefined# (/) Need better UX if the "data" prop is an empty array. Right now an empty menu opens which looks odd. Should either prevent the menu from displaying, or perhaps display it with some kind of "no options" menu. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org
Title: Message Title Cliff Meyers commented on JENKINS-42784 Re: Unable to create new pipeline for empty repo in brand new github org Here's a PR with my suggested change in action: https://github.com/jenkinsci/blueocean-plugin/pull/908 It seems to do what we want, but I have to defer to the others as to whether this is really an appropriate code change. See my detailed comments on the PR. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org
Title: Message Title Cliff Meyers commented on JENKINS-42784 Re: Unable to create new pipeline for empty repo in brand new github org Vivek Pandey it's true that it will place more load on the server and slow down the org folder scanning slightly, but shouldn't the scan of the single repo still complete much faster than the org folder scan on its own (at least when the number of repos is large)? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org
Title: Message Title Cliff Meyers edited a comment on JENKINS-42784 Re: Unable to create new pipeline for empty repo in brand new github org [~vivek] it's true that it #2 will place more load on the server and slow down the org folder scanning slightly, but shouldn't the scan of the single repo still complete much faster than the org folder scan on its own (at least when the number of repos is large)? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org
Title: Message Title Cliff Meyers commented on JENKINS-42784 Re: Unable to create new pipeline for empty repo in brand new github org Keith Zantow I'll let the others speak to it... if it requires a change in the OSS libraries, it's likely not workable in our timeframe. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org
Title: Message Title Cliff Meyers commented on JENKINS-42784 Re: Unable to create new pipeline for empty repo in brand new github org Keith Zantow unfortunately "checking for Jenkinsfile" is not a cheap operation, since it requires N Github API calls where N = number of branches in repo. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org
Title: Message Title Cliff Meyers commented on JENKINS-42784 Re: Unable to create new pipeline for empty repo in brand new github org Vivek Pandey specifically maybe you can speak to whether firing both the optimized single-repo scan and the org folder scan would cause an errors or undue load on the server. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org
Title: Message Title Cliff Meyers edited a comment on JENKINS-42784 Re: Unable to create new pipeline for empty repo in brand new github org To clarify: any time you pick "single repo", the UI will respond to either the "org folder indexing complete" event or the "multi branch indexing complete" event, provided it's for the pipeline that corresponds to the selected repo. (Obviously we want to ignore the events from other pipelines that might have already been created).The first time through, if you pick a repo w/ no jenkinsfile, you'll get neither event - and therefore the timeout - because of this logic here:https://github.com/jenkinsci/blueocean-plugin/commit/5470506f1048c97a40ee8f16e21fe4b80f234dd3#diff-5e7377cad1cf9f0aa33fcc1e0cf62af9R120There's no org indexing done at all, and the event for the multi-branch indexing never fires, because it never will if there's no jenkinsfile.Now, *if you previously selected a repo and it contained a jenkinsfile*, then selecting other repos will result in 'missing jenkinsfile" screen because the org indexing event does in fact fire at some point. Well, it probably will, at least hopefully within the first 60s timeout window.So I see a few ways to address this: # UI only: if the user picked "single repo" and the 60s timeout is hit, show the "missing jenkinsfile" state anyways. If something flaky happened on the backend, it's possible that the Editor will open in an error state. [~kzantow] maybe you can provide some input there. It might actually work fine.# Backend only: change the logic linked above so that the single repo case performs both the optimized "SCMSourceEvent.fireNow" call, and the "organizationFolder.scheduleBuild" as well. For repos w/ JF, that should preserve faster performance. For repos w/o JF, we should still get the "org folder indexing complete" event within the 60s window, which means the UI code isn't making the fuzzy "no event means no JF" assumption.# Make both changes. This would give us extra insurance that if the user picked "single repo" that doesn't have a JF, AND the org indexing takes longer than 60s, that we still show the state where they can launch the editor. cc [~vivek] and [~michaelneale] for input. Add Comment
[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org
Title: Message Title Cliff Meyers commented on JENKINS-42784 Re: Unable to create new pipeline for empty repo in brand new github org To clarify: any time you pick "single repo", the UI will respond to either the "org folder indexing complete" event or the "multi branch indexing complete" event, provided it's for the pipeline that corresponds to the selected repo. (Obviously we want to ignore the events from other pipelines that might have already been created). The first time through, if you pick a repo w/ no jenkinsfile, you'll get neither event - and therefore the timeout - because of this logic here: https://github.com/jenkinsci/blueocean-plugin/commit/5470506f1048c97a40ee8f16e21fe4b80f234dd3#diff-5e7377cad1cf9f0aa33fcc1e0cf62af9R120 There's no org indexing done at all, and the event for the multi-branch indexing never fires, because it never will if there's no jenkinsfile. Now, if you previously selected a repo and it contained a jenkinsfile, then selecting other repos will result in 'missing jenkinsfile" screen because the org indexing event does in fact fire at some point. Well, it probably will, at least hopefully within the first 60s timeout window. So I see a few ways to address this: UI only: if the user picked "single repo" and the 60s timeout is hit, show the "missing jenkinsfile" state anyways. If something flaky happened on the backend, it's possible that the Editor will open in an error state. Keith Zantow maybe you can provide some input there. It might actually work fine. Backend only: change the logic linked above so that the single repo case performs both the optimized "SCMSourceEvent.fireNow" call, and the "organizationFolder.scheduleBuild" as well. For repos w/ JF, that should preserve faster performance. For repos w/o JF, we should still get the "org folder indexing complete" event within the 60s window, which means the UI code isn't making the fuzzy "no event means no JF" assumption. Make both changes. This would give us extra insurance that if the user picked "single repo" that doesn't have a JF, AND the org indexing takes longer than 60s, that we still show the state where they can launch the editor. cc Vivek Pandey and Michael Neale for input. Add Comment
[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org
Title: Message Title Cliff Meyers started work on JENKINS-42784 Change By: Cliff Meyers Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org
Title: Message Title Cliff Meyers assigned an issue to Cliff Meyers Jenkins / JENKINS-42784 Unable to create new pipeline for empty repo in brand new github org Change By: Cliff Meyers Assignee: Keith Zantow Cliff Meyers Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org
Title: Message Title Cliff Meyers commented on JENKINS-42784 Re: Unable to create new pipeline for empty repo in brand new github org James Dumay is this an editor bug, or creation? If the latter, I'll certainly take it. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42719) Bug fixes / enhancements to Dropdown
Title: Message Title Cliff Meyers commented on JENKINS-42719 Re: Bug fixes / enhancements to Dropdown PR: https://github.com/jenkinsci/jenkins-design-language/pull/157 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42719) Bug fixes / enhancements to Dropdown
Title: Message Title Cliff Meyers updated JENKINS-42719 Jenkins / JENKINS-42719 Bug fixes / enhancements to Dropdown Change By: Cliff Meyers Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42719) Bug fixes / enhancements to Dropdown
Title: Message Title Cliff Meyers updated an issue Jenkins / JENKINS-42719 Bug fixes / enhancements to Dropdown Change By: Cliff Meyers While working JENKINS-42120 some bugs in the JDL Dropdown became evident:# (/) Need a way to programmatically select an option in the Dropdown, either via an exposed method or a prop.# (/) Adjust the height of dropdown to match that of standard button.# (/) Prevent NPE if "data" prop is null/undefined# (/) Need better UX if the "data" prop is an empty array. Right now an empty menu opens which looks odd. Should either prevent the menu from displaying, or perhaps display it with some kind of "no options" menu. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit
[JIRA] (JENKINS-42375) Browsing to creation when not having permissions
Title: Message Title Cliff Meyers updated JENKINS-42375 Jenkins / JENKINS-42375 Browsing to creation when not having permissions Change By: Cliff Meyers Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42719) Bug fixes / enhancements to Dropdown
Title: Message Title Cliff Meyers started work on JENKINS-42719 Change By: Cliff Meyers Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42719) Bug fixes / enhancements to Dropdown
Title: Message Title Cliff Meyers updated an issue Jenkins / JENKINS-42719 Bug fixes / enhancements to Dropdown Change By: Cliff Meyers Priority: Minor Major Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42719) Minor bug fixes / enhancements to Dropdown
Title: Message Title Cliff Meyers created an issue Jenkins / JENKINS-42719 Minor bug fixes / enhancements to Dropdown Issue Type: Bug Assignee: Cliff Meyers Components: blueocean-plugin Created: 2017/Mar/13 3:22 PM Priority: Minor Reporter: Cliff Meyers While working JENKINS-42120 some bugs in the JDL Dropdown became evident: Need a way to programmatically select an option in the Dropdown, either via an exposed method or a prop. Adjust the height of dropdown to match that of standard button. Prevent NPE if "data" prop is null/undefined Need better UX if the "data" prop is an empty array. Right now an empty menu opens which looks odd. Should either prevent the menu from displaying, or perhaps display it with some kind of "no options" menu. Add Comment
[JIRA] (JENKINS-42719) Bug fixes / enhancements to Dropdown
Title: Message Title Cliff Meyers updated an issue Jenkins / JENKINS-42719 Bug fixes / enhancements to Dropdown Change By: Cliff Meyers Summary: Minor bug Bug fixes / enhancements to Dropdown Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42120) Revisit Git repository creation flow credential setup
Title: Message Title Cliff Meyers updated JENKINS-42120 Jenkins / JENKINS-42120 Revisit Git repository creation flow credential setup Change By: Cliff Meyers Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42602) Improve publishing and sharing of pure JS modules/libraries
Title: Message Title Cliff Meyers edited a comment on JENKINS-42602 Re: Improve publishing and sharing of pure JS modules/libraries I think the shape this ticket takes depends a lot on where we land w/ the extensibility work.I know [~kzantow] and I have discussed that core-js could be largely obviated if "blueocean-personalization" could simply depend on "blueocean-dashboard" as a Maven dep, and then we had a little magic to pull the right JS dependencies downstream into node_modules. Then things like the Run/Replay buttons, the mobx services, etc could be used in both BO modules without being forced to put them in core-js.It seems to the follow then that "blueocean-dashboard" might depend on another plugin (perhaps "blueocean-web") that is providing all the necessary under the hood JS stuff (extension loading, React, etc). If someone wanted to build their own totally separate UI that had nothing to do with the BO UI, they'd just depend on "web" and not on "dashboard" .To me, those are the changes that would impact plugin developers.But even if we manage to eliminate core-js, we still have the JDL which I'm not sure we'd fold into anything else (but could). And then we still have a lot of smaller JS libs like js-builder, extensions, etc which should all have a uniform way of being published.I know one tool we looked at was "release-it" to simplify and formalize NPM publishing. Whatever we land on, I think it should be as close as possible to process we use to release and publish Maven plugins. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google
[JIRA] (JENKINS-42602) Improve publishing and sharing of pure JS modules/libraries
Title: Message Title Cliff Meyers commented on JENKINS-42602 Re: Improve publishing and sharing of pure JS modules/libraries I think the shape this ticket takes depends a lot on where we land w/ the extensibility work. I know Keith Zantow and I have discussed that core-js could be largely obviated if "blueocean-personalization" could simply depend on "blueocean-dashboard" as a Maven dep, and then we had a little magic to pull the right JS dependencies downstream into node_modules. Then things like the Run/Replay buttons, the mobx services, etc could be used in both BO modules without being forced to put them in core-js. It seems to the follow then that "blueocean-dashboard" might depend on another plugin (perhaps "blueocean-web") that is providing all the necessary under the hood JS stuff (extension loading, React, etc). If someone wanted to build their own totally separate UI that had nothing to do with the BO UI, they'd just depend on "web". To me, those are the changes that would impact plugin developers. But even if we manage to eliminate core-js, we still have the JDL which I'm not sure we'd fold into anything else (but could). And then we still have a lot of smaller JS libs like js-builder, extensions, etc which should all have a uniform way of being published. I know one tool we looked at was "release-it" to simplify and formalize NPM publishing. Whatever we land on, I think it should be as close as possible to process we use to release and publish Maven plugins. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues"
[JIRA] (JENKINS-42120) Revisit Git repository creation flow credential setup
Title: Message Title Cliff Meyers commented on JENKINS-42120 Re: Revisit Git repository creation flow credential setup This ticket is still in-progress but pending some merging and fixes in JENKINS-41397 that are currently in-progress. I think the UI work is basically done but I uncovered some unexpected behavior in the REST API while testing. Unfortunately testing this change is very time consuming given the permutations (roughly 2^5... SCM provider, repo visibility, URL scheme, credential type, credential validity). Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42123) No feedback when clicking "connect" when entering Github access key
Title: Message Title Cliff Meyers started work on JENKINS-42123 Change By: Cliff Meyers Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42375) Browsing to creation when not having permissions
Title: Message Title Cliff Meyers commented on JENKINS-42375 Re: Browsing to creation when not having permissions https://github.com/jenkinsci/blueocean-plugin/pull/890 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42375) Browsing to creation when not having permissions
Title: Message Title Cliff Meyers updated JENKINS-42375 Jenkins / JENKINS-42375 Browsing to creation when not having permissions Change By: Cliff Meyers Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42119) Creation design tweaks
Title: Message Title Cliff Meyers updated JENKINS-42119 Jenkins / JENKINS-42119 Creation design tweaks Change By: Cliff Meyers Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42507) SCM Buttons should be disabled while pipeline creation is in-progress
Title: Message Title Cliff Meyers updated an issue Jenkins / JENKINS-42507 SCM Buttons should be disabled while pipeline creation is in-progress Change By: Cliff Meyers The "scm buttons" (Git, Github) at the top of creation should disabled once creation begins.Per discussion here: https://github.com/jenkinsci/blueocean-plugin/pull/869#issuecomment-283495039Repro Steps:# Click "New Pipeline"# Select "Github"# Enter Github access token (if needed)# Select an organization# Select "auto discover"# Click "Create Pipeline"Expected Results# All form elements are disabled until creation completes (either successfully or unsuccessfully). Actual Results# SCM buttons "Git" and "Github" remain enabled. If clicked, they will wipe out the current creation flow.Note: this should be implemented for Git as well. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and
[JIRA] (JENKINS-42507) SCM Buttons should be disabled while pipeline creation is in-progress
Title: Message Title Cliff Meyers updated an issue Jenkins / JENKINS-42507 SCM Buttons should be disabled while pipeline creation is in-progress Change By: Cliff Meyers The "scm buttons" (Git, Github) at the top of creation should disable disabled once creation begins. Per discussion here: https://github.com/jenkinsci/blueocean-plugin/pull/869#issuecomment-283495039Repro Steps:# Click "New Pipeline"# Select "Github"# Enter Github access token (if needed)# Select an organization# Select "auto discover"# Click "Create Pipeline"Expected Results# All form elements are disabledActual Results# SCM buttons "Git" and "Github" remain enabled. If clicked, they will wipe out the current creation flow.Note: this should be implemented for Git as well. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to
[JIRA] (JENKINS-42507) SCM Buttons should be disabled while pipeline creation is in-progress
Title: Message Title Cliff Meyers created an issue Jenkins / JENKINS-42507 SCM Buttons should be disabled while pipeline creation is in-progress Issue Type: Bug Assignee: Unassigned Components: blueocean-plugin Created: 2017/Mar/06 4:32 PM Priority: Minor Reporter: Cliff Meyers The "scm buttons" (Git, Github) at the top of creation should disable Per discussion here: https://github.com/jenkinsci/blueocean-plugin/pull/869#issuecomment-283495039 Repro Steps: Click "New Pipeline" Select "Github" Enter Github access token (if needed) Select an organization Select "auto discover" Click "Create Pipeline" Expected Results All form elements are disabled Actual Results SCM buttons "Git" and "Github" remain enabled. If clicked, they will wipe out the current creation flow. Note: this should be implemented for Git as well.
[JIRA] (JENKINS-42501) Style Guide and JDL style refinements
Title: Message Title Cliff Meyers updated an issue Jenkins / JENKINS-42501 Style Guide and JDL style refinements Change By: Cliff Meyers # Remove unused fonts or font styles / variables# Remove unused mixins # Consider organizing components in cleaner subfolder structure Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42501) Style Guide and JDL style refinements
Title: Message Title Cliff Meyers updated an issue Jenkins / JENKINS-42501 Style Guide and JDL style refinements Change By: Cliff Meyers # May need to implement JENKINS-36858 first so that .less variables from JDL can be used in dashboard (and other modules) to avoid style duplication especially re: colors# Audit usage of colors across JDL and blueocean and streamline palette where possible# Remove unused fonts or font styles / variables# Remove unused mixins Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42385) Clean up JDL css colours
Title: Message Title Cliff Meyers commented on JENKINS-42385 Re: Clean up JDL css colours I think we should implement JENKINS-36858 ahead of this issue so that "dashboard" and other modules can easily get access to brand colors, etc where needed. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42501) Style Guide and JDL style refinements
Title: Message Title Cliff Meyers created an issue Jenkins / JENKINS-42501 Style Guide and JDL style refinements Issue Type: Task Assignee: Unassigned Components: blueocean-plugin Created: 2017/Mar/06 3:48 PM Priority: Minor Reporter: Cliff Meyers May need to implement JENKINS-36858 first so that .less variables from JDL can be used in dashboard (and other modules) to avoid style duplication especially re: colors Audit usage of colors across JDL and blueocean and streamline palette where possible Remove unused fonts or font styles / variables Remove unused mixins Add Comment
[JIRA] (JENKINS-42120) Revisit Git repository creation flow credential setup
Title: Message Title Cliff Meyers commented on JENKINS-42120 Re: Revisit Git repository creation flow credential setup Should there be some kind of close button on the Add Credential dialog? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42375) Browsing to creation when not having permissions
Title: Message Title Cliff Meyers started work on JENKINS-42375 Change By: Cliff Meyers Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42119) Creation design tweaks
Title: Message Title Cliff Meyers updated an issue Jenkins / JENKINS-42119 Creation design tweaks Change By: Cliff Meyers *Scope** (/) Spacing between creation flow and header* (/) Font size of headings* (/) Line should be faded* (/) I am not sure that the creation flow is the right Overall width ** Can we please check with [~brody] about the width of the creation flow and the centering rules? * (/) Github access key placeholder should be "Your Github access key"* Errors should end with an error step*Screenshots*_adjustments_ !creation.png|thumbnail! _error step_ !error-step.png|thumbnail! Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42120) Revisit Git repository creation flow credential setup
Title: Message Title Cliff Meyers started work on JENKINS-42120 Change By: Cliff Meyers Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42120) Revisit Git repository creation flow credential setup
Title: Message Title Cliff Meyers commented on JENKINS-42120 Re: Revisit Git repository creation flow credential setup When we folded JENKINS-41597 there were a few open questions that got lost. Here they are: If the user enters in an invalid URL (say for example https://github.com/cliffmeyers/repo-that-doesnt-exist) and presses "Create", do we show a validation error alongside the "Repository URL" title? Or are we going to show some kind of error step? If the user's access to the repo is denied (say private repo and invalid credential), do we show an error alongside the "Credentials" title? Or error step? There is a known issue where a user might enter a "https" URL and pick a SSH key credential - the SCM plugin won't allow this combo and falls back to anonymous access. Should we prevent this selection, show some kind of warning before actually proceeding, etc Similar to above, the same is true when the user picks a "ssh" URL and a username / password credential - it won't use that credential. cc Michael Neale as you might be able to facilitate some answers. Thanks Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop
[JIRA] (JENKINS-42120) Revisit Git repository creation flow credential setup
Title: Message Title Cliff Meyers assigned an issue to Cliff Meyers Jenkins / JENKINS-42120 Revisit Git repository creation flow credential setup Change By: Cliff Meyers Assignee: Cliff Meyers Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42120) Revisit Git repository creation flow credential setup
Title: Message Title Cliff Meyers commented on JENKINS-42120 Re: Revisit Git repository creation flow credential setup Brody Maclean James Dumay If it's not too much of a hassle, perhaps the screen shots could be updated with some small changes (see below). I know these screens inside/out but the rest of the team doesn't... so if they ever pick one of these tickets it up it may lead to confusion. The "Connect" step screenie is missing the Create Pipeline button. The "System SSH" option should be removed from Add Credential dialog. The reference to "Github" at the top of the Add Credential dialog should be removed. I am not sure if there should be different instructive text... it's reasonably self explanatory to me. Questions Is there any "success feedback" that should be shown either in the modal or the "Connect" step after the credential is created? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options,
[JIRA] (JENKINS-42119) Creation design tweaks
Title: Message Title Cliff Meyers commented on JENKINS-42119 Re: Creation design tweaks PR: https://github.com/jenkinsci/blueocean-plugin/pull/869/files Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42119) Creation design tweaks
Title: Message Title Cliff Meyers updated JENKINS-42119 Jenkins / JENKINS-42119 Creation design tweaks Change By: Cliff Meyers Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42119) Creation design tweaks
Title: Message Title Cliff Meyers commented on JENKINS-42119 Re: Creation design tweaks James Dumay if we receive an error at the end of Github, we currently do display an error step, although the copy is a little different since we are responding to an error in a specific step in the workflow. I also added a more generic error step that is capable of showing an excerpt of the error message returned by the server. It's possible there are some service calls are missing the right logic, but perhaps that can be done as part of a separate ticket? They aren't really "design tweaks" in my view (it would also help to keep the PR more targeted) Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42119) Creation design tweaks
Title: Message Title Cliff Meyers updated an issue Jenkins / JENKINS-42119 Creation design tweaks Change By: Cliff Meyers *Scope** (/) Spacing between creation flow and header* (/) Font size of headings* (/) Line should be faded* (/) I am not sure that the creation flow is the right width** Can we please check with [~brody] about the width of the flow and the centering rules?* (/) Github access key placeholder should be "Your Github access key"* Errors should end with an error step*Screenshots*_adjustments_ !creation.png|thumbnail! _error step_ !error-step.png|thumbnail! Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42119) Creation design tweaks
Title: Message Title Cliff Meyers updated an issue Jenkins / JENKINS-42119 Creation design tweaks Change By: Cliff Meyers *Scope** (/) Spacing between creation flow and header* (/) Font size of headings* Line should be faded* (/) I am not sure that the creation flow is the right width** Can we please check with [~brody] about the width of the flow and the centering rules?* (/) Github access key placeholder should be "Your Github access key"* Errors should end with an error step*Screenshots*_adjustments_ !creation.png|thumbnail! _error step_ !error-step.png|thumbnail! Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42119) Creation design tweaks
Title: Message Title Cliff Meyers edited a comment on JENKINS-42119 Re: Creation design tweaks Note: I changed the access token to placeholder to "Your Github access token" since they are referred to as "personal access tokens" on the Github site. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42119) Creation design tweaks
Title: Message Title Cliff Meyers commented on JENKINS-42119 Re: Creation design tweaks Note: I changed the access token to placeholder to "Your Github access token" since they are referred to as "personal access tokens" on the Github site. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
