[JIRA] (JENKINS-40645) podTemplate name field not used

2016-12-22 Thread garado...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gareth Harcombe-Minson created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-40645  
 
 
  podTemplate name field not used   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Carlos Sanchez  
 
 
Components: 
 kubernetes-plugin  
 
 
Created: 
 2016/Dec/22 8:47 PM  
 
 
Environment: 
 Version 0.10  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Gareth Harcombe-Minson  
 

  
 
 
 
 

 
 The README mentions a name field for the podTemplate, but it is ignored in PodTemplateExecution.java. It is instead set to a random UUID with the dashes stripped. I understand the need for the pod names to be unique, but kubernetes should take care of this on its own. Plus i'd like to use the job name here so I can easily see what job ran in recorded pod metrics later on.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
   

[JIRA] (JENKINS-38941) Cannot retrieve secrets if vault backend doesn't support fetching lists of secrets

2016-10-17 Thread garado...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gareth Harcombe-Minson commented on  JENKINS-38941  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Cannot retrieve secrets if vault backend doesn't support fetching lists of secrets   
 

  
 
 
 
 

 
 After looking at the source of the two projects, the best option might be to keep my workaround and specify the full path to the key in the build job. When you have such a restriction, i'm not sure either project could "do the right thing" and fetch the data appropriately.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-38941) Cannot retrieve secrets if vault backend doesn't support fetching lists of secrets

2016-10-17 Thread garado...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gareth Harcombe-Minson updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-38941  
 
 
  Cannot retrieve secrets if vault backend doesn't support fetching lists of secrets   
 

  
 
 
 
 

 
Change By: 
 Gareth Harcombe-Minson  
 
 
Comment: 
 I'll suggest an update to the java vault driver - maybe they should handle the 403 returned from vault and not this plugin.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-38941) Cannot retrieve secrets if vault backend doesn't support fetching lists of secrets

2016-10-17 Thread garado...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gareth Harcombe-Minson commented on  JENKINS-38941  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Cannot retrieve secrets if vault backend doesn't support fetching lists of secrets   
 

  
 
 
 
 

 
 I'll suggest an update to the java vault driver - maybe they should handle the 403 returned from vault and not this plugin.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-38941) Cannot retrieve secrets if vault backend doesn't support fetching lists of secrets

2016-10-17 Thread garado...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gareth Harcombe-Minson commented on  JENKINS-38941  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Cannot retrieve secrets if vault backend doesn't support fetching lists of secrets   
 

  
 
 
 
 

 
 Something tells me it's a specific configuration we have on preventing non admin's from listing secrets. I'm asking our team that manages it for the specific policy preventing it. If it is a configuration restriction, would you be interested in changing the underlying code to attempt individual key fetching in the event of a 403 on fetching the list?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-38941) Cannot retrieve secrets if vault backend doesn't support fetching lists of secrets

2016-10-12 Thread garado...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gareth Harcombe-Minson commented on  JENKINS-38941  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Cannot retrieve secrets if vault backend doesn't support fetching lists of secrets   
 

  
 
 
 
 

 
 Upon further investigation, we might have a very restrictive policy in place that is not allowing lists of keys to be returned. Just mentioning as it might not be specific to Consul backends. I also found a workaround - setting the secret path to a single key and only defining one value in the pair does succeed, though it is more verbose.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-38941) Cannot retrieve secrets if vault backend doesn't support fetching lists of secrets

2016-10-12 Thread garado...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gareth Harcombe-Minson edited a comment on  JENKINS-38941  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Cannot retrieve secrets if vault backend doesn't support fetching lists of secrets   
 

  
 
 
 
 

 
 Upon further investigation, we might have a very restrictive policy in place that is not allowing lists of keys to be returned. Just mentioning as it might not be specific to Consul backends.  I don't have access to the configuration of Vault being used here, so i'm unable to dig into the configutation too much. I also found a workaround - setting the secret path to a single key and only defining one value in the pair does succeed, though it is more verbose.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-38941) Cannot retrieve secrets if vault backend doesn't support fetching lists of secrets

2016-10-12 Thread garado...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gareth Harcombe-Minson created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-38941  
 
 
  Cannot retrieve secrets if vault backend doesn't support fetching lists of secrets   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Peter Tierno  
 
 
Components: 
 hashicorp-vault-plugin  
 
 
Created: 
 2016/Oct/12 8:52 PM  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Gareth Harcombe-Minson  
 

  
 
 
 
 

 
 Using Consul as a secret backend, the plugin fails to fetch data as it tries to make a single API call fetching a list of secrets at each path. Example: /secret/test/stuff contains thing1 and thing2. If API requests were made to /secret/test/stuff/thing1 and /secret/test/stuff/thing2 they would succeed, but the plugin tries to make a single request to /secret/test/stuff and iterate over the data returned. With consul as a backend, this single request returns a 403.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  

[JIRA] (JENKINS-38939) Update to vault-java-driver to 1.2.0 and support github token auth

2016-10-12 Thread garado...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gareth Harcombe-Minson updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-38939  
 
 
  Update to vault-java-driver to 1.2.0 and support github token auth   
 

  
 
 
 
 

 
Change By: 
 Gareth Harcombe-Minson  
 
 
Issue Type: 
 New Feature Improvement  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-38939) Update to vault-java-driver to 1.2.0 and support github token auth

2016-10-12 Thread garado...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gareth Harcombe-Minson created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-38939  
 
 
  Update to vault-java-driver to 1.2.0 and support github token auth   
 

  
 
 
 
 

 
Issue Type: 
  New Feature  
 
 
Assignee: 
 Peter Tierno  
 
 
Components: 
 hashicorp-vault-plugin  
 
 
Created: 
 2016/Oct/12 7:35 PM  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Gareth Harcombe-Minson  
 

  
 
 
 
 

 
 Now that 1.2.0 of the vault-java-driver is available, it would be excellent if this plugin added support for github auth. Would a PR be welcome for this change? Willing to dig into the plugin and work on adding github support.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment