[JIRA] (JENKINS-43131) Allow option to disable setting all cookies

2018-10-16 Thread jam...@dspsrv.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Coleman edited a comment on  JENKINS-43131  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Allow option to disable setting all cookies   
 

  
 
 
 
 

 
 just FYI and ForMyInformation too (I'm not requesting a change or fix on this).The issue about cookies without HttpOnly came up on security audit against jenkins we are using.I can see JSESSIONID cookies have HttpOnly option, other cookies hudson_auto_refresh and iconSize do not have the option set.I believe the correct response to this is that those cookies are not used as session cookies so not relevant in case of CSS attack.https://www.owasp.org/index.php/HttpOnly"Mitigating the Most Common XSS attack using HttpOnlyAccording to Michael Howard, Senior Security Program Manager in the Secure Windows Initiative group at Microsoft, the majority of XSS attacks target theft of session cookies. A server could help mitigate this issue by setting the HttpOnly flag on a cookie it creates, indicating the cookie should not be accessible on the client."https:// blog.codinghorror.com/protecting-your-cookies-httponly/"HttpOnly cookies can in fact be remarkably effective."https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies"cookies that persist server-side sessions don't need to be available to _javascript_, and the HttpOnly flag should be set."https:// security.stackexchange.com/questions/ 157133/is-a-secure-cookie-without-the-httponly-flag-a-problem"It's best to put httpOnly and secure flag for your session token."https://security.stackexchange.com/questions/ 43529/does-setting-httponly-prevent-stealing-a-session-using-xss "it's not worth much."So I believe for a CSS attack it is only useful to an attacker if a session cookie doesn't have HttpOnly set.Even with HttpOnly set it just mitigates against attack and doesn't make the attack impossible, other security measures must be used anyway to prevent attacks like this.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" 

[JIRA] (JENKINS-43131) Allow option to disable setting all cookies

2018-10-16 Thread jam...@dspsrv.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Coleman commented on  JENKINS-43131  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Allow option to disable setting all cookies   
 

  
 
 
 
 

 
 just FYI and ForMyInformation too (I'm not requesting a change or fix on this). The issue about cookies without HttpOnly came up on security audit against jenkins we are using. I can see JSESSIONID cookies have HttpOnly option, other cookies hudson_auto_refresh and iconSize do not have the option set. I believe the correct response to this is that those cookies are not used as session cookies so not relevant in case of CSS attack. https://www.owasp.org/index.php/HttpOnly "Mitigating the Most Common XSS attack using HttpOnly According to Michael Howard, Senior Security Program Manager in the Secure Windows Initiative group at Microsoft, the majority of XSS attacks target theft of session cookies. A server could help mitigate this issue by setting the HttpOnly flag on a cookie it creates, indicating the cookie should not be accessible on the client." https://security.stackexchange.com/questions/43529/does-setting-httponly-prevent-stealing-a-session-using-xss "it's not worth much." So I believe for a CSS attack it is only useful to an attacker if a session cookie doesn't have HttpOnly set. Even with HttpOnly set it just mitigates against attack and doesn't make the attack impossible, other security measures must be used anyway to prevent attacks like this.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40913) test run time totals for test suites in table is the run time for the first test suite

2017-01-09 Thread jam...@dspsrv.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Coleman created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-40913  
 
 
  test run time totals for test suites in table is the run time for the first test suite   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Varun Menon  
 
 
Attachments: 
 jenkins_TestResultsAnalyserPlugin_TestTimesInChart2Bugses.png  
 
 
Components: 
 test-results-analyzer-plugin  
 
 
Created: 
 2017/Jan/09 4:16 PM  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 James Coleman  
 

  
 
 
 
 

 
 st of all: really useful (and pretty  ) plugin. Thanks  @[LL LL|../ First of all: really useful (and pretty  ) plugin. Thanks  @[LL LL|../../../../../../../../../display/~ll], Hello, I would guess you are seeing the same bug as me - or a related bug. I see that there is something funny when showing test run times in table: 2 bugs I think. I have one test suite in each junit xml results file. I'm using latest Test Results Analyser Plugin 0.3.4. 1. I see that in the first column (for latest test run) that the run time shown for each test file and test suite is the same for all. The run time shown for all looks like the time for the first test suite. The run time shown for all looks matches the sum of time for each test in first test result file + a little extra. 2.  After the first column the time shown for junit xml file looks correct (matches the sum of time for each test). But the time shown for each test suite is the same as the first test suite of that column (or build).   
 

  
 
 
 
 

 
  

[JIRA] (JENKINS-38932) Support the ScriptTrigger (via XTrigger) plugin

2016-10-12 Thread jam...@dspsrv.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Coleman updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-38932  
 
 
  Support the ScriptTrigger (via XTrigger) plugin   
 

  
 
 
 
 

 
Change By: 
 James Coleman  
 

  
 
 
 
 

 
 I have ScriptTrigger installed under the XTrigger umbrella plugin for a few triggers.For ScriptTrigger triggered plugin if I access this URL:http:///job/jobname/jobnum/api/xml?xpath=//cause=causesI get this:[ScriptTrigger] and stuff printed by ScriptTrigger script.I will have a look at adding support. I get angry jenkins and "Oops!" and stackdump.The ScriptTrigger jobs are outputting incorrect xml for build cause. Oops!Stack tracejava.io.IOException: Failed to do XPath/wrapper handling. Turn on FINER logging to view XML. at hudson.model.Api.doXml(Api.java:161). . . .  at java.lang.Thread.run(Thread.java:745)Caused by: org.dom4j.DocumentException: Error on line 11 of document  : An invalid XML character (Unicode: 0xc) was found in the element content of the document. Nested exception: An invalid XML character (Unicode: 0xc) was found in the element content of the document.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 
  

[JIRA] (JENKINS-38932) Support the ScriptTrigger (via XTrigger) plugin

2016-10-12 Thread jam...@dspsrv.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Coleman created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-38932  
 
 
  Support the ScriptTrigger (via XTrigger) plugin   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Assignee: 
 Baptiste Mathus  
 
 
Components: 
 buildtriggerbadge-plugin  
 
 
Created: 
 2016/Oct/12 4:12 PM  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 James Coleman  
 

  
 
 
 
 

 
 I have ScriptTrigger installed under the XTrigger umbrella plugin for a few triggers. For ScriptTrigger triggered plugin if I access this URL: http:///job/jobname/jobnum/api/xml?xpath=//cause=causes I get this:[ScriptTrigger] and stuff printed by ScriptTrigger script.I will have a look at adding support. I get angry jenkins and "Oops!" and stackdump. The ScriptTrigger jobs are outputting incorrect xml for build cause.  Oops! Stack trace java.io.IOException: Failed to do XPath/wrapper handling. Turn on FINER logging to view XML. at hudson.model.Api.doXml(Api.java:161) . . . .  at java.lang.Thread.run(Thread.java:745) Caused by: org.dom4j.DocumentException: Error on line 11 of document : An invalid XML character (Unicode: 0xc) was found in the element content of the document. Nested exception: An invalid XML character (Unicode: 0xc) was found in the element content of the document.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

[JIRA] (JENKINS-28961) GET/POST with schedule-build-plugin

2016-10-05 Thread jam...@dspsrv.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Coleman commented on  JENKINS-28961  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: GET/POST with schedule-build-plugin   
 

  
 
 
 
 

 
 Upgrading to jenkins 2.7.4 solved the problem for me with CSRF Protection. I have now CSRF Protection enabled and Schedule Build Plugin from latest source on github working.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-28961) GET/POST with schedule-build-plugin

2016-10-05 Thread jam...@dspsrv.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Coleman edited a comment on  JENKINS-28961  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: GET/POST with schedule-build-plugin   
 

  
 
 
 
 

 
 Thanks for working on a fix for this!Confirmed fixed BUT needed to disable CSRF Protection to get it to work. :P= test latest plugin built from source: problem if CSRF Protection is enabled =When attempting to schedule a job it fails (quietly) and I get this in jenkins log:Oct 05, 2016 12:13:32 PM hudson.security.csrf.CrumbFilter doFilterWARNING: No valid crumb was included in request for /job/##jobname##/build. Returning 403.So I guess a crumb/token needs to be posted with the request - in the case where CSRF protection is enabled.e.g. "Remote access with CSRF protection enabled" describes how to do it on command-linehttps://wiki.jenkins-ci.org/display/JENKINS/Jenkins+Script+Console= test latest plugin built from source: works if CSRF Protection is disabled =I suppose I could disable CSRF Protection . . . yes, it works if CSRF Protection is disabled. :)https://wiki.jenkins-ci.org/display/JENKINS/CSRF+ProtectionOct 05, 2016 12:29:06 PM hudson.model.Run executeINFO:  publish_system_test_regression_README_to_jenkins  # #jobname## # 101 main build action completed: SUCCESS= test latest plugin released: problem reproduced "plugin offered a GET link" =Earlier I reproduced the problem described on this bug with latest available Schedule Build Plugin.I installed Schedule Build Plugin yesterday (Wed Oct 4th). Version 0.3.4 (release dated 16 Sep 2015).Icons for Schedule Build appear okay if build scheduled I got a warning "plugin offered a GET link" as reported on this bug.There did appear to be some sort of a job scheduled and it said it "expires in Xhr/min. Waiting for Ymin/hr." which was correct for the time I scheduled. BUT It did not run the job. :-( I couldn't find anything relevant in logs.Url, presumably the GET:http://jenkins:/job/jobname/build?delay=47212secI'm using Jenkins 2.2http://stackoverflow.com/questions/35029486/how-can-i-schedule-a-job-to-run-in-the-future-but-only-one-time-ever/39858002#39858002  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 

[JIRA] (JENKINS-28961) GET/POST with schedule-build-plugin

2016-10-05 Thread jam...@dspsrv.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Coleman edited a comment on  JENKINS-28961  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: GET/POST with schedule-build-plugin   
 

  
 
 
 
 

 
 Thanks for working on a fix for this!Confirmed fixed BUT needed to disable CSRF Protection to get it to work. :P= test latest plugin built from source: problem if CSRF Protection is enabled =When attempting to schedule a job it fails (quietly) and I get this in jenkins log:Oct 05, 2016 12:13:32 PM hudson.security.csrf.CrumbFilter doFilterWARNING: No valid crumb was included in request for /job/##jobname##/build. Returning 403.So I guess a crumb/token needs to be posted with the request - in the case where CSRF protection is enabled.e.g. "Remote access with CSRF protection enabled" describes how to do it on command-linehttps://wiki.jenkins-ci.org/display/JENKINS/Jenkins+Script+Console= test latest plugin built from source: works if CSRF Protection is disabled =I suppose I could disable CSRF Protection . . . yes, it works if CSRF Protection is disabled.  :) https://wiki.jenkins-ci.org/display/JENKINS/CSRF+ProtectionOct 05, 2016 12:29:06 PM hudson.model.Run executeINFO: publish_system_test_regression_README_to_jenkins #101 main build action completed: SUCCESS= test latest plugin released: problem reproduced "plugin offered a GET link" =Earlier I reproduced the problem described on this bug with latest available Schedule Build Plugin.I installed Schedule Build Plugin yesterday (Wed Oct 4th). Version 0.3.4 (release dated 16 Sep 2015).Icons for Schedule Build appear okay if build scheduled I got a warning "plugin offered a GET link" as reported on this bug.There did appear to be some sort of a job scheduled and it said it "expires in Xhr/min. Waiting for Ymin/hr." which was correct for the time I scheduled. BUT It did not run the job. :-( I couldn't find anything relevant in logs.Url, presumably the GET:http://jenkins:/job/jobname/build?delay=47212secI'm using Jenkins 2.2http://stackoverflow.com/questions/35029486/how-can-i-schedule-a-job-to-run-in-the-future-but-only-one-time-ever/39858002#39858002  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
   

[JIRA] (JENKINS-28961) GET/POST with schedule-build-plugin

2016-10-05 Thread jam...@dspsrv.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Coleman commented on  JENKINS-28961  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: GET/POST with schedule-build-plugin   
 

  
 
 
 
 

 
 Thanks for working on a fix for this! Confirmed fixed BUT needed to disable CSRF Protection to get it to work.  = test latest plugin built from source: problem if CSRF Protection is enabled = When attempting to schedule a job it fails (quietly) and I get this in jenkins log:  Oct 05, 2016 12:13:32 PM hudson.security.csrf.CrumbFilter doFilter WARNING: No valid crumb was included in request for /job/##jobname##/build. Returning 403. So I guess a crumb/token needs to be posted with the request - in the case where CSRF protection is enabled. e.g. "Remote access with CSRF protection enabled" describes how to do it on command-line https://wiki.jenkins-ci.org/display/JENKINS/Jenkins+Script+Console = test latest plugin built from source: works if CSRF Protection is disabled = I suppose I could disable CSRF Protection . . . yes, it works if CSRF Protection is disabled. https://wiki.jenkins-ci.org/display/JENKINS/CSRF+Protection  Oct 05, 2016 12:29:06 PM hudson.model.Run execute INFO: publish_system_test_regression_README_to_jenkins #101 main build action completed: SUCCESS = test latest plugin released: problem reproduced "plugin offered a GET link" = Earlier I reproduced the problem described on this bug with latest available Schedule Build Plugin. I installed Schedule Build Plugin yesterday (Wed Oct 4th). Version 0.3.4 (release dated 16 Sep 2015). Icons for Schedule Build appear okay if build scheduled I got a warning "plugin offered a GET link" as reported on this bug. There did appear to be some sort of a job scheduled and it said it "expires in Xhr/min. Waiting for Ymin/hr." which was correct for the time I scheduled.  BUT It did not run the job.  I couldn't find anything relevant in logs. Url, presumably the GET: http://jenkins:/job/jobname/build?delay=47212sec I'm using Jenkins 2.2 http://stackoverflow.com/questions/35029486/how-can-i-schedule-a-job-to-run-in-the-future-but-only-one-time-ever/39858002#39858002  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
   

[JIRA] [packaging] (JENKINS-33776) Cannot start from preview rpm

2016-05-11 Thread jam...@dspsrv.com (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 James Coleman commented on  JENKINS-33776 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Cannot start from preview rpm  
 
 
 
 
 
 
 
 
 
 
Yes, that's okay. Good to have error and solution described here as it will help anyone who might encounter it. Thanks Daniel. J. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [packaging] (JENKINS-33776) Cannot start from preview rpm

2016-05-10 Thread jam...@dspsrv.com (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 James Coleman commented on  JENKINS-33776 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Cannot start from preview rpm  
 
 
 
 
 
 
 
 
 
 
Hi Daniel,  
I'm pretty sure I didn't customize /etc/sysconfig/jenkins . . I think maybe my problem was because of .war install and not rpm install. Good to find this bug as could see how to solve problem. 
I didn't get a /etc/sysconfig/jenkins.rpmnew. I didn't do an rpm upgrade, when I clicked upgrade the .war file was downloaded.  So I swapped that in. 
It was old enough version of jenkins I was going from as well. 
Thanks. James. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [packaging] (JENKINS-33776) Cannot start from preview rpm

2016-05-10 Thread jam...@dspsrv.com (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 James Coleman commented on  JENKINS-33776 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Cannot start from preview rpm  
 
 
 
 
 
 
 
 
 
 
I hit this problem going from 1.562 to 2.2 via update of war file. I did not have customisations in /etc/sysconfig/jenkins Setting JENKINS_AJP_PORT="-1" in /etc/sysconfig/jenkins solved problem. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [cvs] (JENKINS-23234) cvs update hang when recursive symlink in directory

2014-06-11 Thread jam...@dspsrv.com (JIRA)














































James Coleman
 commented on  JENKINS-23234


cvs update hang when recursive symlink in directory















Certainly, does that mean I should push the commits I have made?
I should tidy up the messy debug :-7
I will google "raise these as Pull Requests".
James.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [cvs] (JENKINS-23234) cvs update hang when recursive symlink in directory

2014-06-11 Thread jam...@dspsrv.com (JIRA)














































James Coleman
 commented on  JENKINS-23234


cvs update hang when recursive symlink in directory















pull requests are raised . . .
https://github.com/jenkinsci/cvs-plugin/pull/31
https://github.com/mc1arke/cvsclient/pull/3

Changes tidied, rebuilt cleanly, installed and tested. 

Thanks Michael, Hope those are okay. Appreciate you having a look at them. James.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [cvs] (JENKINS-23234) cvs update hang when recursive symlink in directory

2014-06-10 Thread jam...@dspsrv.com (JIRA)














































James Coleman
 updated  JENKINS-23234


cvs update hang when recursive symlink in directory
















netbeans cvsclient lib patch to prevent infinate loop if recursive symlink loop upon cvs update. 





Change By:


James Coleman
(10/Jun/14 1:03 PM)




Attachment:


0001-ignore-Sym-Links-isSymLink-For-BasicCommand-in-2-pla.patch



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [cvs] (JENKINS-23234) cvs update hang when recursive symlink in directory

2014-06-10 Thread jam...@dspsrv.com (JIRA)














































James Coleman
 commented on  JENKINS-23234


cvs update hang when recursive symlink in directory















Changes are needed in (at least) 2 places:

 1. In netbeans cvsclient library - cvs update goes into infinate loop following symlinks
I think I have a working change for this.
On cvsclient which is forked in github for jenkins: 
  https://github.com/mc1arke/cvsclient
I will attach patch for this.

 2. In CVS plugin in jenkins.
Change needed in several places I think.
Where cvs update and cvs rlog build file lists at least.
I'm not too familliar with debugging java and finding it tricky to track down where in the code a java process is getting stuck in infinate loop.





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [cvs] (JENKINS-23234) cvs update hang when recursive symlink in directory

2014-06-10 Thread jam...@dspsrv.com (JIRA)














































James Coleman
 updated  JENKINS-23234


cvs update hang when recursive symlink in directory
















cvsplugin part of fix for this issue. Avoid infinate loops by ignoring symbolic links when getting list of files (in cleanup in pruneEmptyDirectories and in buildFileList). Both patches have extra debug which would need to be removed/tidied.





Change By:


James Coleman
(10/Jun/14 3:49 PM)




Attachment:


0001-cvsplugin-part-of-fix-for-JENKINS-23234-cvs-update-h.patch



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [cvs] (JENKINS-23234) cvs update hang when recursive symlink in directory

2014-05-30 Thread jam...@dspsrv.com (JIRA)














































James Coleman
 updated  JENKINS-23234


cvs update hang when recursive symlink in directory
















Change By:


James Coleman
(30/May/14 10:58 AM)




Description:


Jenkinsjobhangsforeverdoingcvsupdate.Arecursivedirectorycausesjobtohangforever.
Thecvscommandshowninconsolelogis:cvsupdate-d-P-rbranchtagmodApreviousbuildjobcreatedsymlinksto.insomedirectoriesincheckoutarea.
Usingstracecanseeprocessisrecursingintodirectorytomultiplelevels...
Apreviousbuildjobcreatedsymlinks
itishittinganerrorbutjustseems
to
takeforever
.
insomedirectoriesincheckoutarea
.
.notsureifjobswilleverendbyselves...postingstoptojenkinsjobdoesntwork,thejobremainsrunninguntiljenkinsitselfisrestartedORprocesskilled(whichbringsdownjenkins).

Theerror:ELOOP(Toomanylevelsofsymboliclinks)stracefragment:stat64(/var/lib/jenkins/jobs/buildjobname/workspace/work/projectname/module/something/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/python/python/misc/java/java/python/java/inc/misc/inc/call_id.py,{st_mode=S_IFREG|0664,st_size=3749,...})=0stat64(/var/lib/jenkins/jobs/buildjobname/workspace/work/projectname/module/something/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/python/python/misc/java/java/python/java/inc/misc/inc/Module.versions.release,{st_mode=S_IFREG|0644,st_size=345,...})=0stat64(/var/lib/jenkins/jobs/buildjobname/workspace/work/projectname/module/something/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/python/python/misc/java/java/python/java/inc/misc/inc/libims_call_id.exp,{st_mode=S_IFREG|0644,st_size=227,...})=0stat64(/var/lib/jenkins/jobs/buildjobname/workspace/work/projectname/module/something/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/python/python/misc/java/java/python/java/inc/misc/inc/misc,0x66b18060)=-1ELOOP(Toomanylevelsofsymboliclinks)
CVSPlugin2.11http://wiki.jenkins-ci.org/display/JENKINS/CVS+PluginJenkinsver.1.562Thisproblemwithgitpluginseemstohavebeenasimilarproblem:https://issues.jenkins-ci.org/browse/JENKINS-17186Linux:ifthereisarecursivedirectorywithinthegitrepoyourebuilding,theinitialcheckoutwillfailbadly



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [cvs] (JENKINS-23234) cvs update hang when recursive symlink in directory

2014-05-30 Thread jam...@dspsrv.com (JIRA)














































James Coleman
 updated  JENKINS-23234


cvs update hang when recursive symlink in directory
















Change By:


James Coleman
(30/May/14 11:00 AM)




Description:


Jenkinsjobhangsforeverdoingcvsupdate.Arecursivedirectorycausesjobtohangforever.Thecvscommandshowninconsolelogis:cvsupdate-d-P-rbranchtagmodApreviousbuildjobcreatedsymlinksto.insomedirectoriesincheckoutarea.Usingstracecanseeprocessisrecursingintodirectorytomultiplelevels...itishittinganerrorbutjustseemstotakeforever...notsureifjobswilleverendbyselves...postingstoptojenkinsjobdoesntwork,thejobremainsrunninguntiljenkinsitselfisrestartedORprocesskilled(whichbringsdownjenkins).Theerror:ELOOP(Toomanylevelsofsymboliclinks)stracefragment:
(miscisasymlinkto.)
stat64(/var/lib/jenkins/jobs/buildjobname/workspace/work/projectname/module/something/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/python/python/misc/java/java/python/java/inc/misc/inc/
call_id
something
.py,{st_mode=S_IFREG|0664,st_size=3749,...})=0stat64(/var/lib/jenkins/jobs/buildjobname/workspace/work/projectname/module/something/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/python/python/misc/java/java/python/java/inc/misc/inc/
Module.versions.release
something
,{st_mode=S_IFREG|0644,st_size=345,...})=0stat64(/var/lib/jenkins/jobs/buildjobname/workspace/work/projectname/module/something/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/python/python/misc/java/java/python/java/inc/misc/inc/
libims_call_id.exp
somethingelse
,{st_mode=S_IFREG|0644,st_size=227,...})=0stat64(/var/lib/jenkins/jobs/buildjobname/workspace/work/projectname/module/something/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/misc/python/python/misc/java/java/python/java/inc/misc/inc/misc,0x66b18060)=-1ELOOP(Toomanylevelsofsymboliclinks)CVSPlugin2.11http://wiki.jenkins-ci.org/display/JENKINS/CVS+PluginJenkinsver.1.562Thisproblemwithgitpluginseemstohavebeenasimilarproblem:https://issues.jenkins-ci.org/browse/JENKINS-17186Linux:ifthereisarecursivedirectorywithinthegitrepoyourebuilding,theinitialcheckoutwillfailbadly



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [cvs] (JENKINS-23234) cvs update hang when recursive symlink in directory

2014-05-30 Thread jam...@dspsrv.com (JIRA)














































James Coleman
 commented on  JENKINS-23234


cvs update hang when recursive symlink in directory















Interesting to compare with behaviour of gnu cvs client.
Regular cvs behaviour (generally but upon update in particular) is to ignore symlinks.
See function special_file_mismatch in update.c (and function islink in filesubr.c) in cvs source code.
http://cvs.savannah.gnu.org/viewvc/cvs/ccvs/src/update.c?revision=HEADview=markup
Probably the same should be done by jenkins CVS Plugin.

Otherwise would need to add intelligence on finding symlink loops.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [git] (JENKINS-17186) Linux: if there is a recursive directory within the git repo you're building, the initial checkout will fail badly

2014-05-29 Thread jam...@dspsrv.com (JIRA)














































James Coleman
 commented on  JENKINS-17186


Linux: if there is a recursive directory within the git repo youre building, the initial checkout will fail badly















There seems to be a similar problem with cvs plugin upon cvs update.
A recursive directory causes job to hang forever.
Using strace can see process is recursing into directory to multiple levels . . .  
CVS Plugin 2.11
http://wiki.jenkins-ci.org/display/JENKINS/CVS+Plugin
Jenkins ver. 1.562



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [cvs] (JENKINS-23234) cvs update hang when recursive symlink in directory

2014-05-29 Thread jam...@dspsrv.com (JIRA)














































James Coleman
 created  JENKINS-23234


cvs update hang when recursive symlink in directory















Issue Type:


Bug



Affects Versions:


current



Assignee:


Unassigned


Components:


cvs



Created:


29/May/14 3:16 PM



Description:


Jenkins job hangs forever doing cvs update.

A recursive directory causes job to hang forever.
Using strace can see process is recursing into directory to multiple levels . . .  
A previous build job created symlinks to . in some directories in checkout area.

CVS Plugin 2.11
http://wiki.jenkins-ci.org/display/JENKINS/CVS+Plugin
Jenkins ver. 1.562

This problem with git plugin seems to have been a similar problem:
https://issues.jenkins-ci.org/browse/JENKINS-17186
Linux: if there is a recursive directory within the git repo you're building, the initial checkout will fail badly




Environment:


redhat fc19

jenkins 1.562 

cvs_plugin 2.11

cvs ssh 




Project:


Jenkins



Priority:


Major



Reporter:


James Coleman

























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.