[JIRA] (JENKINS-21942) Unreliable defaulting of Jenkins.workspaceDir
Title: Message Title
Kanstantsin Shautsou edited a comment on JENKINS-21942
Re: Unreliable defaulting of Jenkins.workspaceDir
Now it's impossible to run Jenkins on relative dir path. If i pass into jenkins rule {{target/somedir}} it fails because Jenkins instance itself can work without issues, but this check throws and fails. Fresh Jenkins object has no config.xml in JenkinsRule, then checks {{checkRawBuildsDir(buildsDir);}} where {{buildDir}} is {{"${ITEM_ROOTDIR}/builds"}} by default (stacktrace from 2.176.4) {code:java}08:51:16 org.jvnet.hudson.reactor.ReactorException: java.io.IOException: jenkins.model.InvalidBuildsDir: ${ITEM_ROOTDIR}/builds does not resolve to an absolute path08:51:16 at org.jvnet.hudson.reactor.Reactor.execute(Reactor.java:282)08:51:16 at jenkins.InitReactorRunner.run(InitReactorRunner.java:48)08:51:16 at jenkins.model.Jenkins.executeReactor(Jenkins.java:1129)08:51:16 at jenkins.model.Jenkins.(Jenkins.java:936)08:51:16 at hudson.model.Hudson.(Hudson.java:85)08:51:16 at org.jvnet.hudson.test.JenkinsRule.newHudson(JenkinsRule.java:675)08:51:16 at org.jvnet.hudson.test.JenkinsRule.before(JenkinsRule.java:402)08:51:16 at org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:595)08:51:16 at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)08:51:16 at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)08:51:16 at java.util.concurrent.FutureTask.run(FutureTask.java:266)08:51:16 at java.lang.Thread.run(Thread.java:748)08:51:16 Caused by: java.io.IOException: jenkins.model.InvalidBuildsDir: ${ITEM_ROOTDIR}/builds does not resolve to an absolute path08:51:16 at jenkins.model.Jenkins.loadConfig(Jenkins.java:3050)08:51:16 at jenkins.model.Jenkins.access$1200(Jenkins.java:310)08:51:16 at jenkins.model.Jenkins$13.run(Jenkins.java:3145)08:51:16 at org.jvnet.hudson.reactor.TaskGraphBuilder$TaskImpl.run(TaskGraphBuilder.java:169)08:51:16 at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:296)08:51:16 at jenkins.model.Jenkins$5.runTask(Jenkins.java:1095)08:51:16 at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:214)08:51:16 at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117)08:51:16 at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)08:51:16 at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)08:51:16 ... 1 more08:51:16 Caused by: jenkins.model.InvalidBuildsDir: ${ITEM_ROOTDIR}/builds does not resolve to an absolute path08:51:16 at jenkins.model.Jenkins.checkRawBuildsDir(Jenkins.java:3101)08:51:16 at jenkins.model.Jenkins.loadConfig(Jenkins.java:3047)08:51:16 ... 10 more{code}
Add Comment
[JIRA] (JENKINS-21942) Unreliable defaulting of Jenkins.workspaceDir
Title: Message Title
Kanstantsin Shautsou commented on JENKINS-21942
Re: Unreliable defaulting of Jenkins.workspaceDir
Now it's impossible to run Jenkins on relative dir path. If i pass into jenkins rule target/somedir it fails because Jenkins instance itself can work without issues, but this check throws and fails. Fresh Jenkins object has no config.xml in JenkinsRule, then checks {{ checkRawBuildsDir(buildsDir);}} where buildDir is "${ITEM_ROOTDIR}/builds" by default
08:51:16 org.jvnet.hudson.reactor.ReactorException: java.io.IOException: jenkins.model.InvalidBuildsDir: ${ITEM_ROOTDIR}/builds does not resolve to an absolute path
08:51:16 at org.jvnet.hudson.reactor.Reactor.execute(Reactor.java:282)
08:51:16 at jenkins.InitReactorRunner.run(InitReactorRunner.java:48)
08:51:16 at jenkins.model.Jenkins.executeReactor(Jenkins.java:1129)
08:51:16 at jenkins.model.Jenkins.(Jenkins.java:936)
08:51:16 at hudson.model.Hudson.(Hudson.java:85)
08:51:16 at org.jvnet.hudson.test.JenkinsRule.newHudson(JenkinsRule.java:675)
08:51:16 at org.jvnet.hudson.test.JenkinsRule.before(JenkinsRule.java:402)
08:51:16 at org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:595)
08:51:16 at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
08:51:16 at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
08:51:16 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
08:51:16 at java.lang.Thread.run(Thread.java:748)
08:51:16 Caused by: java.io.IOException: jenkins.model.InvalidBuildsDir: ${ITEM_ROOTDIR}/builds does not resolve to an absolute path
08:51:16 at jenkins.model.Jenkins.loadConfig(Jenkins.java:3050)
08:51:16 at jenkins.model.Jenkins.access$1200(Jenkins.java:310)
08:51:16 at jenkins.model.Jenkins$13.run(Jenkins.java:3145)
08:51:16 at org.jvnet.hudson.reactor.TaskGraphBuilder$TaskImpl.run(TaskGraphBuilder.java:169)
08:51:16 at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:296)
08:51:16 at jenkins.model.Jenkins$5.runTask(Jenkins.java:1095)
08:51:16 at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:214)
08:51:16 at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117)
08:51:16 at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
08:51:16 at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
08:51:16 ... 1 more
08:51:16 Caused by: jenkins.model.InvalidBuildsDir: ${ITEM_ROOTDIR}/builds does not resolve to an absolute path
08:51:16 at jenkins.model.Jenkins.checkRawBuildsDir(Jenkins.java:3101)
08:51:16 at jenkins.model.Jenkins.loadConfig(Jenkins.java:3047)
08:51:16 ... 10 more
[JIRA] (JENKINS-59468) addAction, replaceAction doesn't work on AbstractProject
Title: Message Title Kanstantsin Shautsou updated an issue Jenkins / JENKINS-59468 addAction, replaceAction doesn't work on AbstractProject Change By: Kanstantsin Shautsou Issue Type: New Feature Improvement Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202069.156907180.2152.156907281%40Atlassian.JIRA.
[JIRA] (JENKINS-59468) addAction, replaceAction doesn't work on AbstractProject
Title: Message Title Kanstantsin Shautsou created an issue Jenkins / JENKINS-59468 addAction, replaceAction doesn't work on AbstractProject Issue Type: New Feature Assignee: Unassigned Components: core Created: 2019-09-21 13:16 Priority: Minor Reporter: Kanstantsin Shautsou Historically getActions() is locked to return unmodifiable list, while add/replace methods are using it. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
[JIRA] (JENKINS-59415) Pass run/build object into decorateFetchCommand for GitSCMExtension
Title: Message Title
Kanstantsin Shautsou updated an issue
Jenkins / JENKINS-59415
Pass run/build object into decorateFetchCommand for GitSCMExtension
Change By:
Kanstantsin Shautsou
During build scm checkout fetch and clone are happenning {{hudson . plugins.git.GitSCM#retrieveChanges}} {{decorateCloneCommand}} has {{Run}} in arguments, but {{decorateFetchCommand}} hasn't. Need to know build context for decoration.
Add Comment
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201977.1568770277000.5769.1568770440185%40Atlassian.JIRA.
[JIRA] (JENKINS-59415) Pass run/build object into decorateFetchCommand for GitSCMExtension
Title: Message Title
Kanstantsin Shautsou updated an issue
Jenkins / JENKINS-59415
Pass run/build object into decorateFetchCommand for GitSCMExtension
Change By:
Kanstantsin Shautsou
During build scm checkout fetch and clone are happenning. {{decorateCloneCommand}} has {{ Run }} in arguments, but {{decorateFetchCommand}} doesn hasn 't. Need to know build context for decoration.
Add Comment
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201977.1568770277000.5767.1568770380130%40Atlassian.JIRA.
[JIRA] (JENKINS-59415) Pass run/build object into decorateFetchCommand for GitSCMExtension
Title: Message Title Kanstantsin Shautsou created an issue Jenkins / JENKINS-59415 Pass run/build object into decorateFetchCommand for GitSCMExtension Issue Type: New Feature Assignee: Mark Waite Components: git-plugin Created: 2019-09-18 01:31 Priority: Minor Reporter: Kanstantsin Shautsou During build scm checkout fetch and clone are happenning. decorateCloneCommand has Run in arguments, but decorateFetchCommand doesn't. Add Comment This message was sent by Atlassian Jira
[JIRA] (JENKINS-55579) I suggest to add an ability to disable dashboard widget or deactivate plugin at all
Title: Message Title Kanstantsin Shautsou commented on JENKINS-55579 Re: I suggest to add an ability to disable dashboard widget or deactivate plugin at all As administrator i'm not interested in widgets because they are fixed width size. Separate page is more useful (already exists). Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.196743.1547475231000.19682.1563907140363%40Atlassian.JIRA.
[JIRA] (JENKINS-58434) ComputerListener onRemoved
Title: Message Title Kanstantsin Shautsou created an issue Jenkins / JENKINS-58434 ComputerListener onRemoved Issue Type: New Feature Assignee: Unassigned Components: core Created: 2019-07-10 21:18 Priority: Minor Reporter: Kanstantsin Shautsou Need a way to close file tied to node. Current ComputerListener has only nofications related to Node (offline/online Computer actions)> Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
[JIRA] (JENKINS-51203) Slave.setNodeProperties is unreliable and inefficient
Title: Message Title Kanstantsin Shautsou commented on JENKINS-51203 Re: Slave.setNodeProperties is unreliable and inefficient One more possible chain how to get into this error code 04:25:05 Caused by: java.nio.file.NoSuchFileException: /jenkins/jenkins-work/nodes/yadp877105322/atomic113511861761462995tmp 04:25:05 at sun.nio.fs.UnixException.translateToIOException(UnixException.java:86) 04:25:05 at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102) 04:25:05 at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107) 04:25:05 at sun.nio.fs.UnixCopyFile.move(UnixCopyFile.java:409) 04:25:05 at sun.nio.fs.UnixFileSystemProvider.move(UnixFileSystemProvider.java:262) 04:25:05 at java.nio.file.Files.move(Files.java:1395) 04:25:05 at hudson.util.AtomicFileWriter.commit(AtomicFileWriter.java:206) 04:25:05 at hudson.XmlFile.write(XmlFile.java:198) 04:25:05 at jenkins.model.Nodes.save(Nodes.java:274) 04:25:05 at hudson.util.PersistedList.onModified(PersistedList.java:173) 04:25:05 at hudson.util.PersistedList.replaceBy(PersistedList.java:85) 04:25:05 at hudson.model.Slave.(Slave.java:198) 04:25:05 at hudson.slaves.AbstractCloudSlave.(AbstractCloudSlave.java:51) code Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.190519.152578996.4651.1561041840927%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51203) Slave.setNodeProperties is unreliable and inefficient
Title: Message Title
Kanstantsin Shautsou edited a comment on JENKINS-51203
Re: Slave.setNodeProperties is unreliable and inefficient
One more possible chain how to get into this error { { code} } 04:25:05 Caused by: java.nio.file.NoSuchFileException: /jenkins/jenkins-work/nodes/yadp877105322/atomic113511861761462995tmp04:25:05 at sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)04:25:05 at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)04:25:05 at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)04:25:05 at sun.nio.fs.UnixCopyFile.move(UnixCopyFile.java:409)04:25:05 at sun.nio.fs.UnixFileSystemProvider.move(UnixFileSystemProvider.java:262)04:25:05 at java.nio.file.Files.move(Files.java:1395)04:25:05 at hudson.util.AtomicFileWriter.commit(AtomicFileWriter.java:206)04:25:05 at hudson.XmlFile.write(XmlFile.java:198)04:25:05 at jenkins.model.Nodes.save(Nodes.java:274)04:25:05 at hudson.util.PersistedList.onModified(PersistedList.java:173)04:25:05 at hudson.util.PersistedList.replaceBy(PersistedList.java:85)04:25:05 at hudson.model.Slave.(Slave.java:198)04:25:05 at hudson.slaves.AbstractCloudSlave.(AbstractCloudSlave.java:51){ { code} }
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.190519.152578996.4653.1561041840969%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51947) Symbol from unrelated Extension point conflicts with syntax?
Title: Message Title Kanstantsin Shautsou commented on JENKINS-51947 Re: Symbol from unrelated Extension point conflicts with syntax? Hi, issues discussion is here https://github.com/KostyaSha/github-integration-plugin/issues/274 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.191436.152899281.12154.1558905000119%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56404) Impossible exclude redundant/double fetches
Title: Message Title Kanstantsin Shautsou updated an issue Jenkins / JENKINS-56404 Impossible exclude redundant/double fetches Change By: Kanstantsin Shautsou Priority: Minor Critical Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56404) Impossible exclude redundant/double fetches
Title: Message Title Kanstantsin Shautsou commented on JENKINS-56404 Re: Impossible exclude redundant/double fetches "It is an intentional choice to retain compatibility with the existing (flawed) behavior of using a default refspec which fetches all branches. Too many users depend on fetching all branches without realizing they have that dependency. If the default behavior were changed, they would need to adjust the definitions of those jobs." That absolutely unrelated, refspec must tbe added only when repositories are not defined, but they are DEFINED and ignored, code is taking ONLY origin name from the first repository (refspec). ", the refspec is honored in both fetches that occur. " It shouldn't do two fetches, on huge instances it's only adding unneeded load on git server - this is a BUG. When refspecs (repositories) are clearly specified it's fetching ANYWAY all branches, because it takes from the list of repositories. In current situatiton it's IMPOSSIBLE to avoid double fetches: impossible to inherite and reimplement retrieve method, impossible to exclude fetch during clone or exclude all fetches that happen later. This is critical for performance and huge instances. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56404) Impossible exclude redundant/double fetches
Title: Message Title Kanstantsin Shautsou updated an issue Jenkins / JENKINS-56404 Impossible exclude redundant/double fetches Change By: Kanstantsin Shautsou When hasGitRepo is false , retrieveChanges () tries firstly to Clone repository and then fetch according to available list of repositories. https://github.com/jenkinsci/git-plugin/blob/e9d15cd3a390f1d1849b9d6cbee707bc85213ab0/src/main/java/hudson/plugins/git/GitSCM.java#L1104-L1110But when it clones it picks first repository name and injects ALL branches fetch https://github.com/jenkinsci/git-client-plugin/blob/2b217bd90a93462112176febbb5f30e05141c674/src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java#L704-L712 When So, when refspecs is empty - it fetch all branches (git default), when it null it fetches all branches. The workaround is to set some refspec from branch i.e. https://github.com/jenkinsci/git-plugin/blob/a7ad6eb38a00397c4a656b53d99bfbad8ea3b2cc/src/main/java/jenkins/plugins/git/GitSCMSourceDefaults.java#L108-L115But, later it will be fetched anyway. Solution:Don't fetch anything during clone operation (useful part is clean, fetch etc). OR pass repositories to CloneComand and remove separate fetch iteration . Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues"
[JIRA] (JENKINS-56404) Impossible exclude redundant/double fetches
Title: Message Title Kanstantsin Shautsou created an issue Jenkins / JENKINS-56404 Impossible exclude redundant/double fetches Issue Type: Bug Assignee: Mark Waite Components: git-client-plugin, git-plugin Created: 2019-03-05 01:41 Priority: Minor Reporter: Kanstantsin Shautsou When hasGitRepo is false retrieveChanges tries firstly to Clone repository and then fetch according to available list of repositories. https://github.com/jenkinsci/git-plugin/blob/e9d15cd3a390f1d1849b9d6cbee707bc85213ab0/src/main/java/hudson/plugins/git/GitSCM.java#L1104-L1110 But when it clones it picks first repository name and injects ALL branches fetch https://github.com/jenkinsci/git-client-plugin/blob/2b217bd90a93462112176febbb5f30e05141c674/src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java#L704-L712 When refspecs is empty - it fetch all branches (git default), when it null it fetches all branches. The workaround is to set some refspec from branch i.e. https://github.com/jenkinsci/git-plugin/blob/a7ad6eb38a00397c4a656b53d99bfbad8ea3b2cc/src/main/java/jenkins/plugins/git/GitSCMSourceDefaults.java#L108-L115 But, later it will be fetched anyway. Solution: Don't fetch anything during clone operation (useful part is clean, fetch etc). OR pass repositories to CloneComand and remove separate fetch iteration .
[JIRA] (JENKINS-54980) Jobs are stopped being triggered - java.lang.NullPointerException: There is no credentials with admin access to manage hooks on GitHubRepositoryName[host=github.com,username=myo
Title: Message Title Kanstantsin Shautsou commented on JENKINS-54980 Re: Jobs are stopped being triggered - java.lang.NullPointerException: There is no credentials with admin access to manage hooks on GitHubRepositoryName[host=github.com,username=myorgname,repository=myreponame] The problem was in repository matcher that were failing when trailing slash existed in job configuration. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
