[JIRA] (JENKINS-57186) New View href is an absolute URL but other menu items are relative URLs
Title: Message Title
Napoleon BlownApart updated an issue
Jenkins / JENKINS-57186
New View href is an absolute URL but other menu items are relative URLs
Change By:
Napoleon BlownApart
The href of the "New View" link in the left panel is constructed differently from the other links and is an absolute URL rather than a relative URL. I've only noticed this issue because our Jenkins server is setup behind inside a VPN & SSH, . So we VPN into the university and then SSH to our gateway machine. Thus we use two domain name variants to access Jenkins depending on whether the user is in the lab (thus using "jenkins.int") or outside the lab (thus using "jenkins.vpn").The consequence of this is that when an external user accesses the Jenkins server via VPN/SSH using "jenkins.vpn", the "New View" link points to "jenkins.int/newView" instead of "jenkins.vpn/newView". This means that external users get a 404 error (Server not found) and need to manually correct the url. (Minor/trivial bug.) In core/src/main/java/jenkins/model/NewViewLink.java, starting line 45 {code:java}@Overridepublic String getUrlName() {String urlName = Jenkins.getInstance().getRootUrl() + URL_NAME;return urlName;}{code}the class prepends _Jenkins.getInstance().getRootUrl()_ to _URL_NAME_. If "/" is prepended instead, _urlName_ becomes a relative address, and the "New View" link is fixed.As I am not familiar with the Jenkins codebase, I'm not sure if this is the right way to fix this problem.
Add Comment
This message was sent by
[JIRA] (JENKINS-57186) New View href is an absolute URL but other menu items are relative URLs
Title: Message Title
Napoleon BlownApart updated an issue
Jenkins / JENKINS-57186
New View href is an absolute URL but other menu items are relative URLs
Change By:
Napoleon BlownApart
The href of the "New View" link in the left panel is constructed differently from the other links and is an absolute URL rather than a relative URL. I've only noticed this issue because our Jenkins server is setup behind a VPN & SSH, and we use two domain name variants to access Jenkins depending on whether the user is in the lab (thus using "jenkins.int") or outside the lab (thus using "jenkins.vpn").The consequence of this is that when an external user accesses the Jenkins server via VPN/SSH using "jenkins.vpn", the "New View" link points to "jenkins.int/newView" instead of "jenkins.vpn/newView". This means that external users get a 404 error (Server not found) and need to manually correct the url. (Minor/trivial bug.) In core/src/main/java/jenkins/model/NewViewLink.java, starting line 45 {code:java} @Overridepublic String getUrlName() {String urlName = Jenkins.getInstance().getRootUrl() + URL_NAME;return urlName;}{code}the class prepends _Jenkins.getInstance().getRootUrl()_ to _URL_NAME_. If "/" is prepended instead, _urlName_ becomes a relative address, and the "New View" link is fixed.As I am not familiar with the Jenkins codebase, I'm not sure if this is the right way to fix this problem.
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
[JIRA] (JENKINS-57186) New View href is an absolute URL but other menu items are relative URLs
Title: Message Title
Napoleon BlownApart updated an issue
Jenkins / JENKINS-57186
New View href is an absolute URL but other menu items are relative URLs
Change By:
Napoleon BlownApart
Summary:
New View href does not include "${rootURL}/" is an absolute URL but other menu items are relative URLs
The href of the "New View" link in the left panel is constructed differently from the other links and is an absolute URL rather than a relative URL . The sidepanel2.jelly file seems to be missing ${rootURL}/. I've only noticed this issue because our Jenkins server is setup behind a VPN & SSH, and we use two domain name variants to access Jenkins depending on whether the user is in the lab (thus using "jenkins.int") or outside the lab (thus using "jenkins.vpn").The consequence of this is that when an external user accesses the Jenkins server via VPN/SSH using "jenkins.vpn" , the "New View" link points to "jenkins.int/newView" instead of "jenkins.vpn/newView". This means that external users get a 404 error (Server not found) and need to manually correct the url. (Minor/trivial bug.)
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
[JIRA] (JENKINS-57186) New View href does not include "${rootURL}/"
Title: Message Title
Napoleon BlownApart created an issue
Jenkins / JENKINS-57186
New View href does not include "${rootURL}/"
Issue Type:
Bug
Assignee:
Unassigned
Components:
core
Created:
2019-04-25 15:12
Environment:
Jenkins 2.164.2
Labels:
jenkins
Priority:
Minor
Reporter:
Napoleon BlownApart
The href of the "New View" link in the left panel is constructed differently from the other links. The sidepanel2.jelly file seems to be missing ${rootURL}/. I've only noticed this issue because our Jenkins server is setup behind a VPN & SSH, and we use two domain name variants to access Jenkins depending on whether the user is in the lab (thus using "jenkins.int") or outside the lab (thus using "jenkins.vpn"). The consequence of this is that when an external user accesses the Jenkins server via VPN/SSH, the "New View" link points to "jenkins.int/newView" instead of "jenkins.vpn/newView". This means that external users get a 404 error (Server not found) and need to manually correct the url. (Minor/trivial bug.)
