[JIRA] (JENKINS-57562) EC2Cloud crashes with NPE when instanceCapStr is not passed from JCasC

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-57562  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: EC2Cloud crashes with NPE when instanceCapStr is not passed from JCasC   
 

  
 
 
 
 

 
 Okay   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199473.1558362521000.24103.1560096601491%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-57562) EC2Cloud crashes with NPE when instanceCapStr is not passed from JCasC

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-57562  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: EC2Cloud crashes with NPE when instanceCapStr is not passed from JCasC   
 

  
 
 
 
 

 
 Oleg Nenashev Is this issue still available to work on? If available, I would like to have a look on it.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199473.1558362521000.24076.1560092160132%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-12615) Discard Old Builds does not warn the user when no builds will be discarded

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-12615  
 
 
  Discard Old Builds does not warn the user when no builds will be discarded   
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Comment: 
 I request [~avollmer] to mark this issue as resolved, because PR has been merged.Thanks :)  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.142981.1328107267000.21543.1559711400205%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-12615) Discard Old Builds does not warn the user when no builds will be discarded

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-12615  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Discard Old Builds does not warn the user when no builds will be discarded   
 

  
 
 
 
 

 
 I request Adam Vollmer to mark this issue as resolved, because PR has been merged. Thanks   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.142981.1328107267000.19661.1559577480192%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-12615) Discard Old Builds does not warn the user when no builds will be discarded

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-12615  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Discard Old Builds does not warn the user when no builds will be discarded   
 

  
 
 
 
 

 
 My Pull request : https://github.com/jenkinsci/discard-old-build-plugin/pull/10  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.142981.1328107267000.17935.1559388060179%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-1182) Discard old builds only if the latest build is stable

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-1182  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Discard old builds only if the latest build is stable   
 

  
 
 
 
 

 
 Enhanced old build discarder is using LogRotator for discarding builds. So I think adding this feature to discard-old-build-plugin will make sense as it has more user options for discarding builds.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.131255.1200456855000.12338.1558943940191%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-12615) Discard Old Builds does not warn the user when no builds will be discarded

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-12615  
 
 
  Discard Old Builds does not warn the user when no builds will be discarded   
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Comment: 
 [~jglick] In implementation, I have just added one if condition(type of flag) in LogRotator.java. Whenever value of numToKeep and daysToKeep are not blank, then according to flag(new variable declared) message will be displayed. Currently I have added only if condition and I got error. I have searched regarding this error, but I am not getting it clear. Error is of failure of JUnit tests. But I don't know why it failed.[ERROR] Tests run: 7, Failures: 0, Errors: 7, Skipped: 0, Time elapsed: 0.006 s <<< FAILURE! - in hudson.cli.PrivateKeyProviderTest[ERROR] loadKeyBroken(hudson.cli.PrivateKeyProviderTest) Time elapsed: 0.001 s <<< ERROR!java.lang.Exception: Unexpected exception, expected but was at org.junit.internal.runners.statements.ExpectException.evaluate(ExpectException.java:28) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365) at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:236) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:386) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:323) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:143)Caused by: java.nio.file.NoSuchFileException: C:\Open%20Source\cli\target\test-classes\hudson\cli\openssh-broken at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:79) at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:97) at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:102) at sun.nio.fs.WindowsFileSystemProvider.newByteChannel(WindowsFileSystemProvider.java:230) at java.nio.file.Files.newByteChannel(Files.java:361) at java.nio.file.Files.newByteChannel(Files.java:407) at java.nio.file.spi.FileSystemProvider.newInputStream(FileSystemProvider.java:384) at java.nio.file.Files.newInputStream(Files.java:152) at hudson.cli.PrivateKeyProvider.readPemFile(PrivateKeyProvider.java:132) at hudson.cli.PrivateKeyProvider.loadKey(PrivateKeyProvider.java:128) at hudson.cli.PrivateKeyProviderTest.loadKeyBroken(PrivateKeyProviderTest.java:102) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at 

[JIRA] (JENKINS-1182) Discard old builds only if the latest build is stable

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-1182  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Discard old builds only if the latest build is stable   
 

  
 
 
 
 

 
 Oleg Nenashev Enhanced Old Build Discarder already gives this feature.  Enhanced Old Build Discarder : https://github.com/jenkinsci/enhanced-old-build-discarder Actually I started to code few lines and I came across one doubt, and finding solution for that doubt I found that this feature has already been implemented.  As a plugin is there for this feature should I continue implementation(maybe both functionalities in single plugin) in Old Discard Plugin or not ?    
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.131255.1200456855000.11977.1558807741133%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-1182) Discard old builds only if the latest build is stable

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah assigned an issue to Nisarg Shah  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-1182  
 
 
  Discard old builds only if the latest build is stable   
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Assignee: 
 Nisarg Shah  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.131255.1200456855000.11684.1558720620400%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-1182) Discard old builds only if the latest build is stable

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-1182  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Discard old builds only if the latest build is stable   
 

  
 
 
 
 

 
 Okay so I will try to add this feature to discard old build plugin. I am assigning this issue to me.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.131255.1200456855000.11679.1558720620312%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-1182) Discard old builds only if the latest build is stable

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-1182  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Discard old builds only if the latest build is stable   
 

  
 
 
 
 

 
 Oleg Nenashev Is it necessary to make a new plugin? Can't we just add few "if conditions" in LogRotator or discard old build plugin? Fetching the status of last build and checking whether it was stable or not. And then performing discard actions accordingly.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.131255.1200456855000.11651.1558718520207%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-57186) New View href is an absolute URL but other menu items are relative URLs

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-57186  
 
 
  New View href is an absolute URL but other menu items are relative URLs   
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Comment: 
 I tried applying the proposed solution, but few tests failed. So this solution won't work [~nap].  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198939.1556205175000.11553.1558708440809%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-57186) New View href is an absolute URL but other menu items are relative URLs

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-57186  
 
 
  New View href is an absolute URL but other menu items are relative URLs   
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Comment: 
 Test Failures : [INFO] Results:[INFO][ERROR] Failures:[ERROR] FilePathTest.isDescendant_regularSymlinks:960[ERROR] FilePathTest.isDescendant_worksEvenInSymbolicWorkspace:1110[ERROR] UtilTest.resolveSymlinkToFile:570[ERROR] NewViewLinkTest.getActionsHasPermission:55 expected:<[https://127.0.0.1:8080]/newView> but was:<[]/newView>[ERROR] NewViewLinkTest.getActionsNoPermission:68 expected:<[https://127.0.0.1:8080]/newView> but was:<[]/newView>[ERROR] VirtualFileTest.forFilePath_isDescendant:277->checkCommonAssertionForIsDescendant:312[ERROR] VirtualFileTest.forFilePath_listOnlyDescendants_withoutIllegal:366->checkCommonAssertionForList:392Expected: iterable over [Has name: aa, Has name: ab, Has name: _b] in any order but: No item matches: Has name: _b in [, ][ERROR] VirtualFileTest.forFile_isDescendant:261->checkCommonAssertionForIsDescendant:312[ERROR] VirtualFileTest.forFile_listOnlyDescendants_withoutIllegal:351->checkCommonAssertionForList:392Expected: iterable over [Has name: aa, Has name: ab, Has name: _b] in any order but: No item matches: Has name: _b in [, ][ERROR] Errors:[ERROR] UtilTest.testIsSymlink_ParentIsSymlink:286 » FileSystem C:\OpenSource\core\tar...[ERROR] AtomicFileWriterTest.symlinkToDirectory:80 » FileSystem C:\OpenSource\core\tar...[ERROR] PathRemoverTest.testForceRemoveFile_ParentIsSymbolicLink:184 » FileSystem C:\O...[ERROR] PathRemoverTest.testForceRemoveFile_SymbolicLink:153 » FileSystem C:\OpenSourc...[ERROR] PathRemoverTest.testForceRemoveRecursive_ContainsSymbolicLinks:373 » FileSystem[ERROR] PathRemoverTest.testForceRemoveRecursive_ParentIsSymbolicLink:411 » FileSystem[INFO][ERROR] Tests run: 3712, Failures: 9, Errors: 6, Skipped: 28  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
  

[JIRA] (JENKINS-57186) New View href is an absolute URL but other menu items are relative URLs

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-57186  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: New View href is an absolute URL but other menu items are relative URLs   
 

  
 
 
 
 

 
 Test Failures :  [INFO] Results: [INFO] [ERROR] Failures: [ERROR] FilePathTest.isDescendant_regularSymlinks:960 [ERROR] FilePathTest.isDescendant_worksEvenInSymbolicWorkspace:1110 [ERROR] UtilTest.resolveSymlinkToFile:570 [ERROR] NewViewLinkTest.getActionsHasPermission:55 expected: but was:<[]/newView> [ERROR] NewViewLinkTest.getActionsNoPermission:68 expected: but was:<[]/newView> [ERROR] VirtualFileTest.forFilePath_isDescendant:277->checkCommonAssertionForIsDescendant:312 [ERROR] VirtualFileTest.forFilePath_listOnlyDescendants_withoutIllegal:366->checkCommonAssertionForList:392 Expected: iterable over [Has name: aa, Has name: ab, Has name: _b] in any order but: No item matches: Has name: _b in [, ] [ERROR] VirtualFileTest.forFile_isDescendant:261->checkCommonAssertionForIsDescendant:312 [ERROR] VirtualFileTest.forFile_listOnlyDescendants_withoutIllegal:351->checkCommonAssertionForList:392 Expected: iterable over [Has name: aa, Has name: ab, Has name: _b] in any order but: No item matches: Has name: _b in [, ] [ERROR] Errors: [ERROR] UtilTest.testIsSymlink_ParentIsSymlink:286 » FileSystem C:\OpenSource\core\tar... [ERROR] AtomicFileWriterTest.symlinkToDirectory:80 » FileSystem C:\OpenSource\core\tar... [ERROR] PathRemoverTest.testForceRemoveFile_ParentIsSymbolicLink:184 » FileSystem C:\O... [ERROR] PathRemoverTest.testForceRemoveFile_SymbolicLink:153 » FileSystem C:\OpenSourc... [ERROR] PathRemoverTest.testForceRemoveRecursive_ContainsSymbolicLinks:373 » FileSystem [ERROR] PathRemoverTest.testForceRemoveRecursive_ParentIsSymbolicLink:411 » FileSystem [INFO] [ERROR] Tests run: 3712, Failures: 9, Errors: 6, Skipped: 28  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To 

[JIRA] (JENKINS-57186) New View href is an absolute URL but other menu items are relative URLs

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-57186  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: New View href is an absolute URL but other menu items are relative URLs   
 

  
 
 
 
 

 
 I tried applying the proposed solution, but few tests failed. So this solution won't work Napoleon BlownApart.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198939.1556205175000.11546.1558707600290%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-12615) Discard Old Builds does not warn the user when no builds will be discarded

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-12615  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Discard Old Builds does not warn the user when no builds will be discarded   
 

  
 
 
 
 

 
 Jesse Glick  In implementation, I have just added one if condition(type of flag) in LogRotator.java. Whenever value of numToKeep and daysToKeep are not blank, then according to flag(new variable declared) message will be displayed. Currently I have added only if condition and I got error. I have searched regarding this error, but I am not getting it clear. Error is of failure of JUnit tests. But I don't know why it failed. [ERROR] Tests run: 7, Failures: 0, Errors: 7, Skipped: 0, Time elapsed: 0.006 s <<< FAILURE! - in hudson.cli.PrivateKeyProviderTest [ERROR] loadKeyBroken(hudson.cli.PrivateKeyProviderTest) Time elapsed: 0.001 s <<< ERROR! java.lang.Exception: Unexpected exception, expected but was at org.junit.internal.runners.statements.ExpectException.evaluate(ExpectException.java:28) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365) at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:236) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:386) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:323) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:143) Caused by: java.nio.file.NoSuchFileException: C:\Open%20Source\cli\target\test-classes\hudson\cli\openssh-broken at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:79) at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:97) at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:102) at sun.nio.fs.WindowsFileSystemProvider.newByteChannel(WindowsFileSystemProvider.java:230) at java.nio.file.Files.newByteChannel(Files.java:361) at java.nio.file.Files.newByteChannel(Files.java:407) at java.nio.file.spi.FileSystemProvider.newInputStream(FileSystemProvider.java:384) at java.nio.file.Files.newInputStream(Files.java:152) at hudson.cli.PrivateKeyProvider.readPemFile(PrivateKeyProvider.java:132) at hudson.cli.PrivateKeyProvider.loadKey(PrivateKeyProvider.java:128) at hudson.cli.PrivateKeyProviderTest.loadKeyBroken(PrivateKeyProviderTest.java:102) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at 

[JIRA] (JENKINS-25819) Execute keepLastBuilds function should be an option

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-25819  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Execute keepLastBuilds function should be an option   
 

  
 
 
 
 

 
 Félix Belzunce Arcos Can you please describe the feature with an example?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.159394.1417161166000.1077.1557934080406%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-12615) Discard Old Builds does not warn the user when no builds will be discarded

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah assigned an issue to Nisarg Shah  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-12615  
 
 
  Discard Old Builds does not warn the user when no builds will be discarded   
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Assignee: 
 Nisarg Shah  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.142981.1328107267000.860.1557914460222%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-12615) Discard Old Builds does not warn the user when no builds will be discarded

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-12615  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Discard Old Builds does not warn the user when no builds will be discarded   
 

  
 
 
 
 

 
 I would like to work on this. I am assigning this issue to myself.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.142981.1328107267000.857.1557914400600%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-1623) Keep only successful builds

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-1623  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Keep only successful builds   
 

  
 
 
 
 

 
 Oleg Nenashev Is this issue still open to work on? A feature like "keep successful builds" can be introduced in core or as a plugin which will discard all unsuccessful builds regardless numToKeep and daysToKeep variables in logRotator.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.131696.1209432852000.853.1557914040480%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-48715) Retain last N builds

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-48715  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Retain last N builds   
 

  
 
 
 
 

 
 Martin d'Anjou What do you mean by retain last N builds. Does it mean getting last N builds which were discarded or something else. Or you want that both age and number of builds both factor plays a role in discarding build and no overwritten happens.(Similar to my GSoC Proposal) Can you please clarify?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.187418.1514330382000.650.1557858000424%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55829  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
 Oleg Nenashev As this issue is solved, I request you to make resolve label on this issue so that no other contributor pick this issue.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.197223.1548751776000.21940.1557400620157%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-57186) New View href is an absolute URL but other menu items are relative URLs

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-57186  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: New View href is an absolute URL but other menu items are relative URLs   
 

  
 
 
 
 

 
 Napoleon BlownApart I think that the solution you proposed would work. Because making URL Relative would be a solution. Oleg Nenashev What is your view?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198939.1556205175000.20911.1557335820192%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55829  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
 Oleg Nenashev Can you please review the PR : https://github.com/jenkinsci/jenkins/pull/3873 Changes have been made according to the suggestions and now it looks fine !!    
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-55829  
 
 
  Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Comment: 
 [~oleg_nenashev]So do I need to return extra new empty container from the getter method? Is this what you are suggesting?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55829  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
 Oleg Nenashev So do I need to return extra new empty container from the getter method? Is this what you are suggesting?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55829  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
 Sorry I didn't get it. Can you explain it again?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-55829  
 
 
  Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Comment: 
 If possible can we just remove @Restricted(NoExternalUse.class) and try? I know it's not the correct way but if possible.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55829  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
 Oleg Nenashev Some test failures occurred after importing the classes in PR https://github.com/jenkinsci/jenkins/pull/3873  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah edited a comment on  JENKINS-55829  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
 Can If possible can  we just remove @Restricted(NoExternalUse.class) and try?  I know it's not the correct way but if possible.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55829  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
 Can we just remove @Restricted(NoExternalUse.class) and try?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah edited a comment on  JENKINS-55829  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
 [~oleg_nenashev] The I have committed suggested changes but the  compilation error  continues which  is due to the tag @Restricted(NoExternalUse.class). So any suggestions what should be done to remove this compilation error?   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55829  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
 Oleg Nenashev The compilation error is due to the tag @Restricted(NoExternalUse.class). So any suggestions what should be done to remove this compilation error?    
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 Baptiste Mathus I am attaching the screenshot of message after the fix. And I think the issue is solved as per acceptance criteria.     
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-55738  
 
 
  NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Attachment: 
 Capture5 - Copy.JPG  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-55738  
 
 
  NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Comment: 
 [~batmat]I am attaching screenshot of message after the fix.First photo is when there was an out of disk event detected.Second photo is when master node came online as the disk gets some empty space.And I think this fulfills the acceptance criteria. !image-2019-02-09-00-30-55-101.png|width=735,height=370! !Capture4 - Copy.JPG|width=598,height=263!    
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 Baptiste Mathus I am attaching screenshot of message after the fix. First photo is when there was an out of disk event detected. Second photo is when master node came online as the disk gets some empty space. And I think this fulfills the acceptance criteria.            
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-55738  
 
 
  NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Attachment: 
 image-2019-02-09-00-30-55-101.png  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-55738  
 
 
  NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Attachment: 
 Capture4 - Copy.JPG  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-55738  
 
 
  NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Attachment: 
 Capture2 - Copy.JPG  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 Baptiste Mathus I am attaching the screenshot of the message before the fix :  I have marked the issue with red marker.   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-55738  
 
 
  NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Attachment: 
 Capture3 - Copy.JPG  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-55738  
 
 
  NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Attachment: 
 Capture3.JPG  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 Baptiste Mathus I have tested he fix and attaching screenshot of the output of Jenkins Window and CLI. And I think this fix has resolved the issue of displaying null message.        
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-55738  
 
 
  NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Attachment: 
 Capture2.JPG  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-55738  
 
 
  NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Attachment: 
 Capture1.JPG  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-55738  
 
 
  NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Comment: 
 [~batmat]I have tested the fix and I am attaching the screenshot of the result obtained.!Capture1.JPG|thumbnail!  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 Baptiste Mathus I have tested the fix and I am attaching the screenshot of the result obtained.   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-55738  
 
 
  NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Comment: 
 I have tested this fix and I am attaching the screenshot of the result obtained. !Capture1.JPG!  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 I have tested this fix and I am attaching the screenshot of the result obtained.   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-55738  
 
 
  NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Attachment: 
 Capture1.JPG  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 Baptiste Mathus Can you suggest me the command(applied on Jenkins Folder) of test through which I can check this fix? I have checked some flow of the code and want to check whether this fix would actually work or not.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55829  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
 I am sharing screenshot of that test :    
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-55829  
 
 
  Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Attachment: 
 Capture.JPG  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55829  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
 I have tried to run command of mvn on Jenkins folder after the fix. And in that, compilation error is shown. Yes I have tried to open Jenkins as a project in IDE but not tried to test Jenkins fix itself in IDE.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55829  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
 Oleg Nenashev The compilation error is due to the tag @Restricted(NoExternalUse.class). So any suggestions what should be done to remove this compilation error?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55829  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
 Oleg Nenashev   I have seen your suggestions and also applied on the code. But then, when I tried to compile it on my laptop than same compilation error is observed. Discussions : https://github.com/jenkinsci/jenkins/pull/3873#issuecomment-460027715 https://github.com/jenkinsci/jenkins/pull/3873#discussion_r252975695   Any suggestions ?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55829  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
 Oleg Nenashev Thank you. I will just look into it. And any suggestions in PR?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55829  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
 Can you please provide me some guidance on how to compile and run this code on local and do these tests. As in test, error of "Restricted" is shown. So I can just check it on my local. And do you think that changes done(new getter method) are perfect or I need to work on that?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55829  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
 I think error is due to the “Restricted(NoExternalUse.class)” as shown in the tests. And please can you help me that how can I compile and run the complete code on my local computer and can do all these tests on local?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah edited a comment on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 [~batmat] [~jglick]Due to some issues I have deleted my previous repo and due to that my old PR got deleted.Here is  my  new PR :  [ https://github.com/jenkinsci/jenkins/pull/3874 ]  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 Baptiste Mathus Jesse Glick Due to some issues I have deleted my previous repo and due to that my old PR got deleted. Here is my new PR : https://github.com/jenkinsci/jenkins/pull/3874  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55829  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
 Oleg Nenashev  PR : https://github.com/jenkinsci/jenkins/pull/3873  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55829  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
 Oleg Nenashev Sorry for the inconvenience occurred in the pull request. There were some issues due to which it happened, so I just closed previous pull request and now I will do two individual PR.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55829  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
 Thank you.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah assigned an issue to Nisarg Shah  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-55829  
 
 
  Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Assignee: 
 Nisarg Shah  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55829  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
 I would like to do this task. Can i assign it to me?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah edited a comment on  JENKINS-55829  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
 I would like to do this task. Can  i  I  assign it to me?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-55829  
 
 
  Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Comment: 
 Okay so just instance of jenkins from Jenkins.get() needs to be stored by that method. Am I correct?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 Baptiste Mathus Okay, great I had a thought of copying and pasting big files and manually create an out of disk event. But actually after this I have a doubt that how to run jenkins code on local and test that fixed part?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-38764) Nodes allocated inside of parallel() should have their workspaces removed immediately

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah assigned an issue to CloudBees Inc.  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-38764  
 
 
  Nodes allocated inside of parallel() should have their workspaces removed immediately   
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Assignee: 
 CloudBees Inc.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-38764) Nodes allocated inside of parallel() should have their workspaces removed immediately

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah assigned an issue to Nisarg Shah  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-38764  
 
 
  Nodes allocated inside of parallel() should have their workspaces removed immediately   
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Assignee: 
 CloudBees Inc. Nisarg Shah  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-38764) Nodes allocated inside of parallel() should have their workspaces removed immediately

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah assigned an issue to Unassigned  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-38764  
 
 
  Nodes allocated inside of parallel() should have their workspaces removed immediately   
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Assignee: 
 Nisarg Shah  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 The tests which got failed while checking got passed now, but now I am only facing some problem to verify the fix by manually creating an out of disk space event.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55829  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
 Okay so just instance of jenkins from Jenkins.get() needs to be stored by that method. Am I correct?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55829) Expose AbstractCIBase#disabledAdministrativeMonitors as internal API

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55829  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Expose AbstractCIBase#disabledAdministrativeMonitors as internal API   
 

  
 
 
 
 

 
 I have a doubt that getter method in AbstractCIBase should be created which assigns all the values of parameters from Jenkins.get() right?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 Okay. So I think I should check from where .getDisplayName() is assigned to the particular message. From that we can be sure whether this particular change will work or not.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 I just need to verify the changes done by doing tests as I had a look on code once again and thought that the changes done in the pr looks fine just needed to get verify. Are there any specific tests needed for this through which I can get to know that whether it works or not?    
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah edited a comment on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 In my pull request yesterday testing was being done and it passed all the tests. And a green tick was given that all tests cases passed and this commit can be build. But today tests were running once again and one error occurred which is different from the errors occurred in earlier test.  Error is of Remote call on jenkinsinfra-highmem8ca11 failed  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 In my pull request yesterday testing was being done and it passed all the tests. And a green tick was given that all tests cases passed and this commit can be build. But today tests were running once again and one error occurred which is different from the errors occurred in earlier test.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 What about passing a string message directly into Logger.info(). I think by this change no behaviour of code will get changed and problem can also be solved?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 Okay Thanks... I think here the behaviour of changed code is not okay and the tests failed are unrelated to my code. So now how should I approach to solve this?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 Can anyone tell me how can I run tests on my local computer?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 https://github.com/jenkinsci/jenkins/pull/3863 In these pull request 4 existing tests got failed. Can you please help me in figuring out what happened? As no code of that modules were changed.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-55738  
 
 
  NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Comment: 
 Okay and Can I get just one help that how can I test my change in code. Like how would i run that code and check whether that issue has solved or not?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 Okay and Can I get just one help that how can I test my change in code. Like how would i run that code and check whether that issue has solved or not?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 Yes issue is of MasterComputer. But if we replace c.getName() with c.getDisplayName() than would it fix this issue?   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 Yes it may be. But i looked each and every line where c.getName() is called and i think that it would create issue editing that method. So either we have to call another Display method or we should pass directly the string as it is. And in c.getDisplayName() it gets override by returning nodeName which exactly c.getName() does. So I am not sure but it may probably not work. There are two functions of getDisplayName in which one gets override by returning nodeName.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 If we pass "Putting back online as there is enough disk space again" in Logger.info() then would it be a better behaviour and would it work? As if we change getName() method of Computer class than it would create a problem as this method is used in many places.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 Okay. Thanks I will go through some necessary part of the code and will post comments here if required.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 I want to ask few doubts. So which gitter room should I join to discuss? Or should I ask and discuss here?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 Sure. Thank you!! Actually I am new to open source and also very much excited to contribute.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 Sure. Thank you!! Actually I am new to open source and also very much excited to contribute.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah assigned an issue to Nisarg Shah  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-55738  
 
 
  NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
Change By: 
 Nisarg Shah  
 
 
Assignee: 
 Nisarg Shah  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master

[nisshah1...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Nisarg Shah commented on  JENKINS-55738  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NodeMonitor out of disk space message is wrong for master
 

  
 
 
 
 

 
 I would like to work on this issue. So can I assign this to me?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.