[JIRA] (JENKINS-43256) SSE should be organization aware
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-43256 SSE should be organization aware Change By: Tom FENNELLY Attachment: Screenshot 2017-03-31 07.18.12.png Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43256) SSE should be organization aware
Title: Message Title Tom FENNELLY commented on JENKINS-43256 Re: SSE should be organization aware The jenkins org is set as a property on all events (see screenshot), so should just be a case of tweaking the SSE subscription in the UI code to specify the org as a filter. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41063) SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields
Title: Message Title Tom FENNELLY closed an issue as Fixed Actually this was fixed back in Jan in v1.12 of the plugin. Not sure why it was not closed. Jenkins / JENKINS-41063 SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields Change By: Tom FENNELLY Status: Open Closed Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to
[JIRA] (JENKINS-39646) Properly generate bundles for packages that have multiple top-level modules
Title: Message Title Tom FENNELLY commented on JENKINS-39646 Re: Properly generate bundles for packages that have multiple top-level modules Some progress made on JENKINS-39657 alright (basic chrome extension created - there was a bit of learning needed on these extensions), but can't effectively do anything on this ticket without first getting JENKINS-39657 to a stage where it can answer the kinds of questions I need it to help give answers to. I think I'm a couple of days awaf from that yet - guessing 2 or 3. This stuff is not going to be done for 1.0, but I'm guessing you already know that. I've been away for the last week and it's Paddy's day here today and I'm jetlagged Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39657) Runtime JavaScript bundle analyser for Chrome Dev Tools
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-39657 Runtime _javascript_ bundle analyser for Chrome Dev Tools Change By: Tom FENNELLY Component/s: js-modules Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41640) Scroll spy improvements
Title: Message Title Tom FENNELLY resolved as Duplicate Closing this ticket as it keeps being disconnected from the blueocean-plugin component and JENKINS-33396 is already there for core. Jenkins / JENKINS-41640 Scroll spy improvements Change By: Tom FENNELLY Status: Reopened Resolved Resolution: Duplicate Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to
[JIRA] (JENKINS-39657) Runtime JavaScript bundle analyser for Chrome Dev Tools
Title: Message Title Tom FENNELLY started work on JENKINS-39657 Change By: Tom FENNELLY Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39657) Runtime JavaScript bundle analyser for Chrome Dev Tools
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-39657 Runtime _javascript_ bundle analyser for Chrome Dev Tools Change By: Tom FENNELLY Blue Ocean client-side functionality is delivered as a series of _javascript_ "bundles" (CommonJS modules bundled in self contained executable _javascript_ files). {{js-modules}} and {{js-builder}} add the functionality that allows these bundles to "cooperate" with each other, with some bundles providing modules to other bundle (i.e. are dependencies of), allowing those other bundles to not contain modules that they might ordinarily contain.There are a number of reasons for us wanting/needing to do this, not least the fact that all our bundles +*must*+ use/share the same instance of react at runtime.At the moment, it's really quite difficult to analyse what's happening at runtime across all these bundles. For example, it's hard to check what bundles contain what modules i.e. it's hard to get a definitive answer to a questions like:* What bundles currently loaded in the browser contain module XYZ?* What bundle is providing the instance of react that's being used by the blueocean-personalization extensions bundle? You'd need to know the answer to this when you see react errors (from e.g. personalization) that "look" like we might be leaking in another instance of react.* Are there any bundles active in the browser that are older than a specific time, or number of minutes etc? This would be useful if you want to check did you actually rebuild everything the way you thought.We need to be able to answer these questions more easily in order to analyse the bundles we are generating and in order to verify that the runtime environment is as we expect/want it to be. At the moment, it requires us to manually open each of the raw bundle sources in the browser and have a look inside. As well as obviously being very tedious, it's also obviously going to be confusing and error prone, leading to wrong conclusions etc and making it harder to diagnose issues. This chrome extension will hopefully allow us to easily and accurately "query" across all active bundles in the browser at runtime and answer the sorts of questions listed above. *+Original description:+*{quote}Lots of things we could use this for but I have a few things in mind immediately, one of which I have an immediate need for:# {{js-modules}} bundle inspector. The ability to look inside {{js-modules}} loaded bundles and inspect their contents. Query support of different kinds e.g. find loaded bundles that contain modules that match a name pattern, or bundles that depend on bundle "X". I have an immediate need for this wrt JENKINS-39646.# Configure logging categories e.g. the ability to easily turn on/off [SSE event logging|https://github.com/jenkinsci/sse-gateway-plugin#browser-diagnostics].# View available extension points on a page.{quote}
[JIRA] (JENKINS-39657) Runtime JavaScript bundle analyser for Chrome Dev Tools
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-39657 Runtime _javascript_ bundle analyser for Chrome Dev Tools Change By: Tom FENNELLY Blue Ocean client-side functionality is delivered as a series of _javascript_ "bundles" (CommonJS modules bundled in self contained executable _javascript_ files). {{js-modules}} and {{js-builder}} add the functionality that allows these bundles to "cooperate" with each other, with some bundles providing modules to other bundle (i.e. are dependencies of), allowing those other bundles to not contain modules that they might ordinarily contain.There are a number of reasons for us wanting/needing to do this, not least the fact that all our bundles +*must*+ use/share the same instance of react at runtime.At the moment, it's really quite difficult to analyse what's happening at runtime across all these bundles. For example, it's hard to check what bundles contain what modules i.e. it's hard to get a definitive answer to a questions like:* What bundles currently loaded in the browser contain module XYZ?* What bundle is providing the instance of react that's being used by the blueocean-personalization extensions bundle? You'd need to know the answer to this when you see react errors (from e.g. personalization) that "look" like we might be leaking in another instance of react.* Are there any bundles active in the browser that are older than a specific time, or number of minutes etc? This would be useful if you want to check did you actually rebuild everything the way you thought.We need to be able to answer these questions more easily in order to analyse the bundles we are generating and in order to verify that the runtime environment is as we expect/want it to be. At the moment, it requires us to manually open each of the raw bundle sources in the browser and have a look inside. As well as obviously being very tedious, it's also obviously going to be confusing and error prone, leading to wrong conclusions etc and making it harder to diagnose issues.*+Original description:+*{quote} Lots of things we could use this for but I have a few things in mind immediately, one of which I have an immediate need for:# {{js-modules}} bundle inspector. The ability to look inside {{js-modules}} loaded bundles and inspect their contents. Query support of different kinds e.g. find loaded bundles that contain modules that match a name pattern, or bundles that depend on bundle "X". I have an immediate need for this wrt JENKINS-39646.# Configure logging categories e.g. the ability to easily turn on/off [SSE event logging|https://github.com/jenkinsci/sse-gateway-plugin#browser-diagnostics].# View available extension points on a page. {quote}
[JIRA] (JENKINS-39657) Runtime JavaScript bundle analyser for Chrome Dev Tools
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-39657 Runtime _javascript_ bundle analyser for Chrome Dev Tools Change By: Tom FENNELLY Summary: Runtime _javascript_ bundle analyser for Chrome Dev Tools Extension for Blue Ocean Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39657) Chrome Dev Tools Extension for Blue Ocean
Title: Message Title Tom FENNELLY commented on JENKINS-39657 Re: Chrome Dev Tools Extension for Blue Ocean Spent the last few days learning how Chrome Devtool Extensions hang together via a smaller project so as to learn the moving parts before I try creating the bundle analyser stuff. It allows configuration of the BO logging, which happens via the @jenkins-cd/logging package. See https://github.com/tfennelly/jenkins-logging-chrome-ext. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42560) unable to install ATH on macos
Title: Message Title Tom FENNELLY edited a comment on JENKINS-42560 Re: unable to install ATH on macos In Vivek's case, it was because nodegit was not able to parse his {{ . ~ /.gitconfig}} to get the user details. It didn't like the format being used by the email config - in his case, it was wrapped in angle brackets e.g. "" or whatever. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42600) Creation tests with real git and github/similar environments
Title: Message Title Tom FENNELLY commented on JENKINS-42600 Re: Creation tests with real git and github/similar environments The ATH currently uses nodegit, which seems to have some "issues" (see JENKINS-42560 and others), to say the least. Might be a bigger task than it seems from 20,000 feet, but would it make sense to execute the host git via process. We'd need to see how we're using nodegit etc and what needs to be replicated. Just a thought. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42600) Creation tests with real git and github/similar environments
Title: Message Title Tom FENNELLY edited a comment on JENKINS-42600 Re: Creation tests with real git and github/similar environments The ATH currently uses nodegit, which seems to have some "issues" (see JENKINS-42560 and others), to say the least. Might be a bigger task than it seems from 20,000 feet, but would it make sense to execute the host git via process. We'd need to see how we're using nodegit etc and what needs to be replicated. Just a thought. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42560) unable to install ATH on macos
Title: Message Title Tom FENNELLY commented on JENKINS-42560 Re: unable to install ATH on macos In Vivek's case, it was because nodegit was not able to parse his ./.gitconfig to get the user details. It didn't like the format being used by the email config - in his case, it was wrapped in angle brackets e.g. "" or whatever. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42611) Could not initialize class EventDispatcherFactory
Title: Message Title Tom FENNELLY resolved as Fixed Fix will be in 1.16 of the plugin. I don't think this issue warrants a release on its own. Jenkins / JENKINS-42611 Could not initialize class EventDispatcherFactory Change By: Tom FENNELLY Status: Open Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options,
[JIRA] (JENKINS-42611) Could not initialize class EventDispatcherFactory
Title: Message Title Tom FENNELLY commented on JENKINS-42611 Re: Could not initialize class EventDispatcherFactory PR: https://github.com/jenkinsci/sse-gateway-plugin/pull/19 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42611) Could not initialize class EventDispatcherFactory
Title: Message Title Tom FENNELLY commented on JENKINS-42611 Re: Could not initialize class EventDispatcherFactory Thanks for reporting this. The issue here is really just a log being made at too high a severity level. I'll turn down the logging in this case to be a DEBUG log. This fix will be in v 1.16 of the plugin. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42611) Could not initialize class EventDispatcherFactory
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-42611 Could not initialize class EventDispatcherFactory Change By: Tom FENNELLY Priority: Major Trivial Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42611) Could not initialize class EventDispatcherFactory
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-42611 Could not initialize class EventDispatcherFactory Change By: Tom FENNELLY Issue Type: New Feature Bug Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42560) unable to install ATH on macos
Title: Message Title Tom FENNELLY commented on JENKINS-42560 Re: unable to install ATH on macos Has anyone tried that has had this problem tried the obvious things of: Updating the dependency version of nodegit. Updating the version of git installed on the host machine. Manually adding logs in the failing preinstall script in an effort to get a better idea of why it's failing. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42560) unable to install ATH on macos
Title: Message Title Tom FENNELLY edited a comment on JENKINS-42560 Re: unable to install ATH on macos Has anyone tried ( that has had this problem ) tried the obvious things of: # Updating the dependency version of nodegit. # Updating the version of git installed on the host machine. # Manually adding logs in the failing preinstall script in an effort to get a better idea of why it's failing. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42570) Remove the use of SSE in the ATH
Title: Message Title Tom FENNELLY commented on JENKINS-42570 Re: Remove the use of SSE in the ATH Might be worth doing JENKINS-42572 before/with this. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42572) Upgrade the versions of Selenium and Nightwatch
Title: Message Title Tom FENNELLY created an issue Jenkins / JENKINS-42572 Upgrade the versions of Selenium and Nightwatch Issue Type: Task Assignee: Unassigned Components: blueocean-plugin Created: 2017/Mar/08 10:11 AM Priority: Major Reporter: Tom FENNELLY In case some of the hanging issues are related to bugs that have been fixed in our dependencies e.g. https://github.com/nightwatchjs/nightwatch/pull/1232 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
[JIRA] (JENKINS-42570) Remove the use of SSE in the ATH
Title: Message Title Tom FENNELLY created an issue Jenkins / JENKINS-42570 Remove the use of SSE in the ATH Issue Type: Task Assignee: Unassigned Components: blueocean-plugin Created: 2017/Mar/08 10:01 AM Priority: Major Reporter: Tom FENNELLY For some reason that we've been unable to determine (bug in SSE, bug in nightwatch, bug in something else), using the headless SSE client in the ATH appears to be causing a problem where it's constantly connecting and disconnecting. Lets remove it and see what we get then. This may be a bug in nightwatch were it's starting and stopping a no-op tests or something who knows. We'd just see the SSE connect/disconnect logs in this case because that stuff is in nightwatch global before/after functions in global.js. Add Comment
[JIRA] (JENKINS-42566) Provide support for writing Java based ATH tests
Title: Message Title Tom FENNELLY created an issue Jenkins / JENKINS-42566 Provide support for writing Java based ATH tests Issue Type: Improvement Assignee: Unassigned Components: blueocean-plugin Created: 2017/Mar/08 9:46 AM Priority: Major Reporter: Tom FENNELLY At the moment it just supports nightwatch _javascript_ tests. Some people are not liking that - don't like the API and feel debugging will be a big help. If this is what it takes to get people writing some tests, then we should make it possible. Note: I spent some time looking at this yesterday. I thought it would be easy enough, but the Jenkins core ATH libs that we are using in the Blue Ocean ATH are actually getting in the way more than helping (from the point of view of making this possible) because it is also creating WebDriver instances (non remote/RC Selenium 1 style). It might be worth looking at removing this stuff from the picture altogether and spinning up the Jenkins instance (plus all the plugins) some other way. Add Comment
[JIRA] (JENKINS-40768) Jenkins client-side HTML5 storage API
Title: Message Title Tom FENNELLY resolved as Done Jenkins / JENKINS-40768 Jenkins client-side HTML5 storage API Change By: Tom FENNELLY Status: Open Resolved Resolution: Done Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39657) Chrome Dev Tools Extension for Blue Ocean
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-39657 Chrome Dev Tools Extension for Blue Ocean Change By: Tom FENNELLY Sprint: 1.1 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41642) Handle when favouriting a pipeline fails
Title: Message Title Tom FENNELLY updated JENKINS-41642 Jenkins / JENKINS-41642 Handle when favouriting a pipeline fails Change By: Tom FENNELLY Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41662) Proceed button fails (investigate)
Title: Message Title Tom FENNELLY updated JENKINS-41662 Jenkins / JENKINS-41662 Proceed button fails (investigate) Change By: Tom FENNELLY Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41642) Handle when favouriting a pipeline fails
Title: Message Title Tom FENNELLY started work on JENKINS-41642 Change By: Tom FENNELLY Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41662) Proceed button fails (investigate)
Title: Message Title Tom FENNELLY commented on JENKINS-41662 Re: Proceed button fails (investigate) PR: https://github.com/jenkinsci/blueocean-plugin/pull/875 io.jenkins.blueocean.rest.impl.pipeline.InputStepImpl has some unusual code, resetting the ID of the underlying pipeline InputStep instance to a random ID. The result of this ... two browsers load the same input step ... the first browser is screwed because the id it is using to submit against no longer corresponds to a valid ID because the load from the second browser caused it to be changed via io.jenkins.blueocean.rest.impl.pipeline.InputStepImpl. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41662) Proceed button fails (investigate)
Title: Message Title Tom FENNELLY updated JENKINS-41662 Jenkins / JENKINS-41662 Proceed button fails (investigate) Change By: Tom FENNELLY Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42137) Don't fetch run data on an event if it not already in the store
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-42137 Don't fetch run data on an event if it not already in the store Change By: Tom FENNELLY Priority: Critical Minor Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42137) Don't fetch run data on an event if it not already in the store
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-42137 Don't fetch run data on an event if it not already in the store Change By: Tom FENNELLY Sprint: 1. 0 1 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42137) Don't fetch run data on an event if it not already in the store
Title: Message Title Tom FENNELLY stopped work on JENKINS-42137 Change By: Tom FENNELLY Status: In Progress Open Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42137) Don't fetch run data on an event if it not already in the store
Title: Message Title Tom FENNELLY commented on JENKINS-42137 Re: Don't fetch run data on an event if it not already in the store This is a bit of a rat-hole. Talked with Michael Neale and we decided to punt on trying to perform this optimisation for now. PR 867 "seemed" to do the trick, but the ATH uncovered a scenario where the fetch should still take place. If the RunDetails page is cold loaded for a run instance (e.g. directly from a link), the page loads the pipeline instance, steps data and a load of other stuff, but doesn't use the ActivityService or create a Pager instance. If it's a failed run and the user clicks on the Re-Run button a build will be triggered, causing SSE events, which in turn cause the DefaultSSEHandler to attempt to get the Pager instance from the PagerService etc etc. I spent some time studying all this and kinda got it working, but ran into other issues then with other components. Bottom line ... I think this is something we should come back to post 1.0 because it seems like some other things need to be straightened out in order to make it work and I don't think it's worth taking the risk of breaking things at this point. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42395) If the jenkins banner is customized the "open blue ocean" button gets covered on a narrow screen (< 1060)
Title: Message Title Tom FENNELLY edited a comment on JENKINS-42395 Re: If the jenkins banner is customized the "open blue ocean" button gets covered on a narrow screen (< 1060) Or maybe something nicer (if we want to spend more effort) would be to have a Blue Ocean icon/widget to between the search box and the login stuff e.g. ... !Screenshot 2017-03-01 11.39.28.png|thumbnail! Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42395) If the jenkins banner is customized the "open blue ocean" button gets covered on a narrow screen (< 1060)
Title: Message Title Tom FENNELLY commented on JENKINS-42395 Re: If the jenkins banner is customized the "open blue ocean" button gets covered on a narrow screen (< 1060) Or maybe something nicer (if we want to spend more effort) would be to have a Blue Ocean icon/widget to between the search box and the login stuff e.g. ... Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42395) If the jenkins banner is customized the "open blue ocean" button gets covered on a narrow screen (< 1060)
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-42395 If the jenkins banner is customized the "open blue ocean" button gets covered on a narrow screen (< 1060) Change By: Tom FENNELLY Attachment: Screenshot 2017-03-01 11.39.28.png Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42395) If the jenkins banner is customized the "open blue ocean" button gets covered on a narrow screen (< 1060)
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-42395 If the jenkins banner is customized the "open blue ocean" button gets covered on a narrow screen (< 1060) Change By: Tom FENNELLY Summary: If the jenkins banner is customized the "open blue ocean" button is not positioned correctly gets covered on a narrow screen (< 1060) Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42395) If the jenkins banner is customized the "open blue ocean" button gets covered on a narrow screen (< 1060)
Title: Message Title Tom FENNELLY commented on JENKINS-42395 Re: If the jenkins banner is customized the "open blue ocean" button gets covered on a narrow screen (< 1060) I think maybe we should just move this button/link onto the breadcrumb bar, just beside the "ENABLE AUTO REFRESH" perhaps. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42293) "Open Blue Ocean" opens links to incorrect URL in some cases resulting in 404
Title: Message Title Tom FENNELLY updated JENKINS-42293 Jenkins / JENKINS-42293 "Open Blue Ocean" opens links to incorrect URL in some cases resulting in 404 Change By: Tom FENNELLY Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41662) Proceed button fails (investigate)
Title: Message Title Tom FENNELLY started work on JENKINS-41662 Change By: Tom FENNELLY Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42293) "Open Blue Ocean" opens links to incorrect URL in some cases resulting in 404
Title: Message Title Tom FENNELLY updated JENKINS-42293 Jenkins / JENKINS-42293 "Open Blue Ocean" opens links to incorrect URL in some cases resulting in 404 Change By: Tom FENNELLY Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42293) "Open Blue Ocean" opens links to incorrect URL in some cases resulting in 404
Title: Message Title Tom FENNELLY commented on JENKINS-42293 Re: "Open Blue Ocean" opens links to incorrect URL in some cases resulting in 404 https://github.com/jenkinsci/blueocean-plugin/pull/868 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39646) Properly generate bundles for packages that have multiple top-level modules
Title: Message Title Tom FENNELLY edited a comment on JENKINS-39646 Re: Properly generate bundles for packages that have multiple top-level modules There's also another related scenario that needs to be covered here, which is when one or more different versions of a package to be externalized end up in the {{node_modules}} of package in {{node_modules}} (i.e. npm trying to handle conflicting versions of the package) e.g. {{/node_modules/@jenkins-cd/blueocean-core-js/node_modules/react/react.js}} because {{@jenkins-cd/blueocean-core-js}} depends on a specific version of react that is not the same as the top level installed version of react ( in {{/node_modules/react}} ) . Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39646) Properly generate bundles for packages that have multiple top-level modules
Title: Message Title Tom FENNELLY edited a comment on JENKINS-39646 Re: Properly generate bundles for packages that have multiple top-level modules There's also another related scenario that needs to be covered here, which is when one or more different versions of a package to be externalized end up in the {{node_modules}} of package in {{node_modules}} (i.e. npm trying to handle conflicting versions of the package) e.g. {{/node_modules/@jenkins-cd/blueocean-core-js/node_modules/react/react.js}} because {{@jenkins-cd/blueocean-core-js}} depends on a specific version of react that is not the same as the top level installed version of react . Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39646) Properly generate bundles for packages that have multiple top-level modules
Title: Message Title Tom FENNELLY commented on JENKINS-39646 Re: Properly generate bundles for packages that have multiple top-level modules There's also another related scenario that needs to be covered here, which is when one or more different versions of a package to be externalized end up in the node_modules of package in node_modules (i.e. npm trying to handle conflicting versions of the package) e.g. /node_modules/@jenkins-cd/blueocean-core-js/node_modules/react/react.js because @jenkins-cd/blueocean-core-js depends on a specific version of react. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42293) "Open Blue Ocean" opens links to incorrect URL in some cases resulting in 404
Title: Message Title Tom FENNELLY started work on JENKINS-42293 Change By: Tom FENNELLY Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42291) REGRESSION: Clicking on the cog icon in blue ocean takes you to an invalid page.
Title: Message Title Tom FENNELLY updated JENKINS-42291 Jenkins / JENKINS-42291 REGRESSION: Clicking on the cog icon in blue ocean takes you to an invalid page. Change By: Tom FENNELLY Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38751) run results and main header to provide an "escape" link to get back to a classic view of a Pipeline/job
Title: Message Title Tom FENNELLY updated JENKINS-38751 Jenkins / JENKINS-38751 run results and main header to provide an "escape" link to get back to a classic view of a Pipeline/job Change By: Tom FENNELLY Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42137) Don't fetch run data on an event if it not already in the store
Title: Message Title Tom FENNELLY commented on JENKINS-42137 Re: Don't fetch run data on an event if it not already in the store https://github.com/jenkinsci/blueocean-plugin/pull/867 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42137) Don't fetch run data on an event if it not already in the store
Title: Message Title Tom FENNELLY updated JENKINS-42137 Jenkins / JENKINS-42137 Don't fetch run data on an event if it not already in the store Change By: Tom FENNELLY Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42291) REGRESSION: Clicking on the cog icon in blue ocean takes you to an invalid page.
Title: Message Title Tom FENNELLY updated JENKINS-42291 Jenkins / JENKINS-42291 REGRESSION: Clicking on the cog icon in blue ocean takes you to an invalid page. Change By: Tom FENNELLY Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42137) Don't fetch run data on an event if it not already in the store
Title: Message Title Tom FENNELLY started work on JENKINS-42137 Change By: Tom FENNELLY Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38751) run results and main header to provide an "escape" link to get back to a classic view of a Pipeline/job
Title: Message Title Tom FENNELLY updated JENKINS-38751 Jenkins / JENKINS-38751 run results and main header to provide an "escape" link to get back to a classic view of a Pipeline/job Change By: Tom FENNELLY Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38361) Developing blue ocean on windows
Title: Message Title Tom FENNELLY commented on JENKINS-38361 Re: Developing blue ocean on windows I'd need to grab a windows machine and try it. Looks like a paths issue while trying to exec the mvnbuild script. Everyone should just use Linux/MacOS Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39646) Properly generate bundles for packages that have multiple top-level modules
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-39646 Properly generate bundles for packages that have multiple top-level modules Change By: Tom FENNELLY js-modules, js-builder etc were written based on some assumptions (pre Blue Ocean). The main one that's relevant to this task was the assumption that dependency packages are always accessed via a single top-level/entry/main module and that that modules would be the bundle entry-point module.Of course in reality that's not how some NPM packages are created. Some of them contain multiple top-level/entry modules. React is the one most relevant to Blue Ocean ... it has lots of top level modules, so much so that lots of secondary/child NPM packages have sprung up in the react eco system that do nothing more than define an NPM "main" module entry point for a module inside the react package e.g. some of the ones we use in Blue Ocean ... "react-dom", "react-addons-css-transition-group", "react-addons-test-utils".We need to change how our bundling works so that we can properly accommodate this reality, generating dependency bundles that are guaranteed to contain all the package modules needed so that all entry-modules are covered/supported by the bundle. Likewise, when generating bundles that depend on these packages, we need to make sure that the externalized/shared bundle is always wired in properly and that no external dep modules "leak" in through the back door.I've been working on this off-and-on over the last week or two. I've made progress on it (blueocean.js now at abou 0.6Mb), but have run into other react pita issues now (react == "pain" for me :) ). I've not been able to figure that issue out and I think I'm going to need to build some more tooling for myself in order to do that (will also hopefully help when we hit the next react/other bundling issue) - see JENKINS-39657.So, parking this issue for now and we will come back to it later. Relevant WIP:* https://github.com/tfennelly/jenkins-js-builder/tree/all-extern-bundles* https://github.com/tfennelly/blueocean-plugin/tree/all-extern-bundles Add Comment
[JIRA] (JENKINS-39646) Properly generate bundles for packages that have multiple top-level modules
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-39646 Properly generate bundles for packages that have multiple top-level modules Change By: Tom FENNELLY We fixed js-modules, js-builder etc were written based on some bundling issues last week ... non bootstrap bundles assumptions ( dashboard etc pre Blue Ocean ) are now back down . The main one that's relevant to somewhat reasonable sizes (they were at ~ 2Mb this task was the assumption that dependency packages are always accessed via a single top-level/entry/main module and that that modules would be the bundle entry-point module.Of course in reality that's not how some cases), but the blueocean NPM packages are created . js bootstrp bundle Some of them contain multiple top-level/entry modules. React is still at about 3Mb because we have the kitchen sink thrown in there one most relevant to Blue Ocean . If .. it 's going to be has lots of top level modules, so much so that huge (something we did not know earlier lots of secondary/child NPM packages have sprung up in the game), then react eco system that do nothing more than define an NPM "main" module entry point for a module inside the react package e.g. some of the ones we use in Blue Ocean ... "react-dom", "react-addons-css-transition-group", "react-addons-test-utils".We need to tweak change how our bundling works so that we can properly accommodate this reality, generating dependency bundles are doing guaranteed to contain all the bundling package modules needed so that all entry-modules are covered/supported by the bundle . Likewise, when generating bundles that depend on these packages, we need to make sure that the externalized/shared bundle is always wired in properly and that no external dep modules "leak" in through the back door. I've been working on this off-and-on over the last week or two. I've made progress on it (blueocean.js now at abou 0.6Mb), but have run into other react pita issues now (react == "pain" for me :) ). I've not been able to figure that issue out and I think I'm going to need to build some more tooling for myself in order to do that (will also hopefully help when we hit the next react/other bundling issue) - see JENKINS-39657.So, parking this issue for now and we will come back to it later. Relevant WIP:* https://github.com/tfennelly/jenkins-js-builder/tree/all-extern-bundles* https://github.com/tfennelly/blueocean-plugin/tree/all-extern-bundles
[JIRA] (JENKINS-39646) Properly generate bundles for packages that have multiple top-level modules
Title: Message Title Tom FENNELLY commented on JENKINS-39646 Re: Properly generate bundles for packages that have multiple top-level modules However, we need some browser tooling in order to do this properly (see JENKINS-39657). We need to be able to reliably analyse across all bundles in the browser at runtime. ATM, I do this manually by opening the bundles and looking in them visually. I also created a CLI tool called browserify-tree that does help a lot, but again, it only allows me to analyse a single bundle. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39646) Properly generate bundles for packages that have multiple top-level modules
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-39646 Properly generate bundles for packages that have multiple top-level modules Change By: Tom FENNELLY Priority: Major Blocker Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39646) Properly generate bundles for packages that have multiple top-level modules
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-39646 Properly generate bundles for packages that have multiple top-level modules Change By: Tom FENNELLY Issue Type: Task Bug Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39646) Properly generate bundles for packages that have multiple top-level modules
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-39646 Properly generate bundles for packages that have multiple top-level modules Change By: Tom FENNELLY Summary: Extract more dependencies out into their own JS Properly generate bundles for packages that have multiple top-level modules Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39646) Extract more dependencies out into their own JS bundles
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-39646 Extract more dependencies out into their own JS bundles Change By: Tom FENNELLY Component/s: js-builder Component/s: js-modules Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42249) Safari 10.x issues with paths containing URL encoded characters
Title: Message Title Tom FENNELLY commented on JENKINS-42249 Re: Safari 10.x issues with paths containing URL encoded characters Something to check ... inspect the source for the Open Blue Ocean button and check what the href is. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42249) Safari 10.x issues with paths containing URL encoded characters
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-42249 Safari 10.x issues with paths containing URL encoded characters Change By: Tom FENNELLY This is an issue that needs to be investigated more. It spun out of JENKINS-41425.Basically ...# create a folder "Foo"# create a job in that folder named "Bar"# open the job in classic Jenkins and press the "Open Blue Ocean" buttonWorks on Chrome, FF and Safari 9.x. Doesn't work on Safari 10.x.The BO URL for this job will be {{blue/organizations/jenkins/Foo%2FBar}}. It sounds like Safari 10.x is URL decoding the path and converting it into {{blue/organizations/jenkins/Foo/Bar}}, causing the user to see a 404. This is not happening on the other browsers tested (including the earlier version of Safari). Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send
[JIRA] (JENKINS-41425) Refreshing page with / in job name results in 404
Title: Message Title Tom FENNELLY commented on JENKINS-41425 Re: Refreshing page with / in job name results in 404 Thanks Robert. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41425) Refreshing page with / in job name results in 404
Title: Message Title Tom FENNELLY commented on JENKINS-41425 Re: Refreshing page with / in job name results in 404 Okay, can we park the safari issue away from this issue because it's a separate issue and I think it's confusing people wrt this issue. I created a ticket for that: JENKINS-42249. Wrt this issue, Robert Watkins would it be possible for you to build PR842 and try it with your setup? I was able to reproduce the same or similar issues to the ones you describe by just creating a job with slashes in the name via the script console. PR842 resolved those issues. Note that Vivek Pandey wants to do PR842 some other way (hence he has taken this ticket), but it would be interesting to know if it fixed some/all of your issues too. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42249) Safari 10.x issues with paths containing URL encoded characters
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-42249 Safari 10.x issues with paths containing URL encoded characters Change By: Tom FENNELLY This is an issue that needs to be investigated more. It spun out of JENKINS-41425.Basically ...# create a folder "Foo"# create a job in that folder named "Bar"# open the job and press the "Open Blue Ocean" buttonWorks on Chrome, FF and Safari 9.x. Doesn't work on Safari 10.x.The BO URL for this job will be {{blue/organizations/jenkins/Foo%2FBar}}. It sounds like Safari 1 10 .x is URL decoding the path and converting it into {{blue/organizations/jenkins/Foo/Bar}}, causing the user to see a 404. This is not happening on the other browsers tested (including the earlier version of Safari). Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to
[JIRA] (JENKINS-42249) Safari 10.x issues with paths containing URL encoded characters
Title: Message Title Tom FENNELLY created an issue Jenkins / JENKINS-42249 Safari 10.x issues with paths containing URL encoded characters Issue Type: Bug Assignee: Unassigned Components: blueocean-plugin Created: 2017/Feb/22 10:37 AM Priority: Minor Reporter: Tom FENNELLY This is an issue that needs to be investigated more. It spun out of JENKINS-41425. Basically ... create a folder "Foo" create a job in that folder named "Bar" open the job and press the "Open Blue Ocean" button Works on Chrome, FF and Safari 9.x. Doesn't work on Safari 10.x. The BO URL for this job will be blue/organizations/jenkins/Foo%2FBar. It sounds like Safari 1.x is URL decoding the path and converting it into blue/organizations/jenkins/Foo/Bar, causing the user to see a 404. This is not happening on the other browsers tested (including the earlier version of Safari). Add Comment
[JIRA] (JENKINS-41425) Refreshing page with / in job name results in 404
Title: Message Title Tom FENNELLY commented on JENKINS-41425 Re: Refreshing page with / in job name results in 404 Robert Watkins Hey Robert ... I just tried your list of instructions there wrt the Open button and it worked fine for me on Safari 9.1.2. Anyway ... this seems to be a different issue to the main issue described in this ticket. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41425) Refreshing page with / in job name results in 404
Title: Message Title Tom FENNELLY commented on JENKINS-41425 Re: Refreshing page with / in job name results in 404 Or just open the script console and run ... def jenkins = Jenkins.getInstance(); jenkins.createProject(org.jenkinsci.plugins.workflow.job.WorkflowJob, "a/job/with/slashes"); I assume it's also possible via the rest api. It's a core Jenkins problem ... this is an unenforced "rule" i.e. it's allowed as far as we're concerned, so needs to be accommodated. Trying to pass it back to other plugins is a waste of time imo. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40206) Eliminate shrinkwrap pain
Title: Message Title Tom FENNELLY commented on JENKINS-40206 Re: Eliminate shrinkwrap pain Has also been pointed out to us (by Yoann Dubreuil ) that we can't use an NPM registry (or there are serious issues using one) because of shrinkwrap. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42196) Eliminate overly-eager SSE ping request
Title: Message Title Tom FENNELLY updated JENKINS-42196 Jenkins / JENKINS-42196 Eliminate overly-eager SSE ping request Change By: Tom FENNELLY Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38751) run results and main header to provide an "escape" link to get back to a classic view of a Pipeline/job
Title: Message Title Tom FENNELLY started work on JENKINS-38751 Change By: Tom FENNELLY Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-34973) RejectedAccessException thrown but no pending script approval added
Title: Message Title Tom FENNELLY commented on JENKINS-34973 Re: RejectedAccessException thrown but no pending script approval added should just be officially documented Who reads documentation? (Tongue in cheek) Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42196) Eliminate overly-eager SSE ping request
Title: Message Title Tom FENNELLY updated JENKINS-42196 Jenkins / JENKINS-42196 Eliminate overly-eager SSE ping request Change By: Tom FENNELLY Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42196) Eliminate overly-eager SSE ping request
Title: Message Title Tom FENNELLY started work on JENKINS-42196 Change By: Tom FENNELLY Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42196) Eliminate overly-eager SSE ping request
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-42196 Eliminate overly-eager SSE ping request Change By: Tom FENNELLY Sprint: 1.0 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42137) Don't fetch run data on an event if it not already in the store
Title: Message Title Tom FENNELLY started work on JENKINS-42137 Change By: Tom FENNELLY Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42196) Eliminate overly-eager SSE ping request
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-42196 Eliminate overly-eager SSE ping request Change By: Tom FENNELLY Component/s: blueocean-plugin Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42137) Don't fetch run data on an event if it not already in the store
Title: Message Title Tom FENNELLY stopped work on JENKINS-42137 Change By: Tom FENNELLY Status: In Progress Open Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41425) Refreshing page with / in job name results in 404
Title: Message Title Tom FENNELLY updated JENKINS-41425 Jenkins / JENKINS-41425 Refreshing page with / in job name results in 404 Change By: Tom FENNELLY Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41425) Refreshing page with / in job name results in 404
Title: Message Title Tom FENNELLY commented on JENKINS-41425 Re: Refreshing page with / in job name results in 404 WiP PR: https://github.com/jenkinsci/blueocean-plugin/pull/842 I think Vivek Pandey needs to have a close look at this. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42196) Eliminate overly-eager SSE ping request
Title: Message Title Tom FENNELLY commented on JENKINS-42196 Re: Eliminate overly-eager SSE ping request Noticed this while investigating JENKINS-42137. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42196) Eliminate overly-eager SSE ping request
Title: Message Title Tom FENNELLY created an issue Jenkins / JENKINS-42196 Eliminate overly-eager SSE ping request Issue Type: Bug Assignee: Tom FENNELLY Components: sse-gateway-plugin Created: 2017/Feb/20 10:29 AM Priority: Minor Reporter: Tom FENNELLY Atm, the SSE client executes an immediate ping request to the server on receipt of an SSE channel error. This is too eager. We should wait a few seconds before performing the ping, giving the SSE connection a chance to see if it can "fix" itself (e.g. during a reconnect). I was sure this was how it was working already. Maybe I unwittingly introduced this at some point. Add Comment
[JIRA] (JENKINS-41425) Refreshing page with / in job name results in 404
Title: Message Title Tom FENNELLY updated JENKINS-41425 Jenkins / JENKINS-41425 Refreshing page with / in job name results in 404 Change By: Tom FENNELLY Status: Reopened Open Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41425) Refreshing page with / in job name results in 404
Title: Message Title Tom FENNELLY started work on JENKINS-41425 Change By: Tom FENNELLY Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40980) Slow connections can cause module loading to time out
Title: Message Title Tom FENNELLY commented on JENKINS-40980 Re: Slow connections can cause module loading to time out Brody Maclean Hey Brody ... can you spec the UI for this please. Something that shows a message along the lines of "Sorry, we're having trouble loading the Blue Ocean UI. Please check your connection quality and then try reloading.". Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42137) Keep an eye on SSE events and resulting REST API calls
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-42137 Keep an eye on SSE events and resulting REST API calls Change By: Tom FENNELLY Sprint: iapetus post-release Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36408) Client-side replay (or store and forward) of SSE events
Title: Message Title Tom FENNELLY stopped work on JENKINS-36408 Change By: Tom FENNELLY Status: In Progress Open Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36408) Client-side replay (or store and forward) of SSE events
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-36408 Client-side replay (or store and forward) of SSE events Change By: Tom FENNELLY Sprint: 1.0-m11, 1.0-m12, iapetus post-release Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42068) undefined jobs in activity list
Title: Message Title Tom FENNELLY updated JENKINS-42068 Jenkins / JENKINS-42068 undefined jobs in activity list Change By: Tom FENNELLY Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36408) Client-side replay (or store and forward) of SSE events
Title: Message Title Tom FENNELLY commented on JENKINS-36408 Re: Client-side replay (or store and forward) of SSE events I can see how I’d want to do this, but the problem I’m having atm is in creating the scenario that demos how it is required. The use case I listed in the description no longer seems to require client-side SAF. I'll keep poking to see can I reproduce the scenario, but if I can't maybe we should just park this for now and come back once we have a hard requirement for it. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42137) Keep an eye on SSE events and resulting REST API calls
Title: Message Title Tom FENNELLY commented on JENKINS-42137 Re: Keep an eye on SSE events and resulting REST API calls Ben Walding you're dead right to flag it. Thanks for keeping an eye on these things Ben As I was saying to Michael Neale, one small change in the wrong place could easily lead to disaster, so these things are something we need to keep a close eye on. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42137) Keep an eye on SSE events and resulting REST API calls
Title: Message Title Tom FENNELLY commented on JENKINS-42137 Re: Keep an eye on SSE events and resulting REST API calls Perhaps in future we could avoid the fetch if we know for sure it ain't needed That sounds perfectly reasonable, but in reality is not easy to do because this is a SPA. If we receive an event about something that's in the data store (but not visible on the screen at that time), we need to decide how to handle that i.e. update that data, invalidate it (so it will be retrieved again if it's needed after transitioning to a different route) etc etc. And invalidation of data probably isn't as clean/easy as you might think either, because it might mean you actually need to invalidate a lot more than just "that run" (for example) if the data is part of a collection etc etc. If you go down that road then, we'd start seeing tickets about what appear to be unnecessary REST API calls to refetch data that "appears" to be getting invalidated for no good reason. There are lots of swings and round-about, tradeoffs etc. It's rarely as clearcut as it seems. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42137) Keep an eye on SSE events and resulting REST API calls
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-42137 Keep an eye on SSE events and resulting REST API calls Change By: Tom FENNELLY + This ticket started life as a bug, after observing what was thought to be a regression. + The BlueOcean main pipeline screen (https://ci.blueocean.io/blue/pipelines) appears to be receiving events for running pipelines that are not visible, and then fetching data, creating more than expected traffic.On a regular basis this sends event from the backend to the frontend detailing things that are running.h4. To reproduce* Open /blue/pipelines/ in one tab* Run a job like bwalding-alwaysBlue from a classic screen in another tab* Note that /blue/pipelines/ receives events for this job and does requests. h4. Some detailsEvent socket:https://ci.blueocean.io/sse-gateway/listen/jenkins-blueocean-core-js-1487311928759-80shtgg3w8q5hpelba9k9Event data:{noformat}open {"dispatcherId":"jenkins-blueocean-core-js-1487311928759-80shtgg3w8q5hpelba9k9","dispatcherInst":1238701885} 16:15:00.445job {"jenkins_object_type":"org.jenkinsci.plugins.workflow.job.WorkflowRun","jenkins_event_uuid":"6c1358f1-f887-41bb-beb9-3228dda99df8","sse_subs_dispatcher_inst":"1238701885","job_run_status":"SUCCESS","job_name":"scratch/bwalding-alwaysBlue","jenkins_org":"jenkins","job_run_queueId":"5246","jenkins_object_name":"#2","blueocean_job_rest_url":"/blue/rest/organizations/jenkins/pipelines/scratch/pipelines/bwalding-alwaysBlue/","jenkins_object_id":"2","jenkins_event":"job_run_ended","sse_subs_dispatcher":"jenkins-blueocean-core-js-1487311928759-80shtgg3w8q5hpelba9k9","blueocean_job_pipeline_name":"scratch/bwalding-alwaysBlue","jenkins_object_url":"job/scratch/job/bwalding-alwaysBlue/2/","jenkins_channel":"job"} {noformat}Once the frontend receives those events, the frontend then makes a call to retrieve details about the run.https://ci.blueocean.io/blue/rest/organizations/jenkins/pipelines/scratch/pipelines/bwalding-alwaysBlue/runs/2/However the important thing to note is that the bwalding-alwaysBlue job is not visible on the front screen - so the frontend is querying the backend for details on jobs that will not change the state of the front end (afaik)In a large instance that is running a lot of jobs all the time, this could be problematic.
[JIRA] (JENKINS-42137) Keep an eye on SSE events and resulting REST API calls
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-42137 Keep an eye on SSE events and resulting REST API calls Change By: Tom FENNELLY This ticket started life as a bug, after observing what was thought to be a regression. The BlueOcean main pipeline screen (https://ci.blueocean.io/blue/pipelines) appears to be receiving events for running pipelines that are not visible, and then fetching data, creating more than expected traffic.On a regular basis this sends event from the backend to the frontend detailing things that are running.h4. To reproduce* Open /blue/pipelines/ in one tab* Run a job like bwalding-alwaysBlue from a classic screen in another tab* Note that /blue/pipelines/ receives events for this job and does requests. h4. Some detailsEvent socket:https://ci.blueocean.io/sse-gateway/listen/jenkins-blueocean-core-js-1487311928759-80shtgg3w8q5hpelba9k9Event data:{noformat}open {"dispatcherId":"jenkins-blueocean-core-js-1487311928759-80shtgg3w8q5hpelba9k9","dispatcherInst":1238701885} 16:15:00.445job {"jenkins_object_type":"org.jenkinsci.plugins.workflow.job.WorkflowRun","jenkins_event_uuid":"6c1358f1-f887-41bb-beb9-3228dda99df8","sse_subs_dispatcher_inst":"1238701885","job_run_status":"SUCCESS","job_name":"scratch/bwalding-alwaysBlue","jenkins_org":"jenkins","job_run_queueId":"5246","jenkins_object_name":"#2","blueocean_job_rest_url":"/blue/rest/organizations/jenkins/pipelines/scratch/pipelines/bwalding-alwaysBlue/","jenkins_object_id":"2","jenkins_event":"job_run_ended","sse_subs_dispatcher":"jenkins-blueocean-core-js-1487311928759-80shtgg3w8q5hpelba9k9","blueocean_job_pipeline_name":"scratch/bwalding-alwaysBlue","jenkins_object_url":"job/scratch/job/bwalding-alwaysBlue/2/","jenkins_channel":"job"} {noformat}Once the frontend receives those events, the frontend then makes a call to retrieve details about the run.https://ci.blueocean.io/blue/rest/organizations/jenkins/pipelines/scratch/pipelines/bwalding-alwaysBlue/runs/2/However the important thing to note is that the bwalding-alwaysBlue job is not visible on the front screen - so the frontend is querying the backend for details on jobs that will not change the state of the front end (afaik)In a large instance that is running a lot of jobs all the time, this could be problematic.
[JIRA] (JENKINS-42137) Keep an eye on SSE events and resulting REST API calls
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-42137 Keep an eye on SSE events and resulting REST API calls Change By: Tom FENNELLY Summary: A lot of unnecessary requests for pipeline run details and Keep an eye on SSE events and resulting REST API calls Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.