[JIRA] (JENKINS-17027) Ratio red/green bar wrong
Title: Message Title SCM/JIRA link daemon commented on JENKINS-17027 Re: Ratio red/green bar wrong Code changed in jenkins User: Marcus Bauer Path: src/main/java/hudson/plugins/jacoco/model/Coverage.java src/main/java/hudson/plugins/jacoco/model/CoverageObject.java http://jenkins-ci.org/commit/jacoco-plugin/6adf351a1cef5438d98bf49d4dbc1c45a4b5ec1c Log: JENKINS-17027 Red/green ratio is wrong This issue is adressed by taking the total number of lines, etc. into account – instead of only the covered or missing items (depends on whether you have 50% coverage or more) Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-17027) Ratio red/green bar wrong
Title: Message Title Martin Heinzerling closed an issue as Fixed Jenkins / JENKINS-17027 Ratio red/green bar wrong Change By: Martin Heinzerling Status: Resolved Closed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-17027) Ratio red/green bar wrong
Laurent Schoelens commented on JENKINS-17027 Ratio red/green bar wrong Hello everyone, I think the best solution would be to add an option for the plugin to set the graphical representation length of uncovered lines / covered lines. By default we would keep this representation, and another option would be to set the length of graphical representation of M/C lines according to the M/(M+C) and C/(M+C) percentage. Greetings, Laurent This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-17027) Ratio red/green bar wrong
Ognjen Bubalo commented on JENKINS-17027 Ratio red/green bar wrong Hi, "Nevertheless the ratio of each red/green bar should represent the calculated percentage of the cell." No because the percentage does not tell us too much, but the length of missed and covered objects does. Check Marc's response in this thread:https://groups.google.com/d/msg/jenkins-jacoco-plugin-mailing-list/9pJCQpjEOck/X7Zo-MoLEw0J Cheers, Ogi This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-17027) Ratio red/green bar wrong
Marcel L commented on JENKINS-17027 Ratio red/green bar wrong Hi Ogi, well the percentage does tell me something very important. The percentage tells me I have 55% covered. Not more and not less. But If the graphical representation shows me 90% uncovered it's just wrong. And if the graphical respresentation of the percentage is wrong I don't see why I should use it. I got Marc's and your point. The total length of the red/green bar gives me further informations. Comparing percentage between projects is not of much use. But I don't wan't to do that here. I would like to use the red/green bar to quickly spot areas which should be improved. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-17027) Ratio red/green bar wrong
Marcel L commented on JENKINS-17027 Ratio red/green bar wrong Hi Ogi, I understand the length of the bars depend the max coverages of each column. Ok that's fine. Nevertheless the ratio of each red/green bar should represent the calculated percentage of the cell. If you simply look at the 2nd row 2nd col, you could think. low coverage ,Close to 10%. But the percentage number gives you 55%. This is non intuitive and wrong in my opinion. I'm not talking about the length of each red/green bar it's just about the ration red/green This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-17027) Ratio red/green bar wrong
Ognjen Bubalo commented on JENKINS-17027 Ratio red/green bar wrong Hi, I think we discussed this in this issue: https://issues.jenkins-ci.org/browse/JENKINS-16946 As I see it is alright except the alignment of the bars and when the MissedCovered issue occurs, but this is not what I see on the picture. Cheers, Ogi This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-17027) Ratio red/green bar wrong
Marcel L commented on JENKINS-17027 Ratio red/green bar wrong Hi Ogi, could you the explain me the 2nd row ? In the first col I'say the ratio red/green is ~75/25 but it says 58%. 2nd row 2nd col is more obvious. It says 55 %, bute the red bar has 80% or 90% red. Cheers, Marcel This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-17027) Ratio red/green bar wrong
Ognjen Bubalo commented on JENKINS-17027 Ratio red/green bar wrong Hi Marcel, The bar-s length is not connected to the coverage percent. The bar starts from the left. So if we check the second row second column: The percent is 55% because (366/(366+298))*100. If 366 is the maximum length than the 298/366 is the red bar's length and 366 is the green bar's. The maximum length depends on other rows in that column. So lets say C: 366 is the biggest number of covered (I see only 2 rows), so other rows in that particular column have to be shorter. This is because we want to compare object's coverage with other objects. Check the 1st row. It is way shorter because it has only C:48. Cheers, Ogi This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-17027) Ratio red/green bar wrong
Marcel L created JENKINS-17027 Ratio red/green bar wrong Issue Type: Bug Assignee: Ognjen Bubalo Attachments: bug2.png Components: jacoco Created: 01/Mar/13 6:46 PM Description: The ratio M:C view on the red / green bar is wrong sometimes. Please check the calculation. See example attached Project: Jenkins Priority: Major Reporter: Marcel L This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.