[JIRA] (JENKINS-26137) Mysterious serialization errors
Title: Message Title SCM/JIRA link daemon commented on JENKINS-26137 Re: Mysterious serialization errors Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/cps/CpsThreadGroup.java http://jenkins-ci.org/commit/workflow-cps-plugin/92019ea288775c5d2e357f701472b52e40a7cc99 Log: Merge pull request #117 from jglick/no-PickleFactory-JENKINS-26137 JENKINS-26137 Pass pickleFactories directly into the RiverWriter constructor Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/c2de116720e0...92019ea28877 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26137) Mysterious serialization errors
Title: Message Title SCM/JIRA link daemon commented on JENKINS-26137 Re: Mysterious serialization errors Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/cps/CpsThreadGroup.java http://jenkins-ci.org/commit/workflow-cps-plugin/6012a8232a2214bc7f42be528461154d82bac486 Log: JENKINS-26137 Pass pickleFactories directly into the RiverWriter constructor. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26137) Mysterious serialization errors
Title: Message Title SCM/JIRA link daemon commented on JENKINS-26137 Re: Mysterious serialization errors Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/support/pickles/serialization/RiverWriter.java http://jenkins-ci.org/commit/workflow-support-plugin/b4c0da271dbff56b46eb0603bbcf4be174db25f4 Log: JENKINS-26137 Pass pickleFactories directly into the RiverWriter constructor. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26137) Mysterious serialization errors
Title: Message Title SCM/JIRA link daemon commented on JENKINS-26137 Re: Mysterious serialization errors Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/support/pickles/serialization/RiverWriter.java http://jenkins-ci.org/commit/workflow-support-plugin/a3389777f39dcbae5c7758980f1c6a0d02b65c62 Log: Merge pull request #35 from jglick/no-PickleFactory-JENKINS-26137 JENKINS-26137 Pass pickleFactories directly into the RiverWriter constructor Compare: https://github.com/jenkinsci/workflow-support-plugin/compare/467dd0dca178...a3389777f39d Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26137) Mysterious serialization errors
Title: Message Title Jesse Glick commented on JENKINS-26137 Re: Mysterious serialization errors Filed workflow-basic-steps PR 39 (and its upstream PRs) attempting to troubleshoot the recurrent exception from RiverWriter. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26137) Mysterious serialization errors
Title: Message Title Jesse Glick commented on JENKINS-26137 Re: Mysterious serialization errors I think the main issue here could be resolved if the field lines in the stack trace specified the class name too. There is also an issue that RiverWriter can apparently be missing the list of pickles under some conditions TBD, which is something I can take care of. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26137) Mysterious serialization errors
Title: Message Title Jesse Glick updated an issue Jenkins / JENKINS-26137 Mysterious serialization errors Change By: Jesse Glick Labels: diagnostics kohsuke-plane-project robustness Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26137) Mysterious serialization errors
Title: Message Title Kohsuke Kawaguchi updated an issue Jenkins / JENKINS-26137 Mysterious serialization errors Change By: Kohsuke Kawaguchi Labels: kohsuke-plane-project robustness Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26137) Mysterious serialization errors
Title: Message Title Mor L updated an issue Jenkins / JENKINS-26137 Mysterious serialization errors Change By: Mor L Comment: Or better yet - pipeline should start supporting all the data structures that are supported in groovy :)This includes (from the list of non-serialized objects I encountered so far): maps, xmlSlurper and sun.net.www.protocol.https.HttpsURLConnectionImpl Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26137) Mysterious serialization errors
Title: Message Title Mor L commented on JENKINS-26137 Re: Mysterious serialization errors Or better yet - pipeline should start supporting all the data structures that are supported in groovy This includes (from the list of non-serialized objects I encountered so far): maps, xmlSlurper and sun.net.www.protocol.https.HttpsURLConnectionImpl Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26137) Mysterious serialization errors
Title: Message Title Jesse Glick commented on JENKINS-26137 Re: Mysterious serialization errors You would need to use some other data structure. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26137) Mysterious serialization errors
Title: Message Title Mor L commented on JENKINS-26137 Re: Mysterious serialization errors I know about that, I actually only parse the xml on the main method to avoid having to do that multiple times and do all the access in a @NonCPS method, I guess that's not enough? How would you suggest to use xmlSlurper given I need to parse it once but access it many times and not hit the non serialializable error? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26137) Mysterious serialization errors
Title: Message Title Jesse Glick commented on JENKINS-26137 Re: Mysterious serialization errors As noted here any usage of non-Serializable values must be encapsulated in a @NonCPS method. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26137) Mysterious serialization errors
Title: Message Title
Mor L edited a comment on JENKINS-26137
Re: Mysterious serialization errors
Hi,I'm facing the same issue as this comment https://issues.jenkins-ci.org/browse/JENKINS-26137?focusedCommentId=251415=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-251415Is there a workaround? *Update*: Found a workaround.You need to take whatever you need from the xml and store in strings/lists etc. and before doing anything else set the variable used to parse the xml to null{code:java}node {... def pomXml = readFile('pom.xml') bat "echo before XmlSlurper().parseText()" def parsedPomXml = new XmlSlurper().parseText(pomXml) //do whatever you need with parsedPomXml //when done - set it to null parsedPomXml = null //now this should work (the same goes for calling emailext which is where I faced the issue) bat "echo after XmlSlurper().parseText()"}{code} Thanks,Mor
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26137) Mysterious serialization errors
Title: Message Title Mor L commented on JENKINS-26137 Re: Mysterious serialization errors Hi, I'm facing the same issue as this comment https://issues.jenkins-ci.org/browse/JENKINS-26137?focusedCommentId=251415=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-251415 Is there a workaround? Thanks, Mor Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26137) Mysterious serialization errors
Title: Message Title
Jesse Glick commented on JENKINS-26137
Re: Mysterious serialization errors
Can still observe some random test failures such as
restartDuringDelay(org.jenkinsci.plugins.workflow.steps.WaitForConditionStepTest) Time elapsed: 6.845 sec <<< FAILURE!
java.lang.AssertionError:
Started
[Pipeline] waitUntil
[Pipeline] {
[Pipeline] semaphore
[Pipeline] }
Will try again after 0.25 sec
[Pipeline] {
[Pipeline] semaphore
[Pipeline] }
Will try again after 29,247,120 yr
Resuming build
[Pipeline] {
[Pipeline] }
[Pipeline] // waitUntil
[Pipeline] End of Pipeline
java.lang.IllegalStateException: JENKINS-26137: Jenkins is shutting down
at org.jenkinsci.plugins.workflow.support.pickles.serialization.RiverWriter.(RiverWriter.java:92)
at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.saveProgram(CpsThreadGroup.java:431)
at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.saveProgram(CpsThreadGroup.java:412)
at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.run(CpsThreadGroup.java:357)
at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.access$100(CpsThreadGroup.java:78)
at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:236)
at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:224)
at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$2.call(CpsVmExecutorService.java:63)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:112)
at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
Finished: FAILURE
at org.jenkinsci.plugins.workflow.test.steps.SemaphoreStep.waitForStart(SemaphoreStep.java:144)
at org.jenkinsci.plugins.workflow.steps.WaitForConditionStepTest$7.evaluate(WaitForConditionStepTest.java:169)
despite running with this precheck from JENKINS-32015, suggesting that some Jenkins.instance is set yet extensions are not loaded. If this happens during shutdown, then keeping a WeakHashMap cache would suffice as a workaround. If during startup, then it would not; that would suggest that flow resumption is happening too early. Hard to tell which, since the failure is not reproducible. At least the precheck should be modified to directly check PickleFactory.all().isEmpty().
[JIRA] (JENKINS-26137) Mysterious serialization errors
Title: Message Title Jesse Glick updated an issue Jenkins / JENKINS-26137 Mysterious serialization errors Change By: Jesse Glick Component/s: workflow-support-plugin Component/s: pipeline Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
