[JIRA] (JENKINS-31314) Running asynchronous code inside a @NonCPS method should fail cleanly
Title: Message Title Jesse Glick resolved as Fixed Jenkins / JENKINS-31314 Running asynchronous code inside a @NonCPS method should fail cleanly Change By: Jesse Glick Status: Reopened Resolved Resolution: Fixed Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.166049.1446212529000.7265.1572637322123%40Atlassian.JIRA.
[JIRA] (JENKINS-31314) Running asynchronous code inside a @NonCPS method should fail cleanly
Title: Message Title Sergei Parshev updated an issue Jenkins / JENKINS-31314 Running asynchronous code inside a @NonCPS method should fail cleanly Change By: Sergei Parshev Comment: Yep, confirmed here: https://github.com/griddynamics/mpl/issues/31#issuecomment-548919000 Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.166049.1446212529000.7228.1572636361633%40Atlassian.JIRA.
[JIRA] (JENKINS-31314) Running asynchronous code inside a @NonCPS method should fail cleanly
Title: Message Title Sergei Parshev reopened an issue Sorry, closed by mistake Jenkins / JENKINS-31314 Running asynchronous code inside a @NonCPS method should fail cleanly Change By: Sergei Parshev Resolution: Fixed Status: Closed Reopened Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit
[JIRA] (JENKINS-31314) Running asynchronous code inside a @NonCPS method should fail cleanly
Title: Message Title Sergei Parshev commented on JENKINS-31314 Re: Running asynchronous code inside a @NonCPS method should fail cleanly Yep, confirmed here: https://github.com/griddynamics/mpl/issues/31#issuecomment-548919000 Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.166049.1446212529000.7147.1572636242693%40Atlassian.JIRA.
[JIRA] (JENKINS-31314) Running asynchronous code inside a @NonCPS method should fail cleanly
Title: Message Title Sergei Parshev closed an issue as Fixed Jenkins / JENKINS-31314 Running asynchronous code inside a @NonCPS method should fail cleanly Change By: Sergei Parshev Status: Resolved Closed Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.166049.1446212529000.7149.1572636242734%40Atlassian.JIRA.
[JIRA] (JENKINS-31314) Running asynchronous code inside a @NonCPS method should fail cleanly
Title: Message Title Jesse Glick commented on JENKINS-31314 Re: Running asynchronous code inside a @NonCPS method should fail cleanly Florian Wilhelm JFR is being tracked in JENKINS-58407. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.166049.1446212529000.8736.1562937062194%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31314) Running asynchronous code inside a @NonCPS method should fail cleanly
Title: Message Title Florian Wilhelm commented on JENKINS-31314 Re: Running asynchronous code inside a @NonCPS method should fail cleanly Hi Devin Nusbaum, I’m afraid this change broke our Jenkinsfile runner based testing because the warnings will be thrown as an exception there. Reproducer here https://github.com/fwilhe/repro-cps-issue I know we have to fix this in a proper way, but is there some way to turn it into warnings also on Jenkinsfile runner and not have it throw an exception? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.166049.1446212529000.8576.1562922540860%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31314) Running asynchronous code inside a @NonCPS method should fail cleanly
Title: Message Title Devin Nusbaum updated JENKINS-31314 A fix for this issue was released in Pipeline: Groovy Plugin version 2.71. Jenkins / JENKINS-31314 Running asynchronous code inside a @NonCPS method should fail cleanly Change By: Devin Nusbaum Status: Fixed but Unreleased Resolved Released As: workflow-cps 2.71 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.166049.1446212529000.3224.1562360821529%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31314) Running asynchronous code inside a @NonCPS method should fail cleanly
Title: Message Title Devin Nusbaum updated JENKINS-31314 Jenkins / JENKINS-31314 Running asynchronous code inside a @NonCPS method should fail cleanly Change By: Devin Nusbaum Status: In Review Fixed but Unreleased Resolution: Fixed Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.166049.1446212529000.1813.1560787982484%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31314) Running asynchronous code inside a @NonCPS method should fail cleanly
Title: Message Title Jesse Glick updated JENKINS-31314 Jenkins / JENKINS-31314 Running asynchronous code inside a @NonCPS method should fail cleanly Change By: Jesse Glick Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31314) Running asynchronous code inside a @NonCPS method should fail cleanly
Title: Message Title Jesse Glick commented on JENKINS-31314 Re: Running asynchronous code inside a @NonCPS method should fail cleanly No, I had a prototype but stopped work on this. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31314) Running asynchronous code inside a @NonCPS method should fail cleanly
Title: Message Title Yngvar Kristiansen commented on JENKINS-31314 Re: Running asynchronous code inside a @NonCPS method should fail cleanly Any progress on this? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31314) Running asynchronous code inside a @NonCPS method should fail cleanly
Title: Message Title Vivek Pandey updated an issue Jenkins / JENKINS-31314 Running asynchronous code inside a @NonCPS method should fail cleanly Change By: Vivek Pandey Labels: diagnostics groovy kohsuke-plane-project triaged-2018-11 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31314) Running asynchronous code inside a @NonCPS method should fail cleanly
Title: Message Title Andrew Bayer commented on JENKINS-31314 Re: Running asynchronous code inside a @NonCPS method should fail cleanly I’ll take a look tomorrow. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31314) Running asynchronous code inside a @NonCPS method should fail cleanly
Title: Message Title Jesse Glick commented on JENKINS-31314 Re: Running asynchronous code inside a @NonCPS method should fail cleanly Seems to be catching the cases I would want it to catch. For now it is catching too much, and it will be some work to prune the warnings back to legitimate cases. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31314) Running asynchronous code inside a @NonCPS method should fail cleanly
Title: Message Title Jesse Glick started work on JENKINS-31314 Change By: Jesse Glick Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31314) Running asynchronous code inside a @NonCPS method should fail cleanly
Title: Message Title Jesse Glick assigned an issue to Jesse Glick Jenkins / JENKINS-31314 Running asynchronous code inside a @NonCPS method should fail cleanly Change By: Jesse Glick Assignee: Jesse Glick Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31314) Running asynchronous code inside a @NonCPS method should fail cleanly
Title: Message Title Jesse Glick commented on JENKINS-31314 Re: Running asynchronous code inside a @NonCPS method should fail cleanly Not sure. Linked to a sketch of doing the detection for the originally suggested case. Definitely there are others, and those might be harder to handle—I am not sure. Maybe you can figure something out from these hints. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31314) Running asynchronous code inside a @NonCPS method should fail cleanly
Title: Message Title Andrew Bayer commented on JENKINS-31314 Re: Running asynchronous code inside a @NonCPS method should fail cleanly Jesse Glick - so, I'm lost. DSL.invokeStep is only happening for actual Step implementations, right? So any other CPS-transformed code never calls Continuable.suspend. And CpsClosure throws CpsCallableInvocation from its call and doCall methods. Given that most of the problem cases are actually CpsClosure instances throwing CpsCallableInvocation in non-CPS contexts, how would any of what you said work there? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31314) Running asynchronous code inside a @NonCPS method should fail cleanly
Title: Message Title Jesse Glick commented on JENKINS-31314 Re: Running asynchronous code inside a @NonCPS method should fail cleanly perhaps just print a warning This is the most attractive option since any mistakes would not result in a serious regression, just a misleading message. I think this could be accomplished with the help of a new method PrintStream Invoker.getLog() which CpsFlowExecution.start could delegate to owner.getListener().getLogger(), thus making messages appear in the build log (outside the scope of any particular step). Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31314) Running asynchronous code inside a @NonCPS method should fail cleanly
Title: Message Title recampbell updated an issue Jenkins / JENKINS-31314 Running asynchronous code inside a @NonCPS method should fail cleanly Change By: recampbell Labels: diagnostics groovy kohsuke-plane-project Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31314) Running asynchronous code inside a @NonCPS method should fail cleanly
Title: Message Title Jesse Glick updated an issue Jenkins / JENKINS-31314 Running asynchronous code inside a @NonCPS method should fail cleanly Change By: Jesse Glick Component/s: workflow-cps-plugin Component/s: pipeline Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31314) Running asynchronous code inside a @NonCPS method should fail cleanly
Title: Message Title Jesse Glick commented on JENKINS-31314 Re: Running asynchronous code inside a @NonCPS method should fail cleanly only call them from the master node All Pipeline scripts runs inside the master process. node blocks have no effect on this whatsoever. They only control where nested sh steps and the like connect to. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
