[JIRA] (JENKINS-37190) Unauthenticated request to GitHub trigger rate limits when adding organization
Title: Message Title Stephen Connolly commented on JENKINS-37190 Re: Unauthenticated request to GitHub trigger rate limits when adding organization The GitHub Branch Source 2.0.0-beta-1 (and newer) behaviour is to wait until the organization folder is saved before starting any indexing. You may still hit the anonymous API rate limit if you configure anonymous against an organization that requires more than 60 API calls to scan, but there is not much we can do about that Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37190) Unauthenticated request to GitHub trigger rate limits when adding organization
Title: Message Title Stephen Connolly resolved as Won't Fix The GitHub Org Folders plugin is being tombstoned. The functionality provided by the GitHub Org Folders plugin has been significantly refactored and migrated to the GitHub Branch Source plugin. Please verify if this issue is an issue with GitHub Branch Source 2.0.0-beta-1 (available from the experimental update center now or 2.0.0 (available in early January 2017) Jenkins / JENKINS-37190 Unauthenticated request to GitHub trigger rate limits when adding organization Change By: Stephen Connolly Status: Open Resolved Resolution: Won't Fix Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
[JIRA] (JENKINS-37190) Unauthenticated request to GitHub trigger rate limits when adding organization
Title: Message Title Kanstantsin Shautsou updated an issue Jenkins / JENKINS-37190 Unauthenticated request to GitHub trigger rate limits when adding organization Change By: Kanstantsin Shautsou Component/s: github-api-plugin Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37190) Unauthenticated request to GitHub trigger rate limits when adding organization
Title: Message Title Kohsuke Kawaguchi commented on JENKINS-37190 Re: Unauthenticated request to GitHub trigger rate limits when adding organization I don't think that's what the bug report is trying to explain. The problem is that there's a period of time during the creation of the org folder, where the credential to scan is not yet set. Basically, after the first "create item" screen is done but before the first configuration is saved. The call stack clearly shows that this is the point in which the call is happening. Any GH API calls happen during this is unauthenticated, which is subject to very low API limit. The fix should be that we should hold off any GH API access at least until the first time the configuration is saved. There's already a flag inside `Job` that keeps track of this initial period for other reasons to help us implement this. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37190) Unauthenticated request to GitHub trigger rate limits when adding organization
Title: Message Title Michael Neale commented on JENKINS-37190 Re: Unauthenticated request to GitHub trigger rate limits when adding organization This looks like it is due to the name of the item being created being the github org (that was a recent change, but likely the real bug). Thus if you put in a name for an org you don't own, that could result in rate limits (would that make sense?) Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37190) Unauthenticated request to GitHub trigger rate limits when adding organization
Title: Message Title Giovanni Tirloni created an issue Jenkins / JENKINS-37190 Unauthenticated request to GitHub trigger rate limits when adding organization Issue Type: Bug Assignee: Kohsuke Kawaguchi Components: github-api-plugin, github-organization-folder-plugin Created: 2016/Aug/04 8:57 PM Environment: Jenkins 2.16 GitHub API Plugin 1.76 GitHub Branch Source Plugin 1.8.1 GitHub Organization Folder Plugin 1.4 GitHub plugin 1.20.0 Pipeline 2.2 Priority: Minor Reporter: Giovanni Tirloni When adding a new GitHub organization, the initial attempts to create access it and create the GH webhooks do not seem to be authenticated, triggering GH's rate limits. Aug 04, 2016 8:45:10 PM org.jenkinsci.plugins.orgfolder.github.ItemListenerImpl maybeApply WARNING: Failed to apply GitHub Org Folder theme to crash-test-dummies org.jenkinsci.plugins.github_branch_source.RateLimitExceededException: GitHub API rate limit exceeded at org.jenkinsci.plugins.github_branch_source.Connector$1.onError(Connector.java:177) at org.kohsuke.github.Requester.handleApiError(Requester.java:544) at org.kohsuke.github.Requester._to(Requester.java:264) at org.kohsuke.github.Requester.to(Requester.java:205) at org.kohsuke.github.GitHub.getUser(GitHub.java:293) at org.jenkinsci.plugins.orgfolder.github.MainLogic.applyOrg(MainLogic.java:62) at org.jenkinsci.plugins.orgfolder.github.ItemListenerImpl.maybeApply(ItemListenerImpl.java:41) at org.jenkinsci.plugins.orgfolder.github.ItemListenerImpl.onCreated(ItemListenerImpl.java:34) at hudson.model.listeners.ItemListener$2.apply(ItemListener.java:186) at
