[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Brian J Murrell edited a comment on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes [~aldochristiaan] By _multiple pipeline job_ do you mean GitHub Organisation jobs? Because I agree, the proposed solution here doesn't seem to apply, AFAICT, to the GitHub Source Branch Plugin multibranch-pipeline job.So those users still need a solution to these build storms that just take down your Jenkins machine every time a base branch (i.e. master) is updated. I guess we need [ another ticket |https://issues . jenkins-ci.org/browse/JENKINS-55822]. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Brian J Murrell edited a comment on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes [~aldochristiaan] By _multiple pipeline job_ do you mean GitHub Organisation jobs? Because I agree, the proposed solution here doesn't seem to apply, AFAICT, to the GitHub Source Branch Plugin multibranch-pipeline job.So those users still need a solution to these build storms that just take down your Jenkins machine every time a base branch (i.e. master) is updated. I guess we need another ticket. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Brian J Murrell edited a comment on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes [~aldochristiaan] By _multiple pipeline job_ do you mean GitHub Organisation jobs? Because I agree, the proposed solution here doesn't seem to apply, AFAICT, to the GitHub Source Branch Plugin multibranch-pipeline job.So those users still need a solution to these build storms that just take down your Jenkins machine every time a base branch (i.e. master) is updated. I guess we need another ticket. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Brian J Murrell commented on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes Aldo Christian By multiple pipeline job do you mean GitHub Organisation jobs? Because I agree, the proposed solution here doesn't seem to apply, AFAICT, to the GitHub Source Branch Plugin multibranch-pipeline job. So those users still need a solution to these build storms that just take down your Jenkins machine every time a base branch (i.e. master) is updated. I guess we need another ticket. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Aldo Christian commented on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes Stephen Connolly hey, i've installed the plugins, but i can't find the options on my multiple pipeline job .. Could you help me please ? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Joshua Noble commented on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes I can confirm that setting up the Basic Branch Build Strategies plugin and selecting Regular Branches and Change Requests (with Ignore rebuilding merge branches checked) indeed gives us exactly what we want. Thanks for the tip! Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Jesse Glick commented on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes For safety, you may want to then configure GitHub to refuse to let PRs be merged unless they are up to date with the base branch—IOW to only permit fast-forward merges from the GUI. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Stephen Connolly closed an issue as Fixed Resolution: Install Basic Branch Build Strategies plugin and add the "Change Requests" with "Ignore rebuilding merge branches when only the target branch changed" selected to your build strategies Jenkins / JENKINS-37491 Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes Change By: Stephen Connolly Status: Open Closed Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Stephen Connolly commented on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes For the record, if you want to avoid triggering rebuilds when just the target branch of the PR has changed then you want https://github.com/jenkinsci/basic-branch-build-strategies-plugin/blob/master/docs/user.adoc#change-requests IMHO this problem is closed by the feature "Ignore rebuilding merge branches when only the target branch changed" in the Basic Branch Build Strategy plugin's "Change Requests" strategy Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Joshua Noble edited a comment on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes I'm also now seeing build storms from this issue.One can turn off "Periodically if not otherwise run" to prevent the storms, but then you're left with orphaned jobs being left behind when a branch is deleted. Therefore, if one tries to use the branch source plugin, they either have to deal with build storms, or with orphaned jobs. I don't think I saw this issue back when the core functionality existed in the GitHub Organization Folders plugin. Perhaps this is a regression? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Joshua Noble commented on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes I'm also now seeing build storms from this issue. One can turn off "Periodically if not otherwise run" to prevent the storms, but then you're left with orphaned jobs being left behind when a branch is deleted. Therefore, if one tries to use the branch source plugin, they either have to deal with build storms, or with orphaned jobs. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title
Justin Rainwater commented on JENKINS-37491
Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
I wanted to add here a solution I found that feels like a nice workaround at least for my needs:
In GitHub Org options check to build both merged and unmerged PRs so you have a bunch of PR jobs ending in -merge and -head.
In the auto branch triggering field add PR-\d+-head so you auto build all head jobs but not all merge jobs. This will avoid the build storm that causes so many problems.
From inside the Jenkinsfile add something like this:
// have head job trigger merge job...
if (autoTriggered() && env.BRANCH_NAME.endsWith('head')) {
def headJobName = "${env.BRANCH_NAME}"
def mergeJobName = (headJobName.substring(0, headJobName.length() - 4)).concat('merge') // replace head with merge
build job: mergeJobName, wait: false
return
}
autoTriggered() is the function I added that returns false if cause description contains "Started by...". All this does is check if it's a head job and if so it triggers the corresponding merge job and exits. It feels a little too simple and too good to be true, but at first glance it seems like this gives best of both worlds of auto triggering merge jobs only on changes to head and avoiding the buildStorm.
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Justin Rainwater commented on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes Related question: is there a way to differentiate whether a rebuild was triggered by update to base branch or head? I've setup our pipeline job so that I differentiate whether a job is manually or autotriggered by checking currentBuild.rawBuild.getCause(hudson.model.Cause$UserIdCause).properties.shortDescription for "Started by". It would be super helpful if the "Branch Indexing" message were more granular since I may want to take different action with my build depending on the event that triggered the hook, etc. Thanks Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Spencer Malone commented on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes I'm a fan of the current behavior, it helps ensure safety on PRs that are left open for weeks. If we're going to stay that route, I just need some way to just say "Don't let the master try to checkout more than x repos at once for the purposes of changelog + Jenkinsfile loading" Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Justin Rainwater commented on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes +1 to Spencer Malone's comment. I was hoping there might be an additional option in recent plugin updates to only rebuild PRs when folks commit to their PR and not when the base branch is updated. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Stephen Connolly commented on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes Patrick Wolf FYI another use-case ^^^ Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title spencer malone commented on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes Is there a way to rate limit those builds triggered by the full reindexes? We have a large (2 gig) repo with 60-100 PRs open at any one time, and lots of PR churn. When that indexing kicks in, it queues all the PRs for a rebuild, and often things start breaking as the master tries to check out all those PRs at once. The problem is I can't seem to configure the master's checkout behavior at all (referring to the master's flyweight executors checking things out before we run the Jenkinsfile). Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Jesse Glick commented on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes By the way it seems that currently while a full reindex of the repository will trigger builds of all merge PR jobs which have a new base branch commit, an event (such as webhook) updating the base branch does not immediately trigger those builds. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Jesse Glick commented on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes Justin Rainwater: no. ma pi you more or less described what I already wrote: merge against the latest base commit which is not newer […] than the PR head commit under the assumption that the build starts quickly and the checkout in fact comes before any other base branch commit lands. If the checkout is delayed (for example because of a busy build queue), the behavior I described is preferable to simply merging against the tip of the base branch in that it is more deterministic what the merge commit will be. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Justin Rainwater commented on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes Is this addressed by the Github Branch Source updates? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title ma pi commented on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes I think, the most of people(include me) want... Build Trigger: When PR's head(unmerged) updated. Build Target(what to checkout): merged commit with base branch.(build with merged Jenkinsfile) Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Michael Neale commented on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes It's also hard to describe all these options to people - the reality is "do you want lots of builds when you merge to master" - but most people would say "no". Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Bill Hamilton commented on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes Sorry I meant to say that I liked Kurt Madel's solution (branch protection). Stephens solution could still result in build storms. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Bill Hamilton commented on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes Stephen Connolly, yes that sounds like a good solution. We are considering changing our PR build support recommendation to be: If you want Jenkins PR build support, choose the option to build the PR at head (not merge). Any changes to your task branch and PR will result in the PR being built at head. To insure that your merge doesn’t destabilize master, choose the Git “branch protection” option on Master. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Michael Neale commented on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes Stephen Connolly that actually sounds like a reasonably useful solution to that problem. Build storms are common with that turned on... so mostly I have turned that off as it just wasn't practical when you have a bunch of pull requests in progress... Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Stephen Connolly commented on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes With GitHub Branch Source 2.0.0-beta-1 (available from the experimental update center now or 2.0.0 (available in early January 2017) When you push a change to the base branch, it should trigger only the base branch. The PR-merge branches will get rebuilt when the indexing kicks in as indexing will detect that the merge commit is now different, but that should only happen once a day/week (depending on how often you configure indexing) so should be much less of an issue Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Kurt Madel updated an issue Jenkins / JENKINS-37491 Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes Change By: Kurt Madel Attachment: screenshot-1.png Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Kurt Madel commented on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes I may not follow correctly, but I believe one more option may be to select the 'unmerged head' for all PRs - origin and fork - and then use the GitHub protected branch feature to force branches (PRs) to be up to date with the base branch before being allowed to merge: Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Michael Neale commented on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes Lee Webb I had a similar situation - many open PRs, and it would exhaust things. In that case I turned of the merge build (as it was worth it in my case) but that isn't true for everyone. I think that is the only option for now - but if you really want the validated merge, then what is needed is a new option: do not rebuild when master changes, which I think jesse mentioned as a possibility Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Lee Webb commented on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes Thanks for the explanations Jesse & Michael, While I completely understand the intent, I think we really need to have an option to inhibit the re-trigger yet keep the ability to build merge instead of the PR's HEAD. In our case: We have a team of 12 constantly raising PR's & merging them into the baseline There is an average of about 10 PR's which are in an open state Each build takes about 25 mins to perform A minimum of 10 nodes are required to execute a sub-set of tests in parallel for each build When we enabled the 'merge with base branch' functionality the following very quickly occurred: Jenkins rapidly started queuing jobs up to something like 400 Our autoscaling group backing the ECS docker nodes for each parallel job went from the usually quiet 3-5 went straight to it's cap of 20 Each PR ended up having multiple builds executing all on different baselines None of the developers were able to determine whether their PR's were valid because they were constantly rebuilding Github started rejecting API requests because we were over the rate limit - I imagine because branch indexing was churning over & over for every github hook execution With Github check protection turned on it was not possible to merge a PR because the commit status notification was nearly always 'building' The team basically chose to ignore the CI system ... if the CI isn't the source of truth then anarchy! Perhaps if our situation was somewhat different then it'd be perfectly acceptable to let it do rebuilds when the baseline changes, however in our case (& probably many others) as you can see it actually just crushes development team productivity not to mention all of the infrastructure which is attached. Pretty please, can we not have to make ugly workaround hacks in the pipeline itself because we can't filter the triggering but want the git plugin(s) to do the merge for us?
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Michael Neale commented on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes Yes, once explained it makes sense. Technically current PR builders (not this one) do the wrong thing and give a false sense of the state of a validation and merge ready-ness. As Jesse pointed out - this is a trade of of: How often can you tolerate a broken master: 1) sometimes 3) never. Jesse Glick this seems a subtle point, having behavior like exisitng PR builders would be probably interesting, although all of this is hard to communicate without arm waving, so not sure how to present it as an option (but this is probably not the first time it has come up as a point of confusion). Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Jesse Glick commented on JENKINS-37491 Re: Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes Had a long discussion with Michael Neale about this. Briefly, if you are not rebuilding when the base branch changes, then Jenkins is not really verifying that the merge product is valid. So you need to pick some tradeoff between fidelity and performance: something in between the true merge build and the head build. One option would be to merge against the latest base commit which is not newer (according to recorded commit timestamp—not necessarily related to push time) than the PR head commit. This would probably be the closest to the prior behavior of this plugin, which used the poorly documented and unreliable merge ref from GitHub, and would match the behavior of your workaround if I understand it. Another option would be to merge against new base commits, but only at limited intervals, like a day or a week—so for example if you had an old PR sitting around dormant, it would periodically get rechecked against new base versions, but not on every base branch push. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37491) Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes
Title: Message Title Lee Webb created an issue Jenkins / JENKINS-37491 Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes Issue Type: Bug Assignee: Unassigned Components: github-branch-source-plugin Created: 2016/Aug/18 1:59 AM Environment: github-branch-source 1.8.1 jenkins 2.18 Priority: Major Reporter: Lee Webb When 'Build Origin PRs (merge with base branch)' is selected any PR's which are filed against a base branch are re-triggered when the base branch changes. While this is all fine if you have a small # of PR's & the builds are quick, if you have a large team & backlog of PR's then any merge to the base branch will automatically trigger every PR which is using the same baseline. When you then end up with is a Jenkins that has a massive queue to process & github often complaining that you've exceeded the API rate limit. The concept of building the merge branch is great, however at the moment I really can't use it because of the previously stated behaviour & causes massive issues for our builds. Previous versions of the plugin didn't exhibit this behaviour at all, nor do other systems like travis which build PR's using the merge branch, nor did the github pull request builder plugin. As a workaround I'm forced to use the 'Build Origin PRs (unmerged HEAD)' and then conduct the merge or checkout of the GH merge branch itself within the pipeline which is less than ideal. Can we have an option to inhibit a re-trigger when the baseline changes for PRs with merge? btw I like where this plugin is going
