[JIRA] (JENKINS-38169) Single parameter steps don't work when using named parameter in workflow-cps 2.14/2.15

2016-10-31 Thread scm_issue_l...@java.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 SCM/JIRA link daemon commented on  JENKINS-38169  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Single parameter steps don't work when using named parameter in workflow-cps 2.14/2.15   
 

  
 
 
 
 

 
 Code changed in jenkins User: Jesse Glick Path: pom.xml http://jenkins-ci.org/commit/docker-workflow-plugin/0e95a7bf7af6d647ed3ebc5d1a6ab8dce5c59549 Log: Actually needed to upgrade a bit further to pick up the fix of JENKINS-38169.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-38169) Single parameter steps don't work when using named parameter in workflow-cps 2.14/2.15

2016-09-13 Thread jgl...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jesse Glick updated  JENKINS-38169  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-38169  
 
 
  Single parameter steps don't work when using named parameter in workflow-cps 2.14/2.15   
 

  
 
 
 
 

 
Change By: 
 Jesse Glick  
 
 
Status: 
 In Review Resolved  
 
 
Resolution: 
 Fixed  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-38169) Single parameter steps don't work when using named parameter in workflow-cps 2.14/2.15

2016-09-13 Thread scm_issue_l...@java.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 SCM/JIRA link daemon commented on  JENKINS-38169  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Single parameter steps don't work when using named parameter in workflow-cps 2.14/2.15   
 

  
 
 
 
 

 
 Code changed in jenkins User: Andrew Bayer Path: src/main/java/org/jenkinsci/plugins/workflow/cps/DSL.java src/test/java/org/jenkinsci/plugins/workflow/DSLTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/90f348ece9220c55885d67bb00aeee3737bbeda4 Log: [FIXED JENKINS-38169] Treat single required+named param differently. If you call `echo message:'foo'` previous to this change, the Map that gets passed as the first element of args ends up being used as the sole parameter itself, so you end up with `name:[name:'foo']` being passed as the args. That's obviously wrong. So let's add a check to see if there is a `soleArgumentKey`, the arg map only has one key/value, and that key is equal to `soleArgumentKey` - if that's true, just pass the arg map directly.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-38169) Single parameter steps don't work when using named parameter in workflow-cps 2.14/2.15

2016-09-13 Thread andrew.ba...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Andrew Bayer updated  JENKINS-38169  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-38169  
 
 
  Single parameter steps don't work when using named parameter in workflow-cps 2.14/2.15   
 

  
 
 
 
 

 
Change By: 
 Andrew Bayer  
 
 
Status: 
 In  Progress  Review  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-38169) Single parameter steps don't work when using named parameter in workflow-cps 2.14/2.15

2016-09-13 Thread andrew.ba...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Andrew Bayer commented on  JENKINS-38169  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Single parameter steps don't work when using named parameter in workflow-cps 2.14/2.15   
 

  
 
 
 
 

 
 Tentative PR up at https://github.com/jenkinsci/workflow-cps-plugin/pull/56.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-38169) Single parameter steps don't work when using named parameter in workflow-cps 2.14/2.15

2016-09-13 Thread andrew.ba...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Andrew Bayer started work on  JENKINS-38169  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
Change By: 
 Andrew Bayer  
 
 
Status: 
 Open In Progress  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-38169) Single parameter steps don't work when using named parameter in workflow-cps 2.14/2.15

2016-09-13 Thread andrew.ba...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Andrew Bayer created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-38169  
 
 
  Single parameter steps don't work when using named parameter in workflow-cps 2.14/2.15   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Andrew Bayer  
 
 
Components: 
 workflow-cps-plugin  
 
 
Created: 
 2016/Sep/13 2:45 PM  
 
 
Environment: 
 workflow-cps 2.14 and 2.15  
 
 
Priority: 
  Critical  
 
 
Reporter: 
 Andrew Bayer  
 

  
 
 
 
 

 
 Reported over at https://issues.jenkins-ci.org/browse/JENKINS-38037?focusedCommentId=269757=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-269757 - this code: 

 

stage("Create file")
{
node {
sh 'touch myfile'
stash name:"stash-name", includes:'myfile'
}
}

stage("Crash by executing single argument DSL function")
{
node {
unstash name:"stash-name"
println "We'll never get here."
}
}
 

 ...produces this stacktrace: 

 

org.kohsuke.stapler.NoStaplerConstructorException: There's no @DataBoundConstructor on any constructor of class java.lang.String
	at org.kohsuke.stapler.ClassDescriptor.loadConstructorParamNames(ClassDescriptor.java:247)
	at org.jenkinsci.plugins.structs.describable.DescribableModel.(DescribableModel.java:121)
	at org.jenkinsci.plugins.structs.describable.DescribableModel.coerce(DescribableModel.java:372)
	at