[JIRA] (JENKINS-38228) Incorrect implementation of `loadUserByUsename`, Users are added on demand
Title: Message Title SCM/JIRA link daemon commented on JENKINS-38228 Re: Incorrect implementation of `loadUserByUsename`, Users are added on demand Code changed in jenkins User: Denys Digtiar Path: src/main/java/org/jenkinsci/plugins/saml/SamlUserDetailsService.java http://jenkins-ci.org/commit/saml-plugin/227d80860f144113a42e40bfce22971ba28f345e Log: JENKINS-38228 - User lookup method is changed in Details Services. (#16) Loading existing user by name should not be creating new users. Therefore, the User lookup method is updated to disable automatic creation of users. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38228) Incorrect implementation of `loadUserByUsename`, Users are added on demand
Title: Message Title Ivan Fernandez Calvo updated JENKINS-38228 Jenkins / JENKINS-38228 Incorrect implementation of `loadUserByUsename`, Users are added on demand Change By: Ivan Fernandez Calvo Status: In Review Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38228) Incorrect implementation of `loadUserByUsename`, Users are added on demand
Title: Message Title Ivan Fernandez Calvo resolved as Fixed Jenkins / JENKINS-38228 Incorrect implementation of `loadUserByUsename`, Users are added on demand Change By: Ivan Fernandez Calvo Status: In Progress Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38228) Incorrect implementation of `loadUserByUsename`, Users are added on demand
Title: Message Title Ivan Fernandez Calvo edited a comment on JENKINS-38228 Re: Incorrect implementation of `loadUserByUsename`, Users are added on demand [~duemir] I finally I realice that the step 3 has to be done into the role strategy configuration by adding users to groups for example, It is not the same issue that I was testing, I agree that the PR resolves the issue. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38228) Incorrect implementation of `loadUserByUsename`, Users are added on demand
Title: Message Title Ivan Fernandez Calvo updated JENKINS-38228 Jenkins / JENKINS-38228 Incorrect implementation of `loadUserByUsename`, Users are added on demand Change By: Ivan Fernandez Calvo Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38228) Incorrect implementation of `loadUserByUsename`, Users are added on demand
Title: Message Title Ivan Fernandez Calvo updated JENKINS-38228 Jenkins / JENKINS-38228 Incorrect implementation of `loadUserByUsename`, Users are added on demand Change By: Ivan Fernandez Calvo Status: Reopened Open Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38228) Incorrect implementation of `loadUserByUsename`, Users are added on demand
Title: Message Title Ivan Fernandez Calvo started work on JENKINS-38228 Change By: Ivan Fernandez Calvo Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38228) Incorrect implementation of `loadUserByUsename`, Users are added on demand
Title: Message Title Ivan Fernandez Calvo commented on JENKINS-38228 Re: Incorrect implementation of `loadUserByUsename`, Users are added on demand Denys Digtiar I finally I realice that the step 3 has to be done into the role strategy configuration by adding users to groups for example, It is not the same issue that I was testing, I agree that the PR resolves the issue. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38228) Incorrect implementation of `loadUserByUsename`, Users are added on demand
Title: Message Title Denys Digtiar commented on JENKINS-38228 Re: Incorrect implementation of `loadUserByUsename`, Users are added on demand Ivan Fernandez Calvo are we talking about the same thing? This is not about Id that IdP returns. Changing UserName will not make any difference. The problem is that SamlUserDetailsService to reconstruct User uses API that creates Users on demand. No matter what username Authorization Strategy query from SamlSecurityRealm it says such user exists because it creates them on demand. The fix in PR is just changing the `User#get` method to the one that is not creating users by default. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38228) Incorrect implementation of `loadUserByUsename`, Users are added on demand
Title: Message Title Ivan Fernandez Calvo commented on JENKINS-38228 Re: Incorrect implementation of `loadUserByUsename`, Users are added on demand Denys Digtiar Did you set the setting "Username Attribute" in configuration and it does not work? when you set this setting the name of the user is taken from this attribute it is not more random generated. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38228) Incorrect implementation of `loadUserByUsename`, Users are added on demand
Title: Message Title Denys Digtiar commented on JENKINS-38228 Re: Incorrect implementation of `loadUserByUsename`, Users are added on demand It is still an issue I believe. Linking a fix which should make it more clear. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38228) Incorrect implementation of `loadUserByUsename`, Users are added on demand
Title: Message Title Denys Digtiar reopened an issue Jenkins / JENKINS-38228 Incorrect implementation of `loadUserByUsename`, Users are added on demand Change By: Denys Digtiar Resolution: Not A Defect Status: Resolved Reopened Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38228) Incorrect implementation of `loadUserByUsename`, Users are added on demand
Title: Message Title Ivan Fernandez Calvo resolved as Not A Defect We will add some validation and warnings to configuration form on JENKINS-40144 Jenkins / JENKINS-38228 Incorrect implementation of `loadUserByUsename`, Users are added on demand Change By: Ivan Fernandez Calvo Status: In Progress Resolved Resolution: Not A Defect Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to
[JIRA] (JENKINS-38228) Incorrect implementation of `loadUserByUsename`, Users are added on demand
Title: Message Title Ivan Fernandez Calvo commented on JENKINS-38228 Re: Incorrect implementation of `loadUserByUsename`, Users are added on demand If you set configuration parameter "Username Attribute" the user ID always is the same and it is get from this attribute of reply from IdP Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38228) Incorrect implementation of `loadUserByUsename`, Users are added on demand
Title: Message Title Ivan Fernandez Calvo started work on JENKINS-38228 Change By: Ivan Fernandez Calvo Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38228) Incorrect implementation of `loadUserByUsename`, Users are added on demand
Title: Message Title Ivan Fernandez Calvo assigned an issue to Ivan Fernandez Calvo Jenkins / JENKINS-38228 Incorrect implementation of `loadUserByUsename`, Users are added on demand Change By: Ivan Fernandez Calvo Assignee: Ivan Fernandez Calvo Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38228) Incorrect implementation of `loadUserByUsename`, Users are added on demand
Title: Message Title Denys Digtiar updated an issue Jenkins / JENKINS-38228 Incorrect implementation of `loadUserByUsename`, Users are added on demand Change By: Denys Digtiar Labels: SAML2 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38228) Incorrect implementation of `loadUserByUsename`, Users are added on demand
Title: Message Title Denys Digtiar created an issue Jenkins / JENKINS-38228 Incorrect implementation of `loadUserByUsename`, Users are added on demand Issue Type: Bug Assignee: Unassigned Components: saml-plugin Created: 2016/Sep/15 7:27 AM Environment: Jenkins Docker 2.7.4-alpine saml-plugin 0.6 Priority: Major Reporter: Denys Digtiar Steps to reproduce: 1. Setup the SAML Security Realm 2. Switch to any of the Matrix Authorization strategies 3. Add a random string of characters as users Expected Users mark with appropriate icon as non-existent (i.e. crossed out, icon with a cross) Actual User are added to the Jenkins, see People to confirm. Add Comment
