[JIRA] (JENKINS-38347) Github plugin dependency sporadically fails with NPE during tests

2016-09-20 Thread atg.sleepl...@gmail.com (JIRA) 
Title: Message Title


 
 
 
 

 
 
 

 
   
 Anton Tanasenko commented on  JENKINS-38347  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Github plugin dependency sporadically fails with NPE during tests   
 

  
 
 
 
 

 
 Thanks!  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-38347) Github plugin dependency sporadically fails with NPE during tests

2016-09-20 Thread scm_issue_l...@java.net (JIRA) 
Title: Message Title


 
 
 
 

 
 
 

 
   
 SCM/JIRA link daemon resolved as Fixed  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-38347  
 
 
  Github plugin dependency sporadically fails with NPE during tests   
 

  
 
 
 
 

 
Change By: 
 SCM/JIRA link daemon  
 
 
Status: 
 Open Resolved  
 
 
Resolution: 
 Fixed  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-38347) Github plugin dependency sporadically fails with NPE during tests

2016-09-20 Thread scm_issue_l...@java.net (JIRA) 
Title: Message Title


 
 
 
 

 
 
 

 
   
 SCM/JIRA link daemon commented on  JENKINS-38347  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Github plugin dependency sporadically fails with NPE during tests   
 

  
 
 
 
 

 
 Code changed in jenkins User: Kanstantsin Shautsou Path: src/main/java/org/jenkinsci/plugins/github/GitHubPlugin.java http://jenkins-ci.org/commit/github-plugin/cb7525c70192ad45a6dcb6d7575e5904d218b4ab Log: [FIXED JENKINS-38347] Use Initializer levels. (#139) 
 
[FIXED JENKINS-38347] Use Initializer levels. 
 
 
migrator: Don't throw NPE because Descriptor wasn't ready. 
aliases: user annotation initializer. 
 
 
Ensure execution order. 
 Signed-off-by: Kanstantsin Shautsou  
 
Move to javadoc 
  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+un

[JIRA] (JENKINS-38347) Github plugin dependency sporadically fails with NPE during tests

2016-09-19 Thread gentoo.inte...@gmail.com (JIRA) 
Title: Message Title


 
 
 
 

 
 
 

 
   
 Kanstantsin Shautsou assigned an issue to Kanstantsin Shautsou  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-38347  
 
 
  Github plugin dependency sporadically fails with NPE during tests   
 

  
 
 
 
 

 
Change By: 
 Kanstantsin Shautsou  
 
 
Assignee: 
 Kirill Merkushev Kanstantsin Shautsou  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-38347) Github plugin dependency sporadically fails with NPE during tests

2016-09-19 Thread atg.sleepl...@gmail.com (JIRA) 
Title: Message Title


 
 
 
 

 
 
 

 
   
 Anton Tanasenko created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-38347  
 
 
  Github plugin dependency sporadically fails with NPE during tests   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Kirill Merkushev  
 
 
Components: 
 github-plugin  
 
 
Created: 
 2016/Sep/19 3:18 PM  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Anton Tanasenko  
 

  
 
 
 
 

 
 GithubPlugin.postInitialize() runs Migrator.migrate(), which accesses ExtensionList through GithubPushTrigger.DescriptorImpl.get(). ExtensionsList is not usable until PLUGINS_PREPARED is attained [1] and Plugin.postInitialize() call is not guaranteed to be run after PLUGINS_PREPARED (though it does happen to run after it most of the time). In the example log [2], Migrator.migrate is run at line 368, but PLUGINS_PREPARED is only attained at 499, almost before PLUGINS_STARTED. I think the migration should be run with @Initializer(after=PLUGINS_PREPARED) to be properly working. [1] https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/ExtensionList.java#L282 [2] https://gist.github.com/atanasenko/d364aa30eb2aa07ecdb01af0e7b829be  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment