[JIRA] (JENKINS-39257) p4 plugin escapes/converts plaintext to HTML
Title: Message Title Paul Allen closed an issue as Fixed Fixed in 1.4.9 Jenkins / JENKINS-39257 p4 plugin escapes/converts plaintext to HTML Change By: Paul Allen Status: Resolved Closed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39257) p4 plugin escapes/converts plaintext to HTML
Title: Message Title Paul Allen edited a comment on JENKINS-39257 Re: p4 plugin escapes/converts plaintext to HTML 1. 3 4 .9 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39257) p4 plugin escapes/converts plaintext to HTML
Title: Message Title Paul Allen updated JENKINS-39257 1.3.9 Jenkins / JENKINS-39257 p4 plugin escapes/converts plaintext to HTML Change By: Paul Allen Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39257) p4 plugin escapes/converts plaintext to HTML
Title: Message Title Paul Allen updated JENKINS-39257 Jenkins / JENKINS-39257 p4 plugin escapes/converts plaintext to HTML Change By: Paul Allen Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39257) p4 plugin escapes/converts plaintext to HTML
Title: Message Title Paul Allen started work on JENKINS-39257 Change By: Paul Allen Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39257) p4 plugin escapes/converts plaintext to HTML
Title: Message Title SCM/JIRA link daemon commented on JENKINS-39257 Re: p4 plugin escapes/converts plaintext to HTML Code changed in jenkins User: Paul Allen Path: src/main/java/org/jenkinsci/plugins/p4/changes/P4ChangeEntry.java src/main/resources/org/jenkinsci/plugins/p4/changes/P4ChangeSet/digest.jelly http://jenkins-ci.org/commit/p4-plugin/439c6d2f5e644f0a49995a46611c00421c76d730 Log: Use `textarea` for change description (CSS: 10 rows max) JENKINS-39257 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39257) p4 plugin escapes/converts plaintext to HTML
Title: Message Title Jonas Lindgren commented on JENKINS-39257 Re: p4 plugin escapes/converts plaintext to HTML I Have a similar issue related to the Jira plugin. It injects a link to any mentioned issues in the change notes, and the a href is escaped by p4. We run p4 in parallel with the old perforce plugin during a transition period. The old plugin shows the link as expected while p4 does not, therefor I suspect the bug is in p4. As above, changes show the links as expected while the build summary does not. Jenkins 2.7.4 Jira plugin 2.2.1 P4 plugin: 1.4.6 (This is my first action here. Please let me know if i should have done something differently) Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39257) p4 plugin escapes/converts plaintext to HTML
Title: Message Title Matthew Hall commented on JENKINS-39257 Re: p4 plugin escapes/converts plaintext to HTML The changelog.xml on disk looks like : [root@ 67]# pwd /home/jenkins/jobs/b-monitoring/builds/67 [root@ 67]# more changelog.xml 953319 redacted-monitoring SUMMARY: Dont reuse variables. DETAILS: The code was trying to create a new properties dict for each topic, but was instead reusing the same one over and over. Make it use a new copy each time. This doesnt cause a functional change, but makes the code cleaner. OTS: redacted (visual OTS) TESTING: None redacted 2016-10-25 14:20:04 false Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39257) p4 plugin escapes/converts plaintext to HTML
Title: Message Title Matthew Hall commented on JENKINS-39257 Re: p4 plugin escapes/converts plaintext to HTML To be clear which URL/endpoint I'm referring to : http://jenkins:8080/job/b-monitoring/changes (displays changes correctly) http://jenkins:8080/job/b-monitoring/67/changes (renders the above wrong output) Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39257) p4 plugin escapes/converts plaintext to HTML
Title: Message Title
Matthew Hall edited a comment on JENKINS-39257
Re: p4 plugin escapes/converts plaintext to HTML
This is what the change actually looks like when asking the p4 server : {noformat}$ p4 change -o 953319# A Perforce Change Specification.# # Change: The change number . 'new' on a new changelist . # Date:The date this specification was last modified . # Client: The client on which the changelist was created. Read-only.# User:The user who created the changelist.# Status: Either 'pending' or 'submitted'. Read-only.# Type:Either 'public' or 'restricted'. Default is 'public'.# Description: Comments about the changelist. Required.# ImportedBy: The user who fetched or pushed this change to this server.# Identity:Identifier for this change.# Jobs:What opened jobs are to be closed by this changelist.# You may delete jobs from this list. (New changelists only.)# Files: What opened files from the default changelist are to be added# to this changelist. You may delete files from this list.# (New changelists only.) Change: 953319Date: 2016/10/25 14:20:04Client: redacted-monitoringUser: redactedStatus: submittedDescription:SUMMARY: Don't reuse variables. DETAILS: The code was trying to create a new properties dictfor each topic, but was instead reusing the same one over andover. Make it use a new copy each time. This doesn't cause afunctional change, but makes the code cleaner. OTS: redacted (visual OTS) TESTING: None{noformat}
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
[JIRA] (JENKINS-39257) p4 plugin escapes/converts plaintext to HTML
Title: Message Title Matthew Hall commented on JENKINS-39257 Re: p4 plugin escapes/converts plaintext to HTML This is what the change actually looks like when asking the p4 server : $ p4 change -o 953319 # A Perforce Change Specification. # # Change: The change number. 'new' on a new changelist. # Date:The date this specification was last modified. # Client: The client on which the changelist was created. Read-only. # User:The user who created the changelist. # Status: Either 'pending' or 'submitted'. Read-only. # Type:Either 'public' or 'restricted'. Default is 'public'. # Description: Comments about the changelist. Required. # ImportedBy: The user who fetched or pushed this change to this server. # Identity:Identifier for this change. # Jobs:What opened jobs are to be closed by this changelist. # You may delete jobs from this list. (New changelists only.) # Files: What opened files from the default changelist are to be added # to this changelist. You may delete files from this list. # (New changelists only.) Change: 953319 Date: 2016/10/25 14:20:04 Client: redacted-monitoring User: redacted Status: submitted Description: SUMMARY: Don't reuse variables. DETAILS: The code was trying to create a new properties dict for each topic, but was instead reusing the same one over and over. Make it use a new copy each time. This doesn't cause a functional change, but makes the code cleaner. OTS: redacted (visual OTS) TESTING: None Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
[JIRA] (JENKINS-39257) p4 plugin escapes/converts plaintext to HTML
Title: Message Title Matthew Hall updated an issue Jenkins / JENKINS-39257 p4 plugin escapes/converts plaintext to HTML Change By: Matthew Hall Summary: p4 plugin escapes /converts plaintext to HTML in changelist Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
