[JIRA] (JENKINS-39296) Regression: Shell step failed but step marked as successful

2016-11-02 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay commented on  JENKINS-39296  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Regression: Shell step failed but step marked as successful
 

  
 
 
 
 

 
 Thanks Vivek Pandey  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-39296) Regression: Shell step failed but step marked as successful

2016-11-01 Thread vivek (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Vivek Pandey commented on  JENKINS-39296  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Regression: Shell step failed but step marked as successful
 

  
 
 
 
 

 
 James Dumay This was that ticket where I fixed it. Or you mean bug to fix bismuth API to calculate status of individual steps using StatusAndTiming.computeChunkStatus(run, before, atomNode, atomNode, after)? I have not opened one. I guess it might be more like RFE vs fix as this API is intended for chunks and I was hoping it to work for individual step.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-39296) Regression: Shell step failed but step marked as successful

2016-10-30 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay edited a comment on  JENKINS-39296  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Regression: Shell step failed but step marked as successful
 

  
 
 
 
 

 
 [~vivek] where can I find the issue tracking the fix for the step calculation bug?  Is it JENKINS-38759 ?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-39296) Regression: Shell step failed but step marked as successful

2016-10-30 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay commented on  JENKINS-39296  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Regression: Shell step failed but step marked as successful
 

  
 
 
 
 

 
 Vivek Pandey where can I find the issue tracking the fix for the step calculation bug?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-39296) Regression: Shell step failed but step marked as successful

2016-10-28 Thread vivek (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Vivek Pandey updated  JENKINS-39296  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-39296  
 
 
  Regression: Shell step failed but step marked as successful
 

  
 
 
 
 

 
Change By: 
 Vivek Pandey  
 
 
Status: 
 In Review Resolved  
 
 
Resolution: 
 Fixed  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-39296) Regression: Shell step failed but step marked as successful

2016-10-27 Thread vivek (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Vivek Pandey updated  JENKINS-39296  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-39296  
 
 
  Regression: Shell step failed but step marked as successful
 

  
 
 
 
 

 
Change By: 
 Vivek Pandey  
 
 
Status: 
 In  Progress  Review  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-39296) Regression: Shell step failed but step marked as successful

2016-10-27 Thread mne...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Neale commented on  JENKINS-39296  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Regression: Shell step failed but step marked as successful
 

  
 
 
 
 

 
 ah well spotted. I think this has bit a few people (likely some duplicate tickets too)  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-39296) Regression: Shell step failed but step marked as successful

2016-10-27 Thread vivek (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Vivek Pandey commented on  JENKINS-39296  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Regression: Shell step failed but step marked as successful
 

  
 
 
 
 

 
 James Dumay Michael Neale https://ci.blueocean.io/blue/organizations/jenkins/blueocean/detail/story%2FJENKINS-38847/3/pipeline/ definitely is not right. There is bug in step's status calculation, where its using:  

 

GenericStatus status = StatusAndTiming.computeChunkStatus(run, before, atomNode, atomNode, after);
 

 This is wrong. this is resulting in computing step's status as chunk vs as individual FlowNode. Fix is in progress.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-39296) Regression: Shell step failed but step marked as successful

2016-10-27 Thread vivek (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Vivek Pandey commented on  JENKINS-39296  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Regression: Shell step failed but step marked as successful
 

  
 
 
 
 

 
 James Dumay yeah that step is eating away the error. I suspect the finally block is fine as there is no error in the finally block, however I see errors during node compilation. The pipeline code should be printing error before marking the build as failed. 

 

...
 } catch(err) {
currentBuild.result = "FAILURE"
  } finally {
sendhipchat()
deleteDir()
  }
 

  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-39296) Regression: Shell step failed but step marked as successful

2016-10-27 Thread vivek (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Vivek Pandey commented on  JENKINS-39296  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Regression: Shell step failed but step marked as successful
 

  
 
 
 
 

 
 James Dumay Log doesn't show there was any error in that finally block. However overall run is marked as failed. Something ate that error away. I am going to isolate it as test case and see if I can reproduce. Maybe its underlying library bug.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-39296) Regression: Shell step failed but step marked as successful

2016-10-27 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-39296  
 
 
  Regression: Shell step failed but step marked as successful
 

  
 
 
 
 

 
Change By: 
 James Dumay  
 
 
Attachment: 
  blueocean #3 2016-10-28 10-38-29.png  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-39296) Regression: Shell step failed but step marked as successful

2016-10-27 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay commented on  JENKINS-39296  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Regression: Shell step failed but step marked as successful
 

  
 
 
 
 

 
 Vivek Pandey this looks related https://ci.blueocean.io/blue/organizations/jenkins/blueocean/detail/story%2FJENKINS-38847/3/pipeline/  https://gist.github.com/i386/3817e2b8347f030288c9c41aa6d61895   ! blueocean #3 2016-10-28 10-38-29.png|thumbnail!   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-39296) Regression: Shell step failed but step marked as successful

2016-10-27 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-39296  
 
 
  Regression: Shell step failed but step marked as successful
 

  
 
 
 
 

 
Change By: 
 James Dumay  
 

  
 
 
 
 

 
 For this build one of the steps (third from the bottom) within a try...finally failed but the step was never marked as failedhttps://ci.blueocean.io/blue/organizations/jenkins/blueocean/detail/upgrade-rollbar-1.9.2/1/pipeline/ [~michaelneale] checked the response and the flow node is erroneously marked as failed  https://gist . github.com/michaelneale/658f3bec4487b90ce6d478e90edffad0   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-39296) Regression: Shell step failed but step marked as successful

2016-10-27 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-39296  
 
 
  Regression: Shell step failed but step marked as successful
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Vivek Pandey  
 
 
Components: 
 blueocean-plugin  
 
 
Created: 
 2016/Oct/27 6:26 AM  
 
 
Priority: 
  Critical  
 
 
Reporter: 
 James Dumay  
 

  
 
 
 
 

 
 For this build one of the steps (third from the bottom) within a try...finally failed but the step was never marked as failed https://ci.blueocean.io/blue/organizations/jenkins/blueocean/detail/upgrade-rollbar-1.9.2/1/pipeline/  Michael Neale checked the response and the flow node is erroneously marked as failed.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment