[JIRA] (JENKINS-39407) Use system default Maven, Maven Settings if not specified
Title: Message Title Cyrille Le Clerc edited a comment on JENKINS-39407 Re: Use system default Maven, Maven Settings if not specified Work in progress [ https://github.com/jenkinsci/pipeline-maven-plugin/pull/31 ][https://github.com/jenkinsci/jenkins/pull/2818] Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39407) Use system default Maven, Maven Settings if not specified
Title: Message Title Cyrille Le Clerc commented on JENKINS-39407 Re: Use system default Maven, Maven Settings if not specified Work in progress https://github.com/jenkinsci/pipeline-maven-plugin/pull/31 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39407) Use system default Maven, Maven Settings if not specified
Title: Message Title Alvaro Lobato started work on JENKINS-39407 Change By: Alvaro Lobato Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39407) Use system default Maven, Maven Settings if not specified
Title: Message Title Alvaro Lobato assigned an issue to Cyrille Le Clerc Jenkins / JENKINS-39407 Use system default Maven, Maven Settings if not specified Change By: Alvaro Lobato Assignee: Alvaro Lobato Cyrille Le Clerc Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39407) Use system default Maven, Maven Settings if not specified
Title: Message Title Cyrille Le Clerc commented on JENKINS-39407 Re: Use system default Maven, Maven Settings if not specified FYI I am working on this, I need first to get a change in jenkins-core merged. See JENKINS-40665 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39407) Use system default Maven, Maven Settings if not specified
Title: Message Title SCM/JIRA link daemon commented on JENKINS-39407 Re: Use system default Maven, Maven Settings if not specified Code changed in jenkins User: Cyrille Le Clerc Path: pom.xml src/main/java/org/jenkinsci/plugins/configfiles/buildwrapper/ConfigFileBuildWrapper.java src/main/java/org/jenkinsci/plugins/configfiles/maven/job/MvnGlobalSettingsProvider.java src/main/java/org/jenkinsci/plugins/configfiles/maven/job/MvnSettingsProvider.java http://jenkins-ci.org/commit/config-file-provider-plugin/58621a3f59c16401070853497640c7f0dd7e4ec9 Log: JENKINS-40665JENKINS-39407 Support Maven Settings Provider and Maven Global Settings Provider for pipeline Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39407) Use system default Maven, Maven Settings if not specified
Title: Message Title Cyrille Le Clerc commented on JENKINS-39407 Re: Use system default Maven, Maven Settings if not specified Jesse Glick could you have a look at https://github.com/jenkinsci/jenkins/pull/2678 to verify it this refactoring of jenkins.mvn.SettingsProvider#supplySettings() to support pipeline jobs is moving in the right direction? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39407) Use system default Maven, Maven Settings if not specified
Title: Message Title Jesse Glick commented on JENKINS-39407 Re: Use system default Maven, Maven Settings if not specified Yes we would need to do that. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39407) Use system default Maven, Maven Settings if not specified
Title: Message Title
Cyrille Le Clerc edited a comment on JENKINS-39407
Re: Use system default Maven, Maven Settings if not specified
[~jglick] we seem to have a problem with "{{AbstractBuild}}" versus "{{WorkflowRun}}".Maven default settings are handled by [{{jenkins.mvn.SettingsProvider#supplySettings(AbstractBuild build, TaskListener listener)}}|https://github.com/jenkinsci/jenkins/blob/51619cc80a56fb2681896ccdf6fafb85924a4ac8/core/src/main/java/jenkins/mvn/SettingsProvider.java#L29-L29] which is based on "{{AbstractBuild}}" when pipeline is based on "{{WorkflowRun}}".As we want to use {{jenkins.mvn.SettingsProvider#supplySettings()}} in " {{withMaven() {...\ }} }" , does it seem reasonable to refactor [{{jenkins.mvn.SettingsProvider#supplySettings(AbstractBuild build, TaskListener listener)}}|https://github.com/jenkinsci/jenkins/blob/51619cc80a56fb2681896ccdf6fafb85924a4ac8/core/src/main/java/jenkins/mvn/SettingsProvider.java#L29-L29] into {{jenkins.mvn.SettingsProvider#supplySettings(Run build, TaskListener listener)}}?
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39407) Use system default Maven, Maven Settings if not specified
Title: Message Title Cyrille Le Clerc commented on JENKINS-39407 Re: Use system default Maven, Maven Settings if not specified Jesse Glick we seem to have a problem with "AbstractBuild" versus "WorkflowRun". Maven default settings are handled by jenkins.mvn.SettingsProvider#supplySettings(AbstractBuild build, TaskListener listener) which is based on "AbstractBuild" when pipeline is based on "WorkflowRun". As we want to use jenkins.mvn.SettingsProvider#supplySettings() in withMaven(), does it seem reasonable to refactor jenkins.mvn.SettingsProvider#supplySettings(AbstractBuild build, TaskListener listener) into jenkins.mvn.SettingsProvider#supplySettings(Run build, TaskListener listener)? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39407) Use system default Maven, Maven Settings if not specified
Title: Message Title Robert Watkins commented on JENKINS-39407 Re: Use system default Maven, Maven Settings if not specified That's pretty much the behaviour I would expect. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39407) Use system default Maven, Maven Settings if not specified
Title: Message Title Cyrille Le Clerc commented on JENKINS-39407 Re: Use system default Maven, Maven Settings if not specified So, if the maven settings file (resp maven global settings file) is not define in "withMaven(...)", then we would default to the default strategy defined on Jenkins global config screen (jenkins.mvn.GlobalMavenConfig): jenkins.mvn.GlobalMavenConfig#getSettingsProvider() jenkins.mvn.GlobalMavenConfig#getGlobalSettingsProvider() Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39407) Use system default Maven, Maven Settings if not specified
Title: Message Title Cyrille Le Clerc updated an issue Jenkins / JENKINS-39407 Use system default Maven, Maven Settings if not specified Change By: Cyrille Le Clerc Attachment: maven-global-settings.png Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39407) Use system default Maven, Maven Settings if not specified
Title: Message Title Cyrille Le Clerc updated an issue Jenkins / JENKINS-39407 Use system default Maven, Maven Settings if not specified Change By: Cyrille Le Clerc Attachment: maven-global-settings.png Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39407) Use system default Maven, Maven Settings if not specified
Title: Message Title Robert Watkins commented on JENKINS-39407 Re: Use system default Maven, Maven Settings if not specified Well, it's stock by default unless you, as the Jenkins administrator, change the Jenkins global maven config. As a Jenkins administrator, I must say that if I change the global maven config, I expect it to be used by default. If I didn't want it to be used by default, I wouldn't have made it the global maven config. Basically, what I'm looking for here is parity-of-behaviour with the freestyle plugin. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39407) Use system default Maven, Maven Settings if not specified
Title: Message Title Cyrille Le Clerc commented on JENKINS-39407 Re: Use system default Maven, Maven Settings if not specified This has been debated, some people preferred "stock" by default, others preferred "jenkins global by default". We had in mind to add a global configuration parameter in "manage jenkins" to define the default behavior". Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39407) Use system default Maven, Maven Settings if not specified
Title: Message Title Cyrille Le Clerc edited a comment on JENKINS-39407 Re: Use system default Maven, Maven Settings if not specified This has been debated, some people preferred "stock" by default, others preferred "jenkins global maven config by default".We had in mind to add a global configuration parameter in "manage jenkins" to define the default behavior". Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39407) Use system default Maven, Maven Settings if not specified
Title: Message Title
Robert Watkins created an issue
Jenkins / JENKINS-39407
Use system default Maven, Maven Settings if not specified
Issue Type:
Improvement
Assignee:
Alvaro Lobato
Components:
pipeline-maven-plugin
Created:
2016/Nov/01 2:05 PM
Priority:
Minor
Reporter:
Robert Watkins
Currently, when you use the ``withMaven`` step, you need to specify the Maven installation. Furthermore, if you've configured, using the Managed Files and Global Tools Configuration, a maven settings.xml, you need to specify an ugly ID for that. For example: withMaven(maven: 'Maven 3.3', mavenSettingsConfig: 'ecbd05c9-e03e-4ccb-9aa1-242f9f1a423c') { sh "mvn clean verify -B" } It would be good if these could both be defaulted - at least, the mavenSettingsConfig, which doesn't have to be specified with the freestyle Maven Builder.
Add Comment
