[JIRA] (JENKINS-39454) Race condition in WorkUnitContext copying actions vs. Executor picking off a pending item
Title: Message Title Oliver Gondža commented on JENKINS-39454 Re: Race condition in WorkUnitContext copying actions vs. Executor picking off a pending item Absorbed by 2.32 LTS line. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39454) Race condition in WorkUnitContext copying actions vs. Executor picking off a pending item
Title: Message Title Oliver Gondža updated an issue Jenkins / JENKINS-39454 Race condition in WorkUnitContext copying actions vs. Executor picking off a pending item Change By: Oliver Gondža Labels: 2.19.3-rejected lts-candidate pipeline queue threads Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39454) Race condition in WorkUnitContext copying actions vs. Executor picking off a pending item
Title: Message Title Jesse Glick commented on JENKINS-39454 Re: Race condition in WorkUnitContext copying actions vs. Executor picking off a pending item Yes I developed a workaround in the plugin yesterday, so I think this does not need to be backported. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39454) Race condition in WorkUnitContext copying actions vs. Executor picking off a pending item
Title: Message Title Oliver Gondža updated an issue Jenkins / JENKINS-39454 Race condition in WorkUnitContext copying actions vs. Executor picking off a pending item Change By: Oliver Gondža Labels: 2.19.3-rejected lts-candidate pipeline queue threads Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39454) Race condition in WorkUnitContext copying actions vs. Executor picking off a pending item
Title: Message Title Oleg Nenashev edited a comment on JENKINS-39454 Re: Race condition in WorkUnitContext copying actions vs. Executor picking off a pending item Marked as LTS candidate. Maybe too dangerous to backport + AFAIK there is a workaround applied in the plugins. CC [~jglick] Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39454) Race condition in WorkUnitContext copying actions vs. Executor picking off a pending item
Title: Message Title Oleg Nenashev commented on JENKINS-39454 Re: Race condition in WorkUnitContext copying actions vs. Executor picking off a pending item Marked as LTS candidate. Maybe too dangerous to backport Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39454) Race condition in WorkUnitContext copying actions vs. Executor picking off a pending item
Title: Message Title Oleg Nenashev updated an issue Jenkins / JENKINS-39454 Race condition in WorkUnitContext copying actions vs. Executor picking off a pending item Change By: Oleg Nenashev Labels: lts-candidate pipeline queue threads Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39454) Race condition in WorkUnitContext copying actions vs. Executor picking off a pending item
Title: Message Title Oleg Nenashev updated JENKINS-39454 Integrated towards 2.28 Jenkins / JENKINS-39454 Race condition in WorkUnitContext copying actions vs. Executor picking off a pending item Change By: Oleg Nenashev Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit
[JIRA] (JENKINS-39454) Race condition in WorkUnitContext copying actions vs. Executor picking off a pending item
Title: Message Title SCM/JIRA link daemon commented on JENKINS-39454 Re: Race condition in WorkUnitContext copying actions vs. Executor picking off a pending item Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/Executor.java core/src/main/java/hudson/model/Queue.java http://jenkins-ci.org/commit/jenkins/a57b52ec7e16d9b9985d6303e918aa6fdfa0a141 Log: [FIXED JENKINS-39454] Do not consider pendings when deciding whether a schedule result should be new or existing, as we have already taken a snapshot of actions. (#2609) Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39454) Race condition in WorkUnitContext copying actions vs. Executor picking off a pending item
Title: Message Title Jesse Glick updated JENKINS-39454 Jenkins / JENKINS-39454 Race condition in WorkUnitContext copying actions vs. Executor picking off a pending item Change By: Jesse Glick Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39454) Race condition in WorkUnitContext copying actions vs. Executor picking off a pending item
Title: Message Title Jesse Glick commented on JENKINS-39454 Re: Race condition in WorkUnitContext copying actions vs. Executor picking off a pending item pipeline-build-step PR 9 has a test for this. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39454) Race condition in WorkUnitContext copying actions vs. Executor picking off a pending item
Title: Message Title Jesse Glick created an issue Jenkins / JENKINS-39454 Race condition in WorkUnitContext copying actions vs. Executor picking off a pending item Issue Type: Bug Assignee: Jesse Glick Components: core Created: 2016/Nov/02 6:43 PM Labels: pipeline queue threads Priority: Major Reporter: Jesse Glick I found that under some timing conditions it could happen that a BuildableItem in the pendings list would be considered a duplication target by scheduleInternal. In other words, makePending is called—an executor is ready scheduleInternal is called on the same Task, and seeing this entry in pendings, considers it a duplicate (ScheduleResult.Existing) onStartExecuting is called Normally this would probably not matter. However the WorkUnitContext constructor is called right before makePending, and at this time it makes a (shallow) copy of the actions in the item. If scheduleInternal comes along later and finds some FoldableAction, foldIntoExisting will be called on an item whose action list has already been copied. So when the Executor copies the actions to the Executable, it will be copying the list as it existed prior to the foldIntoExisting call. If the foldIntoExisting implementation mutates an Action in place, as for example CauseAction does, this is generally OK because Executor will see the mutated object (let us hope the Action is thread-safe). But if the implementation adds a new action, the update will be silently ignored. The symptom that I saw was that
[JIRA] (JENKINS-39454) Race condition in WorkUnitContext copying actions vs. Executor picking off a pending item
Title: Message Title Jesse Glick started work on JENKINS-39454 Change By: Jesse Glick Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
