[JIRA] (JENKINS-39665) Unnecessary Scrollbars on build with parameters screen when using Active Choices Plugin
Title: Message Title Lubomir Stanko commented on JENKINS-39665 Re: Unnecessary Scrollbars on build with parameters screen when using Active Choices Plugin Hi Bruno P. Kinoshita, I've created another PR https://github.com/jenkinsci/active-choices-plugin/pull/22 . Now I'm setting height variable only for more than 10 choices. I suppose it is not necessary to set height for less than 10 choices. I believe most users have 3 to 5 choices. So at least these won't be affected by unnecessary scrollbars. Thanks, Lubo Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39665) Unnecessary Scrollbars on build with parameters screen when using Active Choices Plugin
Title: Message Title Bruno P. Kinoshita commented on JENKINS-39665 Re: Unnecessary Scrollbars on build with parameters screen when using Active Choices Plugin Hi Lubomir Stanko, Added comments to the pull request explaining why this approach would cause issues to other existing users of the plugin. Unfortunately I think we have to investigate other alternatives to workaround scroll bars or performance issues (or a completely different approach). But always thinking what will happen to other users Cheers Bruno Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39665) Unnecessary Scrollbars on build with parameters screen when using Active Choices Plugin
Title: Message Title Lubomir Stanko commented on JENKINS-39665 Re: Unnecessary Scrollbars on build with parameters screen when using Active Choices Plugin Bruno P. Kinoshita I've found some time to check and test it and I've created a pull request. Please check https://github.com/jenkinsci/active-choices-plugin/pull/21 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39665) Unnecessary Scrollbars on build with parameters screen when using Active Choices Plugin
Title: Message Title Bruno P. Kinoshita resolved as Won't Fix Tested the pull request, it would remove the scroll bar, but that would implicate a change in the plugin behavior that could cause issues to users with hundreds/thousands of options. Marking as won't fix. Jenkins / JENKINS-39665 Unnecessary Scrollbars on build with parameters screen when using Active Choices Plugin Change By: Bruno P. Kinoshita Status: Open Resolved Assignee: Bruno P. Kinoshita Resolution: Won't Fix Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
[JIRA] (JENKINS-39665) Unnecessary Scrollbars on build with parameters screen when using Active Choices Plugin
Title: Message Title Java Dev updated an issue Jenkins / JENKINS-39665 Unnecessary Scrollbars on build with parameters screen when using Active Choices Plugin Change By: Java Dev Environment: - Operating System: Ubuntu Server 14.04 LTS 64Bit- Jenkins Version: 2.20- Active Choices Plugin version: 1.40- Java(TM) SE Runtime Environment: (build 1.8.0_101-b13)- Not run in a container.- Debian install- Firefox 49.0.2- Chrome Version 54.0.2840.71 (64-bit) Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39665) Unnecessary Scrollbars on build with parameters screen when using Active Choices Plugin
Title: Message Title Java Dev created an issue Jenkins / JENKINS-39665 Unnecessary Scrollbars on build with parameters screen when using Active Choices Plugin Issue Type: Improvement Assignee: Unassigned Attachments: uno-choice-plugin.png Components: active-choices-plugin Created: 2016/Nov/11 8:37 AM Environment: - Operating System: Ubuntu Server 14.04 LTS 64Bit - Jenkins Version: 2.20 - Java(TM) SE Runtime Environment: (build 1.8.0_101-b13) - Not run in a container. - Debian install - Firefox 49.0.2 - Chrome Version 54.0.2840.71 (64-bit) Labels: scrollbar _javascript_ jenkins plugin Priority: Minor Reporter: Java Dev Adding an Active Choices Reactive Parameter with choice type of radio buttons or check boxes produces unnecessary scrollbars on the [build with parameters] screen (see attached image). Jenkins url is: https:// [ci_url] /job/ [job_name] /build?delay=0sec Height calculation in the _javascript_ function of checkboxContent.jelly and radioContent.jelly seems to create a height value which is too small. I have created a push request on GitHub with my own solution, should you choose to accept it.
