[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title Nikolas Falco closed an issue as Fixed Released in 1.0 Jenkins / JENKINS-40364 Support npm configuration file Change By: Nikolas Falco Status: Resolved Closed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title SCM/JIRA link daemon commented on JENKINS-40364 Re: Support npm configuration file Code changed in jenkins User: Nikolas Falco Path: src/main/resources/jenkins/plugins/nodejs/NodeJSBuildWrapper/config.jelly src/main/resources/jenkins/plugins/nodejs/NodeJSCommandInterpreter/config.jelly src/main/resources/lib/nodejs/select.jelly src/main/resources/lib/nodejs/taglib http://jenkins-ci.org/commit/nodejs-plugin/8d073ddaa1d3b34185ffdea9f2d22ad444c1438e Log: JENKINS-40364 Fix validation URL of configs combobox Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title SCM/JIRA link daemon resolved as Fixed Jenkins / JENKINS-40364 Support npm configuration file Change By: SCM/JIRA link daemon Status: In Progress Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title SCM/JIRA link daemon commented on JENKINS-40364 Re: Support npm configuration file Code changed in jenkins User: Nikolas Falco Path: pom.xml src/main/java/jenkins/plugins/nodejs/NodeJSBuildWrapper.java src/main/java/jenkins/plugins/nodejs/NodeJSCommandInterpreter.java src/main/java/jenkins/plugins/nodejs/NodeJSConstants.java src/main/java/jenkins/plugins/nodejs/NodeJSUtils.java src/main/java/jenkins/plugins/nodejs/configfiles/NPMConfig.java src/main/java/jenkins/plugins/nodejs/configfiles/NPMRegistry.java src/main/java/jenkins/plugins/nodejs/configfiles/Npmrc.java src/main/java/jenkins/plugins/nodejs/configfiles/RegistryHelper.java src/main/java/jenkins/plugins/nodejs/configfiles/VerifyConfigProviderException.java src/main/resources/jenkins/plugins/nodejs/Messages.properties src/main/resources/jenkins/plugins/nodejs/Messages_fr.properties src/main/resources/jenkins/plugins/nodejs/Messages_it.properties src/main/resources/jenkins/plugins/nodejs/NodeJSBuildWrapper/config.jelly src/main/resources/jenkins/plugins/nodejs/NodeJSBuildWrapper/config.properties src/main/resources/jenkins/plugins/nodejs/NodeJSBuildWrapper/config_it.properties src/main/resources/jenkins/plugins/nodejs/NodeJSCommandInterpreter/config.jelly src/main/resources/jenkins/plugins/nodejs/NodeJSCommandInterpreter/config.properties src/main/resources/jenkins/plugins/nodejs/NodeJSCommandInterpreter/config_it.properties src/main/resources/jenkins/plugins/nodejs/configfiles/NPMConfig/NPMConfigProvider/newInstanceDetail.jelly src/main/resources/jenkins/plugins/nodejs/configfiles/NPMConfig/NPMConfigProvider/newInstanceDetail.properties src/main/resources/jenkins/plugins/nodejs/configfiles/NPMConfig/edit-config.jelly src/main/resources/jenkins/plugins/nodejs/configfiles/NPMConfig/edit-config.properties src/main/resources/jenkins/plugins/nodejs/configfiles/NPMConfig/show-config.jelly src/main/resources/jenkins/plugins/nodejs/configfiles/NPMConfig/show-config.properties src/main/resources/jenkins/plugins/nodejs/configfiles/NPMRegistry/config.jelly src/main/resources/jenkins/plugins/nodejs/configfiles/NPMRegistry/config.properties src/main/resources/jenkins/plugins/nodejs/configfiles/NPMRegistry/help-credentialsId.html src/main/resources/jenkins/plugins/nodejs/configfiles/NPMRegistry/help-scopes.html src/main/resources/jenkins/plugins/nodejs/configfiles/NPMRegistry/help-url.html src/main/resources/jenkins/plugins/nodejs/configfiles/NPMRegistry/show.jelly src/main/resources/jenkins/plugins/nodejs/configfiles/NPMRegistry/show.properties src/main/resources/jenkins/plugins/nodejs/configfiles/template.npmrc src/test/java/jenkins/plugins/nodejs/NodeJSBuildWrapperTest.java src/test/java/jenkins/plugins/nodejs/NodeJSCommandInterpreterTest.java src/test/java/jenkins/plugins/nodejs/NpmrcFileSupplyTest.java src/test/java/jenkins/plugins/nodejs/configfiles/NPMConfigTest.java src/test/java/jenkins/plugins/nodejs/configfiles/NpmrcTest.java src/test/java/jenkins/plugins/nodejs/configfiles/RegistryHelperTest.java src/test/resources/jenkins/plugins/nodejs/configfiles/npmrc.config http://jenkins-ci.org/commit/nodejs-plugin/c1d918a2a3fb2224688aef0fe8a9426355718c5f Log: [FIX JENKINS-40364] Compare: https://github.com/jenkinsci/nodejs-plugin/compare/148305ef8c80...c1d918a2a3fb
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title SCM/JIRA link daemon commented on JENKINS-40364 Re: Support npm configuration file Code changed in jenkins User: Nikolas Falco Path: src/main/java/jenkins/plugins/nodejs/NodeJSBuildWrapper.java src/main/java/jenkins/plugins/nodejs/NodeJSCommandInterpreter.java src/main/java/jenkins/plugins/nodejs/NodeJSUtils.java src/main/java/jenkins/plugins/nodejs/configfiles/NPMConfig.java src/main/java/jenkins/plugins/nodejs/configfiles/NPMRegistry.java src/main/java/jenkins/plugins/nodejs/configfiles/NpmConfigException.java src/main/java/jenkins/plugins/nodejs/configfiles/Npmrc.java src/main/java/jenkins/plugins/nodejs/configfiles/RegistryHelper.java src/main/java/jenkins/plugins/nodejs/configfiles/VerifyConfigProviderException.java src/main/resources/jenkins/plugins/nodejs/Messages.properties src/main/resources/jenkins/plugins/nodejs/Messages_fr.properties src/main/resources/jenkins/plugins/nodejs/Messages_it.properties src/main/resources/jenkins/plugins/nodejs/NodeJSBuildWrapper/config.jelly src/main/resources/jenkins/plugins/nodejs/NodeJSCommandInterpreter/config.jelly src/main/resources/jenkins/plugins/nodejs/configfiles/NPMConfig/edit-config.properties src/main/resources/jenkins/plugins/nodejs/configfiles/NPMConfig/show-config.jelly src/main/resources/jenkins/plugins/nodejs/configfiles/NPMConfig/show-config.properties src/main/resources/jenkins/plugins/nodejs/configfiles/NPMRegistry/config.jelly src/main/resources/jenkins/plugins/nodejs/configfiles/NPMRegistry/config.properties src/main/resources/jenkins/plugins/nodejs/configfiles/NPMRegistry/show.jelly src/main/resources/jenkins/plugins/nodejs/configfiles/NPMRegistry/show.properties src/test/java/jenkins/plugins/nodejs/configfiles/NPMConfigTest.java src/test/java/jenkins/plugins/nodejs/configfiles/RegistryHelperTest.java http://jenkins-ci.org/commit/nodejs-plugin/e1be96774e55f618d8e9e96b9a84d7f6290872cd Log: JENKINS-40364 Fix jelly file in view mode, add a validation of selected config in the combobox that appears in the build step Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title SCM/JIRA link daemon commented on JENKINS-40364 Re: Support npm configuration file Code changed in jenkins User: Nikolas Falco Path: src/main/java/jenkins/plugins/nodejs/NodeJSBuildWrapper.java src/main/java/jenkins/plugins/nodejs/NodeJSCommandInterpreter.java src/main/java/jenkins/plugins/nodejs/NodeJSUtils.java src/main/java/jenkins/plugins/nodejs/configfiles/NPMConfig.java src/main/java/jenkins/plugins/nodejs/configfiles/NPMRegistry.java src/main/java/jenkins/plugins/nodejs/configfiles/NpmConfigException.java src/main/java/jenkins/plugins/nodejs/configfiles/Npmrc.java src/main/java/jenkins/plugins/nodejs/configfiles/RegistryHelper.java src/main/java/jenkins/plugins/nodejs/configfiles/VerifyConfigProviderException.java src/main/resources/jenkins/plugins/nodejs/Messages.properties src/main/resources/jenkins/plugins/nodejs/Messages_fr.properties src/main/resources/jenkins/plugins/nodejs/Messages_it.properties src/main/resources/jenkins/plugins/nodejs/NodeJSBuildWrapper/config.jelly src/main/resources/jenkins/plugins/nodejs/NodeJSCommandInterpreter/config.jelly src/main/resources/jenkins/plugins/nodejs/configfiles/NPMConfig/edit-config.properties src/main/resources/jenkins/plugins/nodejs/configfiles/NPMConfig/show-config.jelly src/main/resources/jenkins/plugins/nodejs/configfiles/NPMConfig/show-config.properties src/main/resources/jenkins/plugins/nodejs/configfiles/NPMRegistry/config.jelly src/main/resources/jenkins/plugins/nodejs/configfiles/NPMRegistry/config.properties src/main/resources/jenkins/plugins/nodejs/configfiles/NPMRegistry/show.jelly src/main/resources/jenkins/plugins/nodejs/configfiles/NPMRegistry/show.properties src/test/java/jenkins/plugins/nodejs/configfiles/NPMConfigTest.java src/test/java/jenkins/plugins/nodejs/configfiles/RegistryHelperTest.java http://jenkins-ci.org/commit/nodejs-plugin/e541cfe29d2e30ef20e708fda4d8a11df948 Log: JENKINS-40364 Fix jelly file in view mode, add a validation of selected config in the combobox that appears in the build step Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title Nikolas Falco edited a comment on JENKINS-40364 Re: Support npm configuration file Thanks very much to you for support. I will release actual implementations and than will update to when new API be available I will change it . Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title Nikolas Falco commented on JENKINS-40364 Re: Support npm configuration file Thanks very much to you for support. I will release actual implementations and than will update to new API. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title Dominik Bartholdi commented on JENKINS-40364 Re: Support npm configuration file ok, I think I understand now... 1. I think thats a good idea! (and thanks for the hint about the maven settings being editable!) 2. this also is a very nice idea so both are cool ideas - but if you want to have this, then you have to wait for an upcoming release of the config-file-provider - I'm not sure when I will have time to implement this. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title
Nikolas Falco edited a comment on JENKINS-40364
Re: Support npm configuration file
# I got it. I've fixedJust a question: your edit-config.jelly files includes a page named _id-name-and-comment_ for the common attributes but from what I can see instead for show-config.jelly file common fields are rewritten from scratch (with readonly attribute). What do you think to create a common page also for view mode? so for example translations are inherited or changes to the base page will be reported to all extension point for free. (Please note that in 2.15.5 server credentials of maven settings in view mode are editable)# I mean imagine that a user creates 10 new configuration and 50% of them are not valid. When user will configure the NodeJS step in a jenkins job he will see only 5 configuration in the combobox, not 10. How can user understand that missing configuration in combobox is becuase configuration are not valid and not a plugin bug?I have resolved doing a select widget (a dirty html/css work) that invoke a doCheckXyz method on Build descriptor delegating the task of verification on Config implementation. !config-file-validation.png|thumbnail! Could I suggest:* +implement a custom select jelly widget (like that credential plugin) to facilitate integrations of configuration in custom build step/wrapper a sort of+{code:xml} {code}* add a verify method on Config base class (by default empty {} ) so each implementation could have an own logic (for example XML/JSON check well-formed) and this The verify method is on the "interface" and could be also used to validate the content during _supplyFile_ method after token replace. This reduce user analisys on build failure. Keept in mind that in this way we could enforce the same failure behavior when the configuration file is handled directly by a custom build step (like maven or NodeJS) or ConfigFileBuildWrapper is used.
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title
Nikolas Falco commented on JENKINS-40364
Re: Support npm configuration file
I got it. I've fixed Just a question: your edit-config.jelly files includes a page named id-name-and-comment for the common attributes but from what I can see instead for show-config.jelly file common fields are rewritten from scratch (with readonly attribute). What do you think to create a common page also for view mode? so for example translations are inherited or changes to the base page will be reported to all extension point for free. (Please note that in 2.15.5 server credentials of maven settings in view mode are editable)
I mean imagine that a user creates 10 new configuration and 50% of them are not valid. When user will configure the NodeJS step in a jenkins job he will see only 5 configuration in the combobox, not 10. How can user understand that missing configuration in combobox is becuase configuration are not valid and not a plugin bug? I have resolved doing a select widget (a dirty html/css work) that invoke a doCheckXyz method on Build descriptor delegating the task of verification on Config implementation.
Could I suggest:
implement a custom select jelly widget (like that credential plugin) to facilitate integrations of configuration in custom build step/wrapper a sort of
xmlns:cf="/lib/configfiles">
"${%Config File}" field="configId">
"${descriptor.class}" allowEmpty="true" />
add a verify method on Config base class (by default empty {} ) so each implementation could have an own logic (for example XML/JSON check well-formed) and this method is on the "interface" and could be also used to validate the content during supplyFile method after token replace. This reduce user analisys on build failure.
Add Comment
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title Nikolas Falco updated an issue Jenkins / JENKINS-40364 Support npm configuration file Change By: Nikolas Falco Attachment: config-file-validation.png Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title Dominik Bartholdi commented on JENKINS-40364 Re: Support npm configuration file 1. view.jelly is used when you enable "Provide Configuration files" in "Build environment" and add a new file and click "view selected file":2. yes only show valid configurations in the dropdown - only npmrc config files. ...I don't understand your question: "In this case how does user understand that configuration is wrong instead a bug of plugin?" Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title Dominik Bartholdi updated an issue Jenkins / JENKINS-40364 Support npm configuration file Change By: Dominik Bartholdi Attachment: Screen Shot 2017-01-21 at 20.28.14.png Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title Dominik Bartholdi commented on JENKINS-40364 Re: Support npm configuration file Nikolas Falco 2.15.5 fixes this an was released 2 or 3 days ago Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title Dominik Bartholdi updated an issue Jenkins / JENKINS-40364 Support npm configuration file Change By: Dominik Bartholdi Comment: [~nfalco] 2.15.5 fixes this an was released 2 or 3 days ago Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title SCM/JIRA link daemon commented on JENKINS-40364 Re: Support npm configuration file Code changed in jenkins User: Nikolas Falco Path: pom.xml src/main/java/jenkins/plugins/nodejs/NodeJSBuildWrapper.java src/main/java/jenkins/plugins/nodejs/NodeJSCommandInterpreter.java http://jenkins-ci.org/commit/nodejs-plugin/150d9422252a4d8ef196e6f4bc37e30f8cecf5a6 Log: JENKINS-40364 Move config-file-plugin to 2.15.5 and remove use of deprecated methods. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title Nikolas Falco commented on JENKINS-40364 Re: Support npm configuration file release must be posticipate to depends on the minimun working version of this config-file plugin Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title Nikolas Falco assigned an issue to Nikolas Falco Jenkins / JENKINS-40364 Support npm configuration file Change By: Nikolas Falco Assignee: Nikolas Falco Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title Nikolas Falco commented on JENKINS-40364 Re: Support npm configuration file Dominik Bartholdi I have a severe issue with 2.15.4 (2.13 works), when I create a new config file it is persistend fine but any chages on that configuration is no more persisted. This issue does not happens only on my custom configuration but also with other files. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title SCM/JIRA link daemon commented on JENKINS-40364 Re: Support npm configuration file Code changed in jenkins User: Nikolas Falco Path: pom.xml src/main/java/jenkins/plugins/nodejs/configfiles/NpmConfigException.java src/main/java/jenkins/plugins/nodejs/configfiles/RegistryHelper.java src/test/java/jenkins/plugins/nodejs/NodeJSBuildWrapperTest.java src/test/java/jenkins/plugins/nodejs/NpmrcFileSupplyTest.java src/test/java/jenkins/plugins/nodejs/configfiles/RegistryHelperTest.java http://jenkins-ci.org/commit/nodejs-plugin/923a5569d04c248fade40825b2cd9bb2fbe9dc34 Log: JENKINS-40364 Add other test cases, add validation to have only one global registry in configuration file. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title Nikolas Falco commented on JENKINS-40364 Re: Support npm configuration file Dominik Bartholdi thanks for short answer. About first question I did not intent how to test by junit, but how I could see the view mode of a configuration. I had try enable security, add a new configuration with admin, but no way other users could access in manage jenkins to see the configured files. Which is the use case when the view.jelly is invoked? 2) Actually in the job configuration when you choose NodeJS step there is a combo box to choose the configuration file (like maven does for global and settings.xml) Do you mean propose in the combobox only valid configuration? In this case how does user understand that configuration is wrong instead a bug of plugin? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title Nikolas Falco updated an issue Jenkins / JENKINS-40364 Support npm configuration file Change By: Nikolas Falco Attachment: build-step.png Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title Dominik Bartholdi commented on JENKINS-40364 Re: Support npm configuration file Nikolas Falco 1. here is an example of a configuration roundtrip: https://wiki.jenkins-ci.org/display/JENKINS/Unit+Test#UnitTest-Configurationroundtriptesting 2. why don't you make the first field a dropdown and use doFillXXXItems - have a look at https://github.com/jenkinsci/config-file-provider-plugin/blob/master/src/main/java/org/jenkinsci/plugins/configfiles/maven/job/MvnSettingsProvider.java#L137-L144 ) This way the user can only select configs from the correct type. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title Nikolas Falco commented on JENKINS-40364 Re: Support npm configuration file Thanks Dominik Bartholdi for availability. I've complete task a week ago and I'm just write test cases. But I have two question for you: How test the jellys view of configuration files? Is it possible implement a doCheck method of config file descriptor to disable submit button until (FormValidation?) is ok? The reason I would check that only a NPM registry could be set as global (a.k.a. without any scope). I know that I could check anything using _javascript_ but I would avoid that. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title Nikolas Falco updated an issue Jenkins / JENKINS-40364 Support npm configuration file Change By: Nikolas Falco Attachment: config page.png Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title Dominik Bartholdi commented on JENKINS-40364 Re: Support npm configuration file Nikolas Falco do you need an help form my site? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title SCM/JIRA link daemon commented on JENKINS-40364 Re: Support npm configuration file Code changed in jenkins User: Nikolas Falco Path: src/main/java/jenkins/plugins/nodejs/NodeJSConstants.java src/main/java/jenkins/plugins/nodejs/configfiles/Npmrc.java src/main/java/jenkins/plugins/nodejs/configfiles/RegistryHelper.java src/test/java/jenkins/plugins/nodejs/configfiles/NPMConfigTest.java src/test/java/jenkins/plugins/nodejs/configfiles/RegistryHelperTest.java http://jenkins-ci.org/commit/nodejs-plugin/c6440a8919db6e505b2422692d444a09ec3ac8c8 Log: JENKINS-40364 Add some npm settings to constants and some test cases. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title SCM/JIRA link daemon commented on JENKINS-40364 Re: Support npm configuration file Code changed in jenkins User: Nikolas Falco Path: pom.xml src/main/java/jenkins/plugins/nodejs/NodeJSUtils.java src/main/java/jenkins/plugins/nodejs/configfiles/NPMConfig.java src/main/java/jenkins/plugins/nodejs/configfiles/NPMRegistry.java src/main/java/jenkins/plugins/nodejs/configfiles/Npmrc.java src/main/java/jenkins/plugins/nodejs/configfiles/RegistryHelper.java src/test/java/jenkins/plugins/nodejs/configfiles/NpmrcTest.java http://jenkins-ci.org/commit/nodejs-plugin/96154b81396b3bb74b5d3b5914ceb53edbdb5560 Log: JENKINS-40364 Update to config-file-provider 2.15 version and some javadoc. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title SCM/JIRA link daemon commented on JENKINS-40364 Re: Support npm configuration file Code changed in jenkins User: Nikolas Falco Path: pom.xml src/main/java/jenkins/plugins/nodejs/NodeJSUtils.java src/main/java/jenkins/plugins/nodejs/configfiles/NPMConfig.java src/main/java/jenkins/plugins/nodejs/configfiles/NPMRegistry.java src/main/java/jenkins/plugins/nodejs/configfiles/Npmrc.java src/main/java/jenkins/plugins/nodejs/configfiles/RegistryHelper.java src/test/java/jenkins/plugins/nodejs/configfiles/NpmrcTest.java http://jenkins-ci.org/commit/nodejs-plugin/d518e3b20fe823504b005ff83bebea524a893674 Log: JENKINS-40364 Update to config-file-provider 2.15 version and some javadoc. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title Dominik Bartholdi edited a comment on JENKINS-40364 Re: Support npm configuration file Version 2.13 of the config-file-provider is not a good base to start a new integration, you must use the newest one `2.15.4`. A lot of the API got changed and no backward compatibility is provided... You rather implement everything on the most recent version and then we take it from there. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title Dominik Bartholdi commented on JENKINS-40364 Re: Support npm configuration file Version 2.13 of the config-file-provider is not a good base to start a new integration, you must use the newest one `2.15.4`. A lot of the API got changed and no backward compatibility is provided... Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title Nikolas Falco commented on JENKINS-40364 Re: Support npm configuration file Miss only test cases. I have implement against config-file-plugin 2.13 becuase initially with latest version 2.15.3 fails render config jelly files. If do you have free time any option will be appreciated. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title Nikolas Falco started work on JENKINS-40364 Change By: Nikolas Falco Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title SCM/JIRA link daemon commented on JENKINS-40364 Re: Support npm configuration file Code changed in jenkins User: Nikolas Falco Path: pom.xml src/main/java/jenkins/plugins/nodejs/NodeJSBuildWrapper.java src/main/java/jenkins/plugins/nodejs/NodeJSCommandInterpreter.java src/main/java/jenkins/plugins/nodejs/NodeJSConstants.java src/main/java/jenkins/plugins/nodejs/NodeJSUtils.java src/main/java/jenkins/plugins/nodejs/configfiles/NPMConfig.java src/main/java/jenkins/plugins/nodejs/configfiles/NPMRegistry.java src/main/java/jenkins/plugins/nodejs/configfiles/Npmrc.java src/main/java/jenkins/plugins/nodejs/configfiles/RegistryHelper.java src/main/resources/jenkins/plugins/nodejs/Messages.properties src/main/resources/jenkins/plugins/nodejs/Messages_fr.properties src/main/resources/jenkins/plugins/nodejs/Messages_it.properties src/main/resources/jenkins/plugins/nodejs/NodeJSBuildWrapper/config.jelly src/main/resources/jenkins/plugins/nodejs/NodeJSBuildWrapper/config.properties src/main/resources/jenkins/plugins/nodejs/NodeJSBuildWrapper/config_it.properties src/main/resources/jenkins/plugins/nodejs/NodeJSCommandInterpreter/config.jelly src/main/resources/jenkins/plugins/nodejs/NodeJSCommandInterpreter/config.properties src/main/resources/jenkins/plugins/nodejs/NodeJSCommandInterpreter/config_it.properties src/main/resources/jenkins/plugins/nodejs/configfiles/NPMConfig/NPMConfigProvider/newInstanceDetail.jelly src/main/resources/jenkins/plugins/nodejs/configfiles/NPMConfig/NPMConfigProvider/newInstanceDetail.properties src/main/resources/jenkins/plugins/nodejs/configfiles/NPMConfig/edit-config.jelly src/main/resources/jenkins/plugins/nodejs/configfiles/NPMConfig/edit-config.properties src/main/resources/jenkins/plugins/nodejs/configfiles/NPMConfig/show-config.jelly src/main/resources/jenkins/plugins/nodejs/configfiles/NPMConfig/show-config.properties src/main/resources/jenkins/plugins/nodejs/configfiles/NPMRegistry/config.jelly src/main/resources/jenkins/plugins/nodejs/configfiles/NPMRegistry/config.properties src/main/resources/jenkins/plugins/nodejs/configfiles/NPMRegistry/help-credentialsId.html src/main/resources/jenkins/plugins/nodejs/configfiles/NPMRegistry/help-scopes.html src/main/resources/jenkins/plugins/nodejs/configfiles/NPMRegistry/help-url.html src/main/resources/jenkins/plugins/nodejs/configfiles/template.npmrc src/test/java/jenkins/plugins/nodejs/NodeJSCommandInterpreterTest.java src/test/java/jenkins/plugins/nodejs/configfiles/NpmrcTest.java src/test/resources/jenkins/plugins/nodejs/configfiles/npmrc.config http://jenkins-ci.org/commit/nodejs-plugin/fe659812fc054b4edeb03c336802ab824b43fd64 Log: JENKINS-40364 Implement the config-files extension point to enhance the npmrc user config file to handle NPM registries, scope and credentials. Builder generate the configuration file and delete it when finish. Add Comment
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title SCM/JIRA link daemon commented on JENKINS-40364 Re: Support npm configuration file Code changed in jenkins User: Nikolas Falco Path: pom.xml src/main/java/jenkins/plugins/nodejs/NodeJSBuildWrapper.java src/main/java/jenkins/plugins/nodejs/NodeJSCommandInterpreter.java src/main/java/jenkins/plugins/nodejs/NodeJSConstants.java src/main/java/jenkins/plugins/nodejs/NodeJSUtils.java src/main/java/jenkins/plugins/nodejs/configfiles/NPMConfig.java src/main/java/jenkins/plugins/nodejs/configfiles/NPMRegistry.java src/main/java/jenkins/plugins/nodejs/configfiles/Npmrc.java src/main/java/jenkins/plugins/nodejs/configfiles/RegistryHelper.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstallation.java src/main/resources/jenkins/plugins/nodejs/Messages.properties src/main/resources/jenkins/plugins/nodejs/Messages_fr.properties src/main/resources/jenkins/plugins/nodejs/Messages_it.properties src/main/resources/jenkins/plugins/nodejs/NodeJSBuildWrapper/config.jelly src/main/resources/jenkins/plugins/nodejs/NodeJSBuildWrapper/config.properties src/main/resources/jenkins/plugins/nodejs/NodeJSBuildWrapper/config_it.properties src/main/resources/jenkins/plugins/nodejs/NodeJSCommandInterpreter/config.jelly src/main/resources/jenkins/plugins/nodejs/NodeJSCommandInterpreter/config.properties src/main/resources/jenkins/plugins/nodejs/NodeJSCommandInterpreter/config_it.properties src/main/resources/jenkins/plugins/nodejs/configfiles/NPMConfig/NPMConfigProvider/newInstanceDetail.jelly src/main/resources/jenkins/plugins/nodejs/configfiles/NPMConfig/NPMConfigProvider/newInstanceDetail.properties src/main/resources/jenkins/plugins/nodejs/configfiles/NPMConfig/edit-config.jelly src/main/resources/jenkins/plugins/nodejs/configfiles/NPMConfig/edit-config.properties src/main/resources/jenkins/plugins/nodejs/configfiles/NPMConfig/show-config.jelly src/main/resources/jenkins/plugins/nodejs/configfiles/NPMConfig/show-config.properties src/main/resources/jenkins/plugins/nodejs/configfiles/NPMRegistry/config.jelly src/main/resources/jenkins/plugins/nodejs/configfiles/NPMRegistry/config.properties src/main/resources/jenkins/plugins/nodejs/configfiles/NPMRegistry/help-credentialsId.html src/main/resources/jenkins/plugins/nodejs/configfiles/NPMRegistry/help-scopes.html src/main/resources/jenkins/plugins/nodejs/configfiles/NPMRegistry/help-url.html src/main/resources/jenkins/plugins/nodejs/configfiles/template.npmrc src/main/resources/jenkins/plugins/nodejs/tools/NodeJSInstaller/config.jelly src/test/java/jenkins/plugins/nodejs/NodeJSCommandInterpreterTest.java src/test/java/jenkins/plugins/nodejs/configfiles/NpmrcTest.java src/test/resources/jenkins/plugins/nodejs/configfiles/npmrc.config http://jenkins-ci.org/commit/nodejs-plugin/20b82f13f2b7e4d2a559d460b9014c911dec09d1 Log: JENKINS-40364 Implement the config-files extension point to enhance the npmrc user config file to handle NPM registries, scope and credentials. Builder generate the configuration file and delete it when finish.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title Nikolas Falco commented on JENKINS-40364 Re: Support npm configuration file Ok, great. I Will have a look into a short Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title
Cyrille Le Clerc commented on JENKINS-40364
Re: Support npm configuration file
Notes:
we could specify the npm config file location using the npm_config_userconfig environment variable
https://docs.npmjs.com/misc/config#userconfig
https://docs.npmjs.com/misc/config#environment-variables
Any environment variables that start with npm_config_ will be interpreted as a configuration parameter. For example, putting npm_config_foo=bar in your environment will set the foo configuration parameter to bar. Any environment configurations that are not given a value will be given the value of true. Config values are case-insensitive, so NPM_CONFIG_FOO=bar will work the same.
The "_auth" field expects base64("$username:$password")
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title
Dominik Bartholdi edited a comment on JENKINS-40364
Re: Support npm configuration file
for everyone interested in implementing this: this is an extension point that should be implemented in the nodejs plugin. {{org.jenkinsci.lib.configprovider.AbstractConfigProviderImpl}} e.g. take a look at {{org.jenkinsci.plugins.configfiles.json.JsonConfig}} https://github.com/jenkinsci/config-file-provider-plugin/blob/master/src/main/java/org/jenkinsci/plugins/configfiles/json/JsonConfig.java
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title Dominik Bartholdi commented on JENKINS-40364 Re: Support npm configuration file for everyone interested in implementing this: this is an extension point that should be implemented in the nodejs plugin. org.jenkinsci.lib.configprovider.AbstractConfigProviderImpl e.g. take a look at org.jenkinsci.plugins.configfiles.json.JsonConfig Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title Dominik Bartholdi assigned an issue to Unassigned Jenkins / JENKINS-40364 Support npm configuration file Change By: Dominik Bartholdi Assignee: Dominik Bartholdi Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40364) Support npm configuration file
Title: Message Title Nikolas Falco created an issue Jenkins / JENKINS-40364 Support npm configuration file Issue Type: New Feature Assignee: Dominik Bartholdi Components: config-file-provider-plugin, nodejs-plugin Created: 2016/Dec/11 6:02 PM Priority: Major Reporter: Nikolas Falco Hi, to make easier configure nodejs installations across multiple node and setup them to an internal nodejs.org repository would be great add support to the npm config file. The npm config file is an ini file but with only one single section. https://docs.npmjs.com/files/npmrc This config file will take advantage of credential support to configure authentication in case of internal npm repository. That I know, npm does not have an option where you could specify in the CLI the npmrc file, but there are four relevant places where this file is lookup. It's also possible transform each settings into enviroment variable or in a CLI option. https://docs.npmjs.com/misc/config Add Comment
